Re: Unified logging system for command-line programs

2018-12-31 Thread Alvaro Herrera
On 2018-Dec-30, Tom Lane wrote: > Peter Eisentraut writes: > > I have developed a patch that unifies the various ad hoc logging > > (message printing, error printing) systems used throughout the > > command-line programs. > > I've not read the patch in any detail, but +1 for making this more >

Re: Unified logging system for command-line programs

2018-12-31 Thread Andres Freund
Hi, On 2018-12-30 14:45:23 -0500, Tom Lane wrote: > I wonder how hard it would be to layer some subset of > ereport() functionality on top of what you have here, so as to get > rid of those #ifdef stanzas. +many. I think we should aim to unify the use (in contrast to the implementation) of

Re: Add timeline to partial WAL segments

2018-12-31 Thread David Steele
On 12/21/18 2:10 AM, Michael Paquier wrote: On Thu, Dec 20, 2018 at 02:13:01PM +0200, David Steele wrote: Or perhaps just always add the timeline to the .partial? That way it doesn't need to be renamed later. Also, there would be a consistent name, rather than sometimes .partial, sometimes

Re: [HACKERS] proposal: schema variables

2018-12-31 Thread Erik Rijkers
On 2018-12-31 14:23, Pavel Stehule wrote: st 21. 11. 2018 v 8:24 odesílatel Pavel Stehule [schema-variables-20181231-01.patch.gz] Hi Pavel, I gave this a quick try-out with the script I had from previous versions, and found these two errors: drop schema if exists schema1

Re: Is MinMaxExpr really leakproof?

2018-12-31 Thread Tom Lane
Noah Misch writes: > This thread duplicates > https://postgr.es/m/flat/16539.1431472961%40sss.pgh.pa.us Ah, so it does. Not sure why that fell off the radar without getting fixed; possibly because it was right before PGCon. > pg_lsn_cmp() and btoidvectorcmp() surely could advertise

[PATCH] check for ctags utility in make_ctags

2018-12-31 Thread Nikolay Shaplov
Hi! I'd like to propose a small patch for make_ctags script. It checks if ctags utility is intalled or not. If not it reports an error and advises to install ctags. This will make life of a person that uses ctags first time in his life a bit easier. I use command -v to detect if ctags

Re: Error while executing initdb...

2018-12-31 Thread David Rowley
On Mon, 31 Dec 2018 at 17:43, Rajib Deb wrote: > > Dear All > I put a printf statement in the "main.c" code and built it. Later when I > tried to execute INITDB, I got the following error > > The program "postgres" was found by but was not the same version as > initdb.Check your

Re: add_partial_path() may remove dominated path but still in use

2018-12-31 Thread Amit Kapila
On Mon, Dec 31, 2018 at 5:48 PM Kohei KaiGai wrote: > > 2018年12月31日(月) 13:10 Amit Kapila : > > > > On Sun, Dec 30, 2018 at 9:01 AM Kohei KaiGai wrote: > > > 2018年12月30日(日) 4:12 Tom Lane : > > > > > > > > Kohei KaiGai writes: > > > > > 2018年12月29日(土) 1:44 Tom Lane : > > > > >> However, first I'd

Re: [HACKERS] proposal: schema variables

2018-12-31 Thread Pavel Stehule
st 21. 11. 2018 v 8:24 odesílatel Pavel Stehule napsal: > Hi > > just rebase > > rebase Regards Pavel > > Regards > > Pavel > schema-variables-20181231-01.patch.gz Description: application/gzip

Re: [PATCH] check for ctags utility in make_ctags

2018-12-31 Thread Nikolay Shaplov
В письме от понедельник, 31 декабря 2018 г. 19:04:08 MSK пользователь Nikolay Shaplov написал: > I'd like to propose a small patch for make_ctags script. It checks if ctags > utility is intalled or not. If not it reports an error and advises to > install ctags. Oups. I've misplaced '&' character

Re: Implementing Incremental View Maintenance

2018-12-31 Thread Adam Brusselback
Hi all, just wanted to say I am very happy to see progress made on this, my codebase has multiple "materialized tables" which are maintained with statement triggers (transition tables) and custom functions. They are ugly and a pain to maintain, but they work because I have no other solution...for

Re: Is MinMaxExpr really leakproof?

2018-12-31 Thread Noah Misch
This thread duplicates https://postgr.es/m/flat/16539.1431472961%40sss.pgh.pa.us On Sun, Dec 30, 2018 at 01:24:02PM -0500, Tom Lane wrote: > So this coding amounts to an undocumented > assumption that every non-cross-type btree comparison function is > leakproof. > select p.oid::regprocedure

Re: Is MinMaxExpr really leakproof?

2018-12-31 Thread Tom Lane
Isaac Morland writes: > On Mon, 31 Dec 2018 at 12:26, Noah Misch wrote: >> bttextcmp() and other varstr_cmp() callers fall afoul of the same >> restriction with their "could not convert string to UTF-16" errors > I'm confused. What characters cannot be represented in UTF-16? What's actually

Re: Implementing Incremental View Maintenance

2018-12-31 Thread denty
Hi Yugo. > I would like to implement Incremental View Maintenance (IVM) on > PostgreSQL. Great. :-) I think it would address an important gap in PostgreSQL’s feature set. > 2. How to compute the delta to be applied to materialized views > > Essentially, IVM is based on relational algebra.

Re: Is MinMaxExpr really leakproof?

2018-12-31 Thread Andrew Gierth
> "Tom" == Tom Lane writes: >> bttextcmp() and other varstr_cmp() callers fall afoul of the same >> restriction with their "could not convert string to UTF-16" errors >> (https://postgr.es/m/CADyhKSXPwrUv%2B9LtqPAQ_gyZTv4hYbr2KwqBxcs6a3Vee1jBLQ%40mail.gmail.com). >> Leaking the binary

Re: slight tweaks to documentation about runtime pruning

2018-12-31 Thread David Rowley
On Tue, 18 Dec 2018 at 03:49, Alvaro Herrera wrote: > Pushed, thanks. I just noticed that this is still open on the CF app. Marking as committed... -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services

Re: Unified logging system for command-line programs

2018-12-31 Thread Alvaro Herrera
Ah, one more thing -- there's a patch by Marina Polyakova (in CC) to make pgbench logging more regular. Maybe that stuff should be considered now too. I'm not saying to patch pgbench in this commit, but rather to have pgbench in mind while discussing the API. I think the last version of that

pg11.1: dsa_area could not attach to segment

2018-12-31 Thread Justin Pryzby
In our query logs I saw: postgres=# SELECT log_time, session_id, session_line, left(message,99), left(query,99) FROM postgres_log WHERE error_severity='ERROR' AND message NOT LIKE 'cancel%'; -[ RECORD 1

Re: Removing --disable-strong-random from the code

2018-12-31 Thread Michael Paquier
On Mon, Dec 31, 2018 at 10:20:28AM +0900, Michael Paquier wrote: > On Sun, Dec 30, 2018 at 11:47:03AM -0500, Tom Lane wrote: >> Not the fault of this patch, but surely this bit in pgcrypto's >> pad_eme_pkcs1_v15() >> >> if (!pg_strong_random((char *) p, 1)) >> { >>

Re: Early WIP/PoC for inlining CTEs

2018-12-31 Thread Andrew Gierth
> "Andreas" == Andreas Karlsson writes: Andreas> + if (rte->rtekind == RTE_CTE && Andreas> + strcmp(rte->ctename, context->ctename) == 0 && Andreas> + rte->ctelevelsup == context->levelsup) Andreas> + { Andreas> + Query *newquery = copyObject(context->ctequery);

Re: Offline enabling/disabling of data checksums

2018-12-31 Thread Michael Paquier
On Sat, Dec 29, 2018 at 11:55:43AM +0100, Michael Banck wrote: > Renaming applications shouldn't be a problem unless they have to be > moved from one binary package to another. I assume all packagers ship > all client/server binaries in one package, respectively (and not e.g. a > dedicated

Re: Implementing Incremental View Maintenance

2018-12-31 Thread Nguyễn Trần Quốc Vinh
Dear all, We have some result on incremental update for MVs. We generate triggers on C to do the incremental maintenance. We posted the code to github about 1 year ago, but unfortunately i posted a not-right ctrigger.h header. The mistake was exposed to me when a person could not compile the

Re: [HACKERS] REINDEX CONCURRENTLY 2.0

2018-12-31 Thread Andrew Gierth
> "Alvaro" == Alvaro Herrera writes: Alvaro> After looking at the proposed grammar again today and in danger Alvaro> of repeating myself, IMO allowing the concurrency keyword to Alvaro> appear outside the parens would be a mistake. Valid commands: Alvaro> REINDEX (VERBOSE,

Re: monitoring CREATE INDEX [CONCURRENTLY]

2018-12-31 Thread Alvaro Herrera
For discussion, here's an preliminary patch. This is just a first skeleton; needs to grow a lot of flesh yet, per my previous proposal. As far as the generic CREATE INDEX stuff goes, I think this is complete; it's missing the AM-specific bits. -- Álvaro Herrera

Re: Changing SQL Inlining Behaviour (or...?)

2018-12-31 Thread Adam Brightwell
All, > So, context: > > - We want PostGIS to parallelize more. In order to achieve that we need to > mark our functions with more realistic COSTs. Much much higher COSTs. > - When we do that, we hit a different problem. Our most commonly used > functions, ST_Intersects(), ST_DWithin() are

Re: Joins on TID

2018-12-31 Thread Edmund Horner
On Sat, 22 Dec 2018 at 12:34, Tom Lane wrote: > I decided to spend an afternoon seeing exactly how much work would be > needed to support parameterized TID scans, ie nestloop-with-inner-TID- > scan joins, as has been speculated about before, most recently here: > >

Re: [HACKERS] REINDEX CONCURRENTLY 2.0

2018-12-31 Thread Alvaro Herrera
On 2018-Dec-14, Stephen Frost wrote: > > My vote goes to put the keyword inside of and exclusively in the > > parenthesized option list. > > I disagree with the idea of exclusively having concurrently be in the > parentheses. 'explain buffers' is a much less frequently used option > (though

Re: Early WIP/PoC for inlining CTEs

2018-12-31 Thread Andrew Gierth
> "Andreas" == Andreas Karlsson writes: Andreas> I believe I have fixed these except for the comment on the Andreas> conditions for when we inline. Andreas> Andrew Gierth: Why did you chose to not inline on FOR UPDATE Andreas> but inline volatile functions? I feel that this might be

Re: Clean up some elog messages and comments for do_pg_stop_backup and do_pg_start_backup

2018-12-31 Thread Michael Paquier
On Mon, Dec 31, 2018 at 10:50:20AM +0100, Peter Eisentraut wrote: > I like this version of the patch. OK, committed. Thanks all for the discussion. -- Michael signature.asc Description: PGP signature

Re: rewrite ExecPartitionCheckEmitError

2018-12-31 Thread David Rowley
On Sat, 29 Dec 2018 at 06:52, Alvaro Herrera wrote: > Point taken; pushed with that change. Marking this as committed in the CF app. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services

Implicit make rules break test examples

2018-12-31 Thread Donald Dong
Hi, In src/test/example, the implicit make rules produce errors: make -C ../../../src/backend generated-headers make[1]: Entering directory '/home/ddong/postgresql/bld/src/backend' make -C catalog distprep generated-header-symlinks make[2]: Entering directory

Re: Implicit make rules break test examples

2018-12-31 Thread Donald Dong
On Mon, Dec 31, 2018 at 11:24 PM Donald Dong wrote: > > Hi, > > In src/test/example, the implicit make rules produce errors: > > make -C ../../../src/backend generated-headers > make[1]: Entering directory '/home/ddong/postgresql/bld/src/backend' > make -C catalog distprep

Re: pg_regress: promptly detect failed postmaster startup

2018-12-31 Thread Tom Lane
Noah Misch writes: > When "make check TEMP_CONFIG=<(echo break_me=on)" spawns a postmaster that > fails startup, we detect that with "pg_regress: postmaster did not respond > within 60 seconds". pg_regress has a kill(postmaster_pid, 0) intended to > detect this case faster. Since

Re: Early WIP/PoC for inlining CTEs

2018-12-31 Thread Andreas Karlsson
On 11/16/18 10:15 PM, Tom Lane wrote: > I took a little bit of a look through this. Some thoughts: Thanks for the review! I have decided to pick up this patch and work on it since nothing has happened in a while. Here is a new version with most of the feedback fixed. * This is not the

Re: [PATCH] check for ctags utility in make_ctags

2018-12-31 Thread Michael Paquier
On Mon, Dec 31, 2018 at 07:19:39PM +0300, Nikolay Shaplov wrote: > В письме от понедельник, 31 декабря 2018 г. 19:04:08 MSK пользователь Nikolay > Shaplov написал: > >> I'd like to propose a small patch for make_ctags script. It checks if ctags >> utility is intalled or not. If not it reports an

Re: Clean up some elog messages and comments for do_pg_stop_backup and do_pg_start_backup

2018-12-31 Thread Michael Paquier
On Sun, Dec 30, 2018 at 02:50:46PM +0900, Michael Paquier wrote: > A personal note on the matter: I tend to prefer using the passive form > in such log messages because they are impersonal, and not use the > direct form because it becomes more personally addressed to the user. > I may be living

Re: Speeding up creating UPDATE/DELETE generic plan for partitioned table into a lot

2018-12-31 Thread David Rowley
On Fri, 28 Dec 2018 at 20:36, Tsunakawa, Takayuki wrote: > Although I may say the same thing as you, I think a natural idea would be to > create a generic plan gradually. The starting simple question is "why do we > have to touch all partitions at first?" That is, can we behave like this: > >

Re: pg_dump multi VALUES INSERT

2018-12-31 Thread David Rowley
Just looking at the v5 patch, it seems not to handle 0 column tables correctly. For example: # create table t(); # insert into t default values; # insert into t default values; $ pg_dump --table t --inserts --insert-multi=100 postgres > dump.sql # \i dump.sql [...] INSERT 0 1 psql:dump.sql:35:

Re: Clean up some elog messages and comments for do_pg_stop_backup and do_pg_start_backup

2018-12-31 Thread Peter Eisentraut
On 31/12/2018 09:07, Michael Paquier wrote: > On Sun, Dec 30, 2018 at 02:50:46PM +0900, Michael Paquier wrote: >> A personal note on the matter: I tend to prefer using the passive form >> in such log messages because they are impersonal, and not use the >> direct form because it becomes more