Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

On Wed, Dec 2, 2020 at 1:20 PM Dilip Kumar wrote: > > On Tue, Dec 1, 2020 at 11:38 AM Dilip Kumar wrote: > > > > On Mon, Nov 30, 2020 at 6:49 PM Amit Kapila wrote: > > > > > > On Mon, Nov 30, 2020 at 3:14 AM Noah Misch wrote: > > > > > > > > On Mon, Sep 07, 2020 at 12:00:41PM +0530, Amit Kapila

[bug fix] ALTER TABLE SET LOGGED/UNLOGGED on a partitioned table does nothing silently

Hello, ALTER TABLE SET LOGGED/UNLOGED on a partitioned table completes successfully, but nothing changes. I expected the underlying partitions are changed accordingly. The attached patch fixes this. Regards Takayuki Tsunakawa v1-0001-Make-ALTER-TABLE-SET-LOGGED-UNLOGGED-on-a-partiti.pat

Re: proposal: unescape_text function

On 2020-11-30 22:15, Pavel Stehule wrote: I would like some supporting documentation on this.  So far we only have one stackoverflow question, and then this implementation, and they are not even the same format.  My worry is that if there is not precise specification, then peo

Re: pg_stat_statements oddity with track = all

On Wed, Dec 02, 2020 at 03:52:37PM +0900, Fujii Masao wrote: > > On 2020/12/02 15:32, Julien Rouhaud wrote: > > On Tue, Dec 01, 2020 at 10:08:06PM -0800, Nikolay Samokhvalov wrote: > > > On Tue, Dec 1, 2020 at 8:05 PM Julien Rouhaud wrote: > > > > > > > Someone raised an interested point recentl

Re: [HACKERS] logical decoding of two-phase transactions

On Wed, Dec 2, 2020 at 12:47 PM Ajin Cherian wrote: > > On Tue, Dec 1, 2020 at 6:26 PM Amit Kapila wrote: > > > One idea could be that the subscriber skips the transaction if it sees > > > the transaction is already prepared. > > > > > > > To skip it, we need to send GID in begin message and then

Re: A new function to wait for the backend exit after termination

On Mon, Nov 30, 2020 at 8:10 PM Muhammad Usama wrote: > > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: tested, passed > Documentation:not tested

libpq async command processing methods are difficult to use with edge-triggered epoll

Hi, I've been using libpq to access postgres from within a system that uses an edge-triggered epoll in its event-loop. The instructions on https://www.postgresql.org/docs/current/libpq-async.html are pretty good, but I've run into a bit of an edge case that would be much easier to handle if the in

Proposal: Adding isbgworker column to pg_stat_activity

Hey, all, It is currently slightly difficult to determine how many background worker processes are currently running, which is useful when trying to manage the max_worker_processes parameter. It seems the best bet is to use the backend_type column and filter out the many types that are defined in

Re: Improving spin-lock implementation on ARM.

> On 01/12/2020, 19:08, "Alexander Korotkov" wrote: >BTW, what number of clients did you use? I can't find it in your message. Sure. Important params seem to be: Pgbench: Clients: 256 pgbench_jobs : 32 Scale: 1000 fill_factor: 90 Postgresql: shared buffers: 31GB max_connections: 1024 T

wrong link in acronyms.sgml

Hi I just noticed that in https://www.postgresql.org/docs/13/acronyms.html (i.e., doc/src/sgml/acronyms.sgml) there is under lemma 'HOT' a link with URL: https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/access/heap/README.HOT;hb=HEAD Is this deliberate? Surel

Re: autovac issue with large number of tables

Hi On Wed, Dec 2, 2020 at 3:33 PM Fujii Masao wrote: > > > > On 2020/12/02 12:53, Masahiko Sawada wrote: > > On Tue, Dec 1, 2020 at 5:31 PM Masahiko Sawada > > wrote: > >> > >> On Tue, Dec 1, 2020 at 4:32 PM Fujii Masao > >> wrote: > >>> > >>> > >>> > >>> On 2020/12/01 16:23, Masahiko Sawada

Re: autovac issue with large number of tables

On Wed, Dec 2, 2020 at 3:33 PM Fujii Masao wrote: > > > > On 2020/12/02 12:53, Masahiko Sawada wrote: > > On Tue, Dec 1, 2020 at 5:31 PM Masahiko Sawada > > wrote: > >> > >> On Tue, Dec 1, 2020 at 4:32 PM Fujii Masao > >> wrote: > >>> > >>> > >>> > >>> On 2020/12/01 16:23, Masahiko Sawada wrot

Re: [bug fix] ALTER TABLE SET LOGGED/UNLOGGED on a partitioned table does nothing silently

On Wed, Dec 2, 2020 at 1:52 PM tsunakawa.ta...@fujitsu.com wrote: > > ALTER TABLE SET LOGGED/UNLOGED on a partitioned table completes successfully, > but nothing changes. > Yeah, true. > > I expected the underlying partitions are changed accordingly. The attached > patch fixes this. > My tho

Re: [bug fix] ALTER TABLE SET LOGGED/UNLOGGED on a partitioned table does nothing silently

On Wed, Dec 2, 2020 at 3:57 PM Bharath Rupireddy wrote: > > On Wed, Dec 2, 2020 at 1:52 PM tsunakawa.ta...@fujitsu.com > wrote: > > > > ALTER TABLE SET LOGGED/UNLOGED on a partitioned table completes > > successfully, but nothing changes. > > > > Yeah, true. > > > > > I expected the underlying p

Re: proposal: unescape_text function

st 2. 12. 2020 v 9:23 odesílatel Peter Eisentraut < peter.eisentr...@enterprisedb.com> napsal: > On 2020-11-30 22:15, Pavel Stehule wrote: > > I would like some supporting documentation on this. So far we only > > have > > one stackoverflow question, and then this implementation, and

Re: Cost overestimation of foreign JOIN

On 12/1/20 6:17 PM, Ashutosh Bapat wrote: On Mon, Nov 30, 2020 at 11:56 PM Andrey Lepikhov wrote: On 30.11.2020 22:38, Tom Lane wrote: Andrey Lepikhov writes: If you're unhappy with the planning results you get for this, why don't you have use_remote_estimate turned on? I have a mixed load

Re: Corner-case bug in pg_rewind

On 01/12/2020 16:52, Pavel Borisov wrote: Status update for a commitfest entry. The patch is Waiting on Author for some time. As this is a bug fix, I am moving it to the next CF. Ian, are you planning to continue working on it? As a reviewer, I consider the patch useful and

SELECT INTO deprecation

While reading about deprecating and removing various things in other threads, I was wondering about how deprecated SELECT INTO is. There are various source code comments about this, but the SELECT INTO reference page only contains soft language like "recommended". I'm proposing the attached p

Re: SELECT INTO deprecation

> On 2 Dec 2020, at 12:54, Peter Eisentraut > wrote: > While reading about deprecating and removing various things in other threads, > I was wondering about how deprecated SELECT INTO is. There are various > source code comments about this, but the SELECT INTO reference page only > contains

Re: proposal: unescape_text function

On 12/2/20 12:48 AM, Pavel Stehule wrote: > > > st 2. 12. 2020 v 0:05 odesílatel Andrew Dunstan > napsal: > > > On 11/30/20 8:14 AM, Peter Eisentraut wrote: > > On 2020-11-29 18:36, Pavel Stehule wrote: > >> > >>     I don't really get the point of thi

Re: Huge memory consumption on partitioned table with FKs

Hello, On Tue, Dec 1, 2020 at 9:40 AM Kyotaro Horiguchi wrote: > > At Mon, 30 Nov 2020 21:03:45 -0300, Alvaro Herrera > wrote in > > On 2020-Nov-26, Kyotaro Horiguchi wrote: > > > > > This shares RI_ConstraintInfo cache by constraints that shares the > > > same parent constraints. But you forgo

convert elog(LOG) calls to ereport

There are a number of elog(LOG) calls that appear to be user-facing, so they should be ereport()s. This patch changes them. There are more elog(LOG) calls remaining, but they all appear to be some kind of debugging support. Also, I changed a few elog(FATAL)s that were nearby, but I didn't sp

Re: proposal: function pg_setting_value_split() to parse shared_preload_libraries etc.

2020年11月30日(月) 14:53 Craig Ringer : > > On Mon, 30 Nov 2020 at 03:24, Anastasia Lubennikova > wrote: > > > > On 23.10.2020 05:06, Ian Lawrence Barwick wrote: > > > Having just submitted this, I realised I'm focussing on the GUCs which > > > call > > > "SplitDirectoriesString()" (as my specific us

Re: pg_stat_statements oddity with track = all

Hi, a crazy idea: - add a parent_statement_id column that would be NULL for top level queries - build statement_id for nested queries based on the merge of: a/ current_statement_id and parent one or b/ current_statement_id and nested level. this would offer the ability to track counters at

Re: Huge memory consumption on partitioned table with FKs

On Tue, 1 Dec 2020 at 00:03, Alvaro Herrera wrote: > cache entry is reused in the common case where they are identical. Does a similar situation exist for partition statistics accessed during planning? Or planning itself? It would be useful to avoid repeated access to similar statistics and repe

Re: A new function to wait for the backend exit after termination

On Wed, Dec 2, 2020 at 1:30 PM Bharath Rupireddy < bharath.rupireddyforpostg...@gmail.com> wrote: > On Mon, Nov 30, 2020 at 8:10 PM Muhammad Usama wrote: > > > > The following review has been posted through the commitfest application: > > make installcheck-world: tested, passed > > Implements fe

Re: wrong link in acronyms.sgml

On 2020-Dec-02, Erik Rijkers wrote: > Hi > > I just noticed that in > > https://www.postgresql.org/docs/13/acronyms.html > (i.e., doc/src/sgml/acronyms.sgml) > > there is under lemma 'HOT' a link with URL: > > https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/acces

Re: convert elog(LOG) calls to ereport

On 2020-Dec-02, Peter Eisentraut wrote: > There are a number of elog(LOG) calls that appear to be user-facing, so they > should be ereport()s. This patch changes them. There are more elog(LOG) > calls remaining, but they all appear to be some kind of debugging support. > Also, I changed a few el

Re: Autovacuum on partitioned table (autoanalyze)

Hello Alvaro, Thank you for your comments. > > > In second thought about the reason for the "toprel_oid". It is perhaps > > to avoid "wrongly" propagated values to ancestors after a manual > > ANALYZE on a partitioned table. But the same happens after an > > autoanalyze iteration if some of the

Re: pg_stat_statements oddity with track = all

Hello > - add a parent_statement_id column that would be NULL for top level queries Will generate too much entries... Every FK for each different delete/insert, for example. But very useful for databases with a lot of stored procedures to find where this query is called. May be new mode track =

Re: pg_stat_statements oddity with track = all

On Tue, Dec 1, 2020 at 10:32 PM Julien Rouhaud wrote: > On Tue, Dec 01, 2020 at 10:08:06PM -0800, Nikolay Samokhvalov wrote: > > If all top-level records in pg_stat_statements have "true" in the new > > column (is_toplevel), how would this lead to the need to increase > > pg_stat_statements.max?

macOS SIP, next try

Previous discussions on macOS SIP: https://www.postgresql.org/message-id/flat/561E73AB.8060800%40gmx.net https://www.postgresql.org/message-id/flat/CA%2BTgmoYGi5oR8Rvb2-SY1_WEjd76H5gCqSukxFQ66qR7MewWAQ%40mail.gmail.com https://www.postgresql.org/message-id/flat/6a4d6124-41f0-756b-0811-c5c5def7ef4

Re: Corner-case bug in pg_rewind

On 02/12/2020 20:13, Heikki Linnakangas wrote: On 01/12/2020 16:52, Pavel Borisov wrote:     Status update for a commitfest entry.     The patch is Waiting on Author for some time. As this is a bug fix,     I am     moving it to the next CF.     Ian, are you planning to continue working on it?

Re: proposal: unescape_text function

On 12/02/20 05:37, Pavel Stehule wrote: > 2. there can be optional parameter "prefix" with default "\". But with "\u" > it can be compatible with Java or Python. Java's unicode escape form is one of those early ones that lack a six-digit form, and where any character outside of the basic multiling

Re: [HACKERS] [PATCH] Generic type subscripting

> On Mon, Nov 30, 2020 at 02:26:19PM +0100, Dmitry Dolgov wrote: > > On Mon, Nov 30, 2020 at 04:12:29PM +0300, Alexander Korotkov wrote: > > > > > > My first question is whether we're > > > > able to handle different subscript types differently. For instance, > > > > one day we could handle jsonpa

Re: Additional improvements to extended statistics

On Sun, 29 Nov 2020 at 21:02, Tomas Vondra wrote: > > I wonder how much of the comment before clauselist_selectivity should > move to clauselist_selectivity_ext - it does talk about range clauses > and so on, but clauselist_selectivity does not really deal with that. > But maybe that's just an imp

Deprecate custom encoding conversions

Hi, PostgreSQL allows writing custom encoding conversion functions between any character encodings, using the CREATE CONVERSION command. It's pretty flexible, you can define default and non-default conversions, and the conversions live in schemas so you can have multiple conversions installed

Re: SELECT INTO deprecation

st 2. 12. 2020 v 12:55 odesílatel Peter Eisentraut < peter.eisentr...@enterprisedb.com> napsal: > While reading about deprecating and removing various things in other > threads, I was wondering about how deprecated SELECT INTO is. There are > various source code comments about this, but the SELEC

Re: Deprecate custom encoding conversions

Heikki Linnakangas writes: > I propose that we add a notice to the CREATE CONVERSION docs to say that > it is deprecated, and remove it in a few years. While I agree that it's probably not that useful, what would we gain by removing it? If you intend to remove those catalogs, what lookup mechan

Re: Deprecate custom encoding conversions

On 02/12/2020 18:18, Tom Lane wrote: Heikki Linnakangas writes: I propose that we add a notice to the CREATE CONVERSION docs to say that it is deprecated, and remove it in a few years. While I agree that it's probably not that useful, what would we gain by removing it? If you intend to remov

Re: proposal: unescape_text function

On 12/02/20 09:55, Chapman Flack wrote: > In Perl, there is a useful extension to regexp substitution where > you specify the replacement not as a string or even a string with & > and \1 \2 ... magic, but as essentially a lambda that is passed the > match and returns a computed replacement. That ma

Re: Additional improvements to extended statistics

On 12/2/20 4:51 PM, Dean Rasheed wrote: > On Sun, 29 Nov 2020 at 21:02, Tomas Vondra > wrote: >> >> I wonder how much of the comment before clauselist_selectivity should >> move to clauselist_selectivity_ext - it does talk about range clauses >> and so on, but clauselist_selectivity does not reall

Re: [HACKERS] [PATCH] Generic type subscripting

Dmitry Dolgov <9erthali...@gmail.com> writes: >> On Mon, Nov 30, 2020 at 02:26:19PM +0100, Dmitry Dolgov wrote: >>> On Mon, Nov 30, 2020 at 04:12:29PM +0300, Alexander Korotkov wrote: >>> The idea of an opaque field in SubscriptingRef structure is more >>> attractive to me. Could you please implem

Re: should INSERT SELECT use a BulkInsertState?

One loose end in this patch is how to check for volatile default expressions. copyfrom.c is a utility statement, so it can look at the parser's column list: COPY table(c1,c2)... However, for INSERT, in nodeModifyTable.c, it looks like parsing, rewriting, and planning are done, at which point I do

Re: SELECT INTO deprecation

Greetings, * Peter Eisentraut (peter.eisentr...@enterprisedb.com) wrote: > While reading about deprecating and removing various things in other > threads, I was wondering about how deprecated SELECT INTO is. There are > various source code comments about this, but the SELECT INTO reference page >

Re: [HACKERS] [PATCH] Generic type subscripting

So ... one of the things that's been worrying me about this patch from day one is whether it would create a noticeable performance penalty for existing use-cases. I did a small amount of experimentation about that with the v35 patchset, and it didn't take long at all to find that this: --- cut --

Re: Deprecate custom encoding conversions

Heikki Linnakangas writes: > On 02/12/2020 18:18, Tom Lane wrote: >> Heikki Linnakangas writes: >>> I propose that we add a notice to the CREATE CONVERSION docs to say that >>> it is deprecated, and remove it in a few years. >> While I agree that it's probably not that useful, what would we gain

Re: proposal: unescape_text function

st 2. 12. 2020 v 11:37 odesílatel Pavel Stehule napsal: > > > st 2. 12. 2020 v 9:23 odesílatel Peter Eisentraut < > peter.eisentr...@enterprisedb.com> napsal: > >> On 2020-11-30 22:15, Pavel Stehule wrote: >> > I would like some supporting documentation on this. So far we only >> > have

Re: [HACKERS] [PATCH] Generic type subscripting

> On Wed, Dec 02, 2020 at 12:58:51PM -0500, Tom Lane wrote: > So ... one of the things that's been worrying me about this patch > from day one is whether it would create a noticeable performance > penalty for existing use-cases. I did a small amount of experimentation > about that with the v35 pat

Re: [HACKERS] [PATCH] Generic type subscripting

> On Wed, Dec 02, 2020 at 11:52:54AM -0500, Tom Lane wrote: > Dmitry Dolgov <9erthali...@gmail.com> writes: > >> On Mon, Nov 30, 2020 at 02:26:19PM +0100, Dmitry Dolgov wrote: > >>> On Mon, Nov 30, 2020 at 04:12:29PM +0300, Alexander Korotkov wrote: > >>> The idea of an opaque field in Subscripting

Re: [HACKERS] [PATCH] Generic type subscripting

On Wed, Dec 02, 2020 at 08:18:08PM +0100, Dmitry Dolgov wrote: > > On Wed, Dec 02, 2020 at 12:58:51PM -0500, Tom Lane wrote: > > So ... one of the things that's been worrying me about this patch > > from day one is whether it would create a noticeable performance > > penalty for existing use-cases.

Re: proposal: unescape_text function

On Wed, Dec 2, 2020 at 07:30:39PM +0100, Pavel Stehule wrote: > postgres=# select >  'Arabic     : ' || unistr( '\0627\0644\0639\0631\0628\064A\0629' )      || ' >   Chinese    : ' || unistr( '\4E2D\6587' )                               || ' >   English    : ' || unistr( 'English' )              

Re: [HACKERS] [PATCH] Generic type subscripting

> On Wed, Dec 02, 2020 at 01:20:10PM -0600, Justin Pryzby wrote: > On Wed, Dec 02, 2020 at 08:18:08PM +0100, Dmitry Dolgov wrote: > > > On Wed, Dec 02, 2020 at 12:58:51PM -0500, Tom Lane wrote: > > > So ... one of the things that's been worrying me about this patch > > > from day one is whether it

Re: Log message for GSS connection is missing once connection authorization is successful.

Greetings, * Stephen Frost (sfr...@snowman.net) wrote: > * vignesh C (vignes...@gmail.com) wrote: > > Thanks for testing this, I had missed testing this. The expression > > matching was not correct. Attached v6 patch which includes the fix for > > this. > > This generally looks pretty good to me.

Re: Add docs stub for recovery.conf

Greetings, * David G. Johnston (david.g.johns...@gmail.com) wrote: > On Mon, Nov 30, 2020 at 11:42 AM Bruce Momjian wrote: > > The downside is you end up with X-1 dummy sections just to allow for > > references to old syntax, and you then have to find them all and remove > > them when you impleme

Re: [PATCH] SET search_path += octopus

On Tue, Dec 1, 2020 at 08:19:34PM +0530, Abhijit Menon-Sen wrote: > I'm certainly not in favour of introducing multiple operators to express > the various list operations, like += for prepend and =+ for append. (By > the standard of assembling such things from spare parts, the right thing > to do

Re: Off-Schedule Minor Release Consideration?

"David G. Johnston" writes: > Given that we have already heard about 3 separate minor release regressions > in the most recent update I'm putting forth for discussion whether an > off-schedule release should be done. I probably wouldn't care as much if > it wasn't for the fact that the same relea

Re: SELECT INTO deprecation

On Wed, Dec 02, 2020 at 12:58:36PM -0500, Stephen Frost wrote: > Greetings, > > * Peter Eisentraut (peter.eisentr...@enterprisedb.com) wrote: > > While reading about deprecating and removing various things in > > other threads, I was wondering about how deprecated SELECT INTO > > is. There are va

Re: [HACKERS] [PATCH] Generic type subscripting

Dmitry Dolgov <9erthali...@gmail.com> writes: >> On Wed, Dec 02, 2020 at 12:58:51PM -0500, Tom Lane wrote: >> So ... one of the things that's been worrying me about this patch >> from day one is whether it would create a noticeable performance >> penalty for existing use-cases. I did a small amoun

Re: Add table access method as an option to pgbench

Hello David, Some feedback about v4. It looks that the option is *silently* ignored when creating a partitionned table, which currently results in an error, and not passed to partitions, which would accept them. This is pretty weird. The input check is added with an error message when both p

Re: Minor documentation error regarding streaming replication protocol

On Tue, Dec 1, 2020 at 10:16:31AM -0800, Jeff Davis wrote: > On Thu, 2020-10-08 at 23:17 -0400, Bruce Momjian wrote: > > As I said before, it is more raw bytes, but > > we > > don't have an SQL data type for that. > > Sorry to jump in to this thread late. > > Can't we just set both "filename" an

Re: Add docs stub for recovery.conf

On Wed, Dec 2, 2020 at 02:47:13PM -0500, Stephen Frost wrote: > Greetings, > > * David G. Johnston (david.g.johns...@gmail.com) wrote: > > On Mon, Nov 30, 2020 at 11:42 AM Bruce Momjian wrote: > > > The downside is you end up with X-1 dummy sections just to allow for > > > references to old synt

Re: SELECT INTO deprecation

Stephen Frost writes: > * Peter Eisentraut (peter.eisentr...@enterprisedb.com) wrote: >> While reading about deprecating and removing various things in other >> threads, I was wondering about how deprecated SELECT INTO is. There are >> various source code comments about this, but the SELECT INTO

Re: Commitfest 2020-11 is closed

Anastasia Lubennikova writes: > Commitfest 2020-11 is officially closed now. > Many thanks to everyone who participated by posting patches, reviewing > them, committing and sharing ideas in discussions! Thanks for all the hard work! > Today, me and Georgios will move the remaining items to the

Re: Commitfest 2020-11 is closed

On Thu, Dec 3, 2020 at 10:00 AM Tom Lane wrote: > This is actually a bit problematic, because now the cfbot is ignoring > those patches (or if it's not, I don't know where it's displaying the > results). Please go ahead and move the remaining open patches, or > else re-open the CF if that's possi

Re: libpq compression

On Thu, Nov 26, 2020 at 8:15 AM Daniil Zakhlystov wrote: > However, I don’t mean by this that we shouldn’t support switchable > compression. I propose that we can offer two compression modes: permanent > (which is implemented in the current state of the patch) and switchable > on-the-fly. Perma

Proposed patch for key managment

Attached is a patch for key management, which will eventually be part of cluster file encryption (CFE), called TDE (Transparent Data Encryption) by Oracle. It is an update of Masahiko Sawada's patch from July 31: https://www.postgresql.org/message-id/ca+fd4k6rjwnvztro3q2f5hsdd8hgyuc4cuy9

Re: Commitfest 2020-11 is closed

On 12/2/20 4:15 PM, Thomas Munro wrote: On Thu, Dec 3, 2020 at 10:00 AM Tom Lane wrote: This is actually a bit problematic, because now the cfbot is ignoring those patches (or if it's not, I don't know where it's displaying the results). Please go ahead and move the remaining open patches, or

Re: Commitfest 2020-11 is closed

On Thu, Dec 3, 2020 at 10:51 AM David Steele wrote: > On 12/2/20 4:15 PM, Thomas Munro wrote: > > On Thu, Dec 3, 2020 at 10:00 AM Tom Lane wrote: > >> This is actually a bit problematic, because now the cfbot is ignoring > >> those patches (or if it's not, I don't know where it's displaying the >

Re: Commitfest 2020-11 is closed

On 12/2/20 5:13 PM, Thomas Munro wrote: On Thu, Dec 3, 2020 at 10:51 AM David Steele wrote: On 12/2/20 4:15 PM, Thomas Munro wrote: On Thu, Dec 3, 2020 at 10:00 AM Tom Lane wrote: This is actually a bit problematic, because now the cfbot is ignoring those patches (or if it's not, I don't kno

Re: Commitfest 2020-11 is closed

On 12/2/20 5:13 PM, Thomas Munro wrote: > > I'm experimenting with Github's built in CI. All other ideas welcome. I'd look very closely at gitlab. cheers andrew

Re: pg_dump, ATTACH, and independently restorable child partitions

On Wed, Nov 25, 2020 at 06:35:19PM -0500, Tom Lane wrote: > Justin Pryzby writes: > > 1. Maybe pg_restore ExecuteSqlCommandBuf() should (always?) call > > ExecuteSimpleCommands() instead of ExecuteSqlCommand(). It doesn't seem to > > break anything (although that surprised me). > > That certainl

Re: Add docs stub for recovery.conf

Greetings, * Bruce Momjian (br...@momjian.us) wrote: > On Wed, Dec 2, 2020 at 02:47:13PM -0500, Stephen Frost wrote: > > * David G. Johnston (david.g.johns...@gmail.com) wrote: > > > On Mon, Nov 30, 2020 at 11:42 AM Bruce Momjian wrote: > > > > The downside is you end up with X-1 dummy sections

Re: Commitfest 2020-11 is closed

st 2. 12. 2020 v 23:36 odesílatel Andrew Dunstan napsal: > > > On 12/2/20 5:13 PM, Thomas Munro wrote: > > > > I'm experimenting with Github's built in CI. All other ideas welcome. > > > > I'd look very closely at gitlab. I was about to respond before with the same idea. Feel free to ping regard

Re: SELECT INTO deprecation

On Wed, Dec 02, 2020 at 03:35:46PM -0500, Tom Lane wrote: > Yeah, if we want to kill it let's just do so. The negative language in > the reference page has been there since (at least) 7.1, so people can > hardly say they didn't see it coming. +1. I got to wonder about the impact when migrating a

Re: Add docs stub for recovery.conf

On Wed, Dec 2, 2020 at 05:57:01PM -0500, Stephen Frost wrote: > * Bruce Momjian (br...@momjian.us) wrote: > > We were not going to use just redirects --- we were going to create a > > page that had all the renames listed, with links to the new names. > > Maybe I'm the one who is confused here, bu

Re: Add docs stub for recovery.conf

On Wed, Dec 2, 2020 at 5:26 PM Bruce Momjian wrote: > I think the ideal solution is to create a section for all the rename > cases and do all the redirects to that page. The page would list the > old and new name for each item, and would link to the section for each > new item. > > Nothing preve

RE: Deprecate custom encoding conversions

From: Heikki Linnakangas > I propose that we add a notice to the CREATE CONVERSION docs to say that > it is deprecated, and remove it in a few years. > > Any objections? Anyone using custom encoding conversions in production? I can't answer deeper questions because I'm not familiar with characte

Re: pg_stat_statements oddity with track = all

On Wed, Dec 02, 2020 at 06:23:54AM -0800, Nikolay Samokhvalov wrote: > On Tue, Dec 1, 2020 at 10:32 PM Julien Rouhaud wrote: > > > On Tue, Dec 01, 2020 at 10:08:06PM -0800, Nikolay Samokhvalov wrote: > > > If all top-level records in pg_stat_statements have "true" in the new > > > column (is_topl

Re: Add docs stub for recovery.conf

On Wed, 2 Dec 2020 at 19:33, David G. Johnston wrote: > On Wed, Dec 2, 2020 at 5:26 PM Bruce Momjian wrote: > >> I think the ideal solution is to create a section for all the rename >> cases and do all the redirects to that page. The page would list the >> old and new name for each item, and wo

Re: Get memory contexts of an arbitrary backend process

On 2020/11/16 19:58, torikoshia wrote: On 2020-10-28 15:32, torikoshia wrote: On 2020-10-23 13:46, Kyotaro Horiguchi wrote: I think we might need to step-back to basic design of this feature since this patch seems to have unhandled corner cases that are difficult to find. I've written ou

Re: Add docs stub for recovery.conf

On Wed, Dec 2, 2020 at 08:07:47PM -0500, Isaac Morland wrote: > On Wed, 2 Dec 2020 at 19:33, David G. Johnston > wrote: > > On Wed, Dec 2, 2020 at 5:26 PM Bruce Momjian wrote: > > I think the ideal solution is to create a section for all the rename > cases and do all the re

Re: Huge memory consumption on partitioned table with FKs

At Wed, 2 Dec 2020 22:02:50 +0900, Amit Langote wrote in > Hello, > > On Tue, Dec 1, 2020 at 9:40 AM Kyotaro Horiguchi > wrote: > > > > At Mon, 30 Nov 2020 21:03:45 -0300, Alvaro Herrera > > wrote in > > > On 2020-Nov-26, Kyotaro Horiguchi wrote: > > > > > > > This shares RI_ConstraintInfo c

Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly

On Tue, Dec 01, 2020 at 03:10:13PM +0900, Michael Paquier wrote: > Well, my impression is that both of you kept exchanging patches, > touching and reviewing each other's patch (note that Alexei has also > sent a rebase of 0002 just yesterday), so I think that it is fair to > say that both of you sh

Re: Huge memory consumption on partitioned table with FKs

Hi Hackers, >> I would embed all this knowledge in ri_BuildQueryKey though, without >> adding the new function ri_GetParentConstOid. I don't think that >> function meaningful abstraction value, and instead it would make what I >> suggest more difficult. > It seems to me reasonable. Indeed, I tr

Re: Get memory contexts of an arbitrary backend process

Fujii Masao writes: > I'm starting to study how this feature behaves. At first, when I executed > the following query, the function never returned. ISTM that since > the autovacuum launcher cannot respond to the request of memory > contexts dump, the function keeps waiting infinity. Is this a bug?

Re: Deprecate custom encoding conversions

"tsunakawa.ta...@fujitsu.com" writes: > From: Heikki Linnakangas >> Any objections? Anyone using custom encoding conversions in production? > I can't answer deeper questions because I'm not familiar with character sets, > but I saw some Japanese web articles that use CREATE CONVERSION to handle

Re: scram-sha-256 broken with FIPS and OpenSSL 1.0.2

On Wed, Dec 02, 2020 at 12:03:49PM +0900, Michael Paquier wrote: > Thanks. 0001 has been applied and the buildfarm does not complain, so > it looks like we are good (I'll take care of any issues, like the one > Fujii-san has just reported). Attached are new patches for 0002, the > EVP switch. On

Re: Deprecate custom encoding conversions

On Thu, Dec 03, 2020 at 12:54:56AM +, tsunakawa.ta...@fujitsu.com wrote: > I can't answer deeper questions because I'm not familiar with > character sets, but I saw some Japanese web articles that use CREATE > CONVERSION to handle external characters. So, I think we may as > well retain it. (

RE: A new function to wait for the backend exit after termination

Hi I take a look into the patch, and here some comments. 1. + + ereport(WARNING, + (errmsg("could not wait for the termination of the backend with PID %d within %ld milliseconds", + pid, timeout))); + The code use %ld to print in

Re: A new function to wait for the backend exit after termination

"Hou, Zhijie" writes: > + ereport(WARNING, > + (errmsg("could not wait for the termination of the > backend with PID %d within %ld milliseconds", > + pid, timeout))); > The code use %ld to print int64 type. > How about use INT64_FORMAT,

Renaming cryptohashes.c to cryptohashfuncs.c

Hi all, Now that the tree has a new set of files for cryptohash functions as of src/common/cryptohash*.c, it is a bit weird to have another file called cryptohashes.c for the set of SQL functions. Any objections to rename that to cryptohashfuncs.c? That would be much more consistent with the sur

RE: A new function to wait for the backend exit after termination

> > + ereport(WARNING, > > + (errmsg("could not wait for the termination of the > backend with PID %d within %ld milliseconds", > > + pid, timeout))); > > > The code use %ld to print int64 type. > > How about use INT64_FORMAT, which looks more

Re: Deprecate custom encoding conversions

> I recall a discussion in which someone explained that things are messy for > Japanese because there's not really just one version of SJIS; there are > several, because various groups extended the original standard in not- > quite-compatible ways. In turn this means that there's not really one >

Re: Commitfest 2020-11 is closed

On 12/02/20 16:51, David Steele wrote: > Depending on how you have Github organized migrating to travis-ci.com may be > bit tricky because it requires full access to all private repositories in > your account and orgs administrated by your account. PL/Java just began using travis-ci.com this summe

Re: autovac issue with large number of tables

On Wed, Dec 2, 2020 at 7:11 PM Masahiko Sawada wrote: > > On Wed, Dec 2, 2020 at 3:33 PM Fujii Masao > wrote: > > > > > > > > On 2020/12/02 12:53, Masahiko Sawada wrote: > > > On Tue, Dec 1, 2020 at 5:31 PM Masahiko Sawada > > > wrote: > > >> > > >> On Tue, Dec 1, 2020 at 4:32 PM Fujii Masao

RE: Deprecate custom encoding conversions

From: Michael Paquier > Tsunakawa-san, could you post a link to this article, if possible? I am > curious > about their problem and why they used CREATE CONVERSION as a way to > solve it. That's fine even if it is in Japanese. I just pulled info from my old memory in my previous mail. Now the

RE: Disable WAL logging to speed up data loading

Hello I've made a new patch v05 that took in comments to filter out WALs more strictly and addressed some minor fixes that were discussed within past few days. Also, I changed the documentations, considering those modifications. Best, Takamichi Osumi disable_WAL_logging_v05.patch Des

Re: Huge memory consumption on partitioned table with FKs

Hello, On Thu, Dec 3, 2020 at 10:15 AM Kyotaro Horiguchi wrote: > At Wed, 2 Dec 2020 22:02:50 +0900, Amit Langote > wrote in > > Hello, > > > > On Tue, Dec 1, 2020 at 9:40 AM Kyotaro Horiguchi > > wrote: > > > > > > At Mon, 30 Nov 2020 21:03:45 -0300, Alvaro Herrera > > > wrote in > > > > On

RE: A new function to wait for the backend exit after termination

> > I changed the status to 'wait on anthor'. > The others of the patch LGTM, > I think it can be changed to Ready for Committer again, when this comment > is confirmed. > I am Sorry I forgot a possible typo comment. +{ oid => '16386', descr => 'terminate a backend process and wait for it\'s e

  1   2   >