Re: fix: propagate M4 env variable to flex subprocess

On 17.06.25 07:15, Peter Eisentraut wrote: On 28.05.25 20:42, J. Javier Maestro wrote: On Wed, May 28, 2025 at 6:08 PM Andres Freund > wrote:     Hi,     On 2025-05-17 23:32:24 -0400, J. Javier Maestro wrote: > On Tue, May 13, 2025 at 11:54 AM Andres Freund    

Re: Skipping schema changes in publication

Few more comments on 002: 5) +GetAllTablesPublicationRelations(Oid pubid, bool pubviaroot) { + List*exceptlist; + + exceptlist = GetPublicationRelations(pubid, PUBLICATION_PART_ALL); a) Here, we are assuming that the list provided by GetPublicationRelations() will be except-tables list onl

Re: NUMA shared memory interleaving

Hi Tomas! On Fri, Jun 27, 2025 at 6:41 PM Tomas Vondra wrote: > I agree we should improve the behavior on NUMA systems. But I'm not sure > this patch does far enough, or perhaps the approach seems a bit too > blunt, ignoring some interesting stuff. > > AFAICS the patch essentially does the same

Re: Conflict detection for update_deleted in logical replication

On Fri, Jun 27, 2025 at 7:58 AM Zhijie Hou (Fujitsu) wrote: > > Here is the V43 patch set which includes the following changes: > Few minor comments: 1. @@ -29645,8 +29651,10 @@ postgres=# SELECT '0/0'::pg_lsn + pd.segment_number * ps.setting::int + :offset Copies an existing logical rep

Improve error reporting in 027_stream_regress test

Hi, This patch aims to improve 027_stream_regress test's regression test error reporting per Andres' suggestion [1]. It basically dumps 50 lines from head and tail of the regression.diff file to the failure message if both primary and standby is alive and the regression test is failed. I used the

Re: A concurrent VACUUM FULL?

On Mon, Jun 30, 2025 at 12:03 PM Antonin Houska wrote: > Erik Nordström wrote: > > > Hi hackers, > > > > I've been looking at the code for CLUSTER/VACUUM FULL, and whether it is > possible to do a concurrent version of it using a > > multi-transactional approach similar to concurrent reindexing

Re: Prevent internal error at concurrent CREATE OR REPLACE FUNCTION

Hi, On Mon, Jun 30, 2025 at 3:47 PM Yugo Nagata wrote: > > On Fri, 27 Jun 2025 18:53:02 +0700 > Daniil Davydov <3daniss...@gmail.com> wrote: > > This patch fixes postgres behavior if I first create a function and > > then try to CREATE OR REPLACE it in concurrent transactions. > > But if the func

amcheck: support for GiST

Hello hackers! In PG19 we made a step in improving amcheck and added GIN support. This is a thread that continues previous work [0]. Please find attached two new steps for amcheck: 1. A function to verify GiST integrity. This patch is in decent shape, simply rebased from previous year. 2. Suppor

Re: IPC/MultixactCreation on the Standby server

> On 28 Jun 2025, at 21:24, Andrey Borodin wrote: > > This seems to be fixing issue for me. ISTM I was wrong: there is a possible recovery conflict with snapshot. REDO: frame #2: 0x00010179a0c8 postgres`pg_usleep(microsec=100) at pgsleep.c:50:10 frame #3: 0x00010144c108 post

Re: track generic and custom plans in pg_stat_statements

rebased patch. Only changes to the tests due to the revert of nested query tracking in f85f6ab051b Regards, Sami v10-0001-Add-plan_cache-counters-to-pg_stat_statements.patch Description: Binary data

Re: A concurrent VACUUM FULL?

On 2025-Jun-30, Erik Nordström wrote: > On Mon, Jun 30, 2025 at 12:03 PM Antonin Houska wrote: > > Patch [1] is in the queue that allows both reads and writes. (An exclusive > > lock is acquired here for the swaps, but that should be held for very short > > time.) > > That sounds great. Do you k

Re: Report replica identity in pg_publication_tables

On Mon, Jun 30, 2025 at 3:44 PM Ashutosh Bapat wrote: > > Hi All, > > The commit message in the patch says it all, but let me repeat it here. > You forgot to attach the patch. > When debugging issues with logical replication, replica identity > property of tables in publication is often useful,

Re: Improve explicit cursor handling in pg_stat_statements

rebased patch. Regards, Sami v6-0001-Normalize-variable-fetch-sizes-in-a-FETCH-command.patch Description: Binary data

RE: Check for existing replication slot in pg_createsubscriber

Dear Amit, Zane, > Okay, I find your case a good reason to add such a check, apart from > making the code consistent in terms of these checks. One thing I was > thinking is whether it makes sense to add these checks only in > --dry-run mode because we normally don't expect such conflicts. > Otherw

Report replica identity in pg_publication_tables

Hi All, The commit message in the patch says it all, but let me repeat it here. When debugging issues with logical replication, replica identity property of tables in publication is often useful, for example, to determine the amount of data logged for an UPDATE or DELETE on a given table. Given

Re: A concurrent VACUUM FULL?

On Mon, Jun 30, 2025 at 1:46 PM Álvaro Herrera wrote: > On 2025-Jun-30, Erik Nordström wrote: > > > On Mon, Jun 30, 2025 at 12:03 PM Antonin Houska wrote: > > > > Patch [1] is in the queue that allows both reads and writes. (An > exclusive > > > lock is acquired here for the swaps, but that shou

Re: NUMA shared memory interleaving

On Mon, Jun 30, 2025 at 12:55 PM Jakub Wartak wrote: [..] > > FWIW while I think the patch doesn't go far enough, there's one area > > where I think it probably goes way too far - configurability. I agree > > it's reasonable to allow running on a subset of nodes, e.g. to split the > > system betwe

Re: A concurrent VACUUM FULL?

Erik Nordström wrote: > On Mon, Jun 30, 2025 at 1:46 PM Álvaro Herrera wrote: > > On 2025-Jun-30, Erik Nordström wrote: > > > On Mon, Jun 30, 2025 at 12:03 PM Antonin Houska wrote: > > > > Patch [1] is in the queue that allows both reads and writes. (An > exclusive > > > lock is acquire

Re: Report replica identity in pg_publication_tables

On Mon, Jun 30, 2025 at 5:17 PM Amit Kapila wrote: > > On Mon, Jun 30, 2025 at 3:44 PM Ashutosh Bapat > wrote: > > > > Hi All, > > > > The commit message in the patch says it all, but let me repeat it here. > > > > You forgot to attach the patch. Sorry. Here it is > > > When debugging issues wit

RE: pg_logical_slot_get_changes waits continously for a partial WAL record spanning across 2 pages

Dear Vignesh, > I was unable to reproduce the same test failure on the PG17 branch, > even after running the test around 500 times. However, on the master > branch, the failure consistently reproduces approximately once in > every 50 runs. I also noticed that while the buildfarm has reported > mul

Re: pg_logical_slot_get_changes waits continously for a partial WAL record spanning across 2 pages

On Mon, 30 Jun 2025 at 17:41, Hayato Kuroda (Fujitsu) wrote: > > Dear Vignesh, > > > I was unable to reproduce the same test failure on the PG17 branch, > > even after running the test around 500 times. However, on the master > > branch, the failure consistently reproduces approximately once in >

Re: [PATCH] Support for basic ALTER TABLE progress reporting.

Hi, thank you for the review! On Fri, Jun 6, 2025 at 10:37 AM jian he wrote: > On Mon, Jun 2, 2025 at 3:35 PM Jiří Kavalík wrote: > > What I changed: > > > > `commands/tablecmds.c` > > - start and end reporting inside `ATRewriteTables()` > > - report blocks total, blocks and tuples scanned and

Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options

Hi, Patch applies and compiles, all included tests passed and performance gain is really impressive. I have been using the latest versions for months with real data and didn't find any bugs, so It is definitely ready for committer status. На пн, 30.06.2025 г. в 8:26 Tatsuo Ishii написа: > Attach

[PATCH] Prevent replacement of a function if it's used in an index expression and is not IMMUTABLE

Hi hackers, The purpose of this patch is to prevent replacing a function via `CREATE OR REPLACE FUNCTION` with a new definition that is not marked as `IMMUTABLE`, if the existing function is referenced by an index expression. Replacing such functions may lead to index corruption or runtime sema

Re: Historic snapshot doesn't track txns committed in BUILDING_SNAPSHOT state

Hi, If I understand correctly, this may break the basic principle: The aim is to build a snapshot that behaves the same as a freshly taken MVCC snapshot would have at the time the XLogRecord was generated. -- Regards, ChangAo Chen -- Original -- From:

Re: doc: explain pgstatindex fragmentation

On 24.01.25 15:41, Frédéric Yhuel wrote: On 1/24/25 14:58, Laurenz Albe wrote: On Fri, 2025-01-24 at 13:34 +, Bertrand Drouvot wrote: + Since indexes have a default fillfactor of 90, this should be around 0.9 for + newly built indexes I think 0.9 should be replaced by 90 (that's the act

Re: tab complete for COPY populated materialized view TO

On 2025/04/11 4:37, Kirill Reshke wrote: On Fri, 11 Apr 2025 at 00:33, David G. Johnston wrote: They are supported for the From variant; valid completions need only satisfy one of to/from, not both. Thank you. If so, then WFM, and I don't have any more objections. I've pushed the patc

A concurrent VACUUM FULL?

Hi hackers, I've been looking at the code for CLUSTER/VACUUM FULL, and whether it is possible to do a concurrent version of it using a multi-transactional approach similar to concurrent reindexing and partition detach. The idea would be to hold weaker locks in TX1 when doing the heap rewrite (ess

Re: Logical Replication of sequences

On Fri, Jun 27, 2025 at 8:50 AM shveta malik wrote: > > On Wed, Jun 25, 2025 at 7:42 PM Shlok Kyal wrote: > > Hi Vignesh, > > > > I tested with all patches applied. I have a comment: > > > > Let consider following case: > > On publisher create a publication pub1 on all sequence. publication > > h

Re: Logical Replication of sequences

On Wed, Jun 25, 2025 at 9:26 AM shveta malik wrote: > > On Tue, Jun 24, 2025 at 6:44 PM Shlok Kyal wrote: > > > > > > 1. Initially, I have created a publication on sequence s1. > > postgres=# CREATE PUBLICATION pub1 FOR ALL SEQUENCES; > > CREATE PUBLICATION > > postgres=# ALTER PUBLICATION pub1 S

Re: pg_logical_slot_get_changes waits continously for a partial WAL record spanning across 2 pages

On Fri, Jun 27, 2025 at 9:29 PM vignesh C wrote: > > On Fri, 27 Jun 2025 at 07:05, Michael Paquier wrote: > > > > On Thu, Jun 26, 2025 at 05:25:42PM +0530, vignesh C wrote: > > > On Thu, 26 Jun 2025 at 06:22, Michael Paquier wrote: > > >> So you are suggesting the addition of an extra ReadPageIn

Re: Error with DEFAULT VALUE in temp table

> Hi everyone, > I found one bug, when you delete temporary table with DEFAULT VALUE. The > row about this VALUE in the pg_event_trigger_dropped_objects() contains > “False” in the column “is_temporary”. But if you look at column “name_obj”, > you see “for pg_temp.table_name”. So PostgreSQL know, t

Re: speedup COPY TO for partitioned table.

On 2025-06-27 16:14, jian he wrote: Thanks for updating the patch! On Thu, Jun 26, 2025 at 9:43 AM torikoshia wrote: After applying the patch, blank lines exist between these statements as below. Do we really need these blank lines? ``` scan_rel = table_open(scan_

Re: add function for creating/attaching hash table in DSM registry

Hi, Here is what I have staged for commit. > > Thank you for sharing the updated patch. This looks good to me. I used the GetNamedDSA added by this patch in my code and it worked fine. /* XXX: Should we verify params matches what table was created with? */ Are you planning to address the above

Re: Typo in pg_stat_activity definition

Thank you for comments! >> One thing that you are forgetting is that the regression >> tests are going to fail: rules.out reports the definition of >> pg_stat_activity, and the characters casing matters in this case. > >I doubt it --- the regression tests will show deparsing results, >which shoul

Report bytes and transactions actually sent downtream

Hi All, In a recent logical replication issue, there were multiple replication slots involved, each using a different publication. Thus the amount of data that was replicated through each slot was expected to be different. However, total_bytes and total_txns were reported the same for all the repli

Re: Logical Replication of sequences

On Wed, Jun 25, 2025 at 3:10 PM Shlok Kyal wrote: > > > 4. Since we are not adding sequences in the list 'sub_remove_rels', > should we only palloc for (the count of no. of tables)? Is it worth > the effort? > /* > * Rels that we want to remove from subscription and drop any slots > * and origins

Re: A concurrent VACUUM FULL?

Erik Nordström wrote: > Hi hackers, > > I've been looking at the code for CLUSTER/VACUUM FULL, and whether it is > possible to do a concurrent version of it using a > multi-transactional approach similar to concurrent reindexing and partition > detach. > > The idea would be to hold weaker loc

Re: Prevent internal error at concurrent CREATE OR REPLACE FUNCTION

On Fri, 27 Jun 2025 18:53:02 +0700 Daniil Davydov <3daniss...@gmail.com> wrote: > Hi, > > On Thu, Jun 5, 2025 at 5:21 PM Yugo Nagata wrote: > > > > I've attached updated patches. > > > > I have some comments on v4-0001 patch : Thank you for your comments! > 1) > heap_freetuple should be calle

Re: Missing program_XXX calling in pgbench tests

On 12.06.25 05:23, Hayato Kuroda (Fujitsu) wrote: +1 to focusing on the 0001 patch. Since this isn't a bug fix, I'm not sure back-patching is strictly necessary. That said, it does improve consistency and test coverage, e.g., by adding checks like help text length, so I'd be fine with back-patch

Re: pg_get_multixact_members not documented

On Mon, Jun 30, 2025 at 7:29 AM Ashutosh Bapat wrote: > > On Sat, Jun 28, 2025 at 4:02 AM Nathan Bossart > wrote: > > > > On Thu, Jun 12, 2025 at 03:10:56PM -0500, Nathan Bossart wrote: > > > Barring comments/objections, I'll plan on committing/back-patching this in > > > the near future. > > >

Re: Periodic FSM vacuum doesn't happen in one-pass strategy vacuum.

On Tue, Jun 24, 2025 at 6:59 PM Melanie Plageman wrote: > > So, I think we should commit the fix you proposed. > > The only question I have left is implementation: should we have > ndeleted as an output parameter of lazy_scan_prune() or have > lazy_scan_prune() return it (instead of void)? > > In

Re: pg_get_multixact_members not documented

On Mon, Jun 30, 2025 at 04:08:04PM +0300, Sami Imseih wrote: > Correct, I originally proposed the "Transaction ID and Snapshot > Information Functions" section, but as stated in [0], > pg_get_multixact_members does not fit the description of the section as > it is described as "The main use of the

Re: A concurrent VACUUM FULL?

HI Erik Nordström In online production environments, blocking writes is generally unacceptable in most cases. The only acceptable approach is to allow concurrent read/write operations, with brief locks permitted only during the final steps of the process. We can see pg-osc's implementation ( h

Re: [PoC] Federated Authn/z with OAUTHBEARER

On Mon, Jun 30, 2025 at 10:02 AM Daniel Gustafsson wrote: > > On 30 Jun 2025, at 18:58, Andres Freund wrote: > > Probably just needs to be added to the installed_targets list. > > Thanks for the report, I'll take a look today to get it fixed. Thanks both! Looking at the installed_targets stuff,

Re: BackendKeyData is mandatory?

On Mon, 30 Jun 2025 at 19:59, Jacob Champion wrote: > > On Wed, Jun 25, 2025 at 12:12 AM Jelte Fennema-Nio wrote: > > Attached is an attempt at implementing the above. I did not test it > > against these systems though. > > With 0001, psycopg2 appears to function again when talking to a server >

Re: pgsql: Introduce pg_shmem_allocations_numa view

On 6/27/25 19:33, Bertrand Drouvot wrote: > Hi, > > On Fri, Jun 27, 2025 at 04:52:08PM +0200, Tomas Vondra wrote: >> Here's three small patches, that should handle the issue > > Thanks for the patches! > >> 0001 - Adds the batching into pg_numa_query_pages, so that the callers >> don't need to d

Re: postmaster uses more CPU in 18 beta1 with io_method=io_uring

+#if defined(HAVE_LIBURING_QUEUE_INIT_MEM) && defined(IORING_SETUP_NO_MMAP) && 1 Is that && 1 intentional? Nit: + "mmap(%zu) to determine io_uring_queue_init_mem() support has failed: %m", IMHO that would read better without "has". + /* FIXME: This should probably not stay at DEBUG1? */ + elog(D

Re: Fix some inconsistencies with open-coded visibilitymap_set() callers

On Thu, Jun 26, 2025 at 3:56 PM Melanie Plageman wrote: > Here is a rebased version of this (it had some conflicts with recent commits). One general complaint is that the commit message complains about the status quo but isn't real clear about what the patch is actually fixing. I'm pretty concer

Re: A concurrent VACUUM FULL?

Hi Eric, Currently the first suggested approach "Rebuild indexes on the temporary heap in TX1 and then swap in the new indexes along with the new heap in TX2." sound good. It would be great if we are able to perform concurrent reads and writes. In OLTP environments will it lead to slowing of t

Re: BackendKeyData is mandatory?

On Wed, Jun 25, 2025 at 12:12 AM Jelte Fennema-Nio wrote: > Attached is an attempt at implementing the above. I did not test it > against these systems though. With 0001, psycopg2 appears to function again when talking to a server that doesn't send a cancellation key, so that's good. It looks li

Re: pg_get_multixact_members not documented

On Mon, Jun 30, 2025 at 06:19:10PM +0300, Sami Imseih wrote: > Perhaps we should think about removing this description, what do you think? I think it's a good topic for another patch/thread. Chances are it's not the only description that could be updated. >> Looking again, pg_get_multixact_membe

Re: [PATCH] Fix OAuth feature detection on OpenBSD+Meson

On Wed, Jun 25, 2025 at 3:46 AM Nazir Bilal Yavuz wrote: > I wanted to experiment with it. That was fast, thank you! > First, I got the current list of > features from upstream, then disabled the auto features, then > explicitly enabled these features. I did this only for FreeBSD to show > my id

Re: AIO v2.5

Hi, On 2025-06-30 08:58:21 +0200, Antonin Houska wrote: > Andres Freund wrote: > > > On 2025-03-13 11:53:03 +0100, Antonin Houska wrote: > > > Attached are a few proposals for minor comment fixes. > > > > Thanks, applied. > > After reading the code a bit more, I noticed that the 'cb_flags' arg

Re: add function for creating/attaching hash table in DSM registry

On Mon, Jun 30, 2025 at 01:29:22PM +0530, Rahila Syed wrote: > /* XXX: Should we verify params matches what table was created with? */ > > Are you planning to address the above before you commit? It seems like a > helpful check since GetNamedDshash takes the params as arguments. That > said, I d

Re: Improve error reporting in 027_stream_regress test

Hi, On 2025-06-30 16:01:04 +0300, Nazir Bilal Yavuz wrote: > This patch aims to improve 027_stream_regress test's regression test > error reporting per Andres' suggestion [1]. Thanks for working on that! One thing I don't yet like is that I think we should report if the primary is alive *before

Re: Issue with custom operator in simple case

AFAICS, we have the following problem constructions: a IS DISTINCT FROM b a IS NOT DISTINCT FROM b a IN (...) a NOT IN (...) CASE a WHEN b THEN ... ELSE d END NULLIF(a, b) JOIN USING / NATURAL JOIN As a quick recap, the following op

Re: postmaster uses more CPU in 18 beta1 with io_method=io_uring

> On Jun 30, 2025, at 12:27 PM, Andres Freund wrote: > > Hi, > > On 2025-06-05 14:32:10 -0400, Andres Freund wrote: >> On 2025-06-05 12:47:52 -0400, Tom Lane wrote: >>> Andres Freund writes: I think this is a big enough pitfall that it's, obviously assuming the patch has a se

GNU/Hurd portability patches

Hi, please find attached the current patches required to get master built and the testsuites run on Debian's hurd-i386 port. I have not had the time to test the hurd-amd64 port in the same fashion, but will do so next. As mentioned in this thread[1], one needs a fairly recent kernel for the high-

Re: pg_get_multixact_members not documented

> Sure, I am not against keeping the function in an existing section, but > we should remove the description mentioned above for clarity. to be clear, I am suggesting we just remove the second sentence in the description. Therefore, instead of: "The functions shown in Table 9.84 provide server tr

Adding wait events statistics

Hi hackers, Wait events are useful to know what backends are waiting for when there is/was a performance issue: for this we can sample pg_stat_activity at regular intervals and record historical data. That’s how it is commonly used. It could also be useful to observe the engine/backends behavior

Re: Periodic FSM vacuum doesn't happen in one-pass strategy vacuum.

On Mon, Jun 30, 2025 at 10:20 PM Melanie Plageman wrote: > > On Tue, Jun 24, 2025 at 6:59 PM Melanie Plageman > wrote: > > > > So, I think we should commit the fix you proposed. > > > > The only question I have left is implementation: should we have > > ndeleted as an output parameter of lazy_sca

array_random

hi. context: [1]. the attached patch already posted in [1]. I don't want to hijack another thread. so I post it in a separate thread. The attached patch introduces a new function: array_random. array_random description: Returns an array filled with random values in the range min <= x <= max, havi

Re: Collation & ctype method table, and extension hooks

On Sun, 2025-06-29 at 12:43 +0200, Peter Eisentraut wrote: > I wish we could take this further and also run the "ctype is c" case > through the method table.  Right now, there are still a bunch of > open-coded special cases all over the place, which could be unified.  > I > guess this isn't any

Re: NUMA shared memory interleaving

On 6/30/25 12:55, Jakub Wartak wrote: > Hi Tomas! > > On Fri, Jun 27, 2025 at 6:41 PM Tomas Vondra wrote: > >> I agree we should improve the behavior on NUMA systems. But I'm not sure >> this patch does far enough, or perhaps the approach seems a bit too >> blunt, ignoring some interesting st

Re: ALTER TABLE ALTER CONSTRAINT misleading error message

On 2025-Jun-30, Álvaro Herrera wrote: > > Just one note: Jian's patch doesn't handle the same issue for TRIGGER > > case, so that part might still need to be addressed. > > Okay, here's my take on this, wherein I reworded the proposed error > message. I also handled the NOT VALID case of a const

Re: Improve the performance of Unicode Normalization Forms.

On Tue, 2025-06-24 at 18:20 +0300, Alexander Borisov wrote: > That's what we're aiming for - to implement the fastest approach. Awesome! Thank you for clarifying this as a goal. Having the fastest open-source Unicode normalization would be a great thing to highlight when this is done. Regards,

Re: Issue with custom operator in simple case

On Mon, Jun 30, 2025 at 8:49 AM Maxim Orlov wrote: > 3) CVE-2018-1058 revert. > Rejected due to obvious reasons. > > Not revert but maybe try again at convincing people that DBAs should be given agency here by opting out of a security system that breaks functioning code without providing, in real

Re: ALTER TABLE ALTER CONSTRAINT misleading error message

On 2025-Jun-27, Fujii Masao wrote: > On 2025/06/27 22:30, Álvaro Herrera wrote: > > On 2025-06-27, Fujii Masao wrote: > > > > > To make this distinction, I just started thinking it's better to raise > > > the error > > > in ATExecAlterConstraint() rather than in gram.y. I've attached a draft > >

Re: [PoC] Federated Authn/z with OAUTHBEARER

Hi, On 2025-05-02 10:42:34 -0700, Jacob Champion wrote: > Great, thanks. I'll push it soon. I just noticed that I think the dependencies on the meson build aren't quite sufficient: andres@awork3:/srv/dev/build/postgres/m-dev-assert$ ninja install-quiet [2205/2205 1 100%] Generating install-quiet

Re: fix: propagate M4 env variable to flex subprocess

On Mon, Jun 30, 2025 at 11:25 AM Peter Eisentraut wrote: > On 17.06.25 07:15, Peter Eisentraut wrote: > > On 28.05.25 20:42, J. Javier Maestro wrote: > >> On Wed, May 28, 2025 at 6:08 PM Andres Freund >> > wrote: > >> > >> Hi, > >> > >> On 2025-05-17 23:32:24 -

Re: [PoC] Federated Authn/z with OAUTHBEARER

> On 30 Jun 2025, at 18:58, Andres Freund wrote: > > Hi, > > On 2025-05-02 10:42:34 -0700, Jacob Champion wrote: >> Great, thanks. I'll push it soon. > > I just noticed that I think the dependencies on the meson build aren't quite > sufficient: > > andres@awork3:/srv/dev/build/postgres/m-dev-a

Re: POC: enable logical decoding when wal_level = 'replica' without a server restart

Hi, On Mon, Jun 30, 2025 at 12:21:44PM +0530, shveta malik wrote: > On Mon, Jun 30, 2025 at 11:16 AM Masahiko Sawada > wrote: > > > > I'm not sure if there are users who want to disable the new behavior > > and use only the current behavior. I think we can focus on the new API > > and automatic

Re: [PATCH] Fix OAuth feature detection on OpenBSD+Meson

Hi, On Mon, 30 Jun 2025 at 17:45, Jacob Champion wrote: > > On Wed, Jun 25, 2025 at 3:46 AM Nazir Bilal Yavuz wrote: > > I wanted to experiment with it. > > That was fast, thank you! > > > First, I got the current list of > > features from upstream, then disabled the auto features, then > > expl

Re: New function normal_rand_array function to contrib/tablefunc.

hi. I don't want to disrupt this thread too much. so I created a separate thread ([1]) for my attached patch. [1] https://www.postgresql.org/message-id/CACJufxF8_VzCFRHRt4OHHF74QtB8tj5Z%3Ddjsy7Y31OHKG5s1-w%40mail.gmail.com

Re: pg_get_multixact_members not documented

> On Mon, Jun 30, 2025 at 04:08:04PM +0300, Sami Imseih wrote: > > Correct, I originally proposed the "Transaction ID and Snapshot > > Information Functions" section, but as stated in [0], > > pg_get_multixact_members does not fit the description of the section as > > it is described as "The main

Re: Allow ON CONFLICT DO UPDATE to return EXCLUDED values

On Tue, 24 Jun 2025 at 19:49, Dean Rasheed wrote: > > The attached patch allows EXCLUDED values to appear in the RETURNING > list of INSERT ... ON CONFLICT DO UPDATE. > > I still have a lot more testing to do, and docs to update, but so far > the results look promising. I'll add this to the next C

Re: postmaster uses more CPU in 18 beta1 with io_method=io_uring

Hi, On 2025-06-05 14:32:10 -0400, Andres Freund wrote: > On 2025-06-05 12:47:52 -0400, Tom Lane wrote: > > Andres Freund writes: > > > I think this is a big enough pitfall that it's, obviously assuming the > > > patch > > > has a sensible complexity, worth fixing this in 18. RMT, anyone, what do

Re: A concurrent VACUUM FULL?

On 2025-Jun-30, DINESH NAIR wrote: > In OLTP environments will it lead to slowing of the queries or query > performance issues Sure, to some extent, but ideally you wouldn't use it in a recurring fashion but only as an emergency solution out of a really serious bloat problem (so it's not so

Re: Proposal to allow DELETE/UPDATE on partitioned tables with unsupported foreign partitions

Hi all, The proposed change would make the behavior consistent with the cases > for INSERT/COPY into partitioned tables with non-insertable > foreign-table partitions, so +1 in general. Thanks for the initial feedback on making this behavior consistent with INSERT/COPY. Just wanted to follow up

Re: Tags in the commitfest app: How to use them and what tags to add?

On Mon, Jun 23, 2025 at 12:01 PM David G. Johnston wrote: > > Yes, categories, and give each category its own line in the table. I'm headed in the opposite direction. Let me elaborate with some very strong opinions about the existing tags. (No one has to share my strong opinions.) - Help - Bikes

Re: pg_dump --with-* options

On Mon, 2025-06-23 at 13:38 -0400, Robert Haas wrote: > What confuses me about what you've written here specifically is that > pg_dump and pg_restore are different programs with different option > sets. So when you say we need both --with-statistics and > --no-statistics, I guess that's true, but

Re: regdatabase

Committed. -- nathan

Re: Tags in the commitfest app: How to use them and what tags to add?

On Mon, 30 Jun 2025 at 22:48, Jacob Champion wrote: > I would also like to request that CFMs be given the ability to add and > edit (but maybe not delete?) tags. CC: Alvaro. Since he gave me this access, so hopefully he can do the same for the CFM group.

Re: On disable_cost

On Mon, Jun 30, 2025 at 8:14 PM Michael Paquier wrote: > In short, thanks all for the work done here! I'm glad to hear that you found it helpful! -- Robert Haas EDB: http://www.enterprisedb.com

Re: Correct comment atop PublicationPartOpt

On Tue, Jul 1, 2025 at 9:20 AM shveta malik wrote: > > I found the wrong function name mentioned in the comment atop > PublicationPartOpt. > > Comment wrongly mentioned the function name GetRelationPublications() > for PublicationPartOpt usage instead of GetPublicationRelations(). > Corrected the

Re: Periodic FSM vacuum doesn't happen in one-pass strategy vacuum.

On Mon, Jun 30, 2025 at 10:20 PM Melanie Plageman wrote: > > On Tue, Jun 24, 2025 at 6:59 PM Melanie Plageman > wrote: > > > > So, I think we should commit the fix you proposed. I agree with your analysis. > > > > The only question I have left is implementation: should we have > > ndeleted as a

Re: Restrict publishing of partitioned table with a foreign table as partition

On Mon, Jun 9, 2025 at 3:58 PM Shlok Kyal wrote: > > On Wed, 4 Jun 2025 at 16:12, Ajin Cherian wrote: > > > > On Tue, May 20, 2025 at 2:33 AM Shlok Kyal wrote: > > > > > > This approach seems better to me. I have created a patch with the > > > above approach. > > > > > > Thanks and Regards, > >

Re: pgsql: Introduce pg_shmem_allocations_numa view

Hi, On Mon, Jun 30, 2025 at 08:56:43PM +0200, Tomas Vondra wrote: > In particular it now uses "chunking" instead of "batching". I believe > bathing is "combining multiple requests into a single one", but we're > doing exactly the opposite - splitting a large request into smaller > ones. Which is w

Re: Logical Replication of sequences

On Mon, Jun 30, 2025 at 3:21 PM Nisha Moond wrote: > > Tab-completion is not supported after a comma (,) in any other cases. > For example, the following commands are valid, but tab-completion does > not work after the comma: > > CREATE PUBLICATION pub7 FOR TABLE t1, TABLES IN SCHEMA public; > CRE

Re: Fix typo in commens on ExecInsertIndexTuples

On Tue, Jul 1, 2025 at 11:42 AM Amit Langote wrote: > Hi Nagata-san, > > On Tue, Jul 1, 2025 at 11:02 AM Yugo Nagata wrote: > > > > Hi, > > > > I found typos in the comments of ExecInsertIndexTuples > > that mention TUUI_{All, Summarizing} but they should be > > TU_*. > > > > I've attached a patc

Re: back-patch documentation for age() and mxid_age()

On Mon, Jun 30, 2025 at 5:34 PM Nathan Bossart wrote: > These functions have been around for a while, but commits 48b5aa3 and > 15afb7d were only back-patched to v16. Any objections if I apply them down > to v13 now? Seems fine to me. -- Robert Haas EDB: http://www.enterprisedb.com

Re: Conflict detection for update_deleted in logical replication

On Mon, Jun 30, 2025 at 6:59 PM Zhijie Hou (Fujitsu) wrote: > > On Mon, Jun 30, 2025 at 7:22 PM Amit Kapila wrote: > > I was looking at 0001, it mostly looks fine to me except this one case. So here we need to ensure that commits must be acquired after marking the flag, don't you think we need t

Re: Conflict detection for update_deleted in logical replication

On Tue, Jul 1, 2025 at 10:31 AM Dilip Kumar wrote: > > On Mon, Jun 30, 2025 at 6:59 PM Zhijie Hou (Fujitsu) > wrote: > > > > On Mon, Jun 30, 2025 at 7:22 PM Amit Kapila wrote: > > > > > I was looking at 0001, it mostly looks fine to me except this one > case. So here we need to ensure that commi

Re: pg_dumpall dumps global objects with --statistics-only or --no-schema

> > > Since pg_dumpall treats global objects as schema-level content, it > currently > includes them with --schema-only but skips them with --data-only. By that > logic, > it should also skip them when either --statistics-only or --no-schema is > used. > Thought? > > +1, pending resolution of the d

Re: Inline non-SQL SRFs using SupportRequestSimplify

On 9/3/24 09:42, Tom Lane wrote: Paul Jungwirth writes: Here are new patches using a new SupportRequestInlineSRF request type. They include patches and documentation. I took a look through this. I feel like we're still some way away from having something committable. I've got two main comp

Re: pg_get_multixact_members not documented

On Mon, Jun 30, 2025 at 02:54:28PM -0500, Nathan Bossart wrote: > I noticed that this list of exceptions doesn't exist on v13-v15, presumably > because the docs for age() and mxid_age() were only back-patched to v16 > (see commits 48b5aa3 and 15afb7d), which is strange because I believe those > fun

Re: [PoC] Federated Authn/z with OAUTHBEARER

Hi, On 2025-07-01 00:52:49 +0200, Daniel Gustafsson wrote: > > On 30 Jun 2025, at 20:33, Jacob Champion > > wrote: > > > > On Mon, Jun 30, 2025 at 10:02 AM Daniel Gustafsson wrote: > >>> On 30 Jun 2025, at 18:58, Andres Freund wrote: > >>> Probably just needs to be added to the installed_targ

Correct comment atop PublicationPartOpt

Hi, I found the wrong function name mentioned in the comment atop PublicationPartOpt. Comment wrongly mentioned the function name GetRelationPublications() for PublicationPartOpt usage instead of GetPublicationRelations(). Corrected the comment. thanks Shveta v1-0001-Comment-correction-atop-Pu

Re: Tags in the commitfest app: How to use them and what tags to add?

On Mon, Jun 30, 2025 at 1:20 PM Jacob Champion wrote: > This category of tag is the best. It is completely new information, > not captured anywhere else in the UI, that is useful at the top level > and helps drive reviews forward by helping the community find > interesting things. Oh, and while I

  1   2   >