uery.
```
.. to something more like "provides a different syntax, similar to one
used in web search engines, to create tsqeury". And maybe give a few
examples right in the next sentence.
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
for corresponding projects.
Also today I'm going to contact Simone Gotti, the main developer of
Stolon, to let him know about this thread. I wonder what are his
thoughts on all this.
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
uite. That should be
> a pretty small patch and could be more generally useful.
>
> Thoughts?
Personally, I see how it could be useful and don't see any drawbacks of
such a patch. I think it's a good idea.
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
clean up a bitmap, PTRACK says there
are no changed pages", etc.
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
excluding connections establishing)
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
ing such tool. I changed the text on wiki, hopefully it's
better now.
[1]: https://github.com/afiskon/go-elector
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
eturns int
x ->> 'field2' -- returns string
```
The reason why some users may prefer procedures to operators is
that it's easy to make a typo in a field name. Procedures are safer in
this regard.
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
egards,
Aleksander Alekseev
signature.asc
Description: PGP signature
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
Hi Anthony,
Thank you for the new version of the patch!
So,
> please find it in compressed format in attachments.
I'm afraid that tests fail on Python 3:
```
SELECT test1set();
test1set
---
! "{None, 1, 'string'}"
(1 row)
DROP EXTENSION plpython3u CASCADE;
--- 296,302
SELECT test1set();
tes
a separate patch.
Thanks for the datasets though!
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
that you're open to having it as a new data type or as a
> bytea, but I don't agree. This should be a new data type, just as json
> is a distinct data type and so is jsonb.
Could you please explain in a little more detail why you believe so?
Also I wonder whether in your opinion the
ime, and
if we add implicit casting there will be little type safety left. In
pg_protobuf extension I choose to store Protobuf as bytea, but if
Charles prefer to introduce a separate type that's fine by me.
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
Hello Vladimir,
> I'm just trying to figure out what are the use cases for using that Thrift
> extension.
You can find an answer in the project description:
https://wiki.postgresql.org/wiki/GSoC_2018#Thrift_datatype_support_.282018.29
--
Best regards,
Aleksander Alekseev
signatu
Hello Charles,
I suggest to begin with the second approach and add to_jsonb/from_jsonb
later. Both approaches are fine but it seems to me that most users would
expect a separate type thus it's more important.
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
regarding encryption of the indexes
since they will be encrypted on the block level the same way the heap
will be.
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
Hello Charles,
> Can I assume the data in thrift is always send inside a struct?
Sure!
> I think this question also valid for protobuf?
Right, pg_protobuf assumes that data is always a message which is an
equivalent of Thrift's struct.
--
Best regards,
Aleksander Alekseev
signatu
sonally I think raw data bytes are OK if functions for getting all
keys and values from this data are provided. Another possibility is just
converting Thrift to JSONB and vise versa. In this case only two
procedures are required and all the rest is available out-of-the-box.
--
Best regards,
Alek
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
I can confirm this code works. However, since this is quite
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
Here are a few minor issues:
```
+/*
+ * Checks if 'str'
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
LGTM.
The new status of this patch is: Ready for Committer
hether tests should include hashing
non-ASCII characters as well.
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
.
TWIMC the full report can be found here:
https://afiskon.ru/s/3c/736207c9d2_valgrind-2018-02-20.tgz
--
Best regards,
Aleksander Alekseev
diff --git a/src/tools/valgrind.supp b/src/tools/valgrind.supp
index af03051260..accf989047 100644
--- a/src/tools/valgrind.supp
+++ b/src/tools/valgrind.supp
nable-cassert --enable-debug \
--enable-nls --with-perl --with-tcl --with-gssapi --with-ldap
```
The system is Arch Linux x64, GCC version is 7.3.0.
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
use this plugin (
> https://github.com/charles-cui/pg_thrift/blob/master/README.md).
> From this document, user knows how to install pg_thrift, how to parse out
> required fields from byte using provided api, how to build index based on
> the thrift bytes by the use of the api, and how to use the customized
> thrift type.
>
--
Best regards,
Aleksander Alekseev
there are no
stupid mistakes that will blow up someone's PostgreSQL instance :)
On Sun, Aug 5, 2018 at 11:04 PM, Aleksander Alekseev
wrote:
> Hello Charles,
>
> Thanks for keeping us informed. As you probably already discovered the
> email I used previously doesn't work any longer. Pleas
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
I can confirm that these patches don't break anything; the
re not fully
implemented in most existing libraries.
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
sql.org/wiki/GSoC_2018
Which one you are most interested in?
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
Protocol.scala#L15
[2]:
https://postgr.es/m/CA%2BSXE9sP1iHNp9_DFJzdbE0cszAA-QF8d-8GAUyoCA4q9KCsGw%40mail.gmail.com
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
Hello Christos,
> Do you have any project related insights as to what I should put in
> there?
Nope :) I believe Andrey Borodin and Atri Sharma have (added to CC).
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
that. In this case I will be happy to see any sorts of
projects related to Protobuf or any other binary format - Thrift, Avro,
Cap'n'Proto, MessagePack, etc!
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
will be most likely executed
on the system which doesn't has a PostgreSQL package installed. And it's
distributed separately just for this reason I believe.
[1]: https://git.postgresql.org/gitweb/?p=pg_filedump.git;a=summary
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
d other people vote for the links:
https://news.ycombinator.com/
https://www.reddit.com/r/PostgreSQL/
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
t to have
covering indexes support for GiST as well. Please don't forget to add
the thread to the nearest commitfest entry. I'm looking forward for the
next versions of your patch!
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
on and definition online?
Vim + Ctags. Editors like Sublime Text and Visual Studio Code have
features like "goto definition" out-of-the-box.
If you have any other questions please don't hesitate to ask!
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
Hello everyone,
I would like to let you know that unfortunately these patches don't apply
anymore. Also personally I'm a bit confused by the last message that has 0001-
and 0003- patches attached but not the 0002- one.
fixed that too.
I believe it's "Ready for Committer".
--
Best regards,
Aleksander Alekseev
diff --git a/src/backend/utils/adt/jsonb.c b/src/backend/utils/adt/jsonb.c
index 0f70180164..fb907f2a73 100644
--- a/src/backend/utils/adt/jsonb.c
+++ b/src/backend/utils/adt/jsonb.c
@@
s return errors nevertheless. That API would be complicated for
the users. Thus I suggest to accept any garbage and try our best to
interpret it.
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
people will have a hard time
> figuring out what the source of that error message is. It seems like
> it would be better to say something about casting or converting in the
> error message, to give users a clue.
I agree. How about "unable to cast jsonb value to %typename%"?
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
eger to jsonb
> LINE 1: select 123::int4::jsonb;
> ```
>
> I suggest to follow the same template, i.e. "cannot cast type jsonb to
> bool", etc.
On second thought this message is misleading. We can cat jsonb to bool,
the problem is that the document is not a bool value.
to
bool", etc.
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
LGTM.
The new status of this patch is: Ready for Committer
don't hesitate to ask!
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
uestion. If you have other questions please
don't hesitate to ask!
[1]: https://github.com/postgrespro/zson
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
WS deploys it. (Assuming there is a PostgreSQL core developer
interested in this particular task and he or she has time to spare.)
It is my understanding that waiting a few years is not an option in your
case. This is why I'm proposing an alternative solution.
--
Best regards,
Aleksander
It seems that this patch doesn't apply anymore, see
http://commitfest.cputube.org/
The new status of this patch is: Waiting on Author
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation:not tested
Hello Michael,
It looks like that this patch doesn't apply anymore:
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation:not tested
Unfortunately this patch doesn't apply anymore:
TC+3) right now
though so I'm going to make it tomorrow.
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
Hello David,
> Just a few days left until the last Commitfest for the PG11 release begins!
>
> I'm planning to fill the CFM role, unless there are objections.
Thank you for volunteering!
I would like to be CFM assistant, if you need one :)
--
Best regards,
Aleksander Alekseev
sign
only from the backend.
[1]: https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=4eda0a64705
[2]: https://postgr.es/m/20150806070902.ge12...@awork2.anarazel.de
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
stions are
> welcomed!
To my best knowledge currently there are no other students interested in
this particular work.
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
y notified the author. I'll try to write a script that exports
data from this site as well to make cross-checking easier.
If there is anything else I can help you with, just let me know.
--
Best regards,
Aleksander Alekseev
#!/usr/bin/env python3
# vim: set ai et ts=4 sw=4:
import requests
import s
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: not tested
Spec compliant: not tested
Documentation:not tested
Unfortunately according to http://commitfest.cputube.org/ this patch
optimization... don't remember exact words and who
said this.
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
Raw data is attached.
[1]: https://github.com/afiskon/py-autoreviewer
--
Best regards,
Aleksander Alekseev
data.sql.gz
Description: application/gzip
signature.asc
Description: PGP signature
w_to_json(tbl))) from tbl;
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
ARED-PRELOAD-LIBRARIES
--
Best regards,
Aleksander Alekseev
Hi Michael,
> /* The type can never be NULL */
> type = getObjectTypeDescription(, true);
The last argument should be `false` then.
--
Best regards,
Aleksander Alekseev
v4-0001-pg_event_trigger_ddl_commands.patch
Description: Binary data
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
This patch looks fine. Tested on MacOS Catalina; master
d (or before) will be very
useful.
The patch applies to `master` branch (6d177e28) and passes all the
tests on MacOS.
--
Best regards,
Aleksander Alekseev
ile. The patch is fine.
> The new status of this patch is: Ready for Committer
--
Best regards,
Aleksander Alekseev
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: tested, failed
Spec compliant: tested, failed
Documentation:tested, failed
This patch looks good to me. Considering a positive response
ines of
code in C. It addresses a somewhat specific scenario, which, to my
regret, doesn't seem to be uncommon. A pain-killer of a sort. In an
ideal world, people suppose simply to normalize their data.
--
Best regards,
Aleksander Alekseev
may consider adding ZSON to /contrib/.
If this is the case I will add this thread to the nearest CF and submit a
corresponding patch.
[1]: https://github.com/postgrespro/zson
--
Best regards,
Aleksander Alekseev
Open-Source PostgreSQL Contributor at Timescale
patch is in the attachment. I
added this thread to the CF and updated the status to "Ready for
Committer".
--
Best regards,
Aleksander Alekseev
v2-0001-Fix-pg_event_trigger_ddl_commands.patch
Description: Binary data
would
appreciate some code review.
--
Best regards,
Aleksander Alekseev
v1-0001-zson.patch
Description: Binary data
test_integerset.c. Here is an updated patch.
--
Best regards,
Aleksander Alekseev
diff --git a/contrib/file_fdw/file_fdw.c b/contrib/file_fdw/file_fdw.c
index 2c2f149fb0..146b524076 100644
--- a/contrib/file_fdw/file_fdw.c
+++ b/contrib/file_fdw/file_fdw.c
@@ -1188,7 +1188,7 @@ file_acquire_sample_ro
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
Although the patch looks OK I would like to keep the status
Sorry for a duplicate entry on CF web application
ass the tests. I'm currently in the process of
reviewing it and didn't figure out what the issue is yet. Just wanted to
let you know. I also believe changing the patch status to "Waiting on
Author" would be appropriate.
--
Best regards,
Aleksander Alekseev
wip.patch
Description: Binary data
;> 5) not valid;
ALTER TABLE
eax=# alter table foo validate constraint ba
bar baz
eax=# alter table foo validate constraint bar;
ALTER TABLE
--
Best regards,
Aleksander Alekseev
v2-0001-tab-completion-of-ALTER-TABLE.VALIDATE-CONSTRAINT.patch
Description: Binary data
ceive a complaint during beta-testing we can revert the patch
or maybe increase the limit for small messages.
--
Best regards,
Aleksander Alekseev
Hi hackers,
> Otherwise the patch passes all the tests and works as expected
I've noticed there is no tab completion for ALTER TABLE xxx ADD. Here
is an alternative version of the patch that fixes this as well. Not
sure if this should be in the same commit though.
--
Best regards,
Aleksan
hub.com/afiskon/pgscripts
--
Best regards,
Aleksander Alekseev
omeone could do it, it would be nice.
[1]: https://github.com/timescale/timescaledb/issues/1655
--
Best regards,
Aleksander Alekseev
Hi Tom,
> scratches head ... ] The patch still applies perfectly cleanly
> for me, using either "patch" or "git apply".
Sorry, my bad. It was about lines separating on different platforms. The
patch is fine and passes installcheck-world on MacOS.
--
Best regards,
Aleksander Alekseev
leksander,
>
> On Wed, Apr 28, 2021 at 01:19:36PM +0300, Aleksander Alekseev wrote:
> > Hi Julien,
> >
> > > I'm attaching a patch that fixes those, with regression tests to
> reproduce each
> > > problem.
> >
> > I believe something c
elease notes.
--
Best regards,
Aleksander Alekseev
v2-0001-costumscan_projection_flag.patch
Description: Binary data
e gss_krb5_ccache_name call is not made and the
> current behaviour (of letting the GSSAPI library work out the location
> of the ccache) is not changed.
>
> Many thanks,
> Daniel
>
--
Best regards,
Aleksander Alekseev
> There is an omission of automatic completion of CURRENT_ROLE in
> tab-complete.c.
I invested some time in checking this patch. It passes make
check-world / make installcheck-world and adds CURRENT_ROLE to the
automatic completion.
--
Best regards,
Aleksander Alekseev
ough the mailing list but
didn't find anything relevant. The complete script that reproduces the
issue is attached. I'm using the same script on Ubuntu VM, where it works
just fine.
[1]: https://github.com/rbenv/rbenv/issues/962#issuecomment-275858404
--
Best regards,
Aleksander Alekseev
#!/usr/b
unt. If the scenario above happens, there can exist a VPN account that
> does not have any presence in the central database and can be a security
> issue.
>
> I hope I explained it sufficiently. :-)
>
> Do you think, that would be possible to implement a process that would solve
> this use case?
>
> Thank you
> Ondrej
--
Best regards,
Aleksander Alekseev
Hi Tom,
Many thanks, running "make install" before "make check" helped.
On Tue, Apr 20, 2021 at 6:02 PM Tom Lane wrote:
>
> Aleksander Alekseev writes:
> > While trying to build PostgreSQL from source (master branch, 95c3a195) on a
> > MacBoo
on the master happened before receiving replies from the standby(s).
[1]:
https://www.postgresql.org/docs/13/runtime-config-wal.html#GUC-SYNCHRONOUS-COMMIT
--
Best regards,
Aleksander Alekseev
ccept a patch as is to make existing users suffer less and
iterate afterward. Or we choose not to do it and to come up with
another idea. Personally, I don't have any better ideas, thus maybe
accepting Andrey's patch would be the lesser of two evils.
--
Best regards,
Aleksander Alekseev
is the patch.
--
Best regards,
Aleksander Alekseev
v3-0001-timezone_volatility.patch
Description: Binary data
().
Am I missing something?
--
Best regards,
Aleksander Alekseev
,
Aleksander Alekseev
v1-0001-timezone_volatility.patch
Description: Binary data
v2-0001-timezone_volatility.patch
Description: Binary data
David, Tom,
> Well, given that the limitation is documented I’d have to say it is
> intentional:
> [...]
> That's intentional, per the fine manual:
> [...]
My bad, I missed this. Many thanks!
--
Best regards,
Aleksander Alekseev
--
Best regards,
Aleksander Alekseev
It looks like this patch rotted a little and needs to be rebased. Please see
http://cfbot.cputube.org/
The new status of this patch is: Waiting on Author
It looks like this patch needs to be updated. According to
http://cfbot.cputube.org/ it applies but doesn't pass any tests. Changing the
status to save time for reviewers.
The new status of this patch is: Waiting on Author
installcheck-world. After some
searching through the code, I was unable to identify any places where
the logic will break. Although this only proves my inattention, the
easiest way to make any further progress seems to apply the patch.
--
Best regards,
Aleksander Alekseev
Hi Andrey,
> only performance issues
That's interesting. Any chance you could share the hardware
description, the configuration file, and steps to reproduce with us?
--
Best regards,
Aleksander Alekseev
ack, and if
something will go wrong, you are on your own.
Of course, there is a possibility that something has changed in the past
four years. I'm sure somebody on the mailing list will correct me in this
case.
[1] https://wiki.postgresql.org/wiki/PgCon_2017_Developer_Meeting
--
Best regards,
Aleksan
known distance. In other words,
it's possible to copy `oldhash` to `newhash` and then move only half
of the items. I don't claim that this code necessarily should be
faster, or that this should be checked in the scope of this work.
--
Best regards,
Aleksander Alekseev
v9-0003-Optimize-hash-function.
L was built on MacOS Catalina without the `--with-system-tzdata=` flag.
Is it a bug or this behavior is intentional (something to do with SQL
standard, perhaps)?
--
Best regards,
Aleksander Alekseev
easons for such poor
> performance.
Let's say, any information regarding bottlenecks that affect real users
with real queries is of interest. Artificially created queries that are
unlikely to be ever executed by anyone are not.
--
Best regards,
Aleksander Alekseev
1 - 100 of 709 matches
Mail list logo
