On Mon, Jan 4, 2021 at 02:42:16PM -0500, Tom Lane wrote:
> Bruce Momjian writes:
> > Our developer FAQ mentions context diffs in several places for their
> > improved readability:
> > https://wiki.postgresql.org/wiki/Developer_FAQ
>
> I think that's kind of
On Tue, Jan 5, 2021 at 11:21:07AM +1300, Thomas Munro wrote:
> On Tue, Jan 5, 2021 at 8:07 AM Bruce Momjian wrote:
> > * "git apply" and "git am" can't process context diffs (they throw an
> >error once a context-like section of the diff is hit;
On Tue, Jan 5, 2021 at 08:23:15PM +0100, Joel Jacobson wrote:
> út 5. 1. 2021 v 18:51 odesílatel Bruce Momjian napsal:
> > I think I tried to make this feature more visible a few years ago and
> > some people said we might remove it someday, so don't do that. If that
>
On Wed, Jan 6, 2021 at 10:21:22AM +1300, Thomas Munro wrote:
> On Wed, Jan 6, 2021 at 6:58 AM Bruce Momjian wrote:
> > On Tue, Jan 5, 2021 at 11:21:07AM +1300, Thomas Munro wrote:
> > > For the record, cfbot just uses plain old GNU patch, because that
> > > seems
don't have a case for libpq yet, but I object to the lack
> of protection against overflows.
Fine. Do you want to add the overflow to the patch I posted, for all
encoding types?
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterp
defaults.
Well, you know fsyncs are required to recover from an OS crash, which is
more likely than detecting data corruption.
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
0.html#July_1_2020
I am not clear this is a feature we will want. Yes, people ask for it,
but if the experience will be bad for them and they will regret using
it, I am not sure we want it. Of course, if you code it up and we get
a good user experience, we would want it --- I am just saying it is
On Fri, Jan 1, 2021 at 01:07:50AM -0500, Bruce Momjian wrote:
> On Thu, Dec 31, 2020 at 11:50:47PM -0500, Bruce Momjian wrote:
> > I have completed the key management patch with tests created by Stephen
> > Frost. Original patch by Masahiko Sawada. It requires the hex
> >
On Thu, Jan 7, 2021 at 04:08:49PM -0300, Álvaro Herrera wrote:
> On 2021-Jan-07, Bruce Momjian wrote:
>
> > All the tests pass now. The current src/test directory is 19MB, and
> > adding these tests takes it to 23MB, or a 20% increase. That seems like
> > a lot. It is
On Thu, Jan 7, 2021 at 10:02:14AM -0500, Bruce Momjian wrote:
> My next step is to add the high-level tests.
Here is the high-level script, and the log output. I used the
pg_upgrade test.sh as a model.
It uses "CFE DEBUG" lines that are already in the code to compare the
initdb en
he problems you see, I will confirm each specific issue
> one by one.
Well, the email thread I linked to has a lot of them, but the
fundamental issue is that you have to break the logic that a single
index serves a single heap file. Considering what I said above, is
there enough usefulness to
> If checksums were enabled by default, the cheap crowd would benefit
> from the early warnings that something has gone wrong.
>
> The serious crowd are more likely to choose a non-default setting
> to avoid paying the price for a feature that they don't need.
I think you have
ot be affected. Only newly init'd clusters would get this setting.
I think once we have better online enabling of checksums people can more
easily test the overhead on their workloads.
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
On Fri, Jan 8, 2021 at 05:06:24PM +0100, Magnus Hagander wrote:
> On Fri, Jan 8, 2021 at 4:57 PM Bruce Momjian wrote:
> > I think once we have better online enabling of checksums people can more
> > easily test the overhead on their workloads.
>
> Yeah, definitely.
>
&
suite and test it, imv.. If anyone wants to
> volunteer, I'd be happy to explain how to make that happen (it's not
> hard though- download/unzip the files, drop them in the directory,
> update the test script to add all the files into the array).
Yes, do we have a place to store
too.
Yes, I was relieved. The pattern of when zero-length strings fail in
which modes is still very odd, but at least it reports an error, so it
isn't returning incorrect data.
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterprisedb.com
On Sat, Jan 9, 2021 at 08:08:16PM -0500, Bruce Momjian wrote:
> On Sat, Jan 9, 2021 at 01:17:36PM -0500, Bruce Momjian wrote:
> > I know we are still working on the hex patch (dest-len) and the crypto
> > tests, but I wanted to post this so people can see where we are, and we
&
In talking to Teodor this week, I have written the attached C comment
patch which improves our description of GiST's NSN and GistBuildLSN
values.
--
Bruce Momjian https://momjian.us
EDB https://enterprisedb.com
The usefulness of a cup
On Tue, Mar 2, 2021 at 10:25:23PM +0500, Andrey Borodin wrote:
>
>
> > 2 марта 2021 г., в 21:40, Bruce Momjian написал(а):
> >
> > In talking to Teodor this week, I have written the attached C comment
> > patch which improves our description of GiST's NSN an
x. For example, a per-row bitmap that is based on
what indexes exist at time of row creation might cause unacceptable
problems in handling create/drop index. Would you number indexes? I am
not saying you have to solve all the problems now, but you have to keep
your eye on obstacles that might blo
appen.)
Agreed. If you document the hooks too much, it allows them to drift
away from matching the code, which makes the hook documentation actually
worse than having no hook documentation at all.
--
Bruce Momjian https://momjian.us
EDB https://en
On Mon, Feb 15, 2021 at 02:02:02PM +0100, Daniel Gustafsson wrote:
> > On 11 Feb 2021, at 14:10, Bruce Momjian wrote:
> > I don't think anyone has done anything wrong --- rather, it is what we
> > are _trying_ to do that is complex.
>
> Global state changes in a clu
> intention
> behavior?
Postgres can't always propogate the type modifier for all expresions, so
it basically doesn't even try. For example, the modifier for || would
be very complex.
--
Bruce Momjian https://momjian.us
EDB https:
d-columns bitmaps will end up only being used with the
> redirected LPs to help reduce heap bloat after single-page vacuuming.
> In that case, new indexes would probably avoid the existing bitmaps
> anyway.
Yes, that would probably work, sure.
--
Bruc
On Tue, Mar 2, 2021 at 11:40:21AM -0500, Bruce Momjian wrote:
> In talking to Teodor this week, I have written the attached C comment
> patch which improves our description of GiST's NSN and GistBuildLSN
> values.
Patch applied.
--
Bruce Momjian https://mo
t, hence the "weird" maths. I had a lot of bad
> not-really-working ideas before the current status of the patch.
>
> The code could be simplified if we assume that PG_INT128_TYPE will be
> available on all relevant architectures, and accept the feature not to be
> av
ing the Makefile and just keep the configure compile path for it.
>
> I concluded that if thread_test.c will only be used by configure,
> then we should stick it under $(SRCDIR)/config/ and nuke the
> src/test/thread/ subdirectory altogether. See attached.
Sounds good.
--
Bruce Mom
for failing in that case:
> | * The creation of the version directory prevents more than one tablespace
> | * in a single location.
I think it is best to report an error --- pg_upgrade rarely tries to fix
things because that adds complexity, and perhaps bugs.
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
n't quite have the right
> > ring to me. I'm happy for other suggestions on the parameter names.
>
> What scripts are left after we remove the analyze script, as discussed in a
> different thread?
There is still delete_old_cluster.sh.
--
Bruce Momjian https://m
on the USB key --- seems clearer than having
to create a script to 'cat' the file.
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
27;re probably going
> to want to do so separately to block-level whole-cluster encryption,
> in a way that preserves the normal page and page item structure and
> encrypts the row data only.
Agreed.
> * Client-driver-assisted transparently encrypted
> at-rest-and-in-transit data, wh
On Tue, Oct 27, 2020 at 12:35:56PM +0100, Peter Eisentraut wrote:
> On 2020-10-27 11:53, Bruce Momjian wrote:
> > On Tue, Oct 27, 2020 at 11:35:25AM +0100, Peter Eisentraut wrote:
> > > On 2020-10-06 12:26, Magnus Hagander wrote:
> > > > I went with the name --no-inst
On Tue, Oct 27, 2020 at 10:02:53PM +0800, Craig Ringer wrote:
> On Tue, 27 Oct 2020, 19:15 Bruce Momjian, wrote:
> We don't need to do anything except provide a way to tell OpenSSL where to get
> the KEK from, for situations where having Pg generate it internally
> undesirable.
be
> between then and now"
>
> *Point-In-Time Recovery
>
> - Allow archive_mode to be changed without server restart
> Controversial and old
>
> *Standby server mode
>
> - Allow pg_xlogfile_name() to be used in recovery mode
> Controversial and old
>
> - Change walsender so that it applies per-role settings
> Old and possibly obsolete
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
On Tue, Oct 27, 2020 at 03:46:14PM -0400, Bruce Momjian wrote:
> On Tue, Oct 27, 2020 at 03:24:35PM -0400, John Naylor wrote:
> > As I mentioned in [1], I've volunteered to clear out the TODO list of items
> > that appear to be too difficult, controversial, or otherwise not
On Tue, Oct 27, 2020 at 04:54:24PM -0400, John Naylor wrote:
>
>
> On Tue, Oct 27, 2020 at 3:52 PM Bruce Momjian wrote:
>
>
> Do any of these limitations need to be documented before removing them
> from the TODO list?
>
>
> I see two
On Tue, Oct 27, 2020 at 10:20:35AM -0400, Bruce Momjian wrote:
> I don't know much about how to hook into that stuff so if you have an
> idea, I am all ears. I have used OpenSSL with Yubikey via pksc11. You
> can see the use of it on slide 57 and following:
>
> htt
On Wed, Oct 28, 2020 at 09:24:35PM +0900, Masahiko Sawada wrote:
> On Tue, 27 Oct 2020 at 20:34, Bruce Momjian wrote:
> > You need to use separate keys for heap/index and WAL so you can
> > replicate to another server that uses a different heap/index key, but
> > the same WA
On Wed, Oct 28, 2020 at 12:02:46PM +0800, Craig Ringer wrote:
> On Wed, Oct 28, 2020 at 9:43 AM Bruce Momjian wrote:
> I have used OpenSSL with Yubikey via pksc11. You
> can see the use of it on slide 57 and following:
>
> https://momjian.u
On Wed, Oct 28, 2020 at 02:29:16PM -0400, Bruce Momjian wrote:
> On Wed, Oct 28, 2020 at 12:02:46PM +0800, Craig Ringer wrote:
> > Yes, that's possible. But in that case the passphrase will be asked for by
> > openssl only when required, and we'll need to supply an
On Wed, Oct 28, 2020 at 05:16:32PM +0800, Craig Ringer wrote:
> On Wed, Oct 28, 2020 at 12:02 PM Craig Ringer
> wrote:
>
> On Wed, Oct 28, 2020 at 9:43 AM Bruce Momjian wrote:
> >
>
> I don't know much about how to hook into that stuff so if you hav
least has create permission for the public schema
--- that way, when you are creating a role, you can decide if the role
should have creation permissions in the public schema, rather than
having people always using the database owner for this purpose.
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
ther user before this
becomes a usability issue. It seems at the time the first user is
created (non-postgres), the admin needs to decide how the public schema
should behave.
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
es can be fully used by the optimizer. Instead of
putting this mention in the maintenance section, I thought the CREATE
INDEX page make more sense, since it is more of a usability issue,
rather than "why use expression indexes". Patch attached, which I plan
to apply to all supported
to "when time
> permits".
I don't understand what this is referring to. Thanks for the rest of
the work.
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
On Mon, Nov 2, 2020 at 02:23:35PM +0100, Magnus Hagander wrote:
> On Tue, Oct 27, 2020 at 12:40 PM Bruce Momjian wrote:
> >
> > On Tue, Oct 27, 2020 at 12:35:56PM +0100, Peter Eisentraut wrote:
> > > On 2020-10-27 11:53, Bruce Momjian wrote:
> > > > On T
n from json?
I think we could do it, but it would only work if the column was output
as a single json value, and not a multi-key/value field. I am afraid if
we tried to do it, the result would be too inconsistent to be useful.
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
m specific wrappers (debian, redhat, windows or
> whatever) knows more and could do a more complete job, but trying to
> make all that generic is very complicated.
Agreed, but I don't see OS-specific instruction on how to delete the
tablespaces as reasonable --- that should be don
On Wed, Nov 11, 2020 at 11:21:22AM -0500, Bruce Momjian wrote:
> On Wed, Nov 11, 2020 at 05:11:38PM +0100, Magnus Hagander wrote:
> > > In summary, I think the vacuumdb --analyze is now a one-line command,
> > > but the delete part can be complex and not easily typed.
> &
On Wed, Nov 11, 2020 at 05:39:10PM +0100, Magnus Hagander wrote:
> On Wed, Nov 11, 2020 at 5:38 PM Bruce Momjian wrote:
> >
> > On Wed, Nov 11, 2020 at 11:21:22AM -0500, Bruce Momjian wrote:
> > > On Wed, Nov 11, 2020 at 05:11:38PM +0100, Magnus Hagander wrote:
> >
trying to find out what happened, or how to
> configure equivalent functionality.
I don't see the logic in carrying doc stuff that we don't have anymore.
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterprisedb.com
The use
On Wed, Nov 11, 2020 at 08:59:40PM +0100, Daniel Gustafsson wrote:
> > On 11 Nov 2020, at 20:44, Bruce Momjian wrote:
> > On Tue, Nov 10, 2020 at 01:38:14PM +0800, Craig Ringer wrote:
>
> >> I noticed that when recovery.conf was removed in 2dedf4d9a8 (yay!) the
&g
On Thu, Nov 12, 2020 at 12:18:49AM +, Dagfinn Ilmari Mannsåker wrote:
> Bruce Momjian writes:
> > I think we could do it, but it would only work if the column was output
> > as a single json value, and not a multi-key/value field. I am afraid if
> > we tried to do it, th
l.org
This naming change has not happened yet, even though the issue is 11
months old, but the agreed-upon way to handle this is to use a website
redirect that links to the new text. You can add a "tip" there so they
understand the renaming has happened.
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
es, I am thinking someone could go back and add redirects for previous
renames too. It would be interesting also to scrape the web logs for
404 errors to see which renames cause the most failures and do those
first.
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
e would have to say it would be the first or a random match of one
of the keys. Ultimately, it might be so awkward as to be useless.
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
his as, "We thought about it, and we decided it is
probably not a good idea."
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
I'd rather us not stand in his way if he wants to try
> (With disclaimer that we might end up not liking the patch, of course).
I think he would be better outlining how he wants it to behave before
even working on a patch; from our TODO list:
Desirability -> Design -> Imple
On Thu, Oct 15, 2020 at 12:43:22PM -0400, Bruce Momjian wrote:
> On Thu, Oct 15, 2020 at 12:01:21PM -0400, Tom Lane wrote:
> > Bruce Momjian writes:
> > > We would want the timeline history file contents label changed from
> > > BYTEA to TEXT in the docs changed for al
On Mon, Nov 9, 2020 at 08:35:46PM -0300, Fabrízio de Royes Mello wrote:
>
>
> On Mon, 9 Nov 2020 at 20:27 Bruce Momjian wrote:
>
>
> I see REINDEX CONCURRENTLY was fixed in head, but the docs didn't get
> updated to mention the need to run ANALYZE or
ay "about the
> expressions".
How is this followup patch?
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
diff --git a/doc/src/sgml/ref/create_index.sgm
On Thu, Nov 12, 2020 at 06:36:39PM -0800, Noah Misch wrote:
> On Mon, Nov 09, 2020 at 02:56:53PM -0500, Bruce Momjian wrote:
> > On Mon, Nov 2, 2020 at 11:05:15PM -0800, Noah Misch wrote:
> > > My plan is for the default to become:
> > >
> > > GR
t know what's wrong with
> just fixing the docs...
Because at a certain point the number of _old_ names in the docs
obscures exactly how to operate the current software. We have tried
keeping stuff around, and we are very bad at removing stuff.
--
Bruce Momjian https:
we have
thought about it a lot, which is evident from the URL I sent you
already.
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
On Thu, Nov 12, 2020 at 10:41:49PM -0500, Bruce Momjian wrote:
> On Fri, Nov 13, 2020 at 11:37:16AM +0800, Craig Ringer wrote:
> > I have a draft patch that adds them and various related index
> > cross-referencing
> > in my tree to submit after the recovery.conf docs patc
On Fri, Nov 13, 2020 at 01:27:34PM +0800, Craig Ringer wrote:
> On Fri, Nov 13, 2020 at 11:50 AM Bruce Momjian wrote:
>
>
> > So you are saying you don't think you are getting sufficient thought
> > into your proposal, and getting just a reflex? Just beca
On Mon, Nov 16, 2020 at 11:59:03AM -0300, Álvaro Herrera wrote:
> On 2020-Nov-12, Bruce Momjian wrote:
>
> > For new expression indexes, it is necessary to run > linkend="sql-analyze">ANALYZE or wait for
> > the autovacuum daemon to analyze
> &
On Mon, Nov 16, 2020 at 11:04:57AM -0300, Álvaro Herrera wrote:
> On 2020-Nov-16, Erik Rijkers wrote:
>
> > This one seems to have fallen by the wayside.
>
> So it did.
>
> Pushed to all three branches, thanks.
I have applied with to PG 9.5-11, which also had the o
ink I added this one since there is no URL,
or it is very old.
> - More sensible support for Unicode combining characters, normal forms
> We have normalization as of PG13, so I propose to mark this Done rather than
> move it.
Agreed. Also done items should be remove
On Thu, Nov 19, 2020 at 11:15:33AM -0500, Joe Conway wrote:
> On 11/19/20 11:06 AM, Tom Lane wrote:
> > Let's just rip it out and be done. If anyone is ever
> > motivated to make it work per spec, they can resurrect
> > whatever seems useful from the git history.
>
On Mon, Nov 23, 2020 at 10:41:25AM -0400, John Naylor wrote:
> With the exception of "Fix /contrib/btree_gist's implementation of inet
> indexing", all items above have been either moved over, or removed if they
> were
> done already by PG13.
Thanks.
--
B
x27;s "common users", they are
> global for the whole instance (aka "cluster" in Postgres' terms). There
> are no database specific users.
Good to know.
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
pg_upgrade not only output progress
messages, but created files in the current directory, while initdb, by
definition, is creating files in PGDATA.
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
it's actually the "detected parameter values" that are the most
> interesting parts.
Originally, initdb did take some time for each step.
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
ur attention from the slightly
> more useful info printed ahead of it.
I think the question is not how many people who run initdb in any form
need the instructions to start Postgres, but how many who are actually
seeing the initdb output need those instructions. If someone isn't
seeing the init
hen let's wait until someone does want to fix
them all.
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
On Mon, Nov 30, 2020 at 11:31:35AM -0700, David G. Johnston wrote:
> On Mon, Nov 30, 2020 at 11:25 AM Bruce Momjian wrote:
>
> On Mon, Nov 30, 2020 at 10:11:04AM +0800, Craig Ringer wrote:
> > Can we please just address this docs issue? If you don't like my
r small caps an improvement for "SQL", so I'd prefer to never
> use SQL. also makes the markup longer (though
> one could mitigate that with an entity like &SQL). However, standardizing on
> either way is better than varying within the manual.
I
w they do it. The required information is spread
> over a lengthy thread. No one wants to read that. Add commit messages to
> the patches.
Oh, I see that now, and agree that you need to explain each item with a
comment. pg_upgrade is doing some odd things, so documenting everything
it does is
On Mon, Jan 11, 2021 at 04:45:14PM +0900, Michael Paquier wrote:
> On Wed, Jan 06, 2021 at 08:58:23AM -0500, Bruce Momjian wrote:
> > Fine. Do you want to add the overflow to the patch I posted, for all
> > encoding types?
>
> Yeah. It looks that it would be good to be c
On Mon, Jan 11, 2021 at 08:12:00PM +0900, Masahiko Sawada wrote:
> On Sun, Jan 10, 2021 at 11:51 PM Bruce Momjian wrote:
> > OK, here they are with numeric prefixes. It was actually tricky to
> > figure out how to create a squashed format-patch based on another branch.
>
done by Oracle12c.
> For 2) ATTACH new empty child table can also be completed immediately.
> If this is the case, many of the advantages of partitioned tables will be
> retained, while the advantages of global indexes will be gained.
Yes, we can keep the index rows for the deleted partition
hy key
> management is such an important part of this effort.
Yes, this would avoid the need to failover to a standby for data key
rotation.
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
On Mon, Jan 11, 2021 at 01:23:27PM -0500, Stephen Frost wrote:
> Greetings,
>
> * Bruce Momjian (br...@momjian.us) wrote:
> > On Mon, Jan 11, 2021 at 12:54:49PM -0500, Stephen Frost wrote:
> > > Although, another approach and one that I've discussed a bit with Bruc
d.
Yeah, I had not really gotten that far in my thinking, but someone is
going to need to create a POC and then we need to test it to see if it
offers a reasonably valuable feature.
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterprisedb.com
not be much usefulness left. A POC patch might tell
us that, and might allow us to mark it as "not wanted".
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
On Mon, Jan 11, 2021 at 02:19:22PM -0500, Stephen Frost wrote:
> Greetings,
>
> * Bruce Momjian (br...@momjian.us) wrote:
> > On Mon, Jan 11, 2021 at 01:23:27PM -0500, Stephen Frost wrote:
> > > Yes, and it avoids the issue of using a single key for too much, which
>
On Mon, Jan 11, 2021 at 12:05:43PM -0800, Peter Geoghegan wrote:
> On Mon, Jan 11, 2021 at 11:25 AM Bruce Momjian wrote:
> > Once you layer on all the places a global index will be worse than just
> > creating a single large table, or a partitioned table with an index per
> &g
.
This says:
https://wiki.postgresql.org/wiki/Transparent_Data_Encryption#Other_requirements
wal_log_hints will be enabled automatically in encryption mode.
Does that help?
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
So this is rebased on those.
> I guess updating this script should be a part of a beta-checklist somewhere,
> since I guess nobody will want to backpatch changes for testing older
> releases.
Uh, what exactly is missing from the beta checklist? I read the patch
and commit messa
On Tue, Jan 12, 2021 at 11:27:53AM -0600, Justin Pryzby wrote:
> On Tue, Jan 12, 2021 at 12:15:59PM -0500, Bruce Momjian wrote:
> > Uh, what exactly is missing from the beta checklist? I read the patch
> > and commit message but don't understand it.
>
> Did you try to u
bout hint bit changes showing to users? I actually don't
know. If we do, some kind of dummy LSN record might be required, as you
suggested.
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
Looks good. I posted your patch under my
key management patch and the cfbot reports all green:
http://cfbot.cputube.org/index.html
The key management patch calls the src/common hex functions from
src/backend/crypto, pg_alterckey, and the crypto tests, and these are
all tested by make chec
that uses the same LSN, and then force a
dummy WAL record when that 8-bit counter overflows --- that seems
simpler than logging hint bits.
--
Bruce Momjian https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
On Tue, Jan 12, 2021 at 01:15:44PM -0500, Bruce Momjian wrote:
> On Tue, Jan 12, 2021 at 01:11:29PM -0500, Stephen Frost wrote:
> > I don't think there's any doubt that we need to make sure that the IV is
> > distinct and advancing the LSN to get a new one when needed for
On Tue, Jan 12, 2021 at 01:44:05PM -0500, Stephen Frost wrote:
> * Bruce Momjian (br...@momjian.us) wrote:
> > Well, we have eight unused bits in the IV, so we could just increment
> > that for every hint bit change that uses the same LSN, and then force a
> > dummy WAL r
On Tue, Jan 12, 2021 at 01:57:11PM -0500, Stephen Frost wrote:
> Greetings,
>
> * Bruce Momjian (br...@momjian.us) wrote:
> > On Tue, Jan 12, 2021 at 01:44:05PM -0500, Stephen Frost wrote:
> > > * Bruce Momjian (br...@momjian.us) wrote:
> > > > Well, we hav
On Tue, Jan 12, 2021 at 01:46:53PM -0500, Bruce Momjian wrote:
> On Tue, Jan 12, 2021 at 01:15:44PM -0500, Bruce Momjian wrote:
> > Well, we have eight unused bits in the IV, so we could just increment
> > that for every hint bit change that uses the same LSN, and then force a
>
such a
> > cast.
>
> Thanks, Sehrope. I have reviewed the code this morning and fixed
> that, adjusted a couple of elog() strings I found inconsistent after
> review and ran pgindent. And applied it.
Thanks. All my key management regression tests pass on top of your
ap
the
upper branch on top of that, and then use git format-patch comparing
the lower branch to the upper one
Maybe everyone else knew these things, but I didn't. I can provide more
details if desired.
--
Bruce Momjian https://momjian.us
Enterpr
101 - 200 of 2670 matches
Mail list logo
