Re: pl/perl extension fails on Windows

On Wed, Nov 29, 2017 at 11:34:56PM -0500, Tom Lane wrote: > Noah Misch <n...@leadboat.com> writes: > > On Thu, Aug 17, 2017 at 12:15:58PM -0400, Tom Lane wrote: > >> ... it's now looking to me like we should do the above with X = 5.13.4. > >> That won't be a

Re: REPLICA IDENTITY FULL

On Fri, Jun 23, 2017 at 03:45:48PM -0400, Peter Eisentraut wrote: > On 6/23/17 13:14, Alvaro Herrera wrote: > > Andres Freund wrote: > >> On 2017-06-23 13:05:21 -0400, Alvaro Herrera wrote: > >>> Tom Lane wrote: > Peter Eisentraut writes: > > Any

Re: Add PGDLLIMPORT lines to some variables

On Mon, Nov 20, 2017 at 12:02:30PM -0800, Andres Freund wrote: > On 2017-11-20 11:58:44 -0800, Brian Cloutier wrote: > > > please, append session_timezone to your list > > > > Here's a v2 patch which also includes session_timezone. > > > > Separately, is this the kind of thing which is eligible

Re: Race to build pg_isolation_regress in "make -j check-world"

On Mon, Nov 06, 2017 at 12:07:52AM -0800, Noah Misch wrote: > I've been enjoying the speed of parallel check-world, but I get spurious > failures from makefile race conditions. Commit c66b438 fixed the simple ones. > More tricky is this problem of multiple "make" processes

Re: Schedule for migration to pglister

On Mon, Nov 06, 2017 at 10:36:38AM -0500, Stephen Frost wrote: > Our planned migration schedule is as follows: > > Nov 6 - > pgsql-www > > Nov 13 - > pgsql-hackers When each list migrated, its mbox archives stopped receiving new messages:

Re: pl/perl extension fails on Windows

On Wed, Nov 29, 2017 at 08:14:41PM -0800, Noah Misch wrote: > 1. If $Config{gccversion} is nonempty, add _USE_32BIT_TIME_T. This will do >the wrong thing if MinGW changes its default to match modern MSVC. It will >do the wrong thing for a Perl built with "gcc -D__MINGW_USE

Re: SIGPIPE in TAP tests

On Mon, Dec 11, 2017 at 04:19:52PM +0900, Michael Paquier wrote: > On Sun, Dec 10, 2017 at 6:02 AM, Noah Misch <n...@leadboat.com> wrote: > If SIGPIPE is ignored then test output just stops after generating the > FATAL message. Oops. You mean "If SIGPIPE is not ignored ...&

Re: Building PL/Perl with ActiveState Perl 5.22 and MSVC

On Mon, Nov 13, 2017 at 07:41:42AM +, Noah Misch wrote: > On Sat, Mar 26, 2016 at 03:43:21PM +0300, Victor Wagner wrote: > > 1. ActiveState Perl doesn't ship MSVC-build import library perl522.lib > > for their perl522.dll. Instead they ship MINGW-build library > >

Re: pl/perl extension fails on Windows

On Sun, Dec 10, 2017 at 12:36:13PM +, Christian Ullrich wrote: > * Noah Misch wrote: > > On Wed, Nov 29, 2017 at 11:45:35PM -0500, Tom Lane wrote: > >> Oh, OK. In that case, we need to get some representatives of these > >> more modern builds into the buildfarm whil

Re: pl/perl extension fails on Windows

On Wed, Nov 29, 2017 at 11:45:35PM -0500, Tom Lane wrote: > Noah Misch <n...@leadboat.com> writes: > > On Wed, Nov 29, 2017 at 11:34:56PM -0500, Tom Lane wrote: > >> I don't really have an opinion about the relative merits of these changes, > >> but why do any

SIGPIPE in TAP tests

Two buildfarm runs[1][2] from the last 90 days have failed in src/test/authentication, like this: t/001_password.pl .. Failed 3/8 subtests t/002_saslprep.pl .. ok 1815 ms ( 0.00 usr 0.00 sys + 0.89 cusr 0.26 csys = 1.15 CPU) Test Summary Report ---

Re: PostgreSQL 11 beta1 on AIX 7.2 : 2 failures in 32bit mode

On Thu, May 31, 2018 at 10:28:12AM -0400, Tom Lane wrote: > "REIX, Tony" writes: > > It looks like configure does figure out that LARGE_FILES is required, only > > in 32bit. > > No need in 64bit. > > Check ... > > > However, in 32bit, though there is: > >#define _LARGE_FILES 1 > > in file

Re: PostgreSQL 11 beta1 on AIX 7.2 : 2 failures in 32bit mode

On Thu, May 31, 2018 at 07:23:57PM -0400, Tom Lane wrote: > Noah Misch writes: > > On Thu, May 31, 2018 at 10:28:12AM -0400, Tom Lane wrote: > >> I wondered why the existing 32-bit AIX buildfarm machines aren't showing > >> problems, but looking closer at them

Re: pg_recvlogical broken in back branches

On Wed, Apr 25, 2018 at 03:57:49PM +0200, Magnus Hagander wrote: > On Mon, Apr 23, 2018 at 12:49 AM, Michael Paquier <mich...@paquier.xyz> wrote: > > On Sun, Apr 22, 2018 at 02:55:51PM -0700, Noah Misch wrote: > > > That change is testing the wrong variable. I plan to rep

Re: "could not reattach to shared memory" on buildfarm member dory

On Mon, Apr 30, 2018 at 08:01:40PM -0400, Tom Lane wrote: > It's clear from dory's results that something is causing a 4MB chunk > of memory to get reserved in the process's address space, sometimes. > It might happen during the main MapViewOfFileEx call, or during the > preceding VirtualFree, or

Re: pl/perl extension fails on Windows

On Sun, Dec 10, 2017 at 11:46:08AM -0800, Noah Misch wrote: > On Sun, Dec 10, 2017 at 12:36:13PM +, Christian Ullrich wrote: > > * Noah Misch wrote: > > > On Wed, Nov 29, 2017 at 11:45:35PM -0500, Tom Lane wrote: > > >> Oh, OK. In that case, we ne

Re: pl/perl extension fails on Windows

On Sun, Jan 21, 2018 at 11:34:07AM +0100, Christian Ullrich wrote: > * Christian Ullrich wrote: > >* Noah Misch wrote: > >>On Wed, Nov 29, 2017 at 11:45:35PM -0500, Tom Lane wrote: > >>>Oh, OK. In that case, we need to get some representatives of these > >>

Re: [HACKERS] Deadlock in XLogInsert at AIX

On Tue, Jan 16, 2018 at 08:50:24AM -0800, Andres Freund wrote: > On 2018-01-16 16:12:11 +0900, Michael Paquier wrote: > > On Fri, Feb 03, 2017 at 12:26:50AM +0000, Noah Misch wrote: > > > Since this emits double syncs with older xlc, I recommend instead > > > repl

Re: Contributing with code

On Tue, Jan 02, 2018 at 05:52:37PM -0500, Peter Eisentraut wrote: > On 12/31/17 22:43, Craig Ringer wrote: > > I'd rather rename it the "stuck, hard and abandoned projects list" ;)  > > That might actually be useful. +1. When I do refer to a TODO entry, it's usually because the entry bears a

Re: Increasing timeout of poll_query_until for TAP tests

On Tue, Aug 02, 2016 at 06:21:03PM -0400, Alvaro Herrera wrote: > Michael Paquier wrote: > > $node_master->safe_psql('postgres', > > "INSERT INTO tab_int VALUES (generate_series(1001,2000))"); > > my $recovery_txid = > > $node_master->safe_psql('postgres', "SELECT txid_current()"); > >

Re: Race to build pg_isolation_regress in "make -j check-world"

On Sat, Dec 16, 2017 at 08:06:05PM -0800, Noah Misch wrote: > On Mon, Nov 06, 2017 at 12:07:52AM -0800, Noah Misch wrote: > I now see similar trouble from multiple > "make" processes running "make -C contrib/test_decoding install" concurrently. > This i

Re: Increasing timeout of poll_query_until for TAP tests

On Mon, Jan 01, 2018 at 07:55:37PM +0900, Michael Paquier wrote: > On Sun, Dec 31, 2017 at 09:52:27PM -0800, Noah Misch wrote: > > Since now() is transaction_timestamp(), $recovery_time precedes or equals > > $lsn3, and this didn't close the race. Using clock_timestamp() here

Re: Kerberos test suite

On Tue, Mar 06, 2018 at 10:58:54AM -0500, Peter Eisentraut wrote: > On 3/5/18 16:34, Thomas Munro wrote: > > On Tue, Mar 6, 2018 at 8:45 AM, Peter Eisentraut > > wrote: > >> New patch attached. > > > > Passes here. LGTM. > > committed This fails on my machine, where /etc/hosts has:

Facility for detecting insecure object naming

Commit e09144e documented the rules for writing safe qualified names, but those rules are tedious to apply in practice. Spotting the defects in this function definition (from an unpublished draft intended for https://postgr.es/m/20180710014308.ga805...@rfd.leadboat.com) is, I think, too hard:

Re: Facility for detecting insecure object naming

On Wed, Aug 08, 2018 at 12:00:45PM +0530, Robert Haas wrote: > On Sun, Aug 5, 2018 at 1:34 PM, Noah Misch wrote: > > If hackers and non-core extension authors are to write such code, let's make > > it easier to check the work. > > +1. Better still would be to invent a w

Re: Facility for detecting insecure object naming

On Wed, Aug 15, 2018 at 10:40:55AM -0500, Nico Williams wrote: > On Tue, Aug 14, 2018 at 11:50:24PM +, Nasby, Jim wrote: > > On Aug 14, 2018, at 4:01 PM, Nico Williams wrote: > > > > > > On Tue, Aug 14, 2018 at 03:00:55PM +, Robert Haas wrote: > > >> The more I think about it, the more I

Re: Facility for detecting insecure object naming

On Wed, Aug 15, 2018 at 12:04:53PM -0400, Robert Haas wrote: > On Tue, Aug 14, 2018 at 10:44 PM, Noah Misch wrote: > > Right. For what it's worth, the example I permuted upthread might look like > > this in a lexical search path world: > > > > -- Always secure

Re: Facility for detecting insecure object naming

On Tue, Aug 14, 2018 at 04:42:43PM -0400, Bruce Momjian wrote: > On Tue, Aug 14, 2018 at 04:23:33PM -0400, Robert Haas wrote: > > On Tue, Aug 14, 2018 at 3:31 PM, Bruce Momjian wrote: > > > I am unclear how lexical scoping helps with this, or with Postgres. > > > > Well, if you say sqrt(x) in C,

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

On Wed, Sep 11, 2013 at 10:28:00PM -0400, Noah Misch wrote: > On Wed, Sep 11, 2013 at 11:32:01AM -0400, Stephen Frost wrote: > > * Noah Misch (n...@leadboat.com) wrote: > > > Concretely, that means > > > not removing postmaster.pid on immediate shutdown in 9.3

Re: Facility for detecting insecure object naming

On Wed, Aug 08, 2018 at 09:58:38AM -0400, Tom Lane wrote: > I'm not sold on #2 either. That path leads to, for example, > s/=/OPERATOR(pg_catalog.=)/g everywhere, which is utterly catastrophic > to both readability and portability of your SQL code. We *must* find > a way to do better, not tell

Re: Facility for detecting insecure object naming

On Sat, Aug 11, 2018 at 03:32:23PM -0500, Nico Williams wrote: > On Sat, Aug 11, 2018 at 12:47:05PM -0700, Noah Misch wrote: > > -- (3) "SET search_path" with today's code. > > -- > > -- Security and reliability considerations are the same as (2). Today,

Re: libpq should not look up all host addresses at once

On Thu, Aug 09, 2018 at 02:32:58PM -0400, Tom Lane wrote: > Chapman Flack writes: > > On 08/09/2018 11:05 AM, Tom Lane wrote: > >> So I think what this code should do is (1) look up each hostname as it > >> needs it, not all at once, and (2) proceed on to the next hostname > >> if it gets a DNS

Re: "could not reattach to shared memory" on buildfarm member dory

On Tue, May 01, 2018 at 11:31:50AM -0400, Tom Lane wrote: > Well, at this point the only thing that's entirely clear is that none > of the ideas I had work. I think we are going to be forced to pursue > Noah's idea of doing an end-to-end retry. Somebody else will need to > take point on that; I

Re: JIT compiling with LLVM v12

On Wed, Mar 28, 2018 at 02:27:51PM -0700, Andres Freund wrote: > For now LLVM is enabled by default when compiled --with-llvm. I'm mildly > inclined to leave it like that until shortly before the release, and > then disable it by default (i.e. change the default of jit=off). But I > think we can

Re: JIT compiling with LLVM v12

On Wed, Aug 22, 2018 at 06:20:21AM +, Noah Misch wrote: > On Wed, Mar 28, 2018 at 02:27:51PM -0700, Andres Freund wrote: > > For now LLVM is enabled by default when compiled --with-llvm. I'm mildly > > inclined to leave it like that until shortly before the release, and &

wal_sender_timeout should ignore server-side latency

WalSndLoop() does this, simplifying considerably: for (;;) { /* does: last_reply_timestamp = GetCurrentTimestamp() */ ProcessRepliesIfAny(); send_data(); /* e.g. XLogSendPhysical(), which calls XLogRead() */

Re: Non-portable shell code in pg_upgrade tap tests

On Fri, Jul 20, 2018 at 11:09:13AM -0400, Tom Lane wrote: > Victor Wagner writes: > > Tom Lane wrote: > >> Please send a patch. Most of us do not have access to old shells > > > Here it goes. Previous letter was written before fixed tests were > > completed, because this old machine is slow. >

Re: Non-portable shell code in pg_upgrade tap tests

On Sun, Jul 22, 2018 at 10:46:03AM -0400, Tom Lane wrote: > Noah Misch writes: > > I'd say the right way to fix this is the one specified in > > https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/The-Make-Macro-SHELL.html, > > in particular: > &

Re: Non-portable shell code in pg_upgrade tap tests

On Sun, Jul 22, 2018 at 02:53:51PM -0400, Tom Lane wrote: > Noah Misch writes: > > On Sun, Jul 22, 2018 at 10:46:03AM -0400, Tom Lane wrote: > >> The pg_upgrade makefile does in fact use $(SHELL), so it will default to > >> whatever shell configure used. > > &g

Re: Loaded footgun open_datasync on Windows

On Wed, Jun 27, 2018 at 12:09:24PM +0200, Laurenz Albe wrote: > Michael Paquier wrote: > > > I have added it to the July commitfest. > > > > Have you looked at the possibility of removing the log file constraints > > in pg_upgrade with the change you are doing here so as things would be > > more

Re: Configuring messages language on Windows

On Fri, Jan 26, 2018 at 04:54:08PM +0300, a.parfe...@postgrespro.ru wrote: > As it mentioned in pg_locale.c, the variable LC_MESSAGES is ignored in > Windows(pg_locale.c:162). That comment says "On Windows, setlocale(LC_MESSAGES) does not work". It says nothing about the LC_MESSAGES environment

Re: JIT compiling with LLVM v12

On Wed, Sep 05, 2018 at 11:55:39AM -0700, Andres Freund wrote: > On 2018-08-22 06:20:21 +0000, Noah Misch wrote: > > I see jit slows the regression tests considerably: > > Is this with LLVM assertions enabled or not? Without, I think. I configured them like this:

Re: Facility for detecting insecure object naming

On Sat, Aug 11, 2018 at 12:47:05PM -0700, Noah Misch wrote: > On Wed, Aug 08, 2018 at 09:58:38AM -0400, Tom Lane wrote: > > When the security team was discussing this issue before, we speculated > > about ideas like inventing a function trust mechanism, so that attacks > >

Re: Looks like we can enable AF_UNIX on Windows now

On Wed, May 30, 2018 at 09:59:01AM +0800, Craig Ringer wrote: > On 30 May 2018 at 09:53, Andres Freund wrote: > > On May 29, 2018 9:44:09 PM EDT, Craig Ringer wrote: > > >https://blogs.msdn.microsoft.com/commandline/2017/12/19/af_unix-comes-to-windows/ > > > > > >The latest Windows 10 update

Re: hot_standby_feedback vs excludeVacuum and snapshots

On Fri, Jul 06, 2018 at 04:32:56PM +0100, Simon Riggs wrote: > On 6 July 2018 at 03:30, Thomas Munro wrote: > > On Thu, Jul 5, 2018 at 8:27 AM, Noah Misch wrote: > >>> However, 49bff5300d527 also introduced a similar bug where > >>> subtransaction >

Extension relocation vs. schema qualification

On Wed, Apr 04, 2018 at 11:59:57PM -0700, Noah Misch wrote: > On Mon, Apr 02, 2018 at 04:24:02PM -0400, Bruce Momjian wrote: > > > I am not sure we can fix this without requiring people to drop and > > > recreate such indexes. However, I am even at a loss in how to fix the

Re: Tips on committing

On Thu, Jun 28, 2018 at 10:52:42AM -0700, Peter Geoghegan wrote: > On Thu, Jun 28, 2018 at 9:52 AM, Alvaro Herrera > wrote: > >> FWIW, I developed a document on committing for my own reference, with > >> some help from Andres. My rule has been to add to my private checklist anytime I mail or

Re: hot_standby_feedback vs excludeVacuum and snapshots

On Fri, Jun 08, 2018 at 11:03:38AM -0700, Andres Freund wrote: > On 2018-06-08 09:23:02 +0100, Simon Riggs wrote: > > For context, AEL locks are normally removed by COMMIT or ABORT. > > StandbyReleaseOldLocks() is just a sweeper to catch anything that > > didn't send an abort before it died, so it

Re: Fixes for missing schema qualifications

On Wed, Mar 14, 2018 at 09:26:15AM +0900, Tatsuo Ishii wrote: > > select [...] where nspname operator(pg_catalog.=) '%s'​ > Next question is, should we update the manual? There are bunch of > places where example queries are shown without schema qualifications. I gave

Re: public schema default ACL

On Wed, Mar 07, 2018 at 09:22:16AM -0500, Peter Eisentraut wrote: > On 3/6/18 15:20, Robert Haas wrote: > > On Sat, Mar 3, 2018 at 4:56 AM, Noah Misch <n...@leadboat.com> wrote: > >> I propose, for v11, switching to "GRANT USAGE ON SCHEMA > >> publ

Re: public schema default ACL

On Wed, Mar 07, 2018 at 07:14:43AM -0500, Stephen Frost wrote: > * Noah Misch (n...@leadboat.com) wrote: > > I like the idea of getting more SQL-compatible, if this presents a distinct > > opportunity to do so. I do think it would be too weird to create the schema > >

Re: public schema default ACL

On Thu, Mar 08, 2018 at 02:00:23PM -0500, Robert Haas wrote: > I also wonder why we're all convinced that this urgently needs to be > changed. I agree that the default configuration we ship is not the > most secure configuration that we could ship. However, I think it's a > big step from saying

Re: Fixes for missing schema qualifications

On Fri, Mar 09, 2018 at 04:55:38PM +0900, Michael Paquier wrote: > --- a/src/backend/catalog/information_schema.sql > +++ b/src/backend/catalog/information_schema.sql > @@ -186,7 +186,7 @@ CREATE FUNCTION _pg_interval_type(typid oid, mod int4) > RETURNS text > AS > $$SELECT >CASE WHEN

Re: Fixes for missing schema qualifications

On Wed, Mar 14, 2018 at 10:50:38AM +0900, Michael Paquier wrote: > On Sat, Mar 10, 2018 at 08:36:34AM +0000, Noah Misch wrote: > > This qualifies some functions, but it leaves plenty of unqualified > > operators. > > Yeah, I know that, and i don't have a perfect

Re: BUG #15112: Unable to run pg_upgrade with earthdistance extension

On Mon, Apr 02, 2018 at 04:24:02PM -0400, Bruce Momjian wrote: > > I am not sure we can fix this without requiring people to drop and > > recreate such indexes. However, I am even at a loss in how to fix the > > CREATE FUNCTION to reference a cast in the same schema as the function, > > in this

Re: pg_recvlogical broken in back branches

,5 @@ int PQserverVersion(const PGconn *conn) { + Assert(conn); if (!conn) return 0; commit 8ef98fe (HEAD, master) Author: Noah Misch <n...@leadboat.com> AuthorDate: Sun Apr 22 14:46:58 2018 -0700 Commit: Noah Misch <n...@leadboat.com> CommitDat

Re: "could not reattach to shared memory" on buildfarm member dory

On Tue, Apr 24, 2018 at 11:37:33AM +1200, Thomas Munro wrote: > On Tue, Apr 24, 2018 at 11:18 AM, Stephen Frost wrote: > > Greetings, > > > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> So far, dory has failed three times with essentially identical symptoms: > >> > >>

Re: public schema default ACL

On Thu, Mar 08, 2018 at 11:14:59PM -0800, Noah Misch wrote: > On Thu, Mar 08, 2018 at 02:00:23PM -0500, Robert Haas wrote: > > I also wonder why we're all convinced that this urgently needs to be > > changed. I agree that the default configuration we ship is not the > > most

Re: MSVC builld of 9.5.12 is broken?

On Tue, Feb 27, 2018 at 11:43:34AM +0100, Magnus Hagander wrote: > On Tue, Feb 27, 2018 at 11:27 AM, Victor Wagner wrote: > > These errors seems to be caused by commit 91f3ffc5249 > > which improves readability of src/bin/scripts/Makefile for > > humans by moving list of

Re: public schema default ACL

On Sat, Mar 03, 2018 at 02:31:58AM -0800, Joe Conway wrote: > On 03/03/2018 01:56 AM, Noah Misch wrote: > > If we do that alone, databases reaching v11 via dump/reload or pg_upgrade > > will > > get the new default ACL if they had not changed the ACL of schema public.

Re: First-draft release notes for back-branch releases

On Mon, Nov 05, 2018 at 10:49:30PM -0500, Jonathan S. Katz wrote: > On 11/5/18 9:58 PM, Amit Langote wrote: > > On 2018/11/06 11:25, Noah Misch wrote: > >> On Mon, Nov 05, 2018 at 04:01:59PM -0500, Jonathan S. Katz wrote: > >>> Attached is a draft of the press rel

Re: Perl 5.26 and windows build system

On Wed, Oct 17, 2018 at 05:16:15PM -0400, Andrew Dunstan wrote: > On 10/17/2018 04:38 AM, Victor Wagner wrote: > >BTW, have anyone experienced some success using Strawberry perl instead > >of Active perl both for building postgres and as PL/Perl engine? > > > >Active State seems to abandon support

Re: DSM segment handle generation in background workers

On Mon, Nov 12, 2018 at 09:39:01AM -0500, Tom Lane wrote: > Thomas Munro writes: > > On Mon, Nov 12, 2018 at 9:34 PM Noah Misch wrote: > >> Compared to the old code, the new code requires more wall time to visit > >> every > >> possible seed value. New code

Re: First-draft release notes for back-branch releases

On Mon, Nov 05, 2018 at 04:01:59PM -0500, Jonathan S. Katz wrote: > Attached is a draft of the press release for review. Please let me know > if there are any corrections/suggestions. > This update is also the final release for PostgreSQL 9.3, which is now > end-of-life and will no longer

Re: DSM segment handle generation in background workers

On Wed, Nov 14, 2018 at 05:50:26PM +1300, Thomas Munro wrote: > On Wed, Nov 14, 2018 at 3:24 PM Noah Misch wrote: > > On Mon, Nov 12, 2018 at 09:39:01AM -0500, Tom Lane wrote: > > > I doubt that's a good idea; to a first approximation, it would mean that > > >

Re: DSM segment handle generation in background workers

On Wed, Nov 14, 2018 at 08:22:42PM +1300, Thomas Munro wrote: > On Wed, Nov 14, 2018 at 6:34 PM Noah Misch wrote: > > On Wed, Nov 14, 2018 at 05:50:26PM +1300, Thomas Munro wrote: > > > On Wed, Nov 14, 2018 at 3:24 PM Noah Misch wrote: > > > > What counts is the

Re: [RFC] Removing "magic" oids

On Wed, Nov 14, 2018 at 12:01:52AM -0800, Andres Freund wrote: > - one pgbench test tested concurrent insertions into a table with > oids, as some sort of stress test for lwlocks and spinlocks. I *think* > this doesn't really have to be a system oid column, and this was just > because that's

Re: [HACKERS] Re: Improve OR conditions on joined columns (common star schema problem)

On Mon, Oct 01, 2018 at 09:32:10PM -0400, Tom Lane wrote: > Michael Paquier writes: > > On Mon, Sep 03, 2018 at 06:59:10PM -0700, Noah Misch wrote: > >> If you're going to keep this highly-simplified estimate, please expand the > >> comment to say why it doesn't matter

Re: [HACKERS] Re: Improve OR conditions on joined columns (common star schema problem)

On Sun, Feb 12, 2017 at 09:32:36AM -0800, Tom Lane wrote: > It's not so much poor choices as the cost of the optimization attempt --- > if there's a K-relation OR clause, this will increase the cost of planning > by a factor approaching K+1, whether or not you get a better plan out of > it. I ran

Re: Something fishy happening on frogmouth

On Wed, Sep 19, 2018 at 01:03:44PM +0900, Kyotaro HORIGUCHI wrote: > Thank you for finding and fixing this. > > At Sat, 15 Sep 2018 18:21:52 -0400, Tom Lane wrote in > <1.1537050...@sss.pgh.pa.us> > > Noah Misch writes: > > > Usually, the f

Re: "could not reattach to shared memory" on buildfarm member dory

On Mon, Sep 24, 2018 at 01:53:05PM -0400, Tom Lane wrote: > Noah Misch writes: > > In this proof of concept, the > > postmaster does not close its copy of a backend socket until the backend > > exits. > > That seems unworkable because it would interfere with detec

Re: Is MinMaxExpr really leakproof?

This thread duplicates https://postgr.es/m/flat/16539.1431472961%40sss.pgh.pa.us On Sun, Dec 30, 2018 at 01:24:02PM -0500, Tom Lane wrote: > So this coding amounts to an undocumented > assumption that every non-cross-type btree comparison function is > leakproof. > select p.oid::regprocedure

Re: Augment every test postgresql.conf

On Sat, Dec 29, 2018 at 10:46:31PM -0500, Tom Lane wrote: > Noah Misch writes: > > Looking more closely, we already have the TEMP_CONFIG variable and apply it > > to > > everything except TAP suites. Closing that gap, as attached, is enough. > > The > >

Re: emacs configuration for new perltidy settings

On Thu, Jul 12, 2012 at 12:35:26AM +0300, Peter Eisentraut wrote: > This might be useful for some people. Here is an emacs configuration > for perl-mode that is compatible with the new perltidy settings. Note > that the default perl-mode settings produce indentation that will be > completely

Re: Facility for detecting insecure object naming

On Wed, Dec 05, 2018 at 11:20:52PM -0800, Noah Misch wrote: > On Thu, Aug 30, 2018 at 12:06:09AM -0700, Noah Misch wrote: > > On Sat, Aug 11, 2018 at 12:47:05PM -0700, Noah Misch wrote: > > > On Wed, Aug 08, 2018 at 09:58:38AM -0400, Tom Lane wrote: > > > > When th

Re: "could not reattach to shared memory" on buildfarm member dory

On Sun, Dec 02, 2018 at 09:35:06PM -0800, Noah Misch wrote: > On Tue, Sep 25, 2018 at 08:05:12AM -0700, Noah Misch wrote: > > On Mon, Sep 24, 2018 at 01:53:05PM -0400, Tom Lane wrote: > > > Overall, I agree that neither of these approaches are exactly attractive. > > > W

Re: Move regression.diffs of pg_upgrade test suite

On Wed, Dec 26, 2018 at 05:02:37PM -0500, Tom Lane wrote: > Andrew Dunstan writes: > > On 12/23/18 10:44 PM, Noah Misch wrote: > >> A disadvantage of any change here is that it degrades buildfarm reports, > >> which > >> recover slowly as owners

Re: Race to build pg_isolation_regress in "make -j check-world"

On Mon, Jan 01, 2018 at 05:39:56PM -0800, Noah Misch wrote: > On Sat, Dec 16, 2017 at 08:06:05PM -0800, Noah Misch wrote: > > On Mon, Nov 06, 2017 at 12:07:52AM -0800, Noah Misch wrote: > > > I now see similar trouble from multiple > > "make" processes runn

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

On Thu, Nov 29, 2018 at 10:51:40PM -0800, Noah Misch wrote: > On Thu, Nov 29, 2018 at 01:10:57PM +0100, Dmitry Dolgov wrote: > > As a side note, with this patch recovery tests are failing now on 016_shm.pl > > > > # Failed test 'detected live backend via shared memory' &g

Re: Facility for detecting insecure object naming

On Thu, Aug 30, 2018 at 12:06:09AM -0700, Noah Misch wrote: > On Sat, Aug 11, 2018 at 12:47:05PM -0700, Noah Misch wrote: > > On Wed, Aug 08, 2018 at 09:58:38AM -0400, Tom Lane wrote: > > > When the security team was discussing this issue before, we speculated > > >

Re: Support custom socket directory in pg_upgrade

On Sat, Nov 17, 2018 at 10:15:08PM +0100, Daniel Gustafsson wrote: > > On 15 Nov 2018, at 22:42, Tom Lane wrote: > > > Further point about that: pg_regress's method of creating a temp > > directory under /tmp is secure only on machines with the stickybit > > set on /tmp; otherwise it's possible

Re: Too many logs are written on Windows (LOG: could not reserve shared memory region (addr=%p) for child %p:)

On Wed, Nov 21, 2018 at 10:05:34AM -0500, Robert Haas wrote: > On Tue, Nov 20, 2018 at 1:21 AM Takahashi, Ryohei > wrote: > > My customer uses PostgreSQL on Windows and hits the problem that following > > log is written to the server logs too frequently (250 thousand times per > > day). > >

Too-short timeouts in test code

We've had more buildfarm failures due to hard-coded, short timeouts: http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=chipmunk=2018-10-13%2021%3A06%3A58 10s timeout while running pg_recvlogical http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hornet=2018-12-03%2005%3A52%3A12 30s

Re: Fixes for missing schema qualifications

On Thu, Nov 29, 2018 at 04:20:24PM +0900, Michael Paquier wrote: > From what I can see in my backlog, this never actually got into the > tree, and it seems to me that fixing those issues is always better than > nothing: > https://www.postgresql.org/message-id/20180309075538.gd9...@paquier.xyz > >

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

On Thu, Nov 29, 2018 at 01:10:57PM +0100, Dmitry Dolgov wrote: > On Sun, Aug 12, 2018 at 8:48 AM Noah Misch wrote: > > With 9.3 having a few months left, that's less interesting, but ... > I'm a bit out of context, but taking into account that 9.3 is already beyond > EOL, is it st

Re: POC for a function trust mechanism

On Sun, Aug 12, 2018 at 10:40:30PM -0400, Robert Haas wrote: > On Wed, Aug 8, 2018 at 1:15 PM, Tom Lane wrote: > > If we had, say, a catalog that provided the desired list of trusted roles > > for every role, then we could imagine implementing that context change > > automatically. Likewise,

Re: Augment every test postgresql.conf

On Fri, Dec 28, 2018 at 06:19:50PM -0800, Noah Misch wrote: > "env EXTRA_REGRESS_OPTS=--temp-config=SOMEFILE make check" appends the > contents of SOMEFILE to the test cluster's postgresql.conf. I want a similar > feature for TAP suites and other non-pg_regress suites. (My i

Re: Move regression.diffs of pg_upgrade test suite

On Sun, Dec 30, 2018 at 10:41:46AM -0500, Andrew Dunstan wrote: > On 12/26/18 5:44 PM, Noah Misch wrote: > > On Wed, Dec 26, 2018 at 05:02:37PM -0500, Tom Lane wrote: > >> Andrew Dunstan writes: > >>> On 12/23/18 10:44 PM, Noah Misch wrote: > >&

Re: stats_temp_directory conflicts

On Sun, Dec 30, 2018 at 07:47:05PM -0500, Tom Lane wrote: > Noah Misch writes: > > I'm thinking the server should manage this; during startup, create > > $stats_temp_directory/PostgreSQL.$postmaster_pid and store each stats file > > therein. > > +1 > > >

Augment every test postgresql.conf

"env EXTRA_REGRESS_OPTS=--temp-config=SOMEFILE make check" appends the contents of SOMEFILE to the test cluster's postgresql.conf. I want a similar feature for TAP suites and other non-pg_regress suites. (My immediate use case is to raise authentication_timeout and wal_sender_timeout on my

stats_temp_directory conflicts

On Sun, Dec 30, 2018 at 10:32:31AM -0500, Andrew Dunstan wrote: > On 12/30/18 12:53 AM, Noah Misch wrote: > > stats_temp_directory = '/cygdrive/w/lorikeet/HEAD' > > 2. stats_temp_directory is incompatible with TAP suites that start more than > >one node simultaneous

Re: Something fishy happening on frogmouth

On Wed, Oct 30, 2013 at 09:07:43AM -0400, Robert Haas wrote: > On Wed, Oct 30, 2013 at 8:47 AM, Andres Freund wrote: > > On 2013-10-30 08:45:03 -0400, Robert Haas wrote: > >> If I'm reading this correctly, the last three runs on frogmouth have > >> all failed, and all of them have failed with a

Re: PostgreSQL 11 {Beta 4, RC1} Release: 2018-09-20

On Tue, Sep 18, 2018 at 12:15:45PM -0400, Jonathan S. Katz wrote: > On 9/13/18 12:51 PM, Jonathan S. Katz wrote: > > We are planning to have another release of PostgreSQL 11, either Beta 4 > > or RC1, next week on Thursday, 2018-09-20. The version will be > > determined based on the state of the

Re: Too-short timeouts in test code

On Sun, Dec 09, 2018 at 11:14:12AM +0900, Michael Paquier wrote: > On Sat, Dec 08, 2018 at 04:16:01PM -0800, Noah Misch wrote: > > @@ -72,7 +72,7 @@ my $endpos = $node_master->safe_psql('postgres', > > print "waiting to replay $endpos\n"; > > &

Re: pgsql: Remove references to Majordomo

On Sat, Jan 19, 2019 at 01:19:46PM -0500, Stephen Frost wrote: > * Magnus Hagander (mag...@hagander.net) wrote: > > On Fri, Jan 18, 2019 at 4:02 PM Tom Lane wrote: > > > Magnus Hagander writes: > > > > On Fri, Jan 18, 2019 at 1:26 AM Michael Paquier > > > wrote: > > > >> Wouldn't it be better

Re: "could not reattach to shared memory" on buildfarm member dory

On Sun, Dec 02, 2018 at 09:35:06PM -0800, Noah Misch wrote: > On Tue, Sep 25, 2018 at 08:05:12AM -0700, Noah Misch wrote: > > On Mon, Sep 24, 2018 at 01:53:05PM -0400, Tom Lane wrote: > > > Overall, I agree that neither of these approaches are exactly attractive. > > > W

Re: [HACKERS] WAL logging problem in 9.4.3?

On Wed, Mar 20, 2019 at 05:17:54PM +0900, Kyotaro HORIGUCHI wrote: > At Sun, 10 Mar 2019 19:27:08 -0700, Noah Misch wrote in > <20190311022708.ga2189...@rfd.leadboat.com> > > On Mon, Mar 04, 2019 at 12:24:48PM +0900, Kyotaro HORIGUCHI wrote: > > > +/* > > > +

Re: compiler warning in pgcrypto imath.c

On Sat, Mar 23, 2019 at 10:20:16AM +0900, Michael Paquier wrote: > On Fri, Mar 22, 2019 at 08:20:53PM -0400, Jeff Janes wrote: > > PostgreSQL 12devel on aarch64-unknown-linux-gnu, compiled by gcc > > (Ubuntu/Linaro 7.3.0-27ubuntu1~18.04) 7.3.0, 64-bit > > Adding Noah in CC as he has done the

Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

On Mon, Apr 01, 2019 at 08:19:56AM +, Daniel Gustafsson wrote: > On Monday, April 1, 2019 12:42 AM, Noah Misch wrote: > > On Fri, Mar 29, 2019 at 09:53:51AM +, Daniel Gustafsson wrote: > > > > This seems like a case where it would be useful to log a shmdt

Re: Extending USE_MODULE_DB to more test suite types

On Mon, Apr 01, 2019 at 01:01:11PM -0400, Andrew Dunstan wrote: > On Mon, Apr 1, 2019 at 9:52 AM Noah Misch wrote: > > I plan to back-patch the PostgreSQL patch, to combat buildfarm noise. > > Perhaps > > someone has test automation that sets USE_MODULE_DB a

  1   2   3   4   5   6   7   8   9   >