Re: Add more information_schema columns

2018-02-16 Thread Peter Eisentraut
On 2/13/18 18:39, Tom Lane wrote: > Andres Freund writes: >> Do we have a policy about catversion bumps for information schema >> changes? A cluster from before this commit fails the regression tests >> after the change, but still mostly works... > > I think historically we've not bumped catversi

Re: Add more information_schema columns

2018-02-13 Thread Tom Lane
Andres Freund writes: > Do we have a policy about catversion bumps for information schema > changes? A cluster from before this commit fails the regression tests > after the change, but still mostly works... I think historically we've not bumped catversion, on the grounds that there's no incompat

Re: Add more information_schema columns

2018-02-13 Thread Andres Freund
On 2018-02-07 10:50:12 -0500, Peter Eisentraut wrote: > On 2/7/18 00:14, Michael Paquier wrote: > > On Tue, Feb 06, 2018 at 10:45:52PM -0500, Peter Eisentraut wrote: > >> I think what I had meant to write was something like > >> > >> (t.tgtype & (1 | 66)) > >> > >> but maybe it's clearer to wri

Re: Add more information_schema columns

2018-02-07 Thread Michael Paquier
On Wed, Feb 07, 2018 at 10:50:12AM -0500, Peter Eisentraut wrote: > Committed with the separate entries. Thanks. The result looks fine to me. -- Michael signature.asc Description: PGP signature

Re: Add more information_schema columns

2018-02-07 Thread Peter Eisentraut
On 2/7/18 00:14, Michael Paquier wrote: > On Tue, Feb 06, 2018 at 10:45:52PM -0500, Peter Eisentraut wrote: >> I think what I had meant to write was something like >> >> (t.tgtype & (1 | 66)) >> >> but maybe it's clearer to write it all out as you did. > > If you prefer that, that's fine for m

Re: Add more information_schema columns

2018-02-06 Thread Michael Paquier
On Tue, Feb 06, 2018 at 10:45:52PM -0500, Peter Eisentraut wrote: > I think what I had meant to write was something like > > (t.tgtype & (1 | 66)) > > but maybe it's clearer to write it all out as you did. If you prefer that, that's fine for me as well. I tend to prefer the formulation wher

Re: Add more information_schema columns

2018-02-06 Thread Peter Eisentraut
On 2/6/18 17:15, Michael Paquier wrote: > On Tue, Feb 06, 2018 at 03:16:59PM -0500, Robert Haas wrote: >> What possible point can there be to such an expression? It's always 0. >> >> rhaas=# select distinct tgtype::smallint & 1 & 66 from >> generate_series(-32768,32767) tgtype; >> ?column? >>

Re: Add more information_schema columns

2018-02-06 Thread Michael Paquier
On Tue, Feb 06, 2018 at 03:16:59PM -0500, Robert Haas wrote: > What possible point can there be to such an expression? It's always 0. > > rhaas=# select distinct tgtype::smallint & 1 & 66 from > generate_series(-32768,32767) tgtype; > ?column? > -- > 0 > (1 row) Of course you are

Re: Add more information_schema columns

2018-02-06 Thread Robert Haas
On Tue, Feb 6, 2018 at 2:15 AM, Michael Paquier wrote: > Better to use parenthesis for (t.tgtype & 1 & 66) perhaps? You may want > to comment that this is to filter per row-statement first, and then with > after/before/instead of, which are what the 1 and the 66 are for. What possible point can t

Re: Add more information_schema columns

2018-02-06 Thread Peter Eisentraut
ices >From 3b8f1ebb8f8a89c802d1fdeeb839a9a26998917e Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Tue, 6 Feb 2018 12:28:12 -0500 Subject: [PATCH v2] Add more information_schema columns - table_constraints.enforced - triggers.action_order - triggers.action_reference_old_table - triggers.a

Re: Add more information_schema columns

2018-02-05 Thread Michael Paquier
On Mon, Feb 05, 2018 at 08:59:31PM -0500, Peter Eisentraut wrote: > Here is a patch that fills in a few more information schema columns, in > particular those related to the trigger transition tables feature. It is unfortunate that this cannot be backpatched. Here are few comments, the logic and

Add more information_schema columns

2018-02-05 Thread Peter Eisentraut
From c8e1585951859b1248f02c070929e9f83534092a Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Mon, 5 Feb 2018 20:22:16 -0500 Subject: [PATCH] Add more information_schema columns - table_constraints.enforced - triggers.action_order - triggers.action_reference_old_table - triggers.action_reference_new_table ---