Re: [HACKERS] Re: [COMMITTERS] pgsql: Force strings passed to and from plperl to be in UTF8 encoding.

On Wed, Oct 5, 2011 at 5:03 PM, Alex Hunsaker wrote: > On Wed, Oct 5, 2011 at 08:18, Robert Haas wrote: >> On Wed, Oct 5, 2011 at 3:58 AM, Amit Khandekar >> wrote: >>> I have no more issues with the patch. >>> Thanks! >> >> I think this patch needs to be added to the open CommitFest, with >> lin

Re: [HACKERS] alter table only ... drop constraint broken in HEAD

On Wed, Oct 5, 2011 at 5:53 PM, Alex Hunsaker wrote: > tldr: > > Seems to be broken by > http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=4da99ea4231e3d8bbf28b666748c1028e7b7d665 > : > commit 4da99ea4231e3d8bbf28b666748c1028e7b7d665 > Author: Robert Haas > Date:   Mon Jun 27 10:27:17

Re: [HACKERS] Bug in walsender when calling out to do_pg_stop_backup (and others?)

On Wed, Oct 5, 2011 at 10:30 PM, Magnus Hagander wrote: > When walsender calls out to do_pg_stop_backup() (during base backups), > it is not possible to terminate the process with a SIGTERM - it > requires a SIGKILL. This can leave unkillable backends for example if > archive_mode is on and archiv

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

On Wed, Oct 05, 2011 at 07:59:07PM -0400, Bruce Momjian wrote: > Mr. Aaron W. Swenson wrote: > > > With the patch I am going to commit, you will not need to use one of the > > > -D flags because pg_ctl will find the data directory location; you will > > > just specify the config-only directory wit

[HACKERS] [PATCH] Log crashed backend's query v3

Hi, My apologies for the last grumpy message I wrote; I sent it out of surprise that my patch was marked "closed" on the current commitfest. I hope I haven't discouraged you from reviewing this updated version. I think you intended to use the "Waiting on Author" status -- that leaves the commitfe

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

Mr. Aaron W. Swenson wrote: > > With the patch I am going to commit, you will not need to use one of the > > -D flags because pg_ctl will find the data directory location; you will > > just specify the config-only directory with one -D, and the > > --data-directory. > > So, you're saying that my

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

On Wed, Oct 05, 2011 at 07:20:16PM -0400, Bruce Momjian wrote: > Mr. Aaron W. Swenson wrote: > -- Start of PGP signed section. > > On Wed, Oct 05, 2011 at 10:44:38AM -0400, Bruce Momjian wrote: > > > Peter Eisentraut wrote: > > > > On m?n, 2011-10-03 at 15:09 -0400, Bruce Momjian wrote: > > > > > W

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

Mr. Aaron W. Swenson wrote: -- Start of PGP signed section. > On Wed, Oct 05, 2011 at 10:44:38AM -0400, Bruce Momjian wrote: > > Peter Eisentraut wrote: > > > On m?n, 2011-10-03 at 15:09 -0400, Bruce Momjian wrote: > > > > Why were people not using pg_ctl? > > > > > > Actually, a slight correction

Re: [HACKERS] [PATCH] Log crashed backend's query v2

On Wed, Oct 5, 2011 at 02:36, gabrielle wrote: > This review was compiled from a PDXPUG group review (Dan Colish, Mark > Wong, Brent Dombrowski, and Gabrielle Roth). Whaat, you marked the patch as "Returned with Feedback" based on this review? The only obvious change I need to make in response t

[HACKERS] alter table only ... drop constraint broken in HEAD

tldr: Seems to be broken by http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=4da99ea4231e3d8bbf28b666748c1028e7b7d665 : commit 4da99ea4231e3d8bbf28b666748c1028e7b7d665 Author: Robert Haas Date: Mon Jun 27 10:27:17 2011 -0400 Avoid having two copies of the HOT-chain search logi

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

On Wed, Oct 05, 2011 at 10:44:38AM -0400, Bruce Momjian wrote: > Peter Eisentraut wrote: > > On m?n, 2011-10-03 at 15:09 -0400, Bruce Momjian wrote: > > > Why were people not using pg_ctl? > > > > Actually, a slight correction/addition here: The Debian init script does > > use pg_ctl to start the

Re: [HACKERS] Re: [COMMITTERS] pgsql: Force strings passed to and from plperl to be in UTF8 encoding.

On Wed, Oct 5, 2011 at 08:18, Robert Haas wrote: > On Wed, Oct 5, 2011 at 3:58 AM, Amit Khandekar > wrote: >> I have no more issues with the patch. >> Thanks! > > I think this patch needs to be added to the open CommitFest, with > links to the reviews, and marked Ready for Committer. The open co

[HACKERS] Review: Non-inheritable check constraints

Hi! *Waves* First off, it all seems to work as described: - regressions pass - domains work - tried various inherit options (merging constraints, alter table no inherit etc) - pg_dump/restore I didn't care for the changes to gram.y so I reworked it a bit so we now pass is_only to AddRelationNewCo

Re: [HACKERS] Action requested - Application Softblock implemented | Issue report ID341057

On Wed, Oct 5, 2011 at 7:58 PM, Seiko Ishida (MP Tech Consulting LLC) < v-sei...@microsoft.com> wrote: > > Would this download site be a good URL for that? > *http://www.enterprisedb.com/products-services-training/pgdownload* > > N

Re: [HACKERS] Action requested - Application Softblock implemented | Issue report ID341057

On Wed, Oct 5, 2011 at 2:58 PM, Seiko Ishida (MP Tech Consulting LLC) < v-sei...@microsoft.com> wrote: > Hello all, > > Thank you for all your responses to my inquiry. > We are aware that this application version 8.2.x is pretty old and > PostgreSQL will stop releasing updates for the 8.2.X in De

Re: [HACKERS] Multixact truncation for FK locks patch

Excerpts from Alvaro Herrera's message of lun sep 26 13:16:24 -0300 2011: > So I had to look for something else -- and I think I have it: have > multixact itself track its truncation position relative to Xid. Each > pg_multixact/offset segment would store ReadNewTransactionId at the > time it is

Re: [HACKERS] [v9.2] DROP statement reworks

On Wed, Oct 5, 2011 at 12:16 PM, Kohei KaiGai wrote: > * The logic of check_object_validation() got included within >  get_relation_address(), and rewritten more smartly, as: > > +   relkind = RelationGetForm(relation)->relkind; > +   if ((objtype == OBJECT_INDEX         && relkind != RELKIND_INDE

Re: [HACKERS] Query regarding postgres lock contention - Followup

On Wed, Oct 5, 2011 at 1:48 PM, Kevin Grittner wrote: > Hamza Bin Sohail wrote: > >> My postgres version is 8.3.7 > > Why such an old version?  Why exclude the available bug fixes? > > http://www.postgresql.org/support/versioning > >>> I am aware that lock contention can be checked with lockstat

Re: [HACKERS] Query regarding postgres lock contention - Followup

Hamza Bin Sohail wrote: > My postgres version is 8.3.7 Why such an old version? Why exclude the available bug fixes? http://www.postgresql.org/support/versioning >> I am aware that lock contention can be checked with lockstat (and >> with pg_locks ? ) but I wanted to know if someone can t

Re: [HACKERS] Inlining comparators as a performance optimisation

Robert Haas wrote: > Markus Wanner took a crack at generalizing the autovacuum machinery > that we have now into something that could be used to fire up > general-purpose worker processes, but it fell down mostly because I > (and, I think, others) weren't convinced that imessages were something > w

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

Bruce Momjian wrote: > Bruce Momjian wrote: > > Robert Haas wrote: > > > On Mon, Oct 3, 2011 at 11:04 PM, Bruce Momjian wrote: > > > > OK, here is a patch that adds a -C option to the postmaster so any > > > > config variable can be dumped, even while the server is running (there > > > > is no sec

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

Bruce Momjian wrote: > Robert Haas wrote: > > On Mon, Oct 3, 2011 at 11:04 PM, Bruce Momjian wrote: > > > OK, here is a patch that adds a -C option to the postmaster so any > > > config variable can be dumped, even while the server is running (there > > > is no security check because we don't have

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

Robert Haas wrote: > On Tue, Oct 4, 2011 at 8:32 PM, Tom Lane wrote: > > I still think this is a matter for HEAD only. ?We haven't supported > > these cases in back branches and so there is little argument for > > back-patching. > > According to Bruce's original post, there is at least one 9.1 >

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

Peter Eisentraut writes: > On tis, 2011-10-04 at 17:49 -0400, Tom Lane wrote: >> As of fairly recently, the Fedora package also uses pg_ctl for both >> starting and stopping. We've fixed all the reasons that formerly >> existed to avoid use of pg_ctl, and it's a real PITA to try to >> implement t

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

Peter Eisentraut wrote: > On m?n, 2011-10-03 at 15:09 -0400, Bruce Momjian wrote: > > Why were people not using pg_ctl? > > Actually, a slight correction/addition here: The Debian init script does > use pg_ctl to start the service. Seems to work fine. Yes. The script authors discovered a workin

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

Tom Lane wrote: > Bruce Momjian writes: > > Tom Lane wrote: > >> As of fairly recently, the Fedora package also uses pg_ctl for both > >> starting and stopping. We've fixed all the reasons that formerly > >> existed to avoid use of pg_ctl, and it's a real PITA to try to > >> implement the waiting

Re: [HACKERS] Error building v9.1.1 (git) with python 3.2.2

On 05/10/11 15:24, Lou Picciano wrote: > Hackers, > > Have been following with some interest the dialog recently about getting > pl/python built within the v9 tree; most recently, I've been trying v9.1.1 > (git) and python 3.2.2. Configure and make complete without error, but 'make > install'

Re: [HACKERS] Re: [COMMITTERS] pgsql: Force strings passed to and from plperl to be in UTF8 encoding.

On Wed, Oct 5, 2011 at 3:58 AM, Amit Khandekar wrote: > I have no more issues with the patch. > Thanks! I think this patch needs to be added to the open CommitFest, with links to the reviews, and marked Ready for Committer. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise

Re: [HACKERS] Action requested - Application Softblock implemented | Issue report ID341057

On Wed, Oct 5, 2011 at 10:13 AM, Dave Page wrote: > On Wed, Oct 5, 2011 at 3:04 PM, Robert Haas wrote: >> >> That seems strange, since the MSFT guy is reporting that whatever he >> tested did work on Windows 7, but now that you've pointed out that >> Windows 8 won't be released until after we sto

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

On Tue, Oct 4, 2011 at 8:32 PM, Tom Lane wrote: > I still think this is a matter for HEAD only.  We haven't supported > these cases in back branches and so there is little argument for > back-patching. According to Bruce's original post, there is at least one 9.1 regression here relative to 9.0:

Re: [HACKERS] Action requested - Application Softblock implemented | Issue report ID341057

On Wed, Oct 5, 2011 at 3:04 PM, Robert Haas wrote: > > That seems strange, since the MSFT guy is reporting that whatever he > tested did work on Windows 7, but now that you've pointed out that > Windows 8 won't be released until after we stop supporting 8.2, I am > filled with uncaring. It might

Re: [HACKERS] [v9.2] DROP statement reworks

On Wed, Oct 5, 2011 at 4:47 AM, Kohei KaiGai wrote: > The get_relation_address() follows the logic in RemoveRelations() to be > eliminated by this patch, so it is not a code duplication. > The reason why we didn't consolidate this routine with get_object_address() > was that remove-index requires

Re: [HACKERS] Action requested - Application Softblock implemented | Issue report ID341057

On Wed, Oct 5, 2011 at 9:43 AM, Dave Page wrote: > On Wed, Oct 5, 2011 at 2:40 PM, Robert Haas wrote: >> On Wed, Oct 5, 2011 at 2:27 AM, Heikki Linnakangas >> wrote: >>> On 04.10.2011 22:46, Seiko Ishida (MP Tech Consulting LLC) wrote: Our team drives the bug notification activity with

Re: [HACKERS] Inlining comparators as a performance optimisation

On Tue, Oct 4, 2011 at 10:55 PM, Greg Stark wrote: > I agree that if we wanted to farm out entire plan nodes we would > probably end up generating new partial plans which would be handed to > other backend processes. That's not unlike what Oracle did with > Parallel Query. But i'm a bit skeptical

Re: [HACKERS] Action requested - Application Softblock implemented | Issue report ID341057

On Wed, Oct 5, 2011 at 2:40 PM, Robert Haas wrote: > On Wed, Oct 5, 2011 at 2:27 AM, Heikki Linnakangas > wrote: >> On 04.10.2011 22:46, Seiko Ishida (MP Tech Consulting LLC) wrote: >>> >>> Our team drives the bug notification activity with our valued Windows >>> partners. This email is to notify

Re: [HACKERS] Action requested - Application Softblock implemented | Issue report ID341057

On Wed, Oct 5, 2011 at 2:27 AM, Heikki Linnakangas wrote: > On 04.10.2011 22:46, Seiko Ishida (MP Tech Consulting LLC) wrote: >> >> Our team drives the bug notification activity with our valued Windows >> partners. This email is to notify you that PostgreSQL's application/driver >> experienced com

Re: [HACKERS] [PATCH] Unremovable tuple monitoring (was: Addition of some trivial auto vacuum logging)

On Tue, Oct 4, 2011 at 6:45 PM, Royce Ausburn wrote: > I'm not sure what my next step should be.  I've added this patch to the open > commit fest -- is that all for now until the commit fest begins review? Yep, except that it might be nice if you could volunteer to review someone else's patch in

[HACKERS] Error building v9.1.1 (git) with python 3.2.2

Hackers, Have been following with some interest the dialog recently about getting pl/python built within the v9 tree; most recently, I've been trying v9.1.1 (git) and python 3.2.2. Configure and make complete without error, but 'make install' does not produce any plpython.so I have since add

[HACKERS] Bug in walsender when calling out to do_pg_stop_backup (and others?)

When walsender calls out to do_pg_stop_backup() (during base backups), it is not possible to terminate the process with a SIGTERM - it requires a SIGKILL. This can leave unkillable backends for example if archive_mode is on and archive_command is failing (or not set). A similar thing would happen i

Re: [HACKERS] Double sorting split patch

Path without allocating extra bytes is attached. I run some more detailed tests on geonames and two smaller datasets from rtreeportal.org. Test tables are following: 1) test1 - geonames 2) test2 - California Roads, containing the MBRs of 2,249,727 streets 3) test3 - Tiger Streams, containing the MB

Re: [HACKERS] Displaying accumulated autovacuum cost

Excerpts from Greg Smith's message of mié oct 05 04:02:12 -0300 2011: > > On 09/29/2011 10:40 AM, Alvaro Herrera wrote: > > I reviewed this patch. My question for you is: does it make sense to > > enable to reporting of write rate even when vacuum cost accounting is > > enabled? In my opinion i

[HACKERS] Query regarding postgres lock contention - Followup

In addition to the previous post, My postgres version is 8.3.7 >Hi there, > >Just to let you know, I'm not a database expert by any means. >I have configured dbt-2 with postgres and created a database with 4000 >warehouses, >150 customers etc. The database size is over 8G. I am aware that lo

[HACKERS] Query regarding postgres lock contention

Hi there, Just to let you know, I'm not a database expert by any means. I have configured dbt-2 with postgres and created a database with 4000 warehouses, 150 customers etc. The database size is over 8G. I am aware that lock contention can be checked with lockstat (and with pg_locks ? ) but I

Re: [HACKERS] [v9.2] DROP statement reworks

Thanks for your reviewing. 2011/10/4 Robert Haas : > On Wed, Sep 28, 2011 at 11:51 AM, Kohei KaiGai wrote: >> I rebased the patches towards the latest git master, so I believe these >> are available to apply. > > Reviewing away... > > I don't see why we need one struct called ObjectProperty and a

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

On mån, 2011-10-03 at 15:09 -0400, Bruce Momjian wrote: > Why were people not using pg_ctl? Actually, a slight correction/addition here: The Debian init script does use pg_ctl to start the service. Seems to work fine. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To mak

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

On tis, 2011-10-04 at 17:49 -0400, Tom Lane wrote: > Bruce Momjian writes: > > Greg Stark wrote: > >> An interactive tool can dwim automatically but that isn't appropriate > >> for a startup script. A startupt script should always do the same > >> thing exactly and do that based on the OS policy,

Re: [HACKERS] Double sorting split patch

On Wed, Oct 5, 2011 at 11:37 AM, Heikki Linnakangas < heikki.linnakan...@enterprisedb.com> wrote: > On 04.10.2011 15:10, Alexander Korotkov wrote: > >> On Tue, Oct 4, 2011 at 1:46 PM, Heikki Linnakangas< >> heikki.linnakangas@**enterprisedb.com> >> wrote: >> >> Ok. Could you phrase that as a cod

Re: [HACKERS] Re: [COMMITTERS] pgsql: Force strings passed to and from plperl to be in UTF8 encoding.

On 5 October 2011 12:29, Alex Hunsaker wrote: > On Wed, Oct 5, 2011 at 00:30, Alex Hunsaker wrote: >> On Tue, Oct 4, 2011 at 23:46, Amit Khandekar >> wrote: > >>> You mean the final changes in plperl_helpers.h would look like >>> something like this right? : >>> >>>  static inline char * >>>  ut

Re: [HACKERS] Double sorting split patch

On 04.10.2011 15:10, Alexander Korotkov wrote: On Tue, Oct 4, 2011 at 1:46 PM, Heikki Linnakangas< heikki.linnakan...@enterprisedb.com> wrote: Ok. Could you phrase that as a code comment? Here's a version of the patch I've been working on. There's no functional changes, just a lot of moving t

Re: [HACKERS] Displaying accumulated autovacuum cost

On 09/29/2011 10:40 AM, Alvaro Herrera wrote: I reviewed this patch. My question for you is: does it make sense to enable to reporting of write rate even when vacuum cost accounting is enabled? In my opinion it would be useful to do so. If you agree, please submit an updated patch. Presu

Re: [HACKERS] Separating bgwriter and checkpointer

On Wed, Oct 5, 2011 at 5:10 AM, Dickson S. Guedes wrote: > Ah ok! I started reviewing the v4 patch version, this is my comments: ... > Well, all the tests was running with the default postgresql.conf in my > laptop but I'll setup a more "real world" environment to test for > performance regress

Re: [HACKERS] Re: [COMMITTERS] pgsql: Force strings passed to and from plperl to be in UTF8 encoding.

On Wed, Oct 5, 2011 at 00:30, Alex Hunsaker wrote: > On Tue, Oct 4, 2011 at 23:46, Amit Khandekar > wrote: >> You mean the final changes in plperl_helpers.h would look like >> something like this right? : >> >>  static inline char * >>  utf_u2e(const char *utf8_str, size_t len) >>  { >>        c