Re: [HACKERS] Re: [HACKERS] Is it necessary to rewrite table while increasing the scale of datatype numeric?

2013-09-06 Thread wangshuo
于 2013-09-06 01:41, Jeff Janes 回复: On Wed, Sep 4, 2013 at 10:06 PM, wangs...@highgo.com.cn wrote: 于 2013-09-04 23:41, Jeff Janes 回复: On Tue, Sep 3, 2013 at 9:08 PM, wangs...@highgo.com.cn wrote: Hi, Hackers! I find that it takes a long time when I increase the scale of a numeric

Re: [HACKERS] get rid of SQL_ASCII?

2013-09-06 Thread Craig Ringer
On 09/05/2013 08:47 PM, Peter Eisentraut wrote: Other ideas? Are there legitimate uses for SQL_ASCII? IMO people who want SQL_ASCII should actually be storing everything in `bytea`; that's a truer reflection of what they're actually storing, retrieving, and working with and how they're doing

Re: [HACKERS] [PERFORM] encouraging index-only scans

2013-09-06 Thread Dimitri Fontaine
Alvaro Herrera alvhe...@2ndquadrant.com writes: I'm not sure if we need to expose all these new maintenance actions as SQL commands. I strongly think we should, if only for diagnostic purposes. Also to adapt to some well defined workloads that the automatic system is not designed to handle.

[HACKERS] regression tests

2013-09-06 Thread Jeremy Harris
Hi, I don't see the regression tests running any index-hash operations. What am I missing? -- Cheers, Jeremy -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] proposal: Set effective_cache_size to greater of .conf value, shared_buffers

2013-09-06 Thread Cédric Villemain
Le jeudi 5 septembre 2013 17:14:37 Bruce Momjian a écrit : On Thu, Sep 5, 2013 at 06:14:33PM +0200, Magnus Hagander wrote: I have developed the attached patch which implements an auto-tuned effective_cache_size which is 4x the size of shared buffers. I had to set effective_cache_size

Re: [HACKERS] get rid of SQL_ASCII?

2013-09-06 Thread Florian Weimer
On 09/06/2013 09:14 AM, Craig Ringer wrote: On 09/05/2013 08:47 PM, Peter Eisentraut wrote: Other ideas? Are there legitimate uses for SQL_ASCII? IMO people who want SQL_ASCII should actually be storing everything in `bytea`; that's a truer reflection of what they're actually storing,

Re: [HACKERS] Analysis on backend-private memory usage (and a patch)

2013-09-06 Thread Greg Stark
On 4 Sep 2013 20:46, Heikki Linnakangas hlinnakan...@vmware.com wrote: One fairly simple thing we could do is to teach catcache.c to resize the caches. Then we could make the initial size of all the syscaches much smaller. At the moment, we use fairly caches for catalogs like pg_enum (256

Re: [HACKERS] [PERFORM] encouraging index-only scans

2013-09-06 Thread Hannu Krosing
On 09/06/2013 09:23 AM, Dimitri Fontaine wrote: Alvaro Herrera alvhe...@2ndquadrant.com writes: I'm not sure if we need to expose all these new maintenance actions as SQL commands. I strongly think we should, if only for diagnostic purposes. It would be much easier and more flexible to expose

[HACKERS]

2013-09-06 Thread Agustin Larreinegabe
Hi everyone: I want to know if exists a postgres function or some easy way to know if a PK in a table is already referenced in another table/tables. e.g. I want to delete a row but first I've got to change or delete in the table/tables where is referenced, and I have many table where could be

Re: [HACKERS]

2013-09-06 Thread Serge Fonville
Hi Agustin, I want to know if exists a postgres function or some easy way to know if a PK in a table is already referenced in another table/tables. Unfortunately, this is not the correct mailing list. Instead you should ask these types of questions on either NOVICE or GENERAL.

Re: [HACKERS] [PERFORM] encouraging index-only scans

2013-09-06 Thread Andres Freund
On 2013-09-06 01:22:36 -0400, Alvaro Herrera wrote: I think it's shortsighted to keep thinking of autovacuum as just a way to run VACUUM and ANALYZE. We have already discussed work items that need to be done separately, such as truncating the last few empty pages on a relation that was

Re: [HACKERS] [PERFORM] encouraging index-only scans

2013-09-06 Thread Andres Freund
On 2013-09-06 13:38:56 +0200, Hannu Krosing wrote: On 09/06/2013 09:23 AM, Dimitri Fontaine wrote: Alvaro Herrera alvhe...@2ndquadrant.com writes: I'm not sure if we need to expose all these new maintenance actions as SQL commands. I strongly think we should, if only for diagnostic

Re: [HACKERS] [RFC] Extend namespace of valid guc names

2013-09-06 Thread Andres Freund
On 2013-02-25 21:13:25 -0500, Tom Lane wrote: b) allow variables to start with a digit from the second level onwards. That seems like a seriously bad idea. I note that SET does *not* allow this; Hm. One thing about this is that we currently allow something silly as: SET 1.1barblub = 3; So

[HACKERS] [bug fix] strerror() returns ??? in a UTF-8/C database with LC_MESSAGES=non-ASCII

2013-09-06 Thread MauMau
Hello, I've been suffering from PostgreSQL's problems related to character encoding for some time. I really wish to solve those problems, because they make troubleshooting difficult. I'm going to propose fixes for them, and I would appreciate if you could help release the official patches

Re: [HACKERS] get rid of SQL_ASCII?

2013-09-06 Thread Tom Lane
Craig Ringer cr...@2ndquadrant.com writes: What we SHOULD be doing is making it an explicit decision to use SQL_ASCII, and NEVER creating a cluster or database with that encoding by default. Ever. If we can't decide what the correct default encoding is (say, if locale is C) we should error out

Re: [HACKERS] [RFC] Extend namespace of valid guc names

2013-09-06 Thread Andres Freund
On 2013-09-06 10:13:23 -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: That seems like a seriously bad idea. I note that SET does *not* allow this; Hm. One thing about this is that we currently allow something silly as: SET 1.1barblub = 3; So I'd like to either

Re: [HACKERS] [bug fix] strerror() returns ??? in a UTF-8/C database with LC_MESSAGES=non-ASCII

2013-09-06 Thread Tom Lane
MauMau maumau...@gmail.com writes: I've been suffering from PostgreSQL's problems related to character encoding for some time. I really wish to solve those problems, because they make troubleshooting difficult. I'm going to propose fixes for them, and I would appreciate if you could help

Re: [HACKERS] [RFC] Extend namespace of valid guc names

2013-09-06 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: On 2013-02-25 21:13:25 -0500, Tom Lane wrote: b) allow variables to start with a digit from the second level onwards. That seems like a seriously bad idea. I note that SET does *not* allow this; Hm. One thing about this is that we currently

Re: [HACKERS] [bug fix] strerror() returns ??? in a UTF-8/C database with LC_MESSAGES=non-ASCII

2013-09-06 Thread Andres Freund
On 2013-09-06 10:37:16 -0400, Tom Lane wrote: MauMau maumau...@gmail.com writes: I've been suffering from PostgreSQL's problems related to character encoding for some time. I really wish to solve those problems, because they make troubleshooting difficult. I'm going to propose fixes

Re: [HACKERS] regression tests

2013-09-06 Thread Robert Haas
On Fri, Sep 6, 2013 at 3:34 AM, Jeremy Harris j...@wizmail.org wrote: I don't see the regression tests running any index-hash operations. What am I missing? What's an index-hash operation? ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to

Re: [HACKERS] get rid of SQL_ASCII?

2013-09-06 Thread Robert Haas
On Fri, Sep 6, 2013 at 10:19 AM, Tom Lane t...@sss.pgh.pa.us wrote: There's a large undercurrent of I say it's bad for you in this thread, with frankly nothing to back it up. If we try to be as nanny-ish as you're suggesting here, we'll just annoy users. +1. -- Robert Haas EnterpriseDB:

Re: [HACKERS] [PERFORM] encouraging index-only scans

2013-09-06 Thread Hannu Krosing
On 09/06/2013 03:12 PM, Andres Freund wrote: On 2013-09-06 13:38:56 +0200, Hannu Krosing wrote: On 09/06/2013 09:23 AM, Dimitri Fontaine wrote: Alvaro Herrera alvhe...@2ndquadrant.com writes: I'm not sure if we need to expose all these new maintenance actions as SQL commands. I strongly

Re: [HACKERS] [bug fix] strerror() returns ??? in a UTF-8/C database with LC_MESSAGES=non-ASCII

2013-09-06 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: I have no clue about the gettext stuff but I am in favor of including the raw errno in strerror() messages (no backpatching tho). I dislike that on grounds of readability and translatability; and I'm also of the opinion that errno codes aren't really

Re: [HACKERS] [bug fix] strerror() returns ??? in a UTF-8/C database with LC_MESSAGES=non-ASCII

2013-09-06 Thread Andres Freund
On 2013-09-06 10:52:03 -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: I have no clue about the gettext stuff but I am in favor of including the raw errno in strerror() messages (no backpatching tho). I dislike that on grounds of readability and translatability; and

[HACKERS] Re: [HACKERS] Re: [HACKERS] Is it necessary to rewrite table while increasing the scale of datatype numeric?

2013-09-06 Thread Kevin Grittner
wangs...@highgo.com.cn wangs...@highgo.com.cn wrote: I modified the code for this situation.I consider it very simple. It will does not modify the table file, when the scale has been increased exclusively. This patch would allow data in a column which was not consistent with the column

Re: [HACKERS] get rid of SQL_ASCII?

2013-09-06 Thread Kevin Grittner
Robert Haas robertmh...@gmail.com wrote: Tom Lane t...@sss.pgh.pa.us wrote: There's a large undercurrent of I say it's bad for you in this thread, with frankly nothing to back it up.  If we try to be as nanny-ish as you're suggesting here, we'll just annoy users. +1. +1 I can definitely

Re: [HACKERS] [bug fix] strerror() returns ??? in a UTF-8/C database with LC_MESSAGES=non-ASCII

2013-09-06 Thread Greg Stark
On Fri, Sep 6, 2013 at 3:57 PM, Andres Freund and...@2ndquadrant.comwrote: On 2013-09-06 10:52:03 -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: I have no clue about the gettext stuff but I am in favor of including the raw errno in strerror() messages (no

[HACKERS] Re: [HACKERS] Re: [HACKERS] Is it necessary to rewrite table while increasing the scale of datatype numeric?

2013-09-06 Thread Greg Stark
On Thu, Sep 5, 2013 at 8:53 PM, Alvaro Herrera alvhe...@2ndquadrant.comwrote: Greg Stark escribió: The main difficulty is that Postgres is very extensible. So to implement this you need to think bigger than NUMERIC. It should also be possible to alter a column from varchar(5) to

Re: [HACKERS] [PERFORM] encouraging index-only scans

2013-09-06 Thread Andres Freund
On 2013-09-06 12:30:56 -0400, Bruce Momjian wrote: I am not sure I understand this though. What would be the point to go and set all visible and not do the rest of the vacuuming work? I think triggering vacuuming by scanning the visibility map for the number of unset bits and use that as

Re: [HACKERS] regression tests

2013-09-06 Thread Jeremy Harris
On 06/09/13 15:44, Robert Haas wrote: On Fri, Sep 6, 2013 at 3:34 AM, Jeremy Harris j...@wizmail.org wrote: I don't see the regression tests running any index-hash operations. What am I missing? What's an index-hash operation? Ones that hit tuplesort_begin_index_hash() -- Cheers,

Re: [HACKERS] [PERFORM] encouraging index-only scans

2013-09-06 Thread Bruce Momjian
On Fri, Sep 6, 2013 at 03:08:54PM +0200, Andres Freund wrote: On 2013-09-06 01:22:36 -0400, Alvaro Herrera wrote: I think it's shortsighted to keep thinking of autovacuum as just a way to run VACUUM and ANALYZE. We have already discussed work items that need to be done separately, such as

[HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Is it necessary to rewrite table while increasing the scale of datatype numeric?

2013-09-06 Thread Hannu Krosing
On 09/06/2013 07:57 PM, Robert Haas wrote: On Fri, Sep 6, 2013 at 12:34 PM, Greg Stark st...@mit.edu wrote: But I wonder if we could just declare that that's not what the scale typmod does. That it's just a maximum scale but it's perfectly valid for NUMERIC data with lower scales to be stored

[HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Is it necessary to rewrite table while increasing the scale of datatype numeric?

2013-09-06 Thread Robert Haas
On Fri, Sep 6, 2013 at 12:34 PM, Greg Stark st...@mit.edu wrote: But I wonder if we could just declare that that's not what the scale typmod does. That it's just a maximum scale but it's perfectly valid for NUMERIC data with lower scales to be stored in a column than the typmod says. In a way

Re: [HACKERS] dynamic shared memory

2013-09-06 Thread Jim Nasby
On 9/5/13 11:37 AM, Robert Haas wrote: ISTM that at some point we'll want to look at putting top-level shared memory into this system (ie: allowing dynamic resizing of GUCs that affect shared memory size). A lot of people want that, but being able to resize the shared memory chunk itself is

Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Is it necessary to rewrite table while increasing the scale of datatype numeric?

2013-09-06 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: Sure, but the point is that 5. is not the same as 5.000 today. If you start whacking this around you'll be changing that behavior, I think. Yeah. And please note that no matter what the OP may think, a lot of people *do* consider that there's a

Re: [HACKERS] [PERFORM] encouraging index-only scans

2013-09-06 Thread Jim Nasby
On 9/6/13 2:13 PM, Bruce Momjian wrote: On Fri, Sep 6, 2013 at 01:01:59PM -0400, Bruce Momjian wrote: This December 2012 thread by Andrew Dunstan shows he wasn't aware that a manual VACUUM was required for index-only scans. That thread ended with us realizing that pg_upgrade's ANALYZE runs

[HACKERS] Fix picksplit with nan values

2013-09-06 Thread Alexander Korotkov
Hackers, PostGIS spotted that picksplit algorithm freezes in infinite loop when dealing with nan values. I discovered same bug is present in core opclasses. Attached patch fixes this issue interpreting nan as value greater than infinity like btree comparison function does. This patch contain copy

Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Is it necessary to rewrite table while increasing the scale of datatype numeric?

2013-09-06 Thread Tom Lane
Greg Stark st...@mit.edu writes: But I wonder if we could just declare that that's not what the scale typmod does. That it's just a maximum scale but it's perfectly valid for NUMERIC data with lower scales to be stored in a column than the typmod says. In a way the current behaviour is like

[HACKERS] Re: [HACKERS] Re: [HACKERS] Is it necessary to rewrite table while increasing the scale of datatype numeric?

2013-09-06 Thread Jeff Janes
On Fri, Sep 6, 2013 at 9:34 AM, Greg Stark st...@mit.edu wrote: But I wonder if we could just declare that that's not what the scale typmod does. That it's just a maximum scale but it's perfectly valid for NUMERIC data with lower scales to be stored in a column than the typmod says. In a way

Re: [HACKERS] [PERFORM] encouraging index-only scans

2013-09-06 Thread Jim Nasby
On 9/5/13 8:29 PM, Gavin Flower wrote: How about a 'VACUUM AFTER' command (part of the 'BEGIN' transaction syntax?) that would: 1. only be valid in a transaction 2. initiate a vacuum after the current transaction completed 3. defer any vacuum triggered due to other criteria If the

Re: [HACKERS] Is it necessary to rewrite table while increasing the scale of datatype numeric?

2013-09-06 Thread Alvaro Herrera
Jim Nasby escribió: I also have a vague memory of some features that would benefit from being able to have typemod info available at a tuple level in a table, not just for the entire table. Unfortunately I can't remember why we wanted that... (Alvaro, do you recall? I'm pretty sure it's

Re: [HACKERS] [RFC] Extend namespace of valid guc names

2013-09-06 Thread Hannu Krosing
On 09/06/2013 08:48 PM, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On 2013-09-06 10:13:23 -0400, Tom Lane wrote: Well, if you feel an absolute compulsion to make them consistent, I'd go with making SET disallow creation of variables with names the file parser wouldn't

Re: [HACKERS] Hstore: Query speedups with Gin index

2013-09-06 Thread Oleg Bartunov
Blake, I think it's better to implement this patch as a separate opclass, so users will have option to choose indexing. Oleg On Tue, Sep 3, 2013 at 6:24 PM, Blake Smith blakesmi...@gmail.com wrote: Thanks for the feedback everyone. I've attached the patch that we are now running in

Re: [HACKERS] regression tests

2013-09-06 Thread Robert Haas
On Fri, Sep 6, 2013 at 1:34 PM, Jeremy Harris j...@wizmail.org wrote: What's an index-hash operation? Ones that hit tuplesort_begin_index_hash() Oh. Well, it looks to me like that function can only get called when building a hash index. Specifically, according to the comment in hashbuild(),

Re: [HACKERS] [RFC] Extend namespace of valid guc names

2013-09-06 Thread Tom Lane
Hannu Krosing ha...@2ndquadrant.com writes: On 09/06/2013 08:48 PM, Tom Lane wrote: Well, sure, but I would think that ALTER SYSTEM SET should be constrained to only set known GUCs, not invent new ones on the fly. What's the reasoning behind this ? If you don't know what a GUC is, you don't

Re: [HACKERS] Fix picksplit with nan values

2013-09-06 Thread Tom Lane
Alexander Korotkov aekorot...@gmail.com writes: PostGIS spotted that picksplit algorithm freezes in infinite loop when dealing with nan values. I discovered same bug is present in core opclasses. Attached patch fixes this issue interpreting nan as value greater than infinity like btree

Re: [HACKERS] [PERFORM] encouraging index-only scans

2013-09-06 Thread Andres Freund
On 2013-09-06 15:13:30 -0400, Bruce Momjian wrote: On Fri, Sep 6, 2013 at 01:01:59PM -0400, Bruce Momjian wrote: This December 2012 thread by Andrew Dunstan shows he wasn't aware that a manual VACUUM was required for index-only scans. That thread ended with us realizing that pg_upgrade's

Re: [HACKERS] [RFC] Extend namespace of valid guc names

2013-09-06 Thread Andres Freund
On 2013-09-06 14:48:33 -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On 2013-09-06 10:13:23 -0400, Tom Lane wrote: Well, if you feel an absolute compulsion to make them consistent, I'd go with making SET disallow creation of variables with names the file parser

Re: [HACKERS] [RFC] Extend namespace of valid guc names

2013-09-06 Thread Robert Haas
On Fri, Sep 6, 2013 at 6:31 PM, Andres Freund and...@2ndquadrant.com wrote: On 2013-09-06 14:48:33 -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On 2013-09-06 10:13:23 -0400, Tom Lane wrote: Well, if you feel an absolute compulsion to make them consistent, I'd go with

Re: [HACKERS] Custom Plan node

2013-09-06 Thread Robert Haas
On Fri, Sep 6, 2013 at 4:53 PM, Tom Lane t...@sss.pgh.pa.us wrote: Kohei KaiGai kai...@kaigai.gr.jp writes: The attached patch adds a new plan node type; CustomPlan that enables extensions to get control during query execution, via registered callbacks. TBH, I think this is really an exercise

Re: [HACKERS] Valgrind Memcheck support

2013-09-06 Thread Greg Stark
On Sun, Jun 9, 2013 at 10:25 PM, Noah Misch n...@leadboat.com wrote: - Test recovery, such as by running a streaming replica under Memcheck while the primary runs make installcheck-world. In general we need a lot more testing on the recovery code. - Memcheck has support for detecting

[HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Is it necessary to rewrite table while increasing the scale of datatype numeric?

2013-09-06 Thread Robert Haas
On Fri, Sep 6, 2013 at 2:34 PM, Hannu Krosing ha...@2ndquadrant.com wrote: On 09/06/2013 07:57 PM, Robert Haas wrote: On Fri, Sep 6, 2013 at 12:34 PM, Greg Stark st...@mit.edu wrote: But I wonder if we could just declare that that's not what the scale typmod does. That it's just a maximum

Re: [HACKERS] Custom Plan node

2013-09-06 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: I find this a somewhat depressing response. Didn't we discuss this exact design at the developer meeting in Ottawa? I thought it sounded reasonable to you then, or at least I don't remember you panning it. What I recall saying is that I didn't see

Re: [HACKERS] Valgrind Memcheck support

2013-09-06 Thread Noah Misch
On Wed, Aug 28, 2013 at 10:30:34PM -0400, Noah Misch wrote: On Wed, Aug 28, 2013 at 03:16:14PM +0200, Andres Freund wrote: I vote for just removing that VALGRIND_PRINTF - it doesn't give you anything you cannot easily achieve otherwise... Done. I'd like to see a buildfarm member running

Re: [HACKERS] [PERFORM] encouraging index-only scans

2013-09-06 Thread Andres Freund
On 2013-09-06 13:01:59 -0400, Bruce Momjian wrote: On Fri, Sep 6, 2013 at 06:36:47PM +0200, Andres Freund wrote: On 2013-09-06 12:30:56 -0400, Bruce Momjian wrote: I am not sure I understand this though. What would be the point to go and set all visible and not do the rest of the

[HACKERS] Re: [HACKERS] Is it necessary to rewrite table while increasing the scale of datatype numeric?

2013-09-06 Thread Jim Nasby
On 9/5/13 10:47 PM, Noah Misch wrote: On Thu, Sep 05, 2013 at 10:41:25AM -0700, Jeff Janes wrote: In order to avoid the rewrite, the code would have to be changed to look up the column definition and if it specifies the scale, then ignore the per-row n_header, and look at the n_header only if

Re: [HACKERS] [PERFORM] encouraging index-only scans

2013-09-06 Thread Bruce Momjian
On Fri, Sep 6, 2013 at 01:01:59PM -0400, Bruce Momjian wrote: This December 2012 thread by Andrew Dunstan shows he wasn't aware that a manual VACUUM was required for index-only scans. That thread ended with us realizing that pg_upgrade's ANALYZE runs will populate pg_class.relallvisible.

Re: [HACKERS] Hstore: Query speedups with Gin index

2013-09-06 Thread Peter Eisentraut
On 9/5/13 2:42 PM, Blake Smith wrote: Thanks for checking the tests. I wasn't able to duplicate your test results. Did you run the hstore regression tests with the revised patch I attached in the thread? Attached is the output I got with the latest patch applied. See

Re: [HACKERS] [PERFORM] encouraging index-only scans

2013-09-06 Thread Bruce Momjian
On Sat, Sep 7, 2013 at 12:26:23AM +0200, Andres Freund wrote: So, what should trigger an auto-vacuum vacuum for these workloads? Rather than activity, which is what normally drives autovacuum, it is lack of activity that should drive it, combined with a high VM cleared bit percentage.

Re: [HACKERS] Custom Plan node

2013-09-06 Thread Tom Lane
Kohei KaiGai kai...@kaigai.gr.jp writes: The attached patch adds a new plan node type; CustomPlan that enables extensions to get control during query execution, via registered callbacks. TBH, I think this is really an exercise in building useless mechanism. I don't believe that any actually

Re: [HACKERS] [PERFORM] encouraging index-only scans

2013-09-06 Thread Bruce Momjian
On Fri, Sep 6, 2013 at 06:36:47PM +0200, Andres Freund wrote: On 2013-09-06 12:30:56 -0400, Bruce Momjian wrote: I am not sure I understand this though. What would be the point to go and set all visible and not do the rest of the vacuuming work? I think triggering vacuuming by

Re: [HACKERS] [v9.4] row level security

2013-09-06 Thread Peter Eisentraut
On Wed, 2013-08-28 at 13:56 +0200, Kohei KaiGai wrote: The attached patch fixed the portion I was pointed out, so its overall design has not been changed so much. The documentation doesn't build: openjade:catalogs.sgml:237:28:X: reference to non-existent ID CATALOG-PG-ROWLEVELSEC -- Sent

Re: [HACKERS] ECPG FETCH readahead

2013-09-06 Thread Peter Eisentraut
On Wed, 2013-09-04 at 10:06 +0200, Boszormenyi Zoltan wrote: 2013-08-17 12:08 keltezéssel, Boszormenyi Zoltan írta: I have put the broken up patchset into a GIT tree of mine at GitHub: https://github.com/zboszor/ecpg-readahead/ but the huge compressed patch is also attached for reference.

Re: [HACKERS] [RFC] Extend namespace of valid guc names

2013-09-06 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: On 2013-09-06 10:13:23 -0400, Tom Lane wrote: Well, if you feel an absolute compulsion to make them consistent, I'd go with making SET disallow creation of variables with names the file parser wouldn't recognize. But why is it such a bad thing if

Re: [HACKERS] [bug fix] strerror() returns ??? in a UTF-8/C database with LC_MESSAGES=non-ASCII

2013-09-06 Thread Tom Lane
Greg Stark st...@mit.edu writes: What would be nicer would be to display the C define, EINVAL, EPERM, etc. Afaik there's no portable way to do that though. I suppose we could just have a small array or hash table of all the errors we know about and look it up. Yeah, I was just thinking the

Re: [HACKERS] strange IS NULL behaviour

2013-09-06 Thread Bruce Momjian
On Thu, Sep 5, 2013 at 05:06:41PM -0400, Bruce Momjian wrote: Another possible fix would be to avoid the IS NULL value optimizer expansion if a ROW construct is inside a ROW(). I have attached a patch that does this for review. Having received no replies, do people perfer this version of the

Re: [HACKERS] strange IS NULL behaviour

2013-09-06 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: On Thu, Sep 5, 2013 at 05:06:41PM -0400, Bruce Momjian wrote: Another possible fix would be to avoid the IS NULL value optimizer expansion if a ROW construct is inside a ROW(). I have attached a patch that does this for review. Having received no

Re: [HACKERS] strange IS NULL behaviour

2013-09-06 Thread Bruce Momjian
On Fri, Sep 6, 2013 at 11:00:24PM -0400, Tom Lane wrote: Bruce Momjian br...@momjian.us writes: On Thu, Sep 5, 2013 at 05:06:41PM -0400, Bruce Momjian wrote: Another possible fix would be to avoid the IS NULL value optimizer expansion if a ROW construct is inside a ROW(). I have attached

Re: [HACKERS] [RFC] Extend namespace of valid guc names

2013-09-06 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Fri, Sep 6, 2013 at 6:31 PM, Andres Freund and...@2ndquadrant.com wrote: On 2013-09-06 14:48:33 -0400, Tom Lane wrote: Well, sure, but I would think that ALTER SYSTEM SET should be constrained to only set known GUCs, not invent new ones on the fly.

Re: [HACKERS] Custom Plan node

2013-09-06 Thread Kohei KaiGai
2013/9/7 Tom Lane t...@sss.pgh.pa.us: Robert Haas robertmh...@gmail.com writes: I find this a somewhat depressing response. Didn't we discuss this exact design at the developer meeting in Ottawa? I thought it sounded reasonable to you then, or at least I don't remember you panning it. What

Re: [HACKERS] New statistics for WAL buffer dirty writes

2013-09-06 Thread Satoshi Nagayasu
Hi, The revised patch for wal buffer statistics is attached. A test script is also attached. Please take a look. Regards, (2013/07/19 7:49), Satoshi Nagayasu wrote: Will revise and re-resubmit for the next CF. Regards, 2013/07/19 1:06, Alvaro Herrera wrote: What happened to this patch?

Re: [HACKERS] [PERFORM] encouraging index-only scans

2013-09-06 Thread Andres Freund
On 2013-09-06 20:29:08 -0400, Bruce Momjian wrote: On Sat, Sep 7, 2013 at 12:26:23AM +0200, Andres Freund wrote: I wonder if we shouldn't trigger most vacuums (not analyze!) via unset fsm bits. Perhaps combined with keeping track of RecentGlobalXmin to Fsm bits? FSM tracks the free space

Re: [HACKERS] strange IS NULL behaviour

2013-09-06 Thread Andres Freund
On 2013-09-06 23:07:04 -0400, Bruce Momjian wrote: On Fri, Sep 6, 2013 at 11:00:24PM -0400, Tom Lane wrote: Bruce Momjian br...@momjian.us writes: On Thu, Sep 5, 2013 at 05:06:41PM -0400, Bruce Momjian wrote: Another possible fix would be to avoid the IS NULL value optimizer