Re: [HACKERS] jsonb status

2014-03-16 Thread Erik Rijkers
On Sun, March 16, 2014 09:10, Peter Geoghegan wrote: [ jsonb-11.patch.gz ] This doesn't quite compile: [...] patching file src/include/catalog/pg_amop.h patching file src/include/catalog/pg_amproc.h Hunk #3 FAILED at 358. 1 out of 3 hunks FAILED -- saving rejects to file

[HACKERS] [RFC] What should we do for reliable WAL archiving?

2014-03-16 Thread MauMau
Hello, The PostgreSQL documentation describes cp (on UNIX/Linux) or copy (on Windows) as an example for archive_command. However, cp/copy does not sync the copied data to disk. As a result, the completed WAL segments would be lost in the following sequence: 1. A WAL segment fills up. 2.

Re: [HACKERS] [bug fix] postgres.exe fails to start on Windows Server 2012 due to ASLR

2014-03-16 Thread Magnus Hagander
On Sat, Feb 22, 2014 at 5:44 AM, MauMau maumau...@gmail.com wrote: From: Magnus Hagander mag...@hagander.net Does somebody want to look at backpatching this to 9.1 and earlier, or should we just say that it's not fully supported on those Windows versions unless you apply the registry

Re: [HACKERS] Upcoming back branch releases

2014-03-16 Thread Magnus Hagander
On Sun, Mar 16, 2014 at 3:20 AM, MauMau maumau...@gmail.com wrote: eFrom: Tom Lane t...@sss.pgh.pa.us After some discussion, the core committee has concluded that the WAL-replay bug fixed in commit 6bfa88acd3df830a5f7e8677c13512b1b50ae813 is indeed bad enough to justify near-term update

Re: [HACKERS] requested shared memory size overflows size_t

2014-03-16 Thread Yuri Levinsky
Dear Craig, The output is: #define SIZEOF_OFF_T 8 #define SIZEOF_VOID_P 4 #define SIZEOF_SIZE_T 4 #define SIZEOF_LONG 4 Configured with: ../configure --with-as=/usr/ccs/bin/as --with-ld=/usr/ccs/bin/ld --enable-shared --enable-languages=c,c++,f77 Thread model: posix gcc version 3.4.6

Re: [HACKERS] [RFC] What should we do for reliable WAL archiving?

2014-03-16 Thread Amit Kapila
On Sun, Mar 16, 2014 at 3:53 PM, MauMau maumau...@gmail.com wrote: Hello, The PostgreSQL documentation describes cp (on UNIX/Linux) or copy (on Windows) as an example for archive_command. However, cp/copy does not sync the copied data to disk. As a result, the completed WAL segments would

Re: [HACKERS] jsonb status - ‘JsonbValue’ has no member named ‘size’

2014-03-16 Thread Erik Rijkers
On Sun, March 16, 2014 09:50, Peter Geoghegan wrote: On Sun, Mar 16, 2014 at 1:28 AM, Erik Rijkers e...@xs4all.nl wrote: [ jsonb-11.patch.gz ] This doesn't quite compile: Sorry. I guess Andrew's earlier merging of master was insufficient. Attached revision fixes bitrot. Patch applies,

[HACKERS] AUTOCOMMIT off + ON_ERROR_ROLLBACK usability

2014-03-16 Thread Greg Stark
I've been putting my money where my mouth is and running with AUTOCOMMIT=off and ON_ERROR_ROLLBACK set which I've been recommending for years but hadn't gotten around to switching to myself. I think we knew the user experience wasn't perfect but it would be nice to enumerate the problems and they

[HACKERS] [WIP] Better partial index-only scans

2014-03-16 Thread Joshua Yanovski
Proof of concept initial patch for enabling index only scans for partial indices even when an attribute is not in the target list, as long as it is only used in restriction clauses that can be proved by the index predicate. This also works for index quals, though they still can't be used in the

Re: [HACKERS] [bug fix] PostgreSQL fails to start on Windows if it crashes after tablespace creation

2014-03-16 Thread Amit Kapila
On Wed, Jan 15, 2014 at 8:12 PM, MauMau maumau...@gmail.com wrote: From: Asif Naeem anaeem...@gmail.com As you have followed destroy_tablespace_directories() function, Is there any specific reason not to use same logic to detect type of the file/link i.e. (lstat(linkloc, st) == 0

Re: [HACKERS] requested shared memory size overflows size_t

2014-03-16 Thread Craig Ringer
On 03/16/2014 06:57 PM, Yuri Levinsky wrote: Dear Craig, The output is: #define SIZEOF_OFF_T 8 #define SIZEOF_VOID_P 4 #define SIZEOF_SIZE_T 4 OK, that confirms you have done a 32-bit build. You need to figure out how to invoke the 64-bit toolchain on your Solaris version. You might need

[HACKERS] create type- similar char

2014-03-16 Thread Mohsen SM
I create one new type with CREATE TYPE command. for my type its INTERNALLENGTH is VARIABLE . but I want to my type behavior similar to char and when I type this query: CREATE TABLE tbl (col1 NEWTYPE); then when I write this query, so it get an error for it's length: insert into tbl values('dd');

Re: [HACKERS] create type- similar char

2014-03-16 Thread Pavel Stehule
Hello I don't know where is a problem, but I can put a two advices a) start by extending some known extension b) look to source code, where and why a exception was raised. Verbose mode can help [pavel@localhost ~]$ psql postgres psql (9.4devel) Type help for help. postgres=# \set VERBOSITY

Re: [HACKERS] requested shared memory size overflows size_t

2014-03-16 Thread Yuri Levinsky
Craig, Is this output correct now? #define SIZEOF_OFF_T 8 #define SIZEOF_VOID_P 8 #define SIZEOF_SIZE_T 8 #define SIZEOF_LONG 8 Sincerely yours, Yuri Levinsky, DBA Celltick Technologies Ltd., 32 Maskit St., Herzliya 46733, Israel Mobile: +972 54 6107703, Office: +972 9 9710239; Fax: +972 9

Re: [HACKERS] jsonb status - 'JsonbValue' has no member named 'size'

2014-03-16 Thread Erik Rijkers
On Sun, March 16, 2014 13:23, Andrew Dunstan wrote: [ jsonb-12.patch ] patch applies; compiles, and builds, but contrib installs with this error: make[1]: *** No rule to make target `hstore--1.2.sql', needed by `installdata'. Stop. make: *** [install-hstore-recurse] Error 2 After that an

Re: [HACKERS] [RFC] What should we do for reliable WAL archiving?

2014-03-16 Thread MauMau
From: Amit Kapila amit.kapil...@gmail.com How about using pg_receivexlog for archiving purpose? pg_receivexlog is good in that it does fsync(). But it seems difficult to use correctly, and I'm not sure if I can catch all WAL segments without any loss. pg_receivexlog must be started with

Re: [HACKERS] requested shared memory size overflows size_t

2014-03-16 Thread Craig Ringer
On 16 Mar 2014 22:06, Yuri Levinsky yu...@celltick.com wrote: Craig, Is this output correct now? #define SIZEOF_OFF_T 8 #define SIZEOF_VOID_P 8 Well, you are getting 64-bit pointers. So if you are trying to produce a 64-bit executable then yes, this looks appropriate. -- Sent via

Re: [HACKERS] [RFC] What should we do for reliable WAL archiving?

2014-03-16 Thread Greg Stark
On Sun, Mar 16, 2014 at 10:23 AM, MauMau maumau...@gmail.com wrote: The PostgreSQL documentation describes cp (on UNIX/Linux) or copy (on Windows) as an example for archive_command. However, cp/copy does not sync the copied data to disk I'm actually a lot less concerned about fsyncing the

Re: [HACKERS] Portability issues in shm_mq

2014-03-16 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Fri, Mar 14, 2014 at 4:43 PM, Tom Lane t...@sss.pgh.pa.us wrote: How is that leading to a crash? Well, this machine is 32-bit, so MAXALIGN is only 4. This means it is possible for an odd-length message cum message length word to not exactly divide

Re: [HACKERS] create type- similar char

2014-03-16 Thread Tom Lane
Mohsen SM mohsensoodk...@gmail.com writes: I create one new type with CREATE TYPE command. for my type its INTERNALLENGTH is VARIABLE . but I want to my type behavior similar to char and when I type this query: CREATE TABLE tbl (col1 NEWTYPE); then when I write this query, so it get an error

Re: [HACKERS] Minimum supported version of Python?

2014-03-16 Thread Tom Lane
Brendan Jurd dire...@gmail.com writes: On 16 March 2014 11:55, Tom Lane t...@sss.pgh.pa.us wrote: Our documentation claims that the minimum Python version for plpython is 2.3. However, an attempt to build with that on an old Mac yielded a bunch of failures in the plpython_types regression

Re: [HACKERS] First-draft release notes for next week's releases

2014-03-16 Thread Josh Berkus
On 03/15/2014 01:02 PM, Tom Lane wrote: First-draft release notes are committed, and should be visible at http://www.postgresql.org/docs/devel/static/release-9-3-4.html once guaibasaurus does its next buildfarm run a few minutes from now. Any suggestions? Hmmm, not sure I like this. It's

Re: [HACKERS] [RFC] What should we do for reliable WAL archiving?

2014-03-16 Thread Andreas Karlsson
On 03/16/2014 03:23 PM, MauMau wrote: From: Amit Kapila amit.kapil...@gmail.com How about using pg_receivexlog for archiving purpose? pg_receivexlog is good in that it does fsync(). But it seems difficult to use correctly, and I'm not sure if I can catch all WAL segments without any loss.

Re: [HACKERS] First-draft release notes for next week's releases

2014-03-16 Thread Greg Stark
This is not really accurate: This error allowed multiple versions of the same row to become visible to queries, resulting in apparent duplicates. Since the error is in WAL replay, it would only manifest during crash recovery or on standby servers. I think the idea is coming from what the second

Re: [HACKERS] Archive recovery won't be completed on some situation.

2014-03-16 Thread Kyotaro HORIGUCHI
Thank you for good suggestion. What the mess is once entering this situation, I could find no formal operation to exit from it. Though this is formal way, you can exit from that situation by (1) Remove recovery.conf and start the server with crash recovery (2) Execute pg_start_backup()

Re: [HACKERS] [RFC] What should we do for reliable WAL archiving?

2014-03-16 Thread Robert Haas
On Sun, Mar 16, 2014 at 6:23 AM, MauMau maumau...@gmail.com wrote: The PostgreSQL documentation describes cp (on UNIX/Linux) or copy (on Windows) as an example for archive_command. However, cp/copy does not sync the copied data to disk. As a result, the completed WAL segments would be lost

Re: [HACKERS] Portability issues in shm_mq

2014-03-16 Thread Robert Haas
On Sun, Mar 16, 2014 at 11:26 AM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Fri, Mar 14, 2014 at 4:43 PM, Tom Lane t...@sss.pgh.pa.us wrote: How is that leading to a crash? Well, this machine is 32-bit, so MAXALIGN is only 4. This means it is possible

Re: [HACKERS] Archive recovery won't be completed on some situation.

2014-03-16 Thread Kyotaro HORIGUCHI
Hello, very sorry to have bothered you by silly question. me It is in far better proportion than recovery.conf option:), since me it is already warned to be dangerous as its nature. Anyway I'll me make sure the situation under the trouble fist. It looks exactly the 'starting up as standby of

Re: [HACKERS] Minimum supported version of Python?

2014-03-16 Thread Peter Eisentraut
On Sat, 2014-03-15 at 20:55 -0400, Tom Lane wrote: Our documentation claims that the minimum Python version for plpython is 2.3. However, an attempt to build with that on an old Mac yielded a bunch of failures in the plpython_types regression test, It has frequently been the case that the

Re: [HACKERS] Minimum supported version of Python?

2014-03-16 Thread Peter Eisentraut
On Sun, 2014-03-16 at 15:56 +1100, Brendan Jurd wrote: Versions earlier than 2.5 are probably only of interest to historians at this point. and users of RHEL 5 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] [BUGS] BUG #9223: plperlu result memory leak

2014-03-16 Thread Alvaro Herrera
Alex Hunsaker escribió: On Wed, Mar 5, 2014 at 12:55 PM, Alex Hunsaker bada...@gmail.com wrote: On Wed, Mar 5, 2014 at 12:22 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Can I bug you into verifying what supported releases need this patch, and to which does it backpatch cleanly?

Re: [HACKERS] Portability issues in shm_mq

2014-03-16 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: But I think there's another possible problem here. In order for reads from the buffer not to suffer alignment problems, the chunk size for reads and writes from the buffer needs to be MAXIMUM_ALIGNOF (or some multiple of it). And in order to avoid a

Re: [HACKERS] Minimum supported version of Python?

2014-03-16 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On Sat, 2014-03-15 at 20:55 -0400, Tom Lane wrote: Our documentation claims that the minimum Python version for plpython is 2.3. However, an attempt to build with that on an old Mac yielded a bunch of failures in the plpython_types regression test,

Re: [HACKERS] First-draft release notes for next week's releases

2014-03-16 Thread Josh Berkus
On 03/16/2014 12:32 PM, Greg Stark wrote: I would consider adding something like For the problem to occur a foreign key from another table must exist and a new row must be added to that other table around the same time (possibly in the same transaction) as an update to the referenced row That

Re: [HACKERS] Providing catalog view to pg_hba.conf file - Patch submission

2014-03-16 Thread Prabakaran, Vaishnavi
From: Magnus Hagander [mailto:mag...@hagander.net] Sent: Friday, 14 March 2014 9:33 PM To: Prabakaran, Vaishnavi Cc: PostgreSQL-development Subject: Re: [HACKERS] Providing catalog view to pg_hba.conf file - Patch submission On Fri, Mar 14, 2014 at 6:30 AM, Prabakaran, Vaishnavi

Re: [HACKERS] [RFC] What should we do for reliable WAL archiving?

2014-03-16 Thread Amit Kapila
On Sun, Mar 16, 2014 at 7:53 PM, MauMau maumau...@gmail.com wrote: From: Amit Kapila amit.kapil...@gmail.com How about using pg_receivexlog for archiving purpose? pg_receivexlog is good in that it does fsync(). But it seems difficult to use correctly, and I'm not sure if I can catch all

[HACKERS] First draft of update announcement

2014-03-16 Thread Josh Berkus
... attached. Please correct! -- Josh Berkus PostgreSQL Experts Inc. http://pgexperts.com The PostgreSQL Global Development Group has released a critical update to version 9.3 of the database system. This minor release, PostgreSQL 9.3.4, fixes a data corruption issue with replication and crash

Re: [HACKERS] First draft of update announcement

2014-03-16 Thread Ian Lawrence Barwick
2014-03-17 13:24 GMT+09:00 Josh Berkus j...@agliodbs.com: ... attached. Please correct! A couple of drive-by corrections: each of their standy databases standy - standby Prevent erroneous operator push-down in pgsql_fdw pgsql_fdw - postgres_fdw Regards Ian Barwick -- Sent via

[HACKERS] Fix typo in nbtree.h introduced by efada2b

2014-03-16 Thread Michael Paquier
Hi, I found a small typo in nbtree.h, introduced by commit efada2b. Patch is attached. Regards, -- Michael diff --git a/src/include/access/nbtree.h b/src/include/access/nbtree.h index 7b26f98..779a422 100644 --- a/src/include/access/nbtree.h +++ b/src/include/access/nbtree.h @@ -395,7 +395,7 @@

Re: [HACKERS] gaussian distribution pgbench

2014-03-16 Thread KONDO Mitsumasa
(2014/03/15 15:53), Fabien COELHO wrote: Hello Heikki, A couple of comments: * There should be an explicit \setrandom ... uniform option too, even though you get that implicitly if you don't specify the distribution Indeed. I agree. I suggested it, but it got lost. * What exactly does