On Sat, Mar 11, 2017 at 7:26 PM, Nikhil Sontakke
wrote:
> Hi David and Michael,
>> It would be great to get this thread closed out after 14 months and many
>> commits.
>
> PFA, latest patch which addresses Michael's comments.
Thanks for the new version. Let's head toward a final patch.
>> +
2017-03-13 7:24 GMT+01:00 Nico Williams :
> On Thu, Mar 09, 2017 at 07:12:07PM +0100, Sven R. Kunze wrote:
> > From my day-to-day work I can tell, the date(time) type is the only
> missing
> > piece of JSON to make it perfect for business applications (besides,
> maybe,
> > a "currency" type).
>
>
On Thu, Mar 09, 2017 at 07:12:07PM +0100, Sven R. Kunze wrote:
> From my day-to-day work I can tell, the date(time) type is the only missing
> piece of JSON to make it perfect for business applications (besides, maybe,
> a "currency" type).
And a binary type. And a chunked-string type (to avoid h
2016-02-28 11:53 GMT+02:00 Simon Riggs :
> We have various proposals for fixing this, so on consideration here's what
> I think we should do...
>
> 1. Ignore my first patch to always set an xid. Andres thought that this
> may break something else could be true, so is not worth the risk.
>
> 2. App
On Thu, Mar 09, 2017 at 12:58:55PM -0500, Robert Haas wrote:
> On Thu, Mar 9, 2017 at 12:48 PM, Sven R. Kunze wrote:
> > On 08.03.2017 20:48, Peter van Hardenberg wrote:
> >>
> >> Small point of order: YAML is not strictly a super-set of JSON.
> >
> > I haven't read the whole standard, but from wh
2017-03-12 22:26 GMT+01:00 Pavel Stehule :
>
>
> 2017-03-12 21:57 GMT+01:00 Noah Misch :
>
>> On Sun, Mar 12, 2017 at 08:36:58PM +0100, Pavel Stehule wrote:
>> > 2017-03-12 0:56 GMT+01:00 Noah Misch :
>> > > On Mon, Feb 20, 2017 at 07:48:18PM +0100, Pavel Stehule wrote:
>> > > > There are possible
On Tue, Mar 07, 2017 at 10:43:16PM +0100, Sven R. Kunze wrote:
> about the datetime issue: as far as I know, JSON does not define a
> serialization format for dates and timestamps.
Use strings in ISO 8601 format, with or without fractional seconds, and
maybe with 5-digit years.
> On the other han
Hello,
Thank you testing. I just wanted to confirm few things since I do not have
linux32 setup yet.
On Fri, Mar 10, 2017 at 1:09 PM, tushar
wrote:
> On 03/10/2017 11:23 AM, Beena Emerson wrote:
>
>
>> Thank you for your reviews Kuntal, Jim, Ashutosh
>
> Attached in an updated 02 patch which:
>
Hi,
I had a look into this patch and would like to share some of my review
comments that requires author's attention.
1) The comment for page_checksum() needs to be corrected. It seems
like it has been copied from page_header and not edited it further.
/*
* page_header
*
* Allows inspection o
Hi,
>
> I've assigned to review this patch.
> At first, I'd like to notice that I like idea and general design.
> Secondly, patch set don't apply cleanly to master. Please, rebase it.
Thanks for showing your interest towards this patch. I would like to
inform that this patch has got dependency
Hi Jeevan,
On 2017/03/13 14:31, Jeevan Ladhe wrote:
> Hi Amit,
>
> I was able to reproduce the crash, and with the attached patch the crash
> goes
> away. Also, "make check-world" passes clean.
>
> Patch looks good to me.
Thanks for the review.
> However, In following comment in your test:
>
Hi Amit,
I was able to reproduce the crash, and with the attached patch the crash
goes
away. Also, "make check-world" passes clean.
Patch looks good to me. However, In following comment in your test:
-- check routing error through a list partitioned table when they key is
null
I think you want
On Thu, Mar 9, 2017 at 10:54 AM, Rushabh Lathia
wrote:
> Thanks Rajkumar for performing tests on this patch.
>
> Yes, I also noticed similar results in my testing. Additionally sometime I
> also
> noticed ReadSLRUPage event on my system.
>
> I also run the reindex database command and I notices be
Sure, understood.
Regards,
Neha
Neha Khatri writes:
> Then, should it be alright to remove the doubt itself?
It's a perfectly legitimate comment describing a potential optimization.
There are lots of other similar comments that might or might not ever get
addressed.
regards, tom lane
--
Sent via pgsq
On Mon, Mar 13, 2017 at 3:52 PM, Tom Lane wrote:
> David Rowley writes:
> > On 13 March 2017 at 14:22, Neha Khatri wrote:
> >> This copyObject still exits in the current code. So I was wondering if
> the
> >> comment question still holds good and why the question there in first
> place.
> >> To
>
>
> I think it will, because Append itself has been made async-capable by one
> of the patches and UNION ALL uses Append. But as mentioned above, only
> the postgres_fdw foreign tables will be able to utilize this for now.
>
>
Ok, I'll re-run my test from a few weeks back and see if anything has
David Rowley writes:
> On 13 March 2017 at 14:22, Neha Khatri wrote:
>> This copyObject still exits in the current code. So I was wondering if the
>> comment question still holds good and why the question there in first place.
>> To make a new Var object, copyObject seem to be the right choice, t
Andres Freund writes:
> On 2017-03-11 22:14:07 -0500, Tom Lane wrote:
>> This looks generally sane to me, although I'm not very happy about folding
>> the "$(MKDIR_P) output_iso" call into pg_isolation_regress_check --- that
>> seems weird and unlike the way it's done for the regular regression te
On Wed, Mar 8, 2017 at 5:45 AM, Peter Eisentraut
wrote:
> On 1/30/17 20:34, Michael Paquier wrote:
>> Both things are fixed in the new version attached. I have added as
>> well this patch to the next commit fest:
>> https://commitfest.postgresql.org/13/977/
>
> I'm not clear now what this patch is
On 03/13/2017 03:11 AM, Andreas Karlsson wrote:
I also fixed the the code to properly support triggers.
And by "support triggers" I actually meant fixing the support for moving
the foreign keys to the new index.
Andreas
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
On 03/02/2017 03:10 AM, Michael Paquier wrote:
On Wed, Mar 1, 2017 at 2:21 AM, Andreas Karlsson wrote:
+/*
+ * Copy contraint flags for old index. This is safe because the old index
+ * guaranteed uniquness.
+ */
+newIndexForm->indisprimary = oldIndexForm->indisprimary;
+
On Fri, Mar 10, 2017 at 1:49 AM, Ivan Kartyshov
wrote:
> Here I attached rebased patch waitlsn_10dev_v3 (core feature)
> I will leave the choice of implementation (core/contrib) to the discretion
> of the community.
>
> Will be glad to hear your suggestion about syntax, code and patch.
Hi Ivan,
> Hello,
>
> On Wed, March 1, 2017 7:21 pm, Kouhei Kaigai wrote:
> >> I've looked at the patch, and as I'm not that familiar with the
> >> pg-sourcecode, customs and so on, this isn't a review, more like food
> >> for thought and all should be taken with a grain of salt. :)
> >>
> >> So here are a
On 2017/03/11 8:19, Corey Huinker wrote:
>
> On Thu, Feb 23, 2017 at 6:59 AM, Kyotaro HORIGUCHI
> mailto:horiguchi.kyot...@lab.ntt.co.jp>>
> wrote:
>
> 9e43e87
>
>
> Patch fails on current master, but correctly applies to 9e43e87. Thanks
> for including the commit id.
>
> Regression tests
On Mon, Mar 13, 2017 at 12:48 AM, Joe Conway wrote:
> On 03/11/2017 11:07 PM, Michael Paquier wrote:
>> Having a RLS on pg_authid to allow a user to look at its own password
>> type is an idea.
>
> Given that that is not likely at this stage of the dev cycle, what about
> a special purpose SQL fun
On 11 March 2017 at 00:33, Petr Jelinek wrote:
> On 09/03/17 18:48, Peter Eisentraut wrote:
>> On 3/6/17 05:27, Petr Jelinek wrote:
>>> And lastly I changed the automagic around exporting, not exporting and
>>> using the snapshot produced by CREATE_REPLICATION_SLOT into explicit
>>> parameter for
0;115;0c
On 2017-03-11 22:14:07 -0500, Tom Lane wrote:
> Andres Freund writes:
> > On 2017-03-11 11:48:31 -0800, Andres Freund wrote:
> >> I think that'd be a good plan. We probably should also keep --outputdir
> >> seperate (which test_decoding/Makefile does, but
> >> pg_isolation_regress_check
On Mon, Mar 13, 2017 at 9:15 AM, Robert Haas wrote:
> On Fri, Mar 10, 2017 at 5:43 PM, Michael Paquier
> wrote:
>> On Sat, Mar 11, 2017 at 2:53 AM, Jeff Janes wrote:
>>> Should the \password tool in psql inspect password_encryption and act on it
>>> being 'scram'?
>>
>> Not sure if it is wise to
On 11 March 2017 at 14:32, Craig Ringer wrote:
> I'll extract this part of the patch so it can be looked at separately,
> it'll be clearer that way.
Apparently I thought that last time too since I already posted it
split up. Ahem. Working on too many different things at once.
Last-posted patche
On 13 March 2017 at 10:56, Craig Ringer wrote:
> On 7 March 2017 at 21:08, Simon Riggs wrote:
>
>> Patch 4 committed. Few others need rebase.
>
> Since this patch series and initial data copy for logical replication
> both add a facility for suppressing initial snapshot export on a
> logical slot
On Sun, Mar 12, 2017 at 3:05 PM, Peter Geoghegan wrote:
> There is still an open item here, though: The leader-as-worker
> Tuplesortstate, a special case, can still leak files.
I phrased this badly. What I mean is that there can be instances where
temp files are left on disk following a failure s
(Redirecting to Hackers, since Novice is not the correct place for this
question)
On 13 March 2017 at 14:22, Neha Khatri wrote:
> Hi,
>
> I was debugging that when does the function _copyVar get invoked, and the
> first hit for that was in the add_vars_to_targetlist. There I happened to
> see th
On 13 March 2017 at 08:54, Vaishnavi Prabakaran
wrote:
> Before going with this fix, I would like you to consider the option of
> asking batch processing users(via documentation) to set single-row mode
> before calling PQgetResult().
> Either way we need to fix the documentation part, letting use
On 2 March 2017 at 04:40, Alvaro Herrera wrote:
> Alvaro Herrera wrote:
>
>> I have added this patch to the commitfest, which I've been intending to
>> get in for a long time. I'll be submitting an updated patch, if needed.
>
> Here is Emre's patch rebased to current sources.
Looking over this n
On Sat, Mar 11, 2017 at 12:52 AM, Daniel Verite
wrote:
> Hi,
>
> I notice that PQsetSingleRowMode() doesn't work when getting batch results.
>
> The function is documented as:
> " int PQsetSingleRowMode(PGconn *conn);
>
> This function can only be called immediately after PQsendQuery or one
>
On Fri, Mar 10, 2017 at 5:43 PM, Michael Paquier
wrote:
> On Sat, Mar 11, 2017 at 2:53 AM, Jeff Janes wrote:
>> Should the \password tool in psql inspect password_encryption and act on it
>> being 'scram'?
>
> Not sure if it is wise to change the default fot this release.
Seems like an odd way t
On Fri, Mar 10, 2017 at 2:17 PM, Peter Eisentraut
wrote:
> On 3/2/17 21:40, Robert Haas wrote:
>> On the point mentioned above, I
>> don't think adding a partition should move tuples, necessarily; seems
>> like it would be good enough - maybe better - for it to fail if there
>> are any that would
On Tue, Jan 17, 2017 at 9:36 PM, Kyotaro HORIGUCHI <
horiguchi.kyot...@lab.ntt.co.jp> wrote:
> Hello. I added pgsql-hackers.
>
> This occurs also on git master and back to 9.4.
>
> At Fri, 13 Jan 2017 08:47:06 -0600, Jonathon Nelson
> wrote in gmail.com>
> > On Mon, Nov 28, 2016 at 1:39 PM, Jona
On Thu, Feb 16, 2017 at 8:45 AM, Peter Geoghegan wrote:
>> I do not think there should be any reason why we can't get the
>> resource accounting exactly correct here. If a single backend manages
>> to remove every temporary file that it creates exactly once (and
>> that's currently true, modulo s
2017-03-12 21:57 GMT+01:00 Noah Misch :
> On Sun, Mar 12, 2017 at 08:36:58PM +0100, Pavel Stehule wrote:
> > 2017-03-12 0:56 GMT+01:00 Noah Misch :
> > > On Mon, Feb 20, 2017 at 07:48:18PM +0100, Pavel Stehule wrote:
> > > > There are possible two fixes
> > > >
> > > > a) clean decl on input - the
On Fri, Mar 10, 2017 at 11:48 AM, Kevin Grittner wrote:
> On Tue, Mar 7, 2017 at 6:28 PM, Kevin Grittner wrote:
>
>> New patch attached.
>
> And bit-rotted less than 24 hours later by fcec6caa.
>
> New patch attached just to fix bit-rot.
>
> That conflicting patch might be a candidate to merge in
On Sun, Mar 12, 2017 at 08:36:58PM +0100, Pavel Stehule wrote:
> 2017-03-12 0:56 GMT+01:00 Noah Misch :
> > On Mon, Feb 20, 2017 at 07:48:18PM +0100, Pavel Stehule wrote:
> > > There are possible two fixes
> > >
> > > a) clean decl on input - the encoding info can be removed from decl part
> > >
>
Greetings,
* Stephen Frost (sfr...@snowman.net) wrote:
> * Stephen Frost (sfr...@snowman.net) wrote:
> > * Haribabu Kommi (kommi.harib...@gmail.com) wrote:
> > > On Wed, Feb 1, 2017 at 6:27 AM, Vitaly Burovoy
> > > wrote:
> > > > The new status of this patch is: Ready for Committer
> > >
> > >
Hi
When I tested XMLTABLE function I found a bug of XPATH function -
xpath_internal
There xmltype is not correctly encoded to xmlChar due possible invalid
encoding info in header. It is possible when XML was loaded with recv
function and has not UTF8 encoding.
The functions based on xml_parse fu
Greetings,
* Stephen Frost (sfr...@snowman.net) wrote:
> * Haribabu Kommi (kommi.harib...@gmail.com) wrote:
> > On Wed, Feb 1, 2017 at 6:27 AM, Vitaly Burovoy
> > wrote:
> > > The new status of this patch is: Ready for Committer
> >
> > Thanks for the review.
>
> I've started taking a look at
2017-03-12 0:56 GMT+01:00 Noah Misch :
> On Mon, Feb 20, 2017 at 07:48:18PM +0100, Pavel Stehule wrote:
> > Today I played with xml_recv function and with xml processing functions.
> >
> > xml_recv function ensures correct encoding from document encoding to
> server
> > encoding. But the decl sect
"David G. Johnston" writes:
> There are only four commands and a finite number of usage permutations.
> Enumerating and figuring out the proper behavior for each should be done.
> Thus - If the expressions are bad they are considered false but the block
> is created
> If the flow-control comman
2017-03-10 9:43 GMT+01:00 Jan Michálek :
>
>
> 2017-03-09 20:10 GMT+01:00 Peter Eisentraut com>:
>
>> This is looking pretty neat. I played around with it a bit. There are
>> a couple of edge cases that you need to address, I think.
>>
>
> Thanks, original code is very synoptical and and well p
On Sun, Mar 12, 2017 at 10:24 AM, Tom Lane wrote:
>
> One point here is that we need to distinguish problems in the expression,
> which could arise from changing variable values, from some other types of
> mistakes like \elif with no preceding \if. When you see something like
> that you pretty m
>
>
> (1) document that \if-related commands MUST be on their own
> line (i.e. like cpp #if directives?).
>
I have no opinion on whether \if-related comments must be on their own
line, though I coded as if that were the case.
I want to point out that the goal down the road is to allow rudimen
Corey Huinker writes:
> Reading this, I started to wonder "so how did I get that impression?" and I
> found this from Feb 9:
> IMO, an erroneous backslash command should have no effect, period.
> "It failed but we'll treat it as if it were valid" is a rathole
> I don't want to descend into. It's
On Sun, Mar 12, 2017 at 1:52 AM, David G. Johnston <
david.g.johns...@gmail.com> wrote:
>
> Oddly, Corey was using you as support for this position...though without
an actual quote:
>
> """
Reading this, I started to wonder "so how did I get that impression?" and I
found this from Feb 9:
IMO, an
On 03/11/2017 11:07 PM, Michael Paquier wrote:
> Having a RLS on pg_authid to allow a user to look at its own password
> type is an idea.
Given that that is not likely at this stage of the dev cycle, what about
a special purpose SQL function that returns the password type for the
current user? Or
I find, there is problem in tab indent in rst, it looks that lines should
be aligned to left in some cases.
2017-03-10 9:43 GMT+01:00 Jan Michálek :
>
>
> 2017-03-09 20:10 GMT+01:00 Peter Eisentraut com>:
>
>> This is looking pretty neat. I played around with it a bit. There are
>> a couple of
Moin,
On Sat, March 11, 2017 11:29 pm, Robert Haas wrote:
> On Fri, Mar 10, 2017 at 6:01 AM, Tels
> wrote:
>> Just a question for me to understand the implementation details vs. the
>> strategy:
>>
>> Have you considered how the scheduling decision might impact performance
>> due to "inter-plan p
Thanks for your information. Now I know the pg_rewind tool.
But why PG does not recover the diverge automatically?
There exists two options at least, analogy to what "git merge" does:
a) the old master find out and rewind itself to the common base of the
new master in the WAL history before app
On Sun, Mar 12, 2017 at 5:24 PM, Jinhua Luo wrote:
> I think this diverge scenario is common, because it's likely the
> master would crash due to some hardware issue (e.g. power off) which
> would cause some committed transaction has not yet synced to slave,
> while the slave would be promoted to
Hi,
I make a test to see how postgresql handle replication diverge problem:
a) setup two pg cluster A and B
b) run A as master, B as salve, using streaming replication
c) insert some data into table foobar on A, shutdown the network
between A and B at the meantime, which ends up some data would b
Hello Tom,
* Daniel Verite previously pointed out the desirability of disabling
variable expansion while skipping script. That doesn't seem to be here,
ISTM that it is still there, but for \elif conditions which are currently
always checked.
fabien=# \if false
fabien@# \echo `echo B
60 matches
Mail list logo
