Re: [HACKERS] GIN improvements part 1: additional information

2014-01-21 Thread Alexander Korotkov
it already). Is it right? -- With best regards, Alexander Korotkov.

Re: [HACKERS] PoC: Partial sort

2014-01-20 Thread Alexander Korotkov
this work in combination with randomAccess ? As far as I can tell randomAccess was broken by the partial sort patch even before my change since it would not iterate over multiple tuplesorts anyway. Alexander: Is this true or am I missing something? Yes, I decided that Sort node shouldn't

Re: [HACKERS] GIN improvements part 1: additional information

2014-01-17 Thread Alexander Korotkov
On Wed, Jan 15, 2014 at 10:47 AM, Alexander Korotkov aekorot...@gmail.comwrote: On Wed, Jan 15, 2014 at 5:17 AM, Tomas Vondra t...@fuzzy.cz wrote: On 14.1.2014 00:38, Tomas Vondra wrote: On 13.1.2014 18:07, Alexander Korotkov wrote: On Sat, Jan 11, 2014 at 6:15 AM, Tomas Vondra t

Re: [HACKERS] GIN improvements part 1: additional information

2014-01-17 Thread Alexander Korotkov
On Fri, Jan 17, 2014 at 10:38 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 01/17/2014 01:05 PM, Alexander Korotkov wrote: Seems to be fixed in the attached version of patch. Another improvement in this version: only left-most segments and further are re-encoded. Left part

Re: [HACKERS] trgm regex index peculiarity

2014-01-15 Thread Alexander Korotkov
On Fri, Jun 21, 2013 at 5:39 PM, Erik Rijkers e...@xs4all.nl wrote: On Fri, June 21, 2013 15:11, Alexander Korotkov wrote: On Fri, Jun 21, 2013 at 2:40 PM, Erik Rijkers e...@xs4all.nl wrote: On Fri, June 21, 2013 05:25, Tom Lane wrote: Erik Rijkers e...@xs4all.nl writes: In a 112 MB

Re: [HACKERS] GIN improvements part 1: additional information

2014-01-14 Thread Alexander Korotkov
On Tue, Jan 14, 2014 at 12:34 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 01/13/2014 07:07 PM, Alexander Korotkov wrote: I've fixed this bug and many other bug. Now patch passes test suite that I've used earlier. The results are so: Operations time: event

Re: [HACKERS] GIN improvements part2: fast scan

2014-01-14 Thread Alexander Korotkov
On Thu, Nov 21, 2013 at 12:14 AM, Alexander Korotkov aekorot...@gmail.comwrote: On Wed, Nov 20, 2013 at 3:06 AM, Alexander Korotkov aekorot...@gmail.comwrote: On Fri, Nov 15, 2013 at 11:19 AM, Alexander Korotkov aekorot...@gmail.com wrote: On Fri, Nov 15, 2013 at 12:34 AM, Heikki

Re: [HACKERS] PoC: Partial sort

2014-01-14 Thread Alexander Korotkov
node. So, this problem is not directly related to partial sort. -- With best regards, Alexander Korotkov.

Re: [HACKERS] PoC: Partial sort

2014-01-14 Thread Alexander Korotkov
On Tue, Jan 14, 2014 at 11:16 PM, Marti Raudsepp ma...@juffo.org wrote: On Tue, Jan 14, 2014 at 5:49 PM, Alexander Korotkov aekorot...@gmail.com wrote: I implemented a new enable_partialsort GUC to make it easier to turn on/off I though about such option. Generally not because of testing

Re: [HACKERS] GIN improvements part 1: additional information

2014-01-14 Thread Alexander Korotkov
On Wed, Jan 15, 2014 at 5:17 AM, Tomas Vondra t...@fuzzy.cz wrote: On 14.1.2014 00:38, Tomas Vondra wrote: On 13.1.2014 18:07, Alexander Korotkov wrote: On Sat, Jan 11, 2014 at 6:15 AM, Tomas Vondra t...@fuzzy.cz mailto:t...@fuzzy.cz wrote: On 8.1.2014 22:58, Alexander Korotkov

Re: [HACKERS] GIN improvements part2: fast scan

2014-01-14 Thread Alexander Korotkov
On Tue, Jan 14, 2014 at 11:07 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 01/14/2014 05:35 PM, Alexander Korotkov wrote: On Thu, Nov 21, 2013 at 12:14 AM, Alexander Korotkov aekorot...@gmail.comwrote: Revised version of patch is attached. Changes are so: 1) Support

Re: [HACKERS] GIN improvements part 1: additional information

2014-01-13 Thread Alexander Korotkov
On Sat, Jan 11, 2014 at 6:15 AM, Tomas Vondra t...@fuzzy.cz wrote: On 8.1.2014 22:58, Alexander Korotkov wrote: Thanks for reporting. Fixed version is attached. I've tried to rerun the 'archie' benchmark with the current patch, and once again I got PANIC: could not split GIN page

[HACKERS] KNN-GiST with recheck

2014-01-13 Thread Alexander Korotkov
) -- With best regards, Alexander Korotkov. knn-gist-recheck-1.patch.gz Description: GNU Zip compressed data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] PoC: Partial sort

2014-01-13 Thread Alexander Korotkov
and regression tests fix. -- With best regards, Alexander Korotkov. partial-sort-5.patch.gz Description: GNU Zip compressed data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] GIN improvements part 1: additional information

2014-01-08 Thread Alexander Korotkov
: explain (buffers, analyze) select count(*) from test where a like '%tio%'; ERROR: lock 9447 is not held Thanks for reporting. Fixed version is attached. -- With best regards, Alexander Korotkov. gin-packed-postinglists-varbyte3.patch.gz Description: GNU Zip compressed data -- Sent via

Re: [HACKERS] PoC: Partial sort

2013-12-22 Thread Alexander Korotkov
On Sun, Dec 22, 2013 at 8:12 PM, Martijn van Oosterhout klep...@svana.orgwrote: On Sun, Dec 22, 2013 at 07:38:05PM +0400, Alexander Korotkov wrote: Hi! Next revision. It expected to do better work with optimizer. It introduces presorted_keys argument of cost_sort function which

Re: [HACKERS] PoC: Partial sort

2013-12-22 Thread Alexander Korotkov
On Sat, Dec 14, 2013 at 6:30 PM, Jeremy Harris j...@wizmail.org wrote: On 14/12/13 12:54, Andres Freund wrote: On 2013-12-14 13:59:02 +0400, Alexander Korotkov wrote: Currently when we need to get ordered result from table we have to choose one of two approaches: get results from index

Re: [HACKERS] GIN improvements part 1: additional information

2013-12-20 Thread Alexander Korotkov
. -- With best regards, Alexander Korotkov.

Re: [HACKERS] GIN improvements part 1: additional information

2013-12-20 Thread Alexander Korotkov
On Fri, Dec 20, 2013 at 11:36 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 12/19/2013 03:33 PM, Heikki Linnakangas wrote: On 12/17/2013 12:49 AM, Heikki Linnakangas wrote: On 12/17/2013 12:22 AM, Alexander Korotkov wrote: On Mon, Dec 16, 2013 at 3:30 PM, Heikki Linnakangas

Re: [HACKERS] GIN improvements part 1: additional information

2013-12-18 Thread Alexander Korotkov
On Tue, Dec 17, 2013 at 2:49 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 12/17/2013 12:22 AM, Alexander Korotkov wrote: On Mon, Dec 16, 2013 at 3:30 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 12/12/2013 06:44 PM, Alexander Korotkov wrote: When values

Re: [HACKERS] hstore ng index for @ ?

2013-12-18 Thread Alexander Korotkov
can't effectively use GIN for such kind of queries. I believe it's not implemented because wasn't requested yet. Could you share your use-case? -- With best regards, Alexander Korotkov.

Re: [HACKERS] PoC: Partial sort

2013-12-18 Thread Alexander Korotkov
On Sat, Dec 14, 2013 at 6:39 PM, Martijn van Oosterhout klep...@svana.orgwrote: On Sat, Dec 14, 2013 at 06:21:18PM +0400, Alexander Korotkov wrote: Is that actually all that beneficial when sorting with a bog standard qsort() since that doesn't generally benefit from data being pre-sorted

Re: [HACKERS] PoC: Partial sort

2013-12-18 Thread Alexander Korotkov
- just pass NULL instead, that performs a bit less work. Useful notice, thanks. -- With best regards, Alexander Korotkov.

Re: [HACKERS] PoC: Partial sort

2013-12-18 Thread Alexander Korotkov
On Sat, Dec 14, 2013 at 11:47 PM, Andreas Karlsson andr...@proxel.sewrote: On 12/14/2013 10:59 AM, Alexander Korotkov wrote: This patch allows to use index for order-by if order-by clause and index has non-empty common prefix. So, index gives right ordering for first n order-by columns

Re: [HACKERS] GIN improvements part 1: additional information

2013-12-16 Thread Alexander Korotkov
On Mon, Dec 16, 2013 at 3:30 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 12/12/2013 06:44 PM, Alexander Korotkov wrote: I've thought about different algorithms little more. General problem I see is online update. We need it while it is typically not covered by researches at all

Re: [HACKERS] PoC: Partial sort

2013-12-14 Thread Alexander Korotkov
Hi! Thanks for feedback! On Sat, Dec 14, 2013 at 4:54 PM, Andres Freund and...@2ndquadrant.comwrote: Hi, Cool stuff. On 2013-12-14 13:59:02 +0400, Alexander Korotkov wrote: Currently when we need to get ordered result from table we have to choose one of two approaches: get results from

Re: [HACKERS] GIN improvements part 1: additional information

2013-12-12 Thread Alexander Korotkov
On Tue, Dec 10, 2013 at 12:26 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 12/09/2013 11:34 AM, Alexander Korotkov wrote: On Mon, Dec 9, 2013 at 1:18 PM, Heikki Linnakangas hlinnakan...@vmware.comwrote: Even if we use varbyte encoding, I wonder if it would be better to treat

Re: [HACKERS] GIN improvements part 1: additional information

2013-12-10 Thread Alexander Korotkov
On Tue, Dec 10, 2013 at 12:26 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 12/09/2013 11:34 AM, Alexander Korotkov wrote: On Mon, Dec 9, 2013 at 1:18 PM, Heikki Linnakangas hlinnakan...@vmware.comwrote: Even if we use varbyte encoding, I wonder if it would be better to treat

Re: [HACKERS] GIN improvements part 1: additional information

2013-12-09 Thread Alexander Korotkov
On Mon, Dec 9, 2013 at 1:18 PM, Heikki Linnakangas hlinnakan...@vmware.comwrote: On 12/08/2013 09:56 PM, Alexander Korotkov wrote: On Fri, Nov 29, 2013 at 11:17 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: I'll continue reviewing next week.. Got dragged into other things

Re: [HACKERS] GIN improvements part 1: additional information

2013-12-08 Thread Alexander Korotkov
On Fri, Nov 29, 2013 at 11:17 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 11/29/2013 11:41 AM, Heikki Linnakangas wrote: On 11/28/2013 09:19 AM, Alexander Korotkov wrote: On Wed, Nov 27, 2013 at 1:14 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 11/26/13 15:34

Re: [HACKERS] Problem with displaying wide tables in psql

2013-12-04 Thread Alexander Korotkov
the necessary part of the value. There is no such problems with the patch. I think the solution is to provide proposed behaviour as an option. -- With best regards, Alexander Korotkov.

Re: [HACKERS] GIN improvements part 1: additional information

2013-11-27 Thread Alexander Korotkov
On Wed, Nov 27, 2013 at 1:14 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 11/26/13 15:34, Alexander Korotkov wrote: What's your plans about GIN now? I tried to rebase packed posting lists with head. But I found that you've changed interface of placeToPage function. That's

Re: [HACKERS] GIN improvements part 1: additional information

2013-11-26 Thread Alexander Korotkov
to describe place to insert item pointer. Do you like to commit rework of handling GIN incomplete splits before? -- With best regards, Alexander Korotkov.

Re: [HACKERS] GIN improvements part 1: additional information

2013-11-26 Thread Alexander Korotkov
On Tue, Nov 26, 2013 at 5:34 PM, Alexander Korotkov aekorot...@gmail.comwrote: On Wed, Nov 20, 2013 at 9:02 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 06.11.2013 17:36, Alvaro Herrera wrote: Just for my own illumination, can someone explain this bit? + If a posting list

Re: [HACKERS] Cube extension split algorithm fix

2013-11-25 Thread Alexander Korotkov
Hi! On Wed, Sep 25, 2013 at 3:14 PM, Stas Kelvich stas.kelv...@gmail.comwrote: I've fixed split algorithm that was implemented in cube extension. I've changed it according to the original Guttman paper (old version was more simple algorithm) and also ported Alexander Korotkov's algorithm from

Re: [HACKERS] GIN improvements part2: fast scan

2013-11-20 Thread Alexander Korotkov
On Wed, Nov 20, 2013 at 3:06 AM, Alexander Korotkov aekorot...@gmail.comwrote: On Fri, Nov 15, 2013 at 11:19 AM, Alexander Korotkov aekorot...@gmail.com wrote: On Fri, Nov 15, 2013 at 12:34 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 14.11.2013 19:26, Alexander Korotkov

Re: [HACKERS] GIN improvements part2: fast scan

2013-11-19 Thread Alexander Korotkov
On Fri, Nov 15, 2013 at 11:19 AM, Alexander Korotkov aekorot...@gmail.comwrote: On Fri, Nov 15, 2013 at 12:34 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 14.11.2013 19:26, Alexander Korotkov wrote: On Sun, Jun 30, 2013 at 3:00 PM, Heikki Linnakangas hlinnakan...@vmware.com

Re: [HACKERS] GIN improvements part2: fast scan

2013-11-18 Thread Alexander Korotkov
On Fri, Nov 15, 2013 at 11:42 PM, Alexander Korotkov aekorot...@gmail.comwrote: On Fri, Nov 15, 2013 at 11:39 PM, Rod Taylor rod.tay...@gmail.com wrote: On Fri, Nov 15, 2013 at 2:26 PM, Alexander Korotkov aekorot...@gmail.com wrote: On Fri, Nov 15, 2013 at 11:18 PM, Rod Taylor rod.tay

Re: [HACKERS] GIN improvements part 1: additional information

2013-11-15 Thread Alexander Korotkov
On Fri, Nov 15, 2013 at 8:58 PM, Peter Eisentraut pete...@gmx.net wrote: On 11/14/13, 6:00 AM, Alexander Korotkov wrote: Sorry, I posted buggy version of patch. Attached version is correct. This patch crashes the hstore the pg_trgm regression tests. What exact version did you try 14 or 16

Re: [HACKERS] GIN improvements part2: fast scan

2013-11-15 Thread Alexander Korotkov
. Will be fixed soon. BTW, was index 2% smaller or 2 times smaller? If it's 2% smaller than I need to know more about your dataset :) -- With best regards, Alexander Korotkov.

Re: [HACKERS] GIN improvements part 1: additional information

2013-11-15 Thread Alexander Korotkov
On Fri, Nov 15, 2013 at 9:56 PM, Peter Eisentraut pete...@gmx.net wrote: On 11/15/13, 12:24 PM, Alexander Korotkov wrote: On Fri, Nov 15, 2013 at 8:58 PM, Peter Eisentraut pete...@gmx.net mailto:pete...@gmx.net wrote: On 11/14/13, 6:00 AM, Alexander Korotkov wrote: Sorry, I

Re: [HACKERS] GIN improvements part2: fast scan

2013-11-15 Thread Alexander Korotkov
. Is it possible to share dump? -- With best regards, Alexander Korotkov.

Re: [HACKERS] GIN improvements part2: fast scan

2013-11-15 Thread Alexander Korotkov
On Fri, Nov 15, 2013 at 11:39 PM, Rod Taylor rod.tay...@gmail.com wrote: On Fri, Nov 15, 2013 at 2:26 PM, Alexander Korotkov aekorot...@gmail.comwrote: On Fri, Nov 15, 2013 at 11:18 PM, Rod Taylor rod.tay...@gmail.comwrote: 2%. It's essentially sentence fragments from 1 to 5 words

Re: [HACKERS] GIN improvements part2: fast scan

2013-11-15 Thread Alexander Korotkov
On Sat, Nov 16, 2013 at 12:10 AM, Peter Eisentraut pete...@gmx.net wrote: On 11/14/13, 12:26 PM, Alexander Korotkov wrote: Revised version of patch is attached. This doesn't build: ginget.c: In function ‘scanPage’: ginget.c:1108:2: warning: implicit declaration of function

Re: [HACKERS] GIN improvements part 1: additional information

2013-11-14 Thread Alexander Korotkov
On Tue, Nov 5, 2013 at 9:49 PM, Heikki Linnakangas hlinnakan...@vmware.comwrote: On 04.11.2013 23:44, Alexander Korotkov wrote: On Mon, Oct 21, 2013 at 11:12 PM, Alexander Korotkov aekorot...@gmail.comwrote: Attached version of patch is debugged. I would like to note that number of bugs

Re: [HACKERS] GIN improvements part 1: additional information

2013-11-14 Thread Alexander Korotkov
On Thu, Nov 14, 2013 at 2:17 PM, Alexander Korotkov aekorot...@gmail.comwrote: On Tue, Nov 5, 2013 at 9:49 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 04.11.2013 23:44, Alexander Korotkov wrote: On Mon, Oct 21, 2013 at 11:12 PM, Alexander Korotkov aekorot...@gmail.comwrote

Re: [HACKERS] GIN improvements part2: fast scan

2013-11-14 Thread Alexander Korotkov
On Sun, Jun 30, 2013 at 3:00 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 28.06.2013 22:31, Alexander Korotkov wrote: Now, I got the point of three state consistent: we can keep only one consistent in opclasses that support new interface. exact true and exact false values

Re: [HACKERS] GIN improvements part 1: additional information

2013-11-14 Thread Alexander Korotkov
On Thu, Nov 14, 2013 at 3:00 PM, Alexander Korotkov aekorot...@gmail.comwrote: On Thu, Nov 14, 2013 at 2:17 PM, Alexander Korotkov aekorot...@gmail.comwrote: On Tue, Nov 5, 2013 at 9:49 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 04.11.2013 23:44, Alexander Korotkov wrote

Re: [HACKERS] GIN improvements part2: fast scan

2013-11-14 Thread Alexander Korotkov
dump The GIN index fails to build with a segfault. Thanks for testing. See fixed version in thread about packed posting lists. -- With best regards, Alexander Korotkov.

Re: [HACKERS] GIN improvements part2: fast scan

2013-11-14 Thread Alexander Korotkov
On Fri, Nov 15, 2013 at 12:34 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 14.11.2013 19:26, Alexander Korotkov wrote: On Sun, Jun 30, 2013 at 3:00 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 28.06.2013 22:31, Alexander Korotkov wrote: Now, I got the point

Re: [HACKERS] GIN improvements part 1: additional information

2013-11-04 Thread Alexander Korotkov
On Mon, Oct 21, 2013 at 11:12 PM, Alexander Korotkov aekorot...@gmail.comwrote: Attached version of patch is debugged. I would like to note that number of bugs was low and it wasn't very hard to debug. I've rerun tests on it. You can see that numbers are improved as the result of your

Re: [HACKERS] Cube extension point support // GSoC'13

2013-10-22 Thread Alexander Korotkov
, not compress/decompress in general. I understand that in general compress/decompress can do useful job. -- With best regards, Alexander Korotkov.

Re: [HACKERS] GIN improvements part 1: additional information

2013-10-21 Thread Alexander Korotkov
On Thu, Oct 10, 2013 at 3:57 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 09.10.2013 02:04, Tomas Vondra wrote: On 8.10.2013 21:59, Heikki Linnakangas wrote: On 08.10.2013 17:47, Alexander Korotkov wrote: Hi, Tomas! On Sun, Oct 6, 2013 at 3:58 AM, Tomas Vondrat...@fuzzy.cz

Re: [HACKERS] Cube extension point support // GSoC'13

2013-10-21 Thread Alexander Korotkov
On Mon, Oct 21, 2013 at 11:06 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 11.10.2013 17:39, Alexander Korotkov wrote: On Fri, Oct 11, 2013 at 5:56 PM, Heikki Linnakangashlinnakangas@** vmware.com hlinnakan...@vmware.com wrote: 2. I didn't understand this change

Re: [HACKERS] GIN improvements part 1: additional information

2013-10-12 Thread Alexander Korotkov
On Sat, Oct 12, 2013 at 1:55 AM, Tomas Vondra t...@fuzzy.cz wrote: On 10.10.2013 13:57, Heikki Linnakangas wrote: On 09.10.2013 02:04, Tomas Vondra wrote: On 8.10.2013 21:59, Heikki Linnakangas wrote: On 08.10.2013 17:47, Alexander Korotkov wrote: Hi, Tomas! On Sun, Oct 6, 2013 at 3

Re: [HACKERS] Cube extension point support // GSoC'13

2013-10-11 Thread Alexander Korotkov
related code. For example, in contrib/intarray/_int.h #define SIGLENINT 63 /* 122 = key will *toast*, so very slow!!! */ Any ideas? -- With best regards, Alexander Korotkov.

Re: [HACKERS] GIN improvements part 1: additional information

2013-10-08 Thread Alexander Korotkov
: PANIC: not enough space in leaf page! Thanks for testing. Heikki's version of patch don't works for me too on even much more simplier examples. I can try to get it working if he answer my question about GinDataLeafPageGetPostingList* macros. -- With best regards, Alexander Korotkov.

Re: [HACKERS] GIN improvements part 1: additional information

2013-10-04 Thread Alexander Korotkov
. In GinDataLeafPageGetPostingList* you use sizeof(ItemPointerData) without MAXALIGN. Is it an error or you especially use 2 extra bytes on leaf page? -- With best regards, Alexander Korotkov.

Re: [HACKERS] GIN improvements part 1: additional information

2013-10-03 Thread Alexander Korotkov
almost whole index. Is it much better than just reindex? 4) Fork GIN2, leave GIN as is. It would lead to much of duplicated code. Any other options? -- With best regards, Alexander Korotkov.

Re: [HACKERS] GIN improvements part 1: additional information

2013-10-03 Thread Alexander Korotkov
On Fri, Oct 4, 2013 at 12:41 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 03.10.2013 23:37, Alexander Korotkov wrote: 2) Insert kluges into GIN to support both old and new formats. So, kluges are kluges :) I don't see elegant way to do it for now, because formats are very

Re: [HACKERS] GIN improvements part 1: additional information

2013-10-03 Thread Alexander Korotkov
On Fri, Oct 4, 2013 at 12:37 AM, Alexander Korotkov aekorot...@gmail.comwrote: On Thu, Oct 3, 2013 at 10:48 PM, Robert Haas robertmh...@gmail.comwrote: On Thu, Oct 3, 2013 at 2:43 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: It seems we've all but decided that we'll require

Re: [HACKERS] GIN improvements part 1: additional information

2013-09-26 Thread Alexander Korotkov
On Wed, Sep 25, 2013 at 5:22 PM, Peter Eisentraut pete...@gmx.net wrote: On 9/23/13 5:36 PM, Alexander Korotkov wrote: In the attached version of patch double finding of ItemPointer during insert is avoided. Overhead becomes lower as expected. Fails cpluspluscheck: ./src/include/access

Re: [HACKERS] GIN improvements part 1: additional information

2013-09-23 Thread Alexander Korotkov
On Mon, Sep 23, 2013 at 12:47 AM, Alexander Korotkov aekorot...@gmail.comwrote: It's probably an option to select 64 entries instead of 32. There is still some regression in update speed. However, there is also room for improvement patch. It searches item index entries 2 times on insert

Re: [HACKERS] Fix picksplit with nan values

2013-09-18 Thread Alexander Korotkov
On Tue, Sep 17, 2013 at 5:04 PM, Alexander Korotkov aekorot...@gmail.comwrote: On Mon, Sep 16, 2013 at 4:13 PM, Andrew Gierth and...@tao11.riddles.org.uk wrote: Alexander == Alexander Korotkov aekorot...@gmail.com writes: Alexander 2) NaN coordinates should be processed in GiST index

Re: [HACKERS] Fix picksplit with nan values

2013-09-17 Thread Alexander Korotkov
On Mon, Sep 16, 2013 at 4:13 PM, Andrew Gierth and...@tao11.riddles.org.ukwrote: Alexander == Alexander Korotkov aekorot...@gmail.com writes: Alexander 2) NaN coordinates should be processed in GiST index scan Alexander like in sequential scan. postgres=# select * from pts order

Re: [HACKERS] GIN improvements part 1: additional information

2013-09-16 Thread Alexander Korotkov
On Mon, Sep 16, 2013 at 11:43 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 15.09.2013 12:14, Alexander Korotkov wrote: On Sat, Jun 29, 2013 at 12:56 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: There's a few open questions: 1. How are we going to handle pg_upgrade

Re: [HACKERS] GIN improvements part 1: additional information

2013-09-15 Thread Alexander Korotkov
is fixed in attached version of patch by introducing incremental updating of that index. Benchmarks will be posted later today. -- With best regards, Alexander Korotkov. gin-packed-postinglists-3.patch.gz Description: GNU Zip compressed data -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Fix picksplit with nan values

2013-09-08 Thread Alexander Korotkov
On Sat, Sep 7, 2013 at 1:47 AM, Tom Lane t...@sss.pgh.pa.us wrote: Alexander Korotkov aekorot...@gmail.com writes: PostGIS spotted that picksplit algorithm freezes in infinite loop when dealing with nan values. I discovered same bug is present in core opclasses. Attached patch fixes

[HACKERS] Fix picksplit with nan values

2013-09-06 Thread Alexander Korotkov
of float8_cmp_internal rather than exposing it from float.c, because it let compiler inline this function. -- With best regards, Alexander Korotkov. picksplit-nan-fix-1.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] [v9.4] row level security

2013-08-29 Thread Alexander Korotkov
a room for timing attack, but it doesn't seem to be feasible in practice to apply. -- With best regards, Alexander Korotkov.

Re: [HACKERS] CAST Within EXCLUSION constraint

2013-08-21 Thread Alexander Korotkov
source NOT NULL, within tstzrange NOT NULL, EXCLUDE USING gist ((source::oid) WITH =, within WITH ) ); Probably, I'm missing something and casting enum to oid is somehow unsafe? -- With best regards, Alexander Korotkov.

Re: [HACKERS] Cube extension point support // GSoC'13

2013-07-17 Thread Alexander Korotkov
cubes from user input, check whether it is a point or not * All internal functions that can return cubes takes care of all cases where a cube might become a point * Added tests for checking correct point behavior Also this patch includes adapted Alexander Korotkov's patch with kNN-based ordering

Re: [HACKERS] GIN improvements part 3: ordering in index

2013-07-01 Thread Alexander Korotkov
On Sun, Jun 30, 2013 at 3:09 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 25.06.2013 21:18, Alexander Korotkov wrote: On Tue, Jun 25, 2013 at 7:31 PM, Heikki Linnakangashlinnakangas@** vmware.com hlinnakan...@vmware.com wrote: In summary: The test case you presented

Re: [HACKERS] GIN improvements part 1: additional information

2013-07-01 Thread Alexander Korotkov
for packed postinglists. 2) Extract additional info patch based on packed postinglists. 3) Rewrite interface of fast scan. Do CPU and IO benchmarking. 4) Do IO benchmarking of index ordering. Cleanup, comments and READMEs are assumed in each item. -- With best regards, Alexander Korotkov.

Re: [HACKERS] GIN improvements part 1: additional information

2013-07-01 Thread Alexander Korotkov
On Thu, Jun 27, 2013 at 6:20 PM, Antonin Houska antonin.hou...@gmail.comwrote: On 06/25/2013 12:03 AM, Alexander Korotkov wrote: New revision of patch is attached. Now it includes some docs. Hi, I was curious about the new layout of the data page, so I spent a while looking

Re: [HACKERS] GIN improvements part2: fast scan

2013-06-28 Thread Alexander Korotkov
On Tue, Jun 25, 2013 at 2:20 AM, Alexander Korotkov aekorot...@gmail.comwrote: 4. If we do go with a new function, I'd like to just call it consistent (or consistent2 or something, to keep it separate form the old consistent function), and pass it a tri-state input for each search term

Re: [HACKERS] Developer meeting photos

2013-06-27 Thread Alexander Korotkov
On Thu, Jun 27, 2013 at 4:23 PM, Robert Haas robertmh...@gmail.com wrote: On Wed, Jun 26, 2013 at 10:22 AM, Alexander Korotkov aekorot...@gmail.com wrote: at last developer meeting we missed Oleg Bartunov. So, it's not surprising that photos is also missed. I remember that somebody took

[HACKERS] Developer meeting photos

2013-06-26 Thread Alexander Korotkov
it on the website. So, it would be very nice to have a photo of developer meeting. Does anybody have it? -- With best regards, Alexander Korotkov.

Re: [HACKERS] GIN improvements part 3: ordering in index

2013-06-25 Thread Alexander Korotkov
On Tue, Jun 25, 2013 at 7:31 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 25.06.2013 01:24, Alexander Korotkov wrote: On Wed, Jun 19, 2013 at 1:21 AM, Alexander Korotkovaekorot...@gmail.com **wrote: On Mon, Jun 17, 2013 at 10:27 PM, Heikki Linnakangas hlinnakan...@vmware.com

Re: [HACKERS] BUG #7493: Postmaster messages unreadable in a Windows console

2013-06-24 Thread Alexander Law
encoding fix will be considered as important enough to be backported, then this patch should be backported too. Thanks again! Best regards, Alexander -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

Re: [HACKERS] GIN improvements part 1: additional information

2013-06-24 Thread Alexander Korotkov
On Wed, Jun 19, 2013 at 12:44 AM, Alexander Korotkov aekorot...@gmail.comwrote: On Mon, Jun 17, 2013 at 4:54 PM, Alexander Korotkov aekorot...@gmail.comwrote: On Fri, Jun 14, 2013 at 12:09 AM, Alexander Korotkov aekorot...@gmail.com wrote: Revised version of patch for additional

Re: [HACKERS] GIN improvements part2: fast scan

2013-06-24 Thread Alexander Korotkov
On Fri, Jun 21, 2013 at 11:43 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 19.06.2013 11:56, Alexander Korotkov wrote: On Wed, Jun 19, 2013 at 12:49 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 19.06.2013 11:30, Alexander Korotkov wrote: On Wed, Jun 19, 2013

Re: [HACKERS] GIN improvements part 3: ordering in index

2013-06-24 Thread Alexander Korotkov
On Wed, Jun 19, 2013 at 1:21 AM, Alexander Korotkov aekorot...@gmail.comwrote: On Mon, Jun 17, 2013 at 10:27 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 17.06.2013 15:56, Alexander Korotkov wrote: On Sat, Jun 15, 2013 at 3:02 AM, Alexander Korotkovaekorot...@gmail.com **wrote

Re: [HACKERS] trgm regex index peculiarity

2013-06-21 Thread Alexander Korotkov
. The idea is to keep trying to remove color trigrams from graph even when it fits into MAX_TRGM_SIZE, because we are intending to scan less posting lists/trees. Comments is not fixed yet, coming soon. -- With best regards, Alexander Korotkov. trgm_regex_optimize.1.patch Description: Binary data

Re: [HACKERS] GIN improvements part2: fast scan

2013-06-19 Thread Alexander Korotkov
On Wed, Jun 19, 2013 at 11:48 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 18.06.2013 23:59, Alexander Korotkov wrote: I would like to illustrate that on example. Imagine you have fulltext query rare_term frequent_term. Frequent term has large posting tree while rare term has

Re: [HACKERS] GIN improvements part2: fast scan

2013-06-19 Thread Alexander Korotkov
On Wed, Jun 19, 2013 at 12:30 PM, Alexander Korotkov aekorot...@gmail.comwrote: On Wed, Jun 19, 2013 at 11:48 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 18.06.2013 23:59, Alexander Korotkov wrote: I would like to illustrate that on example. Imagine you have fulltext query

Re: [HACKERS] GIN improvements part2: fast scan

2013-06-19 Thread Alexander Korotkov
On Wed, Jun 19, 2013 at 12:49 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 19.06.2013 11:30, Alexander Korotkov wrote: On Wed, Jun 19, 2013 at 11:48 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 18.06.2013 23:59, Alexander Korotkov wrote: I would like

Re: [HACKERS] Patch for removng unused targets

2013-06-18 Thread Alexander Korotkov
Hi Etsuro! On Tue, Jun 18, 2013 at 4:15 PM, Etsuro Fujita fujita.ets...@lab.ntt.co.jpwrote: Hi Alexander, I wrote: From: Tom Lane [mailto:t...@sss.pgh.pa.us] resjunk means that the target is not supposed to be output by the query. Since it's there at all, it's presumably

Re: [HACKERS] GIN improvements part 1: additional information

2013-06-18 Thread Alexander Korotkov
On Mon, Jun 17, 2013 at 4:54 PM, Alexander Korotkov aekorot...@gmail.comwrote: On Fri, Jun 14, 2013 at 12:09 AM, Alexander Korotkov aekorot...@gmail.com wrote: Revised version of patch for additional information storage in GIN is attached. Changes are mostly bug fixes. New version

Re: [HACKERS] GIN improvements part2: fast scan

2013-06-18 Thread Alexander Korotkov
On Mon, Jun 17, 2013 at 5:09 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 17.06.2013 15:55, Alexander Korotkov wrote: On Sat, Jun 15, 2013 at 2:55 AM, Alexander Korotkovaekorot...@gmail.com **wrote: attached patch implementing fast scan technique for GIN. This is second patch

Re: [HACKERS] GIN improvements part 3: ordering in index

2013-06-18 Thread Alexander Korotkov
On Mon, Jun 17, 2013 at 10:27 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 17.06.2013 15:56, Alexander Korotkov wrote: On Sat, Jun 15, 2013 at 3:02 AM, Alexander Korotkovaekorot...@gmail.com **wrote: This patch introduces new interface method of GIN which takes same arguments

Re: [HACKERS] GIN improvements part 1: additional information

2013-06-17 Thread Alexander Korotkov
On Fri, Jun 14, 2013 at 12:09 AM, Alexander Korotkov aekorot...@gmail.comwrote: Revised version of patch for additional information storage in GIN is attached. Changes are mostly bug fixes. New version of patch is attached with some more refactoring and bug fixes. -- With best regards

Re: [HACKERS] GIN improvements part2: fast scan

2013-06-17 Thread Alexander Korotkov
On Sat, Jun 15, 2013 at 2:55 AM, Alexander Korotkov aekorot...@gmail.comwrote: attached patch implementing fast scan technique for GIN. This is second patch of GIN improvements, see the 1st one here: http://www.postgresql.org/message-id/capphfduxv-il7aedwpw0w5fxrwgakfxijwm63_hzujacrxn

Re: [HACKERS] GIN improvements part 3: ordering in index

2013-06-17 Thread Alexander Korotkov
On Sat, Jun 15, 2013 at 3:02 AM, Alexander Korotkov aekorot...@gmail.comwrote: attached patch implementing ordering inside GIN index. This is third patch of GIN improvements, see previous two: http://www.postgresql.org/message-id/capphfduxv-il7aedwpw0w5fxrwgakfxijwm63_hzujacrxn

[HACKERS] GIN improvements part2: fast scan

2013-06-14 Thread Alexander Korotkov
) -- With best regards, Alexander Korotkov. gin_fast_scan.1.patch.gz Description: GNU Zip compressed data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] GIN improvements part 3: ordering in index

2013-06-14 Thread Alexander Korotkov
'''::tsquery) Order By: (tsvector '''statist'''::tsquery) Total runtime: 7.556 ms (5 rows) -- With best regards, Alexander Korotkov.

[HACKERS] GIN improvements part 1: additional information

2013-06-13 Thread Alexander Korotkov
information storage itself (because it don't accelerate tsearch itselt). It comes in separate thread. -- With best regards, Alexander Korotkov. ginaddinfo.4.patch.gz Description: GNU Zip compressed data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

[HACKERS] Index on regexes

2013-06-13 Thread Alexander Korotkov
: 110.870 ms (5 rows) -- With best regards, Alexander Korotkov. index_on_regexes.1.patch.gz Description: GNU Zip compressed data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Index on regexes

2013-06-13 Thread Alexander Korotkov
On Fri, Jun 14, 2013 at 1:30 AM, Erik Rijkers e...@xs4all.nl wrote: On Thu, June 13, 2013 22:19, Alexander Korotkov wrote: [index_on_regexes.1.patch.gz ] Hi, Compile of core is OK, but contrib compilation fails: -- [2013.06.13 23:23:14 idxregex] make contrib trgm_gin.c: In function

Re: [HACKERS] Behavior of a pg_trgm index for 2 (or 3) character LIKE queries

2013-05-31 Thread Alexander Korotkov
it based on pg_trgm, because of many hard-wired assumptions that trigram is fixed length and compatibility. -- With best regards, Alexander Korotkov.

<    2   3   4   5   6   7   8   9   10   11   >