Re: [HACKERS] [COMMITTERS] pgsql: Add missing support for new node fields

2017-03-23 Thread Peter Eisentraut
Another idea here: Instead of making COPY_PARSE_PLAN_TREES a compile-time option, make it a run-time option, and make that somehow selectable while running the test suite. It would be much easier to run the test suite with an option on the command line, instead of having to manually edit a header

Re: [HACKERS] [COMMITTERS] pgsql: Add missing support for new node fields

2017-03-21 Thread Fabien COELHO
Hello Robert, IMHO, what would be a lot more useful than something that generates {read,equal,copy,out}funcs.c automatically would be something that just checks them for trivial errors of omission. Hmmm. Checking for errors is actually more complicated than generating the function: basically

Re: [HACKERS] [COMMITTERS] pgsql: Add missing support for new node fields

2017-03-21 Thread Fabien COELHO
Hello Andres, It is not done yet, but it looks that it can work in the end with limited effort. Currently it works for copy & equal. It'd have to do out/read as well imo. Sure. This part is WIP, though. Is there some interest to generate the x00kB of sources rather than edit them everytim

Re: [HACKERS] [COMMITTERS] pgsql: Add missing support for new node fields

2017-03-21 Thread Pavel Stehule
> > IMHO, what would be a lot more useful than something that generates > {read,equal,copy,out}funcs.c automatically would be something that > just checks them for trivial errors of omission. For example, if you > read a list of structure members from the appropriate header files and > cross-check

Re: [HACKERS] [COMMITTERS] pgsql: Add missing support for new node fields

2017-03-21 Thread Robert Haas
On Tue, Mar 21, 2017 at 10:56 AM, Tom Lane wrote: > Andres Freund writes: >> On 2017-03-21 07:22:57 +0100, Fabien COELHO wrote: >>> I've been annoyed by these stupid functions and forgetting to update them >>> since I run into them while trying to fix an issue in pg_stat_statement some >>> time a

Re: [HACKERS] [COMMITTERS] pgsql: Add missing support for new node fields

2017-03-21 Thread Tom Lane
Andres Freund writes: > On 2017-03-21 07:22:57 +0100, Fabien COELHO wrote: >> I've been annoyed by these stupid functions and forgetting to update them >> since I run into them while trying to fix an issue in pg_stat_statement some >> time ago. >> >> I've started to develop a perl script to gener

Re: [HACKERS] [COMMITTERS] pgsql: Add missing support for new node fields

2017-03-20 Thread Andres Freund
Hi, On 2017-03-21 07:22:57 +0100, Fabien COELHO wrote: > > Add missing support for new node fields > > > > Commit b6fb534f added two new node fields but neglected to add copy and > > comparison support for them, Mea culpa, should have checked for that. > > I've been annoyed by these stupid functio

Re: [HACKERS] [COMMITTERS] pgsql: Add missing support for new node fields

2017-03-20 Thread Fabien COELHO
Add missing support for new node fields Commit b6fb534f added two new node fields but neglected to add copy and comparison support for them, Mea culpa, should have checked for that. I've been annoyed by these stupid functions and forgetting to update them since I run into them while trying t