Re: [HACKERS] Comments to Synchronous replication patch v3

2008-11-30 Thread Fujii Masao
Hi, thanks for the comment! On Sat, Nov 29, 2008 at 1:10 AM, Tom Lane [EMAIL PROTECTED] wrote: Fujii Masao [EMAIL PROTECTED] writes: You export replication_timeout as a PGC_USERSET variable, but it is dangerous. It allows non-superusers to kill servers easily by setting it too low value.

Re: [HACKERS] Comments to Synchronous replication patch v3

2008-11-28 Thread Tom Lane
Fujii Masao [EMAIL PROTECTED] writes: You export replication_timeout as a PGC_USERSET variable, but it is dangerous. It allows non-superusers to kill servers easily by setting it too low value. Walsender dies with FATAL on timeout. Unlike other background processes, FATAL by walsender doesn't

Re: [HACKERS] Comments to Synchronous replication patch v3

2008-11-27 Thread Fujii Masao
Hello, On Tue, Nov 25, 2008 at 6:03 PM, Fujii Masao [EMAIL PROTECTED] wrote: [2] User-configurable replication_timeout is dangerous Index: backend/utils/misc/guc.c + {replication_timeout, PGC_USERSET, WAL_REPLICATION, You export replication_timeout as a PGC_USERSET variable,

Re: [HACKERS] Comments to Synchronous replication patch v3

2008-11-26 Thread David Fetter
On Tue, Nov 25, 2008 at 12:23:45PM -0300, Alvaro Herrera wrote: Fujii Masao escribió: On Tue, Nov 25, 2008 at 10:57 PM, Alvaro Herrera [EMAIL PROTECTED] wrote: Dickson S. Guedes escribió: Fujii Masao escreveu: (...) Even if we need to have the database in real, I'd like to use

Re: [HACKERS] Comments to Synchronous replication patch v3

2008-11-26 Thread Heikki Linnakangas
David Fetter wrote: It sounds to me like this should use SQL/MED connections, if it's holding auth information :) No, the SQL/MED stuff holds authentication information to authenticate to other data sources. This is about authentication of *incoming* connections. -- Heikki Linnakangas

Re: [HACKERS] Comments to Synchronous replication patch v3

2008-11-26 Thread David Fetter
On Wed, Nov 26, 2008 at 09:15:49PM +0200, Heikki Linnakangas wrote: David Fetter wrote: It sounds to me like this should use SQL/MED connections, if it's holding auth information :) No, the SQL/MED stuff holds authentication information to authenticate to other data sources. This is about

Re: [HACKERS] Comments to Synchronous replication patch v3

2008-11-25 Thread Fujii Masao
On Tue, Nov 25, 2008 at 11:42 AM, ITAGAKI Takahiro [EMAIL PROTECTED] wrote: Fujii Masao [EMAIL PROTECTED] wrote: On Fri, Nov 14, 2008 at 7:15 PM, Fujii Masao [EMAIL PROTECTED] wrote: Attached is the latest version of Synch Rep patch. Sorry for my late posting. I fixed some bugs in v1patch

Re: [HACKERS] Comments to Synchronous replication patch v3

2008-11-25 Thread Dickson S. Guedes
Fujii Masao escreveu: (...) Even if we need to have the database in real, I'd like to use another name for it. The name 'walsender' seems to be an internal module name but it should be a feature name (ex. 'replication'). Agreed. The name 'replication' is more suitable, I also think. Any

Re: [HACKERS] Comments to Synchronous replication patch v3

2008-11-25 Thread Alvaro Herrera
Dickson S. Guedes escribió: Fujii Masao escreveu: (...) Even if we need to have the database in real, I'd like to use another name for it. The name 'walsender' seems to be an internal module name but it should be a feature name (ex. 'replication'). Agreed. The name 'replication' is

Re: [HACKERS] Comments to Synchronous replication patch v3

2008-11-25 Thread Fujii Masao
On Tue, Nov 25, 2008 at 10:57 PM, Alvaro Herrera [EMAIL PROTECTED] wrote: Dickson S. Guedes escribió: Fujii Masao escreveu: (...) Even if we need to have the database in real, I'd like to use another name for it. The name 'walsender' seems to be an internal module name but it should be a

Re: [HACKERS] Comments to Synchronous replication patch v3

2008-11-25 Thread Alvaro Herrera
Fujii Masao escribió: On Tue, Nov 25, 2008 at 10:57 PM, Alvaro Herrera [EMAIL PROTECTED] wrote: Dickson S. Guedes escribió: Fujii Masao escreveu: (...) Even if we need to have the database in real, I'd like to use another name for it. The name 'walsender' seems to be an internal module

Re: [HACKERS] Comments to Synchronous replication patch v3

2008-11-25 Thread Fujii Masao
On Wed, Nov 26, 2008 at 12:23 AM, Alvaro Herrera [EMAIL PROTECTED] wrote: Fujii Masao escribió: On Tue, Nov 25, 2008 at 10:57 PM, Alvaro Herrera [EMAIL PROTECTED] wrote: Dickson S. Guedes escribió: Fujii Masao escreveu: (...) Even if we need to have the database in real, I'd like to use

Re: [HACKERS] Comments to Synchronous replication patch v3

2008-11-25 Thread Heikki Linnakangas
Alvaro Herrera wrote: Fujii Masao escribió: On Tue, Nov 25, 2008 at 10:57 PM, Alvaro Herrera [EMAIL PROTECTED] wrote: Dickson S. Guedes escribió: Fujii Masao escreveu: (...) Even if we need to have the database in real, I'd like to use another name for it. The name 'walsender' seems to be

[HACKERS] Comments to Synchronous replication patch v3

2008-11-24 Thread ITAGAKI Takahiro
Fujii Masao [EMAIL PROTECTED] wrote: On Fri, Nov 14, 2008 at 7:15 PM, Fujii Masao [EMAIL PROTECTED] wrote: Attached is the latest version of Synch Rep patch. Sorry for my late posting. I fixed some bugs in v1patch and integrated walreceiver into core. I have some comments about v3 patch.