Re: [HACKERS] Contains and is contained by operators of inet datatypes

2016-11-29 Thread Tom Lane
Robert Haas writes: > On Mon, Nov 21, 2016 at 7:57 AM, Andreas Karlsson wrote: >> I like the patch because it means less operators to remember for me as a >> PostgreSQL user. And at least for me inet is a rarely used type compared to >> hstore, json and

Re: [HACKERS] Contains and is contained by operators of inet datatypes

2016-11-29 Thread Emre Hasegeli
> I do not like this bit from the original post: > > EH> The patch removes the recently committed SP-GiST index support for the > EH> existing operator symbols to give move reason to the users to use the > EH> new symbols. I reverted this part. The new version of the patch is attached.

Re: [HACKERS] Contains and is contained by operators of inet datatypes

2016-11-21 Thread Robert Haas
On Mon, Nov 21, 2016 at 7:57 AM, Andreas Karlsson wrote: > I like the patch because it means less operators to remember for me as a > PostgreSQL user. And at least for me inet is a rarely used type compared to > hstore, json and range types which all use @> and <@. I agree

Re: [HACKERS] Contains and is contained by operators of inet datatypes

2016-11-21 Thread Andreas Karlsson
On 11/17/2016 11:14 PM, Tom Lane wrote: The original post proposed that we'd eventually get some benefit by being able to repurpose << and >> to mean something else, but the time scale over which that could happen is so long as to make it unlikely to ever happen. I think we'd need to deprecate

Re: [HACKERS] Contains and is contained by operators of inet datatypes

2016-11-18 Thread Emre Hasegeli
> The new names might be better if we were starting in a green field, > but in themselves they are not any more mnemonic than what we had, and > what we had has been there for a lot of years. Also, if we accept both > old names and new (which it seems like we'd have to), that creates new >

Re: [HACKERS] Contains and is contained by operators of inet datatypes

2016-11-17 Thread Tom Lane
Andreas Karlsson writes: > Emre Hasegeli wrote: > Attached patch adds <@, @>, <<@, and @>> operator symbols for inet > datatype to replace <<=, >>=, <<, and >>. > Nice, I am fine with this version of the patch. Setting it to ready for > committer! I looked at this

Re: [HACKERS] Contains and is contained by operators of inet datatypes

2016-11-13 Thread Andreas Karlsson
On 11/13/2016 01:21 PM, Emre Hasegeli wrote: Thank you for the review. New version is attached. Nice, I am fine with this version of the patch. Setting it to ready for committer! Andreas -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Contains and is contained by operators of inet datatypes

2016-11-13 Thread Emre Hasegeli
> - I am not convinced that your changes to the descriptions of the operators > necessarily make things clearer. For example "is contained by and smaller > network (subnet)" only mentions subnets and not IP-addresses. I was trying to avoid confusion. <@ is the "contained by" operator which is

Re: [HACKERS] Contains and is contained by operators of inet datatypes

2016-11-11 Thread Andreas Karlsson
Review - Applies and passes the test suite. - I think this is a good change since it increases the consistency of the operators. I also like the choice of <<@ and @>> since they feel intuitive to me. - I tested it and both old and new operators use the brin and gist indexes. - The new

[HACKERS] Contains and is contained by operators of inet datatypes

2016-10-01 Thread Emre Hasegeli
Attached patch adds <@, @>, <<@, and @>> operator symbols for inet datatype to replace <<=, >>=, <<, and >>. <@ and @> symbols are used for containment for all datatypes except inet, particularly on the geometric types, arrays; cube, hstore, intaray, ltree extensions. <@ and @> symbols are