On 07/18/2015 04:15 PM, Alvaro Herrera wrote:
Heikki Linnakangas wrote:
If it's there just to so you can run the regression tests that come
with it, it might make sense to just add a default case to that
switch to handle any unrecognized commands, and perhaps even remove
the cases for the
On 2015-07-17 21:40:45 +0300, Heikki Linnakangas wrote:
Hmm, that function is pretty fragile, it will segfault on any AT_* type that
it doesn't recognize. Thankfully you get that compiler warning, but we have
added AT_* type codes before in minor releases.
For in-core code that is supposed to
Heikki Linnakangas wrote:
On 07/18/2015 04:15 PM, Alvaro Herrera wrote:
Heikki Linnakangas wrote:
If it's there just to so you can run the regression tests that come
with it, it might make sense to just add a default case to that
switch to handle any unrecognized commands, and perhaps even
Alvaro Herrera wrote:
Heikki Linnakangas wrote:
On 07/18/2015 04:15 PM, Alvaro Herrera wrote:
Heikki Linnakangas wrote:
If it's there just to so you can run the regression tests that come
with it, it might make sense to just add a default case to that
switch to handle any unrecognized
Heikki Linnakangas wrote:
On 07/17/2015 05:40 PM, Michael Paquier wrote:
On Fri, Jul 17, 2015 at 11:16 PM, Kevin Grittner kgri...@ymail.com wrote:
Heikki Linnakangas heikki.linnakan...@iki.fi wrote:
This fixes bug #13126, reported by Kirill Simonov.
It looks like you missed something with
On Fri, Jul 17, 2015 at 11:16 PM, Kevin Grittner kgri...@ymail.com wrote:
Heikki Linnakangas heikki.linnakan...@iki.fi wrote:
This fixes bug #13126, reported by Kirill Simonov.
It looks like you missed something with the addition of
AT_ReAddComment:
test_ddl_deparse.c:80:11: warning:
Heikki Linnakangas heikki.linnakan...@iki.fi wrote:
This fixes bug #13126, reported by Kirill Simonov.
It looks like you missed something with the addition of
AT_ReAddComment:
test_ddl_deparse.c:80:11: warning: enumeration value 'AT_ReAddComment' not
handled in switch [-Wswitch]
On 07/17/2015 05:40 PM, Michael Paquier wrote:
On Fri, Jul 17, 2015 at 11:16 PM, Kevin Grittner kgri...@ymail.com wrote:
Heikki Linnakangas heikki.linnakan...@iki.fi wrote:
This fixes bug #13126, reported by Kirill Simonov.
It looks like you missed something with the addition of
