Re: [HACKERS] Doc patch, normalize search_path in index

2013-01-25 Thread Bruce Momjian
On Fri, Sep 28, 2012 at 12:40:38PM -0500, Karl O. Pinc wrote: Hi, The attached patch (against git head) normalizes search_path as the thing indexed and uses a secondary index term to distinguish the configuration parameter from the run-time setting. search path the concept remains

Re: [HACKERS] Doc patch, normalize search_path in index

2013-01-25 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: I have applied a modified version of your patch that creates separate secondary index references for search_path. This patch seems pretty bizarre. What is the difference between a configuration parameter and a run-time setting? Why would you point people

Re: [HACKERS] Doc patch, normalize search_path in index

2013-01-25 Thread Bruce Momjian
On Fri, Jan 25, 2013 at 01:35:49PM -0500, Tom Lane wrote: Bruce Momjian br...@momjian.us writes: I have applied a modified version of your patch that creates separate secondary index references for search_path. This patch seems pretty bizarre. What is the difference between a

Re: [HACKERS] Doc patch, normalize search_path in index

2013-01-25 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: On Fri, Jan 25, 2013 at 01:35:49PM -0500, Tom Lane wrote: This patch seems pretty bizarre. What is the difference between a configuration parameter and a run-time setting? Why would you point people to two different places for those two terms? Should

Re: [HACKERS] Doc patch, normalize search_path in index

2013-01-25 Thread Bruce Momjian
On Fri, Jan 25, 2013 at 01:42:48PM -0500, Tom Lane wrote: Bruce Momjian br...@momjian.us writes: On Fri, Jan 25, 2013 at 01:35:49PM -0500, Tom Lane wrote: This patch seems pretty bizarre. What is the difference between a configuration parameter and a run-time setting? Why would you

Re: [HACKERS] Doc patch, normalize search_path in index

2013-01-25 Thread Peter Eisentraut
On 1/25/13 12:50 PM, Bruce Momjian wrote: On Fri, Sep 28, 2012 at 12:40:38PM -0500, Karl O. Pinc wrote: Hi, The attached patch (against git head) normalizes search_path as the thing indexed and uses a secondary index term to distinguish the configuration parameter from the run-time

Re: [HACKERS] Doc patch, normalize search_path in index

2013-01-25 Thread Bruce Momjian
On Fri, Jan 25, 2013 at 01:46:46PM -0500, Peter Eisentraut wrote: On 1/25/13 12:50 PM, Bruce Momjian wrote: On Fri, Sep 28, 2012 at 12:40:38PM -0500, Karl O. Pinc wrote: Hi, The attached patch (against git head) normalizes search_path as the thing indexed and uses a secondary index

Re: [HACKERS] Doc patch, normalize search_path in index

2013-01-25 Thread Karl O. Pinc
On 01/25/2013 12:35:49 PM, Tom Lane wrote: Bruce Momjian br...@momjian.us writes: I have applied a modified version of your patch that creates separate secondary index references for search_path. This patch seems pretty bizarre. What is the difference between a configuration parameter

Re: [HACKERS] Doc patch, normalize search_path in index

2013-01-25 Thread Peter Eisentraut
On 1/25/13 1:59 PM, Bruce Momjian wrote: On Fri, Jan 25, 2013 at 01:46:46PM -0500, Peter Eisentraut wrote: This matter was already closed: https://commitfest.postgresql.org/action/patch_view?id=949 It looks like your patch reverts part of that. Uh, I am confused because the patch at:

Re: [HACKERS] Doc patch, normalize search_path in index

2013-01-25 Thread Bruce Momjian
On Fri, Jan 25, 2013 at 05:10:14PM -0500, Peter Eisentraut wrote: On 1/25/13 1:59 PM, Bruce Momjian wrote: On Fri, Jan 25, 2013 at 01:46:46PM -0500, Peter Eisentraut wrote: This matter was already closed: https://commitfest.postgresql.org/action/patch_view?id=949 It looks like your

Re: [HACKERS] Doc patch, normalize search_path in index

2012-09-30 Thread Dan Scott
On Fri, Sep 28, 2012 at 1:40 PM, Karl O. Pinc k...@meme.com wrote: Hi, The attached patch (against git head) normalizes search_path as the thing indexed and uses a secondary index term to distinguish the configuration parameter from the run-time setting. Makes sense to me, although I