Re: [HACKERS] quiet inline configure check misses a step for clang

2014-05-03 Thread Andres Freund
On 2014-05-01 16:17:17 -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: Patch attached. Committed with minor comment-smithing. Interestingly this seems to have allowed the quiet inline test to succeedd on HP-UX ac++ as well:

Re: [HACKERS] quiet inline configure check misses a step for clang

2014-05-01 Thread Andres Freund
Hi, On 2014-04-03 12:47:00 +0200, Andres Freund wrote: The current quiet inline test doesn't work for clang. As e.g. evidenced in http://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=gulldt=2014-04-03%2007%3A49%3A26stg=configure configure thinks it's not quiet. Which means that

Re: [HACKERS] quiet inline configure check misses a step for clang

2014-05-01 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: I still think we really need to fix this. I have three possible solutions: a) Add an external file (in the source tree) that's included in the configure test. b) Have a compiler specific override and specify USE_INLINE there. c) Drop the

Re: [HACKERS] quiet inline configure check misses a step for clang

2014-05-01 Thread Andres Freund
On 2014-05-01 10:10:46 -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: I still think we really need to fix this. I have three possible solutions: a) Add an external file (in the source tree) that's included in the configure test. b) Have a compiler specific

Re: [HACKERS] quiet inline configure check misses a step for clang

2014-05-01 Thread Andres Freund
On 2014-05-01 10:10:46 -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: I still think we really need to fix this. I have three possible solutions: a) Add an external file (in the source tree) that's included in the configure test. b) Have a compiler specific

Re: [HACKERS] quiet inline configure check misses a step for clang

2014-05-01 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: Patch attached. Committed with minor comment-smithing. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] quiet inline configure check misses a step for clang

2014-05-01 Thread Andres Freund
On 2014-05-01 16:17:17 -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: Patch attached. Committed with minor comment-smithing. Thanks. There's another problematic case:

Re: [HACKERS] quiet inline configure check misses a step for clang

2014-05-01 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: There's another problematic case: http://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=olinguitodt=2014-05-01%2021%3A22%3A43stg=config /usr/local/lib/libxml2.so.14.0: warning: strcpy() is almost always misused, please use strlcpy()

Re: [HACKERS] quiet inline configure check misses a step for clang

2014-04-03 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: The current quiet inline test doesn't work for clang. As e.g. evidenced in http://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=gulldt=2014-04-03%2007%3A49%3A26stg=configure configure thinks it's not quiet. Which means that postgres

Re: [HACKERS] quiet inline configure check misses a step for clang

2014-04-03 Thread Andres Freund
On 2014-04-03 09:43:20 -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: The current quiet inline test doesn't work for clang. As e.g. evidenced in http://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=gulldt=2014-04-03%2007%3A49%3A26stg=configure configure thinks

Re: [HACKERS] quiet inline configure check misses a step for clang

2014-04-03 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: On 2014-04-03 09:43:20 -0400, Tom Lane wrote: I object to the latter; you're proposing to greatly increase the warning noise seen with any compiler that issues a warning for this without caring about .h vs .c. For somebody who finds gcc -pedantic

Re: [HACKERS] quiet inline configure check misses a step for clang

2014-04-03 Thread Andres Freund
On 2014-04-03 09:43:20 -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: The current quiet inline test doesn't work for clang. As e.g. evidenced in http://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=gulldt=2014-04-03%2007%3A49%3A26stg=configure configure thinks

Re: [HACKERS] quiet inline configure check misses a step for clang

2014-04-03 Thread Andres Freund
On 2014-04-03 10:15:33 -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On 2014-04-03 09:43:20 -0400, Tom Lane wrote: I object to the latter; you're proposing to greatly increase the warning noise seen with any compiler that issues a warning for this without caring