Re: [HACKERS] Updated tsearch documentation

2007-07-27 Thread Oleg Bartunov
On Thu, 26 Jul 2007, Bruce Momjian wrote: Oleg Bartunov wrote: Bruce, I sent you link to my wiki page with summary of changes http://www.sai.msu.su/~megera/wiki/ts_changes Your documentation looks rather old. I have updated it to reflect your changes:

Re: [HACKERS] Updated tsearch documentation

2007-07-27 Thread Oleg Bartunov
On Thu, 26 Jul 2007, Bruce Momjian wrote: Oleg Bartunov wrote: On Wed, 25 Jul 2007, Erikjan wrote: In http://momjian.us/expire/fulltext/HTML/textsearch-intro.html#TEXTSEARCH-DOCUMENT it says: A document is any text file that can be opened, read, and modified. OOps, in my original

Re: [HACKERS] default_text_search_config and expression indexes

2007-07-27 Thread Pavel Stehule
1) Document the problem and do nothing else. 2) Make default_text_search_config a postgresql.conf-only setting, thereby making it impossible to change by non-super users, or make it a super-user-only setting. 3) Remove default_text_search_config

Re: [HACKERS] default_text_search_config and expression indexes

2007-07-27 Thread Oleg Bartunov
On Fri, 27 Jul 2007, Pavel Stehule wrote: 1) Document the problem and do nothing else. 2) Make default_text_search_config a postgresql.conf-only setting, thereby making it impossible to change by non-super users, or make it a super-user-only setting.

Re: [HACKERS] default_text_search_config and expression indexes

2007-07-27 Thread Oleg Bartunov
On Fri, 27 Jul 2007, Pavel Stehule wrote: 2007/7/27, Oleg Bartunov [EMAIL PROTECTED]: On Fri, 27 Jul 2007, Pavel Stehule wrote: 1) Document the problem and do nothing else. 2) Make default_text_search_config a postgresql.conf-only setting, thereby making it

Re: [HACKERS] default_text_search_config and expression indexes

2007-07-27 Thread Pavel Stehule
2007/7/27, Oleg Bartunov [EMAIL PROTECTED]: On Fri, 27 Jul 2007, Pavel Stehule wrote: 1) Document the problem and do nothing else. 2) Make default_text_search_config a postgresql.conf-only setting, thereby making it impossible to change by non-super

Re: [HACKERS] stats_block_level

2007-07-27 Thread Peter Eisentraut
Tom Lane wrote: Any reason not to just fold them both into stats_start_collector ? Well, then you couldn't turn collection on and off without restarting the postmaster, which might be a pain. Maybe we don't actually need stats_start_collector, but instead we start it always and just have

Re: [HACKERS] default_text_search_config and expression indexes

2007-07-27 Thread Pavel Stehule
configuration has NOTHING with language ! This is a most frequent myth about configuration. It's just the way we chose for default_text_search_config to use language part of locale at initdb time. text search configuration is just a bind between parser to use for breaking document by lexems

Re: [HACKERS] stats_block_level

2007-07-27 Thread Dave Page
Simon Riggs wrote: On Fri, 2007-07-27 at 04:29 -0400, Alvaro Herrera wrote: Peter Eisentraut wrote: Tom Lane wrote: Any reason not to just fold them both into stats_start_collector ? Well, then you couldn't turn collection on and off without restarting the postmaster, which might be a pain.

Re: [HACKERS] stats_block_level

2007-07-27 Thread Alvaro Herrera
Peter Eisentraut wrote: Tom Lane wrote: Any reason not to just fold them both into stats_start_collector ? Well, then you couldn't turn collection on and off without restarting the postmaster, which might be a pain. Maybe we don't actually need stats_start_collector, but instead we

Re: [HACKERS] stats_block_level

2007-07-27 Thread Simon Riggs
On Fri, 2007-07-27 at 04:29 -0400, Alvaro Herrera wrote: Peter Eisentraut wrote: Tom Lane wrote: Any reason not to just fold them both into stats_start_collector ? Well, then you couldn't turn collection on and off without restarting the postmaster, which might be a pain.

Re: [HACKERS] default_text_search_config and expression indexes

2007-07-27 Thread Magnus Hagander
On Thu, Jul 26, 2007 at 06:23:51PM -0400, Bruce Momjian wrote: Oleg Bartunov wrote: Second, I can't figure out how to reference a non-default configuration. See the multi-argument versions of to_tsvector etc. I do see a problem with having to_tsvector(config, text) plus

Re: [HACKERS] Quick idea for reducing VACUUM contention

2007-07-27 Thread Alvaro Herrera
ITAGAKI Takahiro wrote: Simon Riggs [EMAIL PROTECTED] wrote: Read the heap blocks in sequence, but make a conditional lock for cleanup on each block. If we don't get it, sleep, then try again when we wake up. If we fail the second time, just skip the block completely. It would be cool if

Re: [HACKERS] [PATCHES] allow CSV quote in NULL

2007-07-27 Thread Andrew Dunstan
[redirecting to -hackers] Stephen Frost wrote: * Gregory Stark ([EMAIL PROTECTED]) wrote: Tom Lane [EMAIL PROTECTED] writes: Stephen Frost [EMAIL PROTECTED] writes: Please find attached a minor patch to remove the constraints that a user can't include the delimiter or

Re: [HACKERS] LSN grouping within clog pages

2007-07-27 Thread Simon Riggs
On Thu, 2007-07-26 at 22:37 -0400, Tom Lane wrote: I've been looking at the way that the async-commit patch conserves shared memory space by remembering async commit LSNs for groups of transactions on a clog page, rather than having an LSN for each individual transaction slot. This seems

[HACKERS] Document and/or remove unreachable code in tuptoaster.c from varvarlena patch

2007-07-27 Thread Gregory Stark
Testers here were having a hard time constructing test cases to reach some lines touched by the varvarlena patch. Upon further investigation I'm convinced they're unreachable. Some were added when I did packed varlena -- I've removed those. These lines were actually necessary earlier but when we

Re: [HACKERS] stats_block_level

2007-07-27 Thread Simon Riggs
On Fri, 2007-07-27 at 10:15 +0100, Dave Page wrote: Simon Riggs wrote: On Fri, 2007-07-27 at 04:29 -0400, Alvaro Herrera wrote: Peter Eisentraut wrote: Tom Lane wrote: Any reason not to just fold them both into stats_start_collector ? Well, then you couldn't turn collection on and off

Re: [HACKERS] Document and/or remove unreachable code in tuptoaster.c from varvarlena patch

2007-07-27 Thread Gregory Stark
Sorry, meant to send the previous message to pgsql-patches. Here's a version cut using cvs diff so it's usable with -p0 I added one more fixup. There was a silly test in toast_fetch_datum_slice() which handled compressed datums. Returning a slice of a compressed datum is nonsensical with toast

Re: [HACKERS] [PATCHES] allow CSV quote in NULL

2007-07-27 Thread Andrew Dunstan
Stephen Frost wrote: I'm honestly not a big fan of the columnlist approach that's been taken with the options. While I understand the desire to seperate the parsing from the typing, making the users essentially do that association for us by way of making them specify how to handle each

Re: [HACKERS] [PATCHES] allow CSV quote in NULL

2007-07-27 Thread Stephen Frost
* Andrew Dunstan ([EMAIL PROTECTED]) wrote: This looks too clever by half, to me. Someone facing the problem you are facing would have to dig quite deep to find the solution you're promoting. Oddly enough, it was one of the first things I tried when I discovered it wasn't just realizing that

Re: [HACKERS] [PATCHES] allow CSV quote in NULL

2007-07-27 Thread Stephen Frost
* Andrew Dunstan ([EMAIL PROTECTED]) wrote: Stephen Frost wrote: I'm honestly not a big fan of the columnlist approach that's been taken with the options. While I understand the desire to seperate the parsing from the typing, making the users essentially do that association for us by way of

Re: [HACKERS] Updated tsearch documentation

2007-07-27 Thread Bruce Momjian
Oleg Bartunov wrote: On Thu, 26 Jul 2007, Bruce Momjian wrote: Oleg Bartunov wrote: On Wed, 25 Jul 2007, Erikjan wrote: In http://momjian.us/expire/fulltext/HTML/textsearch-intro.html#TEXTSEARCH-DOCUMENT it says: A document is any text file that can be opened, read, and

Re: [HACKERS] Updated tsearch documentation

2007-07-27 Thread Bruce Momjian
Thanks, I found a few more places that needed updating. It should be accurate now. Thanks for the report. --- Oleg Bartunov wrote: On Thu, 26 Jul 2007, Bruce Momjian wrote: Oleg Bartunov wrote: Bruce, I sent

Re: [HACKERS] Updated tsearch documentation

2007-07-27 Thread Bruce Momjian
Dimitri Fontaine wrote: -- Start of PGP signed section. Hi, Le mercredi 25 juillet 2007, Bruce Momjian a ?crit?: I have added more documentation to try to show how full text search is used by user tables. I think this the documentaiton is almost done:

Re: [HACKERS] default_text_search_config and expression indexes

2007-07-27 Thread Bruce Momjian
Magnus Hagander wrote: However, the big problem is that the expressions used in expression indexes should not change their output based on the value of a GUC variable (because it would corrupt the index), but in the case above, default_text_search_config controls what configuration is