Re: [HACKERS] GROUPING SETS revisited

2010-08-02 Thread Pavel Stehule
Hello 2010/8/3 Joshua Tolley : > In case anyone's interested, I've taken the CTE-based grouping sets patch from > [1] and made it apply to 9.1, attached. I haven't yet done things like checked > it for whitespace consistency, style conformity, or anything else, but (tuits > permitting) hope to fig

[HACKERS] GROUPING SETS revisited

2010-08-02 Thread Joshua Tolley
In case anyone's interested, I've taken the CTE-based grouping sets patch from [1] and made it apply to 9.1, attached. I haven't yet done things like checked it for whitespace consistency, style conformity, or anything else, but (tuits permitting) hope to figure out how it works and get it closer t

Re: [HACKERS] review: psql: edit function, show function commands patch

2010-08-02 Thread Pavel Stehule
2010/8/3 Robert Haas : > On Mon, Aug 2, 2010 at 11:17 PM, Tom Lane wrote: >> Robert Haas writes: >>> On Mon, Aug 2, 2010 at 10:49 PM, Tom Lane wrote: I'm tempted to suggest forgetting about any user-configurable parameter and just provide code that strcmp's the $EDITOR value to se

Re: [HACKERS] review: psql: edit function, show function commands patch

2010-08-02 Thread Pavel Stehule
2010/8/3 Robert Haas : > On Sun, Aug 1, 2010 at 11:48 PM, Robert Haas wrote: >>> b) more robust algorithm for header rows identification >> >> Have not gotten to this one yet. > > I notIce that on WIN32 the default editor is notepad.exe and the > default editor navigation option is "/".  Does "not

Re: [HACKERS] review: psql: edit function, show function commands patch

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 11:17 PM, Tom Lane wrote: > Robert Haas writes: >> On Mon, Aug 2, 2010 at 10:49 PM, Tom Lane wrote: >>> I'm tempted >>> to suggest forgetting about any user-configurable parameter and just >>> provide code that strcmp's the $EDITOR value to see if it recognizes the >>> edi

Re: [HACKERS] (9.1) btree_gist support for searching on "not equals"

2010-08-02 Thread Jeff Davis
On Mon, 2010-08-02 at 12:27 -0400, Robert Haas wrote: > I was also wondering if it would be worth adding some additional > regression testing to contrib/btree_gist exercising this new > functionality. Thoughts? Sure. I attached two tests. Regards, Jeff Davis *** a/contrib/btree_gist/Mak

Re: [HACKERS] review: psql: edit function, show function commands patch

2010-08-02 Thread Tom Lane
Robert Haas writes: > On Mon, Aug 2, 2010 at 10:49 PM, Tom Lane wrote: >> I'm tempted >> to suggest forgetting about any user-configurable parameter and just >> provide code that strcmp's the $EDITOR value to see if it recognizes the >> editor name, otherwise do nothing. > With all due respect,

Re: [HACKERS] review: psql: edit function, show function commands patch

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 10:49 PM, Tom Lane wrote: > Robert Haas writes: >> This is actually my biggest concern about this patch - that it may be >> just too much of a hassle to actually make it work for people.  I just >> tried setting $EDITOR to MacOS's TextEdit program, and it turns out >> that

Re: [HACKERS] review: psql: edit function, show function commands patch

2010-08-02 Thread Tom Lane
Robert Haas writes: > This is actually my biggest concern about this patch - that it may be > just too much of a hassle to actually make it work for people. I just > tried setting $EDITOR to MacOS's TextEdit program, and it turns out > that TextEdit doesn't understand +. I'm afraid that we're go

Re: [HACKERS] review: psql: edit function, show function commands patch

2010-08-02 Thread Robert Haas
On Sun, Aug 1, 2010 at 11:48 PM, Robert Haas wrote: >> b) more robust algorithm for header rows identification > > Have not gotten to this one yet. I notIce that on WIN32 the default editor is notepad.exe and the default editor navigation option is "/". Does "notepad.exe /lineno filename" actual

Re: [HACKERS] multibyte charater set in levenshtein function

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 5:07 PM, Alexander Korotkov wrote: > Now I think patch is as good as can be. :) OK, committed. > I'm going to prepare less-or-equal function in same manner as this patch. Sounds good. Since we're now more than half-way through this CommitFest and this patch has undergone

Re: [HACKERS] Where in the world is Itagaki Takahiro?

2010-08-02 Thread Josh Berkus
On 8/2/10 3:42 PM, Itagaki Takahiro wrote: > Sorry for delayed reply. I moved to a new job, > and was very busy for it. Congratulations! Are you still at NTT Open Source? -- -- Josh Berkus PostgreSQL Experts Inc.

Re: [HACKERS] Where in the world is Itagaki Takahiro?

2010-08-02 Thread Itagaki Takahiro
2010/8/3 Kevin Grittner : > I haven't seen any posts or CF activity from Itagaki in over a week, > so I'm wondering how to handle some patches in the CF.  Does anyone > know whether he's on vacation?  Expected return? Sorry for delayed reply. I moved to a new job, and was very busy for it. My pro

Re: [HACKERS] Review: Row-level Locks & SERIALIZABLE transactions, postgres vs. Oracle

2010-08-02 Thread Florian Pflug
Hi I've updated mvcc.sgml to explain the new serialization conflict rules for row-level locks, and added a paragraph to backend/executor/README that explains the implementation of those. I've chosen backend/executor/README because it already contains a description of UPDATE handling in READ COM

[HACKERS] Where in the world is Itagaki Takahiro?

2010-08-02 Thread Kevin Grittner
I haven't seen any posts or CF activity from Itagaki in over a week, so I'm wondering how to handle some patches in the CF. Does anyone know whether he's on vacation? Expected return? -Kevin -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscrip

Re: [HACKERS] review: xml_is_well_formed

2010-08-02 Thread Mike Fowler
On 02/08/10 07:46, Pavel Stehule wrote: I have not any suggestions now - so I'll change flag to "ready to commit" sorry - contrib module should be a fixed patch attached Thanks Pavel, you saved me some time! Regards, -- Mike Fowler Registered Linux user: 379787 -- Sent via pgsql-hacker

Re: [HACKERS] multibyte charater set in levenshtein function

2010-08-02 Thread Robert Haas
2010/8/2 Alexander Korotkov : > The dump of the table with russian dictionary is in attachment. > > I use following tests: > SELECT SUM(levenshtein(a, 'foo')) from words; > SELECT SUM(levenshtein(a, 'Urbański')) FROM words; > SELECT SUM(levenshtein(a, 'ańs')) FROM words; > SELECT SUM(levenshtein(a,

Re: [HACKERS] patch for check constraints using multiple inheritance

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 2:56 PM, Yeb Havinga wrote: > I do not completely understand what you mean with the destruction of > reusability of ATOneLevelRecursion, currently only called by ATPrepAddColumn > - in the patch it is documented in the definition of relVisited that is it > visit info for eac

Re: [HACKERS] lock_timeout GUC patch - Review

2010-08-02 Thread Kevin Grittner
Robert Haas wrote: >> I wonder whether this patch shouldn't be rejected with a request >> that the timeout framework be submitted to the next CF. > I think "Returned with Feedback" would be more appropriate than > "Rejected", since we're asking for a rework, rather than saying - > we just don'

Re: [HACKERS] lock_timeout GUC patch - Review

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 3:09 PM, Kevin Grittner wrote: > Marc Cousin wrote: > >> This time, it's this case that doesn't work : > >> I really feel that the timeout framework is the way to go here. > > Since Zoltán also seems to feel this way: > > http://archives.postgresql.org/message-id/4c516c3a.6

Re: [HACKERS] lock_timeout GUC patch - Review

2010-08-02 Thread Kevin Grittner
Boszormenyi Zoltan wrote: > Kevin Grittner írta: >> I wonder whether this patch shouldn't be rejected with a request >> that the timeout framework be submitted to the next CF. Does >> anyone feel this approach (without the framework) should be >> pursued further? > > I certainly think so, the

Re: [HACKERS] lock_timeout GUC patch - Review

2010-08-02 Thread Boszormenyi Zoltan
Hi, Kevin Grittner írta: > Marc Cousin wrote: > > >> This time, it's this case that doesn't work : >> > > >> I really feel that the timeout framework is the way to go here. >> > > Since Zoltán also seems to feel this way: > > http://archives.postgresql.org/message-id/4c516

Re: [HACKERS] lock_timeout GUC patch - Review

2010-08-02 Thread Kevin Grittner
Marc Cousin wrote: > This time, it's this case that doesn't work : > I really feel that the timeout framework is the way to go here. Since Zoltán also seems to feel this way: http://archives.postgresql.org/message-id/4c516c3a.6090...@cybertec.at I wonder whether this patch shouldn't be r

Re: [HACKERS] patch for check constraints using multiple inheritance

2010-08-02 Thread Yeb Havinga
Robert Haas wrote: I don't think that this is much cleaner than the global variable solution; you haven't really localized that need to know about the new flag in any meaningful way, the hacks in ATOneLevelRecusion() basically destroy any pretense of that code possibly being reusable for some oth

Re: [HACKERS] Compiling CVS HEAD with clang under OSX

2010-08-02 Thread Greg Stark
On Mon, Aug 2, 2010 at 4:27 PM, Tom Lane wrote: > Here's the problem: if the compiler is allowed to assume that overflow > cannot happen, it is always going to be able to "prove" that the > if-test is constant false.  This is inherent.  Anybody claiming to > exhibit a safe way to code the overflow

Re: [HACKERS] (9.1) btree_gist support for searching on "not equals"

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 2:39 AM, Jeff Davis wrote: > On Sun, 2010-08-01 at 21:57 -0400, Robert Haas wrote: >> On Fri, Jul 16, 2010 at 1:19 AM, Jeff Davis wrote: >> > Thank you for the review. >> > >> > On Mon, 2010-07-12 at 17:17 +0900, Itagaki Takahiro wrote: >> >> (1) Exclusion constraints suppo

Re: [HACKERS] knngist - 0.8

2010-08-02 Thread Robert Haas
2010/7/29 Alexander Korotkov : > But, in pg_trgm it makes it possible to combine different similarity levels > in one query. For example: > select * from test_trgm order by t <-> 'asdf' < 0.5 or t <-> 'qwer' < 0.4; > Is there any chance to handle this syntax also? Maybe I'm missing something, but

Re: [HACKERS] patch for check constraints using multiple inheritance

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 10:47 AM, Yeb Havinga wrote: >>> The attached patch uses the globally defined list. >> >> I can't speak for any other committer, but personally I'm prepared to >> reject out of hand any solution involving a global variable.  This >> code is none to easy to follow as it is an

Re: [HACKERS] Compiling CVS HEAD with clang under OSX

2010-08-02 Thread Tom Lane
Neil Conway writes: > FWIW, I think we should aim to eventually remove the dependency on > -fwrapv, and instead make the code correct under the semantics > guaranteed by the C spec. [ shrug... ] We've gone around on that before. I can't get excited about it, and the reason is that 99% of the pl

Re: [HACKERS] lock_timeout GUC patch - Review

2010-08-02 Thread Marc Cousin
The Monday 02 August 2010 13:59:59, Boszormenyi Zoltan wrote : > > > > Also, I made sure that only one or two timeout causes (one of > > deadlock_timeout > > and lock_timeout in the first case or statement_timeout plus one of the > > other two) > > can be active at a time. > > A little clarificati

Re: [HACKERS] multibyte charater set in levenshtein function

2010-08-02 Thread Robert Haas
2010/8/2 Alexander Korotkov : > On Mon, Aug 2, 2010 at 5:20 AM, Robert Haas wrote: >> I reviewed this code in a fair amount of detail today and ended up >> rewriting it.  In general terms, it's best to avoid changing things >> that are not relevant to the central purpose of the patch.  This patch

Re: [HACKERS] patch for check constraints using multiple inheritance

2010-08-02 Thread Yeb Havinga
Robert Haas wrote: On Mon, Aug 2, 2010 at 9:20 AM, Yeb Havinga wrote: The attached patch uses the globally defined list. I can't speak for any other committer, but personally I'm prepared to reject out of hand any solution involving a global variable. This code is none to easy to follow as it

Re: [HACKERS] english parser in text search: support for multiple words in the same position

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 10:21 AM, Kevin Grittner wrote: > Sushant Sinha wrote: > >> Yes thats what I am planning to do. I just wanted to see if anyone >> can help me in estimating whether this is doable in the current >> parser or I need to write a new one. If possible, then some idea >> on how to

Re: [HACKERS] english parser in text search: support for multiple words in the same position

2010-08-02 Thread Kevin Grittner
Sushant Sinha wrote: > Yes thats what I am planning to do. I just wanted to see if anyone > can help me in estimating whether this is doable in the current > parser or I need to write a new one. If possible, then some idea > on how to go about implementing? The current tsearch parser is a stat

Re: [HACKERS] english parser in text search: support for multiple words in the same position

2010-08-02 Thread Tom Lane
Sushant Sinha writes: >> This would needlessly increase the number of tokens. Instead you'd >> better make it work like compound word support, having just "wikipedia" >> and "org" as tokens. > The current text parser already returns url and url_path. That already > increases the number of uniqu

Re: [HACKERS] english parser in text search: support for multiple words in the same position

2010-08-02 Thread Sushant Sinha
On Mon, 2010-08-02 at 09:32 -0400, Robert Haas wrote: > On Mon, Aug 2, 2010 at 9:12 AM, Sushant Sinha wrote: > > The current text parser already returns url and url_path. That already > > increases the number of unique tokens. I am only asking for adding of > > normal english words as well so that

Re: [HACKERS] patch for check constraints using multiple inheritance

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 9:20 AM, Yeb Havinga wrote: > Robert Haas wrote: >> >> I agree that's the crux of the problem, but I can't see solving it >> with a global variable.  I realize you were just testing... > > Yes it was just a test. However, somewhere information must be kept or > altered so it

Re: [HACKERS] english parser in text search: support for multiple words in the same position

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 9:12 AM, Sushant Sinha wrote: > The current text parser already returns url and url_path. That already > increases the number of unique tokens. I am only asking for adding of > normal english words as well so that if someone types only "wikipedia" > he gets a match. [...] >

Re: [HACKERS] english parser in text search: support for multiple words in the same position

2010-08-02 Thread Markus Wanner
Hi, On 08/02/2010 03:12 PM, Sushant Sinha wrote: The current text parser already returns url and url_path. That already increases the number of unique tokens. Well, I think I simply turned that off to be able to search for plain words. It still works for complete URLs, those are just treated

Re: [HACKERS] Postgres as Historian

2010-08-02 Thread Etienne Dube
On 02/08/2010 3:20 AM, Hardik Belani wrote: We are using postgres as RDBMS for our product. There is a requirement coming for a feature which will require me to store data about various data points (mainly numbers) on a time scale. Data measurement is being taken every few secs/mins based and i

Re: [HACKERS] patch for check constraints using multiple inheritance

2010-08-02 Thread Yeb Havinga
Robert Haas wrote: I agree that's the crux of the problem, but I can't see solving it with a global variable. I realize you were just testing... Yes it was just a test. However, somewhere information must be kept or altered so it can be detected that a relation has already been visited, i.e

Re: [HACKERS] english parser in text search: support for multiple words in the same position

2010-08-02 Thread Sushant Sinha
> On 08/01/2010 08:04 PM, Sushant Sinha wrote: > > 1. We do not have separate tokens "wikipedia" and "org" > > 2. If we have the two tokens we should have them at adjacent position so > > that a phrase search for "wikipedia org" should work. > > This would needlessly increase the number of tokens.

Re: [HACKERS] Synchronous replication

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 8:57 AM, Yeb Havinga wrote: > Fujii Masao wrote: >> >> On Mon, Aug 2, 2010 at 7:53 PM, Robert Haas wrote: >> >>> >>> Let's not get *the manner of specifying the policy* confused with *the >>> need to update the policy when the master changes*.  It doesn't seem >>> likely yo

Re: [HACKERS] Synchronous replication

2010-08-02 Thread Yeb Havinga
Fujii Masao wrote: On Mon, Aug 2, 2010 at 7:53 PM, Robert Haas wrote: Let's not get *the manner of specifying the policy* confused with *the need to update the policy when the master changes*. It doesn't seem likely you would want the same value for synchronous_standbys on all your machine

Re: [HACKERS] Synchronous replication

2010-08-02 Thread Fujii Masao
On Mon, Aug 2, 2010 at 8:32 PM, Robert Haas wrote: > Sure.  If you give the standbys names, then if people change the > names, they'll have to update their configuration.  But I can't see > that as an argument against doing it.  You can remove the possibility > that someone will have a hassle if t

Re: [HACKERS] lock_timeout GUC patch - Review

2010-08-02 Thread Boszormenyi Zoltan
Boszormenyi Zoltan írta: > Marc Cousin írta: > >> The Thursday 29 July 2010 13:55:38, Boszormenyi Zoltan wrote : >> >> >>> I fixed this by adding CheckLockTimeout() function that works like >>> CheckStatementTimeout() and ensuring that the same start time is >>> used for both deadlock_ti

Re: [HACKERS] Synchronous replication

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 7:06 AM, Fujii Masao wrote: > On Mon, Aug 2, 2010 at 7:53 PM, Robert Haas wrote: >> Let's not get *the manner of specifying the policy* confused with *the >> need to update the policy when the master changes*.  It doesn't seem >> likely you would want the same value for  sy

Re: [HACKERS] lock_timeout GUC patch - Review

2010-08-02 Thread Boszormenyi Zoltan
Marc Cousin írta: > The Thursday 29 July 2010 13:55:38, Boszormenyi Zoltan wrote : > >> I fixed this by adding CheckLockTimeout() function that works like >> CheckStatementTimeout() and ensuring that the same start time is >> used for both deadlock_timeout and lock_timeout if both are active. >>

Re: [HACKERS] Synchronous replication

2010-08-02 Thread Fujii Masao
On Mon, Aug 2, 2010 at 7:53 PM, Robert Haas wrote: > Let's not get *the manner of specifying the policy* confused with *the > need to update the policy when the master changes*.  It doesn't seem > likely you would want the same value for  synchronous_standbys on all > your machines.  In the most c

Re: [HACKERS] Postgres as Historian

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 3:20 AM, Hardik Belani wrote: > We are using postgres as RDBMS for our product. There is a requirement > coming for a feature which will require me to store data about various data > points (mainly numbers) on a time scale. Data measurement is being taken > every few secs/mi

Re: [HACKERS] Synchronous replication

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 5:02 AM, Fujii Masao wrote: > On Sun, Aug 1, 2010 at 9:51 PM, Robert Haas wrote: >> Perhaps someone will claim that nobody wants to do that anyway (which >> I don't believe, BTW), but even in simpler cases it would be nicer to >> have an explicit policy rather than - in eff

Re: [HACKERS] Synchronous replication

2010-08-02 Thread Fujii Masao
On Sun, Aug 1, 2010 at 9:51 PM, Robert Haas wrote: > Perhaps someone will claim that nobody wants to do that anyway (which > I don't believe, BTW), but even in simpler cases it would be nicer to > have an explicit policy rather than - in effect - inferring a policy > from a soup of GUC settings.  

Re: [HACKERS] Synchronous replication

2010-08-02 Thread Fujii Masao
On Sun, Aug 1, 2010 at 3:11 PM, Heikki Linnakangas wrote: > I don't think any of this quorum stuff makes much sense without explicitly > registering standbys in the master. I'm not sure if this is a good idea. This requires users to do more manual operations than ever when setting up the replicat

Re: [HACKERS] Initial review of xslt with no limits patch

2010-08-02 Thread Pavel Stehule
Hello 2010/8/2 Mike Fowler : > Hi Pavel, > > Currently your patch isn't applying to head, from the looks of things a > function signature has changed. Can you update your patch please? > yes - see attachment > Also, having had a read through the patch itself I note that there are no > tests and

Re: [HACKERS] english parser in text search: support for multiple words in the same position

2010-08-02 Thread Markus Wanner
Hi, On 08/01/2010 08:04 PM, Sushant Sinha wrote: 1. We do not have separate tokens "wikipedia" and "org" 2. If we have the two tokens we should have them at adjacent position so that a phrase search for "wikipedia org" should work. This would needlessly increase the number of tokens. Instead y

[HACKERS] Postgres as Historian

2010-08-02 Thread Hardik Belani
We are using postgres as RDBMS for our product. There is a requirement coming for a feature which will require me to store data about various data points (mainly numbers) on a time scale. Data measurement is being taken every few secs/mins based and it is needed to be stored for statistical analysi