Re: [HACKERS] array_length(anyarray)

2013-12-19 Thread David Fetter
On Wed, Dec 18, 2013 at 09:27:54PM +0100, Marko Tiikkaja wrote: Hi, Attached is a patch to add support for array_length(anyarray), which only works for one-dimensional arrays, returns 0 for empty arrays and complains if the array's lower bound isn't 1. In other words, does the right thing

Re: [HACKERS] array_length(anyarray)

2013-12-19 Thread Pavel Stehule
2013/12/19 David Fetter da...@fetter.org On Wed, Dec 18, 2013 at 09:27:54PM +0100, Marko Tiikkaja wrote: Hi, Attached is a patch to add support for array_length(anyarray), which only works for one-dimensional arrays, returns 0 for empty arrays and complains if the array's lower bound

Re: [HACKERS] GIN improvements part 1: additional information

2013-12-19 Thread Heikki Linnakangas
On 12/19/2013 08:37 AM, Oleg Bartunov wrote: Guys, before digging deep into the art of comp/decomp world I'd like to know if you familiar with results of http://wwwconference.org/www2008/papers/pdf/p387-zhangA.pdf paper and some newer research ? Yeah, I saw that paper. Do we agree in what

Re: [HACKERS] clang's -Wmissing-variable-declarations shows some shoddy programming

2013-12-19 Thread Andres Freund
Hi, On 2013-12-18 22:11:03 -0500, Bruce Momjian wrote: Now that pg_upgrade has stabilized, I think it is time to centralize all the pg_upgrade_support control variables in a single C include file that can be used by the backend and by pg_upgrade_support. This will eliminate the compiler

Re: [HACKERS] preserving forensic information when we freeze

2013-12-19 Thread Andres Freund
On 2013-12-18 21:42:25 -0500, Robert Haas wrote: On Wed, Dec 18, 2013 at 5:54 PM, Andres Freund and...@2ndquadrant.com wrote: if (frz-frzflags XLH_FREEZE_XVAC) + { HeapTupleHeaderSetXvac(tuple, FrozenTransactionId); + /* If we somehow haven't hinted

Re: [HACKERS] [PATCH] SQL assertions prototype

2013-12-19 Thread Florian Pflug
On Dec18, 2013, at 20:39 , Alvaro Herrera alvhe...@2ndquadrant.com wrote: Andres Freund wrote: On 2013-12-18 13:44:15 -0300, Alvaro Herrera wrote: Heikki Linnakangas wrote: Ah, I see. You don't need to block anyone else from modifying the table, you just need to block anyone else from

Re: [HACKERS] preserving forensic information when we freeze

2013-12-19 Thread Robert Haas
On Thu, Dec 19, 2013 at 5:44 AM, Andres Freund and...@2ndquadrant.com wrote: On 2013-12-18 21:42:25 -0500, Robert Haas wrote: On Wed, Dec 18, 2013 at 5:54 PM, Andres Freund and...@2ndquadrant.com wrote: if (frz-frzflags XLH_FREEZE_XVAC) + {

Re: SQL objects UNITs (was: [HACKERS] Extension Templates S03E11)

2013-12-19 Thread Robert Haas
On Wed, Dec 18, 2013 at 10:05 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Stephen Frost escribió: * Dimitri Fontaine (dimi...@2ndquadrant.fr) wrote: Basically with building `UNIT` we realise with hindsight that we failed to build a proper `EXTENSION` system, and we send that message

Re: [HACKERS] SQL objects UNITs

2013-12-19 Thread Andrew Dunstan
On 12/19/2013 08:01 AM, Robert Haas wrote: On Wed, Dec 18, 2013 at 10:05 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Stephen Frost escribió: * Dimitri Fontaine (dimi...@2ndquadrant.fr) wrote: Basically with building `UNIT` we realise with hindsight that we failed to build a proper

Re: SQL objects UNITs (was: [HACKERS] Extension Templates S03E11)

2013-12-19 Thread Cédric Villemain
Le jeudi 19 décembre 2013 14:01:17, Robert Haas a écrit : On Wed, Dec 18, 2013 at 10:05 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Stephen Frost escribió: * Dimitri Fontaine (dimi...@2ndquadrant.fr) wrote: Basically with building `UNIT` we realise with hindsight that we

Re: [HACKERS] GIN improvements part 1: additional information

2013-12-19 Thread Heikki Linnakangas
On 12/17/2013 12:49 AM, Heikki Linnakangas wrote: On 12/17/2013 12:22 AM, Alexander Korotkov wrote: On Mon, Dec 16, 2013 at 3:30 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 12/12/2013 06:44 PM, Alexander Korotkov wrote: When values are packed into small groups, we have to

Re: [HACKERS] pg_rewarm status

2013-12-19 Thread Amit Kapila
On Wed, Dec 18, 2013 at 8:33 PM, Robert Haas robertmh...@gmail.com wrote: On Tue, Dec 17, 2013 at 12:35 PM, Jeff Janes jeff.ja...@gmail.com wrote: All right, here is an updated patch. I swapped the second and third arguments, because I think overriding the prewarm mode will be a lot more

Re: [HACKERS] pg_rewarm status

2013-12-19 Thread Robert Haas
On Thu, Dec 19, 2013 at 8:37 AM, Amit Kapila amit.kapil...@gmail.com wrote: Few observations: 1. pg_prewarm.control +# pg_buffercache extension Wrong name. Oops. 2. +pg_prewarm(regclass, mode text default 'buffer', fork text default 'main', + first_block int8 default null, +

Re: [HACKERS] preserving forensic information when we freeze

2013-12-19 Thread Andres Freund
On 2013-12-19 07:40:40 -0500, Robert Haas wrote: On Thu, Dec 19, 2013 at 5:44 AM, Andres Freund and...@2ndquadrant.com wrote: On 2013-12-18 21:42:25 -0500, Robert Haas wrote: I dislike transporting the infomask in the wal record and then changing it away from that again afterwards.

Re: [HACKERS] pg_rewarm status

2013-12-19 Thread Andres Freund
On 2013-12-19 09:16:59 -0500, Robert Haas wrote: There's no uint32 type at the SQL level, and int32 is no good because it can't represent sufficiently large positive values to cover the largest possible block number. Well, pg_class.relpages is an int32, so I think that limit is already kind of

Re: [HACKERS] preserving forensic information when we freeze

2013-12-19 Thread Robert Haas
On Thu, Dec 19, 2013 at 9:19 AM, Andres Freund and...@2ndquadrant.com wrote: On 2013-12-19 07:40:40 -0500, Robert Haas wrote: On Thu, Dec 19, 2013 at 5:44 AM, Andres Freund and...@2ndquadrant.com wrote: On 2013-12-18 21:42:25 -0500, Robert Haas wrote: I dislike transporting the infomask

[HACKERS] Shouldn't IsBinaryCoercible accept targettype = ANYOID?

2013-12-19 Thread Tom Lane
Whilst fooling with the WITHIN GROUP patch, I noticed that IsBinaryCoercible() doesn't think that anything-to-ANY is a binary coercion. This was causing lookup_agg_function() to refuse to accept use of support functions declared as taking ANY in aggregates with more specific declared types. For

Re: [HACKERS] ALTER SYSTEM SET command to change postgresql.conf parameters

2013-12-19 Thread Fujii Masao
On Thu, Dec 19, 2013 at 2:21 PM, Tatsuo Ishii is...@postgresql.org wrote: I found that the psql tab-completion for ALTER SYSTEM SET has not been implemented yet. Attached patch does that. Barring any objections, I will commit this patch. Good catch! Committed. Regards, -- Fujii Masao --

Re: [HACKERS] -d option for pg_isready is broken

2013-12-19 Thread Fujii Masao
On Thu, Dec 12, 2013 at 4:48 AM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Wed, Dec 11, 2013 at 2:29 PM, Tom Lane t...@sss.pgh.pa.us wrote: More generally, if we do go over in 9.4 to the position that PQhost reports the host parameter and nothing but, I'm

Re: [HACKERS] Logging WAL when updating hintbit

2013-12-19 Thread Sawada Masahiko
On Thu, Dec 19, 2013 at 12:37 PM, Amit Kapila amit.kapil...@gmail.com wrote: On Wed, Dec 18, 2013 at 11:30 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Wed, Dec 18, 2013 at 11:22 AM, Amit Kapila amit.kapil...@gmail.com wrote: On Fri, Dec 13, 2013 at 7:57 PM, Heikki Linnakangas

Re: [HACKERS] pg_rewarm status

2013-12-19 Thread Cédric Villemain
Le jeudi 19 décembre 2013 03:08:59, Robert Haas a écrit : On Wed, Dec 18, 2013 at 6:07 PM, Cédric Villemain ced...@2ndquadrant.fr wrote: When the prefetch process starts up, it services requests from the queue by reading the requested blocks (or block ranges). When the queue is empty, it

Re: [HACKERS] pg_rewarm status

2013-12-19 Thread Jeff Janes
On Wed, Dec 18, 2013 at 6:08 PM, Robert Haas robertmh...@gmail.com wrote: Yeah, absolutely. The first backend that needs a prefetch probably isn't going to get it in time. I think that's OK though. Once the background process is started, response times will be quicker... although possibly

Re: [HACKERS] preserving forensic information when we freeze

2013-12-19 Thread Robert Haas
On Thu, Dec 19, 2013 at 9:37 AM, Robert Haas robertmh...@gmail.com wrote: On Thu, Dec 19, 2013 at 9:19 AM, Andres Freund and...@2ndquadrant.com wrote: On 2013-12-19 07:40:40 -0500, Robert Haas wrote: On Thu, Dec 19, 2013 at 5:44 AM, Andres Freund and...@2ndquadrant.com wrote: On 2013-12-18

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-12-19 Thread Bruce Momjian
On Thu, Dec 19, 2013 at 05:14:50AM +, Haribabu kommi wrote: On 19 December 2013 05:31 Bruce Momjian wrote: On Wed, Dec 11, 2013 at 10:22:32AM +, Haribabu kommi wrote: The make_absolute_path() function moving to port is changed in similar way as Bruce Momjian approach. The

Re: [HACKERS] gaussian distribution pgbench

2013-12-19 Thread Peter Geoghegan
On Thu, Nov 21, 2013 at 9:13 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: So what I'd actually like to see is \setgaussian, for use in custom scripts. +1. I'd really like to be able to run a benchmark with a Gaussian and uniform distribution side-by-side for comparative purposes - we

Re: [HACKERS] preserving forensic information when we freeze

2013-12-19 Thread Alvaro Herrera
Robert Haas escribió: I think it may have been a mistake to divide responsibility between the prepare and execute functions the way we did in this case, because it doesn't appear to be a clean separation of concerns. But it's not this patch's job to kibitz that decision, so this version just

Re: [HACKERS] FK locking concurrency improvement

2013-12-19 Thread Alvaro Herrera
Daniel Wood wrote: FYI, I saw some comments and adding fflush's into isolationtester.c. I ran into the same problem with debugging tests when they failed/hung in the middle. A simple setbuf(stdout, NULL) at the beginning of main gets rid of the problem where line buffering becomes block

Re: [HACKERS] clang's -Wmissing-variable-declarations shows some shoddy programming

2013-12-19 Thread Bruce Momjian
On Wed, Dec 18, 2013 at 10:11:03PM -0500, Bruce Momjian wrote: On Sat, Dec 14, 2013 at 04:52:28PM +0100, Andres Freund wrote: Hi, Compiling postgres with said option in CFLAGS really gives an astounding number of warnings. Except some bison/flex generated ones, none of them looks

Re: [HACKERS] clang's -Wmissing-variable-declarations shows some shoddy programming

2013-12-19 Thread Bruce Momjian
On Sat, Dec 14, 2013 at 04:52:28PM +0100, Andres Freund wrote: Hi, Compiling postgres with said option in CFLAGS really gives an astounding number of warnings. Except some bison/flex generated ones, none of them looks acceptable to me. Most are just file local variables with a missing

Re: [HACKERS] preserving forensic information when we freeze

2013-12-19 Thread Robert Haas
On Thu, Dec 19, 2013 at 3:36 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Robert Haas escribió: I think it may have been a mistake to divide responsibility between the prepare and execute functions the way we did in this case, because it doesn't appear to be a clean separation of

Re: [HACKERS] clang's -Wmissing-variable-declarations shows some shoddy programming

2013-12-19 Thread Kevin Grittner
Bruce Momjian br...@momjian.us wrote: I have fixed the binary_upgrade_* variables defines, and Heikki has fixed some other cases.  Can you rerun the test against git head and post the updated output?  Thanks. I'm now seeing the attached. -- Kevin Grittner EDB: http://www.enterprisedb.com The

Re: [HACKERS] gaussian distribution pgbench

2013-12-19 Thread Gavin Flower
On 20/12/13 09:36, Peter Geoghegan wrote: On Thu, Nov 21, 2013 at 9:13 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: So what I'd actually like to see is \setgaussian, for use in custom scripts. +1. I'd really like to be able to run a benchmark with a Gaussian and uniform distribution

Re: [HACKERS] clang's -Wmissing-variable-declarations shows some shoddy programming

2013-12-19 Thread Andres Freund
On 2013-12-19 14:56:38 -0800, Kevin Grittner wrote: Bruce Momjian br...@momjian.us wrote: I have fixed the binary_upgrade_* variables defines, and Heikki has fixed some other cases.  Can you rerun the test against git head and post the updated output?  Thanks. I'm now seeing the

[HACKERS] XML Issue with DTDs

2013-12-19 Thread Florian Pflug
Hi, While looking into ways to implement a XMLSTRIP function which extracts the textual contents of an XML value and de-escapes them (i.e. replaces entity references by their text equivalent), I've ran into another issue with the XML type. XML values can either contain a DOCUMENT or CONTENT.

Re: [HACKERS] gaussian distribution pgbench

2013-12-19 Thread Gregory Smith
On 12/19/13 5:52 PM, Gavin Flower wrote: Curious, wouldn't the common usage pattern tend to favour a skewed distribution, such as the Poisson Distribution (it has been over 40 years since I studied this area, so there may be better candidates). Some people like database load testing with a

Re: [HACKERS] preserving forensic information when we freeze

2013-12-19 Thread Jim Nasby
One thing users will lose in this patch is the ability to reliably see if a tuple is frozen via SQL. Today you can do that just by selecting xmin from the table. Obviously people don't generally need to do that... but it's one of those things that when you do need it it's incredibly handy to

Re: [HACKERS] row security roadmap proposal

2013-12-19 Thread Gregory Smith
On 12/18/13 10:21 PM, Craig Ringer wrote: In the end, sometimes I guess there's no replacement for WHERE call_some_procedure() That's where I keep ending up at. The next round of examples I'm reviewing this week plug pl/pgsql code into that model. And the one after that actually references

Re: [HACKERS] preserving forensic information when we freeze

2013-12-19 Thread Alvaro Herrera
Jim Nasby escribió: One thing users will lose in this patch is the ability to reliably see if a tuple is frozen via SQL. Today you can do that just by selecting xmin from the table. Obviously people don't generally need to do that... but it's one of those things that when you do need it

[HACKERS] Re: [bug fix] multibyte messages are displayed incorrectly on the client

2013-12-19 Thread Noah Misch
On Tue, Dec 17, 2013 at 01:42:08PM -0500, Bruce Momjian wrote: On Fri, Dec 13, 2013 at 10:41:17PM +0900, MauMau wrote: [Cause] While the session is being established, the server cannot use the client encoding for message conversion yet, because it cannot access system catalogs to retrieve

Re: [HACKERS] Proposed feature: Selective Foreign Keys

2013-12-19 Thread Gavin Wahl
This a great solution to this problem, one I've found to be very common in web development. The technique will work to add RI to Django's generic foreign keys[1], which are implemented with an id column and a type-flag column. [1]:

Re: [HACKERS] [PATCH] Doc fix for VACUUM FREEZE

2013-12-19 Thread Amit Kapila
On Wed, Dec 18, 2013 at 6:46 AM, Maciek Sakrejda m.sakre...@gmail.com wrote: VACUUM FREEZE sets both vacuum_freeze_min_age and vacuum_freeze_table_age to 0, but only the former is documented. This patch notes that the other setting is also affected. (now with patch--sorry about that) Your

Re: [HACKERS] Logging WAL when updating hintbit

2013-12-19 Thread Sawada Masahiko
On Fri, Dec 20, 2013 at 3:38 AM, Sawada Masahiko sawada.m...@gmail.com wrote: On Thu, Dec 19, 2013 at 12:37 PM, Amit Kapila amit.kapil...@gmail.com wrote: On Wed, Dec 18, 2013 at 11:30 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Wed, Dec 18, 2013 at 11:22 AM, Amit Kapila

Re: [HACKERS] Logging WAL when updating hintbit

2013-12-19 Thread Michael Paquier
On Fri, Dec 20, 2013 at 1:05 PM, Sawada Masahiko sawada.m...@gmail.com wrote: On Fri, Dec 20, 2013 at 3:38 AM, Sawada Masahiko sawada.m...@gmail.com wrote: On Thu, Dec 19, 2013 at 12:37 PM, Amit Kapila amit.kapil...@gmail.com wrote: On Wed, Dec 18, 2013 at 11:30 AM, Michael Paquier