[HACKERS] Mention in bgworker docs that db connection needs shmem access

2013-07-04 Thread Michael Paquier
Hi all, The bgworker documentation does not explicitely mention that a bgworker using BGWORKER_BACKEND_DATABASE_CONNECTION needs to have BGWORKER_SHMEM_ACCESS set as well. Just to mention, a bgworker using only db connection flag and not shmem flag will fail at atart-up with this error.

Re: [HACKERS] Review: Patch to compute Max LSN of Data Pages

2013-07-04 Thread Amit Kapila
On Wednesday, July 03, 2013 7:41 PM Robert Haas wrote: On Wed, Jul 3, 2013 at 9:51 AM, Amit Kapila amit.kap...@huawei.com wrote: amit@linux:~ md test amit@linux:~ cd test amit@linux:~/test ln -s ~/test link_test amit@linux:~/test ls link_test amit@linux:~/test cd link_test

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-07-04 Thread Michael Paquier
Hi, I noticed some errors in the comments of the patch committed. Please find attached a patch to correct that. Regards, -- Michael 20130704_reltoastidxid_comments.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] in-catalog Extension Scripts and Control parameters (templates?)

2013-07-04 Thread Jaime Casanova
On Mon, Jun 24, 2013 at 6:20 AM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Jaime Casanova ja...@2ndquadrant.com writes: just tried to build this one, but it doesn't apply cleanly anymore... specially the ColId_or_Sconst contruct in gram.y Please find attached a new version of the patch,

Re: [HACKERS] in-catalog Extension Scripts and Control parameters (templates?)

2013-07-04 Thread Jaime Casanova
On Thu, Jul 4, 2013 at 2:42 AM, Jaime Casanova ja...@2ndquadrant.com wrote: create extension test version '123'; CREATE EXTENSION postgres=# \df List of functions Schema | Name | Result data type | Argument data types | Type

Re: [HACKERS] request a new feature in fuzzystrmatch

2013-07-04 Thread Michael Paquier
Hi Liming, Here is a more formal review of this patch. First, when submitting a patch, please follow the following guidelines: http://wiki.postgresql.org/wiki/Submitting_a_Patch http://wiki.postgresql.org/wiki/Creating_Clean_Patches Particularly, when you develop a new feature, people will

Re: [HACKERS] Review: Patch to compute Max LSN of Data Pages

2013-07-04 Thread Hari Babu
On Wednesday, July 03, 2013 1:26 AM Robert Haas Wrote: On Tue, Jun 25, 2013 at 1:42 PM, Andres Freund and...@2ndquadrant.com wrote: I think the usecase for this utility isn't big enough to be included in postgres since it really can only help in a very limited circumstances. And I think it's

Re: [HACKERS] [9.4 CF 1] The Commitfest Slacker List

2013-07-04 Thread Mark Kirkwood
On 04/07/13 10:43, Robert Haas wrote: And people who submit patches for review should also review patches: they are asking other people to do work, so they should also contribute work. I think that is an overly simplistic view of things. People submit patches for a variety of reasons, but

Re: [HACKERS] Review: UNNEST (and other functions) WITH ORDINALITY

2013-07-04 Thread Dean Rasheed
On 4 July 2013 00:08, David Fetter da...@fetter.org wrote: Patch re-jiggered for recent changes to master. I re-validated this, and it all still looks good, so still ready for committer IMO. Regards, Dean -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] event trigger API documentation?

2013-07-04 Thread Dimitri Fontaine
Peter Eisentraut pete...@gmx.net writes: Applied with some tweaks. Thanks! There's a typo I made that I see only now: + varlistentry + termstructfieldtg_event//term I think that should be event, not tg_event, because we're listing the fields for the EventTriggerData structure and

Re: [HACKERS] possible/feasible to specify field and value in error msg?

2013-07-04 Thread Willy-Bas Loos
On Wed, Jul 3, 2013 at 5:18 PM, Bruce Momjian br...@momjian.us wrote: On Wed, Jul 3, 2013 at 11:14:18AM -0400, Bruce Momjian wrote: We will add optional error details in Postgres 9.3: http://momjian.us/main/blogs/pgblog/2013.html#April_11_2013 I just tested this and it doesn't

Re: [HACKERS] possible/feasible to specify field and value in error msg?

2013-07-04 Thread Pavel Stehule
Hello 2013/7/4 Willy-Bas Loos willy...@gmail.com: On Wed, Jul 3, 2013 at 5:18 PM, Bruce Momjian br...@momjian.us wrote: On Wed, Jul 3, 2013 at 11:14:18AM -0400, Bruce Momjian wrote: We will add optional error details in Postgres 9.3:

Re: [HACKERS] [PATCH] Add transforms feature

2013-07-04 Thread Hitoshi Harada
On Thu, Jun 13, 2013 at 8:11 PM, Peter Eisentraut pete...@gmx.net wrote: A transform is an SQL object that supplies to functions for converting between data types and procedural languages. For example, a transform could arrange that hstore is converted to an appropriate hash or dictionary

Re: [HACKERS] in-catalog Extension Scripts and Control parameters (templates?)

2013-07-04 Thread Hitoshi Harada
On Thu, Jul 4, 2013 at 12:46 AM, Jaime Casanova ja...@2ndquadrant.com wrote: On Thu, Jul 4, 2013 at 2:42 AM, Jaime Casanova ja...@2ndquadrant.com wrote: create extension test version '123'; CREATE EXTENSION postgres=# \df List of functions Schema | Name | Result

Re: [HACKERS] [PATCH] Add an ldapoption to disable chasing LDAP referrals

2013-07-04 Thread Magnus Hagander
On Thu, Jul 4, 2013 at 2:30 AM, James Sewell james.sew...@lisasoft.comwrote: Heya, I see what you are saying, the problem as I see it is that the action we are taking here is disable chasing ldap referrals. If the name is ldapreferrals and we use a boolean then setting it to 1 reads in a

Re: [HACKERS] [9.3 bug fix] ECPG does not escape backslashes

2013-07-04 Thread Michael Meskes
On Wed, Jul 03, 2013 at 07:22:48PM +0900, MauMau wrote: I happened to find a trivial bug of ECPG while experimenting with 9.3 beta 2. Please find attached the patch to fix this. This is not specific to 9.3. Could you commit and backport this? This appears to be Windows specific. I don't

Re: [HACKERS] [9.3 bug fix] ECPG does not escape backslashes

2013-07-04 Thread Andrew Dunstan
On 07/04/2013 07:04 AM, Michael Meskes wrote: On Wed, Jul 03, 2013 at 07:22:48PM +0900, MauMau wrote: I happened to find a trivial bug of ECPG while experimenting with 9.3 beta 2. Please find attached the patch to fix this. This is not specific to 9.3. Could you commit and backport this?

Re: [HACKERS] Improvement of checkpoint IO scheduler for stable transaction responses

2013-07-04 Thread KONDO Mitsumasa
(2013/07/03 22:31), Robert Haas wrote: On Wed, Jul 3, 2013 at 4:18 AM, KONDO Mitsumasa kondo.mitsum...@lab.ntt.co.jp wrote: I tested and changed segsize=0.25GB which is max partitioned table file size and default setting is 1GB in configure option (./configure --with-segsize=0.25). Because I

Re: [HACKERS] [9.3 bug fix] ECPG does not escape backslashes

2013-07-04 Thread Michael Meskes
On Thu, Jul 04, 2013 at 07:58:39AM -0400, Andrew Dunstan wrote: michael@feivel:~$ grep line testa/init.c |head -1 #line 1 test\\a/init.pgc ... Really? I'd expect to see 4 backslashes in the #line directive, I think. Eh, why? The four backslashes come are two that are escaped for shell

Re: [HACKERS] in-catalog Extension Scripts and Control parameters (templates?)

2013-07-04 Thread Dimitri Fontaine
Hi, Please find attached version 8 of the patch, with fixes for almost all reported problems. Thanks a lot to you reviewers for finding them! I need some help with: - toast tables for new catalog tables - extension.c:1150:25: warning: variable ‘evi’ set but not used See details below.

[HACKERS] Grouping Sets

2013-07-04 Thread Dev Kumkar
http://www.postgresql.org/list/pgsql-hackers/since/200905171950Hello, Am looking for the patch related to 'Implementation of GROUPING SETS'. Where can get this from? Related thread: http://www.postgresql.org/message-id/162867790905121420p7c910054x24d8e327abd58...@mail.gmail.com Regards...

Re: [HACKERS] [9.3 bug fix] ECPG does not escape backslashes

2013-07-04 Thread Andrew Dunstan
On 07/04/2013 08:31 AM, Michael Meskes wrote: On Thu, Jul 04, 2013 at 07:58:39AM -0400, Andrew Dunstan wrote: michael@feivel:~$ grep line testa/init.c |head -1 #line 1 test\\a/init.pgc ... Really? I'd expect to see 4 backslashes in the #line directive, I think. Eh, why? The four

Re: [HACKERS] [9.3 bug fix] ECPG does not escape backslashes

2013-07-04 Thread Andres Freund
On 2013-07-04 08:50:34 -0400, Andrew Dunstan wrote: On 07/04/2013 08:31 AM, Michael Meskes wrote: On Thu, Jul 04, 2013 at 07:58:39AM -0400, Andrew Dunstan wrote: michael@feivel:~$ grep line testa/init.c |head -1 #line 1 test\\a/init.pgc ... Really? I'd expect to see 4 backslashes in

Re: [HACKERS] Grouping Sets

2013-07-04 Thread Pavel Stehule
Hello 2013/7/4 Dev Kumkar devdas.kum...@gmail.com: Hello, Am looking for the patch related to 'Implementation of GROUPING SETS'. Where can get this from? Related thread: http://www.postgresql.org/message-id/162867790905121420p7c910054x24d8e327abd58...@mail.gmail.com I don't work on this

Re: [HACKERS] Improvement of checkpoint IO scheduler for stable transaction responses

2013-07-04 Thread Andres Freund
On 2013-07-04 21:28:11 +0900, KONDO Mitsumasa wrote: That would move all the vm and fsm forks to separate directories, which would cut down the number of files in the main-fork directory significantly. That might be worth doing independently of the issue you're raising here. For large

Re: [HACKERS] [9.4 CF 1] The Commitfest Slacker List

2013-07-04 Thread Bruce Momjian
On Wed, Jul 3, 2013 at 03:34:06PM -0700, Josh Berkus wrote: On 07/03/2013 03:08 PM, Robert Haas wrote: You are way out of line. You have no right to expect ANYONE to participate in patch review and commit. Michael is doing us a favor by maintaining ECPG even though he's not heavily

Re: [HACKERS] [PATCH] Remove useless USE_PGXS support in contrib

2013-07-04 Thread Cédric Villemain
Le mercredi 3 juillet 2013 23:56:42, Josh Berkus a écrit : Peter, Cedric, etc.: Where are we on this patch? Seems like discussion died out. Should it be bounced? I for myself have been presuaded that it is a good idea. Things apparently loosed are not, it just outline that we need better

Re: [HACKERS] [9.3 bug fix] ECPG does not escape backslashes

2013-07-04 Thread Andrew Dunstan
On 07/04/2013 08:58 AM, Andres Freund wrote: On 2013-07-04 08:50:34 -0400, Andrew Dunstan wrote: On 07/04/2013 08:31 AM, Michael Meskes wrote: On Thu, Jul 04, 2013 at 07:58:39AM -0400, Andrew Dunstan wrote: michael@feivel:~$ grep line testa/init.c |head -1 #line 1 test\\a/init.pgc ...

Re: [HACKERS] Bugfix and new feature for PGXS

2013-07-04 Thread Cédric Villemain
I'm not sure whether this is as simple as changing $ to $^ in the pgxs.mk's installcontrol rule, or if something more is required. Could you take a look? will do. ah yes, good catch, I though .control file were unique per contrib, but there aren't. -- Cédric Villemain +33 (0)6 20 30

Re: [HACKERS] [9.3 bug fix] ECPG does not escape backslashes

2013-07-04 Thread Andres Freund
On 2013-07-04 09:12:37 -0400, Andrew Dunstan wrote: On 07/04/2013 08:58 AM, Andres Freund wrote: On 2013-07-04 08:50:34 -0400, Andrew Dunstan wrote: On 07/04/2013 08:31 AM, Michael Meskes wrote: On Thu, Jul 04, 2013 at 07:58:39AM -0400, Andrew Dunstan wrote: michael@feivel:~$ grep line

Re: [HACKERS] [9.4 CF 1] The Commitfest Slacker List

2013-07-04 Thread Andrew Dunstan
On 07/04/2013 09:09 AM, Bruce Momjian wrote: On Wed, Jul 3, 2013 at 03:34:06PM -0700, Josh Berkus wrote: On 07/03/2013 03:08 PM, Robert Haas wrote: You are way out of line. You have no right to expect ANYONE to participate in patch review and commit. Michael is doing us a favor by

Re: [HACKERS] [9.4 CF 1] The Commitfest Slacker List

2013-07-04 Thread Bruce Momjian
On Thu, Jul 4, 2013 at 09:16:22AM -0400, Andrew Dunstan wrote: On 07/04/2013 09:09 AM, Bruce Momjian wrote: On Wed, Jul 3, 2013 at 03:34:06PM -0700, Josh Berkus wrote: On 07/03/2013 03:08 PM, Robert Haas wrote: You are way out of line. You have no right to expect ANYONE to participate in

Re: [HACKERS] Bugfix and new feature for PGXS

2013-07-04 Thread Andrew Dunstan
On 07/04/2013 09:14 AM, Cédric Villemain wrote: I'm not sure whether this is as simple as changing $ to $^ in the pgxs.mk's installcontrol rule, or if something more is required. Could you take a look? will do. ah yes, good catch, I though .control file were unique per contrib,

Re: [HACKERS] Grouping Sets

2013-07-04 Thread Dev Kumkar
On Thu, Jul 4, 2013 at 6:31 PM, Pavel Stehule pavel.steh...@gmail.comwrote: Hello I don't work on this topic now, and my code is not usable for production. Ok, no problem. Will await for any other pointers regarding any related patch here. Currently using UNION to archive similar results

Re: [HACKERS] [9.3 bug fix] ECPG does not escape backslashes

2013-07-04 Thread Michael Meskes
On Thu, Jul 04, 2013 at 03:18:12PM +0200, Andres Freund wrote: Previous versions of CPP did not interpret escapes in ‘#line’; we have changed it because the standard requires they be interpreted, and most other compilers do.« So that means MauMau was right and backslashes have to be escaped in

Re: [HACKERS] Grouping Sets

2013-07-04 Thread Atri Sharma
On Thu, Jul 4, 2013 at 6:56 PM, Dev Kumkar devdas.kum...@gmail.com wrote: On Thu, Jul 4, 2013 at 6:31 PM, Pavel Stehule pavel.steh...@gmail.com wrote: Hello I don't work on this topic now, and my code is not usable for production. Ok, no problem. Will await for any other pointers

Re: [HACKERS] event trigger API documentation?

2013-07-04 Thread Peter Eisentraut
On Thu, 2013-07-04 at 10:15 +0200, Dimitri Fontaine wrote: There's a typo I made that I see only now: + varlistentry + termstructfieldtg_event//term Fixed. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] in-catalog Extension Scripts and Control parameters (templates?)

2013-07-04 Thread Jaime Casanova
On Thu, Jul 4, 2013 at 7:32 AM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: - In alter.c you made AlterObjectRename_internal non static and replaced a SearchSysCache1 call with a get_catalog_object_by_oid one. Now, in its comment that function says that is for simple cases. And because of

Re: [HACKERS] Mention in bgworker docs that db connection needs shmem access

2013-07-04 Thread Robert Haas
On Thu, Jul 4, 2013 at 2:01 AM, Michael Paquier michael.paqu...@gmail.com wrote: Hi all, The bgworker documentation does not explicitely mention that a bgworker using BGWORKER_BACKEND_DATABASE_CONNECTION needs to have BGWORKER_SHMEM_ACCESS set as well. Just to mention, a bgworker using only

Re: [HACKERS] Improvement of checkpoint IO scheduler for stable transaction responses

2013-07-04 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: I don't like going in this direction at all: 1) it breaks pg_upgrade. Which means many of the bigger users won't be able to migrate to this and most packagers would carry the old segsize around forever. Even if we could get pg_upgrade to

Re: [HACKERS] Improvement of checkpoint IO scheduler for stable transaction responses

2013-07-04 Thread Joshua D. Drake
On 07/04/2013 06:05 AM, Andres Freund wrote: Presumably the smaller segsize is better because we don't completely stall the system by submitting up to 1GB of io at once. So, if we were to do it in 32MB chunks and then do a final fsync() afterwards we might get most of the benefits. Yes, I try

Re: [HACKERS] [9.4 CF 1] The Commitfest Slacker List

2013-07-04 Thread Noah Misch
On Thu, Jul 04, 2013 at 08:08:57PM +1200, Mark Kirkwood wrote: On 04/07/13 10:43, Robert Haas wrote: And people who submit patches for review should also review patches: they are asking other people to do work, so they should also contribute work. I think that is an overly simplistic view

Re: [HACKERS] request a new feature in fuzzystrmatch

2013-07-04 Thread Robert Haas
On Thu, Jul 4, 2013 at 3:59 AM, Michael Paquier michael.paqu...@gmail.com wrote: 5) Your code copies a function from TOMOYO Linux, which is under GPL2 license, so I believe that this cannot be integrated to Postgres which is under PostgreSQL license (more permissive). Just based on that some

Re: [HACKERS] Review: Patch to compute Max LSN of Data Pages

2013-07-04 Thread Robert Haas
On Thu, Jul 4, 2013 at 2:14 AM, Amit Kapila amit.kap...@huawei.com wrote: It can cause error too many levels of symbolic links Sure, so you report the error and exit. No problem. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via

Re: [HACKERS] LATERAL quals revisited

2013-07-04 Thread Antonin Houska
On 07/03/2013 08:32 PM, Tom Lane wrote: Another possibility would be to keep the optimization, but disable it in queries that use LATERAL. I don't much care for that though --- seems too Rube Goldbergish, and in any case I have a lot less faith in the whole concept now than I had before I

Re: [HACKERS] strange IS NULL behaviour

2013-07-04 Thread Bruce Momjian
On Mon, Nov 26, 2012 at 09:29:19PM +0100, Hannu Krosing wrote: On 11/26/2012 09:05 PM, Tom Lane wrote: Hannu Krosing ha...@2ndquadrant.com writes: In some previous mail Tom Lane claimed that by SQL standard either an array of all NULLs or a record with all fields NULLs (I don't remember

Re: [HACKERS] Review: Patch to compute Max LSN of Data Pages

2013-07-04 Thread Robert Haas
This looks better. + fprintf(stderr, _(%s: .. file \%s\ for seeking: %s\n), + progname, filename, strerror(errno)); Weird error message style - what's with the ..? + fprintf(stderr, _(%s: .. file \%s\ length is more than segment size:

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-07-04 Thread Fujii Masao
On Thu, Jul 4, 2013 at 3:38 PM, Michael Paquier michael.paqu...@gmail.com wrote: Hi, I noticed some errors in the comments of the patch committed. Please find attached a patch to correct that. Committed. Thanks! Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list

Re: [HACKERS] [PATCH] big test separation POC

2013-07-04 Thread Fabien COELHO
+serial_%: parallel_% + echo # this file is generated automatically, do not edit! $@ + egrep '^(test|ignore):' $ | \ + while read op list ; do \ + for test in $$list ; do \ + echo $$op $$test ; \ + done ; \ + done $@ + This won't work on

Re: [HACKERS] strange IS NULL behaviour

2013-07-04 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: I developed the attached patch which properly recurses into ROW() records checking for NULLs; you can see it returns the right answer in all cases (and constant folds too): My recollection of the previous discussion is that we didn't have consensus on

Re: [HACKERS] strange IS NULL behaviour

2013-07-04 Thread Alvaro Herrera
Tom Lane wrote: My recollection of the previous discussion is that we didn't have consensus on what the right behavior is, so I'm not sure you can just assert that this patch is right. In any case this is only touching the tip of the iceberg. If we intend that rows of nulls should be null,

Re: [HACKERS] GSOC13 proposal - extend RETURNING syntax

2013-07-04 Thread Karol Trzcionka
Hello, according to my mentor's suggestion, I send first PoC patch of RETURNING AFTER/BEFORE statement. Some info: - it is early version - more hack PoC than RC patch - AFTER in this version works as decribed before but it returns row after update but before post-update before (to be fixed or

[HACKERS] Proposal - Support for National Characters functionality

2013-07-04 Thread Arulappan, Arul Shaji
This is a proposal to implement functionalities for the handling of National Characters. [Introduction] The aim of this proposal is to eventually have a way to represent 'National Characters' in a uniform way, even in non-UTF8 encoded databases. Many of our customers in the Asian region who are

Re: [HACKERS] Grouping Sets

2013-07-04 Thread Dev Kumkar
On Thu, Jul 4, 2013 at 7:53 PM, Atri Sharma atri.j...@gmail.com wrote: On Thu, Jul 4, 2013 at 6:56 PM, Dev Kumkar devdas.kum...@gmail.com wrote: Ok, no problem. Will await for any other pointers regarding any related patch here. Currently using UNION to archive similar results but

[HACKERS] [COMMITTERS] pgsql: Add new GUC, max_worker_processes, limiting number of bgworkers.

2013-07-04 Thread Kevin Hale Boyes
The change to config.sgml contains a small typo with the double r in the xreflabel. + varlistentry id=guc-max-worker-processes xreflabel=max_worrker_processes

Re: [HACKERS] Proposal - Support for National Characters functionality

2013-07-04 Thread Tatsuo Ishii
Arul Shaji, NCHAR support is on our TODO list for some time and I would like to welcome efforts trying to implement it. However I have a few questions: This is a proposal to implement functionalities for the handling of National Characters. [Introduction] The aim of this proposal is to

Re: [HACKERS] Proposal - Support for National Characters functionality

2013-07-04 Thread Claudio Freire
On Fri, Jul 5, 2013 at 2:02 AM, Tatsuo Ishii is...@postgresql.org wrote: - Support for NATIONAL_CHARACTER_SET GUC variable that will determine the encoding that will be used in NCHAR/NVARCHAR columns. You said NCHAR's encoding is UTF-8. Why do you need the GUC if NCHAR's encoding is fixed to