Re: [HACKERS] Parallel Seq Scan

2015-09-25 Thread Amit Kapila
On Sat, Sep 26, 2015 at 5:54 AM, Robert Haas wrote: > > On Fri, Sep 25, 2015 at 12:55 AM, Amit Kapila wrote: > > > Yes, the patch needs more work in terms of dealing with parallel-restricted > > expressions/functions. One idea which I have

Re: [HACKERS] cluster_name and update_process_title documentation

2015-09-25 Thread Tom Lane
Peter Eisentraut writes: > The related settings cluster_name and update_process_title have somehow > ended up at opposite corners of the documentation and sample files. I > propose to group them together in a new "Process Title" section, as in > the attached patch. I think you

Re: [HACKERS] [COMMITTERS] pgsql: Fix an O(N^2) problem in foreign key references.

2015-09-25 Thread Tom Lane
Jan Wieck writes: > On 09/18/2015 10:47 AM, Tom Lane wrote: >> Attached is something closer to what I was envisioning; can you do >> performance testing on it? > Yes, that patch also has the desired performance for restoring a schema > with hundreds of thousands of foreign key

Re: [HACKERS] No Issue Tracker - Say it Ain't So!

2015-09-25 Thread Joshua D. Drake
Hello, I accidently sent this directly to TGL so here we go: Hello, I am pretty sure RT can do what I am about to suggest but I know Redmine can do it. Consider the following situation: Robert Haas posts: Parallelized Joins patch New issue is created (via email) Patch is

Re: [HACKERS] WIP: Rework access method interface

2015-09-25 Thread Alvaro Herrera
Teodor Sigaev wrote: > >I'm OK about continuing work on amvalidate if we can build consuensus on its > >design. > >Could you give some feedback on amvalidate version of patch please? > >http://www.postgresql.org/message-id/capphfds8zywenz9vw6te5rzxbol1vu_wsw181veq+mu+v1d...@mail.gmail.com > > In

Re: [HACKERS] Less than ideal error reporting in pg_stat_statements

2015-09-25 Thread Marti Raudsepp
On Wed, Sep 23, 2015 at 3:01 AM, Peter Geoghegan wrote: > I think that the real problem here is that garbage collection needs to > deal with OOM more appropriately. +1 I've also been seeing lots of log messages saying "LOG: out of memory" on a server that's hosting development

Re: [HACKERS] WIP: Rework access method interface

2015-09-25 Thread Alexander Korotkov
On Fri, Sep 25, 2015 at 6:25 PM, Tom Lane wrote: > Petr Jelinek writes: > > On 2015-09-25 16:11, Teodor Sigaev wrote: > >> In attach a bit modified patch based on 4-th version, and if there are > >> no strong objections, I will commit it. Waiting this

Re: [HACKERS] WIP: Rework access method interface

2015-09-25 Thread Petr Jelinek
On 2015-09-25 16:11, Teodor Sigaev wrote: I'm OK about continuing work on amvalidate if we can build consuensus on its design. Could you give some feedback on amvalidate version of patch please?

Re: [HACKERS] WIP: Rework access method interface

2015-09-25 Thread Tom Lane
Petr Jelinek writes: > On 2015-09-25 16:11, Teodor Sigaev wrote: >> In attach a bit modified patch based on 4-th version, and if there are >> no strong objections, I will commit it. Waiting this patch stops >> Alexander's development on CREATE ACCESS METHOD and he needs to

Re: [HACKERS] No Issue Tracker - Say it Ain't So!

2015-09-25 Thread Simon Riggs
On 24 September 2015 at 12:16, Tom Lane wrote: > I promised myself I'd stay out of this discussion, but ... > > Josh Berkus writes: > > I know we're big on reinventing the wheel here, but it would really be a > > better idea to use an established product

Re: [HACKERS] pageinspect patch, for showing tuple data

2015-09-25 Thread Nikolay Shaplov
В письме от 11 сентября 2015 15:12:04 пользователь Michael Paquier написал: > > Ok.Let's come to the final decision with tuple_data_parse, and i will add > > this switch there and to pure sql heap_page_item_attrs > > Fine for me. Here is final version with documentation. Hope it will be the

Re: [HACKERS] No Issue Tracker - Say it Ain't So!

2015-09-25 Thread Joshua D. Drake
On 09/25/2015 09:55 AM, Joe Conway wrote: On 09/25/2015 09:32 AM, Tom Lane wrote: 2. There's no visibility for outsiders as to what issues are open or recently fixed. Not being outsiders, I'm not sure that we are terribly well qualified to describe this problem precisely or identify a good

Re: [HACKERS] On-demand running query plans using auto_explain and signals

2015-09-25 Thread Shulgin, Oleksandr
On Fri, Sep 18, 2015 at 7:04 PM, Robert Haas wrote: > > Frankly, I think you guys are making this out to be way more > complicated than it really is. Basically, I think the process being > queried should publish a DSM via a slot it owns. The recipient is > responsible

Re: [HACKERS] How to get value of 'Param' of the WHERE clause in the FDW?

2015-09-25 Thread Tom Lane
Dmitry Chichkov writes: > Evaluate via ExecEvalExpr, right? Yeah. > And sorry for a beginner question, > what do I need to do to get that Expr from ForeignScanState?Is it > accessible at all in old 9.1 API? I think you're out of luck before 9.2. There's no provision

[HACKERS] Re: Reusing abbreviated keys during second pass of ordered [set] aggregates

2015-09-25 Thread Jeff Janes
This needs a rebase, there are several conflicts in src/backend/executor/nodeAgg.c Thanks, Jeff -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] No Issue Tracker - Say it Ain't So!

2015-09-25 Thread Joe Conway
On 09/25/2015 09:32 AM, Tom Lane wrote: > 2. There's no visibility for outsiders as to what issues are open or > recently fixed. Not being outsiders, I'm not sure that we are terribly > well qualified to describe this problem precisely or identify a good > solution --- but I grant that there's a

Re: [HACKERS] No Issue Tracker - Say it Ain't So!

2015-09-25 Thread Joshua D. Drake
On 09/25/2015 10:27 AM, Simon Riggs wrote: 2. There's no visibility for outsiders as to what issues are open or recently fixed. Not being outsiders, I'm not sure that we are terribly well qualified to describe this problem precisely or identify a good solution --- but I grant

Re: [HACKERS] upcoming infrastructure changes/OS upgrades on *.postgresql.org

2015-09-25 Thread Tom Lane
Stefan Kaltenbrunner writes: > yeah the point about 9.0.x is a very good one - so I think we will > target mid/end of october for borka so we get a bit of time to deal with > any fallout from the release (if needed). Sounds like a plan. > We could target the same

Re: [HACKERS] How to get value of 'Param' of the WHERE clause in the FDW?

2015-09-25 Thread Tom Lane
Dmitry Chichkov writes: > Thank you for the reply! I'm trying to get the correct value and I need it > at the execution stage. I just don't see how to get baserestrictinfo in > the execution stage or if the 'abc123' value would be there at all... Hm? At execution, you'd

Re: [HACKERS] No Issue Tracker - Say it Ain't So!

2015-09-25 Thread Merlin Moncure
On Fri, Sep 25, 2015 at 11:32 AM, Tom Lane wrote: > Simon Riggs writes: >> I have frequently been the agent of change in matters of process, but I see >> no useful change here, just lots of wasted time. But then why are we even >> talking about change?

Re: [HACKERS] Less than ideal error reporting in pg_stat_statements

2015-09-25 Thread Peter Geoghegan
On Fri, Sep 25, 2015 at 11:37 AM, Peter Geoghegan wrote: >> So, as I understand it: if the system runs low on memory for an >> extended period, and/or the file grows beyond 1GB (MaxAlloc), garbage >> collection stops entirely, meaning it starts leaking disk space until >> a

Re: [HACKERS] Less than ideal error reporting in pg_stat_statements

2015-09-25 Thread Peter Geoghegan
On Tue, Sep 22, 2015 at 6:01 PM, Peter Geoghegan wrote: > I'm doubtful that this had anything to do with MaxAllocSize. You'd > certainly need a lot of bloat to be affected by that in any way. I > wonder how high pg_stat_statements.max was set to on this system, and > how long

Re: [HACKERS] upcoming infrastructure changes/OS upgrades on *.postgresql.org

2015-09-25 Thread Stefan Kaltenbrunner
On 09/25/2015 08:53 PM, Andres Freund wrote: > On 2015-09-25 20:47:21 +0200, Stefan Kaltenbrunner wrote: >> yeah the point about 9.0.x is a very good one - so I think we will >> target mid/end of october for borka so we get a bit of time to deal with >> any fallout from the release (if needed). >>

Re: [HACKERS] How to get value of 'Param' of the WHERE clause in the FDW?

2015-09-25 Thread Dmitry Chichkov
Evaluate via ExecEvalExpr, right? And sorry for a beginner question, what do I need to do to get that Expr from ForeignScanState?Is it accessible at all in old 9.1 API? I see code that is getting exec_exprs from ForeignScan *node: ForeignScan *fsplan = (ForeignScan *)node->ss.ps.plan;

Re: [HACKERS] How to get value of 'Param' of the WHERE clause in the FDW?

2015-09-25 Thread Dmitry Chichkov
Thank you for the reply! I'm trying to get the correct value and I need it at the execution stage. I just don't see how to get baserestrictinfo in the execution stage or if the 'abc123' value would be there at all... Kind regards, Dmitry On Fri, Sep 25, 2015 at 11:44 AM, Tom Lane

Re: [HACKERS] upcoming infrastructure changes/OS upgrades on *.postgresql.org

2015-09-25 Thread Andres Freund
On 2015-09-25 20:47:21 +0200, Stefan Kaltenbrunner wrote: > yeah the point about 9.0.x is a very good one - so I think we will > target mid/end of october for borka so we get a bit of time to deal with > any fallout from the release (if needed). > > We could target the same timeframe for gemulon,

Re: [HACKERS] [PATCH] postgres_fdw extension support

2015-09-25 Thread Paul Ramsey
Back from summer and conferencing, and finally responding, sorry for the delay... On Thu, Aug 20, 2015 at 6:01 PM, Michael Paquier wrote: > > > if (needlabel) > appendStringInfo(buf, "::%s", > - > format_type_with_typemod(node->consttype, > - >

Re: [HACKERS] No Issue Tracker - Say it Ain't So!

2015-09-25 Thread Tom Lane
Simon Riggs writes: > I have frequently been the agent of change in matters of process, but I see > no useful change here, just lots of wasted time. But then why are we even > talking about change? What thing is broken that needs to be fixed? Why is > adopting a new package

Re: [HACKERS] pageinspect patch, for showing tuple data

2015-09-25 Thread Nikolay Shaplov
В письме от 25 сентября 2015 20:59:29 пользователь Michael Paquier написал: > > Here is final version with documentation. > > Thanks! I just had a short look at it: > - I am not convinced that it is worth declaring 3 versions of > tuple_data_split. How which of them should we leave? > - The

Re: [HACKERS] [COMMITTERS] pgsql: Fix an O(N^2) problem in foreign key references.

2015-09-25 Thread Alvaro Herrera
Tom Lane wrote: > Jan Wieck writes: > > Attached is a complete rework of the fix from scratch, based on Tom's > > suggestion. > > > The code now maintains a double linked list as suggested, but only uses > > it to mark all currently valid entries as invalid when hashvalue ==

Re: [HACKERS] No Issue Tracker - Say it Ain't So!

2015-09-25 Thread Tom Lane
Joe Conway writes: > On 09/25/2015 09:32 AM, Tom Lane wrote: >> I do not know how much emphasis the project should place on point #2. >> By definition, fixing that will not return any direct benefit to us. > I would argue that there is some benefit for us in terms of

Re: [HACKERS] upcoming infrastructure changes/OS upgrades on *.postgresql.org

2015-09-25 Thread Tom Lane
Stefan Kaltenbrunner writes: > * borka.postgresql.org - official tarball and docs build server, the > upgrade will upgrade the toolchain on that box to the respective > versions of what is in jessie. If people think it is necessarily to > (double)check the effects

Re: [HACKERS] Doubt in pgbench TPS number

2015-09-25 Thread Fabien COELHO
Hello Tatsuo, Hmmm... I never use -C. The formula seems ok: tps_exclude = normal_xacts / (time_include - (INSTR_TIME_GET_DOUBLE(conn_total_time) / nthreads)); Hmmm... it is not:-) I think that the degree of parallelism to consider is nclients, not nthreads: while

Re: [HACKERS] No Issue Tracker - Say it Ain't So!

2015-09-25 Thread Simon Riggs
On 25 September 2015 at 11:55, Joe Conway wrote: > On 09/25/2015 09:32 AM, Tom Lane wrote: > > 2. There's no visibility for outsiders as to what issues are open or > > recently fixed. Not being outsiders, I'm not sure that we are terribly > > well qualified to describe this

Re: [HACKERS] No Issue Tracker - Say it Ain't So!

2015-09-25 Thread Simon Riggs
On 25 September 2015 at 11:32, Tom Lane wrote: > Simon Riggs writes: > > I have frequently been the agent of change in matters of process, but I > see > > no useful change here, just lots of wasted time. But then why are we even > > talking about

Re: [HACKERS] No Issue Tracker - Say it Ain't So!

2015-09-25 Thread Jeff Janes
On Wed, Sep 23, 2015 at 2:14 PM, Alvaro Herrera wrote: > Jeff Janes wrote: > > > > I'd rather, say, put some more work into cleaning the kruft out of the > > To-Do list, then put that effort into migrating the kruft to a fancier > > filing cabinet. > > Casual users

Re: [HACKERS] [COMMITTERS] pgsql: Fix an O(N^2) problem in foreign key references.

2015-09-25 Thread Tom Lane
Alvaro Herrera writes: > Would it make sense to remove the only the few oldest entries, instead > of all of them? As is, I think this causes a storm of reloads every > once in a while, if the number of FKs in the system is large enough. > Maybe on a cache hit we could

Re: [HACKERS] [COMMITTERS] pgsql: Fix an O(N^2) problem in foreign key references.

2015-09-25 Thread Tom Lane
I wrote: > Alvaro Herrera writes: >> Would it make sense to remove the only the few oldest entries, instead >> of all of them? As is, I think this causes a storm of reloads every >> once in a while, if the number of FKs in the system is large enough. >> Maybe on a cache

Re: [HACKERS] upcoming infrastructure changes/OS upgrades on *.postgresql.org

2015-09-25 Thread Andres Freund
On 2015-09-25 20:11:32 +0200, Stefan Kaltenbrunner wrote: > no date set yet though > * gemulon.postgresql.org - gitmaster.postgresql, master git repository > (we will likely coordinate this internally so that somebody on the team > with a commit bit will test after the upgrade) I'm pretty sure

Re: [HACKERS] Less than ideal error reporting in pg_stat_statements

2015-09-25 Thread Peter Geoghegan
On Fri, Sep 25, 2015 at 8:51 AM, Marti Raudsepp wrote: > I've also been seeing lots of log messages saying "LOG: out of > memory" on a server that's hosting development databases. I put off > debugging this until now because it didn't seem to have any adverse > effects on the

Re: [HACKERS] How to get value of 'Param' of the WHERE clause in the FDW?

2015-09-25 Thread Tom Lane
Dmitry Chichkov writes: > It seems like during fdwPlan(..., RelOptInfo *baserel) stage I'm getting > baserel->baserestrictinfo, in which I see a Node *x of IsA(x, Param). > But it looks like the value 'abc123' is not yet available in the planning > stage, right? And I

Re: [HACKERS] No Issue Tracker - Say it Ain't So!

2015-09-25 Thread Joshua D. Drake
On 09/25/2015 10:11 AM, Simon Riggs wrote: > > I do not know how much emphasis the project should place on point #2. > By definition, fixing that will not return any direct benefit to us. I would argue that there is some benefit for us in terms of advocacy. There are also some

[HACKERS] upcoming infrastructure changes/OS upgrades on *.postgresql.org

2015-09-25 Thread Stefan Kaltenbrunner
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all! As part of our regular maintenance schedule and in our continous effort to run our systems on current and fully supported operating systems the postgresql sysadmin has started upgrading the OS on our infrastructure hosts from Debian

[HACKERS] How to get value of 'Param' of the WHERE clause in the FDW?

2015-09-25 Thread Dmitry Chichkov
Please help I'm doing a following query to a foreign wrapper: FUNCTION fwcall(text) SELECT * FROM fwtable WHERE col=$1 ; ... SELECT * from fdwcall('abc123'); I'm looking for a way to get that parameter 'abc123' value in the FDW wrapper code... It seems like during

Re: [HACKERS] upcoming infrastructure changes/OS upgrades on *.postgresql.org

2015-09-25 Thread Stefan Kaltenbrunner
On 09/25/2015 08:30 PM, Tom Lane wrote: > Stefan Kaltenbrunner writes: >> * borka.postgresql.org - official tarball and docs build server, the >> upgrade will upgrade the toolchain on that box to the respective >> versions of what is in jessie. If people think it is

[HACKERS] Tab completion for ALTER COLUMN SET STATISTICS

2015-09-25 Thread Jeff Janes
If I have "alter table foo alter COLUMN bar SET STATISTICS" in the line buffer, it tab completes to add " TO", which is not legal. The attached patch makes it not tab complete anything at all, which is at least not actively misleading. I thought of having it complete "-1", "" so that it gives a

Re: [HACKERS] pg_ctl/pg_rewind tests vs. slow AIX buildfarm members

2015-09-25 Thread Tom Lane
I wrote: > Attached is a draft patch for this. I think it's fine for Unix (unless > someone wants to object to relying on "/bin/sh -c"), but I have no idea > whether it works for Windows. The main risk is that if CMD.EXE runs > the postmaster as a subprocess rather than overlaying itself a la

Re: [HACKERS] Parallel Seq Scan

2015-09-25 Thread Robert Haas
On Fri, Sep 25, 2015 at 12:55 AM, Amit Kapila wrote: > In the latest patch (parallel_seqscan_partialseqscan_v18.patch) posted by > me yesterday, this was fixed. Am I missing something or by any chance > you are referring to wrong version of patch You're right, I'm

Re: [HACKERS] Parallel Seq Scan

2015-09-25 Thread Robert Haas
On Fri, Sep 25, 2015 at 7:46 AM, Amit Kapila wrote: > I have a question here which is why this format doesn't have a similar > problem > as the current version, basically in current patch the second read of > SerializedParamExternData can be misaligned and for same reason

Re: [HACKERS] No Issue Tracker - Say it Ain't So!

2015-09-25 Thread Josh Berkus
On 09/25/2015 10:27 AM, Simon Riggs wrote: > On 25 September 2015 at 11:32, Tom Lane 1. We don't have a good process for making sure things don't "slip > through > the cracks". I think everyone more or less relies on Bruce to run > through > his mailbox

[HACKERS] Re: In-core regression tests for replication, cascading, archiving, PITR, etc.

2015-09-25 Thread Amir Rohan
On 09/25/2015 01:47 PM, Michael Paquier wrote: > On Fri, Sep 25, 2015 at 5:57 PM, Amir Rohan wrote: >> > That's the kind of thing that each serious developer on this mailing > list already has in a rather different shape but with the same final > result: Oh, I guess I'll

Re: [HACKERS] Parallel Seq Scan

2015-09-25 Thread Robert Haas
On Fri, Sep 25, 2015 at 12:00 AM, Amit Kapila wrote: > I think initPlan will work with the existing patches as we are always > executing it in master and then sending the result to workers. Refer > below code in funnel patch: Sure, *if* that's what we're doing, then it

[HACKERS] Re: In-core regression tests for replication, cascading, archiving, PITR, etc.

2015-09-25 Thread Amir Rohan
On 08/14/2015 06:32 AM, Michael Paquier wrote: > On Fri, Aug 14, 2015 at 12:54 AM, Michael Paquier > wrote: >> On Mon, Jun 29, 2015 at 10:11 PM, Michael Paquier >> wrote: >>> On Wed, Mar 18, 2015 at 1:59 PM, Michael Paquier >>>

[HACKERS] Re: In-core regression tests for replication, cascading, archiving, PITR, etc.

2015-09-25 Thread Michael Paquier
On Fri, Sep 25, 2015 at 3:11 PM, Amir Rohan wrote: > On 08/14/2015 06:32 AM, Michael Paquier wrote: > > On Fri, Aug 14, 2015 at 12:54 AM, Michael Paquier > > wrote: > >> On Mon, Jun 29, 2015 at 10:11 PM, Michael Paquier > >>

Re: [HACKERS] No Issue Tracker - Say it Ain't So!

2015-09-25 Thread Albert Cervera i Areny
2015-09-25 9:57 GMT+02:00 Torsten Zuehlsdorff : > > > On 24.09.2015 20:23, David Fetter wrote: >> >> On Thu, Sep 24, 2015 at 12:10:07PM -0600, Ryan Pedela wrote: >>> >>> Kam Lasater wrote: I'd suggest: Github Issues, Pivotal Tracker or Redmine (probably in

Re: [HACKERS] 9.3.9 and pg_multixact corruption

2015-09-25 Thread Bjorn Munch
On 25/09 09.37, Andreas Seltenreich wrote: > [ adding Bjorn Munch to Cc ] Oh. I am on the -hackers list but usually just scan for any subject mentioning Solaris and this one did not. :-) > Jim Nasby writes: > > On 9/20/15 9:23 AM, Christoph Berg wrote: > >> a short update here: the customer

Re: [HACKERS] No Issue Tracker - Say it Ain't So!

2015-09-25 Thread Torsten Zuehlsdorff
On 25.09.2015 10:04, Albert Cervera i Areny wrote: 2015-09-25 9:57 GMT+02:00 Torsten Zuehlsdorff : On 24.09.2015 20:23, David Fetter wrote: On Thu, Sep 24, 2015 at 12:10:07PM -0600, Ryan Pedela wrote: Kam Lasater wrote: I'd suggest: Github Issues, Pivotal

Re: [HACKERS] CustomScan support on readfuncs.c

2015-09-25 Thread Kouhei Kaigai
> On Fri, Sep 25, 2015 at 6:49 AM, Kouhei Kaigai wrote: > > > Hi, > > I tried to define two additional callbacks to support CustomScan > on readfuncs.c. > > First of all, we need to pay attention how to treat output of > TextOutCustomScan

Re: [HACKERS] 9.3.9 and pg_multixact corruption

2015-09-25 Thread Andreas Seltenreich
[ adding Bjorn Munch to Cc ] Jim Nasby writes: > On 9/20/15 9:23 AM, Christoph Berg wrote: >> a short update here: the customer updated the compiler to a newer >> version, is now compiling using -O2 instead of -O3, and the code >> generated now looks sane, so this turned out to be a compiler

Re: [HACKERS] No Issue Tracker - Say it Ain't So!

2015-09-25 Thread Torsten Zuehlsdorff
On 24.09.2015 20:23, David Fetter wrote: On Thu, Sep 24, 2015 at 12:10:07PM -0600, Ryan Pedela wrote: Kam Lasater wrote: I'd suggest: Github Issues, Pivotal Tracker or Redmine (probably in that order). There are tens to hundreds of other great ones out there, I'm sure one of them would also

Re: [HACKERS] ON CONFLICT issues around whole row vars,

2015-09-25 Thread Peter Geoghegan
On Thu, Sep 24, 2015 at 8:25 AM, Andres Freund wrote: > Stuff I want to fix by tomorrow: > * Whole row var references to exclude > * wrong offsets for columns after dropped ones > * INSTEAD DO UPDATE for tables with oids > > Do you know of anything else? You said something in

Re: [HACKERS] 9.3.9 and pg_multixact corruption

2015-09-25 Thread Andreas Seltenreich
Alvaro Herrera writes: > Jim Nasby wrote: >> Do we officially not support anything > -O2? If so it'd be nice if configure >> threw at least a warning (if not an error that you had to explicitly >> over-ride). > > Keep in mind this is Sun OS C -- not one of the most popular compilers > in the

Re: [HACKERS] No Issue Tracker - Say it Ain't So!

2015-09-25 Thread Magnus Hagander
On Fri, Sep 25, 2015 at 12:40 AM, Tom Lane wrote: > Josh Berkus writes: > > On 09/24/2015 12:55 PM, Tom Lane wrote: > >> I agree with the idea that we don't yet want to give the impression that > >> this is the official bug tracker. However, "beta-bugs"

[HACKERS] Re: In-core regression tests for replication, cascading, archiving, PITR, etc.

2015-09-25 Thread Amir Rohan
On 09/25/2015 09:29 AM, Michael Paquier wrote: > > > On Fri, Sep 25, 2015 at 3:11 PM, Amir Rohan > wrote: > > On 08/14/2015 06:32 AM, Michael Paquier wrote: > > I am rather happy with the shape of this patch now, so feel free > to

Re: [HACKERS] Why can't we used CAPITAL LETTERS into replication slot_name?

2015-09-25 Thread Andres Freund
Hi, On 2015-09-25 17:32:39 +0530, Rushabh Lathia wrote: > I am just wondering why pg_create_physical_replication_slot() can't take > CAPITAL LETTERS into slot_name ? Windows. And OSX. Specifically case-insensitive filenames. > If its by design then was should atleast change the hint into >

Re: [HACKERS] Parallel Seq Scan

2015-09-25 Thread Amit Kapila
On Thu, Sep 24, 2015 at 8:03 AM, Robert Haas wrote: > > On Thu, Sep 3, 2015 at 6:21 AM, Amit Kapila wrote: > > [ new patches ] > > Still more review comments: > > + /* Allow space for terminating zero-byte */ > +

Re: [HACKERS] pageinspect patch, for showing tuple data

2015-09-25 Thread Michael Paquier
On Fri, Sep 25, 2015 at 8:30 PM, Nikolay Shaplov wrote: > Here is final version with documentation. Thanks! I just had a short look at it: - I am not convinced that it is worth declaring 3 versions of tuple_data_split. - The patch does not respect the project code style, particularly one-line "if

[HACKERS] Why can't we used CAPITAL LETTERS into replication slot_name?

2015-09-25 Thread Rushabh Lathia
Hi, I am just wondering why pg_create_physical_replication_slot() can't take CAPITAL LETTERS into slot_name ? Comment over ReplicationSlotValidateName() says that - Slot names may consist out of [a-z0-9_]{1,NAMEDATALEN-1} which should allow the name to be used as a directory name on every

Re: [HACKERS] Why can't we used CAPITAL LETTERS into replication slot_name?

2015-09-25 Thread Rushabh Lathia
Thanks Andres. PFA patch to fix the hint message. On Fri, Sep 25, 2015 at 5:34 PM, Andres Freund wrote: > Hi, > > On 2015-09-25 17:32:39 +0530, Rushabh Lathia wrote: > > I am just wondering why pg_create_physical_replication_slot() can't take > > CAPITAL LETTERS into

Re: [HACKERS] DBT-3 with SF=20 got failed

2015-09-25 Thread Tomas Vondra
On 09/25/2015 02:54 AM, Robert Haas wrote: On Thu, Sep 24, 2015 at 1:58 PM, Tomas Vondra wrote: Meh, you're right - I got the math wrong. It's 1.3% in both cases. However the question still stands - why should we handle the over-estimate in one case and not the

Re: [HACKERS] CustomScan support on readfuncs.c

2015-09-25 Thread Amit Kapila
On Fri, Sep 25, 2015 at 6:49 AM, Kouhei Kaigai wrote: > Hi, > > I tried to define two additional callbacks to support CustomScan > on readfuncs.c. > > First of all, we need to pay attention how to treat output of > TextOutCustomScan when additional text output is generated.

[HACKERS] Re: In-core regression tests for replication, cascading, archiving, PITR, etc.

2015-09-25 Thread Michael Paquier
On Fri, Sep 25, 2015 at 5:57 PM, Amir Rohan wrote: > > Having a subcommand in Greg's PEG (http://github.com/gregs1104/peg), > that allows you to create one of several "canned" clusters would be > convenient as well, for manual testing and folling around with features.

[HACKERS] cluster_name and update_process_title documentation

2015-09-25 Thread Peter Eisentraut
The related settings cluster_name and update_process_title have somehow ended up at opposite corners of the documentation and sample files. I propose to group them together in a new "Process Title" section, as in the attached patch. From 159e0db4d7da647ca6d9153250c60a744517ab3e Mon Sep 17

Re: [HACKERS] PATCH: use foreign keys to improve join estimates v1

2015-09-25 Thread Tomas Vondra
Hi, On 09/25/2015 03:39 AM, David Rowley wrote: On 24 September 2015 at 23:57, Tomas Vondra > wrote: 2) find_best_match_foreign_key -- I think the comment before the function needs

Re: [HACKERS] [COMMITTERS] pgsql: Fix an O(N^2) problem in foreign key references.

2015-09-25 Thread Jan Wieck
On 09/18/2015 10:47 AM, Tom Lane wrote: Jan Wieck writes: Attached is a complete rework of the fix from scratch, based on Tom's suggestion. The code now maintains a double linked list as suggested, but only uses it to mark all currently valid entries as invalid when