Re: [HACKERS] security hooks on object creation

ase products. Do we need to consider both security hooks and DDL triggers now? Or, is it enough to design DLL triggers after the hooks are merged? Low-level hooks might be better for security providers because SQL-level triggers could be uninstall by superusers. -- Itagaki Takahiro -- Sen

[HACKERS] MULTISET and additional functions for ARRAY

tp://download.oracle.com/docs/cd/B28359_01/server.111/b28286/operators006.htm -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] MULTISET and additional functions for ARRAY

t that has many duplicates. For example, we could use a sorted array of {value, count} pairs. If we decide to have data type IDs for multiset, I'll go for it (ex. int4, _int4, and an additional $int4), but it consumes +50% of typoids. If it is not preferable, only function support might be better

Re: [HACKERS] MULTISET and additional functions for ARRAY

ctor syntax even now. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comparison with "true" in source code

oo clever for its own good. > > So committed the rest, plus an additional one-line change to psql's > print.c to avoid making the two accesses to format->wrap_right_pointer > inconsistent with each other. Thanks! -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list

Re: [HACKERS] MULTISET and additional functions for ARRAY

On Fri, Nov 12, 2010 at 00:02, Itagaki Takahiro wrote: > Postgres supports ARRAY data types well, but there are some > more array functions in the SQL standard. Also, the standard > has MULTISET data type, that is an unordered array. Here is a WIP patch for multiset function supports.

Re: [HACKERS] SQL/MED estimated time of arrival?

fferent cost models. So, it would be better to encapsulate such operations in FDW. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] MULTISET and additional functions for ARRAY

ORTED flags. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] How to rename each field in ROW expression?

E AS on ahead, but I'd like to change names of ROW expression in ad-hoc queries. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] How to rename each field in ROW expression?

e fields have no names. =# SELECT (ROW(123, 'ABC', NULL)).*; ERROR: record type has not been registered -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] autovacuum maintenance_work_mem

t is there the same issue for normal connections? We can limit max connections per user, but there are no quota for total memory consumed by the user. It might not be an autovacuum-specifix issue. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make c

Re: [HACKERS] Extensible executor nodes for preparation of SQL/MED

it is a waste of time and notational >> complexity. > > I think I agree; and moreover there's been no compelling argument made > why we would need that for SQL/MED anyway. I see. I'll cut useless parts from my patch. -- Itagaki Takahiro -- Sent via pgsql-hackers maili

Re: [HACKERS] Extensible executor nodes for preparation of SQL/MED

On Wed, Nov 17, 2010 at 10:51, Itagaki Takahiro wrote: > On Wed, Nov 17, 2010 at 03:36, Robert Haas wrote: >> On Tue, Nov 16, 2010 at 1:28 PM, Tom Lane wrote: >>> I am of the opinion that a run-time-extensible set of plan node types >>> is merest fantasy.  We will nev

[HACKERS] Overlap operators for ARRAY and NULLs

gt; NULL Will we change the operator's behavior? It would be more consistent, but incompatible with older server versions. If impossible, I'll add separated submultiset_of() function instead of <@ operator for MULTISET supports. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing li

Re: [HACKERS] We need to log aborted autovacuums

d of the database owner? If we have "autovacuum" role for autovacuum processes, we could set log_min_messages to DEBUG3 for only the role with per-user configuration. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your sub

Re: [HACKERS] UNNEST ... WITH ORDINALITY (AND POSSIBLY OTHER STUFF)

i) - SELECT row_number() OVER () AS i, v FROM UNNEST($1) AS t(v) -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] UNNEST ... WITH ORDINALITY (AND POSSIBLY OTHER STUFF)

lement1, OUT anyelement2, ...) RETURNS SETOF record So, we would need a special representation for multi-array unnest(). -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Extensions, this time with a patch

ble. Personally, I prefer "conf". * Can we export ParseConfigFile() in guc-file.l rather than parseRecoveryCommandFileLine()? It can solve the issue that unquoted parameter values in recovery.conf are not recognized. Even if we won't merge them, just allowing unquoted values wo

Re: [HACKERS] Per-column collation

nce regression. [src/backend/utils/adt/pg_locale.c] -lc_collate_is_c(void) +lc_collate_is_c(Oid collation) { ... + tp = SearchSysCache1(COLLOID, ObjectIdGetDatum(collation)); ... HERE => if (result >= 0) return (bool) result; -- Itagaki Takahiro -- Sent via

Re: [HACKERS] SQL/MED estimated time of arrival?

the head broken state at the previous commit-fest? I think that's why the patch becomes so large. So, our guideline to submit a large patch would be: * Split patch into commitable sub-patches (2000 lines each), * But submit a series of patches at once. Am I understanding correctly? -- It

Re: [HACKERS] [JDBC] Support for JDBC setQueryTimeout, et al.

was some binary read > classes) and about 50% it's big test case. I changed the patch's topic to "JDBC". https://commitfest.postgresql.org/action/patch_view?id=399 Patch reviewers are still wanted. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hacke

[HACKERS] format() with embedded to_char() formatter

--- CREATE TABLE partition_20101122 () INHERITS parent Is it interesting? Comments welcome. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Extensions, this time with a patch

om_variable_classes" in it might not be needed to parse recovery.conf and extensions. We would disable them when we parse non-guc configuration files. Or, we could allow "include" in recovery.conf if we think it is useful in some cases. -- Itagaki Takahiro -- Sent via pgsql-hacker

Re: [HACKERS] dblink versus long connection strings

nguish two connections that differ only >63 bytes. Do we need another logic to name non-named connections? For example, md5 hash of the connection string. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] heap vacuum & cleanup locks

d page instead of the old pinned one. Of course, copy-on-writing is more complex than skipping pinned pages, but I wonder we cannot vacuum at all in some edge cases with the skipping method. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make cha

Re: pgbench cpu overhead (was Re: [HACKERS] lazy vxid locks, v1)

s integer values of sub-META_COMMAND instead of string comparison for each loop. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: pgbench cpu overhead (was Re: [HACKERS] lazy vxid locks, v1)

h/without timeout in the cases, no? -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] possible connection leak in dblink?

' is no longer necessary. > > The similar problem exists in dblink_get_result and dblink_record_internal. > Attached patch fixes those problems. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pgbench--new transaction type

urn only one value instead of 512. Anyway, I'm not sure we need to include the query mode into the pgbench's codes. Instead, how about providing "a sample script" as a separate sql file? pgbench can execute any script files with -f option. -- Itagaki Takahiro -- Sent via pgsql-h

Re: [HACKERS] Adding Japanese README

te those README files as documentation, we could move them into "internals" section in the SGML doc tree. If so, the translated README will be a part of the doc translation project. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Extensions support for pg_dump, patch v27

pg_dump might need to dump extensions as "CREATE OR REPLACE EXTENSION" or "CREATE EXTENSION IF NOT EXISTS" rather than "CREATE EXTENSION". -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] REVIEW: WIP: plpgsql - foreach in

mArrayResult() for SLICE has a bit overhead. If we want to optimize it, we could use memcpy() because slices are placed in continuous memory. But I'm not sure the worth; I guess FOREACH will be used with SLICE = 0 in many cases. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsq

Re: [HACKERS] REVIEW: WIP: plpgsql - foreach in

ared with FOREACH var IN expr. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Extensions support for pg_dump, patch v27

ate in BTW, I have a minor comments for the code. extern bool extension_relocatable_p(Oid ext_oid); What is "_p" ? Also, we could make the function static because it is used only in extension.c. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postg

Re: [HACKERS] Extensions support for pg_dump, patch v27

On Thu, Jan 27, 2011 at 22:48, Dimitri Fontaine wrote: > Itagaki Takahiro writes: >> I found pg_restore with -c option fails when an extension is created >> in pg_catalog. > Nice catch, thank you very much (again) for finding those :) Seems good. >>   extern bool ext

Re: [HACKERS] multiset patch review

ata type as a super class of ARRAY and MULTISET. So, it's reasonable that functions and operators that accept MULTISETs also accept ARRAYs. For example, we will have cardinality(ARRAY) even if we have cardinality(MULTISET). Also, trim_array() is in the SQL standard. I can remove some parts in th

Re: [HACKERS] multiset patch review

ys are adjusted to 1. I'm not sure what is the consistent behavior for MD arrays. For example, array_concat() is very strict, but <@ and && operators don't care about the dimensions. I interpreted the second argument for trim_array() as a number of "elements", but of

Re: pg_ctl failover Re: [HACKERS] Latches, signals, and waiting

mote") seems the easiest way if you use an external module. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Extensions support for pg_dump, patch v27

pg_extension catalog to return whether the extension is installed, but it would be better to change the function to return just whole extensions and JOIN with pg_extension in pg_available_extensions. (it's the same technique used in pg_stat_replication) -- Itagaki Takahiro -- Sent via pgsq

Re: [HACKERS] Spread checkpoint sync

pg_start_backup(), and some of checkpoints during recovery might don't want to sleep. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Add reference to client_encoding parameter

nd. Thanks. It's a reasonable reference. But I reworded it as below, that we are using in other a few places. The character sets supported by the PostgreSQL server are described in ... -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) T

Re: [HACKERS] setlocale and gettext in Postgres

ded the patch to the current commitfest for reminder. https://commitfest.postgresql.org/action/patch_view?id=528 -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] off-by-one mistake in array code error reporting

1][1][1][1][1][1]; END; $$; ERROR: number of array dimensions (6) exceeds the maximum allowed (6) -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Add support for logging the current role

  They looks itemized in the sgml files, but will be flattened in >>   complied HTML files. > > Not sure what you're referring to here...?  Can you elaborate?  I'm not > great with the docs. :/ Could you try to "make html" in the doc directory? Your new decumentatio

Re: [HACKERS] Transaction-scope advisory locks

th session and transaction lock on the same resource at the same time, though we still need to show exclusive and shared locks in different lines. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

grade script for each supported versions? -- if so, it would be nightmare... -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

rsions. For example, if we have 3 versions of a module below: NULL unmanaged functions only v1EXTENSION support with an additional function v2EXTENSION support with another function. How do we write upgrading scripts for NULL=>v1, NULL=>v2, and v1=>v2 ? -- Itagaki Takahiro -

Re: [HACKERS] log_checkpoints and restartpoint

tter.  Absent objections, I will also commit it. I don't have any objections for the patch, but we might also need to add description about restartpoints into log_checkpoints option. http://developer.postgresql.org/pgdocs/postgres/runtime-config-logging.html#RUNTIME-CONFIG-LOGGING-WHAT --

Re: [HACKERS] exposing COPY API

typical users don't want to write functions with C for each kind of input files. Note that pg_bulkload has a similar feature like as: CREATE FUNCTION my_function(...) RETURNS record AS ...; COPY tbl FROM 'file' WITH (make_record_from_line = my_function) -- Itagaki Takahiro -- Se

Re: [HACKERS] exposing COPY API

ed previously, is to have a FDW that returns a > text array from a (possibly irregularly shaped) file. I remember the text array proposal, but if the extension is written in C, it can only handle one kind of input files. If another file is broken in a different way, you need to rewrite the C

Re: [HACKERS] exposing COPY API

h extensibility. If COPY FROM, we should implement all the features in copy.c rather than exported APIs. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pg_dump directory archive format / parallel pg_dump

tter to remove Windows-specific codes from the first try. I doubt Windows message queue is the best API in such console-based application. I hope we could use the same implementation for all platforms for inter-process/thread communication. -- Itagaki Takahiro -- Sent via pgsql-hackers maili

Re: [HACKERS] Add ENCODING option to COPY

renamed to target_encoding, but I prefer file_encoding or remote_encoding. * CopyState can have conv_proc entity as a member instead of the pointer. * need_transcoding checks could be replaced with conv_proc IS NULL check. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hacker

Re: [HACKERS] exposing COPY API

ce but uninteresting. BTW, how do you determine which field is shifted in your broken CSV file? For example, the case you find "AB,CD,EF" for 2 columns tables. I could provide a raw CSV reader for jagged files, but you still have to cook the returned fields into a proper tuple... --

Re: [HACKERS] multiset patch review

. We could have array_fusion() for array types and fusion() for multiset types, but I prefer overloaded fusion() to have both names. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] multiset patch review

s, or for multisets? Multisets. But I chose the same function name and syntax because arrays *are* multisets by definition. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] multiset patch review

full multiset support. > > Given PostgreSQL overloading, yes, arrays are multisets as far as > defining those standard compliant APIs is concerned.  AFAIUI. Yes, I'd like to use overloading. Choosing arbitrary names increases learning costs for users. -- Itagaki Takahiro -- Sent vi

Re: [HACKERS] Add support for logging the current role

On Sun, Feb 6, 2011 at 23:31, Stephen Frost wrote: > * Itagaki Takahiro (itagaki.takah...@gmail.com) wrote: >> I think we need to improve postgresql.conf.sample a bit more, especially >> the long line for #log_csv_fields = '...'. 330 characters in it! >>   #1. Le

Re: [HACKERS] [GENERAL] Issues with generate_series using integer boundaries

;infinity', '1 sec') AS a(x); =# SELECT x FROM generate_series('infinity'::timestamptz, 'infinity', '1 sec') AS a(x); > postgres=# SELECT x FROM generate_series(1, 9,-1) AS a(x); > postgres=# SELECT x FROM generate_series(1, 9,3) AS a(x); They work as expe

Re: [HACKERS] SQL/MED - file_fdw

seq_page_cost * pages; + + *startup_cost += baserel->baserestrictcost.startup; + cpu_per_tuple = cpu_tuple_cost + baserel->baserestrictcost.per_tuple; + run_cost += cpu_per_tuple * 10 * baserel->tuples; + *total_cost = *startup_cost + run_cost; + + return stat.st_size; +} -- Itagaki T

Re: [HACKERS] exposing COPY API

I'll include NextCopyFromRawFields() in COPY API patch to complete raw_fields support in CopyState. (Or, we should also revert changes related to raw_fields.) However, we'd better postpone jagged csv support to 9.2. The design is still under discussion. -- Itagaki Takahiro -- Sent via

Re: [HACKERS] [GENERAL] Issues with generate_series using integer boundaries

a check > for either kind of infinity and return an error if that's the case?  I Maybe so. It also works if we had infinity on timestamp overflow, but I've not tested yet. Anyway, we need similar fix for timestamp versions. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgs

Re: [HACKERS] [GENERAL] Issues with generate_series using integer boundaries

On Wed, Feb 9, 2011 at 10:17, Andrew Dunstan wrote: > Isn't this all really a bug fix that should be backpatched, rather than a > commitfest item? Sure, but we don't have any bug trackers... -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgre

Re: [HACKERS] pg_dump directory archive format / parallel pg_dump

lso on Windows. * Research libpq + fork() issue. We have a warning in docs: http://developer.postgresql.org/pgdocs/postgres/libpq-connect.html | On Unix, forking a process with open libpq connections can lead to unpredictable results -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Error attribution in foreign scans

n retrieve the values. It's an existing issue, but will be more serious in 9.1. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Range Type constructors

v9r8/index.jsp?topic=/com.ibm.db2.luw.sql.ref.doc/doc/r927.html I'm not sure it is the best syntax, but at least it's easy to read for beginners and works with parentheses completion by text editors. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresq

Re: [HACKERS] Transaction-scope advisory locks

files > and adding a new one just for a few tests didn't seem right.  Anyone have an > idea where they should go or should I just add a new one? I think you can add advisory_lock.sql for the test. -- Itagaki Takahiro advisory4fix.patch Description: Binary data -- Sent via pgsql-hackers m

Re: [HACKERS] another mvcc.sgml typo

On Thu, Feb 10, 2011 at 09:30, Kevin Grittner wrote: > Trivial patch attached. Applied. Thanks! -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Transaction-scope advisory locks

cks == true: release all locks including session locks. | allLocks == false: release all non-session locks. * Or, we might have one subroutine for LockReleaseSession() and LockReleaseCurrentOwner(). They have similar codes. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@p

Re: [HACKERS] Add support for logging the current role

x27;); It will be cleaner if we add first_col flag and move it out of the switch statement. Other questions I raised before might be matters of preference. I'd like to here about them form third person. * name: log_csv_fields vs. csvlog_fields * when to assign: PGC_POSTMASTER vs. PGC_SIGHUP

Re: [HACKERS] psql patch: tab-complete :variables also at buffer start

On Thu, Feb 10, 2011 at 19:37, Christoph Berg wrote: > Currently, tab-completing :variable names in psql does not work at the > beginning of the line. Fix this by moving the code block before the > "empty buffer" case. Seems reasonable to me. -- Itagaki Takahiro -- Sen

Re: [HACKERS] multiset patch review

om the patch; it will add only a few array functions. Then, please let me know functions you don't want to include in the core, if any. I'll remove them at the same time. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] SQL/MED - file_fdw

ttle more, I'd raise two items: * Should we print foreign table names in error messages? http://archives.postgresql.org/pgsql-hackers/2011-02/msg00427.php * COPY encoding patch was rejected, but using client_encoding is logically wrong for file_fdw. We might need subset of the patch for file_

Re: [HACKERS] multiset patch review

codes using the same operation in other files? > There's more, primairly lack of comments and what I consider poor > function naming ("sort_or_unique()" ?  really?), Could you suggest better names? -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Add support for logging the current role

turn" should be removed. *** 2139,2144 write_csvlog(ErrorData *edata) --- 2379,2386 write_pipe_chunks(buf.data, buf.len, LOG_DESTINATION_CSVLOG); pfree(buf.data); + + return; } /* -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] SQL/MED - file_fdw

est run, but if anyone feels >> that's justified, I can arrange something. > > Based on this, I've taken the liberty of marking the patch Ready for > Committer. Thank you very much for performance testing and reviewing! The result is interesting because I didn't in

Re: [HACKERS] Add support for logging the current role

pg_settings view, but there were no better alternative solutions in the past discussion. * csvlog_fields is marked as PGC_POSTMASTER. It can protect mixed formats in a csv file on default log_filename, but other similar GUC variables are usually marked AS PGC_SIGHUP. -- Itagaki Takahiro -- Sent vi

Re: [HACKERS] CommitFest 2011-01 as of 2011-02-04

astructure. The extension will lack of file encoding support, but still useful for many cases. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] CommitFest 2011-01 as of 2011-02-04

r the better. Thanks comments. I've applied the COPY API patch. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] SQL/MED - file_fdw

a virtual tuple. */ , right? * #include is needed. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] COPY ENCODING revisited

;double quoted", but encoding names are not identifiers. -- Itagaki Takahiro copy_encoding-20110217.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] COPY ENCODING revisited

he, in which cache search doesn't seem like overhead. We need to research what we should cache for conversion procs. We will need 4 bytes per conversion pair if we cache only OIDs, but sizeof(FmgrInfo) bytes if we use the same way as ToXXXConvProc cache. -- Itagaki Takahiro -- Sent via pgs

Re: [HACKERS] Transaction-scope advisory locks

On Thu, Feb 17, 2011 at 17:05, Itagaki Takahiro wrote: > I did a few cosmetic fixes, mainly lmgr/README and make a subroutine > ReleaseLockForOwner() for LockReleaseSession and LockReleaseCurrentOwner. Committed with a few typo fixes. Thanks, Marko! -- Itagaki Takahiro -- Sent via

Re: [HACKERS] CommitFest 2011-01 as of 2011-02-04

On Fri, Feb 18, 2011 at 13:15, Shigeru HANADA wrote: > When I've used COPY TO for testing file_fdw, I got wrong result. > It would be because DR_copy's processed is not initialized in > CreateCopyDestReceiver().  Please see attached patch. Oops, thanks, applied. -- Itagaki

Re: [HACKERS] COPY ENCODING revisited

On Fri, Feb 18, 2011 at 03:57, Robert Haas wrote: > On Wed, Feb 16, 2011 at 10:45 PM, Itagaki Takahiro > I am not qualified to fully review this patch because I'm not all that > familiar with the encoding stuff, but it looks reasonably sensible on > a quick read-through.  I

[HACKERS] Assertion failure on UNLOGGED VIEW and SEQUENCE

uot;heap.c", Line: 1246) =# CREATE UNLOGGED SEQUENCE us; TRAP: FailedAssertion("!(relkind == 'r' || relkind == 't')", File: "heap.c", Line: 1246) The most easiest fix would be preventing them in parser level. -- Itagaki Takahiro -- Sent via p

[HACKERS] contrib/unaccent regression test failed

| C | C | -- Itagaki Takahiro regression.diffs Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] COPY ENCODING revisited

On Fri, Feb 18, 2011 at 20:12, Itagaki Takahiro wrote: > + extern char *pg_any_to_server(const char *s, int len, int encoding); > + extern char *pg_server_to_any(const char *s, int len, int encoding); I applied the version with additional codes for file_fdw. -- Itagaki Takahiro -- Se

Re: [HACKERS] validating foreign tables

which RSS fields we > want. I think we need to overhaul validators in 9.2 listening to FDW developers' opinions anyway. The text array is an example, but there should be many other requirements. Personally, I'd like to have a method to list available options from SQL. We should also consider

[HACKERS] UNLOGGED tables in psql \d

they are always created in pg_temp_N schema. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] UNLOGGED tables in psql \d

On Tue, Feb 22, 2011 at 18:11, Cédric Villemain wrote: > 2011/2/22 Itagaki Takahiro : >> psql \d(+) doesn't show any information about UNLOGGED and TEMP attributes >> for the table. So, we cannot know the table is unlogged or not unless >> we directly select from pg_clas

[HACKERS] psql tab-completion for CREATE UNLOGGED TABLE

Here is a patch to support CREATE UNLOGGED TABLE in psql tab-completion. It also fixes a bug that DROP is completed with TEMP and UNIQUE unexpectedly and cleanup codes for DROP OWNED BY in drop_command_generator(). -- Itagaki Takahiro psql_tab_completion_for_unlogged-20110223.patch Description

[HACKERS] aggregate version of first_value function?

Is it reasonable? Or, do we have alternative ways for the same purpose? -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Header comments in the recently added files

th_delay.c. - "IDENTIFICATION $PostgreSQL$" in pg_collation.h, syncrep.h, and syncrep.c Other files has their actual paths in the same place. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Header comments in the recently added files

On Thu, Mar 10, 2011 at 12:55, Robert Haas wrote: > On Wed, Mar 9, 2011 at 8:33 PM, Itagaki Takahiro > wrote: >> I found trivial mistakes in the recently added files. >> Will they fixed by some automated batches, or by manual? > I think these should be fixed manua

[HACKERS] KEEPONLYALNUM for pg_trgm is not documented

preferred. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Lock problem with autovacuum truncating heap

t; Guess it wouldn't hurt too much. Yes, probably. AFAIK, RHEL 5 cannot readahead in backward scans. It might be improved in the latest kernel, but it would be safe not to rely on kernels except simple forward scans. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@

Re: [HACKERS] patch: preload dictionary new version

2010/7/8 Tom Lane : > For example, the dictionary-load code could automatically execute > the precompile step if it observed that the precompiled copy of the > dictionary was missing or had an older file timestamp than the source. There might be a problem in automatic precompiler -- Where should w

Re: [HACKERS] patch (for 9.1) string functions

quot;, fromlen=3) at mbutils.c:715 #4 0x7f8e8c436d37 in stringfunc_sprintf (fcinfo=0x7fff9bdcd4b0) at stringfunc.c:463 -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] patch (for 9.1) string functions

SQL Server, Oracle (as utl_raw.reverse) concat_sql(), format(), and sprintf() will be our unique features. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

<    1   2   3   4   5   6   7   8   9   >