Re: [HACKERS] Final Patch for GROUPING SETS

2014-12-31 Thread Noah Misch
On Tue, Dec 23, 2014 at 02:29:58AM -0500, Noah Misch wrote: > On Mon, Dec 22, 2014 at 10:46:16AM -0500, Tom Lane wrote: > > I still find the ChainAggregate approach too ugly at a system structural > > level to accept, regardless of Noah's argument about number of I/O cycles >

Re: [HACKERS] orangutan seizes up during isolation-check

2014-12-28 Thread Noah Misch
On Sat, Oct 11, 2014 at 09:07:46AM -0400, Peter Eisentraut wrote: > On 10/11/14 1:41 AM, Noah Misch wrote: > > Good question. It would be nice to make the change there, for the benefit > > of > > other consumers. The patch's setlocale_native_forked() assumes i

[HACKERS] Re: Better way of dealing with pgstat wait timeout during buildfarm runs?

2014-12-27 Thread Noah Misch
On Thu, Dec 25, 2014 at 09:14:36PM +0100, Andres Freund wrote: > My guess is that a checkpoint happened at that time. Maybe it'd be a > good idea to make pg_regress start postgres with log_checkpoints > enabled? My guess is that we'd find horrendous 'sync' times. +1, independent of $SUBJECT. How

Re: [HACKERS] Initdb-cs_CZ.WIN-1250 buildfarm failures

2014-12-27 Thread Noah Misch
On Tue, Dec 23, 2014 at 03:32:59PM +0100, Tomas Vondra wrote: > On 23.12.2014 15:21, Andrew Dunstan wrote: > > > > No, config_opts is what's passed to configure. Try something like: > > > > if ($branch eq 'REL9_0_STABLE') > > { > > $skip_steps{'pl-install-check'} = 1; > > } >

Re: [HACKERS] CATUPDATE confusion?

2014-12-27 Thread Noah Misch
On Sat, Dec 27, 2014 at 06:26:02PM -0500, Tom Lane wrote: > Stephen Frost writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> Plan C (remove CATUPDATE altogether) also has some merit. But adding a > >> superuser override there would be entirely pointless. > > > This is be my recommendation.

[HACKERS] Re: Using RTLD_DEEPBIND to handle symbol conflicts in loaded libraries

2014-12-27 Thread Noah Misch
On Wed, Nov 26, 2014 at 01:34:18PM +0200, Ants Aasma wrote: > glibc-2.3.4+ has a flag called RTLD_DEEPBIND for dlopen that prefers > symbols loaded by the library to those provided by the caller. Using > this flag fixes my issue, PostgreSQL gets the ldap functions from > libldap, Oracle client gets

Re: [HACKERS] Serialization exception : Who else was involved?

2014-12-27 Thread Noah Misch
On Tue, Dec 02, 2014 at 11:17:43AM +0100, Olivier MATROT wrote: > Serialization conflict detection is done in > src/backend/storage/lmgr/predicate.c, where transactions that are doomed > to fail are marked as such with the SXACT_FLAG_DOOMED flag. > > I simply added elog(...) calls with the NOTIFY

Re: [HACKERS] CATUPDATE confusion?

2014-12-27 Thread Noah Misch
On Mon, Nov 24, 2014 at 04:28:46PM -0500, Adam Brightwell wrote: > So, where I find this confusing is that the documentation supports this > functionality and the check keeps superuser separate from CATUPDATE... > however... comments and implementation in user.c state/do the opposite and > couple t

Re: [HACKERS] group locking: incomplete patch, just for discussion

2014-12-25 Thread Noah Misch
On Thu, Nov 20, 2014 at 09:15:51PM +0100, Andres Freund wrote: > On 2014-11-20 13:57:25 -0500, Robert Haas wrote: > > On Thu, Nov 20, 2014 at 12:19 PM, Andres Freund > > wrote: > > If the > > deadlock detector would kill the processes anyway, it doesn't matter, > > because CheckTableNotInUse() sh

Re: [HACKERS] Securing "make check" (CVE-2014-0067)

2014-12-25 Thread Noah Misch
On Thu, Dec 25, 2014 at 11:35:31PM +1300, David Rowley wrote: > On 25 December 2014 at 18:27, Noah Misch wrote: > > This needs to be conditional on whether the platform supports IPv6, like > > we do > > in setup_config(). The attached patch works on these configurations: &

Re: [HACKERS] Securing "make check" (CVE-2014-0067)

2014-12-24 Thread Noah Misch
On Thu, Dec 25, 2014 at 03:55:02PM +1300, David Rowley wrote: > f6dc6dd seems to have broken vcregress check for me: > FATAL: no pg_hba.conf entry for host "::1", user "David", database > "postgres" > ... > FATAL: no pg_hba.conf entry for host "::1", user "David", database > "postgres" Thanks.

Re: [HACKERS] bin checks taking too long.

2014-12-23 Thread Noah Misch
On Tue, Dec 23, 2014 at 01:55:46PM -0500, Andrew Dunstan wrote: > On 12/23/2014 11:11 AM, Andrew Dunstan wrote: > > Use of uninitialized value $ENV{"top_builddir"} in concatenation (.) > > or string at t/001_start_stop.pl line 17. > > file not found: /src/test/regress/pg_regress at > >/home/b

Re: [HACKERS] Initdb-cs_CZ.WIN-1250 buildfarm failures

2014-12-23 Thread Noah Misch
On Sat, Dec 20, 2014 at 07:28:33PM +0100, Tomas Vondra wrote: > On 20.12.2014 19:05, Tom Lane wrote: > > Locale cs_CZ.WIN-1250 is evidently marked with a codeset property of > > "ANSI_X3.4-1968" (which means old-school US-ASCII). That's certainly > > wrong. I believe the correct thing would be "C

Re: [HACKERS] Final Patch for GROUPING SETS

2014-12-22 Thread Noah Misch
On Mon, Dec 22, 2014 at 10:46:16AM -0500, Tom Lane wrote: > I still find the ChainAggregate approach too ugly at a system structural > level to accept, regardless of Noah's argument about number of I/O cycles > consumed. We'll be paying for that in complexity and bugs into the > indefinite future,

Re: [HACKERS] Final Patch for GROUPING SETS

2014-12-21 Thread Noah Misch
On Sat, Dec 13, 2014 at 04:37:48AM +, Andrew Gierth wrote: > > "Tom" == Tom Lane writes: > > >> I'd already explained in more detail way back when we posted the > >> patch. But to reiterate: the ChainAggregate nodes pass through > >> their input data unchanged, but on group boundaries

Re: [HACKERS] Initdb-cs_CZ.WIN-1250 buildfarm failures

2014-12-20 Thread Noah Misch
On Sat, Dec 20, 2014 at 05:14:03PM +0100, CSPUG wrote: > On 20.12.2014 07:39, Noah Misch wrote: > > Buildfarm members magpie, treepie and fulmar went absent on > > 2014-10-29. Since returning on 2014-11-16, they have consistently > > failed with 'initdb: invalid locale

[HACKERS] New Python vs. old PG on raccoon and jaguarundi

2014-12-19 Thread Noah Misch
PostgreSQL 9.2 and later support Python 3.3 and Python 3.4; PostgreSQL 9.1 and 9.0 do not. Buildfarm member raccoon upgraded from Python 2.7 to Python 3.3 for its 2013-08-18 run, and it has failed for REL9_1_STABLE and REL9_0_STABLE ever since. Please omit --with-python for those branches. (Poin

[HACKERS] Initdb-cs_CZ.WIN-1250 buildfarm failures

2014-12-19 Thread Noah Misch
Buildfarm members magpie, treepie and fulmar went absent on 2014-10-29. Since returning on 2014-11-16, they have consistently failed with 'initdb: invalid locale name "cs_CZ.WIN-1250"'. No commits in that period readily explain a regression in this area. Did the underlying system configurations

[HACKERS] Re: pgsql: Allow pushdown of WHERE quals into subqueries with window functi

2014-12-19 Thread Noah Misch
On Sat, Jun 28, 2014 at 06:08:05AM +, Tom Lane wrote: > Allow pushdown of WHERE quals into subqueries with window functions. > > We can allow this even without any specific knowledge of the semantics > of the window function, so long as pushed-down quals will either accept > every row in a giv

Re: [HACKERS] Reducing lock strength of adding foreign keys

2014-12-19 Thread Noah Misch
On Wed, Dec 17, 2014 at 02:41:39PM +, Simon Riggs wrote: > Is there anything different here from work in my original patch series? Not to my knowledge. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailp

Re: [HACKERS] tracking commit timestamps

2014-12-18 Thread Noah Misch
On Tue, Dec 16, 2014 at 01:05:31AM -0300, Alvaro Herrera wrote: > Noah Misch wrote: > > On Mon, Dec 15, 2014 at 12:12:10AM -0800, Michael Paquier wrote: > > > > FWIW, I just tried that with MinGW-32 and I can see the error on Win7. > > > I also checked that changing

Re: [HACKERS] Commitfest problems

2014-12-15 Thread Noah Misch
On Mon, Dec 15, 2014 at 03:29:19PM -0500, Andrew Dunstan wrote: > On 12/15/2014 03:16 PM, Andres Freund wrote: > >On 2014-12-15 11:52:35 -0800, Josh Berkus wrote: > >>On 12/15/2014 11:27 AM, Robert Haas wrote: > >>>I feel like we used to be better at encouraging people to participate > >>>in the CF

Re: [HACKERS] tracking commit timestamps

2014-12-15 Thread Noah Misch
On Mon, Dec 15, 2014 at 12:12:10AM -0800, Michael Paquier wrote: > On Wed, Dec 10, 2014 at 6:50 PM, Noah Misch wrote: > > On Mon, Dec 08, 2014 at 02:23:39AM +0100, Petr Jelinek wrote: > >> On 08/12/14 00:56, Noah Misch wrote: > >> >The commit_ts test suite gives me

Re: [HACKERS] tracking commit timestamps

2014-12-10 Thread Noah Misch
On Mon, Dec 08, 2014 at 02:23:39AM +0100, Petr Jelinek wrote: > On 08/12/14 00:56, Noah Misch wrote: > >The commit_ts test suite gives me the attached diff on a 32-bit MinGW build > >running on 64-bit Windows Server 2003. I have not checked other Windows > >configurations; t

Re: [HACKERS] tracking commit timestamps

2014-12-07 Thread Noah Misch
On Wed, Dec 03, 2014 at 11:54:38AM -0300, Alvaro Herrera wrote: > Pushed with some extra cosmetic tweaks. The commit_ts test suite gives me the attached diff on a 32-bit MinGW build running on 64-bit Windows Server 2003. I have not checked other Windows configurations; the suite does pass on GNU/

Re: [HACKERS] inherit support for foreign tables

2014-12-06 Thread Noah Misch
On Thu, Dec 04, 2014 at 10:00:14AM +0530, Ashutosh Bapat wrote: > On Thu, Dec 4, 2014 at 9:05 AM, Etsuro Fujita > wrote: > > (2014/12/03 19:35), Ashutosh Bapat wrote: > >> On Tue, Dec 2, 2014 at 8:29 AM, Etsuro Fujita > >> mailto:fujita.ets...@lab.ntt.co.jp>> wrote: > > IIUC, even the transa

Re: [HACKERS] SSL regression test suite

2014-12-05 Thread Noah Misch
On Thu, Dec 04, 2014 at 02:42:41PM +0200, Heikki Linnakangas wrote: > On 10/06/2014 04:21 PM, Heikki Linnakangas wrote: > >This probably needs some further cleanup before it's ready for > >committing. One issues is that it creates a temporary cluster that > >listens for TCP connections on localhost

Re: [HACKERS] using Core Foundation locale functions

2014-12-02 Thread Noah Misch
On Fri, Nov 28, 2014 at 11:43:28AM -0500, Peter Eisentraut wrote: > In light of the recent discussions about using ICU on OS X, I looked > into the Core Foundation locale functions (Core Foundation = traditional > Mac API in OS X, as opposed to the Unix/POSIX APIs). > > Attached is a proof of conc

Re: [HACKERS] Securing "make check" (CVE-2014-0067)

2014-11-29 Thread Noah Misch
On Sun, Sep 21, 2014 at 02:31:15AM -0400, Noah Misch wrote: > It then dawned on me that every Windows build of PostgreSQL already has a way > to limit connections to a particular OS user. SSPI authentication is > essentially the Windows equivalent of peer authentication. A brief trial

Re: [HACKERS] [COMMITTERS] pgsql: Revert "Add libpq function PQhostaddr()."

2014-11-29 Thread Noah Misch
On Sat, Nov 29, 2014 at 02:09:09PM -0500, Tom Lane wrote: > Noah Misch writes: > > Revert "Add libpq function PQhostaddr()." > > This reverts commit 9f80f4835a55a1cbffcda5d23a617917f3286c14. The > > function returned the raw value of a connection parameter,

Re: [HACKERS] The problems of PQhost()

2014-11-28 Thread Noah Misch
On Fri, Nov 28, 2014 at 07:55:29PM +0900, Fujii Masao wrote: > On Fri, Nov 28, 2014 at 3:43 AM, Noah Misch wrote: > > On Fri, Nov 28, 2014 at 03:11:06AM +0900, Fujii Masao wrote: > >> On Thu, Nov 27, 2014 at 12:38 PM, Noah Misch wrote: > >> > Sure. I'll fir

Re: [HACKERS] The problems of PQhost()

2014-11-27 Thread Noah Misch
On Fri, Nov 28, 2014 at 03:11:06AM +0900, Fujii Masao wrote: > On Thu, Nov 27, 2014 at 12:38 PM, Noah Misch wrote: > > Sure. I'll first issue "git revert 9f80f48", then apply the attached patch. > > Since libpq ignores a hostaddr parameter equal to the empty string

Re: [HACKERS] The problems of PQhost()

2014-11-26 Thread Noah Misch
On Tue, Nov 25, 2014 at 09:53:10PM +0900, Fujii Masao wrote: > On Tue, Nov 25, 2014 at 12:37 PM, Noah Misch wrote: > > On Wed, Jan 22, 2014 at 11:48:26PM +0900, Fujii Masao wrote: > >> (3) PQhost() cannot return the hostaddr. > > > >> We can fix the problem (3

Re: [HACKERS] no test programs in contrib

2014-11-24 Thread Noah Misch
On Mon, Nov 24, 2014 at 10:49:45AM -0300, Alvaro Herrera wrote: > What's the general opinion on having test programs somewhere other than > contrib/ ? General opinion: slightly favorable. > We currently have a number of subdirectories for test-only programs: > > test_parser (a toy text search pa

Re: [HACKERS] The problems of PQhost()

2014-11-24 Thread Noah Misch
On Wed, Jan 22, 2014 at 11:48:26PM +0900, Fujii Masao wrote: > (3) PQhost() cannot return the hostaddr. > We can fix the problem (3) by changing PQhost() so that it also > returns the hostaddr. But this change might break the existing > application using PQhost(). So, I added new libpq function PQ

Re: [HACKERS] Automatic PG_PRINTF_ATTRIBUTE

2014-11-21 Thread Noah Misch
On Fri, Nov 21, 2014 at 08:13:17PM -0500, Tom Lane wrote: > Andres Freund writes: > > On 2014-11-21 03:12:14 -0500, Noah Misch wrote: > >> ... I'm > >> increasingly using an affected compiler, because it builds twice as > >> quickly as > >> tod

Re: [HACKERS] Automatic PG_PRINTF_ATTRIBUTE

2014-11-21 Thread Noah Misch
On Fri, Nov 21, 2014 at 01:16:25PM -0500, Tom Lane wrote: > Noah Misch writes: > > pg_config_manual.h has been choosing gnu_printf as the PG_PRINTF_ATTRIBUTE > > for > > every MinGW build. That invites a torrent of warnings on pre-gcc-4.4 MinGW > > compilers, includin

[HACKERS] Automatic PG_PRINTF_ATTRIBUTE

2014-11-21 Thread Noah Misch
pg_config_manual.h has been choosing gnu_printf as the PG_PRINTF_ATTRIBUTE for every MinGW build. That invites a torrent of warnings on pre-gcc-4.4 MinGW compilers, including the compiler on buildfarm member narwhal. I'm increasingly using an affected compiler, because it builds twice as quickly

Re: [HACKERS] Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

2014-11-14 Thread Noah Misch
On Fri, Nov 14, 2014 at 08:39:28PM -0500, Stephen Frost wrote: > * Noah Misch (n...@leadboat.com) wrote: > > So, if you desire to make this consistent, I recommend using > > rolreplication's > > treatment as the gold standard. That is to say, when dumping from an older

Re: [HACKERS] Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

2014-11-14 Thread Noah Misch
On Fri, Nov 14, 2014 at 11:47:49AM -0500, Stephen Frost wrote: > > On Fri, Nov 14, 2014 at 11:24:20AM -0500, Tom Lane wrote: > > > I think Noah is arguing for leaving the pg_dumpall queries as they > > > stand. I disagree, but he's entitled to his opinion. > Ah, ok. I'm impartial, but I do note

Re: [HACKERS] Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

2014-11-14 Thread Noah Misch
On Fri, Nov 14, 2014 at 11:24:20AM -0500, Tom Lane wrote: > Stephen Frost writes: > > * Noah Misch (n...@leadboat.com) wrote: > >> I'd agree for a new design, but I see too little to gain from changing it > >> now. > >> Today's behavior is fine

Re: [HACKERS] Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

2014-11-14 Thread Noah Misch
On Fri, Nov 14, 2014 at 08:35:25AM -0500, Stephen Frost wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: > > Noah Misch writes: > > > On Thu, Nov 13, 2014 at 08:24:36PM -0500, Stephen Frost wrote: > > >> Agreed. I'll take care of both and we'll make sure th

[HACKERS] Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

2014-11-13 Thread Noah Misch
On Thu, Nov 13, 2014 at 08:24:36PM -0500, Stephen Frost wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: > > What's bothering me is that I see this in pg_dumpall output from a 9.4 > > or earlier database: > > > > ALTER ROLE postgres WITH SUPERUSER INHERIT CREATEROLE CREATEDB LOGIN > > REPLICATION

Re: [HACKERS] Race in "tablespace" test on Windows

2014-11-12 Thread Noah Misch
On Tue, Nov 11, 2014 at 10:21:26AM +0530, Amit Kapila wrote: > On Sat, Nov 8, 2014 at 10:34 AM, Noah Misch wrote: > > Here is a briefer command sequence exhibiting the same problem: > > > > CREATE TABLESPACE testspace LOCATION '...somewhere...'; > > C

[HACKERS] Race in "tablespace" test on Windows

2014-11-07 Thread Noah Misch
In my Windows development environment, the tablespace regression test fails approximately half the time. Buildfarm member frogmouth failed in the same manner at least once: http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=frogmouth&dt=2014-05-21%2014%3A30%3A01 Here is a briefer command sequ

Re: [HACKERS] TAP test breakage on MacOS X

2014-11-03 Thread Noah Misch
On Mon, Nov 03, 2014 at 04:40:39PM -0500, Tom Lane wrote: > Peter Eisentraut writes: > > I thank you for this research, but I suggest that we ship 9.4 as is, > > that is with requiring IPC::Run and --enable-* option. All the possible > > alternatives will clearly need more rounds of portability t

Re: [HACKERS] Silly coding in pgcrypto

2014-11-02 Thread Noah Misch
On Sun, Nov 02, 2014 at 10:53:27PM +0100, Marko Tiikkaja wrote: > On 11/2/14, 10:34 PM, Noah Misch wrote: > >On Sun, Nov 02, 2014 at 05:10:25AM +0100, Marko Tiikkaja wrote: > >>*** a/contrib/pgcrypto/pgp-decrypt.c > >>--- b/contrib/pgcrypto/pgp-decrypt.c > >&

Re: [HACKERS] Silly coding in pgcrypto

2014-11-02 Thread Noah Misch
On Sun, Nov 02, 2014 at 05:10:25AM +0100, Marko Tiikkaja wrote: > *** a/contrib/pgcrypto/pgp-decrypt.c > --- b/contrib/pgcrypto/pgp-decrypt.c > *** > *** 1069,1075 pgp_skip_packet(PullFilter *pkt) > > while (res > 0) > res = pullf_read(pkt, 32 * 1024, &tmp);

Re: [HACKERS] TAP test breakage on MacOS X

2014-11-02 Thread Noah Misch
On Thu, Oct 30, 2014 at 01:57:15AM -0400, Noah Misch wrote: > On Wed, Oct 29, 2014 at 08:14:07PM -0400, Peter Eisentraut wrote: > > On 10/28/14 9:09 PM, Peter Eisentraut wrote: > > > I have looked into IPC::Cmd, but the documentation keeps telling me that > > > to do any

Re: [HACKERS] infinite loop in _bt_getstackbuf

2014-10-31 Thread Noah Misch
On Fri, Oct 31, 2014 at 10:29:53AM -0400, Robert Haas wrote: > On Thu, Oct 30, 2014 at 11:45 PM, Noah Misch wrote: > >> Given the lack of prior complaints about this > >> loop, I'm not sure I see the need to work harder than that; corruption > >> of this sor

Re: [HACKERS] TAP test breakage on MacOS X

2014-10-30 Thread Noah Misch
On Thu, Oct 30, 2014 at 10:49:33PM -0400, Tom Lane wrote: > Andrew Dunstan writes: > > There are other issues. I am not going to enable this in the buildfarm > > until the check test can work from a single install. It's insane for the > > bin tests to take an order of magnitude longer than the m

Re: [HACKERS] infinite loop in _bt_getstackbuf

2014-10-30 Thread Noah Misch
On Thu, Oct 30, 2014 at 03:52:01PM -0400, Tom Lane wrote: > Alvaro Herrera writes: > > Robert Haas wrote: > >> A colleague at EnterpriseDB today ran into a situation on PostgreSQL > >> 9.3.5 where the server went into an infinite loop while attempting a > >> VACUUM FREEZE; it couldn't escape _bt_g

Re: [HACKERS] TAP test breakage on MacOS X

2014-10-30 Thread Noah Misch
On Thu, Oct 30, 2014 at 04:54:25PM +0100, Andres Freund wrote: > On 2014-10-30 01:57:15 -0400, Noah Misch wrote: > > On Wed, Oct 29, 2014 at 08:14:07PM -0400, Peter Eisentraut wrote: > > > On 10/28/14 9:09 PM, Peter Eisentraut wrote: > > > > I have looked into IPC::Cm

Re: [HACKERS] TAP test breakage on MacOS X

2014-10-29 Thread Noah Misch
On Wed, Oct 29, 2014 at 08:14:07PM -0400, Peter Eisentraut wrote: > On 10/28/14 9:09 PM, Peter Eisentraut wrote: > > I have looked into IPC::Cmd, but the documentation keeps telling me that > > to do anything interesting I have to have IPC::Run anyway. I'll give it > > a try, though. > > I tried

Re: [HACKERS] Validating CHECK constraints with SPI

2014-10-29 Thread Noah Misch
On Wed, Oct 29, 2014 at 10:24:26AM -0400, Tom Lane wrote: > Dan Robinson writes: > > Since the table is locked to updates while the constraint is validating, > > this means you have to jump through hoops if you want to add a CHECK > > constraint to a large table in a production setting. This valid

Re: [HACKERS] Allow peer/ident to fall back to md5?

2014-10-28 Thread Noah Misch
On Wed, Oct 29, 2014 at 10:52:38AM +0800, Craig Ringer wrote: > On 10/29/2014 10:45 AM, Tom Lane wrote: > > Craig Ringer writes: > >> At pgconf-eu Álvaro and I were discussing the idea of allowing 'peer' > >> and 'ident' authentication to fall back to md5 if the peer/ident check > >> failed. > >

Re: [HACKERS] TAP test breakage on MacOS X

2014-10-27 Thread Noah Misch
On Mon, Oct 27, 2014 at 12:31:56PM -0400, Tom Lane wrote: > Heikki Linnakangas writes: > > On 10/27/2014 05:41 PM, Robert Haas wrote: > >> Beyond all that, I have serious doubts about whether, even if we > >> eventually get these tests mostly working in most places, whether they > >> will actually

Re: [HACKERS] Reducing lock strength of adding foreign keys

2014-10-27 Thread Noah Misch
On Mon, Oct 27, 2014 at 08:24:15AM -0400, Robert Haas wrote: > On Sat, Oct 25, 2014 at 2:00 PM, Noah Misch wrote: > >> http://www.postgresql.org/message-id/ca+tgmoy4glsxzk0tao29-ljtcuj0sl1xwcwq51xb-hfysgi...@mail.gmail.com > >> http://www.postgresql.org/message-id/20893.139

Re: [HACKERS] narwhal and PGDLLIMPORT

2014-10-26 Thread Noah Misch
On Wed, Oct 22, 2014 at 12:12:36AM -0400, Noah Misch wrote: > On Mon, Oct 20, 2014 at 01:03:31AM -0400, Noah Misch wrote: > > I reproduced narwhal's problem using its toolchain on another 32-bit Windows > > Server 2003 system. The crash happens at the SHGet

Re: [HACKERS] Reducing lock strength of adding foreign keys

2014-10-25 Thread Noah Misch
On Fri, Oct 24, 2014 at 12:07:42PM -0400, Robert Haas wrote: > I think instead of focusing on foreign keys, we should rewind a bit > and think about the locking level required to add a trigger. Agreed. > http://www.postgresql.org/message-id/ca+tgmoy4glsxzk0tao29-ljtcuj0sl1xwcwq51xb-hfysgi...@mail

Re: [HACKERS] narwhal and PGDLLIMPORT

2014-10-21 Thread Noah Misch
On Mon, Oct 20, 2014 at 01:03:31AM -0400, Noah Misch wrote: > I reproduced narwhal's problem using its toolchain on another 32-bit Windows > Server 2003 system. The crash happens at the SHGetFolderPath() call in > pqGetHomeDirectory(). A program can acquire that function via s

Re: [HACKERS] narwhal and PGDLLIMPORT

2014-10-20 Thread Noah Misch
On Mon, Oct 20, 2014 at 10:24:47PM +0200, Andres Freund wrote: > On 2014-10-20 01:03:31 -0400, Noah Misch wrote: > > On Wed, Oct 15, 2014 at 12:53:03AM -0400, Noah Misch wrote: > > I happened to try the same contrib/dblink test suite on PostgreSQL built > > with > > m

Re: [HACKERS] narwhal and PGDLLIMPORT

2014-10-20 Thread Noah Misch
On Mon, Oct 20, 2014 at 11:06:54AM -0400, Tom Lane wrote: > Noah Misch writes: > > I don't expect to understand the mechanism > > behind it, but I recommend we switch back to linking libpq with shell32.dll. > > The MSVC build already does that in all supported branche

Re: [HACKERS] narwhal and PGDLLIMPORT

2014-10-19 Thread Noah Misch
On Wed, Oct 15, 2014 at 12:53:03AM -0400, Noah Misch wrote: > On Tue, Oct 14, 2014 at 07:07:17PM -0400, Tom Lane wrote: > > Dave Page writes: > > > On Tue, Oct 14, 2014 at 11:38 PM, Tom Lane wrote: > > >> I think we're hoping that somebody will step up a

Re: [HACKERS] narwhal and PGDLLIMPORT

2014-10-14 Thread Noah Misch
On Tue, Oct 14, 2014 at 07:07:17PM -0400, Tom Lane wrote: > Dave Page writes: > > On Tue, Oct 14, 2014 at 11:38 PM, Tom Lane wrote: > >> I think we're hoping that somebody will step up and investigate how > >> narwhal's problem might be fixed. I have planned to look at reproducing narwhal's prob

Re: [HACKERS] split builtins.h to quote.h

2014-10-11 Thread Noah Misch
On Sat, Oct 11, 2014 at 11:43:46PM +0200, Andres Freund wrote: > On 2014-10-11 17:19:27 -0400, Noah Misch wrote: > > On Sat, Oct 11, 2014 at 10:44:39AM -0300, Alvaro Herrera wrote: > > > Started a new thread to raise awareness. > > > > > Ref: this comes fro

Re: [HACKERS] split builtins.h to quote.h

2014-10-11 Thread Noah Misch
On Sat, Oct 11, 2014 at 10:44:39AM -0300, Alvaro Herrera wrote: > Started a new thread to raise awareness. > Ref: this comes from > http://www.postgresql.org/message-id/cab7npqr1ivd5r_qn_ngmkbolqmagbosj4wnpo8eybnn6we_...@mail.gmail.com Thanks. You can assume I'm -1 on every header split proposal

Re: [HACKERS] orangutan seizes up during isolation-check

2014-10-10 Thread Noah Misch
On Fri, Oct 10, 2014 at 09:14:38PM -0400, Peter Eisentraut wrote: > On 10/10/14 8:24 PM, Noah Misch wrote: > > Here's an implementation thereof covering both backend and frontend use of > > setlocale(). A setlocale() wrapper, pg_setlocale(), injects use of the > &g

Re: [HACKERS] orangutan seizes up during isolation-check

2014-10-10 Thread Noah Misch
On Mon, Sep 15, 2014 at 12:51:14AM -0400, Noah Misch wrote: > 1. Fork, call setlocale(LC_x, "") in the child, pass back the effective locale >name through a pipe, and pass that name to setlocale() in the original >process. The short-lived child will get the ext

[HACKERS] Re: Failure with make check-world for pgtypeslib/dt_test2 with HEAD on OSX

2014-10-07 Thread Noah Misch
On Mon, Oct 06, 2014 at 08:57:54PM -0400, Tom Lane wrote: > I eventually realized that the critical difference was you'd added > "CFLAGS=" to the configure call. On this platform that has the net > effect of removing -O2 from the compiler flags, and apparently that > shifts around the stack layout

Re: [HACKERS] Securing "make check" (CVE-2014-0067)

2014-09-20 Thread Noah Misch
On Sun, Mar 02, 2014 at 11:36:41PM +0100, Magnus Hagander wrote: > On Sun, Mar 2, 2014 at 7:27 PM, Tom Lane wrote: > > > Noah Misch writes: > > > One option that would simplify things is to fix only non-Windows in the > > back > > > branches, via socket prot

Re: [HACKERS] orangutan seizes up during isolation-check

2014-09-15 Thread Noah Misch
On Mon, Sep 15, 2014 at 10:11:57AM +0300, Heikki Linnakangas wrote: > On 09/15/2014 07:51 AM, Noah Misch wrote: > >libintl replaces setlocale(). Its setlocale(LC_x, "") uses OS-specific APIs > >to determine the default locale when $LANG and similar environment variables

Re: [HACKERS] orangutan seizes up during isolation-check

2014-09-14 Thread Noah Misch
On Tue, Sep 02, 2014 at 12:25:39AM -0400, Tom Lane wrote: > Noah Misch writes: > > Buildfarm member orangutan has failed chronically on both of the branches > > for > > which it still reports, HEAD and REL9_1_STABLE, for over two years. The > > postmaster appears to

Re: [HACKERS] Adding a nullable DOMAIN column w/ CHECK

2014-09-07 Thread Noah Misch
On Sun, Sep 07, 2014 at 01:06:04PM -0400, Tom Lane wrote: > Noah Misch writes: > > On Sat, Sep 06, 2014 at 02:01:32AM +0200, Marko Tiikkaja wrote: > >> To do this optimization we do have to assume that CHECKs in > >> DOMAINs are at least STABLE, but I don't s

Re: [HACKERS] Patch for psql History Display on MacOSX

2014-09-06 Thread Noah Misch
On Sat, Sep 06, 2014 at 11:40:02PM -0400, Tom Lane wrote: > I only tried this directly on Tiger, Snow Leopard, and Mavericks. I > tested libedit-28 by compiling from source on a RHEL machine, so it's > possible that there's some difference between what I tested and what > Apple's really shipping.

Re: [HACKERS] Adding a nullable DOMAIN column w/ CHECK

2014-09-06 Thread Noah Misch
On Sat, Sep 06, 2014 at 02:01:32AM +0200, Marko Tiikkaja wrote: > First of all, sorry about breaking the thread; I don't subscribe to > -general so I can't copy the original email. This is in response to > the problem here: > http://www.postgresql.org/message-id/CACfv+p+8dToaR7h06_M_YMjpV5Na-CQq7

Re: [HACKERS] Patch for psql History Display on MacOSX

2014-09-05 Thread Noah Misch
On Thu, Sep 04, 2014 at 07:51:03AM -0700, Tom Lane wrote: > Noah Misch writes: > > I tried your patches against libedit-28. Wherever a command contains a > > newline, unpatched psql writes the three bytes "\^A" to the history file, > > and > > pat

Re: [HACKERS] Patch for psql History Display on MacOSX

2014-09-05 Thread Noah Misch
On Thu, Sep 04, 2014 at 09:54:37AM -0400, Robert Haas wrote: > One point to note is that not back-patching this doesn't really fix > anything. Will a user be annoyed when .psql_history fails to reload > properly on a new minor release, but utterly indifferent to whether it > reloads in a new major

Re: [HACKERS] Patch for psql History Display on MacOSX

2014-09-02 Thread Noah Misch
On Tue, Sep 02, 2014 at 09:49:56AM -0400, Tom Lane wrote: > Noah Misch writes: > > I'm with you that far. Given a patch that does not change "\s /tmp/foo" and > > that makes "\s" equivalent to "\s /tmp/foo" + "\! cat /tmp/foo >/dev/t

Re: [HACKERS] Patch for psql History Display on MacOSX

2014-09-02 Thread Noah Misch
On Tue, Sep 02, 2014 at 01:56:34AM -0400, Tom Lane wrote: > Noah Misch writes: > > On Mon, Sep 01, 2014 at 10:22:57PM -0400, Tom Lane wrote: > >> Also, as best I can tell, .psql_history files from older libedit versions > >> are not forward-compatible to current libe

Re: [HACKERS] Patch for psql History Display on MacOSX

2014-09-01 Thread Noah Misch
On Mon, Sep 01, 2014 at 10:22:57PM -0400, Tom Lane wrote: > Noah Misch writes: > > On Mon, Sep 01, 2014 at 02:05:37PM -0400, Tom Lane wrote: > >> Functionally this seems like a clear win over what we had, especially > >> since it supports using the pager. I'm incl

[HACKERS] orangutan seizes up during isolation-check

2014-09-01 Thread Noah Misch
Buildfarm member orangutan has failed chronically on both of the branches for which it still reports, HEAD and REL9_1_STABLE, for over two years. The postmaster appears to jam during isolation-check. Dave, orangutan currently has one such jammed postmaster for each branch. Could you gather some

Re: [HACKERS] Patch for psql History Display on MacOSX

2014-09-01 Thread Noah Misch
On Mon, Sep 01, 2014 at 02:05:37PM -0400, Tom Lane wrote: > Functionally this seems like a clear win over what we had, especially > since it supports using the pager. I'm inclined to think we should > not only apply this change but back-patch it. > > One thing worth thinking about: should we use

[HACKERS] Re: [BUGS] Re: BUG #9555: pg_dump for tables with inheritance recreates the table with the wrong order of columns

2014-09-01 Thread Noah Misch
On Sat, Aug 30, 2014 at 07:32:26PM -0400, Bruce Momjian wrote: > On Wed, Aug 27, 2014 at 09:40:30PM -0400, Noah Misch wrote: > > > > 3. use the pg_dump binary-upgrade code when such cases happen > > > > +1. We have the convention that, while --binary-upgrade c

Re: [HACKERS] What in the world is happening with castoroides and protosciurus?

2014-08-30 Thread Noah Misch
On Tue, Aug 26, 2014 at 10:17:05AM +0100, Dave Page wrote: > On Tue, Aug 26, 2014 at 1:46 AM, Tom Lane wrote: > > For the last month or so, these two buildfarm animals (which I believe are > > the same physical machine) have been erratically failing with errors that > > reflect low-order differenc

Re: [HACKERS] Removing dependency to wsock32.lib when compiling code on WIndows

2014-08-29 Thread Noah Misch
On Thu, Aug 21, 2014 at 11:29:31PM -0400, Noah Misch wrote: > On Thu, Aug 21, 2014 at 09:18:22AM -0400, Andrew Dunstan wrote: > > What's happening about this? Buildfarm animal jacana is consistently > > red because of this. > > If nobody plans to do the aforementione

[HACKERS] Re: [BUGS] Re: BUG #9555: pg_dump for tables with inheritance recreates the table with the wrong order of columns

2014-08-27 Thread Noah Misch
On Wed, Aug 27, 2014 at 11:24:53AM -0400, Tom Lane wrote: > On Wed, Aug 27, 2014 at 10:40:53AM -0400, Bruce Momjian wrote: > > I looked at this issue from March and I think we need to do something. > > In summary, the problem is that tables using inheritance can be dumped > > and reloaded with col

Re: [HACKERS] SSL renegotiation

2014-08-25 Thread Noah Misch
On Mon, Aug 25, 2014 at 11:46:13PM -0400, Alvaro Herrera wrote: > Tom Lane wrote: > > OK, then maybe end-of-beta is too long. But how much testing will it get > > during development? I know I never use SSL on development installs. > > How many hackers do? > > Just a reminder that I intend to bac

Re: [HACKERS] Removing dependency to wsock32.lib when compiling code on WIndows

2014-08-23 Thread Noah Misch
On Fri, Aug 22, 2014 at 04:58:47PM +0900, Michael Paquier wrote: > Looking more into that, I am seeing that MinGW-32 is failing to find socket > at configure, contrary to MinGW-64. > > Here is what happens for MinGW-64 at configure: > configure:7638: checking for library containing socket > [...]

Re: [HACKERS] Proposal to add a QNX 6.5 port to PostgreSQL

2014-08-22 Thread Noah Misch
On Fri, Aug 22, 2014 at 09:34:42AM +0200, Andres Freund wrote: > On 2014-08-22 01:36:37 -0400, Noah Misch wrote: > > On Thu, Aug 21, 2014 at 01:33:38AM +0200, Andres Freund wrote: > > > On 2014-07-25 18:29:53 -0400, Tom Lane wrote: > > > > > * QNX lacks

Re: [HACKERS] Proposal to add a QNX 6.5 port to PostgreSQL

2014-08-21 Thread Noah Misch
On Thu, Aug 21, 2014 at 01:33:38AM +0200, Andres Freund wrote: > On 2014-07-25 18:29:53 -0400, Tom Lane wrote: > > > * QNX lacks sigaction SA_RESTART: I modified "src/include/port.h" > > > to define macros to retry system calls upon EINTR (open,read,write,...) > > > when compiled on QNX >

Re: [HACKERS] Removing dependency to wsock32.lib when compiling code on WIndows

2014-08-21 Thread Noah Misch
On Thu, Aug 21, 2014 at 09:18:22AM -0400, Andrew Dunstan wrote: > > On 08/15/2014 11:00 PM, Noah Misch wrote: > >On Fri, Aug 15, 2014 at 12:49:36AM -0700, Michael Paquier wrote: > >>Btw, how do you determine if MSVC is using HAVE_GETADDRINFO? Is it > >>decided by the

Re: [HACKERS] inherit support for foreign tables

2014-08-21 Thread Noah Misch
On Wed, Aug 20, 2014 at 08:11:01PM +0900, Etsuro Fujita wrote: > (2014/07/02 11:23), Noah Misch wrote: > >Your chosen ANALYZE behavior is fair, but the messaging from a database-wide > >ANALYZE VERBOSE needs work: > > > >INFO: analyzing "test_foreign_inherit.paren

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-08-19 Thread Noah Misch
On Mon, Aug 18, 2014 at 12:30:40PM +0100, Greg Stark wrote: > On Tue, Aug 5, 2014 at 3:41 AM, Noah Misch wrote: > > This remains open for 9.4. Your proposal to revert the feature in 9.4 and > > fix > > it in 9.5 sounds reasonable. > > Ok, I've gone ahead and don

Re: [HACKERS] Improvement of versioning on Windows, take two

2014-08-18 Thread Noah Misch
Committed after making several fixes, notably: On Thu, Aug 14, 2014 at 03:59:57PM +0900, Michael Paquier wrote: > --- a/src/test/isolation/Makefile > +++ b/src/test/isolation/Makefile > @@ -6,12 +6,15 @@ subdir = src/test/isolation > top_builddir = ../../.. > include $(top_builddir)/src/Makefile

Re: [HACKERS] strncpy is not a safe version of strcpy

2014-08-18 Thread Noah Misch
On Fri, Aug 15, 2014 at 11:26:55PM -0400, Noah Misch wrote: > Barring objections, I will commit your latest patch with some comments about > why truncation is harmless for those two particular calls. Done. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make chan

Re: [HACKERS] Proposal to add a QNX 6.5 port to PostgreSQL

2014-08-18 Thread Noah Misch
On Mon, Aug 18, 2014 at 09:01:20AM -0400, Robert Haas wrote: > On Sat, Aug 16, 2014 at 3:28 AM, Noah Misch wrote: > >> I'd be afraid that a secondary mechanism that mostly-but-not-really > >> works could do more harm by allowing us to miss bugs in the primary, > &g

Re: [HACKERS] Proposal to add a QNX 6.5 port to PostgreSQL

2014-08-16 Thread Noah Misch
#x27;s still alive or not. People can and do > write extensions that launch processes from PostgreSQL backends via > fork()+exec(), and we've taken pains in the past not to break such > cases. I don't see a reason to impose now (for no > data-integrity-related reason) the

[HACKERS] Sample LDIF for pg_service.conf no longer works

2014-08-15 Thread Noah Misch
ot;xyz" is not an LDAP DN attribute type. Amid the LDAP core schema, "device" is the best-fitting objectClass having the generality required. Let's convert to that, as attached. I have verified that this works end-to-end. Thanks, nm [1] http://www.postgresql.org/docs/devel/static

Re: [HACKERS] strncpy is not a safe version of strcpy

2014-08-15 Thread Noah Misch
On Sat, Aug 16, 2014 at 10:38:39AM +1200, David Rowley wrote: > On Thu, Aug 14, 2014 at 4:13 PM, Noah Misch wrote: > > > I share your (Kevin's) discomfort with our use of strlcpy(). I wouldn't > > mind > > someone replacing most strlcpy()/snprintf() cal

<    4   5   6   7   8   9   10   11   12   13   >