://www.postgresql.org/message-id/20130124021205.gb29...@tornado.leadboat.com
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org
On Tue, Jun 25, 2013 at 03:01:52PM +0200, Andres Freund wrote:
On 2013-06-24 21:35:53 -0400, Noah Misch wrote:
Simple enough, yes. The other point still stands.
You mean performance? Primarily I still think we should first worry
about correctness first and then about performance. And CASE
On Tue, Jun 25, 2013 at 11:17:47PM -0400, Peter Eisentraut wrote:
On Sun, 2013-06-23 at 16:03 -0400, Noah Misch wrote:
((c-mode . ((c-basic-offset . 4)
(fill-column . 79)
I don't know whether you'd consider it to fall within the scope of this
update, but 78 is the fill
On Mon, Jun 24, 2013 at 04:00:00PM +0400, Alexander Law wrote:
Thanks for your work, your patch is definitely better. I agree that this
approach much more generic.
Committed.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers
like removing the data
copy. What's your opinion of copying pgcrypto's md5 implementation, which
already avoids the data copy?
Thanks,
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org
On Wed, Jun 26, 2013 at 09:04:34PM +0100, Dean Rasheed wrote:
On 26 June 2013 19:32, Noah Misch n...@leadboat.com wrote:
On Mon, Jun 17, 2013 at 11:34:52AM +0100, Dean Rasheed wrote:
md5_agg() is well-defined and not cryptographically novel, and your use case
is credible. However
On Mon, Jun 24, 2013 at 01:41:51PM +, Albe Laurenz wrote:
Noah Misch wrote:
If fixing the behaviour is undesirable, at least the documentation
should be fixed.
A brief documentation mention sounds fine. Perhaps add a paragraph on
constant folding in general and reference that from
On Wed, Jun 26, 2013 at 03:48:23PM -0700, Jeff Janes wrote:
On Mon, May 13, 2013 at 7:26 AM, Noah Misch n...@leadboat.com wrote:
This patch introduces MemoryContextAllocHuge() and repalloc_huge() that
check
a higher MaxAllocHugeSize limit of SIZE_MAX/2. Chunks don't bother
recording
of a schema, at which point it would
legitimately choose to leave that field unpopulated. Once we allow any part
of the system to generate such errors, we should let PL/pgSQL do the same.
Thoughts on that plan?
--
Noah Misch
EnterpriseDB http
On Fri, Jun 28, 2013 at 07:49:46AM +0200, Pavel Stehule wrote:
2013/6/28 Noah Misch n...@leadboat.com:
On Tue, Jun 25, 2013 at 03:56:27PM +0200, Pavel Stehule wrote:
cleaned patch is in attachment
Of the five options you're adding to GET STACKED DIAGNOSTICS, four of them
appear
git grep 'makeNode(FuncCall)'. The advantage could go either way depending
on your tooling, though.
By having each call site only mention the seldom-used fields for which it does
something special, the distinctive aspects of the call site stand out better.
That's a nice advantage.
--
Noah Misch
On Fri, Jun 28, 2013 at 03:31:00PM +0200, Pavel Stehule wrote:
Hello
2013/6/28 Noah Misch n...@leadboat.com:
On Fri, Jun 28, 2013 at 07:49:46AM +0200, Pavel Stehule wrote:
2013/6/28 Noah Misch n...@leadboat.com:
On Tue, Jun 25, 2013 at 03:56:27PM +0200, Pavel Stehule wrote:
cleaned
On Fri, Jun 28, 2013 at 05:21:29PM +0200, Pavel Stehule wrote:
2013/6/28 Noah Misch n...@leadboat.com:
Okay. I failed to note the first time through that while the patch uses the
same option names for RAISE and GET STACKED DIAGNOSTICS, the existing option
lists for those commands differ
that if these new tests should appear elsewhere, some of our existing tests
should also move there.
Thanks,
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription
On Fri, Jun 28, 2013 at 12:08:21PM -0400, Noah Misch wrote:
On Fri, Jun 28, 2013 at 05:21:29PM +0200, Pavel Stehule wrote:
2013/6/28 Noah Misch n...@leadboat.com:
Okay. I failed to note the first time through that while the patch uses
the
same option names for RAISE and GET STACKED
On Wed, Jul 03, 2013 at 06:17:18AM +0200, Pavel Stehule wrote:
2013/7/2 Noah Misch n...@leadboat.com:
Here's a revision bearing the discussed name changes and protocol
documentation tweaks, along with some cosmetic adjustments. If this seems
good to you, I will commit it.
+1
Done
the potential cost of a bug. A
spreadsheet program might reasonably have a different perspective on a surge
of submissions. For PostgreSQL, figuring out how to review them is key.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers
documentation mention. Seeing that this narrows the range of
valid MV queries, I bring it up now so MVs can debut with the restrictions
already in place.
Thanks,
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
diff --git a/doc/src/sgml/ref
to the consensus here.
Has this progressed?
Should we consider this a 9.3 release blocker? sepgsql already has a red box
warning about its limitations, so adding the limitation that materialized
views are unrestricted wouldn't be out of the question.
Thanks,
nm
--
Noah Misch
EnterpriseDB
see what the patch looks like.
Thanks,
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, Jul 05, 2013 at 11:18:50PM -0700, Hitoshi Harada wrote:
On Fri, Jul 5, 2013 at 9:45 AM, Noah Misch n...@leadboat.com wrote:
REFRESH MATERIALIZED VIEW should temporarily switch the current user ID to
the
MV owner. REINDEX and VACUUM do so to let privileged users safely maintain
to transfer the other. Having API coverage for just one
makes it easier for hackers to miss that.
Thanks,
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your
On Sun, Jul 07, 2013 at 08:55:01PM -0400, Peter Eisentraut wrote:
On Sun, 2013-07-07 at 20:15 -0400, Noah Misch wrote:
I mildly recommend we reject this patch as such, remove the TODO item,
remove
the XXX comments this patch removes, and plan not to add more trivial
SPI
wrappers
On Sun, Jul 07, 2013 at 08:15:00PM -0400, Noah Misch wrote:
I mildly recommend we reject this patch as such, remove the TODO item, remove
the XXX comments this patch removes, and plan not to add more trivial SPI
wrappers.
Seeing just the one response consistent with that view, done.
--
Noah
or negative value.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
While doing some post-commit review of the 9.3 materialized view feature, I
noticed a few loose ends:
On Thu, Jan 24, 2013 at 01:09:28PM -0500, Noah Misch wrote:
Note that [...] ALTER TABLE ... RENAME CONSTRAINT [is]
currently supported for MVs by ALTER TABLE but not by ALTER MATERIALIZED VIEW
the sole named author of this patch? That's what the CF page says,
but that wasn't fully clear to me from the list discussions.
Thanks,
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
*** a/src/backend/optimizer/plan/planagg.c
--- b/src/backend/optimizer/plan
On Mon, Jul 15, 2013 at 06:56:17PM +, Andrew Gierth wrote:
Noah Misch said:
I twitched upon reading this, because neither ORDER BY nor FILTER preclude
the aggregate being MIN or MAX. Perhaps Andrew can explain why he put
aggorder there back in 2009.
The bottom line is that I
SnapshotNow here; however, I'm assuming we would otherwise manage to
remove SnapshotNow entirely.
Thanks,
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
diff --git a/src/backend/access/index/genam.c b/src/backend/access/index/genam.c
index 2bfe78a..2fecc88 100644
On Tue, Jul 16, 2013 at 05:56:10PM +0200, Andres Freund wrote:
On 2013-07-16 09:50:07 -0400, Noah Misch wrote:
With \c, in general, you may end up executing commands under the new
session
before the old backend has finished exiting. For this test case
specifically,
the two backends
On Tue, Jul 16, 2013 at 10:41:44AM -0700, David Fetter wrote:
On Fri, Jul 12, 2013 at 08:51:52PM -0400, Noah Misch wrote:
Agreed. The OpenSSL Project last applied a security fix to 0.9.6
over eight years ago. Compatibility with 0.9.6 has zero or negative
value.
You've made a persuasive
or equivalent.
Committed with hopefully-better comments. Thanks.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql
On Mon, Jul 15, 2013 at 11:43:04AM -0700, David Fetter wrote:
On Sun, Jul 14, 2013 at 10:15:12PM -0400, Noah Misch wrote:
See attached patch revisions. The first patch edits
find_minmax_aggs_walker()
per my comments just now. The second is an update of your FILTER patch
the standard hypothetical set function names. Or you could add a second
CREATE AGGREGATE option requesting hypothetical-set-function deparse style.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers
a blank line between an #if
and a multi-line comment, like at the top of get_restricted_token().
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http
decide to
remove every core use, third-party code might legitimately reach a different
conclusion on similar borderline cases.
Thanks,
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org
.
Thanks,
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, Jul 19, 2013 at 07:34:14PM -0400, Tom Lane wrote:
Noah Misch n...@leadboat.com writes:
On Fri, Jul 05, 2013 at 02:47:06PM -0400, Tom Lane wrote:
So I'm inclined to propose that SPI itself should offer some mechanism
for cleaning up tuple tables at subtransaction abort. We could
On Sun, Jul 21, 2013 at 11:44:51AM +0300, Ants Aasma wrote:
On Jul 21, 2013 4:06 AM, Noah Misch n...@leadboat.com wrote:
If these hooks will need to apply to a larger operation, I
think that mandates a different means to reliably expose the before/after
object states.
I haven't checked
from related heap consistency problems such as duplicate keys?
Thanks,
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
*** a/src/backend/commands/indexcmds.c
--- b/src/backend/commands/indexcmds.c
***
*** 1768,1774 ReindexTable(RangeVar
behavior change,
we should do something like leave the behavior and change the documentation
instead. I personally vote no, but that alternative seemed credible enough
to justify mentioning it. Something more radical, like a new UI, would be a
separate patch.
Thanks,
nm
--
Noah Misch
EnterpriseDB
On Sun, Jul 21, 2013 at 12:40:38PM -0400, Tom Lane wrote:
Noah Misch n...@leadboat.com writes:
Reasonable enough. Code that does use subtransactions will need to be more
careful than before to manually free tuple tables in the non-error case.
Failure to do so has been creating a leak
On Mon, Jul 22, 2013 at 10:02:30PM -0400, Tom Lane wrote:
Noah Misch n...@leadboat.com writes:
On Sun, Jul 21, 2013 at 12:40:38PM -0400, Tom Lane wrote:
Hmm ... good point. The other plan I'd been considering was to add
explicit tracking inside spi.c of all tuple tables created within
.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
for suggestions..
It's the right forum.
Thanks,
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Wed, Jul 24, 2013 at 04:16:28AM +, Andrew Gierth wrote:
Noah Misch said:
Other aggregates based on this syntax might not desire such type
unification.
Then there would have to be some way to distinguish that. Maybe those could
have -1 and the standard hypothetical set functions -2
on the buildfarm status page, like we
have for the CLOBBER_CACHE_ALWAYS members. That should be enough for folks to
realize that a failure in this animal alone is more likely the fault of a new
package version than of the latest commit.
--
Noah Misch
EnterpriseDB http
trigger function does work. Compare how copy.c creates one for
some relatively-narrow purposes.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription
in AtEOXact_RelationCache().
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
it
recognizes that fact.
Thanks,
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
on Windows. It may have
independent value. Other ideas, opinions?
Thanks,
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org
at the CCI in
CommitTransactionCommand(), so the later CCI does in fact find nothing to do.
I have little confidence that should be counted upon, though.)
How might we best rearrange things to avoid these hazards?
Thanks,
nm
--
Noah Misch
EnterpriseDB http
On Thu, Aug 01, 2013 at 06:44:41PM +0200, Dimitri Fontaine wrote:
Noah Misch n...@leadboat.com writes:
2. Add a pg_basebackup option like --destdir or --sysroot, meaningful
only
with -Fp; tablespace backups will be stored relative to it. So if the
actual
tablespace path is c:/foo
On Thu, Aug 01, 2013 at 01:04:42PM -0400, Andrew Dunstan wrote:
On 08/01/2013 12:15 PM, Noah Misch wrote:
1. Include in the base backup a file listing symbolic links/junction points,
then have archive recovery recreate them. This file would be managed like
the
backup label file; exclusive
On Tue, Aug 06, 2013 at 09:06:59AM +0200, Andres Freund wrote:
On 2013-08-05 13:09:31 -0400, Noah Misch wrote:
When we call AtEOSubXact_Inval() or AtEOXact_Inval() with a relation still
open, we can potentially get a relcache rebuild and therefore a syscache
lookup as shown above
ending.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, Aug 09, 2013 at 06:59:13PM -0400, Tom Lane wrote:
Noah Misch n...@leadboat.com writes:
On Thu, Aug 08, 2013 at 10:32:17PM -0400, Tom Lane wrote:
This patch arranges to emit a hint message when/if we switch away from
logging to the original postmaster stderr during startup
.
A new implementation (or revamp of the old) must avoid reintroducing those
vulnerabilities. Similar considerations apply to XML Schema.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org
On Sat, Aug 10, 2013 at 10:57:56AM -0400, Tom Lane wrote:
Noah Misch n...@leadboat.com writes:
On Fri, Aug 09, 2013 at 06:59:13PM -0400, Tom Lane wrote:
Does that ameliorate your concern, or do you still want it to be DEBUG1?
I think of the implicit sequence messages we moved from NOTICE
disappear into the noise and
yet a dramatic improvement over the current no fixed time limit.
I bet the utils/timeout.h infrastructure added in 9.3 will make this at least
60% easier to implement than it would have been before.
--
Noah Misch
EnterpriseDB http
done.
3. Remove that block and make src/backend/port/win32/socket.c frontend-usable,
so frontend code can treat errno like backend code treats errno.
What do you recommend?
Thanks,
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql
/e1uclpd-l4...@wrigleys.postgresql.org
Perhaps only some versions of w32api trigger the problem. I agree we ought to
understand the necessary conditions before proceeding.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing
On Sun, Aug 18, 2013 at 01:02:57PM -0400, Andrew Dunstan wrote:
On 08/17/2013 01:16 AM, Noah Misch wrote:
/*
* For Microsoft Visual Studio 2010 and above we intentionally redefine
* the regular Berkeley error constants and set them to the WSA constants.
* Note that this will break
On Mon, Aug 19, 2013 at 08:46:11AM -0500, Michael Cronenworth wrote:
On 08/17/2013 12:16 AM, Noah Misch wrote:
1. Redefine those constants for more (all?) compilers.
2. Remove that block and put #ifdef around all usage of such constants in
frontend code, as you have done.
3. Remove
.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Tue, Aug 27, 2013 at 04:14:27PM +0200, Andres Freund wrote:
On 2013-06-09 17:25:59 -0400, Noah Misch wrote:
***
*** 846,851 exec_simple_query(const char *query_string)
--- 847,856
TRACE_POSTGRESQL_QUERY_START(query_string);
+ #ifdef USE_VALGRIND
the list of restrictions by searching for callers of
InSecurityRestrictedOperation(). Here is the current list for core code:
- CREATE TEMP TABLE
- SET ROLE
- SET SESSION AUTHORIZATION
- CLOSE
- PREPARE
- DEALLOCATE
- LISTEN
- UNLISTEN
- DISCARD
--
Noah Misch
EnterpriseDB
On Wed, Aug 28, 2013 at 03:16:14PM +0200, Andres Freund wrote:
On 2013-08-27 23:46:23 -0400, Noah Misch wrote:
On Tue, Aug 27, 2013 at 04:14:27PM +0200, Andres Freund wrote:
On 2013-06-09 17:25:59 -0400, Noah Misch wrote:
***
*** 846,851 exec_simple_query(const char
the
whole idea of reliable fixed addresses. But I find it acceptable if it's a
crutch for older kernels, rare hardware, etc.
I don't foresee fundamental differences on 32-bit. All the allocation
maximums scale down, but that's the usual story for 32-bit.
--
Noah Misch
EnterpriseDB
On Sun, Sep 01, 2013 at 05:08:38PM +0200, Andres Freund wrote:
On 2013-09-01 09:24:00 -0400, Noah Misch wrote:
The difficulty depends on whether processes other than the segment's creator
will attach anytime or only as they start. Attachment at startup is enough
for parallel query
them initially for conceptual simplicity.
Whether an index column uses an expression is irrelevant to each existing core
AM. How does minmax differ in this respect?
Thanks,
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers
On Tue, Sep 03, 2013 at 12:52:22AM +0200, Andres Freund wrote:
On 2013-09-01 12:07:04 -0400, Noah Misch wrote:
On Sun, Sep 01, 2013 at 05:08:38PM +0200, Andres Freund wrote:
On 2013-09-01 09:24:00 -0400, Noah Misch wrote:
The difficulty depends on whether processes other than
() formats the value.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
.
That's worth at least considering when we start to revise the protocol, so I
have added it to the TODO list.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your
On Thu, Sep 05, 2013 at 11:07:43AM +0800, wangs...@highgo.com.cn wrote:
??? 2013-09-04 19:30, Noah Misch ??:
On Wed, Sep 04, 2013 at 12:08:48PM +0800, wangs...@highgo.com.cn
wrote:
I find that it takes a long time when I increase the scale of a
numeric
datatype.
By checking the code
share
Tom's desire for a Makefile target that completes quickly and checks only
those behaviors most likely to break, but not at the cost of letting deep test
coverage dissipate in a mailing list attachment or in the feature author's
home directory.
--
Noah Misch
EnterpriseDB
start to look credible relative to the benefits.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Wed, Aug 28, 2013 at 10:30:34PM -0400, Noah Misch wrote:
On Wed, Aug 28, 2013 at 03:16:14PM +0200, Andres Freund wrote:
I vote for just removing that VALGRIND_PRINTF - it doesn't give you
anything you cannot easily achieve otherwise...
Done.
I'd like to see a buildfarm member running
localized dependencies seems like a fine coping mechanism.
If we can reasonably detect when gettext is supplying useless ? messages,
that's good, too.
Thanks,
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list
On Mon, Sep 09, 2013 at 05:49:38PM -0400, Peter Eisentraut wrote:
On 9/9/13 2:57 PM, Noah Misch wrote:
Actually, GNU libiconv's iconv() decides that //translit is unimplementable
for some of the characters in that file, and it fails the conversion. GNU
libc's iconv(), on the other hand
On Tue, Sep 10, 2013 at 05:42:06AM +0900, MauMau wrote:
From: Tom Lane t...@sss.pgh.pa.us
Noah Misch n...@leadboat.com writes:
... I think
MauMau's original bind_textdomain_codeset() proposal was on the right
track.
It might well be. My objection was to the proposal for back-patching
, mask, NULL);
}
for (;;)
sleep(1);
}
Thanks,
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
diff --git a/src/backend/tcop/postgres.c b/src/backend/tcop/postgres.c
index e56dbfb..1eaf287 100644
--- a/src/backend/tcop
On Tue, Sep 10, 2013 at 07:13:16PM -0700, David Johnston wrote:
Noah Misch-2 wrote
The errfinish() pertaining to that WARNING issues CHECK_FOR_INTERRUPTS(),
and
the query cancel pending since before the SIGQUIT arrived then takes
effect.
This is less bad on 9.4, because the postmaster
On Fri, Sep 06, 2013 at 09:55:09PM +0100, Greg Stark wrote:
On Sun, Jun 9, 2013 at 10:25 PM, Noah Misch n...@leadboat.com wrote:
- Memcheck has support for detecting leaks. I have not explored that
side at
all, always passing --leak-check=no. We could add support for freeing
patterns that permit
trivial lifespan overlap between backends of different postmasters. Opinions?
Thanks,
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your
. Why sleep at least 1
second? If time is up, it is up, why not use zero as the minimum?
Offhand, clamping to zero does make more sense to me. It looks like Alvaro
added that bit in his pre-commit edits. Alvaro?
Thanks,
nm
--
Noah Misch
EnterpriseDB http
On Wed, Sep 11, 2013 at 02:00:41PM -0400, Robert Haas wrote:
On Wed, Sep 11, 2013 at 10:38 AM, Stephen Frost sfr...@snowman.net wrote:
* Noah Misch (n...@leadboat.com) wrote:
On Tue, Sep 10, 2013 at 07:13:16PM -0700, David Johnston wrote:
Your feelings on how far to back-patch?
All
On Wed, Sep 11, 2013 at 11:32:01AM -0400, Stephen Frost wrote:
* Noah Misch (n...@leadboat.com) wrote:
The concrete situation in which I encountered this involved PostgreSQL 9.2
and
an immediate shutdown with a backend that had blocked SIGQUIT. The backend
survived the immediate
On Wed, Sep 11, 2013 at 07:57:22PM -0700, David Johnston wrote:
Noah Misch-2 wrote
Making PGSharedMemoryCreate() pickier in all branches will greatly
diminish
the marginal value of preserving postmaster.pid, so I'm fine with dropping
the
postmaster.pid side of the proposal.
Its
.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Mon, Sep 16, 2013 at 04:28:23PM +0200, Andres Freund wrote:
On 2013-09-15 19:49:26 -0400, Noah Misch wrote:
Type-specific identity operators seem like overkill, anyway. If we find
that
meaningless variations in a particular data type are causing too many false
non-matches
on the more-recent thread.
[1] http://www.postgresql.org/docs/9.3/static/functions-comparison.html
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http
benchmark of full-build time, one could
exercise the benefit of fewer header dependencies by modelling the series of
compile times from running git pull; make at each commit for the past
several months. The latter benchmark is perhaps more favorable.
nm
--
Noah Misch
EnterpriseDB
is
going to be orders of magnitude smaller.
There will also be the folks who must add heapam.h and/or genam.h includes
despite formerly getting it/them through execnodes.h. That's not ugly like
#if PG_VERSION_NUM ..., but it's still work for authors.
--
Noah Misch
EnterpriseDB
, latency, sqlat, stdev,
lag;
Why these variable type changes?
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref
place in the previous patch. Thus I fixed it.
Okay.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
which is not the case with current usage of open in dynamic
shared memory code.
#ifdef WIN32
/* use CRLF line endings on Windows */
_setmode(_fileno(fh), _O_TEXT);
#endif
I suspect that call (in logfile_open()) has no effect. The file is already in
text mode.
--
Noah Misch
EnterpriseDB
On Mon, Sep 23, 2013 at 10:43:33AM +0530, Amit Kapila wrote:
On Mon, Sep 23, 2013 at 12:34 AM, Noah Misch n...@leadboat.com wrote:
On Sun, Sep 22, 2013 at 01:17:52PM +0530, Amit Kapila wrote:
#ifdef WIN32
/* use CRLF line endings on Windows */
_setmode(_fileno(fh), _O_TEXT);
#endif
701 - 800 of 1905 matches
Mail list logo
