Re: [HACKERS] [PATCH] A hook for session start

2017-11-11 Thread Fabrízio de Royes Mello
On Sat, Nov 11, 2017 at 6:48 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > > On Sat, Nov 11, 2017 at 12:49 AM, Fabrízio de Royes Mello > <fabriziome...@gmail.com> wrote: > > New version attached. > > Thanks. > > +++ b/src/test/modul

Re: [HACKERS] [PATCH] A hook for session start

2017-11-10 Thread Fabrízio de Royes Mello
On Thu, Nov 9, 2017 at 9:08 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > > On Fri, Nov 10, 2017 at 2:32 AM, Fabrízio de Royes Mello > <fabriziome...@gmail.com> wrote: > > On Thu, Nov 9, 2017 at 12:09 AM, Michael Paquier < michael.paqu...@gmail.com&g

Re: [HACKERS] [PATCH] A hook for session start

2017-11-09 Thread Fabrízio de Royes Mello
On Thu, Nov 9, 2017 at 12:09 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > > On Thu, Nov 9, 2017 at 2:42 AM, Fabrízio de Royes Mello > <fabriziome...@gmail.com> wrote: > > On Wed, Nov 8, 2017 at 12:47 AM, Michael Paquier < michael.paqu...@gmail.com>

Re: [HACKERS] (spelling) Ensure header of postgresql.auto.conf is consistent

2017-11-09 Thread Fabrízio de Royes Mello
nce caused some false-positives on our configuration > management identifying changes, which was enough of an itch for me to > scratch. > Interesting... IMHO this typo should be backpatched to 9.4 when ALTER SYSTEM was introduced. Regards, -- Fabrízio de Royes Mello Consultoria/Coachi

Re: [HACKERS] [PATCH] A hook for session start

2017-11-08 Thread Fabrízio de Royes Mello
let's remove them. Please let's also avoid ALTER SYSTEM calls in tests > as it would impact existing installations with installcheck. > Also simplify the test code. Fixed. > Impossible to tell committer's feeling about this test suite, but my > opinion is to keep it as that's a

Re: [HACKERS] Additional logging for VACUUM and ANALYZE

2017-11-07 Thread Fabrízio de Royes Mello
gt; > Just remove the additional tab indentation before rel_lock variable. > > I've removed the extra tab in v4. > Great. Changed status to ready for commiter. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> B

Re: [HACKERS] [PATCH] A hook for session start

2017-11-07 Thread Fabrízio de Royes Mello
On Tue, Nov 7, 2017 at 1:15 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > > On Sun, Nov 5, 2017 at 3:14 AM, Fabrízio de Royes Mello > <fabriziome...@gmail.com> wrote: > > On Sat, Nov 4, 2017 at 1:23 AM, Michael Paquier < michael.paqu...@gmail.com> &g

Re: [HACKERS] [PATCH] A hook for session start

2017-11-04 Thread Fabrízio de Royes Mello
On Sat, Nov 4, 2017 at 1:23 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > > On Fri, Nov 3, 2017 at 1:55 PM, Fabrízio de Royes Mello > <fabriziome...@gmail.com> wrote: > >> Passing the database name and user name does not look much useful to > >&g

Re: [HACKERS] [PATCH] A hook for session start

2017-11-03 Thread Fabrízio de Royes Mello
On Fri, Nov 3, 2017 at 11:43 AM, Aleksandr Parfenov < a.parfe...@postgrespro.ru> wrote: > > README file in patch 0003 is a copy of README from test_pg_dump module > without any changes. > Thanks, I'll fix it. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQ

Re: [HACKERS] [PATCH] A hook for session start

2017-11-03 Thread Fabrízio de Royes Mello
true); } ... > Passing the database name and user name does not look much useful to > me. You can have access to this data already with CurrentUserId and > MyDatabaseId. > This way we don't need to convert oid to names inside hook code. Regards, -- Fabrízio de Royes

Re: [HACKERS] [PATCH] A hook for session start

2017-11-02 Thread Fabrízio de Royes Mello
ested > Documentation:not tested > > Hi, > > Unfortunately, patches 0001 and 0002 don't apply to current master. > > The new status of this patch is: Waiting on Author > Thanks for your review. Rebased versions attached. Regards, -- Fabrízio de Royes Mello Con

Re: [HACKERS] Disable cross products in postgres

2017-10-13 Thread Fabrízio de Royes Mello
wonder if it's possible implement it as an extension using some hook -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin: http://br.linkedin.com/in/fabriziomello >> Twitter: http://twitter.com/fabriziomello >> Github: http://github.com/fabriziomello

Re: [HACKERS] search path security issue?

2017-10-09 Thread Fabrízio de Royes Mello
t; users change to the GUC default and sometimes we suffer with it. Would be nice to have some kind of guc permissions. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Lin

Re: [HACKERS] [PATCH] A hook for session start

2017-10-05 Thread Fabrízio de Royes Mello
On Thu, Oct 5, 2017 at 4:14 PM, Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > > > On Tue, Aug 1, 2017 at 4:55 PM, Robert Haas <robertmh...@gmail.com> wrote: > > > > On Tue, Aug 1, 2017 at 3:37 PM, Peter Eisentraut > > <peter.eisentr...@2

Re: [HACKERS] [PATCH] A hook for session start

2017-10-05 Thread Fabrízio de Royes Mello
org/message-id/758d5e7f0803130227m558d32cdl7159bed00d21f084%40mail.gmail.com > (2008) > https://www.postgresql.org/message-id/001a01c48077%240b118e60%240200030a%40gendron.ca > (2004) > https://www.postgresql.org/message-id/f96sgcorblsaqv6updv0...@hotmail.com > (2000) > Hi all

[HACKERS] Segmentation Fault during pg_restore using '--use-list' and '--jobs'

2017-08-18 Thread Fabrízio de Royes Mello
Hi all, I'm facing a 'segmentation fault' error using '--use-list' and '--jobs' options after update to 9.5.8. We generate a list ignoring some 'TABLE DATA' toc for a selective restore. See the test case below: cat < /tmp/test_restore.dump.list -- rebuild database cat

Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump

2017-08-07 Thread Fabrízio de Royes Mello
leanly to current master and all tests run without failures. I also test against all current supported versions (9.2 ... 9.6) and didn't find any issue. Changed status to "ready for commiter". Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin: http://br.linkedin.com/in/fabriziomello >> Twitter: http://twitter.com/fabriziomello >> Github: http://github.com/fabriziomello

Re: [HACKERS] [PATCH] A hook for session start

2017-07-21 Thread Fabrízio de Royes Mello
On Fri, Jul 21, 2017 at 12:19 PM, Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > > On Fri, Jul 21, 2017 at 10:58 AM, Yugo Nagata <nag...@sraoss.co.jp> wrote: > > > > On Fri, 21 Jul 2017 10:31:57 -0300 > > Fabrízio de Royes Mello <fabriziome.

Re: [HACKERS] [PATCH] A hook for session start

2017-07-21 Thread Fabrízio de Royes Mello
On Fri, Jul 21, 2017 at 10:58 AM, Yugo Nagata <nag...@sraoss.co.jp> wrote: > > On Fri, 21 Jul 2017 10:31:57 -0300 > Fabrízio de Royes Mello <fabriziome...@gmail.com> wrote: > > > On Fri, Jul 21, 2017 at 9:35 AM, Yugo Nagata <nag...@sraoss.co.jp> wrote: >

Re: [HACKERS] [PATCH] A hook for session start

2017-07-21 Thread Fabrízio de Royes Mello
e if your initial tasks have run yet. > > Thank you for your suggestion. Certainly, we can do the similar job of a > session-start hook using these existing hooks, although these hooks are > triggered when the first query is executed not when the session is started. > Now I come

Re: [HACKERS] [PATCH] A hook for session start

2017-07-20 Thread Fabrízio de Royes Mello
ring your opinion on this hook. > I'm not sure your real needs but doesn't it material for improve Event Triggers??? Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin

Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump

2017-07-19 Thread Fabrízio de Royes Mello
ack. > > > > Hi David, > > You may want to consider this patch (attached) which additionally has the pg_dumpall changes. > It would be great if you could help with the tests though, am unsure how to go about them. > You should add the properly sgml docs for this pg_dumpall

Re: [HACKERS] Directory pg_replslot is not properly cleaned

2017-06-19 Thread Fabrízio de Royes Mello
On Mon, Jun 19, 2017 at 11:02 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > > On Mon, Jun 19, 2017 at 10:58 PM, Fabrízio de Royes Mello > <fabriziome...@gmail.com> wrote: > > Do you know when the next minor versions will be released? Because depending >

Re: [HACKERS] Directory pg_replslot is not properly cleaned

2017-06-19 Thread Fabrízio de Royes Mello
On Sun, Jun 18, 2017 at 11:32 PM, Andres Freund <and...@anarazel.de> wrote: > > Hi, > > On 2017-06-07 15:46:45 -0300, Fabrízio de Royes Mello wrote: > > > >> Just adding Dimitriy to conversation... previous email I provided was > > > >wrong. > >

Re: [HACKERS] Directory pg_replslot is not properly cleaned

2017-06-07 Thread Fabrízio de Royes Mello
On Wed, Jun 7, 2017 at 3:30 PM, Andres Freund <and...@anarazel.de> wrote: > > > > On June 7, 2017 11:29:28 AM PDT, "Fabrízio de Royes Mello" < fabriziome...@gmail.com> wrote: > >On Fri, Jun 2, 2017 at 6:37 PM, Fabrízio de Royes Mello < > >fabriziom

Re: [HACKERS] Directory pg_replslot is not properly cleaned

2017-06-07 Thread Fabrízio de Royes Mello
On Fri, Jun 2, 2017 at 6:37 PM, Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > > On Fri, Jun 2, 2017 at 6:32 PM, Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > > > Hi all, > > > > This week I faced a out of disk sp

Re: [HACKERS] Directory pg_replslot is not properly cleaned

2017-06-02 Thread Fabrízio de Royes Mello
On Fri, Jun 2, 2017 at 6:32 PM, Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > Hi all, > > This week I faced a out of disk space trouble in 8TB production cluster. During investigation we notice that pg_replslot was the culprit growing more than 1TB in less

[HACKERS] Directory pg_replslot is not properly cleaned

2017-06-02 Thread Fabrízio de Royes Mello
tch that seems solve the issue. I confess I don't know enough about replication slots code to really know if it's the best solution. Regards, [1] https://www.postgresql.org/message-id/1457621358.355011041%40f382.i.mail.ru -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira:

Re: [HACKERS] [PATCH] Move all am-related reloption code into src/backend/access/[am-name] and get rid of relopt_kind for custom AM

2017-03-23 Thread Fabrízio de Royes Mello
, I'll look the patch and try to help in some way. Regards, -- Fabrízio de Royes Mello Timbira - http://www.timbira.com.br/ PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

Re: [HACKERS] Add support to COMMENT ON CURRENT DATABASE

2017-01-28 Thread Fabrízio de Royes Mello
On Sat, Jan 28, 2017 at 4:26 PM, Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > > > On Fri, Jan 27, 2017 at 8:53 PM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > > > > On 1/26/17 1:20 PM, Fabrízio de Royes Mello wrote: > &

Re: [HACKERS] Add support to COMMENT ON CURRENT DATABASE

2017-01-28 Thread Fabrízio de Royes Mello
On Fri, Jan 27, 2017 at 8:53 PM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > > On 1/26/17 1:20 PM, Fabrízio de Royes Mello wrote: > > Ok, but doing in that way the syntax would be: > > > > COMMENT ON DATABASE CURRENT_DATABASE IS 'comment'; > &

Re: [HACKERS] Add support to COMMENT ON CURRENT DATABASE

2017-01-26 Thread Fabrízio de Royes Mello
a grammar symbol like > > database_name: ColId | CURRENT_DATABASE > > and make a small analogous change in objectaddress.c and you're done. > > Compare rolespec in gram.y. > Ok, but doing in that way the syntax would be: COMMENT ON DATABASE CURRENT_DATABASE IS 'comment'; Regar

Re: [HACKERS] Add support to COMMENT ON CURRENT DATABASE

2017-01-03 Thread Fabrízio de Royes Mello
we decide to think better and rework this patch. I confess I'm not too happy with this code yet, and thinking better maybe we should create a new object type called OBJECT_CURRENT_DATABASE to handle it different than OBJECT_DATABASE. Opinions??? [1] https://www.postgresql.org/message-id/201504291

Re: [HACKERS] Commit fest 2017-01 will begin soon!

2017-01-01 Thread Fabrízio de Royes Mello
Em sáb, 31 de dez de 2016 às 21:52, Michael Paquier < michael.paqu...@gmail.com> escreveu: > On Tue, Dec 27, 2016 at 12:41 PM, Michael Paquier > > wrote: > > > There are still a couple of days to register patches! So if you don't > > > want your fancy feature to be

Re: [HACKERS] tab complete regress tests

2016-12-31 Thread Fabrízio de Royes Mello
Em sáb, 31 de dez de 2016 às 07:11, Pavel Stehule escreveu: > Hi > > now the code in tabcomplete become large part of psql. Is there some > possibility to write regress tests? > > I found only this link > > >

[HACKERS] Add support to COMMENT ON CURRENT DATABASE

2016-12-30 Thread Fabrízio de Royes Mello
Hi all, The attached patch is reworked from a previous one [1] to better deal with get_object_address and pg_get_object_address. Regards, [1] https://www.postgresql.org/message-id/20150317171836.gc10...@momjian.us -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira

Re: [HACKERS] proposal: session server side variables

2016-12-27 Thread Fabrízio de Royes Mello
On Tue, Dec 27, 2016 at 6:55 PM, Pavel Stehule <pavel.steh...@gmail.com> wrote: > > > 2016-12-27 21:38 GMT+01:00 Fabrízio de Royes Mello < fabriziome...@gmail.com>: >> >> >> On Fri, Dec 23, 2016 at 4:00 PM, Joe Conway <m...@joeconway.com> wro

Re: [HACKERS] proposal: session server side variables

2016-12-27 Thread Fabrízio de Royes Mello
arefully we already have some persistent variables with specialized context: reloptions (hardcoded), security labels (local and shared catalog) and comments (local and shared catalog). I was clear enough? Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: htt

Re: [HACKERS] new table partitioning breaks \d table to older versions

2016-12-09 Thread Fabrízio de Royes Mello
nt::pg_catalog.regclass, pg_get_expr(c.relpartb... > Looks like they forgot to adjust version check number in describe.c code. Attched patch fix it. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fa

Re: [HACKERS] DROP FUNCTION of multiple functions

2016-11-01 Thread Fabrízio de Royes Mello
rgs(fwa, missing_ok); address.objectSubId = 0; break; } Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin: h

Re: [HACKERS] Commit fest 2016-09 is now closed

2016-10-04 Thread Fabrízio de Royes Mello
t; necessary. I am sure we will be able to sort things out :) Hi Michael, Thank you so much for your help. I was travelling to take a rest after a long and busy month. I'll update my statistics and send another email to check the % of the work was done. Thanks again, -- Fabrí

[HACKERS] CommitFest 2016-09 status summary

2016-09-25 Thread Fabrízio de Royes Mello
review and ~16% waiting on author to take an action. So if you have time please consider reviewing at least one patch. We need your help! Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io

[HACKERS] CommitFest 2016-09 status summary

2016-09-11 Thread Fabrízio de Royes Mello
have time please consider reviewing at least one patch. We need your help! Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin: http://br.linkedin.com/in/fabriziomell

Re: [HACKERS] CommitFest 2016-09

2016-09-01 Thread Fabrízio de Royes Mello
On Thu, Sep 1, 2016 at 5:11 PM, Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > Please check the "needs reviewer" list > (https://commitfest.postgresql.org/9/?reviewer=-2) for patches to > review. The committers need our help to work. > Just to f

[HACKERS] CommitFest 2016-09

2016-09-01 Thread Fabrízio de Royes Mello
already 29% done with the CF: Committed: 57 Rejected: 6 Returned with Feedback: 4 TOTAL: 219 I'll post a status update on this thread at least once a week and more often as needed. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbir

Re: [HACKERS] PostgreSQL 10 kick-off

2016-09-01 Thread Fabrízio de Royes Mello
On Thu, Sep 1, 2016 at 1:02 PM, Magnus Hagander <mag...@hagander.net> wrote: > > On Sep 1, 2016 17:44, "Fabrízio de Royes Mello" <fabriziome...@gmail.com> wrote: > > > > > > > > On Thu, Sep 1, 2016 at 8:35 AM, Tom Lane <t...@sss.pgh.pa.us&g

Re: [HACKERS] PostgreSQL 10 kick-off

2016-09-01 Thread Fabrízio de Royes Mello
On Thu, Sep 1, 2016 at 8:35 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > > Magnus Hagander <mag...@hagander.net> writes: > >> On Thu, Aug 4, 2016 at 12:09 AM, Fabrízio de Royes Mello > >> <fabriziome...@gmail.com> wrote: > >>> If there are no

Re: [HACKERS] Exclude schema during pg_restore

2016-08-31 Thread Fabrízio de Royes Mello
as permissions are restored last, no permissions > have been granted for those other schemas yet. > > Argueably, those reasons could be dealt with as well, but this seems to > be a generally useful addition to pg_restore, in my opinion. > > Please add it to the next open commitfe

Re: [HACKERS] PostgreSQL 10 kick-off

2016-08-03 Thread Fabrízio de Royes Mello
On Tue, Aug 2, 2016 at 5:44 PM, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > > Peter Eisentraut wrote: > > On 8/1/16 1:08 PM, Fabrízio de Royes Mello wrote: > > > What knowledge is expected for a CFM? I'm really would like to help and > > > a

Re: [HACKERS] PostgreSQL 10 kick-off

2016-08-01 Thread Fabrízio de Royes Mello
On Mon, Aug 1, 2016 at 12:25 PM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > > - We need a commit fest manager. Volunteers, step forward! > What knowledge is expected for a CFM? I'm really would like to help and also learn more about our development. Regards,

Re: [COMMITTERS] [HACKERS] Logical decoding

2016-07-12 Thread Fabrízio de Royes Mello
> https://github.com/confluentinc/bottledwater-pg (for kafka) > https://github.com/michaelpq/pg_plugins/tree/master/decoder_raw (wrote this one) > Nice, also we have wal2json [1]. Regards, [1] https://github.com/eulerto/wal2json -- Fabrízio de Royes Mello Consultoria/Coaching Postgre

Re: [HACKERS] Column COMMENTs in CREATE TABLE?

2016-07-02 Thread Fabrízio de Royes Mello
mns would not be ideal. > > > CREATE TABLE name > COMMENT IS > 'Table Comment Here' > ( > col1 serial COMMENT IS 'Place comment here' > )​; > > And what about the other CREATE statements? IMHO if we follow this path then we should add COMMENT to all CREATE statements and perhap

Re: [HACKERS] hstore: add hstore_length function

2016-06-06 Thread Fabrízio de Royes Mello
tion use 'uint32' instead of 'int' ?? + int count = HS_COUNT(hs); + + PG_RETURN_INT32(count); maybe + uint32 count = HS_COUNT(hs); + + PG_RETURN_UINT32(count); Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >&

Re: [HACKERS] [PROPOSAL] Move all am-related reloption code into src/backend/access/[am-name] and get rid of relopt_kind

2016-05-25 Thread Fabrízio de Royes Mello
Regards, [1] https://www.postgresql.org/message-id/cafj8prcx_vdcsdbumknhhyr_-n_ctl84_7r+-bj17hckt_m...@mail.gmail.com [2] https://www.postgresql.org/message-id/ca+tgmoznfdqt2kotx38yjus3f_avisclxawbmpdwxhyxrg_...@mail.gmail.com -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL &

Re: [HACKERS] Does Type Have = Operator?

2016-05-12 Thread Fabrízio de Royes Mello
On Wed, May 11, 2016 at 9:09 PM, David E. Wheeler <da...@justatheory.com> wrote: > > On May 11, 2016, at 11:01 AM, Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > > I know... but you can do that just in case the current behaviour fail by cathing it with

Re: [HACKERS] Error during restore - dump taken with pg_dumpall -c option

2016-05-12 Thread Fabrízio de Royes Mello
ck is missing into dropRoles() > function. > > PFA patch, to fix the problem in the similar way its been handled into > dumpRoles(). > > Shouldn't this logic be applied just to version >= 9.6? I ask it because you write a special query filtering rolname !~ '^pg_' and again check it

Re: [HACKERS] Does Type Have = Operator?

2016-05-11 Thread Fabrízio de Royes Mello
On Wed, May 11, 2016 at 2:07 AM, David E. Wheeler <da...@justatheory.com> wrote: > > On May 10, 2016, at 5:56 PM, Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > > Searching for the operator in pg_operator catalog isn't enought? > > Seems like overkil

Re: [HACKERS] Does Type Have = Operator?

2016-05-10 Thread Fabrízio de Royes Mello
gt; instead of json values when the values are JSON. But of course the lack of > a = operator is not limited to JSON. So I’m wondering if there’s an > interface at the SQL level to tell me whether a type has an = operator? > That way I could always use text values in those situations. &

Re: [HACKERS] "parallel= " information is not coming in pg_dumpall for create aggregate

2016-04-22 Thread Fabrízio de Royes Mello
On Thu, Apr 21, 2016 at 12:06 AM, Robert Haas <robertmh...@gmail.com> wrote: > > On Mon, Apr 18, 2016 at 10:47 AM, Fabrízio de Royes Mello > <fabriziome...@gmail.com> wrote: > >> I checked in PG 9.6 , if we create an aggregate function with saying - > &

Re: [HACKERS] "parallel= " information is not coming in pg_dumpall for create aggregate

2016-04-18 Thread Fabrízio de Royes Mello
; Type: AGGREGATE; Schema: public; Owner: centos > -- > > CREATE AGGREGATE unsafe_sum100(double precision) ( > SFUNC = float8pl, > STYPE = double precision, > MSFUNC = float8pl, > MINVFUNC = float8mi, > MSTYPE = double precision > ); > > &qu

[HACKERS] Unused macros in src/include/access/transam.h

2016-04-05 Thread Fabrízio de Royes Mello
Hi all, When dealing with some patch review I've noticed there are two macro is not used anywhere: #define TransactionIdStore(xid, dest) (*(dest) = (xid)) #define StoreInvalidTransactionId(dest) (*(dest) = InvalidTransactionId) Regards, -- Fabrízio de Royes Mello Consultoria/Coaching

Re: [HACKERS] Sequence Access Method WIP

2016-03-29 Thread Fabrízio de Royes Mello
On Tue, Mar 29, 2016 at 5:58 PM, Petr Jelinek <p...@2ndquadrant.com> wrote: > > On 29/03/16 22:08, Fabrízio de Royes Mello wrote: >> >> >> >> On Tue, Mar 29, 2016 at 4:59 PM, Petr Jelinek <p...@2ndquadrant.com >> <mailto:p...@2ndquadrant.com>

Re: [HACKERS] Sequence Access Method WIP

2016-03-29 Thread Fabrízio de Royes Mello
On Tue, Mar 29, 2016 at 4:59 PM, Petr Jelinek <p...@2ndquadrant.com> wrote: > > On 29/03/16 19:46, Fabrízio de Royes Mello wrotez >> >> >> > >> > Hmm I am unable to reproduce this. What OS? Any special configure >> flags you use? >> >

Re: [HACKERS] Sequence Access Method WIP

2016-03-29 Thread Fabrízio de Royes Mello
On Tue, Mar 29, 2016 at 2:26 PM, Petr Jelinek <p...@2ndquadrant.com> wrote: > > On 29/03/16 18:50, Fabrízio de Royes Mello wrote: >> >> >> >> On Tue, Mar 29, 2016 at 12:25 PM, David Steele <da...@pgmasters.net >> <mailto:da...@pgmasters.net>> w

Re: [HACKERS] Sequence Access Method WIP

2016-03-28 Thread Fabrízio de Royes Mello
gt; 0 AND max_value = 9223372036854775807 THEN NULL WHEN increment_by < 0 AND max_value = -1 THEN NULL ELSE max_value END AS max_value, CASE WHEN increment_by > 0 AND min_value = 1 THEN NULL WHEN increment_by < 0 AND min_value = -9223372036854775807 THEN NULL ELSE min_value

Re: [HACKERS] NOT EXIST for PREPARE

2016-03-22 Thread Fabrízio de Royes Mello
On Tue, Mar 22, 2016 at 6:16 PM, Yury Zhuravlev <u.zhurav...@postgrespro.ru> wrote: > > Fabrízio de Royes Mello wrote: >> >> >> You're correct. Yury please add your patch to the next commitfest. > > Done. But I do not have restrictions as part of our P

Re: [HACKERS] NOT EXIST for PREPARE

2016-03-22 Thread Fabrízio de Royes Mello
l/src/interfaces/ecpg' make[2]: *** [all-ecpg-recurse] Error 2 make[2]: Leaving directory `/data/fabrizio/Dropbox/dev/postgresql/src/interfaces' make[1]: *** [all-interfaces-recurse] Error 2 make[1]: Leaving directory `/data/fabrizio/Dropbox/dev/postgresql/src' make: *** [all-src-recurse] Error 2

Re: [HACKERS] NOT EXIST for PREPARE

2016-03-22 Thread Fabrízio de Royes Mello
pping", stmt->name))); 3) There are no regression tests 4) There are no docs Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin:

Re: [HACKERS] NOT EXIST for PREPARE

2016-03-22 Thread Fabrízio de Royes Mello
On Tue, Mar 22, 2016 at 2:32 PM, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > > Yury Zhuravlev wrote: > > Fabrízio de Royes Mello wrote: > > >You already have a patch? If yes I'm glad to review it. > > > > If the community is not against it,

Re: [HACKERS] NOT EXIST for PREPARE

2016-03-22 Thread Fabrízio de Royes Mello
c/backend/commands/prepare.c isn't enough? Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin: http://br.linkedin.com/in/fabriziomello >> Twitter: http://twitter.com/

Re: [HACKERS] NOT EXIST for PREPARE

2016-03-22 Thread Fabrízio de Royes Mello
> statement somehow. > You're correct, but IMHO it should be used when you have control of prepared statement... isn't it analogous to CREATE TABLE IF NOT EXISTS?? -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://

Re: [HACKERS] NOT EXIST for PREPARE

2016-03-22 Thread Fabrízio de Royes Mello
Em terça-feira, 22 de março de 2016, Yury Zhuravlev < u.zhurav...@postgrespro.ru> escreveu: > Fabrízio de Royes Mello wrote: > >> I think you meant IF NOT EXISTS, right? >> > Thanks, you right. > > You already have a patch? If yes I'm glad to review it. Regar

Re: [HACKERS] NOT EXIST for PREPARE

2016-03-22 Thread Fabrízio de Royes Mello
lity to PREPARE? > > I think you meant IF NOT EXISTS, right? Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin: http://br.linkedin.com/in/fabriziomello >> T

[HACKERS] gzclose don't set properly the errno in pg_restore

2016-03-06 Thread Fabrízio de Royes Mello
strerror(errno)); Should we set the errno using the gzclose return code or just add some check to "strerror" the "errno" or the "gzclose return code" if they are different? Thoughts? [1] http://www.zlib.net/manual.html -- Fabrízio de Royes Mello Con

Re: [HACKERS] Publish autovacuum informations

2016-03-01 Thread Fabrízio de Royes Mello
On Tue, Mar 1, 2016 at 8:44 AM, Julien Rouhaud <julien.rouh...@dalibo.com> wrote: > > On 01/03/2016 07:50, Michael Paquier wrote: > > On Tue, Mar 1, 2016 at 4:38 AM, Julien Rouhaud > > <julien.rouh...@dalibo.com> wrote: > >> On 29/02/2016 20:20, Fabrízio d

Re: [HACKERS] Publish autovacuum informations

2016-02-29 Thread Fabrízio de Royes Mello
vacuum.so '/data/home/fabrizio/pgsql/lib/pg_stat_autovacuum.so' /usr/bin/install -c -m 644 .//pg_stat_autovacuum.control '/data/home/fabrizio/pgsql/share/extension/' /usr/bin/install -c -m 644 .//pg_stat_autovacuum--0.0.1.sql '/data/home/fabrizio/pgsql/share/extension/' /usr/bin/install -

Re: [HACKERS] Reduce lock levels others reloptions in ALTER TABLE

2016-02-29 Thread Fabrízio de Royes Mello
On Mon, Feb 29, 2016 at 2:58 PM, Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > Hi all, > > Some time ago we added [1] the infrastructure to allow different lock levels for relation options. > > So per discussion [2] the attached patch

[HACKERS] Reduce lock levels others reloptions in ALTER TABLE

2016-02-29 Thread Fabrízio de Royes Mello
- n_distinct - n_distinct_inherited - buffering Att, [1] http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=47167b7907a802ed39b179c8780b76359468f076 [2] http://www.postgresql.org/message-id/20150731022857.gc11...@alap3.anarazel.de -- Fabrízio de Royes Mello Consultoria/Coaching

Re: [HACKERS] PostgreSQL extension API? Documentation?

2016-02-27 Thread Fabrízio de Royes Mello
e not exposed, so we should define an internal API to expose this kind of information. So depending what problem you want to solve you can write an extension to do that. Then unfortunately the short aswer is "depend". Regards, -- Fabrízio de Royes Mello Consultoria/Coaching Postgr

Re: [HACKERS] blocking the alter role command

2016-01-12 Thread Fabrízio de Royes Mello
a lot. > You should implement an extension using ProcessUtility_hook todo that. See an example in [1] Regards, [1] https://github.com/michaelpq/pg_plugins/tree/master/hook_utility -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br

Re: [HACKERS] Patch: fix lock contention for HASHHDR.mutex

2016-01-02 Thread Fabrízio de Royes Mello
unning configure with --enable-depend should avoid this problem. >> >> I still maintain that --enable-depend should be on by default. We're > > > +1 > +1, I always use it. -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br

Re: [HACKERS] Git cartoon

2015-11-09 Thread Fabrízio de Royes Mello
Em segunda-feira, 9 de novembro de 2015, Albe Laurenz < laurenz.a...@wien.gv.at> escreveu: > Fabrízio de Royes Mello wrote: > > Em domingo, 8 de novembro de 2015, Bruce Momjian <br...@momjian.us > <javascript:;>> escreveu: > >> This git cartoon was too fun

Re: [HACKERS] Git cartoon

2015-11-07 Thread Fabrízio de Royes Mello
Em domingo, 8 de novembro de 2015, Bruce Momjian <br...@momjian.us> escreveu: > This git cartoon was too funny not to share: > > http://xkcd.com/1597/ > > Maybe we need it on our git wiki page. ;-) > I think we need our own cartoon with a funny DB story. --

Re: [HACKERS] Getting sorted data from foreign server

2015-10-27 Thread Fabrízio de Royes Mello
ss we will benefit from the >> sort, and clearly that's not what happened here. >> > > PFA patch with the default multiplication factor for sort bumped up to 1.2. > +/* If no remote estimates, assume a sort costs 10% extra */ +#define DEFAULT_FDW_SORT_MULTIPLIE

Re: [HACKERS] proposal: DROP DATABASE variant that kills active sessions

2015-10-16 Thread Fabrízio de Royes Mello
be any interest. > > I think this would be a useful feature. What would one do about > prepared transactions? > Isn't "rollback all prepared" before an option? Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.b

Re: [HACKERS] Can pg_dump make use of CURRENT/SESSION_USER

2015-09-03 Thread Fabrízio de Royes Mello
My intention was move to next commitfest and finish the "rework", but I didn't finish it due some other professional priorities. Sorry by the noise. > I'm marking the patch as returned with feedback again. Once there's a > new patch we can deal with it in the appropriate commitfest.

Re: [HACKERS] Is this a bug?

2015-08-26 Thread Fabrízio de Royes Mello
-- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter: http://twitter.com/fabriziomello Github: http://github.com/fabriziomello

Re: [HACKERS] Is this a bug?

2015-08-26 Thread Fabrízio de Royes Mello
On Wed, Aug 26, 2015 at 4:30 PM, Andres Freund and...@anarazel.de wrote: On 2015-08-26 16:24:31 -0300, Fabrízio de Royes Mello wrote: Why this patch was reverted one day after applied [1]? I didn't see any discussion around it. http://www.postgresql.org/message-id/23918.1409010

Re: [HACKERS] Is this a bug?

2015-08-26 Thread Fabrízio de Royes Mello
On Wed, Aug 26, 2015 at 4:31 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Fabrízio de Royes Mello wrote: Why this patch was reverted one day after applied [1]? I didn't see any discussion around it. Contributors whose patches are getting committed should really subscribe to pgsql

Re: [HACKERS] Commitfest remaining Needs Review items

2015-08-25 Thread Fabrízio de Royes Mello
. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter: http://twitter.com/fabriziomello Github: http://github.com/fabriziomello

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-08-06 Thread Fabrízio de Royes Mello
On Wed, Aug 5, 2015 at 9:21 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Thu, Aug 6, 2015 at 3:06 AM, Fabrízio de Royes Mello wrote: On Wed, Aug 5, 2015 at 9:31 AM, Robert Haas wrote: Agreed. I think we're making a mountain out of a molehill here. As long as the locks

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-08-05 Thread Fabrízio de Royes Mello
-levels used for DDL are, and will always be, self-exclusive, so why all this hand-wringing? New version attached with suggested changes. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-08-04 Thread Fabrízio de Royes Mello
) -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter: http://twitter.com/fabriziomello Github: http://github.com/fabriziomello diff --git a/doc/src/sgml/ref

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-08-03 Thread Fabrízio de Royes Mello
://www.zenvia.com.br) -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter: http://twitter.com/fabriziomello Github: http://github.com/fabriziomello

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-07-31 Thread Fabrízio de Royes Mello
On Fri, Jul 31, 2015 at 10:01 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Fri, Jul 31, 2015 at 11:41 AM, Fabrízio de Royes Mello wrote: We usually don't compare lock values that way, i.e. there's not guaranteed to be a strict monotonicity between lock levels. I don't really

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-07-30 Thread Fabrízio de Royes Mello
to compare lock values to get the highest lock level? Perhaps creating a function to compare lock levels? Regards, *** This work is funded by Zenvia Mobile Results (http://www.zenvia.com.br) -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-07-30 Thread Fabrízio de Royes Mello
suggestions. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter: http://twitter.com/fabriziomello Github: http://github.com/fabriziomello diff

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-07-23 Thread Fabrízio de Royes Mello
is funded by Zenvia Mobile Results (http://www.zenvia.com.br) -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter: http://twitter.com/fabriziomello Github: http

Re: [HACKERS] security labels on databases are bad for dump restore

2015-07-22 Thread Fabrízio de Royes Mello
://commitfest.postgresql.org/5/229/ Unfortunately this code is a bit weird and will be better to move to the next commitfest (I have no time to improve it yet), so we can join efforts and implement all ideas and make the reviewers life easier with a more consistency patch. Seems reasonable? Regards, -- Fabrízio de

Re: [HACKERS] Add CINE for ALTER TABLE ... ADD COLUMN

2015-07-22 Thread Fabrízio de Royes Mello
exist if if_not_exists is true. Improved the comment. Except that the implementation looks sane to me. Thank you for the review. Att, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http

  1   2   3   4   5   >