Re: [HACKERS] Exclude pg_internal.init from base backup

On Wed, Nov 8, 2017 at 11:11 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Wed, Nov 8, 2017 at 9:04 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > > The commit 98267e missed to check the empty SGML tag, attached

Re: [HACKERS] Exclude pg_internal.init from base backup

On Wed, Nov 8, 2017 at 3:03 AM, Simon Riggs wrote: > On 5 November 2017 at 11:55, Magnus Hagander wrote: > > On Sat, Nov 4, 2017 at 4:04 AM, Michael Paquier < > michael.paqu...@gmail.com> > > wrote: > >> > >> On Fri, Nov 3, 2017 at 4:04 PM, Petr

Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall

On Wed, Nov 8, 2017 at 8:48 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Tue, Nov 7, 2017 at 4:35 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > > The newly added option is not recommended to be used in normal cases and > > it is used only for upgra

Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall

On Thu, Oct 26, 2017 at 10:01 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Mon, Oct 23, 2017 at 7:36 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > Apologies for not providing much details. > > > > pg_dumpall is used to produce t

Re: [HACKERS] pg_stat_wal_write statistics view

On Wed, Sep 27, 2017 at 6:58 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > Updated patch attached. > Patch rebased. Regards, Hari Babu Fujitsu Australia pg_stat_walwrites-statistics-view_v10.patch Description: Binary data -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall

On Sun, Oct 22, 2017 at 3:08 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Sat, Oct 21, 2017 at 1:30 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > Before refactoring, pg_dumpall doesn't print "create database" commands > >

Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall

On Fri, Oct 6, 2017 at 12:29 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Wed, Oct 4, 2017 at 3:40 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > > There are some differences in handling database objects > > between pg_dump and pg_d

Re: [HACKERS] Pluggable storage

On Fri, Oct 13, 2017 at 11:55 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Thu, Oct 12, 2017 at 8:00 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > Currently I added a snapshot_satisfies API to find out whether the tuple > > satisfies the visibili

Re: [HACKERS] Pluggable storage

On Fri, Oct 13, 2017 at 8:23 AM, Robert Haas wrote: > On Thu, Oct 12, 2017 at 4:38 PM, Alexander Korotkov > wrote: > > It's probably that we imply different meaning to "MVCC implementation". > > While writing "MVCC implementation" I meant that,

Re: [HACKERS] utility commands benefiting from parallel plan

On Fri, Oct 6, 2017 at 2:43 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Fri, Sep 15, 2017 at 2:22 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > Thanks for the review. > > I committed this patch with some cosmetic changes. I think the fact &g

Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall

On Sat, Sep 30, 2017 at 3:31 AM, Robert Haas wrote: > On Fri, Sep 29, 2017 at 12:44 AM, Vaishnavi Prabakaran > wrote: > > Option name "--enable-pgdumpall-behaviour" is very generic > > Yeah, that's a terrible name, at least in my opinion. >

Re: [HACKERS] Commitfest 201709 is now closed

On Tue, Oct 3, 2017 at 3:12 AM, Robert Haas wrote: > On Mon, Oct 2, 2017 at 11:57 AM, Tom Lane wrote: > > Daniel Gustafsson writes: > >> Thanks to everyone who participated, and to everyone who have responded > to my > >> nagging via

Re: [HACKERS] pg_stat_wal_write statistics view

On Fri, Sep 22, 2017 at 5:46 PM, Julien Rouhaud <rjuju...@gmail.com> wrote: > Hello, > > On Wed, Sep 13, 2017 at 3:01 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > I ran the latest performance tests with and without IO times, there is an > > overhe

Re: [HACKERS] visual studio 2017 build support

On Mon, Sep 25, 2017 at 10:12 PM, Andrew Dunstan < andrew.duns...@2ndquadrant.com> wrote: > > On 09/25/2017 12:25 AM, Haribabu Kommi wrote: > > > > Thanks for pointing it out, I missed to check the Build tools support > > section. > > Here I attach

Re: [HACKERS] SERIALIZABLE with parallel query

On Mon, Sep 25, 2017 at 6:57 PM, Thomas Munro <thomas.mu...@enterprisedb.com > wrote: > On Mon, Sep 25, 2017 at 8:37 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > After I tune the GUC to go with sequence scan, still I am not getting the > > error &

Re: [HACKERS] SERIALIZABLE with parallel query

On Thu, Sep 21, 2017 at 4:13 PM, Thomas Munro <thomas.mu...@enterprisedb.com > wrote: > On Tue, Sep 19, 2017 at 1:47 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > During testing of this patch, I found some behavior difference > > with the su

Re: [HACKERS] VACUUM and ANALYZE disagreeing on what reltuples means

On Mon, Sep 25, 2017 at 4:39 AM, Tomas Vondra <tomas.von...@2ndquadrant.com> wrote: > > > On 09/06/2017 09:45 AM, Haribabu Kommi wrote: > > > > > > On Tue, Jul 25, 2017 at 9:33 PM, Tomas Vondra > > <tomas.von...@2ndquadrant.com <mailto:tomas.von...@2

Re: [HACKERS] visual studio 2017 build support

On Fri, Sep 22, 2017 at 10:40 PM, Andrew Dunstan < andrew.duns...@2ndquadrant.com> wrote: > > > On 09/21/2017 08:16 PM, Haribabu Kommi wrote: > > > > > > I was about to commit this after a good bit of testing when I > > noticed this: > > >

Re: [HACKERS] visual studio 2017 build support

On Fri, Sep 22, 2017 at 7:03 AM, Andrew Dunstan < andrew.duns...@2ndquadrant.com> wrote: > > > On 08/25/2017 11:29 PM, Haribabu Kommi wrote: > > > > > > On Fri, Aug 25, 2017 at 11:27 PM, Christian Ullrich > > <ch...@chrullrich.net <mailto:ch...@chrull

Re: [HACKERS] Windows warnings from VS 2017

On Thu, Sep 21, 2017 at 12:26 PM, Andrew Dunstan < andrew.duns...@2ndquadrant.com> wrote: > > > On 09/20/2017 08:18 PM, Andrew Dunstan wrote: > > > > On 09/20/2017 07:54 PM, Tom Lane wrote: > >> Andrew Dunstan writes: > >>> It's also warning that it will copy 16

Re: [HACKERS] SERIALIZABLE with parallel query

On Tue, Sep 19, 2017 at 11:42 AM, Thomas Munro < thomas.mu...@enterprisedb.com> wrote: > On Fri, Sep 1, 2017 at 5:11 PM, Thomas Munro > wrote: > > On Wed, Jun 28, 2017 at 11:21 AM, Thomas Munro > > wrote: > >> [ssi-parallel-v5.patch]

Re: [HACKERS] utility commands benefiting from parallel plan

On Thu, Sep 14, 2017 at 2:42 PM, Rafia Sabih <rafia.sa...@enterprisedb.com> wrote: > On Wed, Sep 13, 2017 at 2:29 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > > > > On Wed, Sep 13, 2017 at 4:17 PM, Rafia Sabih < > rafia.sa...@enterprise

Re: [HACKERS] utility commands benefiting from parallel plan

On Wed, Sep 13, 2017 at 4:17 PM, Rafia Sabih <rafia.sa...@enterprisedb.com> wrote: > On Fri, Sep 1, 2017 at 12:31 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > > Hi All, > > > > Attached a rebased patch that supports parallelism for t

Re: [HACKERS] pg_stat_wal_write statistics view

On Tue, Sep 12, 2017 at 3:14 PM, Kuntal Ghosh <kuntalghosh.2...@gmail.com> wrote: > On Tue, Sep 12, 2017 at 9:06 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > > > > On Tue, Sep 12, 2017 at 2:04 AM, Kuntal Ghosh < > kuntalghosh.2...@gmail.

Re: [HACKERS] Pluggable storage

On Sat, Sep 9, 2017 at 1:23 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > I rebased the patch to the latest master and also fixed the duplicate OID > and some slot fixes. Updated patches are attached. > While analyzing the removal of HeapScanDesc usage other

Re: [HACKERS] pg_stat_wal_write statistics view

On Tue, Sep 12, 2017 at 2:04 AM, Kuntal Ghosh <kuntalghosh.2...@gmail.com> wrote: > On Wed, Sep 6, 2017 at 9:16 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > > > > Attached the latest patch and performance report. > > > While looking into the patc

Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall

On Fri, Sep 8, 2017 at 10:24 AM, Thomas Munro <thomas.mu...@enterprisedb.com > wrote: > On Mon, Aug 21, 2017 at 4:35 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > On Tue, Aug 15, 2017 at 7:29 AM, Peter Eisentraut > > <peter.eisentr...@2ndquadrant

Re: [HACKERS] VACUUM and ANALYZE disagreeing on what reltuples means

On Tue, Jul 25, 2017 at 9:33 PM, Tomas Vondra wrote: > On 7/25/17 12:55 AM, Tom Lane wrote: > >> Tomas Vondra writes: >> >>> It seems to me that VACUUM and ANALYZE somewhat disagree on what >>> exactly reltuples means. VACUUM seems to

Re: [HACKERS] pg_stat_wal_write statistics view

On Tue, Aug 15, 2017 at 7:39 AM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 3/29/17 22:10, Haribabu Kommi wrote: > > Updated patch to use shared counter instead of adding pg_stat_ calls to > send > > the statistics from each background process/work

Re: [HACKERS] Allow INSTEAD OF DELETE triggers to modify the tuple for RETURNING

On Mon, Aug 14, 2017 at 6:48 AM, Marko Tiikkaja wrote: > On Fri, Jul 1, 2016 at 2:12 AM, I wrote: > >> Currently the tuple returned by INSTEAD OF triggers on DELETEs is only >> used to determine whether to pretend that the DELETE happened or not, which >> is often not helpful

Re: [HACKERS] Visual Studio 2017 Build Support

On Fri, Sep 1, 2017 at 11:06 AM, Tanay Varma <tanay.va...@microsoft.com> wrote: > > > Hello, > > > > This is with respect to the original thread on “visual studio 2017 build > support” created by Haribabu Kommi (kommi.harib...@gmail.com). > > >

Re: [HACKERS] utility commands benefiting from parallel plan

Hi All, Attached a rebased patch that supports parallelism for the queries that are underneath of some utility commands such as CREATE TABLE AS and CREATE MATERIALIZED VIEW. Note: This patch doesn't make the utility statement (insert operation) to run in parallel. It only allows the select query

Re: [HACKERS] Pluggable storage

On Wed, Aug 23, 2017 at 11:59 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Wed, Aug 23, 2017 at 11:05 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > > > > On Mon, Aug 21, 2017 at 7:25 PM, Amit Kapila <amit.kapil...@gmail.com> >

Re: [HACKERS] visual studio 2017 build support

On Fri, Aug 25, 2017 at 11:27 PM, Christian Ullrich <ch...@chrullrich.net> wrote: > * On 2017-06-21 02:06, Haribabu Kommi wrote: > > Thanks for the review. Here I attached an updated patch with README update. >> > > Hello, > Thanks for the review. > the most

Re: [HACKERS] Pluggable storage

On Mon, Aug 21, 2017 at 7:25 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Mon, Aug 21, 2017 at 12:58 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > > On Sun, Aug 13, 2017 at 5:17 PM, Amit Kapila <amit.kapil...@gmail.com> > > wrote:

Re: [HACKERS] Pluggable storage

On Tue, Aug 15, 2017 at 4:53 PM, Andres Freund <and...@anarazel.de> wrote: > Hi, > > > On 2017-06-13 11:50:27 +1000, Haribabu Kommi wrote: > > Here I attached WIP patches to support pluggable storage. The patch > series > > are may not work individuall

Re: [HACKERS] parallelize queries containing initplans

On Mon, Aug 14, 2017 at 8:41 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Sun, Aug 13, 2017 at 6:49 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > On Fri, Aug 11, 2017 at 1:18 AM, Amit Kapila <amit.kapil...@gmail.com> > > wrote: >

Re: [HACKERS] Pluggable storage

On Sun, Aug 13, 2017 at 5:17 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Sat, Aug 12, 2017 at 10:31 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > >> > >> Why do we need to store handler function in TupleDesc? As of now, the >

Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall

On Tue, Aug 15, 2017 at 7:29 AM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 4/4/17 01:06, Haribabu Kommi wrote: > > Both pg_dump and pg_upgrade tests are passed. Updated patch attached > > I will add this patch to the next commitfest. > > Thi

Re: [HACKERS] Pluggable storage

On Sun, Aug 13, 2017 at 5:21 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Sat, Aug 12, 2017 at 10:34 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > > On Tue, Aug 8, 2017 at 2:21 PM, Amit Kapila <amit.kapil...@gmail.com> > wrote: >

Re: [HACKERS] parallelize queries containing initplans

On Fri, Aug 11, 2017 at 1:18 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Wed, Aug 9, 2017 at 6:51 PM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > > > > > > + if (IsA(plan, Gather)) > > + ((Gather *) plan)->initParam = bms_interse

Re: [HACKERS] Pluggable storage

On Tue, Aug 8, 2017 at 2:21 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Tue, Jun 13, 2017 at 7:20 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > > > > On Fri, Oct 14, 2016 at 7:26 AM, Alvaro Herrera < > alvhe...@2ndquadrant.com>

Re: [HACKERS] Pluggable storage

On Mon, Aug 7, 2017 at 11:12 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Tue, Aug 1, 2017 at 1:56 PM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > > > > > > On Sun, Jul 23, 2017 at 4:10 PM, Amit Kapila <amit.kapil...@gmail.com> > &

Re: [HACKERS] parallelize queries containing initplans

On Wed, Aug 9, 2017 at 9:26 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Wed, Aug 9, 2017 at 10:24 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > > > > For the following query the parallel plan is not chosen. The query > contains >

Re: [HACKERS] parallelize queries containing initplans

On Wed, Aug 9, 2017 at 8:54 PM, Kuntal Ghosh <kuntalghosh.2...@gmail.com> wrote: > On Wed, Aug 9, 2017 at 10:24 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > > I tested the latest patch and the parallel plan is getting choose for > most > &

Re: [HACKERS] parallelize queries containing initplans

On Mon, Jul 17, 2017 at 10:53 PM, Amit Kapila wrote: > On Tue, Mar 28, 2017 at 7:25 AM, Amit Kapila > wrote: > > On Thu, Mar 16, 2017 at 2:34 AM, Kuntal Ghosh > > wrote: > >> On Tue, Mar 14, 2017 at 3:20 PM, Amit

Re: [HACKERS] Pluggable storage

On Sun, Jul 23, 2017 at 4:10 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Wed, Jul 19, 2017 at 11:33 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > > I am finding out that eliminating the HeapTuple usage in the upper layers > >

Re: [HACKERS] Pluggable storage

On Sat, Jul 15, 2017 at 12:30 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Fri, Jul 14, 2017 at 8:35 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > To replace tuple with slot, I took trigger and SPI calls as the first > step > > in modifyi

[HACKERS] Re: [BUGS] BUG #14634: On Windows pg_basebackup should write tar to stdout in binary mode

On Fri, Jul 14, 2017 at 2:54 AM, Heikki Linnakangas <hlinn...@iki.fi> wrote: > On 05/03/2017 07:32 AM, Haribabu Kommi wrote: > >> [Adding -hackers mailing list] >> >> On Fri, Apr 28, 2017 at 6:28 PM, <henry_boehl...@agilent.com> wrote: >> >>

Re: [HACKERS] Pluggable storage

wrote: >> > On Wed, Jun 21, 2017 at 10:47 PM, Robert Haas <robertmh...@gmail.com> >> wrote: >> >> >> >> On Mon, Jun 12, 2017 at 9:50 PM, Haribabu Kommi >> >> <kommi.harib...@gmail.com> wrote: >> >> > Open Items: >

Re: [HACKERS] Pluggable storage

; wrote: >> > On Tue, Jun 13, 2017 at 4:50 AM, Haribabu Kommi < >> kommi.harib...@gmail.com> >> > wrote: >> >> >> >> On Fri, Oct 14, 2016 at 7:26 AM, Alvaro Herrera < >> alvhe...@2ndquadrant.com> >> >> wrote: >&g

Re: [HACKERS] Pluggable storage

On Thu, Jun 22, 2017 at 5:47 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Mon, Jun 12, 2017 at 9:50 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > Open Items: > > > > 1. The BitmapHeapScan and TableSampleScan are tightly coupled wit

Re: [HACKERS] visual studio 2017 build support

On Mon, Apr 24, 2017 at 5:50 PM, Ideriha, Takeshi < ideriha.take...@jp.fujitsu.com> wrote: > Hi > > > > I’ve noticed src/tools/msvc/README also needs some fix together with your > patch. > > README discription haven’t updated since VS 2012. > Thanks for the review. Here I attached an updated

Re: [HACKERS] Increasing parallel workers at runtime

On Wed, May 17, 2017 at 2:35 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Tue, May 16, 2017 at 8:18 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > In the current state of the patch, the main backend tries to start the > > extra worker

Re: [HACKERS] Increasing parallel workers at runtime

On Tue, May 16, 2017 at 1:53 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Mon, May 15, 2017 at 10:06 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > This still needs some adjustments to fix for the cases where > > the main backend also do

[HACKERS] Increasing parallel workers at runtime

In the current parallel implementation, in case if the number of planned workers doesn't available during the start of the query execution, the query starts the execution with the available number of workers till the end of the query. It may be possible that during the query processing the

Re: [HACKERS] modeling parallel contention (was: Parallel Append implementation)

On Mon, May 8, 2017 at 11:39 AM, David Rowley wrote: > > We really need a machine with good IO concurrency, and not too much > RAM to test these things out. It could well be that for a suitability > large enough table we'd want to scan a whole 1GB extent per worker.

[HACKERS] compiler warning with VS 2017

I am getting a compiler warning when I build the latest HEAD PostgreSQL with visual studio 2017. src/backend/replication/logical/proto.c(482): warning C4312: 'type cast': conversion from 'unsigned int' to 'char *' of greater size Details of the warning is available in the link [1]. The code at

Re: [HACKERS] Re: [BUGS] BUG #14634: On Windows pg_basebackup should write tar to stdout in binary mode

On Wed, May 3, 2017 at 10:44 PM, Ashutosh Sharma <ashu.coe...@gmail.com> wrote: > Hi Craig, > > On Wed, May 3, 2017 at 10:50 AM, Craig Ringer <cr...@2ndquadrant.com> > wrote: > > On 3 May 2017 at 12:32, Haribabu Kommi <kommi.harib...@gmail.com> wrote

Re: [HACKERS] Re: [BUGS] BUG #14634: On Windows pg_basebackup should write tar to stdout in binary mode

On Wed, May 3, 2017 at 3:20 PM, Craig Ringer <cr...@2ndquadrant.com> wrote: > On 3 May 2017 at 12:32, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > [Adding -hackers mailing list] > > > > On Fri, Apr 28, 2017 at 6:28 PM, <henry_boehl...@agilent.com>

[HACKERS] Re: [BUGS] BUG #14634: On Windows pg_basebackup should write tar to stdout in binary mode

[Adding -hackers mailing list] On Fri, Apr 28, 2017 at 6:28 PM, wrote: > The following bug has been logged on the website: > > Bug reference: 14634 > Logged by: Henry Boehlert > Email address: henry_boehl...@agilent.com > PostgreSQL version: 9.6.2

[HACKERS] visual studio 2017 build support

Here I attached a small patch that adds the build support for visual studio 2017. The tools version number is still 14.X, irrespective of VS 2017 version of 15.0. I modified the versions accordingly. Regards, Hari Babu Fujitsu Australia vs2017_build_support.patch Description: Binary data --

Re: [HACKERS] New SQL counter statistics view (pg_stat_sql)

On Thu, Apr 6, 2017 at 5:17 AM, Andres Freund wrote: > Hi, > > > I'm somewhat inclined to think that this really would be better done in > an extension like pg_stat_statements. > Thanks for the review. > > > +} > > + > > +/* > > + * Count SQL statement for pg_stat_sql

Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall

On Thu, Mar 30, 2017 at 12:00 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > > On Wed, Mar 29, 2017 at 11:04 PM, Andreas Karlsson <andr...@proxel.se> > wrote: > >> On 03/29/2017 05:43 AM, Haribabu Kommi wrote: >> > Updated patch attached. &g

Re: [HACKERS] [WIP] RE: DECLARE STATEMENT setting up a connection in ECPG

On Thu, Mar 30, 2017 at 1:57 PM, Ideriha, Takeshi < ideriha.take...@jp.fujitsu.com> wrote: > > >+ if(connection_name == NULL) > >+ { > >+ /* > >+ * Going to here means not using AT clause in the DECLARE STATEMENT > >+ * We don't allocate a node to store the declared name because the > >+ *

Re: [HACKERS] pg_stat_wal_write statistics view

On Wed, Mar 29, 2017 at 5:10 AM, Fujii Masao <masao.fu...@gmail.com> wrote: > On Tue, Mar 28, 2017 at 1:40 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > > > > Added stats collection for walsender, statrup and autovacuum processes.

Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall

On Wed, Mar 29, 2017 at 11:04 PM, Andreas Karlsson <andr...@proxel.se> wrote: > On 03/29/2017 05:43 AM, Haribabu Kommi wrote: > > Updated patch attached. > > I get a test failure in the pg_upgrade tests, but I do not have time right > now to investigate. > >

Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall

On Tue, Mar 28, 2017 at 12:50 AM, Andreas Karlsson wrote: > Hi, > > Here is my review. I agree with the goal of the refactoring, as we want to > make it easier to dump all the properties for the database object. But I > think we need to solve the issues with the special casing

Re: [HACKERS] pg_stat_wal_write statistics view

On Tue, Mar 28, 2017 at 3:40 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > update patch attached. > Forgot to execute git commit, new patch attached. Regards, Hari Babu Fujitsu Australia pg_stat_walwrites_view_4.patch Description: Binary data -- Sent via pgsql-

Re: [HACKERS] pg_stat_wal_write statistics view

On Mon, Mar 27, 2017 at 1:27 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > > On Sat, Mar 25, 2017 at 6:40 AM, Fujii Masao <masao.fu...@gmail.com> > wrote: > >> On Wed, Feb 15, 2017 at 12:53 PM, Haribabu Kommi >> <kommi.harib...@gmail.com> w

Re: [HACKERS] pg_stat_wal_write statistics view

On Sat, Mar 25, 2017 at 6:40 AM, Fujii Masao <masao.fu...@gmail.com> wrote: > On Wed, Feb 15, 2017 at 12:53 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > > > > On Wed, Feb 8, 2017 at 9:36 PM, Amit Kapila <amit.kapil...@gmail.com> > wro

Re: [HACKERS] ANALYZE command progress checker

On Wed, Mar 22, 2017 at 8:11 PM, vinayak <pokale_vinayak...@lab.ntt.co.jp> wrote: > > On 2017/03/21 21:25, Haribabu Kommi wrote: > > > > On Tue, Mar 21, 2017 at 3:41 PM, vinayak <pokale_vinayak...@lab.ntt.co.jp> > wrote: > >> Thank you for testing the

Re: [WIP] RE: [HACKERS] DECLARE STATEMENT setting up a connection in ECPG

On Wed, Mar 22, 2017 at 7:57 PM, Ideriha, Takeshi < ideriha.take...@jp.fujitsu.com> wrote: > Hi, thank you very much for reviewing. > Attached is v6 patch. > > >There was a minor conflict in applying 004_declareXX patch. > > I rebased 004_declareStmt_test_v6.patch. > > >Some comments in

Re: [WIP] RE: [HACKERS] DECLARE STATEMENT setting up a connection in ECPG

On Wed, Mar 22, 2017 at 12:51 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > > On Tue, Mar 7, 2017 at 4:09 PM, Ideriha, Takeshi < > ideriha.take...@jp.fujitsu.com> wrote: > >> >> Attached 004_declareStmt_test_v5.patch is a rebased one. >>

Re: [HACKERS] Proposal: GetOldestXminExtend for ignoring arbitrary vacuum flags

On Wed, Mar 22, 2017 at 1:53 PM, Seki, Eiji wrote: > > Thank you for your review, again. > > I think your proposals are better, so I reflected them. Thanks for the updated patch. Patch looks good to me. I marked it as "ready for committer". While reviewing this

Re: [WIP] RE: [HACKERS] DECLARE STATEMENT setting up a connection in ECPG

On Tue, Mar 7, 2017 at 4:09 PM, Ideriha, Takeshi < ideriha.take...@jp.fujitsu.com> wrote: > > Attached 004_declareStmt_test_v5.patch is a rebased one. > The rest of patches are same as older version. > Thanks for the update patch. I started reviewing the patches. There was a minor conflict in

Re: [HACKERS] ANALYZE command progress checker

On Tue, Mar 21, 2017 at 3:41 PM, vinayak wrote: > Thank you for testing the patch on Windows platform. > > Thanks for the updated patch. It works good for a normal relation. But for a relation that contains child tables, the PROGRESS_ANALYZE_NUM_ROWS_SAMPLED

Re: [HACKERS] Proposal: GetOldestXminExtend for ignoring arbitrary vacuum flags

On Tue, Mar 21, 2017 at 3:16 PM, Seki, Eiji wrote: > > > Thank you for you review. > > I reflected your comment and attach the updated patch. Thanks for the updated patch. +/* Use these flags in GetOldestXmin as "flags" */ How about some thing like the following. /*

Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall

Because of this refactor handing of database objects between pg_dump and pg_dumpall, the latest pg_dump tap tests are failing in the following scenarios. 1. CREATE DATABASE postgres Before this patch, the pg_dump uses to dump the CREATE DATABASE command of postgres but not by pg_dumpall. During

Re: [HACKERS] pg_stat_wal_write statistics view

On Thu, Mar 16, 2017 at 4:15 PM, vinayak <pokale_vinayak...@lab.ntt.co.jp> wrote: > > On 2017/03/16 10:34, Haribabu Kommi wrote: > > > Updated patch attached. > > The patch looks good to me. > Thanks for the review. How about rename the view as "pg_stat_

Re: [HACKERS] Proposal: GetOldestXminExtend for ignoring arbitrary vacuum flags

On Fri, Feb 24, 2017 at 3:17 PM, Seki, Eiji wrote: > > Thank you for your comments. > > I reflected these comments to the attached patch. And I renamed IGNORE_XXX > flags to PROCARRAY_XXX flags. I checked the latest patch and I have some comments. +static int

Re: [HACKERS] pg_stat_wal_write statistics view

On Thu, Mar 16, 2017 at 9:55 AM, Julien Rouhaud <julien.rouh...@dalibo.com> wrote: > On Wed, Feb 15, 2017 at 02:53:44PM +1100, Haribabu Kommi wrote: > > Here I attached patch that implements the view. > > I will add this patch to next commitfest. > > Hello, &g

Re: [HACKERS][REVIEW] macaddr 64 bit (EUI-64) datatype support

On Thu, Mar 16, 2017 at 2:20 AM, Stephen Frost <sfr...@snowman.net> wrote: > Greetings Hari Babu, > > * Haribabu Kommi (kommi.harib...@gmail.com) wrote: > > On Mon, Mar 13, 2017 at 6:52 AM, Stephen Frost <sfr...@snowman.net> > wrote: > > > And, naturally,

Re: [HACKERS] utility commands benefiting from parallel plan

On Tue, Feb 28, 2017 at 12:48 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > > On Sat, Feb 25, 2017 at 3:21 AM, Robert Haas <robertmh...@gmail.com> > wrote: > >> On Fri, Feb 24, 2017 at 11:43 AM, Haribabu Kommi >> <kommi.harib...@gmail.com>

Re: [HACKERS] ANALYZE command progress checker

On Fri, Mar 10, 2017 at 6:46 PM, vinayak wrote: > > + /* Report total number of heap blocks and collectinf sample row phase*/ > + initprog_val[0] = PROGRESS_ANALYZE_PHASE_COLLECT_HEAP_SAMPLE_ROWS; > + initprog_val[1] = totalblocks; > +

Re: [HACKERS][REVIEW] macaddr 64 bit (EUI-64) datatype support

On Mon, Mar 13, 2017 at 6:52 AM, Stephen Frost <sfr...@snowman.net> wrote: > Greetings, > > * Stephen Frost (sfr...@snowman.net) wrote: > > * Stephen Frost (sfr...@snowman.net) wrote: > > > * Haribabu Kommi (kommi.harib...@gmail.com) wrote: > > > > On W

Re: [HACKERS][REVIEW] macaddr 64 bit (EUI-64) datatype support

On Mon, Mar 13, 2017 at 6:38 AM, Stephen Frost <sfr...@snowman.net> wrote: > Greetings, > > * Stephen Frost (sfr...@snowman.net) wrote: > > * Haribabu Kommi (kommi.harib...@gmail.com) wrote: > > > On Wed, Feb 1, 2017 at 6:27 AM, Vitaly Burovoy < > vitaly.buro.

Re: [HACKERS] New SQL counter statistics view (pg_stat_sql)

On Wed, Feb 1, 2017 at 3:13 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Fri, Jan 27, 2017 at 10:26 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > Thanks for the review. > > Let's wait for the committer's opinion. > > I have mo

Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall

On Wed, Mar 1, 2017 at 12:59 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > Patch attached. Still some more docs needs to be added. > Updated patch attached to resolve the conflicts with following commit. commit 9a83d56b38c870ce47b7651385ff2add583bf136 Author:

Re: [HACKERS] ANALYZE command progress checker

On Tue, Mar 7, 2017 at 5:01 PM, Michael Paquier wrote: > > @@ -496,7 +499,6 @@ do_analyze_rel(Relation onerel, int options, > VacuumParams *params, > numrows = (*acquirefunc) (onerel, elevel, > rows, targrows, >

[HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall

Subject changed for better context of the patch. (was - Re: Question about grant create on database and pg_dump/pg_dumpall) On Fri, Sep 30, 2016 at 12:29 AM, Tom Lane wrote: > >1. pg_dump without --create continues to do what it does today, ie it just >dumps

Re: [HACKERS] utility commands benefiting from parallel plan

On Sat, Feb 25, 2017 at 3:21 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Fri, Feb 24, 2017 at 11:43 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > Here I attached an implementation patch that allows > > utility statements that have queries under

Re: [HACKERS] utility commands benefiting from parallel plan

On Sat, Feb 25, 2017 at 2:45 AM, Dilip Kumar <dilipbal...@gmail.com> wrote: > On Fri, Feb 24, 2017 at 11:43 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > Here I attached an implementation patch that allows > > utility statements that have queries under

[HACKERS] utility commands benefiting from parallel plan

Hi Hackers, Here I attached an implementation patch that allows utility statements that have queries underneath such as CREATE TABLE AS, CREATE MATERIALIZED VIEW and REFRESH commands to benefit from parallel plan. These write operations not performed concurrently by the parallel workers, but the

Re: [HACKERS] Proposal: GetOldestXminExtend for ignoring arbitrary vacuum flags

On Wed, Feb 15, 2017 at 11:35 PM, Amit Kapila wrote: > On Wed, Feb 15, 2017 at 12:03 PM, Seki, Eiji > wrote: > > Amit Kapila wrote: > >> How will you decide just based on oldest xmin whether the tuple is > visible or not? How will you take

Re: [HACKERS] CREATE TABLE with parallel workers, 10.0?

On Thu, Feb 16, 2017 at 12:48 AM, Robert Haas wrote: > On Wed, Feb 15, 2017 at 12:24 AM, Joshua Chamberlain > wrote: > > Hello, > > > > (I'm posting to hackers since I got no response on the general list.) > > > > I use Postgres + PostGIS quite heavily,

Re: [HACKERS] pg_stat_wal_write statistics view

On Wed, Feb 8, 2017 at 9:36 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Tue, Feb 7, 2017 at 11:47 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > Hi Hackers, > > > > I just want to discuss adding of a new statistics view that provide

Re: [HACKERS] [WIP]Vertical Clustered Index (columnar store extension)

On Tue, Feb 14, 2017 at 2:57 AM, Konstantin Knizhnik < k.knizh...@postgrespro.ru> wrote: > Hi, > > I wonder if it is possible to somehow benchmark your clustered index > implementation. > I tried to create VCI index for lineitem table from TPC and run Q6 query. > After index creation Postgres is

Re: [HACKERS] Parallel bitmap heap scan

On Tue, Feb 14, 2017 at 12:48 AM, Dilip Kumar wrote: > On Mon, Feb 13, 2017 at 6:24 PM, Robert Haas > wrote: > > I don't think it's acceptable (or necessary) to move the DSA > > definitions into postgres.h. Why do you think you need to do that, > >

[HACKERS] pg_stat_wal_write statistics view

Hi Hackers, I just want to discuss adding of a new statistics view that provides the information of wal writing details as follows postgres=# \d pg_stat_wal_writer View "pg_catalog.pg_stat_wal_writer" Column | Type | Collation |

  1   2   3   4   5   6   >