On Aug 25, 2017 10:45 PM, "Michael Meskes" wrote:
>
> > The v3 patch looks good to me. I've changed this patch status to Ready
> > for Committer.
>
> Thank you all, committed.
Thank you very much.
Regards,
Vinayak Pokale
On 2017/08/25 17:13, Masahiko Sawada wrote:
On Fri, Aug 25, 2017 at 4:27 PM, vinayak
wrote:
On 2017/08/25 16:18, Masahiko Sawada wrote:
On Fri, Aug 25, 2017 at 2:57 PM, vinayak
wrote:
Hi Sawada-san,
On 2017/08/25 11:07, Masahiko Sawada wrote:
On Fri, Aug 18, 2017 at 5:20 PM, vinayak
On 2017/08/25 16:18, Masahiko Sawada wrote:
On Fri, Aug 25, 2017 at 2:57 PM, vinayak
wrote:
Hi Sawada-san,
On 2017/08/25 11:07, Masahiko Sawada wrote:
On Fri, Aug 18, 2017 at 5:20 PM, vinayak
wrote:
On 2017/06/20 17:35, vinayak wrote:
Hi Sawada-san,
On 2017/06/20 17:22, Masahiko
Hi Sawada-san,
On 2017/08/25 11:07, Masahiko Sawada wrote:
On Fri, Aug 18, 2017 at 5:20 PM, vinayak
wrote:
On 2017/06/20 17:35, vinayak wrote:
Hi Sawada-san,
On 2017/06/20 17:22, Masahiko Sawada wrote:
On Tue, Jun 20, 2017 at 1:51 PM, vinayak
wrote:
On 2017/06/12 13:09, vinayak wrote
On 2017/06/20 17:35, vinayak wrote:
Hi Sawada-san,
On 2017/06/20 17:22, Masahiko Sawada wrote:
On Tue, Jun 20, 2017 at 1:51 PM, vinayak
wrote:
On 2017/06/12 13:09, vinayak wrote:
Hi,
On 2017/06/10 12:23, Vinayak Pokale wrote:
Thank you for your reply
On Jun 9, 2017 5:39 PM, "Mi
Hi Sawada-san,
On 2017/06/20 17:22, Masahiko Sawada wrote:
On Tue, Jun 20, 2017 at 1:51 PM, vinayak
wrote:
On 2017/06/12 13:09, vinayak wrote:
Hi,
On 2017/06/10 12:23, Vinayak Pokale wrote:
Thank you for your reply
On Jun 9, 2017 5:39 PM, "Michael Meskes" wrote:
Could you pl
On 2017/06/12 13:09, vinayak wrote:
Hi,
On 2017/06/10 12:23, Vinayak Pokale wrote:
Thank you for your reply
On Jun 9, 2017 5:39 PM, "Michael Meskes" <mailto:mes...@postgresql.org>> wrote:
>
> Could you please add a "DO CONTINUE" case to one of the test
Hi,
On 2017/06/10 12:23, Vinayak Pokale wrote:
Thank you for your reply
On Jun 9, 2017 5:39 PM, "Michael Meskes" <mailto:mes...@postgresql.org>> wrote:
>
> Could you please add a "DO CONTINUE" case to one of the test cases? Or
> add a new one? We would
to our attention and
> fixing this missing functionality.
>
> > I have tried to implement it. Please check the attached patch.
> > Please give me feedback.
> > ...
>
> Could you please add a "DO CONTINUE" case to one of the test cases? Or
> add a new one? We would need a test case IMO.
>
Yes I will add test case and send updated patch.
Regards,
Vinayak Pokale
osing loop.
I have tried to implement it. Please check the attached patch.
Please give me feedback.
[1]https://docs.oracle.com/cd/B28359_01/appdev.111/b28427/pc_09err.htm#i12340
Regards,
Vinayak Pokale
NTT Open Source Software Center
whenever-do-continue.patch
Description: binary/octet-stream
the remaining types in the attached patch.
I would like to know whether we can add remaining types in the
"ecpg/ecpglib/pg_type.h" file or not?
Regards,
Vinayak Pokale
NTT Open Source Software Center
ECPG_pg_type_h.patch
Description: binary/octet-stream
--
Sent via pgsql-hacke
h other regression test
failed.
$ make installcheck
13 of 178 tests failed.
Regards,
Vinayak
On 2017/03/30 17:39, Masahiko Sawada wrote:
On Wed, Mar 29, 2017 at 5:38 PM, vinayak
wrote:
On 2017/03/25 4:30, Robert Haas wrote:
On Fri, Mar 24, 2017 at 3:41 AM, vinayak
wrote:
I have updated the patch.
You can't change the definition of AcquireSampleRowsFunc without
updatin
On 2017/03/30 17:39, Masahiko Sawada wrote:
On Wed, Mar 29, 2017 at 5:38 PM, vinayak
wrote:
On 2017/03/25 4:30, Robert Haas wrote:
On Fri, Mar 24, 2017 at 3:41 AM, vinayak
wrote:
I have updated the patch.
You can't change the definition of AcquireSampleRowsFunc without
updatin
On 2017/03/25 4:30, Robert Haas wrote:
On Fri, Mar 24, 2017 at 3:41 AM, vinayak
wrote:
I have updated the patch.
You can't change the definition of AcquireSampleRowsFunc without
updating the documentation in fdwhandler.sgml, but I think I don't
immediately understand why that&#x
On 2017/03/23 15:04, Haribabu Kommi wrote:
On Wed, Mar 22, 2017 at 8:11 PM, vinayak
<mailto:pokale_vinayak...@lab.ntt.co.jp>> wrote:
On 2017/03/21 21:25, Haribabu Kommi wrote:
On Tue, Mar 21, 2017 at 3:41 PM, vinayak
mailto:pokale_vinayak...@lab.ntt.co.j
On 2017/03/21 21:25, Haribabu Kommi wrote:
On Tue, Mar 21, 2017 at 3:41 PM, vinayak
<mailto:pokale_vinayak...@lab.ntt.co.jp>> wrote:
Thank you for testing the patch on Windows platform.
Thanks for the updated patch.
It works good for a normal relation. But for a rela
indows platform and didn't find
any issues. Thanks.
Thank you for testing the patch on Windows platform.
Regards,
Vinayak Pokale
NTT Open Source Software Center
pg_stat_progress_analyze_v4.patch
Description: binary/octet-stream
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Hi Ashutosh,
Thank you for reviewing the patch.
On 2017/03/18 21:00, Ashutosh Sharma wrote:
Hi Vinayak,
Here are couple of review comments that may need your attention.
1. Firstly, I am seeing some trailing whitespace errors when trying to
apply your v3 patch using git apply command.
[ashu
On 2017/03/17 10:38, Robert Haas wrote:
On Fri, Mar 10, 2017 at 2:46 AM, vinayak
wrote:
Thank you for reviewing the patch.
The attached patch incorporated Michael and Amit comments also.
I reviewed this tonight.
Thank you for reviewing the patch.
+/* Report compute index stats
On 2017/03/16 14:46, Haribabu Kommi wrote:
On Thu, Mar 16, 2017 at 4:15 PM, vinayak
<mailto:pokale_vinayak...@lab.ntt.co.jp>> wrote:
On 2017/03/16 10:34, Haribabu Kommi wrote:
Updated patch attached.
The patch looks good to me.
Thanks for the review.
How abo
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
I have tested the latest patch and it looks good to me,
so I
e_blocks
write_time->wal_write_time
sync_time->wal_sync_time
Regards,
Vinayak Pokale
NTT Open Source Software Center
/* Phases of analyze (as advertised via PROGRESS_ANALYZE_PHASE) */
Done.
Regards,
Vinayak Pokale
NTT Open Source Software Center
pg_stat_progress_analyze_v2.patch
Description: binary/octet-stream
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes
On 2017/03/06 17:02, Amit Langote wrote:
Hi Vinayak,
On 2017/02/28 18:24, vinayak wrote:
The attached patch reports the different phases of analyze command.
Added this patch to CF 2017-03.
In the updated monitoring.sgml:
+
+ computing heap stats
+
+ VACUUM is currently
orrect?
In the "src/bin/pg_waldump/rmgrdesc.c" file following header file used
two times.
+ #include "access/fdw_xact.h"
I think we need to remove one line.
Regards,
Vinayak Pokale
ase is not reported yet in the
patch.
Regards,
Vinayak Pokale
NTT Open Source Software Center
pg_stat_progress_analyze_v1.patch
Description: binary/octet-stream
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.or
3654
wait_event_type | *Lock*
wait_event | *transactionid*
query | COMMIT TRANSACTION
Note: Test 4 and Test 5 are same but in Test 5 both the foreign servers
trying to insert the same data.
Is this a expected behavior of postgres_fdw?
Regards,
Vinayak Pokale
NTT Open Source Software Center
quot; means. In the spirit of that, let's find
better names for new functions as well.
+1
Regards,
Vinayak Pokale
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
shared memory.
2017-01-26 17:52:56.156 JST [3425] HINT: In a moment you should be able
to reconnect to the database and repeat your command.
Is this a bug?
Regards,
Vinayak Pokale
NTT Open Source Software Center
at
>pgstat_track_sql is true, seems it's redundant here.
Removed the check in pgstat_count_sqlstmt statement and add it
exec_execute_message
function where the check is missed.
Updated patch attached.
I have reviewed the patch. All the test cases works fine.
Regards,
Vinayak Pokale
NTT Open Source Software Center
commit across foreign server that
is capable two phase commit protocol.
In [1], I proposed that we solve the problem of supporting PREPARED
transactions involving foreign servers and in subsequent mail Vinayak
agreed to that. But this goal has wider scope than that proposal. I am
fine widening the scope
hey want it to be added to the next
commitfest or not.
When I first started with this work, Tom had suggested me to try to
make PREPARE and COMMIT/ROLLBACK PREPARED involving foreign servers or
at least postgres_fdw servers work. I think, most of my work that
Vinayak and Sawada have rebased to the latest
Hi,
Attached patch fixes a typo in reorderbuffer.c
s/messsage/message/g
Regards,
Vinayak Pokale
NTT Open Source Software Center
typo-reorderbuffer-c.patch
Description: application/download
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your
Hi,
Attached patch fixes a typo in pgstat.c
s/addtions/additions/g
Regards,
Vinayak Pokale
NTT Open Source Software Center
typo-pgstat-c.patch
Description: application/download
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription
Hi,
- * st_progress_command_target, and st_progress_command[].
+ * st_progress_command_target, and st_progress_param[].
Attached patch fixed typo.
Regards,
Vinayak Pokale
NTT Open Source Software Center
typo-pgstat-h.patch
Description: application/download
--
Sent via pgsql
On 2016/10/17 10:22, Haribabu Kommi wrote:
On Fri, Oct 14, 2016 at 7:48 PM, vinayak
<mailto:pokale_vinayak...@lab.ntt.co.jp>> wrote:
On 2016/10/12 12:21, Haribabu Kommi wrote:
I tried changing the pg_stat_sql into row mode and ran the
regress suite to
add diffe
ount
-+---
(0 rows)
postgres=# SELECT * FROM pg_stat_sql where tag='SELECT';
tag | count
+---
SELECT | 1
(1 row)
Is this a correct behavior?
Regards,
Vinayak Pokale
NTT Open Source Software Center
T'*;
tag | count
+---
* SELECT |13*
(1 row)
postgres=# SELECT * FROM pg_stat_sql where tag=*'select'*;
tag | count
-+---
*(0 rows)*
postgres=# SELECT * FROM pg_stat_sql where tag=*'SELECT'*;
tag | count
+---
* SELECT |15*
(1 row)
I think all command works same as above.
Regards,
Vinayak Pokale
NTT Open Source Software Center
On 2016/09/07 10:54, vinayak wrote:
Thanks for the clarification. I had added pg_fdw_xact_resolver() to
resolve any transactions which can not be resolved immediately after
they were prepared. There was a comment from Kevin (IIRC) that
leaving transactions unresolved on the foreign server
26, 2016 at 11:22 AM, Masahiko Sawada
mailto:sawada.m...@gmail.com>>
> wrote:
>>
>> On Fri, Aug 26, 2016 at 1:32 PM, Vinayak Pokale
mailto:vinpok...@gmail.com>>
>> wrote:
>> > Hi All,
>> >
>> > Ashutosh
patch.
Suggestions and comments are helpful to implement this feature.
Regards,
Vinayak Pokale
On Mon, Feb 1, 2016 at 11:14 PM, Alvaro Herrera
wrote:
> Alvaro Herrera wrote:
> > Ashutosh Bapat wrote:
> >
> > > Here's updated patch. I didn't use version num
Hello,
On Fri, Feb 26, 2016 at 6:19 PM, Amit Langote wrote:
>
> Hi Vinayak,
>
> Thanks for updating the patch! A quick comment:
>
> On 2016/02/26 17:28, poku...@pm.nttdata.co.jp wrote:
> >> CREATE VIEW pg_stat_vacuum_progress AS
> >> SELECT S.s[1] a
Hi,
Please find attached updated patch with an updated interface.
On Jan 26, 2016 11:22 AM, "Vinayak Pokale" wrote:
>
> Hi Amit,
>
> Thank you for reviewing the patch.
>
> On Jan 26, 2016 9:51 AM, "Amit Langote"
wrote:
> >
> >
> > Hi Vi
Hi Amit,
Thank you for reviewing the patch.
On Jan 26, 2016 9:51 AM, "Amit Langote"
wrote:
>
>
> Hi Vinayak,
>
> On 2016/01/25 20:58, Vinayak Pokale wrote:
> > Hi,
> >
> > Please find attached updated patch with an updated interface.
> >
>
>
which are called at the beginning:
void pgstat_report_progress_set_command_target(Oid relid)
Regards,
Vinayak
On Wed, Jan 13, 2016 at 3:16 PM, Amit Langote wrote:
> On 2016/01/12 11:28, Vinayak Pokale wrote:
> > On Jan 12, 2016 11:22 AM, "Amit Langote"
> > wrote:
>
Hi,
I found a typo in sequence.c
Please check the attached patch.
Regards,
Vinayak
typo-sequence-c.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
vileged user.
> In the previous patch, it is showing in phase
> column.
Yes. I will update the patch.
Regards,
Vinayak Pokale
;
> I meant to say "originally proposed pgstat interface on this thread".
Yes.
Robert's comments related to pgstat interface needs to be address.
I will update it.
Regards,
Vinayak Pokale
D_LAZY_VACUUM.
Added documentation for view.
Some more comments need to be addressed.
Regards,
Vinayak Pokale
On Sat, Dec 12, 2015 at 2:07 AM, Robert Haas wrote:
> On Fri, Dec 11, 2015 at 1:25 AM, Michael Paquier
> wrote:
> >> For another thing, there are definitely going to be
>
| 41667
scanned_heap_pages | 25185
percent_complete| 60
total_index_pages | 0
scanned_index_pages | 0
index_scan_count| 0
-
Regards,
Vinayak,
--
View this message in context:
http://postgresql.nabble.com/PROPOSAL-VACUUM-Progress-Checker-tp5855849p5875614.html
Sent from the PostgreSQL
51 matches
Mail list logo
