Re: [HACKERS] alter user set local_preload_libraries.

2014-12-23 Thread Kyotaro HORIGUCHI
Hello, sorry for the absense, Thank you for committing. On 8/29/14 4:01 PM, Peter Eisentraut wrote: On 8/28/14 9:01 AM, Kyotaro HORIGUCHI wrote: I found this issue when trying per-pg_user (role) loading of auto_analyze and some tweaking tool. It is not necessarily set by the user by

Re: [HACKERS] alter user set local_preload_libraries.

2014-12-22 Thread Peter Eisentraut
On 8/29/14 4:01 PM, Peter Eisentraut wrote: On 8/28/14 9:01 AM, Kyotaro HORIGUCHI wrote: I found this issue when trying per-pg_user (role) loading of auto_analyze and some tweaking tool. It is not necessarily set by the user by own, but the function to decide whether to load some module by

Re: [HACKERS] alter user set local_preload_libraries.

2014-12-14 Thread Michael Paquier
On Tue, Dec 9, 2014 at 11:56 PM, Robert Haas robertmh...@gmail.com wrote: On Mon, Dec 8, 2014 at 9:18 PM, Tom Lane t...@sss.pgh.pa.us wrote: Barring someone committing to spend the time to improve that situation (time that would be poorly invested IMO), I don't think that we want to open up

Re: [HACKERS] alter user set local_preload_libraries.

2014-12-09 Thread Robert Haas
On Mon, Dec 8, 2014 at 9:18 PM, Tom Lane t...@sss.pgh.pa.us wrote: Barring someone committing to spend the time to improve that situation (time that would be poorly invested IMO), I don't think that we want to open up ignore_system_indexes as USERSET, or do anything else to encourage its use.

Re: [HACKERS] alter user set local_preload_libraries.

2014-12-08 Thread Robert Haas
On Sun, Dec 7, 2014 at 9:54 AM, Peter Eisentraut pete...@gmx.net wrote: My radical proposal therefore would have been to embrace this inconsistency and get rid of PGC_BACKEND and PGC_SU_BACKEND altogether, relying on users interpreting the parameter names to indicate that changing them later

Re: [HACKERS] alter user set local_preload_libraries.

2014-12-08 Thread Peter Eisentraut
On 12/8/14 12:39 PM, Robert Haas wrote: On Sun, Dec 7, 2014 at 9:54 AM, Peter Eisentraut pete...@gmx.net wrote: My radical proposal therefore would have been to embrace this inconsistency and get rid of PGC_BACKEND and PGC_SU_BACKEND altogether, relying on users interpreting the parameter

Re: [HACKERS] alter user set local_preload_libraries.

2014-12-08 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On 12/8/14 12:39 PM, Robert Haas wrote: On Sun, Dec 7, 2014 at 9:54 AM, Peter Eisentraut pete...@gmx.net wrote: My radical proposal therefore would have been to embrace this inconsistency and get rid of PGC_BACKEND and PGC_SU_BACKEND altogether,

Re: [HACKERS] alter user set local_preload_libraries.

2014-12-07 Thread Peter Eisentraut
On 11/12/14 1:01 PM, Fujii Masao wrote: On Wed, Nov 5, 2014 at 1:22 AM, Peter Eisentraut pete...@gmx.net wrote: On 10/9/14 1:58 PM, Fujii Masao wrote: Also I think that it's useful to allow ALTER ROLE/DATABASE SET to set PGC_BACKEND and PGC_SU_BACKEND parameters. So, what about applying the

Re: [HACKERS] alter user set local_preload_libraries.

2014-12-07 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: My radical proposal therefore would have been to embrace this inconsistency and get rid of PGC_BACKEND and PGC_SU_BACKEND altogether, relying on users interpreting the parameter names to indicate that changing them later may or may not have an effect.

Re: [HACKERS] alter user set local_preload_libraries.

2014-11-12 Thread Fujii Masao
On Wed, Nov 5, 2014 at 1:22 AM, Peter Eisentraut pete...@gmx.net wrote: On 10/9/14 1:58 PM, Fujii Masao wrote: Also I think that it's useful to allow ALTER ROLE/DATABASE SET to set PGC_BACKEND and PGC_SU_BACKEND parameters. So, what about applying the attached patch? This patch allows that and

Re: [HACKERS] alter user set local_preload_libraries.

2014-11-04 Thread Peter Eisentraut
On 10/9/14 1:58 PM, Fujii Masao wrote: Also I think that it's useful to allow ALTER ROLE/DATABASE SET to set PGC_BACKEND and PGC_SU_BACKEND parameters. So, what about applying the attached patch? This patch allows that and changes the context of session_preload_libraries to PGC_SU_BACKEND.

Re: [HACKERS] alter user set local_preload_libraries.

2014-11-04 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On 10/9/14 1:58 PM, Fujii Masao wrote: Also I think that it's useful to allow ALTER ROLE/DATABASE SET to set PGC_BACKEND and PGC_SU_BACKEND parameters. So, what about applying the attached patch? This patch allows that and changes the context of

Re: [HACKERS] alter user set local_preload_libraries.

2014-10-27 Thread Fujii Masao
On Tue, Oct 21, 2014 at 3:16 PM, Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp wrote: Wow. By the way, I became unable to login at all after wrongly setting *_preload_libraries for all available users. Is there any releaf measures for the situation? I think it's okay even if there's no

Re: [HACKERS] alter user set local_preload_libraries.

2014-10-21 Thread Kyotaro HORIGUCHI
Wow. By the way, I became unable to login at all after wrongly setting *_preload_libraries for all available users. Is there any releaf measures for the situation? I think it's okay even if there's no way to login again but want to know if any. Yep, that's a problem. You can login to

Re: [HACKERS] alter user set local_preload_libraries.

2014-10-10 Thread Kyotaro HORIGUCHI
Hello, I overlooked this thread. On Mon, Sep 15, 2014 at 1:33 AM, Tom Lane t...@sss.pgh.pa.us wrote: Peter Eisentraut pete...@gmx.net writes: On 9/1/14 7:51 AM, Kyotaro HORIGUCHI wrote: The attached patch simply changes the context for local_... to PGC_USERSET and edits the doc. I

Re: [HACKERS] alter user set local_preload_libraries.

2014-10-10 Thread Fujii Masao
On Fri, Oct 10, 2014 at 5:36 PM, Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp wrote: Hello, I overlooked this thread. On Mon, Sep 15, 2014 at 1:33 AM, Tom Lane t...@sss.pgh.pa.us wrote: Peter Eisentraut pete...@gmx.net writes: On 9/1/14 7:51 AM, Kyotaro HORIGUCHI wrote: The attached

Re: [HACKERS] alter user set local_preload_libraries.

2014-10-09 Thread Fujii Masao
On Mon, Sep 15, 2014 at 1:33 AM, Tom Lane t...@sss.pgh.pa.us wrote: Peter Eisentraut pete...@gmx.net writes: On 9/1/14 7:51 AM, Kyotaro HORIGUCHI wrote: The attached patch simply changes the context for local_... to PGC_USERSET and edits the doc. I had this ready to commit, but then

Re: [HACKERS] alter user set local_preload_libraries.

2014-09-14 Thread Peter Eisentraut
On 9/1/14 7:51 AM, Kyotaro HORIGUCHI wrote: The attached patch simply changes the context for local_... to PGC_USERSET and edits the doc. I had this ready to commit, but then Invent PGC_SU_BACKEND and mark log_connections/log_disconnections that way. was committed in the meantime. Does

Re: [HACKERS] alter user set local_preload_libraries.

2014-09-14 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On 9/1/14 7:51 AM, Kyotaro HORIGUCHI wrote: The attached patch simply changes the context for local_... to PGC_USERSET and edits the doc. I had this ready to commit, but then Invent PGC_SU_BACKEND and mark log_connections/log_disconnections that

Re: [HACKERS] alter user set local_preload_libraries.

2014-09-01 Thread Kyotaro HORIGUCHI
Hello, I found this issue when trying per-pg_user (role) loading of auto_analyze and some tweaking tool. It is not necessarily set by the user by own, but the function to decide whether to load some module by the session-user would be usable, at least, as for me:) I think we could just

Re: [HACKERS] alter user set local_preload_libraries.

2014-08-29 Thread Peter Eisentraut
On 8/28/14 9:01 AM, Kyotaro HORIGUCHI wrote: I found this issue when trying per-pg_user (role) loading of auto_analyze and some tweaking tool. It is not necessarily set by the user by own, but the function to decide whether to load some module by the session-user would be usable, at least, as

Re: [HACKERS] alter user set local_preload_libraries.

2014-08-28 Thread Kyotaro HORIGUCHI
Hello, On Thu, 2014-07-03 at 13:05 +0900, Kyotaro HORIGUCHI wrote: For the earlier than 9.4, no one seems to have considered seriously to use local_preload_library via ALTER statements so far. Only document fix would be enough for them. I think local_preload_libraries never actually

Re: [HACKERS] alter user set local_preload_libraries.

2014-08-26 Thread Peter Eisentraut
On Thu, 2014-07-03 at 13:05 +0900, Kyotaro HORIGUCHI wrote: For the earlier than 9.4, no one seems to have considered seriously to use local_preload_library via ALTER statements so far. Only document fix would be enough for them. I think local_preload_libraries never actually worked sensibly

Re: [HACKERS] alter user set local_preload_libraries.

2014-08-14 Thread Kyotaro HORIGUCHI
Hello, I made a set of patches to fix this issue. The attached files are the followings, 0001_Add_PGC_BACKEND_USERSET_v0.patch: Add new GUC category PGC_BACKEND_USERSET and change local_preload_libraries to use it. 0002_dblink_follow_change_of_set_config_options_v0.patch:

[HACKERS] alter user set local_preload_libraries.

2014-07-02 Thread Kyotaro HORIGUCHI
Hello, This is about a document fix of local_preload_libraries for the versions 9.3 and earlier to at least 8.4. There's inconsistency between documentation about local_preload_libraries for 9.3 and earlier and their behavior. The 9.3 document for local_preload_libraries says that:

Re: [HACKERS] alter user set local_preload_libraries.

2014-07-02 Thread Tom Lane
Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp writes: postgres=# alter user horiguti2 set local_preload_libraries='libname'; ERROR: parameter local_preload_libraries cannot be set after connection start Hm ... it's kind of annoying that that doesn't work; it's certainly not hard to

Re: [HACKERS] alter user set local_preload_libraries.

2014-07-02 Thread Fujii Masao
On Wed, Jul 2, 2014 at 11:15 PM, Tom Lane t...@sss.pgh.pa.us wrote: Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp writes: postgres=# alter user horiguti2 set local_preload_libraries='libname'; ERROR: parameter local_preload_libraries cannot be set after connection start Hm ... it's

Re: [HACKERS] alter user set local_preload_libraries.

2014-07-02 Thread Tom Lane
Fujii Masao masao.fu...@gmail.com writes: On Wed, Jul 2, 2014 at 11:15 PM, Tom Lane t...@sss.pgh.pa.us wrote: Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp writes: postgres=# alter user horiguti2 set local_preload_libraries='libname'; ERROR: parameter local_preload_libraries cannot be set

Re: [HACKERS] alter user set local_preload_libraries.

2014-07-02 Thread Fujii Masao
On Thu, Jul 3, 2014 at 3:53 AM, Tom Lane t...@sss.pgh.pa.us wrote: Fujii Masao masao.fu...@gmail.com writes: On Wed, Jul 2, 2014 at 11:15 PM, Tom Lane t...@sss.pgh.pa.us wrote: Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp writes: postgres=# alter user horiguti2 set

Re: [HACKERS] alter user set local_preload_libraries.

2014-07-02 Thread Tom Lane
Fujii Masao masao.fu...@gmail.com writes: Agreed. I was also thinking we can set it per role, but got surprised when I found that's impossible. Is this a problem of only local_preload_libraries? I'm afraid that all PGC_BACKEND parameters have the same problem. Well, there aren't that many

Re: [HACKERS] alter user set local_preload_libraries.

2014-07-02 Thread Kyotaro HORIGUCHI
o cahgqgwfyianahr_u_chnz-zourj3yqmmnjrr9rwp7vpsvxt...@mail.gmail.com 20408.1404329...@sss.pgh.pa.us User-Agent: Mew version 6.5 on Emacs 22.2 / Mule 5.0 =?iso-2022-jp?B?KBskQjpnGyhCKQ==?= / Meadow-3.01-dev (TSUBO-SUMIRE) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii