Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-12-05 Thread Craig Ringer
On 5 December 2016 at 19:17, Dagfinn Ilmari Mannsåker wrote: > This is not the correct invocation of cpanm: it just takes a list of > module names. This will pull in the 'install' module, which is > harmless, but unnecessary: https://metacpan.org/pod/install. Ha. Good catch.

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-12-05 Thread Dagfinn Ilmari Mannsåker
Noah Misch writes: > On Mon, Nov 21, 2016 at 05:37:50PM +0900, Kyotaro HORIGUCHI wrote: >> At Mon, 21 Nov 2016 16:45:10 +0900, Michael Paquier >> wrote in >> >> > No objections

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-12-04 Thread Michael Paquier
On Sun, Dec 4, 2016 at 2:28 PM, Noah Misch wrote: > Committed after re-filling paragraphs. Thanks, I have updated the CF entry as well. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-12-03 Thread Noah Misch
On Mon, Nov 21, 2016 at 11:58:34AM +0800, Craig Ringer wrote: > Updated docs patch. Since configure checks for 5.8.0 that's what's > specified. Anyone who wants to argue about the actual version we > _should_ target can do so elsewhere, all I'm interested in is what we > _do_ officially target so

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-21 Thread Kyotaro HORIGUCHI
At Mon, 21 Nov 2016 16:45:10 +0900, Michael Paquier wrote in > > Fixed in attached. > > No objections to this version. It's a good idea to document that. +1 regards, -- Kyotaro Horiguchi NTT Open

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-20 Thread Michael Paquier
On Mon, Nov 21, 2016 at 3:38 PM, Craig Ringer wrote: > On 21 November 2016 at 12:23, Kyotaro HORIGUCHI > wrote: >> I understand you :p By the way, the new doc points to >> http://install.perlbrew.pl and it just shows the install >> script.

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-20 Thread Craig Ringer
On 21 November 2016 at 12:23, Kyotaro HORIGUCHI wrote: > Hello, > > At Mon, 21 Nov 2016 11:58:34 +0800, Craig Ringer > wrote in >> On 18 November 2016 at 08:15, Craig

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-20 Thread Kyotaro HORIGUCHI
Hello, At Mon, 21 Nov 2016 11:58:34 +0800, Craig Ringer wrote in > On 18 November 2016 at 08:15, Craig Ringer wrote: > > On 18 November 2016 at 07:10, Michael Paquier

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-20 Thread Craig Ringer
On 18 November 2016 at 08:15, Craig Ringer wrote: > On 18 November 2016 at 07:10, Michael Paquier > wrote: >> On Thu, Nov 17, 2016 at 2:39 PM, Craig Ringer wrote: >>> I wasted a bunch of time getting set up to test for

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-17 Thread Craig Ringer
On 18 November 2016 at 07:10, Michael Paquier wrote: > On Thu, Nov 17, 2016 at 2:39 PM, Craig Ringer wrote: >> I wasted a bunch of time getting set up to test for such an ancient >> Perl and would love to save the next person along the hassle by

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-17 Thread Michael Paquier
On Thu, Nov 17, 2016 at 2:39 PM, Craig Ringer wrote: > I wasted a bunch of time getting set up to test for such an ancient > Perl and would love to save the next person along the hassle by > documenting the easy way. It looks sensible to mention that in the README, so +1.

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-17 Thread Craig Ringer
On 18 November 2016 at 05:41, Robert Haas wrote: > On Wed, Nov 16, 2016 at 9:54 PM, Craig Ringer wrote: >> On 17 November 2016 at 10:42, Craig Ringer wrote: >>> But sure, if it's easier, we can have 5.8.0 in the README. What's

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-17 Thread Robert Haas
On Wed, Nov 16, 2016 at 9:54 PM, Craig Ringer wrote: > On 17 November 2016 at 10:42, Craig Ringer wrote: >> But sure, if it's easier, we can have 5.8.0 in the README. What's five >> extra years matter anyway? Hey, while we're at it, lets change Pg to

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-16 Thread Craig Ringer
On 17 November 2016 at 12:23, Michael Paquier wrote: > On Wed, Nov 16, 2016 at 6:54 PM, Craig Ringer wrote: >> In all seriousness, though, lets query the buildfarm database for Perl >> versions. Let it answer. > > castoroides, Solaris 10 and perl

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-16 Thread Michael Paquier
On Wed, Nov 16, 2016 at 6:54 PM, Craig Ringer wrote: > In all seriousness, though, lets query the buildfarm database for Perl > versions. Let it answer. castoroides, Solaris 10 and perl 5.8.4, no?

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-16 Thread Kyotaro HORIGUCHI 
Hello,

At Thu, 17 Nov 2016 11:59:02 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI 
 wrote in 
<20161117.115902.224922490.horiguchi.kyot...@lab.ntt.co.jp>
> My only concern is the fact that 'make check-world' runs the TAP
> tests as a part if

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-16 Thread Kyotaro HORIGUCHI
At Thu, 17 Nov 2016 10:42:54 +0800, Craig Ringer wrote in > On 17 November 2016 at 10:31, Kyotaro HORIGUCHI > wrote: > > > > > I vote +1 to upgrading perl, but I'm not

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-16 Thread Craig Ringer
On 17 November 2016 at 10:42, Craig Ringer wrote: > But sure, if it's easier, we can have 5.8.0 in the README. What's five > extra years matter anyway? Hey, while we're at it, lets change Pg to > build on Borland C and require K style! Sorry. That was unnecessary. I

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-16 Thread Craig Ringer
On 17 November 2016 at 10:31, Kyotaro HORIGUCHI wrote: > > I vote +1 to upgrading perl, but I'm not sure if all supporting > platforms other than linux support the version of perl. > > Anyway ./configure is saying as the following. > > | *** The installed version

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-16 Thread Kyotaro HORIGUCHI
Hello, At Thu, 17 Nov 2016 10:00:53 +0800, Craig Ringer wrote in > On 17 November 2016 at 00:01, Michael Paquier > wrote: > > On Tue, Nov 15, 2016 at 11:32 PM, Noah Misch

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-16 Thread Craig Ringer
On 17 November 2016 at 00:01, Michael Paquier wrote: > On Tue, Nov 15, 2016 at 11:32 PM, Noah Misch wrote: >> On Wed, Nov 16, 2016 at 12:48:03PM +0800, Craig Ringer wrote: >>> --- a/src/test/perl/README >>> +++ b/src/test/perl/README >>> @@ -64,3

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-16 Thread Michael Paquier
On Tue, Nov 15, 2016 at 11:32 PM, Noah Misch wrote: > On Wed, Nov 16, 2016 at 12:48:03PM +0800, Craig Ringer wrote: >> --- a/src/test/perl/README >> +++ b/src/test/perl/README >> @@ -64,3 +64,20 @@ For available PostgreSQL-specific test methods and some >> example tests read

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-15 Thread Noah Misch
On Wed, Nov 16, 2016 at 12:48:03PM +0800, Craig Ringer wrote: > --- a/src/test/perl/README > +++ b/src/test/perl/README > @@ -64,3 +64,20 @@ For available PostgreSQL-specific test methods and some > example tests read the > perldoc for the test modules, e.g.: > > perldoc

[HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-15 Thread Craig Ringer
I found it a real pain to set up Perl 5.8.8 to re-check recent TAP changes against it. It turns out there's a much easier way than messing with VMs or manually doing a source install, so I documented it to save others the future pain. It'd be nice to commit this at least to 9.6 and v10. Trivial