Re: [HACKERS] Why does WAL_DEBUG macro need to be defined by default?

2011-10-07 Thread Tom Lane
Robert Haas writes: > On Fri, Oct 7, 2011 at 4:06 PM, Bruce Momjian wrote: >> I would just fix it in head. > That just seems weird. Either it's cheap enough not to matter (in > which case there's no reason to revert that change at all) or it's > expensive enough to matter (in which case presuma

Re: [HACKERS] Why does WAL_DEBUG macro need to be defined by default?

2011-10-07 Thread Robert Haas
On Fri, Oct 7, 2011 at 9:59 PM, Bruce Momjian wrote: > Robert Haas wrote: >> On Fri, Oct 7, 2011 at 4:06 PM, Bruce Momjian wrote: >> > Robert Haas wrote: >> >> On Fri, Oct 7, 2011 at 1:03 PM, Kevin Grittner >> >> wrote: >> >> > Robert Haas wrote: >> >> >> The funny thing is that I've been think

Re: [HACKERS] Why does WAL_DEBUG macro need to be defined by default?

2011-10-07 Thread Bruce Momjian
Robert Haas wrote: > On Fri, Oct 7, 2011 at 4:06 PM, Bruce Momjian wrote: > > Robert Haas wrote: > >> On Fri, Oct 7, 2011 at 1:03 PM, Kevin Grittner > >> wrote: > >> > Robert Haas wrote: > >> >> The funny thing is that I've been thinking all of these months > >> >> about how convenient it is tha

Re: [HACKERS] Why does WAL_DEBUG macro need to be defined by default?

2011-10-07 Thread Robert Haas
On Fri, Oct 7, 2011 at 4:06 PM, Bruce Momjian wrote: > Robert Haas wrote: >> On Fri, Oct 7, 2011 at 1:03 PM, Kevin Grittner >> wrote: >> > Robert Haas wrote: >> >> The funny thing is that I've been thinking all of these months >> >> about how convenient it is that we defined WAL_DEBUG in debug >

Re: [HACKERS] Why does WAL_DEBUG macro need to be defined by default?

2011-10-07 Thread Bruce Momjian
Robert Haas wrote: > On Fri, Oct 7, 2011 at 1:03 PM, Kevin Grittner > wrote: > > Robert Haas wrote: > >> The funny thing is that I've been thinking all of these months > >> about how convenient it is that we defined WAL_DEBUG in debug > >> builds > > > > IMO, --enable-debug should not do anything

Re: [HACKERS] Why does WAL_DEBUG macro need to be defined by default?

2011-10-07 Thread Robert Haas
On Fri, Oct 7, 2011 at 1:03 PM, Kevin Grittner wrote: > Robert Haas wrote: >> The funny thing is that I've been thinking all of these months >> about how convenient it is that we defined WAL_DEBUG in debug >> builds > > IMO, --enable-debug should not do anything but include debugging > symbols.  

Re: [HACKERS] Why does WAL_DEBUG macro need to be defined by default?

2011-10-07 Thread Kevin Grittner
Robert Haas wrote: > The funny thing is that I've been thinking all of these months > about how convenient it is that we defined WAL_DEBUG in debug > builds IMO, --enable-debug should not do anything but include debugging symbols. The ability to get a useful stack trace from a production cras

Re: [HACKERS] Why does WAL_DEBUG macro need to be defined by default?

2011-10-07 Thread Robert Haas
On Fri, Oct 7, 2011 at 5:19 AM, Fujii Masao wrote: > I found that by default WAL_DEBUG macro has been defined in > 9.2dev and 9.1. I'm very surprised at this. Why does WAL_DEBUG > need to be defined by default? The performance overhead > introduced by WAL_DEBUG is really vanishingly low? > > WAL_D

Re: [HACKERS] Why does WAL_DEBUG macro need to be defined by default?

2011-10-07 Thread Heikki Linnakangas
On 07.10.2011 12:19, Fujii Masao wrote: Hi, I found that by default WAL_DEBUG macro has been defined in 9.2dev and 9.1. I'm very surprised at this. Why does WAL_DEBUG need to be defined by default? The performance overhead introduced by WAL_DEBUG is really vanishingly low? WAL_DEBUG was defined