Re: [HACKERS] FDW API / flow charts for the docs?

2013-10-21 Thread Vik Fearing
On 10/21/2013 06:24 AM, David Fetter wrote: On Sat, Oct 19, 2013 at 01:56:23PM -0400, Peter Eisentraut wrote: I'd also take a look at ditaa, which might make this even simpler. If we manage to keep Java out of our build toolchain, we will be much the better for it. Amen. -- Vik -- Sent

Re: [HACKERS] FDW API / flow charts for the docs?

2013-10-20 Thread David Fetter
On Sat, Oct 19, 2013 at 01:56:23PM -0400, Peter Eisentraut wrote: On Fri, 2013-10-18 at 18:46 -0400, Stephen Frost wrote: As to your point about not wanting to do it for a single image- it seems we could potentially say that for every individual image proposed, but if we don't keep track of

Re: [HACKERS] FDW API / flow charts for the docs?

2013-10-19 Thread Peter Eisentraut
On Fri, 2013-10-18 at 18:46 -0400, Stephen Frost wrote: As to your point about not wanting to do it for a single image- it seems we could potentially say that for every individual image proposed, but if we don't keep track of those images anywhere then we may not realize that 5 or 10 have

Re: [HACKERS] FDW API / flow charts for the docs?

2013-10-19 Thread Peter Eisentraut
On Sat, 2013-10-19 at 00:52 +0200, Tomas Vondra wrote: AFAIK graphviz can give you at least .ps .svg .fig .png .gif .dia formats (and some other). I believe that covers most (if not all) of the cases you've mentioned. I'm not concerned about that. It's the code that would need to be written

Re: [HACKERS] FDW API / flow charts for the docs?

2013-10-19 Thread Vik Fearing
On 10/19/2013 02:22 AM, Christopher Browne wrote: I would be more inclined to let GraphViz into the process than Dia; the former fits *much* better into a Make-based process. I also cast my vote for Graphviz. -- Vik -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To

Re: [HACKERS] FDW API / flow charts for the docs?

2013-10-18 Thread Stephen Frost
Tomas, * Tomas Vondra (t...@fuzzy.cz) wrote: My impression from that thread was that one of the requirements is reasonable versioning / diff support, and AFAIK that's not a good match for any GUI-based product. So while I like dia and I used it for drawing the charts I submitted today, I

Re: [HACKERS] FDW API / flow charts for the docs?

2013-10-18 Thread Peter Eisentraut
On 10/18/13 5:35 PM, Stephen Frost wrote: I can't see it being a major effort to get it from the wiki into the docs, though perhaps I'm being a bit over-optomistic wrt that. Hah! Consider that an image would have to work with the following toolchains/output formats: - standalone HTML output -

Re: [HACKERS] FDW API / flow charts for the docs?

2013-10-18 Thread Stephen Frost
* Peter Eisentraut (pete...@gmx.net) wrote: In my mind, it's not worth the effort unless we have, say, at least a dozen really useful images to add. I don't want to go through this entire pain for one image on a pretty minor topic. These are certainly fair issues- my point was merely that

Re: [HACKERS] FDW API / flow charts for the docs?

2013-10-18 Thread Andres Freund
On 2013-10-18 18:46:10 -0400, Stephen Frost wrote: As to your point about not wanting to do it for a single image- it seems we could potentially say that for every individual image proposed, but if we don't keep track of those images anywhere then we may not realize that 5 or 10 have actually

Re: [HACKERS] FDW API / flow charts for the docs?

2013-10-18 Thread Tomas Vondra
On 18.10.2013 23:35, Stephen Frost wrote: Tomas, * Tomas Vondra (t...@fuzzy.cz) wrote: My impression from that thread was that one of the requirements is reasonable versioning / diff support, and AFAIK that's not a good match for any GUI-based product. So while I like dia and I used it

Re: [HACKERS] FDW API / flow charts for the docs?

2013-10-18 Thread Tomas Vondra
On 18.10.2013 23:52, Peter Eisentraut wrote: On 10/18/13 5:35 PM, Stephen Frost wrote: I can't see it being a major effort to get it from the wiki into the docs, though perhaps I'm being a bit over-optomistic wrt that. Hah! Consider that an image would have to work with the following

Re: [HACKERS] FDW API / flow charts for the docs?

2013-10-18 Thread Christopher Browne
I would be more inclined to let GraphViz into the process than Dia; the former fits *much* better into a Make-based process. It is worth observing that there are schema diagramming systems (SchemaSpy is mighty likable) that build diagrams using GraphViz. We have integrated this into internal

Re: [HACKERS] FDW API / flow charts for the docs?

2013-10-17 Thread Tomas Vondra
On 17 Říjen 2013, 5:32, Stephen Frost wrote: Alvaro, * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: Tomas Vondra wrote: Attached is the set of flow charts, showing the sequence of callbacks for all the supported commands (i.e. SELECT, INSERT, UPDATE, DELETE, ANALYZE). Wouldn't it be

[HACKERS] FDW API / flow charts for the docs?

2013-10-16 Thread Tomas Vondra
Hi, I've been experimenting with the new reworked FDW API to get familiar with it. The postgres_fdw is a great source of knowledge (huge thanks to Shigeru Hanada, KaiGai Kohei and everyone else who made this happen), but in the end I had to draw some flow charts in Dia, to understand how exactly

Re: [HACKERS] FDW API / flow charts for the docs?

2013-10-16 Thread Fabrízio de Royes Mello
On Wed, Oct 16, 2013 at 8:35 PM, Tomas Vondra t...@fuzzy.cz wrote: [...] Attached is the set of flow charts, showing the sequence of callbacks for all the supported commands (i.e. SELECT, INSERT, UPDATE, DELETE, ANALYZE). Thank you very much... this flow charts will help many people,

Re: [HACKERS] FDW API / flow charts for the docs?

2013-10-16 Thread Alvaro Herrera
Tomas Vondra wrote: Attached is the set of flow charts, showing the sequence of callbacks for all the supported commands (i.e. SELECT, INSERT, UPDATE, DELETE, ANALYZE). Wouldn't it be useful to put something like this into the docs? I mean, the FDW API is not going to get any simpler, and for

Re: [HACKERS] FDW API / flow charts for the docs?

2013-10-16 Thread Stephen Frost
Alvaro, * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: Tomas Vondra wrote: Attached is the set of flow charts, showing the sequence of callbacks for all the supported commands (i.e. SELECT, INSERT, UPDATE, DELETE, ANALYZE). Wouldn't it be useful to put something like this into the