Re: [HACKERS] pg_upgrade - add config directory setting

2011-10-10 Thread Bruce Momjian
Bruce Momjian wrote: Bruce Momjian wrote: OK, I have modified the postmaster in PG 9.2 to allow output of the data directory, and modified pg_ctl to use that, so starting in PG 9.2 pg_ctl will work cleanly for config-only directories. I will now work on pg_upgrade to also use the new

Re: [HACKERS] pg_upgrade - add config directory setting

2011-10-08 Thread Bruce Momjian
Bruce Momjian wrote: OK, I have modified the postmaster in PG 9.2 to allow output of the data directory, and modified pg_ctl to use that, so starting in PG 9.2 pg_ctl will work cleanly for config-only directories. I will now work on pg_upgrade to also use the new flag to find the data

Re: [HACKERS] pg_upgrade - add config directory setting

2011-10-07 Thread Bruce Momjian
Bruce Momjian wrote: Bruce Momjian wrote: I will now work on pg_upgrade to also use the new flag to find the data directory from a config-only install. However, this is only available in PG 9.2, and it will only be in PG 9.3 that you can hope to use this feature (if old is PG 9.2 or

Re: [HACKERS] pg_upgrade - add config directory setting

2011-10-06 Thread Bruce Momjian
Bruce Momjian wrote: Bruce Momjian wrote: Tom Lane wrote: Bruce Momjian br...@momjian.us writes: Tom Lane wrote: Yeah. I think the only sensible way to do this would be to provide an operating mode for the postgres executable that would just parse the config file and spit

Re: [HACKERS] pg_upgrade - add config directory setting

2011-10-06 Thread Bruce Momjian
Bruce Momjian wrote: I will now work on pg_upgrade to also use the new flag to find the data directory from a config-only install. However, this is only available in PG 9.2, and it will only be in PG 9.3 that you can hope to use this feature (if old is PG 9.2 or later). I am afraid the

Re: [HACKERS] pg_upgrade - add config directory setting

2011-10-01 Thread Bruce Momjian
Bruce Momjian wrote: Tom Lane wrote: Bruce Momjian br...@momjian.us writes: Tom Lane wrote: Yeah. I think the only sensible way to do this would be to provide an operating mode for the postgres executable that would just parse the config file and spit out requested values.

Re: [HACKERS] pg_upgrade - add config directory setting

2011-09-29 Thread Bruce Momjian
Peter Eisentraut wrote: On ons, 2011-09-28 at 11:53 -0300, Alvaro Herrera wrote: Excerpts from Peter Eisentraut's message of mi? sep 28 04:49:43 -0300 2011: On tis, 2011-09-27 at 16:13 -0700, Steve Crawford wrote: It would perhaps be useful to add optional --old-confdir and

Re: [HACKERS] pg_upgrade - add config directory setting

2011-09-29 Thread Bruce Momjian
Bruce Momjian wrote: Peter Eisentraut wrote: On ons, 2011-09-28 at 11:53 -0300, Alvaro Herrera wrote: Excerpts from Peter Eisentraut's message of mi? sep 28 04:49:43 -0300 2011: On tis, 2011-09-27 at 16:13 -0700, Steve Crawford wrote: It would perhaps be useful to add optional

Re: [HACKERS] pg_upgrade - add config directory setting

2011-09-29 Thread Alvaro Herrera
Excerpts from Bruce Momjian's message of jue sep 29 09:56:09 -0300 2011: Thinking some more, I don't need to know the data directory while the server is down --- I already am starting it. pg_upgrade starts both old and new servers during its check phase, and it could look up the

Re: [HACKERS] pg_upgrade - add config directory setting

2011-09-29 Thread Mr. Aaron W. Swenson
On Thu, Sep 29, 2011 at 10:44:29AM -0300, Alvaro Herrera wrote: Excerpts from Bruce Momjian's message of jue sep 29 09:56:09 -0300 2011: Thinking some more, I don't need to know the data directory while the server is down --- I already am starting it. pg_upgrade starts both old and new

Re: [HACKERS] pg_upgrade - add config directory setting

2011-09-29 Thread Bruce Momjian
Mr. Aaron W. Swenson wrote: -- Start of PGP signed section. On Thu, Sep 29, 2011 at 10:44:29AM -0300, Alvaro Herrera wrote: Excerpts from Bruce Momjian's message of jue sep 29 09:56:09 -0300 2011: Thinking some more, I don't need to know the data directory while the server is down

Re: [HACKERS] pg_upgrade - add config directory setting

2011-09-29 Thread Steve Crawford
On 09/29/2011 08:20 AM, Bruce Momjian wrote: ... 1 document the limitation and require users to use symlinks 2 add a --old/new-configdir parameter to pg_upgrade 3 have pg_upgrade find the real data dir by starting the server 4 add a flag to some tool to return the real data dir, and

Re: [HACKERS] pg_upgrade - add config directory setting

2011-09-29 Thread Bruce Momjian
Steve Crawford wrote: On 09/29/2011 08:20 AM, Bruce Momjian wrote: ... 1 document the limitation and require users to use symlinks 2 add a --old/new-configdir parameter to pg_upgrade 3 have pg_upgrade find the real data dir by starting the server 4 add a flag to some tool to return

Re: [HACKERS] pg_upgrade - add config directory setting

2011-09-29 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: pg_upgrade is not about to start reading through postgresql.conf looking for a definition for data_directory --- there are too many cases where this could go wrong. It would need a full postgresql.conf parser. Yeah. I think the only sensible way to do

Re: [HACKERS] pg_upgrade - add config directory setting

2011-09-29 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian br...@momjian.us writes: pg_upgrade is not about to start reading through postgresql.conf looking for a definition for data_directory --- there are too many cases where this could go wrong. It would need a full postgresql.conf parser. Yeah. I think the

Re: [HACKERS] pg_upgrade - add config directory setting

2011-09-29 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: Tom Lane wrote: Yeah. I think the only sensible way to do this would be to provide an operating mode for the postgres executable that would just parse the config file and spit out requested values. That would certainly solve the problem, though it

Re: [HACKERS] pg_upgrade - add config directory setting

2011-09-29 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian br...@momjian.us writes: Tom Lane wrote: Yeah. I think the only sensible way to do this would be to provide an operating mode for the postgres executable that would just parse the config file and spit out requested values. That would certainly solve the

Re: [HACKERS] pg_upgrade - add config directory setting

2011-09-28 Thread Peter Eisentraut
On tis, 2011-09-27 at 16:13 -0700, Steve Crawford wrote: It would perhaps be useful to add optional --old-confdir and --new-confdir parameters to pg_upgrade. If these parameters are absent then pg_upgrade would work as it does now and assume that the config files are in the datadir. It

Re: [HACKERS] pg_upgrade - add config directory setting

2011-09-28 Thread Alvaro Herrera
Excerpts from Peter Eisentraut's message of mié sep 28 04:49:43 -0300 2011: On tis, 2011-09-27 at 16:13 -0700, Steve Crawford wrote: It would perhaps be useful to add optional --old-confdir and --new-confdir parameters to pg_upgrade. If these parameters are absent then pg_upgrade would

Re: [HACKERS] pg_upgrade - add config directory setting

2011-09-28 Thread Steve Crawford
On 09/28/2011 12:49 AM, Peter Eisentraut wrote: On tis, 2011-09-27 at 16:13 -0700, Steve Crawford wrote: It would perhaps be useful to add optional --old-confdir and --new-confdir parameters to pg_upgrade. If these parameters are absent then pg_upgrade would work as it does now and assume that

Re: [HACKERS] pg_upgrade - add config directory setting

2011-09-28 Thread Peter Eisentraut
On ons, 2011-09-28 at 11:53 -0300, Alvaro Herrera wrote: Excerpts from Peter Eisentraut's message of mié sep 28 04:49:43 -0300 2011: On tis, 2011-09-27 at 16:13 -0700, Steve Crawford wrote: It would perhaps be useful to add optional --old-confdir and --new-confdir parameters to

[HACKERS] pg_upgrade - add config directory setting

2011-09-27 Thread Steve Crawford
It would perhaps be useful to add optional --old-confdir and --new-confdir parameters to pg_upgrade. If these parameters are absent then pg_upgrade would work as it does now and assume that the config files are in the datadir. The reason for this suggestion is that packages for Ubuntu (and I

Re: [HACKERS] pg_upgrade - add config directory setting

2011-09-27 Thread Mr. Aaron W. Swenson
On Tue, Sep 27, 2011 at 04:13:41PM -0700, Steve Crawford wrote: It would perhaps be useful to add optional --old-confdir and --new-confdir parameters to pg_upgrade. If these parameters are absent then pg_upgrade would work as it does now and assume that the config files are in the datadir.