Re: Backfill bgworker Extension?

On Tue, Dec 12, 2017 at 2:26 PM Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 12/12/17 13:03, Jeremy Finzel wrote: > > To be clear, what I mean is batch updating a large set of data in small > > pieces so as to avoid things like lock contention and replication lags. > >

Re: [HACKERS] Runtime Partition Pruning

On 13 December 2017 at 00:33, Beena Emerson wrote: > PFA the updated patch, this can be applied over the v13 patches [1] > over commit 487a0c1518af2f3ae2d05b7fd23d636d687f28f3 Hi Beena, Thanks for posting an updated patch. I've been looking over this and I think that

Re: [sqlsmith] Parallel worker executor crash on master

On Sat, Dec 16, 2017 at 12:57 AM, Andreas Seltenreich wrote: > Hi, > > sqlsmith just crashed a parallel worker while testing master at > 699bf7d05c. I can reproduce it with the following recipe on a fresh > regression database. Backtrace and query plan below as well. > This

Re: Reproducible builds: genbki.pl vs schemapg.h

On 2017-12-16 07:52:41 +0900, Michael Paquier wrote: > On Sat, Dec 16, 2017 at 3:13 AM, Christoph Berg > wrote: > > Re: Tom Lane 2017-12-15 <9616.1513351...@sss.pgh.pa.us> > >> Christoph Berg writes: > >> > Debian's reproducible builds

Re: Reproducible builds: genbki.pl vs schemapg.h

On Fri, Dec 15, 2017 at 3:21 PM, Andres Freund wrote: >> Why not fixing that? Reproducible builds are a trend of these days, >> and what's proposed here is really simple to make PG more compliant >> with this purpose in mind. > > It's not like $0 instead of a hardcoded name in

autoprewarm is fogetting to register a tranche.

Hello, I noticed while an investigation that pg_prewarm is forgetting to register a tranche. Before the second parameter of LWLockRegisterTranche() became char * in 3761fe3, that would lead to a crash for a --enable-dtrace build, but currently it not likely. On the other hand as far as reading a

Re: GSoC 2018

Hi Stephen, > HA/fail-over is a very broad topic, with a lot of pieces that need to be > done such that I'm not sure it's really viable, but perhaps a precursor > project (synchronous logical replication seems like a prereq, no?) would > make more sense. Or, perhaps, a different piece of the HA

Re: [HACKERS] UPDATE of partition key

On Wed, Dec 13, 2017 at 5:18 AM, Amit Khandekar wrote: > Amit Langote informed me off-list, - along with suggestions for > changes - that my patch needs a rebase. Attached is the rebased > version. I have also bumped the patch version number (now v29), > because this as

Re: pearltidy source code has been removed (pgindent)

On 12/14/2017 08:55 PM, Tom Lane wrote: > Andrew Dunstan writes: >> On 12/14/2017 08:37 PM, Jordan Deitch wrote: >>> I am unable to build pgindent as it appears the pearltidy source has >>> been removed from sourceforge: >>>

Re: [HACKERS] pgbench more operators & functions

2) In makeVariableValue(): if (pg_strcasecmp(var->svalue, "null") == 0) ... else if (pg_strncasecmp(var->svalue, "true", slen) mixing of pg_strcasecmp and pg_strNcasecmp. And, IMHO, result of pg_strncasecmp("tru", "true", 1) will  be 0. Yep, but it cannot be called like that because slen ==

Re: GSoC 2018

Hello, On Fri, Dec 15, 2017, at 14:30, Stephen Frost wrote: > Aleksander, > > * Aleksander Alekseev (a.aleks...@postgrespro.ru) wrote: > > > Regarding the difficulty of the project - in fact it's not that > > difficult. Particularly this project can rely on external tools, e.g. > > use Consul

[HACKERS] wrong t_bits alignment in pageinspect

Hi! I found out the problem in exposing values of t_bits field from heap_page_items function. When the number of attributes in table is multiple of eight, t_bits column shows double number of bits in which data fields are included. For example: # create table tbl(f1 int, f2 int, f3 int,

Re: GSoC 2018

Aleksander, * Aleksander Alekseev (a.aleks...@postgrespro.ru) wrote: > > HA/fail-over is a very broad topic, with a lot of pieces that need to be > > done such that I'm not sure it's really viable, but perhaps a precursor > > project (synchronous logical replication seems like a prereq, no?)

Re: GSoC 2018

Hi Stephen, > synchronous_commit isn't the same as synchronous_standby_names ... What about synchronous_standby_names? Logical replication ignores it and doesn't wait for ack's from replicas or something? > What might be interesting is seeing if Logical Replication could be > added to Patroni

Re: GSoC 2018

Aleksander Alekseev writes: > Hi Stephen, > >> synchronous_commit isn't the same as synchronous_standby_names ... > > What about synchronous_standby_names? Logical replication ignores it and > doesn't wait for ack's from replicas or something? It actually works, see

Re: GSoC 2018

Alex, * Alex Kliukin (al...@hintbits.com) wrote: > On Fri, Dec 15, 2017, at 14:30, Stephen Frost wrote: > > * Aleksander Alekseev (a.aleks...@postgrespro.ru) wrote: > > > > > Regarding the difficulty of the project - in fact it's not that > > > difficult. Particularly this project can rely on

Re: GSoC 2018

Hi Stephen, > New entries are certainly welcome and encouraged, just be sure to note > them as '2018' when you add it. I proposed a few ideas: * High availability / failover based on logical replication * Thrift datatype support Hope these ideas are good enough for GSoC. -- Best regards,

Re: [HACKERS] Surjective functional indexes

On 15.12.2017 01:21, Michael Paquier wrote: On Fri, Dec 15, 2017 at 6:15 AM, Alvaro Herrera wrote: Konstantin Knizhnik wrote: If you still thing that additional 16 bytes per relation in statistic is too high overhead, then I will also remove autotune. I think it's

Re: Package version in PG_VERSION and version()

On Fri, Dec 15, 2017 at 7:46 PM, Christoph Berg wrote: > To be able to identify more easily which package a connected server is > coming from, I would like to embed the (Debian) package version in the > version() output which is coming from PG_VERSION. It is fairly

Re: Package version in PG_VERSION and version()

Re: Michael Paquier 2017-12-15

Re: GSoC 2018

Aleksander, * Aleksander Alekseev (a.aleks...@postgrespro.ru) wrote: > > New entries are certainly welcome and encouraged, just be sure to note > > them as '2018' when you add it. > > I proposed a few ideas: Thanks! > * High availability / failover based on logical replication > * Thrift

Re: GSoC 2018

Hi, 2017-12-15 4:14 GMT+01:00 Stephen Frost : > Unsurprisingly, we'll need to have an Ideas page again, so I've gone > ahead and created one (copying last year's): What about adding "Learned Index" as project task [*]? This type of index looks promising for certain

Re: GSoC 2018

Hi! > 15 дек. 2017 г., в 15:03, Stefan Keller написал(а): > What about adding "Learned Index" as project task [*]? > This type of index looks promising for certain properties. I have no high expectation from this idea. But feel that it is necessary at least to validate the

Package version in PG_VERSION and version()

To be able to identify more easily which package a connected server is coming from, I would like to embed the (Debian) package version in the version() output which is coming from PG_VERSION. It is fairly easy to do that, but it requires patching configure(.in): $ ./configure

Re: GSoC 2018

Stefan, * Stefan Keller (sfkel...@gmail.com) wrote: > 2017-12-15 4:14 GMT+01:00 Stephen Frost : > > Unsurprisingly, we'll need to have an Ideas page again, so I've gone > > ahead and created one (copying last year's): > > What about adding "Learned Index" as project task [*]?

Re: GSoC 2018

On Fri, Dec 15, 2017, at 14:52, Aleksander Alekseev wrote: > Completely agree, this project can be an improvement for Stolon (or > Patroni, but I personally never tested or used it, also I got a feeling > that Google guys will prefer a project that is written in Go). This > would make much more

Re: Reproducible builds: genbki.pl vs schemapg.h

Christoph Berg writes: > Debian's reproducible builds project has revealed that the full build > path gets embedded into server/catalog/schemapg.h: genbki.pl is hardly our only script that prints its $0 ... regards, tom lane

Re: GSoC 2018

Alex, * Alex Kliukin (al...@hintbits.com) wrote: > On Fri, Dec 15, 2017, at 14:52, Aleksander Alekseev wrote: > > Completely agree, this project can be an improvement for Stolon (or > > Patroni, but I personally never tested or used it, also I got a feeling > > that Google guys will prefer a

Re: [HACKERS] UPDATE of partition key

On Fri, Dec 15, 2017 at 7:58 AM, Robert Haas wrote: > Reviewing the preparatory patch: I started another review pass over the main patch, so here are some comments about that. This is unfortunately not a complete review, however. - map =

Re: [HACKERS] pgbench more operators & functions

Hello Teodor, It may be good for 't' of 'f' but it seems too free grammar to accept 'tr' or 'fa' or even 'o' which actually not known to be on or off. Yes, it really works like that. I tried to make something clearer than "src/bin/psql/variable.c". Maybe I did not succeed. Ok, I see.

Re: [HACKERS] pgbench more operators & functions

2017-12-15 14:47 GMT+01:00 Teodor Sigaev : > 2) In makeVariableValue(): >>> if (pg_strcasecmp(var->svalue, "null") == 0) >>> ... >>> else if (pg_strncasecmp(var->svalue, "true", slen) >>> >>> mixing of pg_strcasecmp and pg_strNcasecmp. And, IMHO, result of >>>

Re: [HACKERS] replace GrantObjectType with ObjectType

On 12/14/17 22:59, Rushabh Lathia wrote: > I noted that no_priv_msg and not_owner_msg array been removed > and code fitted the code into aclcheck_error().  Actually that > makes the code more complex then what it used to be.  I would > prefer the array rather then code been fitted into the

Re: Reproducible builds: genbki.pl vs schemapg.h

Re: Tom Lane 2017-12-15 <9616.1513351...@sss.pgh.pa.us> > Christoph Berg writes: > > Debian's reproducible builds project has revealed that the full build > > path gets embedded into server/catalog/schemapg.h: > > genbki.pl is hardly our only script that prints its $0

Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple

On Thu, Dec 14, 2017 at 6:30 PM, Andres Freund wrote: > Pushed this way. Moved some more relfrozenxid/relminmxid tests outside > of the cutoff changes, polished some error messages. > > > Alvaro, Michael, Peter, and everyone else I'd greatly appreciate if you > could have a

[sqlsmith] Parallel worker executor crash on master

Hi, sqlsmith just crashed a parallel worker while testing master at 699bf7d05c. I can reproduce it with the following recipe on a fresh regression database. Backtrace and query plan below as well. regards, Andreas --8<---cut here---start->8--- set

Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple

On 2017-12-15 10:46:05 -0800, Peter Geoghegan wrote: > On Thu, Dec 14, 2017 at 6:30 PM, Andres Freund wrote: > > Pushed this way. Moved some more relfrozenxid/relminmxid tests outside > > of the cutoff changes, polished some error messages. > > > > > > Alvaro, Michael, Peter,

Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple

On 2017-12-15 20:25:22 +0900, Michael Paquier wrote: > On Fri, Dec 15, 2017 at 11:30 AM, Andres Freund wrote: > > Alvaro, Michael, Peter, and everyone else I'd greatly appreciate if you > > could have a look at the backported version, just about everything but > > v10 had

Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple

On Fri, Dec 15, 2017 at 10:58 AM, Andres Freund wrote: >> I have one minor piece of feedback on the upgrading of assertions to >> ereport()s with ERRCODE_DATA_CORRUPTION: It would be nice if you could >> upgrade the raw elog() "can't happen" error within >>

Re: Top-N sorts verses parallelism

On Thu, Dec 14, 2017 at 5:12 PM, Thomas Munro wrote: > > > > This looks like a costing bug. The estimated cost of sorting 416,667 > > estimated tuples in one parallel worker is almost identical to the > estimated > > cost of sorting 1,000,000 tuples when

Re: [HACKERS] replace GrantObjectType with ObjectType

On Fri, Dec 15, 2017 at 12:40 PM, Peter Eisentraut wrote: > On 12/14/17 22:59, Rushabh Lathia wrote: >> I noted that no_priv_msg and not_owner_msg array been removed >> and code fitted the code into aclcheck_error(). Actually that >> makes the code more complex

Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple

On Fri, Dec 15, 2017 at 11:03 AM, Peter Geoghegan wrote: > The elog(), which was itself upgraded from a simple Assert by commit > d70cf811, appears in exactly the same form in 9.3+. Things did change > there, but they were kept in sync. BTW, if you're going to do it, I would target

Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple

On 2017-12-15 11:15:47 -0800, Peter Geoghegan wrote: > On Fri, Dec 15, 2017 at 11:03 AM, Peter Geoghegan wrote: > > The elog(), which was itself upgraded from a simple Assert by commit > > d70cf811, appears in exactly the same form in 9.3+. Things did change > > there, but they were

Bug: Ambiguous Column Reference Allowed When Joining to pg_roles.oid

I recently fell afoul of a weird edge case while writing an extension. It seems Postgres allows for an ambiguous column reference to oid in the where clause when joining to pg_roles. It just arbitrarily chooses pg_roles.oid and ignores the conflicting name. Example: postgres=# CREATE TABLE

Re: [PROPOSAL] bracketed-paste support for psql

On 12/15/17 11:22, Geoff Winkless wrote: > It occurred to me the other day while people were talking about > pasting blocks of text creating problems, especially with tabs, that > xterm bracketed-paste support (also works in at least putty and > probably others) that would block curses handling

Re: [HACKERS] replace GrantObjectType with ObjectType

On 12/13/17 02:35, Michael Paquier wrote: > Patch 0001 is simply removing EventTriggerSupportsGrantObjectType(), > but shouldn't we keep it and return an error for objects that have no > GRANT support? Returning conditionally true looks like a trap waiting > to take someone in. I don't understand

Re: [PROPOSAL] bracketed-paste support for psql

On 15 December 2017 at 17:13, Peter Eisentraut wrote: > You need to put > > set enable-bracketed-paste on > > into ~/.inputrc, then it works. Hmm, looks like that requires a newer version of readline (v7) than I have here. Oh well, if support is already there

Re: [HACKERS] Proposal: Local indexes for partitioned table

Hmm, so I'm now unsure what the actual proposals for handling pg_dump are. We seem to have the following three proposals: 1. Alvaro: use CREATE INDEX ON ONLY (not recursive ), followed by CREATE INDEX ON , followed by ALTER INDEX ATTACH PARTITION . I provide an ALTER INDEX DETACH

Re: Top-N sorts verses parallelism

On Sat, Dec 16, 2017 at 9:13 AM, Robert Haas wrote: > On Fri, Dec 15, 2017 at 2:10 PM, Jeff Janes wrote: >> I had hit on the same change. And was also surprised that it was located >> where it was. With the change, it uses the parallel plan all the

genomic locus

Greetings everyone, I need a data type to represent genomic positions, which will consist of a string and a pair of integers with interval logic and access methods. Sort of like my seg type, but more straightforward. I noticed somebody took a good care of seg while I was away for the last 20

Re: Top-N sorts verses parallelism

On Fri, Dec 15, 2017 at 2:10 PM, Jeff Janes wrote: > I had hit on the same change. And was also surprised that it was located > where it was. With the change, it uses the parallel plan all the way down > to LIMIT 1. > > With the patch, it still satisfies make check, so if

Re: Bug: Ambiguous Column Reference Allowed When Joining to pg_roles.oid

Matthew Kelly writes: > I recently fell afoul of a weird edge case while writing an extension. It > seems Postgres allows for an ambiguous column reference to oid in the where > clause when joining to pg_roles. It just arbitrarily chooses pg_roles.oid > and ignores

Re: [HACKERS] Proposal: Local indexes for partitioned table

On Fri, Dec 15, 2017 at 4:02 PM, Alvaro Herrera wrote: > 3. Robert's: use CREATE INDEX ON ONLY , which creates a shell >index on parent only (no recursion), followed by CREATE INDEX ON >. DETACH is not provided. If you ATTACH an index for a >partition that

Re: [HACKERS] Proposal: Local indexes for partitioned table

Robert Haas wrote: > On Thu, Nov 30, 2017 at 7:02 AM, Alvaro Herrera > wrote: > > Great question. So you're thinking that the planner might have an > > interest in knowing what indexes are defined at the parent table level > > for planning purposes; but for that to

Re: [HACKERS] Proposal: Local indexes for partitioned table

Robert Haas wrote: > On Fri, Dec 15, 2017 at 4:02 PM, Alvaro Herrera > wrote: > > 3. Robert's: use CREATE INDEX ON ONLY , which creates a shell > >index on parent only (no recursion), followed by CREATE INDEX ON > >. DETACH is not provided. If you ATTACH an

"failed to find parent tuple for heap-only tuple" error as an ERRCODE_DATA_CORRUPTION ereport()

Commit d70cf811, from 2014, promoted an Assert() within IndexBuildHeapScan() to a "can't happen" elog() error, in order to detect when a parent tuple cannot be found for some heap-only tuple -- if this happens, then it indicates corruption. I think that we should make it a full ereport(), with an

Re: Reproducible builds: genbki.pl vs schemapg.h

On Sat, Dec 16, 2017 at 3:13 AM, Christoph Berg wrote: > Re: Tom Lane 2017-12-15 <9616.1513351...@sss.pgh.pa.us> >> Christoph Berg writes: >> > Debian's reproducible builds project has revealed that the full build >> > path gets embedded

Re: genomic locus

On Sat, Dec 16, 2017 at 4:49 AM, Gene Selkov wrote: > I noticed somebody took a good care of seg while I was away for the last 20 > years, and I am extremely grateful for that. I have been using it. In the > meantime, things have changed and now I am almost clueless about how