eaning of the previous behaviors? Does bad
padding even give correct answers on decryption? What does encryption
without padding even do on incorrect input sizes?From 848289f7458d71742a327c1625c24a30981f9229 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Mon, 21 Feb 2022 11:24:27 +0100
S
On 20.02.22 01:39, Tom Lane wrote:
Hm, wouldn't it be less code to just use printf?
Meh --- it'd be different from the way we do it in the rest
of initdb, and it would not be "less code". Maybe it'd run
a shade faster, but I refuse to believe that that'd be
enough to matter.
There is a PG_CMD
were some discussions earlier in the thread that some version of
some patch had broken some use of pagers. Does anyone remember details?
Anything worth testing specifically?From 6e75c1bec73f2128b94131305e6a37b97257f7c3 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Tue, 22 Feb 2022 13:4
On 23.02.22 21:30, Andres Freund wrote:
hen verifying that the meson port actually runs all perl based tests I came
across src/interfaces/libpq/test/regress.pl. Instead of running tests yet
another way, it seems better to convert it to a tap test.
I hope others agree?
Where would we want that
On 23.02.22 23:58, Tom Lane wrote:
Peter Eisentraut writes:
On 23.02.22 21:30, Andres Freund wrote:
Where would we want that test to live? Right now we have the slightly odd
convention that some tap tests live in src/test/{misc,modules,...}. But
e.g. frontend binary ones are below src/bin
On 21.02.22 17:17, Andres Freund wrote:
Hi,
On 2022-02-21 14:49:01 +0530, Amit Kapila wrote:
On Mon, Feb 21, 2022 at 1:18 PM Andres Freund wrote:
* stats_reset (Time at which these statistics were last reset)
The view name could be pg_stat_subscription_lrep,
pg_stat_logical_replication, or s
On 23.02.22 03:14, Andres Freund wrote:
Why are the stats stored in the per-database stats file / as a second level
below the database? While they're also associated with a database, it's a
global catalog, so it seems to make more sense to have them "live" globally as
well?
pg_subscription bein
On 24.02.22 02:32, Masahiko Sawada wrote:
On Wed, Feb 23, 2022 at 12:08 PM Peter Smith wrote:
Hi. Below are my review comments for the v1 patch.
Thank you for the comments! I've attached the latest version patch
that incorporated all comments I got so far. The primary change from
the previou
test source
code is laid out, so it makes following the tests and locating failing
test code easier.From 3f50bc5236d7793939904222a38f7e13a2cda47c Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Thu, 24 Feb 2022 11:01:47 +0100
Subject: [PATCH v2] Readd use of TAP subtests
On 23.02.22 12:10, Amit Kapila wrote:
Isn't it better to support this with a syntax as indicated by Tom in
one of his earlier emails on this topic [1]? IIUC, it would be as
follows:
CREATE PUBLICATION p FOR ALL TABLES, ALL SEQUENCES;
I don't think there is any point in supporting this. What F
On 18.12.21 00:53, Brar Piening wrote:
The purpose is that you can directly link to the id in the public html
docs which still gets generated (e. g.
https://www.postgresql.org/docs/14/protocol-replication.html#PROTOCOL-REPLICATION-BASE-BACKUP).
Essentially it gives people discussing the prot
On 24.02.22 12:46, Masahiko Sawada wrote:
We have a view called pg_stat_activity, which is very well known. From
that perspective, "activity" means what is happening right now or what
has happened most recently. The reworked view in this patch does not
contain that (we already have pg_stat_su
On 24.02.22 02:52, Tom Lane wrote:
Peter Eisentraut writes:
On 23.02.22 23:58, Tom Lane wrote:
Peter Eisentraut writes:
libpq TAP tests should be in src/interfaces/libpq/t/.
That's failing to account for the fact that a libpq test can't
really be a pure-perl TAP test; you n
On 23.02.22 00:23, Tom Lane wrote:
This conversation seems to have tailed off without full resolution,
but I observe that pretty much everyone except Peter is on board
with defining pg_log_fatal as pg_log_error + exit(1). So I think
we should just do that, unless Peter wants to produce a finishe
On 18.02.22 11:17, Peter Eisentraut wrote:
I noticed that the JSON path lexer does not support the decimal literal
syntax forms
.1
1.
(that is, there are no digits before or after the decimal point). This
is allowed by the relevant ECMAScript standard
(https://262.ecma-international.org
On 25.02.22 06:36, Brar Piening wrote:
Yes, that would be possible. In fact appending a link and optionally
adding a tiny bit of CSS like I show below does the trick.
The major problem in that regard would probably be my lack of
XSLT/docbook skills but if no one can jump in here, I can see if I
On 24.02.22 16:17, Tom Lane wrote:
I think that having t/ directories contain only Perl test scripts
is a good convention that we should stick to. Peter's proposal
of a separate test/ subdirectory for C test scaffolding is
probably fine.
I wonder if there are any conventions in the Perl commun
On 24.02.22 16:00, Andres Freund wrote:
I've incidentally played with subtests yesterdays, when porting
src/interfaces/libpq/test/regress.pl to a tap test. Unfortunately it seems
that subtests aren't actually specified in the tap format, and that different
libraries generate different output form
You set this commit fest entry to Waiting on Author, but there were no
reviews posted and the patch still applies and builds AFAICT, so I don't
know what you meant by that.
On 13.01.22 00:49, Bossart, Nathan wrote:
On 12/28/21, 8:25 AM, "Peter Eisentraut"
wrote:
(The "
y a bit more compact like this:
psql (15devel)
SSL connection (protocol: TLSv1.3, cipher: TLS_AES_256_GCM_SHA384)
Type "help" for help.
See attached patch.From 65042b40c874ff9f3877e5bbb1915321f5759b68 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Mon, 28 Feb 2022 09:54:16 +0100
S
On 28.02.22 09:41, Brar Piening wrote:
On Feb 25, 2022 at 14:31, Peter Eisentraut wrote:
I think that kind of stuff would be added in via the web site
stylesheets, so you wouldn't have to deal with XSLT at all.
True for the CSS but adding the HTML (#)
will need either XSLT or Javas
rebased patch, no functional changes
On 11.02.22 10:12, Peter Eisentraut wrote:
On 25.06.19 20:37, Andres Freund wrote:
I.e. I think it'd be better if we just added a fork argument to
fill_seq_with_data(), and then do something like
smgrcreate(srel, INIT_FORKNUM, false);
log_smgrcreate
On 27.02.22 10:42, Jille Timmermans wrote:
I wanted to be able to allocate a bunch of numbers from a sequence at
once. Multiple people seem to be struggling with this
(https://stackoverflow.com/questions/896274/select-multiple-ids-from-a-postgresql-sequence,
https://www.depesz.com/2008/03/20/ge
On 28.02.22 00:17, Jeff Davis wrote:
I also have in mind here that there has been discussion of giving
libpq a feature to refuse, on the client side, to send cleartext
passwords.
I am generally in favor of that idea, but I'm not sure that will
completely resolve the issue. For instance, should i
On 17.02.22 20:25, samay sharma wrote:
A use case where this is useful are environments where you want
authentication to be centrally managed across different services. This
is a common deployment model for cloud providers where customers like to
use single sign on and authenticate across diffe
On 28.02.22 11:50, Dagfinn Ilmari Mannsåker wrote:
Daniel Gustafsson writes:
On 28 Feb 2022, at 10:02, Peter Eisentraut
wrote:
Since support for SSL compression has been removed from PostgreSQL, it
doesn't seem sensible to display it anymore.
This was originally done, but all c
On 28.02.22 12:21, Michael Paquier wrote:
What about that making the information
shown version-aware? I would choose to show the compression part only
for server versions where it is settable.
That might lead to confusing results if you are not connecting to
something that is a stock PostgreS
On 25.02.22 14:06, Magnus Hagander wrote:
+OUT jit_generation_time float8,
+OUT jit_inlining_time float8,
+OUT jit_optimization_time float8,
+OUT jit_emission_time float8
Perhaps those should be of type interval?
On 25.02.22 17:26, Andres Freund wrote:
Ok that's good to know. What exactly happens when it tries to parse them?
Does it not count them or does it fail somehow? The way the output is
structured
Says that it can't pase a line of the tap output:
Ok, then I suppose I'm withdrawing this.
Perha
On 28.02.22 16:12, Tom Lane wrote:
Daniel Gustafsson writes:
On 28 Feb 2022, at 12:56, Peter Eisentraut
wrote:
On 28.02.22 11:50, Dagfinn Ilmari Mannsåker wrote:
How about making it show "compression: on" if compression is on, but
nothing in the common "off" case?
Th
On 25.02.22 21:19, Jacob Champion wrote:
On Fri, 2022-02-25 at 16:28 +, Jacob Champion wrote:
Ha, opr_sanity caught my use of cstring. I'll work on a fix later
today.
Fixed in v3.
This patch contains no documentation. I'm having a hard time
understanding what the name "session_authn_id
On 01.03.22 23:05, Jacob Champion wrote:
On Tue, 2022-03-01 at 19:56 +0100, Peter Eisentraut wrote:
This patch contains no documentation. I'm having a hard time
understanding what the name "session_authn_id" is supposed to convey.
The comment for the Port.authn_id field s
On 01.03.22 22:17, Jonathan S. Katz wrote:
If you're moving to a newer version of PostgreSQL, you likely have to
update your connection drivers anyway (rebuilt against new libpq,
supporting any changes in the protocol, etc). I would prefer more data
to support that argument, but this is general
On 01.03.22 22:34, Andres Freund wrote:
The cases I've heard about are about centralizing auth across multiple cloud
services. Including secret management in some form. E.g. allowing an
application to auth to postgres, redis and having the secret provided by
infrastructure, rather than having to
On 01.03.22 20:50, Brar Piening wrote:
Patch is attached. I don't think it should get applied this way, though.
The fact that you only get links for section headers that have manually
assigned ids would be pretty surprising for users of the docs and in
some files (e.g. protocol-flow.html) only ev
On 01.03.22 18:27, Brar Piening wrote:
Also I'm not sure how well the autogenerated ids are reproducible over
time/versions/builds, and if it is wise to use them as targets to link
to from somewhere else.
Autogenerated ids are stable across builds of the same source. They
would change if the
On 02.03.22 05:47, Peter Smith wrote:
This patch introduces a new "Filtering" page to give a common place
where all kinds of logical replication filtering can be described.
(e.g. It is envisaged that a "Column Filters" section can be added
sometime in the future).
The pending feature to select
On 02.03.22 15:16, Jonathan S. Katz wrote:
I find that a lot of people are still purposely using md5. Removing
it now or in a year would be quite a disruption.
What are the reasons they are still purposely using it? The ones I have
seen/heard are:
- Using an older driver
- On a pre-v10 PG
On 02.03.22 20:12, Jille Timmermans wrote:
On 2022-02-28 11:13, Peter Eisentraut wrote:
On 27.02.22 10:42, Jille Timmermans wrote:
I wanted to be able to allocate a bunch of numbers from a sequence at
once. Multiple people seem to be struggling with this
(https://stackoverflow.com/questions
On 02.03.22 21:26, Stephen Frost wrote:
Part of the point, for my part anyway, of dropping support for plaintext
transmission would be to remove support for that from libpq, otherwise a
compromised server could still potentially convince a client to provide
a plaintext password be sent to it.
I
On 02.03.22 16:45, Jonathan S. Katz wrote:
By that argument, we should have kept "password" (plain) as an
authentication method.
For comparison, the time between adding md5 and removing password was 16
years. It has been 5 years since scram was added.
On 02.03.22 15:16, Jonathan S. Katz wrote:
What are the reasons they are still purposely using it? The ones I have
seen/heard are:
- Using an older driver
- On a pre-v10 PG
- Unaware of SCRAM
Another reason is that SCRAM presents subtle operational issues in
distributed systems. As someone
On 02.03.22 21:49, samay sharma wrote:
I think we are discussing two topics in this thread which in my opinion
are orthogonal.
(a) Should we make authentication methods pluggable by exposing these
hooks? - These will allow users to add plugins of their own to support
whatever auth method they
On 15.01.22 10:00, Fabien COELHO wrote:
The reason this test constantly fails on cfbot windows is a
use-after-free
bug.
Indeed! Thanks a lot for the catch and the debug!
The ClearOrSaveResult function is quite annoying because it may or may
not clear the result as a side effect.
Attached v
Is there a current patch set to review in this thread at the moment?
latest understanding was that the DDL-time checking would be removed. I
think it's basically useless now, since as the test cases show, you can
subvert those checks by altering the replica identity later.From d0e9df4674389cda9f891f5678f476d35095c618 Mon Sep 17 00:00:00 2001
From: Peter
introduced in
commit 2bd78eb8d51cc9ee03ba0287b23ff4c266dcd9b9
Author: Peter Eisentraut
Date: 2011-04-06 22:36:06 +0300
Add traceback information to PL/Python errors
We would probably try to write this test differently today, but at this
point I wouldn't bother and just wait for Pytho
On 28.02.22 19:51, Nathan Bossart wrote:
On Mon, Feb 28, 2022 at 07:46:40AM +0100, Peter Eisentraut wrote:
You set this commit fest entry to Waiting on Author, but there were no
reviews posted and the patch still applies and builds AFAICT, so I don't
know what you meant by that.
Apologie
On 09.03.22 11:29, Pavel Borisov wrote:
I've noticed that check_ok() in pg_upgrade.h has been declared two times.
Here's a one-line patch correcting this.
Fixed, thanks.
On 08.03.22 03:56, Andres Freund wrote:
Attached is v6 of the meson patchset. There are a lots of changes since the
last version posted. These include:
- python2 removal is now committed, so not needed in here anymore
- CI changed to be based on the CI now merged into postgres
- CI also tests sus
On 07.03.22 19:18, Robert Haas wrote:
That all said, permissions SHOULD BE strictly additive. If boss doesn't want
to be a member of pg_read_all_files allowing them to revoke themself from that
role seems like it should be acceptable. If there is fear in allowing someone
to revoke (not add)
A general question on this feature: AFAICT, you can only send the proxy
header once at the beginning of the connection. So this wouldn't be of
use for PostgreSQL-protocol connection poolers (pgbouncer, pgpool),
where the same server connection can be used for clients from different
source addr
t the attached?
From c7b408ba646c5ee5f8c6ae84bec04ca4059ed08f Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Thu, 10 Mar 2022 10:49:49 +0100
Subject: [PATCH] DefineCollation() code cleanup
Reorganize the code in DefineCollation() so that the parts using the
FROM clause and the parts not doing
reviewing later.From 43b0aa50d621f3b640e4285e4e329c361988a6c4 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Thu, 10 Mar 2022 12:02:56 +0100
Subject: [PATCH] fixup! Add support for decoding sequences to built-in
replication
---
src/bin/pg_dump/t/002_pg_dump.pl | 2 +-
src/interfaces/libpq/fe-
On 09.03.22 17:44, Andres Freund wrote:
v6-0009-prereq-make-unicode-targets-work-in-vpath-builds.patch.gz
Another directory issue
I think it's a tad different, in that it's fixing something that's currently
broken in VPATH builds.
Ok, I took another look at this.
-override CPPFLAGS := -DFRON
On 09.03.22 14:02, Robert Haas wrote:
On Wed, Mar 9, 2022 at 7:55 AM Peter Eisentraut
wrote:
Do we have subtractive permissions today?
Not in the GRANT/REVOKE sense, I think, but you can put a user in a
group and then mention that group in pg_hba.conf. And that line might
be "rejec
e thread I commented on some aspects of the new grammar
(e.g., do we need FOR ALL SEQUENCES?). I think this would be useful to
review again after all the new logical replication patches are in. I
don't want to hold up this patch for that at this point.From bdded82050841d3b71308ce821
ch locale provider of the
template database (c)
HINT: Use the same locale provider as in the template database, or use
template0 as template.
It feels strange to write "LOCALE_PROVIDER icu" and get "provider (i)" in the
error message. I think it would be better to emit the us
derlying
file can change while it is being read.
The requirements of pg_subscriber can be satisfied more easily: Just
call pg_ctl to start the server. You are already using that in
pg_subscriber. Is there a reason it can't be used here as well?From a0ad5fdaddc17ef74594bfd3c65c777649d1544b Mon Sep 17 0
On 14.03.22 19:57, Robert Haas wrote:
1. What will happen if I set the ICU collation to something that
doesn't match the libc collation? How bad are the consequences?
These are unrelated, so there are no consequences.
2. If I want to avoid a mismatch between the two, then I will need a
way
s now complete from my perspective.From 633d4aa0f762bf976e3ddc077cb9c34b58eeb4d5 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Wed, 16 Mar 2022 10:58:17 +0100
Subject: [PATCH v4] pgcrypto: Remove internal padding implementation
Use the padding provided by OpenSSL instead of doing it ourse
On 15.03.22 18:28, Robert Haas wrote:
On Tue, Mar 15, 2022 at 12:58 PM Peter Eisentraut
wrote:
On 14.03.22 19:57, Robert Haas wrote:
1. What will happen if I set the ICU collation to something that
doesn't match the libc collation? How bad are the consequences?
These are unrelated, so
894df74377bbc5aa624626c4e Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Wed, 16 Mar 2022 18:24:00 +0100
Subject: [PATCH v4] Make JSON path numeric literals more correct
Per ECMAScript standard (ECMA-262, referenced by SQL standard), the
syntax forms
.1
1.
should be allowed for decimal numeric
On 16.03.22 02:25, Kyotaro Horiguchi wrote:
Hello, this is a derived topic from [1], summarized as $SUBJECT.
This just removes useless hyphens from the words
"(crash|emergency)-recovery". We don't have such wordings for "archive
recovery" This patch fixes non-user-facing texts as well as
user-fa
On 15.03.22 08:41, Julien Rouhaud wrote:
The locale object in ICU is an identifier that specifies a particular locale
and has fields for language, country, and an optional code to specify further
variants or subdivisions. These fields also can be represented as a string
with the fields separated
On 16.03.22 21:27, samay sharma wrote:
The only goal of this patch wasn't to enable support for Azure AD.
That's just one client. Users might have a need to add or change auth
methods in the future and providing that extensibility so we don't need
to have core changes for each one of them would
On 17.03.22 13:01, Shinoda, Noriyoshi (PN Japan FSIP) wrote:
Thank you to all the developers.
I found that the description of the pg_database.daticulocale column was not
written in the documentation.
The attached small patch adds a description of the daticulocale column to
catalogs.sgml.
comm
On 17.03.22 14:12, Aleksander Alekseev wrote:
v19-0001 changes the format string for XIDs from %u to XID_FMT. This
refactoring allows us to switch to UINT64_FORMAT by changing one
#define in the future patches.
Kyotaro suggested using `errmsg("blah blah %lld ..", (long long)
xid)` instead in or
On 16.03.22 19:59, Mark Dilger wrote:
Informally, we often use "GUC" on this list, but that isn't used formally, leaving "configuration parameter" and "setting" as the
two obvious choices. I preferred "configuration parameter" originally and was argued out of it. My take on "setting" was also
On 16.03.22 19:47, Tom Lane wrote:
I'm also fairly allergic to the way that this patch has decided to assign
multi-word names to privilege types (ie SET VALUE, ALTER SYSTEM). There
is no existing precedent for that, and I think it's going to break
client-side code that we don't need to break. I
I notice that the publication.sql regression tests contain a number of
comments like
+-- error: replica identity "a" not included in the column list
+ALTER PUBLICATION testpub_fortable ADD TABLE testpub_tbl5 (b, c);
but the error doesn't actually happen, because of the way the replica
identity
On 12.03.22 17:27, Fabien COELHO wrote:
Are you planning to send a rebased patch for this commit fest?
Argh, I did it in a reply in another thread:-( Attached v15.
So as to help moves things forward, I'd suggest that we should not to
care too much about corner case repetition of some error
ou can complete partitioned indexes.From 18ad74bfc2b6d1a758eaab9d2332532f6abb074d Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Fri, 18 Mar 2022 11:44:16 +0100
Subject: [PATCH 1/2] fixup! MERGE SQL Command following SQL:2016
Add back serial commas.
---
doc/src/sgml/libpq.sgml
On 18.03.22 10:27, Julien Rouhaud wrote:
I'm attaching a patch that fixes both issues for me with ICU 50. Note that
there's already a test that would have failed for CREATE DATABASE if initdb
tests didn't fail first, so no new test needed.
I ended up copy/pasting icu_set_collation_attributes()
On 19.03.22 05:14, Julien Rouhaud wrote:
On Fri, Mar 18, 2022 at 03:09:59PM -0700, Andres Freund wrote:
Hi,
On 2022-03-18 20:28:58 +0100, Peter Eisentraut wrote:
Why does your patch introduce a function check_icu_locale() that is only
called once? Did you have further plans for that?
I
On 19.03.22 18:53, Christoph Berg wrote:
Re: Peter Eisentraut
Since some (legacy) code still uses the libc locale facilities
directly, we still need to set the libc global locale settings even if
ICU is otherwise selected. So pg_database now has three
locale-related fields: the existing
On 20.03.22 23:55, Tomas Vondra wrote:
Attached is a rebased patch, addressing most of the remaining issues.
This looks okay to me, if the two FIXMEs are addressed. Remember to
also update protocol.sgml if you change LOGICAL_REP_MSG_SEQUENCE.
On 18.03.22 16:14, Maxim Orlov wrote:
Here is v22. It addresses things mentioned by Tom and Kyotaro. Also
added Aleksander's changes from v21.
The v22-0002-Update-XID-formatting-in-the-.po-files.patch is not
necessary. That is done by a separate procedure.
I'm wondering about things like th
On 22.03.22 00:51, Nathan Bossart wrote:
On Wed, Mar 16, 2022 at 11:12:06AM +0100, Peter Eisentraut wrote:
Right, the previous behaviors were clearly faulty. I have updated the
commit message to call out the behavior change more clearly.
This patch is now complete from my perspective.
I
On 21.03.22 22:54, Tomas Vondra wrote:
On 3/21/22 14:05, Peter Eisentraut wrote:
On 20.03.22 23:55, Tomas Vondra wrote:
Attached is a rebased patch, addressing most of the remaining issues.
This looks okay to me, if the two FIXMEs are addressed. Remember to
also update protocol.sgml if you
On 17.03.22 19:04, Fabien COELHO wrote:
Hello Peter,
See attached v16 which removes the libpq workaround.
I suppose this depends on
https://www.postgresql.org/message-id/flat/ab4288f8-be5c-57fb-2400-e3e857f53e46%40enterprisedb.com
getting committed, because right now this makes the psql
On 17.03.22 19:04, Fabien COELHO wrote:
Indeed! The missing part was put back in v17.
Some unrelated notes on this v17 patch:
-use Test::More;
+use Test::More tests => 41;
The test counts are not needed/wanted anymore.
+
+\set ECHO none
+
This seems inappropriate.
+--
+-- autocommit
+--
On 23.03.22 17:33, Bharath Rupireddy wrote:
It looks like the following errmsg_plural in dependency.c is
unnecessary as numReportedClient > 1 always and numNotReportedClient
can never be < 0. Therefore plural version of the error message is
sufficient. Attached a patch to fix it.
Some languages
On 18.03.22 23:34, Andrew Dunstan wrote:
On 3/15/22 09:51, Peter Eisentraut wrote:
On 21.02.22 13:09, Euler Taveira wrote:
A new tool called pg_subscriber does this conversion and is tightly
integrated
with Postgres.
Are we comfortable with the name pg_subscriber? It seems too general.
Are
On 15.03.22 20:27, samay sharma wrote:
This patch-set adds the following:
* Allow multiple custom auth providers to be registered (Addressing
feedback from Aleksander and Andrew)
* Modify the test extension to use SCRAM to exchange secrets (Based on
Andres's suggestion)
* Add support for custo
unter that ends up being printed, there isn't a need to use int64 in
the first place. See attached patch for examples.From 9c5109c32b8702d14e42324cba027ee987df6cd0 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Wed, 23 Mar 2022 21:44:48 +0100
Subject: [PATCH] Change some variables to
On 21.03.22 05:55, Thomas Munro wrote:
[04:30:50.630] pg_waldump.c:963:26: error: format ‘%u’ expects
argument of type ‘unsigned int *’, but argument 3 has type ‘ForkNumber
*’ [-Werror=format=]
[04:30:50.630] 963 | if (sscanf(optarg, "%u",
&config.filter_by_relation_forknum) != 1 ||
[04:30:50.630
On 23.03.22 10:51, Maxim Orlov wrote:
Thanks for updating the patchs. I have a little comment on 0002.
+ errmsg_internal("found xmax %llu" "
(infomask 0x%04x) not frozen, not multi, not normal",
+
On 2020-11-30 22:15, Pavel Stehule wrote:
I would like some supporting documentation on this. So far we only
have
one stackoverflow question, and then this implementation, and they are
not even the same format. My worry is that if there is not precise
specification, then peo
r removing top-level SELECT INTO
altogether, but there is a nontrivial amount of code for handling it, so
there would be some gain if it could be removed eventually.
From a3ae4248340317ac1580c257472e1361841bd4b2 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Wed, 2 Dec 2020 12:09:39 +0100
x27;t specifically look for them.
From 05e5cf58e66072202707c6fddcd59768a26039be Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Wed, 2 Dec 2020 13:16:15 +0100
Subject: [PATCH] Convert elog(LOG) calls to ereport() where appropriate
User-visible log messages should go through ereport(), so the
tting
DYLD_LIBRARY_PATH, but the tests still work. Verification on other
system variantions welcome, of course.
Comments welcome. I think this direction is promising, but some details
need to be addressed.
From 28f2f9fc2234e3d993027fb014f1c85f7b3db6be Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: W
On 2020-11-30 16:32, Alvaro Herrera wrote:
On 2020-Nov-30, Peter Eisentraut wrote:
Patch updated this way. I agree it's better that way.
Thanks, LGTM.
For a change like this, do we need to change the C symbol names, so that
there is no misbehavior if the shared library is not updat
been introduced by the original logical replication
patch, so there probably wasn't that much scrutiny on this detail then.
From 311f3c7e40b47ace182f1ad5e39a6a12ae80d23c Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Thu, 3 Dec 2020 10:40:57 +0100
Subject: [PATCH] Remove unnecessary gr
On 2020-12-02 18:58, Stephen Frost wrote:
I also found some gratuitous uses of SELECT INTO in various tests and
documentation (not ecpg or plpgsql of course). Here is a patch to adjust
those to CREATE TABLE AS.
If we aren't actually removing SELECT INTO then I don't know that it
makes sense to
On 2020-12-03 00:54, Michael Paquier wrote:
I got to wonder about the impact when migrating applications
though. SELECT INTO has a different meaning in Oracle, but SQL server
creates a new table like Postgres.
Interesting. This appears to be the case. SQL Server uses SELECT INTO
to create a
On 2020-12-02 23:13, Thomas Munro wrote:
I'm experimenting with Github's built in CI. All other ideas welcome.
You can run Linux builds on AppVeyor, too.
On 2020-12-03 16:34, Tom Lane wrote:
As I recall, a whole lot of the pain we have with INTO has to do
with the semantics we've chosen for INTO in a set-operation nest.
We think you can write something like
SELECT ... INTO foo FROM ... UNION SELECT ... FROM ...
but we insist on the INTO bein
A side comment on this patch: I think using enums as bit mask values is
bad style. So changing this:
-/* Reindex options */
-#define REINDEXOPT_VERBOSE (1 << 0) /* print progress info */
-#define REINDEXOPT_REPORT_PROGRESS (1 << 1) /* report pgstat progress */
-#define REINDEXOPT_MISSING_OK (1
On 2020-12-02 15:04, Alvaro Herrera wrote:
- elog(LOG, "WSAIoctl(SIO_KEEPALIVE_VALS) failed: %ui",
-WSAGetLastError());
+ ereport(LOG,
+ (errmsg("WSAIoctl(SIO_KEEPALIVE_VALS) failed:
%ui",
+
1 - 100 of 4956 matches
Mail list logo
