Re: Updated macOS start scripts

2017-11-15 Thread Tom Lane
Mark Dilger <hornschnor...@gmail.com> writes: >> On Nov 15, 2017, at 8:32 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> The stuff in contrib/start-scripts/osx/ does not, as far as I know, >> work at all on any recent release of macOS, because SystemStarter >>

Re: Fix number skipping in to_number

2017-11-15 Thread Tom Lane
I wrote: > Oliver Ford <ojf...@gmail.com> writes: >> On Monday, 13 November 2017, Tom Lane <t...@sss.pgh.pa.us> wrote: >>> I don't follow your concern? If "$" is not the correct currency >>> symbol for the locale, we shouldn't accept it as a match

Re: Further simplification of c.h's #include section

2017-11-15 Thread Tom Lane
I wrote: > Robert Haas <robertmh...@gmail.com> writes: >> On Wed, Nov 15, 2017 at 4:32 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >>> How do you feel about "win32_more.h"? >> Seems morally equivalent to what you had before. I think what I would >&g

Re: Updated macOS start scripts

2017-11-15 Thread Tom Lane
east that far back. I don't have access to relevant, > pre-10.4 machines. IIRC, I already did test it on 10.6.8, but no harm in your double checking. regards, tom lane

Re: Further simplification of c.h's #include section

2017-11-15 Thread Tom Lane
I wrote: > Robert Haas <robertmh...@gmail.com> writes: >> On Wed, Nov 15, 2017 at 10:51 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >>> 1. Move what's currently in src/include/port/win32.h (a/k/a >>> pg_config_os.h) to a new file, say src/include/port/win32

Re: [HACKERS] SQL procedures

2017-11-14 Thread Tom Lane
Peter Eisentraut <peter.eisentr...@2ndquadrant.com> writes: > On 11/14/17 11:14, Tom Lane wrote: >> ... Do we really want the existence of >> a function foo(int) to mean that you can't create a SQL procedure named >> foo and taking one int argument? > Yes, that

Re: [HACKERS] Bug in ExecModifyTable function and trigger issues for foreign tables

2017-11-27 Thread Tom Lane
It wouldn't save a lot, but yeah, doing it in this order seems a bit silly when you put it like that. regards, tom lane

Re: [HACKERS] Bug in ExecModifyTable function and trigger issues for foreign tables

2017-11-27 Thread Tom Lane
e or after what expand_targetlist() does. I'm doubtful that the potential savings is worth taking risks there. In particular, it seems like a good thing that expand_targetlist() verifies the correct tlist ordering *after* the FDW function has acted. So now my inclination is to leave this alone.

Re: documentation is now XML

2017-11-28 Thread Tom Lane
Peter Eisentraut <peter.eisentr...@2ndquadrant.com> writes: > On 11/23/17 15:39, Tom Lane wrote: >> I think we should have a discussion about whether it'd be smart >> to convert the back branches' documentation to XML as well. > My short answer to that is, I don't have

Re: documentation is now XML

2017-11-28 Thread Tom Lane
Andrew Dunstan <andrew.duns...@2ndquadrant.com> writes: > On 11/28/2017 12:06 PM, Tom Lane wrote: >> One thing we'd definitely better do is enable some buildfarm coverage. >> AFAIK, the only buildfarm animal that's building the docs is guaibasaurus, >> and it only see

Re: [HACKERS] postgres_fdw bug in 9.6

2017-11-28 Thread Tom Lane
I wrote: > Robert Haas <robertmh...@gmail.com> writes: >> On Tue, Aug 29, 2017 at 5:14 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >>> We'd definitely need to do things that way in 9.6. I'm not quite sure >>> whether it's too late to adopt the clean solution i

Re: [HACKERS] More stats about skipped vacuums

2017-11-27 Thread Tom Lane
; However, when it comes to the stats system, I'd say that on any busy system > (which would be the ones to care about), the stats structures are still > going to be *written* a lot more than they are read. Uh, what? The stats collector doesn't write those files at all except on-demand. regards, tom lane

Re: simplehash: tb->sizemask = 0

2017-11-27 Thread Tom Lane
the behavior as the limit is approached and reached. regards, tom lane

Re: Updated macOS start scripts

2017-11-28 Thread Tom Lane
need to see how that interacts with using pg_ctl. Some documentation might be needed in any case. regards, tom lane

Re: pgindent run?

2017-11-28 Thread Tom Lane
ad-hoc reindent on some of these files. regards, tom lane

Re: Updated macOS start scripts

2017-11-28 Thread Tom Lane
Mark Dilger <hornschnor...@gmail.com> writes: >> On Nov 28, 2017, at 11:17 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> Hmm. Maybe we should have the plist file set KeepAlive to false not true? >> This would mean you'd need manual action to restart a failed postmast

Re: Skip index cleanup if autovacuum did not do any work

2017-11-28 Thread Tom Lane
much if there are no dead tuples. One thing that I think it does do is update the index's pg_class stats (relpages/reltuples). Maybe it's okay to skip that in this particular scenario, trusting that auto-analyze would fix it, but that seems worthy of debate. regards, tom lane

Re: [HACKERS] postgres_fdw super user checks

2017-11-28 Thread Tom Lane
RWF. Although maybe switching to owner privileges would be so different as to constitute an unrelated patch. regards, tom lane

Re: pgindent run?

2017-11-28 Thread Tom Lane
Thomas Munro <thomas.mu...@enterprisedb.com> writes: > On Wed, Nov 29, 2017 at 9:47 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> I think that'd be taking it too far, especially given that the dependency >> on a typedefs list means that the git hook might have a different

Re: [HACKERS] postgres_fdw: Add support for INSERT OVERRIDING clause

2017-11-28 Thread Tom Lane
tending with back then. (Which I don't recall the details of; you'll need to trawl the archives. Should be somewhere early in 2013, though, since we implemented that change in commit 50c19fc76.) regards, tom lane

Re: pgindent run?

2017-11-28 Thread Tom Lane
Mark Dilger <hornschnor...@gmail.com> writes: >> On Nov 28, 2017, at 12:47 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> I think that'd be taking it too far, especially given that the dependency >> on a typedefs list means that the git hook might have a different idea &

Re: [HACKERS] PATCH: multivariate histograms and MCV lists

2017-11-25 Thread Tom Lane
ormal operation, it should definitely have an ereport (and a non-default errcode). regards, tom lane

Re: [PATCH] Fix crash in int8_avg_combine().

2017-11-25 Thread Tom Lane
, while > this statement (which moves a __int128 from one memory location to another > memory location) expects 16-byte memory alignments. So when either state1 > or state2 is not 16-byte aligned, this crashes. I believe we already dealt with this: Author: Tom Lane <t...@sss.pgh.pa.us>

Re: [HACKERS] More stats about skipped vacuums

2017-11-25 Thread Tom Lane
o this is sounding like quite a lot of new counters, in support of perhaps 0.1% of the user population. Most people are just going to set maintenance_work_mem as high as they can tolerate and call it good. regards, tom lane

Re: [HACKERS] More stats about skipped vacuums

2017-11-25 Thread Tom Lane
e would break peoples' queries, probably subtly. What we need is a way to have a consistent snapshot without implementing it by copying 100,000 tables' worth of data for every query. Hmm, I heard of a technique called MVCC once ... regards, tom lane

Re: Code cleanup patch submission for extended_stats.c

2017-11-25 Thread Tom Lane
lean arrays, too. regards, tom lane

Re: [HACKERS] More stats about skipped vacuums

2017-11-25 Thread Tom Lane
probably keep the stats tables in a DSM segment; but how would a backend get a consistent snapshot of them? regards, tom lane

Re: [HACKERS] HASH_CHUNK_SIZE vs malloc rounding

2017-11-23 Thread Tom Lane
Thomas Munro <thomas.mu...@enterprisedb.com> writes: > On Tue, Nov 29, 2016 at 6:27 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> We could imagine providing an mmgr API function along the lines of "adjust >> this request size to the nearest thing that can be alloc

Re: [HACKERS] More stats about skipped vacuums

2017-11-26 Thread Tom Lane
"INFO: scanned index" line for each scan. regards, tom lane

Re: has_sequence_privilege() never got the memo

2017-11-22 Thread Tom Lane
nt with the rest of acl.c, but maybe there's some deeper reason? Peter? regards, tom lane

Re: [PATCH] using arc4random for strong randomness matters.

2017-11-22 Thread Tom Lane
ilm...@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes: > Tom Lane <t...@sss.pgh.pa.us> writes: >> More generally, why should we bother with an additional implementation? >> Is this better than /dev/urandom, and if so why? > If what is wanted is something mor

Re: [PATCH] using arc4random for strong randomness matters.

2017-11-22 Thread Tom Lane
nd if so why? regards, tom lane

Re: How is the PostgreSQL debuginfo file generated

2017-11-23 Thread Tom Lane
ackaging system, not by PG proper. You should proceed by making a new SRPM and building RPMs from that. regards, tom lane

Re: [HACKERS] static assertions in C++

2017-11-29 Thread Tom Lane
ed some love as well. I have no other comments either. regards, tom lane

Re: using index or check in ALTER TABLE SET NOT NULL

2017-11-29 Thread Tom Lane
Stephen Frost <sfr...@snowman.net> writes: > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> I did not look at the patch yet, but TBH if it uses SPI for sub-operations >> of ALTER TABLE I think that is sufficient reason to reject it out of hand. > You mean like what ALTER TABLE

Re: [HACKERS] postgres_fdw bug in 9.6

2017-11-29 Thread Tom Lane
Ashutosh Bapat <ashutosh.ba...@enterprisedb.com> writes: > On Tue, Nov 28, 2017 at 11:05 PM, Robert Haas <robertmh...@gmail.com> wrote: >> On Tue, Nov 28, 2017 at 11:21 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >>> In short, we should get rid of all of this exp

Re: [HACKERS] static assertions in C++

2017-11-29 Thread Tom Lane
Andres Freund <and...@anarazel.de> writes: > On 2017-11-29 16:39:14 -0500, Tom Lane wrote: >> Andres Freund <and...@anarazel.de> writes: >>> FWIW, I think that's a perfectly reasonable choice. Adding complications >>> in making static assertions work for rand

Re: [HACKERS] static assertions in C++

2017-11-29 Thread Tom Lane
just want "we don't support this" to be spelled "#error", rather than dumping off a load of reasoning about what might happen without functioning static asserts --- on a weird compiler, no less --- onto our future selves. regards, tom lane

Re: Protect syscache from bloating with negative cache entries

2017-11-29 Thread Tom Lane
is that we used to have a catcache size limitation mechanism, and ripped it out because it had too much overhead (see commit 8b9bc234a). I'm not sure how we can avoid that problem within a fresh implementation. regards, tom lane

Re: pl/perl extension fails on Windows

2017-11-29 Thread Tom Lane
Noah Misch <n...@leadboat.com> writes: > On Thu, Aug 17, 2017 at 12:15:58PM -0400, Tom Lane wrote: >> ... it's now looking to me like we should do the above with X = 5.13.4. >> That won't be a perfect solution, but it's about the best we can >> readily do. Realistical

Re: [HACKERS] <> join selectivity estimate question

2017-11-29 Thread Tom Lane
nd a bit till I found such a query, and committed it. regards, tom lane

Re: Protect syscache from bloating with negative cache entries

2017-11-30 Thread Tom Lane
Robert Haas <robertmh...@gmail.com> writes: > On Wed, Nov 29, 2017 at 11:17 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> The thing that makes me uncomfortable about this is that we used to have a >> catcache size limitation mechanism, and ripped it out because it ha

Isn't partition drop code seriously at risk of deadlock?

2017-11-27 Thread Tom Lane
possibly be deadlock-free to be trying to grab AccessExclusiveLock on a partition's parent table when we already have such a lock on the partition. Which we do, or at least had better, long before we get to heap_drop_with_catalog. regards, tom lane

Re: [HACKERS] Bug in ExecModifyTable function and trigger issues for foreign tables

2017-11-27 Thread Tom Lane
Dean Rasheed <dean.a.rash...@gmail.com> writes: > On 27 November 2017 at 16:35, Tom Lane <t...@sss.pgh.pa.us> wrote: >> On looking closer, the reason it's like that in Fujita-san's patch >> is to minimize the API churn seen by FDW AddForeignUpdateTargets >> functio

Re: documentation is now XML

2017-11-23 Thread Tom Lane
not-strictly-necessary changes in the back branches. Which is a strong factor, for sure, but I think maybe here's a case for overriding it. regards, tom lane

Re: [HACKERS] SQL procedures

2017-11-22 Thread Tom Lane
roc is the same as the value of its last command. There's no such thing as a proc that doesn't return a value. regards, tom lane

Re: ASCII Null control character validation

2017-11-30 Thread Tom Lane
iscussions of this issue. regards, tom lane

Re: [HACKERS] postgres_fdw bug in 9.6

2017-11-30 Thread Tom Lane
Etsuro Fujita <fujita.ets...@lab.ntt.co.jp> writes: > (2017/11/30 7:32), Tom Lane wrote: >> the output of the foreign join cannot change during EPQ, since the remote >> server already locked the rows before returning them. The only thing that >> can change is t

Re: Errands around AllocateDir()

2017-12-04 Thread Tom Lane
Robert Haas <robertmh...@gmail.com> writes: > On Mon, Dec 4, 2017 at 12:05 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> The only part of this that seems likely to be controversial is the >> decision to get rid of special-case error messages, eg replace >> "co

Silly API for do_pg_start_backup()

2017-12-04 Thread Tom Lane
. regards, tom lane

Is it OK to ignore directory open failure in ResetUnloggedRelations?

2017-12-04 Thread Tom Lane
something badly wrong if we can't. Thoughts? regards, tom lane

Re: Bitmap scan is undercosted?

2017-12-03 Thread Tom Lane
improved some comments, got rid of a NumRelids() test that's redundant with the preceding bms_membership() test, and fixed dependencies_clauselist_selectivity so that estimatedclauses actually is a pure output argument as stated by its API contract. regards, tom lane diff --git a/src/backend/s

Re: [HACKERS] postgres_fdw bug in 9.6

2017-12-03 Thread Tom Lane
in the not-too-long run. As such, it'd be okay if it were smaller, but it seems bigger and more invasive than I could wish for a band-aid. regards, tom lane

Re: Errands around AllocateDir()

2017-12-04 Thread Tom Lane
it does not change errno. This is because there seemed to be other call sites that were depending on that, not just this one. Anyway, that seemed like a more future-proof fix than relying on callers to deal with it. regards, tom lane

Re: Error handling (or lack of it) in RemovePgTempFilesInDir

2017-12-04 Thread Tom Lane
Michael Paquier <michael.paqu...@gmail.com> writes: > On Tue, Dec 5, 2017 at 10:51 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> Uh ... I'm confused? That particular change only concerns whether we emit >> a log message, not whether the action is attempted or succeeds.

Re: Error handling (or lack of it) in RemovePgTempFilesInDir

2017-12-04 Thread Tom Lane
Michael Paquier <michael.paqu...@gmail.com> writes: > On Tue, Dec 5, 2017 at 11:15 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> The general theory I'm operating on is that we should endeavor to >> let the database start in any situation where that doesn't involve >>

Re: Errands around AllocateDir()

2017-12-04 Thread Tom Lane
regards, tom lane

Re: Error handling (or lack of it) in RemovePgTempFilesInDir

2017-12-04 Thread Tom Lane
nly* the next postmaster > restart would remove remnant temp files which can cause potentially GB > of data to stay around. Uh ... I'm confused? That particular change only concerns whether we emit a log message, not whether the action is attempted or succeeds. regards, tom lane

Re: Reproducible builds: genbki.pl vs schemapg.h

2017-12-16 Thread Tom Lane
somebody either copies that coding pattern into some new script or tweaks the way those existing scripts are being used. regards, tom lane

Sun Studio 12 vs. __builtin_constant_p()

2017-12-14 Thread Tom Lane
result in slightly worse code optimization around ereport/elog calls on compilers that don't have this behavior, but that seems fine to me. regards, tom lane

Re: MemoryContextCreate change in PG 11 how should contexts be created

2017-12-19 Thread Tom Lane
is destroyed, seems like what you ought to be using is a memory context reset callback. Look at MemoryContextRegisterResetCallback and its callers (there are just a couple at the moment, though I'm fooling with a patch that will add more). regards, tom lane

Re: pearltidy source code has been removed (pgindent)

2017-12-14 Thread Tom Lane
tend to reindent the Perl code ... regards, tom lane

Re: Package version in PG_VERSION and version()

2017-12-15 Thread Tom Lane
Christoph Berg writes: > Re: Michael Paquier 2017-12-15 >

Re: Reproducible builds: genbki.pl vs schemapg.h

2017-12-15 Thread Tom Lane
Christoph Berg <christoph.b...@credativ.de> writes: > Debian's reproducible builds project has revealed that the full build > path gets embedded into server/catalog/schemapg.h: genbki.pl is hardly our only script that prints its $0 ... regards, tom lane

Re: Bug: Ambiguous Column Reference Allowed When Joining to pg_roles.oid

2017-12-15 Thread Tom Lane
re's a matching user-defined column in the join output then that doesn't happen. It definitely is a bit unfortunate that the pg_roles view exposes a user-defined column named "oid", but we felt we had to do that to avoid breaking user queries that date from when pg_roles was a plain table. regards, tom lane

Re: Rethinking MemoryContext creation

2017-12-12 Thread Tom Lane
movement on that benchmark, and it'd be brighter to look for test cases where more contexts are involved. regards, tom lane diff --git a/contrib/amcheck/verify_nbtree.c b/contrib/amcheck/verify_nbtree.c index 868c14e..adbbc44 100644 *** a/con

Re: Using ProcSignal to get memory context stats from a running backend

2017-12-19 Thread Tom Lane
Andres Freund <and...@anarazel.de> writes: > On 2017-12-19 13:17:52 -0500, Tom Lane wrote: >> Yeah. But please don't mess with MemoryContextStats per se --- >> I dunno about you guys but "call MemoryContextStats(TopMemoryContext)" >> is kinda wired into my gdb

Re: Using ProcSignal to get memory context stats from a running backend

2017-12-19 Thread Tom Lane
of the per-context-type functions these would call, though, because nobody calls those functions directly. regards, tom lane

Letting plpgsql in on the fun with the new expression eval stuff

2017-12-19 Thread Tom Lane
Comments, better ideas? regards, tom lane

Re: Protect syscache from bloating with negative cache entries

2017-12-19 Thread Tom Lane
int of view I'm not very sure that it's worth distinguishing cases A and C. It's conceivable that we could rewrite all the lookup algorithms so that they didn't require negative cache entries to have good performance ... but I doubt that that's easy to do. regards, tom lane

Re: [HACKERS] static assertions in C++

2017-12-19 Thread Tom Lane
Peter Eisentraut <peter.eisentr...@2ndquadrant.com> writes: > On 12/11/17 17:12, Tom Lane wrote: >> Hmm, well, surely there's more than one way to do that; the sizeof >> is just a convenient way to wrap it in C. Wouldn't a typedef serve >> just as well? > Here

Re: Why does array_position_common bitwise NOT an Oid type?

2017-12-16 Thread Tom Lane
If we take the lookup path then the bogus element_type will be detected and reported; if we don't, it won't be. We could instead add an explicit test for element_type == InvalidOid, but that's just more duplicative code. regards, tom lane

Re: Inconsistency in plpgsql's error context reports

2017-12-13 Thread Tom Lane
Robert Haas <robertmh...@gmail.com> writes: > On Mon, Dec 11, 2017 at 3:52 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> Here's a quick hack at that. I guess the main question that needs to be >> asked is whether we're happy with plpgsql getting so much chattier >>

Re: Rethinking MemoryContext creation

2017-12-12 Thread Tom Lane
able, so you could imagine that AllocSetDelete shoves it onto a freelist after resetting it, instead of just giving it back to libc. I'm slightly worried about creating allocation islands that way, but that problem is probably surmountable, if it's real at all. However, that seems like a differ

Re: plpgsql test layout

2017-12-12 Thread Tom Lane
ng up for MSVC. How about this? Looks ok to me, though I'm not in a position to actually test the msvc changes. regards, tom lane

Re: money type's overflow handling is woefully incomplete

2017-12-12 Thread Tom Lane
rop reltime/abstime without too many complaints. Y2038 is coming.) regards, tom lane

Re: Rethinking MemoryContext creation

2017-12-12 Thread Tom Lane
the runtime cost doesn't really seem worth it. I got some results while I was rearranging code that suggest that skipping those tests could be worthwhile in practice, now that there's a common short path through AllocSetContextCreate. regards, tom lane diff --git a/contrib/amchec

_WINSOCK_DEPRECATED_NO_WARNINGS

2017-11-16 Thread Tom Lane
re any good reason not to just define _WINSOCK_DEPRECATED_NO_WARNINGS unconditionally? Presumably it would have no effect on VS versions too old to know the symbol. I'm a bit inclined to move it to win32_port.h, as well, since that's what includes . regards, tom lane

Re: Further simplification of c.h's #include section

2017-11-16 Thread Tom Lane
David Rowley <david.row...@2ndquadrant.com> writes: > On 16 November 2017 at 15:52, Tom Lane <t...@sss.pgh.pa.us> wrote: >> Anybody want to test this manually, or shall we just throw it into the >> buildfarm and see what blows up? > I don't have any cygwi

Re: [HACKERS] A weird bit in pg_upgrade/exec.c

2017-11-16 Thread Tom Lane
, without any thought for the fact that those calls were thereby made redundant. Fix pushed, thanks for noticing! regards, tom lane

Re: Fix number skipping in to_number

2017-11-17 Thread Tom Lane
d that patch. regards, tom lane

Re: [HACKERS] Consistently catch errors from Python _New() functions

2017-11-17 Thread Tom Lane
therwise it looks reasonable. regards, tom lane

Bizarre behavior of literal-substring parsing in formatting.c

2017-11-17 Thread Tom Lane
r from before is the last one, which is the case I just showed. If no objections, I'll push this shortly. I think putting it in HEAD is enough, given the lack of field complaints. regards, tom lane diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml index 35a845c..69

Re: Treating work_mem as a shared resource (Was: Parallel Hash take II)

2017-11-17 Thread Tom Lane
tly. I agree there's a lot of potential for improvement if we can find a better solution, but we're going to need to put some serious thought into it. regards, tom lane

Re: FP16 Support?

2017-11-13 Thread Tom Lane
ate to think about whether float16 is a useful solution. I don't deny that we could get there someday, but I think putting in float16 now would be a fine example of having your priorities reversed. regards, tom lane

Re: [HACKERS] parallelize queries containing initplans

2017-11-14 Thread Tom Lane
e to do so. Yeah, I'm sure it is. I have a vague recollection that there might be existing regression test cases exercising such things, though I won't swear to that. The "orderstest" bit in subselect.sql looks like it might be meant to do that... regards, tom lane

Re: [HACKERS] SQL procedures

2017-11-14 Thread Tom Lane
Peter Eisentraut <peter.eisentr...@2ndquadrant.com> writes: > On 11/8/17 09:54, Tom Lane wrote: >> Do procedures of this ilk belong in pg_proc at all? It seems like a large >> fraction of the attributes tracked in pg_proc are senseless for this >> purpose. A ne

Re: percentile value check can be slow

2017-11-18 Thread Tom Lane
astonishing. regards, tom lane

Re: to_typemod(type_name) information function

2017-11-18 Thread Tom Lane
would help you. regards, tom lane

Re: [HACKERS] pgbench regression test failure

2017-11-20 Thread Tom Lane
hmetic. We have not gone as far as deciding that Postgres will only run on IEEE hardware, and I don't want to start in pgbench, especially not in seldom-exercised corner cases. regards, tom lane

Re: [HACKERS] CLUSTER command progress monitor

2017-11-20 Thread Tom Lane
ot that wrong, maybe horribly so. I think it's a bad idea for progress monitoring to depend on the planner's estimates in any way whatsoever. regards, tom lane

Re: [HACKERS] [PATCH] A hook for session start

2017-11-20 Thread Tom Lane
typedef name, to emphasize that what we are classifying is the postmaster and its children. regards, tom lane

Re: [PATCH] Porting small OpenBSD changes.

2017-11-20 Thread Tom Lane
David CARLIER <devne...@gmail.com> writes: > On 20 November 2017 at 18:49, Tom Lane <t...@sss.pgh.pa.us> wrote: >> OTOH, we still have M68K >> and VAX stanzas in that file, so I suppose it's silly to complain >> about 88K. A bigger issue is that I wonder whether

Re: [PATCH] Porting small OpenBSD changes.

2017-11-20 Thread Tom Lane
David CARLIER <devne...@gmail.com> writes: > I m not against, I would go with your final version too. Thanks ! Pushed to all supported branches. regards, tom lane

Re: [PATCH] Porting small OpenBSD changes.

2017-11-20 Thread Tom Lane
and and confused myself about what was what. I still think the form I proposed is better style though. regards, tom lane

Re: [PATCH] Porting small OpenBSD changes.

2017-11-20 Thread Tom Lane
call is even syntactically correct. There should be colons in it. regards, tom lane

Anybody care about having the verbose form of the tzdata files?

2017-11-20 Thread Tom Lane
e cares about that. Anybody here actually care about reading the zone data files? regards, tom lane

Re: Using isatty() on WIN32 platform

2017-11-20 Thread Tom Lane
s definition lives in. regards, tom lane

Re: [HACKERS] Index only scan for cube and seg

2017-11-20 Thread Tom Lane
es, you'd forgotten to update the alternative expected-files. regards, tom lane

Re: spgist rangetypes compiler warning (gcc 7.2.0)

2017-11-18 Thread Tom Lane
n to > if (in->traversalValue) Agreed, especially since it's done like that in spgscan.c and geo_spgist.c. regards, tom lane

  1   2   3   4   5   6   7   8   9   10   >