Re: [HACKERS] [Mingw-users] mingw64

2011-02-16 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Mon, Feb 14, 2011 at 09:14:03AM CET: > Den 2011-02-12 11:10 skrev Ralf Wildenhues: > > * Peter Rosin wrote on Sat, Jan 29, 2011 at 02:26:24PM CET: > >> Or is plain 'ar' used somewhere instead of 'x86_64-w64-mingw32-ar'? > > > > Automake outputs 'AR = ar' in Makefi

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-16 Thread Lukas Eder
I'm not trying to fix the signature. I want exactly that signature. I want to return 1 UDT as an OUT parameter from a function. Somewhere between JDBC and the database, this signature is lost, and JDBC's internal code tells me that I have to bind 6 OUT parameters, instead of 1. It happens to be so

Re: [HACKERS] why two dashes in extension load files

2011-02-16 Thread Cédric Villemain
2011/2/16 Alex Hunsaker : > On Tue, Feb 15, 2011 at 14:12, Robert Haas wrote: >> On Tue, Feb 15, 2011 at 3:26 PM, marcin mank wrote: >>> how about : we use a single dash as the separator, and if the >>> extension author insists on having a dash in the name, as a punishment >>> he must duplicate t

Re: [HACKERS] review: FDW API

2011-02-16 Thread Heikki Linnakangas
On 15.02.2011 23:00, Tom Lane wrote: Heikki Linnakangas writes: On 15.02.2011 21:13, Tom Lane wrote: Hmm. I don't have a problem with adding relkind to the planner's RelOptInfo, but it seems to me that if parse analysis needs to know this, you have put functionality into parse analysis that d

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-16 Thread Robert Haas
On Wed, Feb 16, 2011 at 3:30 AM, Lukas Eder wrote: > I'm not trying to fix the signature. I want exactly that signature. I want > to return 1 UDT as an OUT parameter from a function. > > Somewhere between JDBC and the database, this signature is lost, and JDBC's > internal code tells me that I hav

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-16 Thread Oliver Jowett
On 17/02/11 00:58, Robert Haas wrote: > On Wed, Feb 16, 2011 at 3:30 AM, Lukas Eder wrote: >> I'm not trying to fix the signature. I want exactly that signature. I want >> to return 1 UDT as an OUT parameter from a function. >> >> Somewhere between JDBC and the database, this signature is lost, an

Re: [HACKERS] DROP SCHEMA xxx CASCADE: ERROR: could not open relation with OID yyy

2011-02-16 Thread strk
On Thu, Feb 10, 2011 at 12:03:49AM -0500, Tom Lane wrote: > strk writes: > > I've finally completed the debugging phase and have > > a minimal self-contained testcase showing the problem. > > It has to do with INITIALLY DEFERRED constraints. > > I looked into this and find that the issue is you'r

Re: [HACKERS] Change pg_last_xlog_receive_location not to move backwards

2011-02-16 Thread Robert Haas
On Wed, Feb 16, 2011 at 12:59 AM, Fujii Masao wrote: > On Tue, Feb 15, 2011 at 9:41 PM, Robert Haas wrote: >> On Tue, Feb 15, 2011 at 12:34 AM, Fujii Masao wrote: >>> You suggest that the shared variable Stream tracks the WAL write location, >>> after it's set to the replication starting positio

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-16 Thread Robert Haas
On Wed, Feb 16, 2011 at 7:07 AM, Lukas Eder wrote: > So what should I do? File a bug to the main Postgres mailing list? Or just > not support that feature? Well, I thought you just said you'd ruled out a PG bug? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-16 Thread Robert Haas
On Wed, Feb 16, 2011 at 7:03 AM, Oliver Jowett wrote: > On 17/02/11 00:58, Robert Haas wrote: >> On Wed, Feb 16, 2011 at 3:30 AM, Lukas Eder wrote: >>> I'm not trying to fix the signature. I want exactly that signature. I want >>> to return 1 UDT as an OUT parameter from a function. >>> >>> Somew

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-16 Thread rsmogura
If I may give some suggestion, I was tried to investigate this, and maybe some this will help When you create procedure with out parameters then return type of this is implicit calculated and may be record or base type (if exactly one out param is defined). In many places I saw comparison of re

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-16 Thread Oliver Jowett
On 17/02/11 01:10, Robert Haas wrote: > If you do SELECT function_with_one_out_parameter() rather than SELECT > * FROM function_with_one_out_parameter(), you'll get just one > argument. Does that help at all? Unfortunately, not really, because it doesn't work for cases where there's more than on

Re: [HACKERS] [PERFORM] pgbench to the MAXINT

2011-02-16 Thread Greg Smith
Tom Lane wrote: I think that might be a good idea --- it'd reduce the cross-platform variability of the results quite a bit, I suspect. random() is not to be trusted everywhere, but I think erand48 is pretty much the same wherever it exists at all (and src/port/ provides it elsewhere). Give

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-16 Thread Lukas Eder
That was my opinion, but you're saying that JDBC is not the cause either? 2011/2/16 Robert Haas > On Wed, Feb 16, 2011 at 7:07 AM, Lukas Eder wrote: > > So what should I do? File a bug to the main Postgres mailing list? Or > just > > not support that feature? > > Well, I thought you just said y

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-16 Thread Lukas Eder
Hmm, good point. I should try that. I have only tried these syntaxes: connection.prepareStatement("select * from p_enhance_address2()"); connection.prepareCall("{ call p_enhance_address2(?) }"); // with an output parameter registered ===

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-16 Thread Lukas Eder
So what should I do? File a bug to the main Postgres mailing list? Or just not support that feature? 2011/2/16 Oliver Jowett > On 17/02/11 00:58, Robert Haas wrote: > > On Wed, Feb 16, 2011 at 3:30 AM, Lukas Eder > wrote: > >> I'm not trying to fix the signature. I want exactly that signature.

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-16 Thread Florian Pflug
On Feb16, 2011, at 13:43 , Oliver Jowett wrote: > Anyway, it's a bit counterintuitive that > > SELECT * FROM f($1,$2) AS RESULT > > where f() takes two OUT parameters always returns two columns, but > > SELECT * FROM f($1) AS RESULT > > might return any number of columns! Is that really the c

Re: [HACKERS] new clang report

2011-02-16 Thread Bruce Momjian
Peter Eisentraut wrote: > The lastest clang svn tip (2.9-to-be, I guess) builds PostgreSQL out of > the box and most tests pass. Specifically, it no longer chokes on > -D_GNU_SOURCE on Linux, which was the previously reported blocker. > > Warnings: > > Lots of these: > clang: warning: argument u

Re: [HACKERS] Fix for Index Advisor related hooks

2011-02-16 Thread Gurjeet Singh
On Tue, Feb 15, 2011 at 11:59 AM, Tom Lane wrote: > Gurjeet Singh writes: > > Also attached is the patch expose_IndexSupportInitialize.patch, that > makes > > the static function IndexSupportInitialize() global so that the Index > > Advisor doesn't have to reinvent the wheel to prepare an index

Re: [HACKERS] Fix for Index Advisor related hooks

2011-02-16 Thread Gurjeet Singh
On Tue, Feb 15, 2011 at 12:51 PM, Tom Lane wrote: > Gurjeet Singh writes: > > On Tue, Feb 15, 2011 at 8:24 AM, Heikki Linnakangas < > > heikki.linnakan...@enterprisedb.com> wrote: > >> On 11.02.2011 22:44, Gurjeet Singh wrote: > >>> One one hand get_actual_variable_range() expects that virtual i

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-16 Thread Tom Lane
Florian Pflug writes: > Hm, I've browsed through the code and it seems that the current behaviour > was implemented on purpose. Yes, it's 100% intentional. The idea is to allow function authors to use OUT-parameter notation (in particular, the convention of assigning to a named variable to set

Re: [HACKERS] Fix for Index Advisor related hooks

2011-02-16 Thread Tom Lane
Gurjeet Singh writes: > I understand that we need to hide guts of an implementation. But without > this the Index Advisor will have to emulate what LookupOpclassInfo() does > and that's a lot of code that I am afraid, if emulated by another function > in Index Advisor, is more prone to obsolecence

Re: [HACKERS] Fix for Index Advisor related hooks

2011-02-16 Thread Tom Lane
Gurjeet Singh writes: > BTW, you use the term 'fictitious' in the comments, would it be better > to standardize the term used for such an index? So either the comment would > be changed to call it hypothetical, or the structure member would be changed > to isfictitious. Yeah, hypothetical is

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-16 Thread Robert Haas
On Tue, Feb 15, 2011 at 10:13 PM, Fujii Masao wrote: > On Wed, Feb 16, 2011 at 2:08 AM, Robert Haas wrote: >> On Mon, Feb 14, 2011 at 12:25 AM, Fujii Masao wrote: >>> On Fri, Feb 11, 2011 at 4:06 AM, Heikki Linnakangas >>> wrote: I added a XLogWalRcvSendReply() call into XLogWalRcvFlush()

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-16 Thread Simon Riggs
On Tue, 2011-02-15 at 12:08 -0500, Robert Haas wrote: > On Mon, Feb 14, 2011 at 12:25 AM, Fujii Masao wrote: > > On Fri, Feb 11, 2011 at 4:06 AM, Heikki Linnakangas > > wrote: > >> I added a XLogWalRcvSendReply() call into XLogWalRcvFlush() so that it also > >> sends a status update every time th

Re: [HACKERS] multiset patch review

2011-02-16 Thread Robert Haas
On Tue, Feb 15, 2011 at 7:13 AM, Robert Haas wrote: > On Tue, Feb 15, 2011 at 4:31 AM, Itagaki Takahiro > wrote: >> array_flatten() no longer exists. I added array_trim() as an alias >> to trim_array() because it would be a FAQ. > > I don't like the alias thing - let's add one name or the other,

Re: [HACKERS] [PERFORM] pgbench to the MAXINT

2011-02-16 Thread Tom Lane
Greg Smith writes: > Given that pgbench will run with threads in some multi-worker > configurations, after some more portability research I think odds are > good we'd get nailed by > http://sourceware.org/bugzilla/show_bug.cgi?id=10320 : "erand48 > implementation not thread safe but POSIX says

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-16 Thread Heikki Linnakangas
On 16.02.2011 17:36, Simon Riggs wrote: On Tue, 2011-02-15 at 12:08 -0500, Robert Haas wrote: On Mon, Feb 14, 2011 at 12:25 AM, Fujii Masao wrote: On Fri, Feb 11, 2011 at 4:06 AM, Heikki Linnakangas wrote: I added a XLogWalRcvSendReply() call into XLogWalRcvFlush() so that it also sends a s

[HACKERS] Determining period between 2 dates

2011-02-16 Thread Thom Brown
Hi all, I'm wondering what people think of introducing some kind of function to extract the number of units between 2 dates? At the moment there's no way to do this. Take the following example: Event 1 is '1985-10-26 01:22:00' Event 2 is now. How many minutes between these 2 events? What I do

Re: [HACKERS] Determining period between 2 dates

2011-02-16 Thread Robert Haas
On Wed, Feb 16, 2011 at 10:47 AM, Thom Brown wrote: > Hi all, > > I'm wondering what people think of introducing some kind of function > to extract the number of units between 2 dates?  At the moment there's > no way to do this.  Take the following example: > > Event 1 is '1985-10-26 01:22:00' > E

Re: [HACKERS] Determining period between 2 dates

2011-02-16 Thread Jan-Benedict Glaw
On Wed, 2011-02-16 10:52:13 -0500, Robert Haas wrote: > On Wed, Feb 16, 2011 at 10:47 AM, Thom Brown wrote: > > I'm wondering what people think of introducing some kind of function > > to extract the number of units between 2 dates?  At the moment there's > > no way to do this.  Take the followin

Re: [HACKERS] Determining period between 2 dates

2011-02-16 Thread Thom Brown
On 16 February 2011 15:57, Jan-Benedict Glaw wrote: > On Wed, 2011-02-16 10:52:13 -0500, Robert Haas wrote: >> On Wed, Feb 16, 2011 at 10:47 AM, Thom Brown wrote: >> > I'm wondering what people think of introducing some kind of function >> > to extract the number of units between 2 dates?  At th

Re: [HACKERS] CommitFest 2011-01 as of 2011-02-04

2011-02-16 Thread Simon Riggs
On Tue, 2011-02-15 at 06:49 +0200, Peter Eisentraut wrote: > On mån, 2011-02-14 at 11:49 -0500, Stephen Frost wrote: > > Perhaps a thought for next time would be to offset things a bit. eg: > > > > CF 2011-03 (or whatever): > > 2011-02-14: Patches should all be submitted > > 2011-02-14: Reviewers

Re: [HACKERS] contrib loose ends: 9.0 to 9.1 incompatibilities

2011-02-16 Thread Tom Lane
Robert Haas writes: > On Tue, Feb 15, 2011 at 7:10 PM, Tom Lane wrote: >> 2. We could add extra pg_proc.h entries matching the old signatures. >> For the moment these would be stub functions that call the same C code, >> though eventually perhaps they could be changed to throw errors. > +1. OK,

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-16 Thread Simon Riggs
On Wed, 2011-02-16 at 17:40 +0200, Heikki Linnakangas wrote: > On 16.02.2011 17:36, Simon Riggs wrote: > > On Tue, 2011-02-15 at 12:08 -0500, Robert Haas wrote: > >> On Mon, Feb 14, 2011 at 12:25 AM, Fujii Masao > >> wrote: > >>> On Fri, Feb 11, 2011 at 4:06 AM, Heikki Linnakangas > >>> wrote:

Re: [HACKERS] Determining period between 2 dates

2011-02-16 Thread Kevin Grittner
Thom Brown wrote: > For the number of fortnights, that becomes: > > select extract(epoch from now() - '2010-01-01 > 11:45:13'::timestamp)/60/60/24/14; > > You'd think with PostgreSQL having such a rich type system, it > wouldn't need to come to that. It's just asking for the number of > inte

Re: [HACKERS] Determining period between 2 dates

2011-02-16 Thread Marti Raudsepp
On Wed, Feb 16, 2011 at 18:03, Thom Brown wrote: > For the number of fortnights, that becomes: > > select extract(epoch from now() - '2010-01-01 > 11:45:13'::timestamp)/60/60/24/14; > > You'd think with PostgreSQL having such a rich type system, it > wouldn't need to come to that.  It's just aski

Re: [HACKERS] arrays as pl/perl input arguments [PATCH]

2011-02-16 Thread Tim Bunce
On Sat, Feb 12, 2011 at 02:17:12AM +0200, Alexey Klyukin wrote: > > So, here is the v8. Instead of rewriting the encode_array_literal I've added > another function, encode_type_literal (could use a better name). Given that encode_array_literal() encodes an _array_ as a literal, I'd assume encode_

Re: [HACKERS] contrib loose ends: 9.0 to 9.1 incompatibilities

2011-02-16 Thread Robert Haas
On Wed, Feb 16, 2011 at 11:29 AM, Tom Lane wrote: >> Hmm.  Can we just invent a way to hook them from the opclasses?  I >> have a feeling that now that this extension stuff is in we're going to >> discover a bunch of these little utility commands that we managed to >> get by without in the past bu

Re: [HACKERS] Debian readline/libedit breakage

2011-02-16 Thread Bruce Momjian
Tom Lane wrote: > Robert Haas writes: > > On Fri, Feb 11, 2011 at 3:10 PM, Tom Lane wrote: > >> We have code that exists in both psql and the backend (cf src/port/) > >> so I'm not sure this really will satisfy the more rabid GPL partisans. > >> And this whole discussion is about satisfying the m

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-16 Thread Robert Haas
On Wed, Feb 16, 2011 at 11:32 AM, Simon Riggs wrote: > On Wed, 2011-02-16 at 17:40 +0200, Heikki Linnakangas wrote: >> On 16.02.2011 17:36, Simon Riggs wrote: >> > On Tue, 2011-02-15 at 12:08 -0500, Robert Haas wrote: >> >> On Mon, Feb 14, 2011 at 12:25 AM, Fujii Masao   >> >> wrote: >> >>> On Fri

Re: [HACKERS] contrib loose ends: 9.0 to 9.1 incompatibilities

2011-02-16 Thread Robert Haas
On Wed, Feb 16, 2011 at 12:24 PM, Heikki Linnakangas wrote: > On 16.02.2011 19:17, Robert Haas wrote: >> >> The trouble is that we have no mechanism for conditional logic in >> upgrade scripts,... > > Can't you put a DO-block there? It's not pretty, but should work.. Tom has repeatedly objected t

Re: [HACKERS] contrib loose ends: 9.0 to 9.1 incompatibilities

2011-02-16 Thread Tom Lane
Robert Haas writes: > The trouble is that we have no mechanism for conditional logic in > upgrade scripts, so if the system catalog structure should change in a > way that causes the hook and unhook mechanism to require different > logic depending on which PG major version is in use, we're hosed.

Re: [HACKERS] contrib loose ends: 9.0 to 9.1 incompatibilities

2011-02-16 Thread Heikki Linnakangas
On 16.02.2011 19:17, Robert Haas wrote: The trouble is that we have no mechanism for conditional logic in upgrade scripts,... Can't you put a DO-block there? It's not pretty, but should work.. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers maili

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-16 Thread Heikki Linnakangas
On 16.02.2011 19:29, Robert Haas wrote: Actually, on further reflection, I'm not even sure why we bother with the fsync. It seems like a useful safeguard but I'm not seeing how we can get to that point without having fsync'd everything anyway. Am I missing something? WalRcvDie() is called on

Re: [HACKERS] Debian readline/libedit breakage

2011-02-16 Thread Andrew Dunstan
On 02/16/2011 12:29 PM, Bruce Momjian wrote: Tom Lane wrote: Robert Haas writes: On Fri, Feb 11, 2011 at 3:10 PM, Tom Lane wrote: We have code that exists in both psql and the backend (cf src/port/) so I'm not sure this really will satisfy the more rabid GPL partisans. And this whole discu

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-16 Thread Robert Haas
On Wed, Feb 16, 2011 at 12:34 PM, Heikki Linnakangas wrote: > On 16.02.2011 19:29, Robert Haas wrote: >> >> Actually, on further reflection, I'm not even sure why we bother with >> the fsync.  It seems like a useful safeguard but I'm not seeing how we >> can get to that point without having fsync'

Re: [HACKERS] contrib loose ends: 9.0 to 9.1 incompatibilities

2011-02-16 Thread Robert Haas
On Wed, Feb 16, 2011 at 12:31 PM, Tom Lane wrote: > Robert Haas writes: >> The trouble is that we have no mechanism for conditional logic in >> upgrade scripts, so if the system catalog structure should change in a >> way that causes the hook and unhook mechanism to require different >> logic dep

Re: [HACKERS] contrib loose ends: 9.0 to 9.1 incompatibilities

2011-02-16 Thread Tom Lane
Robert Haas writes: > Well, it sounds like we're in agreement at least about 9.1, so we can > leave the rest of the argument to another day. I *am* surprised that > you think it would take *thousands* of lines of code. Well, it all depends on how much ALTER stuff you want to add. An open-ended

Re: [HACKERS] Debian readline/libedit breakage

2011-02-16 Thread Joshua D. Drake
On Wed, 2011-02-16 at 12:29 -0500, Bruce Momjian wrote: > Tom Lane wrote: > Can someone take ownership of this, get involved with the libedit folks, > get Debian to use their fixes, and solve this problem for us? That is a lot easier said that done. To be frank, I thought it was something that I

Re: [HACKERS] Fix for Index Advisor related hooks

2011-02-16 Thread Gurjeet Singh
On Wed, Feb 16, 2011 at 10:25 AM, Tom Lane wrote: > Gurjeet Singh writes: > > I understand that we need to hide guts of an implementation. But without > > this the Index Advisor will have to emulate what LookupOpclassInfo() does > > and that's a lot of code that I am afraid, if emulated by anoth

Re: [HACKERS] arrays as pl/perl input arguments [PATCH]

2011-02-16 Thread Alvaro Herrera
Excerpts from Tim Bunce's message of mié feb 16 14:08:11 -0300 2011: > On Sat, Feb 12, 2011 at 02:17:12AM +0200, Alexey Klyukin wrote: > > > > So, here is the v8. Instead of rewriting the encode_array_literal I've added > > another function, encode_type_literal (could use a better name). > Given

Re: [HACKERS] Spontaneous PITR standby activiation

2011-02-16 Thread Thom Brown
On 26 November 2009 07:26, Heikki Linnakangas wrote: > David Christensen wrote: >> 1) is there a hard limit of the number of times the archive_command will >> attempt?  I didn't see anything documented about this in the PITR or >> config docs, so I'm guessing the 10 failures I saw in the log were

Re: [HACKERS] Extensions vs PGXS' MODULE_PATHNAME handling

2011-02-16 Thread Dimitri Fontaine
Tom Lane writes: > [ scratches head ... ] Why is your version generating so many > unnecessary @extschema@ uses? I just ran create table tomlist as select your query and create table dimlist as select my query, then: dim=# select * from tomlist except select * from dimlist;

[HACKERS] Re: [COMMITTERS] pgsql: Cleanup ClusterInfo initialization in pg_upgrade

2011-02-16 Thread Bruce Momjian
Alvaro Herrera wrote: > Cleanup ClusterInfo initialization in pg_upgrade Global structs are already initialized to zero, so no need to initialize them. I discussed this with Alvaro, and he suggested that there is no need to free memory before we exit. The attached, applied patch makes both chang

Re: [HACKERS] Fix corner case for binary upgrade: extension functions in pg_catalog.

2011-02-16 Thread Dimitri Fontaine
Tom Lane writes: > Fix corner case for binary upgrade: extension functions in pg_catalog. Do we only want to care about functions here? What about the following? CREATE EXTENSION hstore WITH SCHEMA pg_catalog; When not doing binary upgrade, this will issue the right pg_dump command, but it s

Re: [HACKERS] Debian readline/libedit breakage

2011-02-16 Thread Peter Eisentraut
On mån, 2011-02-14 at 15:01 +0200, Devrim GÜNDÜZ wrote: > On Mon, 2011-02-14 at 13:52 +0100, Cédric Villemain wrote: > > "Consider providing debian packages at debian.postgresql.org" > > apt.postgresql.org, please. :) APT is not necessarily tied to Debian, nor is a Debian package repository neces

Re: [HACKERS] contrib loose ends: 9.0 to 9.1 incompatibilities

2011-02-16 Thread Dimitri Fontaine
Tom Lane writes: > Well, actually, we *do* have such a mechanism (plpgsql), we just don't > want to use it unless we have to. I wouldn't feel too bad about saying > "upgrading tsearch2 directly from 9.0 to 9.4 requires that you have > plpgsql installed when you issue the CREATE EXTENSION command"

Re: [HACKERS] Usability tweaks for extension commands

2011-02-16 Thread Dimitri Fontaine
Tom Lane writes: > ERROR: version to install or update to must be different from old version > > On reflection it seems like this is overly paranoid, and it'd be more > useful if the ALTER just reported a NOTICE along the lines of "version > so-and-so is already installed". Any objections? I se

Re: [HACKERS] using a lot of maintenance_work_mem

2011-02-16 Thread Peter Eisentraut
On mån, 2011-02-14 at 10:11 -0500, Tom Lane wrote: > But before expending time on that, I'd want to see some evidence that > it's actually helpful for production situations. I'm a bit dubious > that you're going to gain much here. If you want to build an index on a 500GB table and you have 1TB RA

Re: [HACKERS] Add support for logging the current role

2011-02-16 Thread Robert Haas
On Tue, Feb 15, 2011 at 1:02 PM, Stephen Frost wrote: > * Andrew Dunstan (and...@dunslane.net) wrote: >> On 02/15/2011 11:13 AM, Stephen Frost wrote: >> >Think I suggested that at one point.  I'm all for doing that on a major >> >version change like this one, but I think we already had some concer

Re: [HACKERS] btree_gist (was: CommitFest progress - or lack thereof)

2011-02-16 Thread Robert Haas
On Sat, Feb 12, 2011 at 8:19 AM, Robert Haas wrote: > On Sat, Feb 12, 2011 at 7:47 AM, Stephen Frost wrote: >> Oleg, >> >> * Oleg Bartunov (o...@sai.msu.su) wrote: >>> what do you need for documentation ? From users point of view we add just >>> knn support and all examples are available in btree

Re: [HACKERS] contrib loose ends: 9.0 to 9.1 incompatibilities

2011-02-16 Thread Tom Lane
Dimitri Fontaine writes: > Tom Lane writes: >> Well, actually, we *do* have such a mechanism (plpgsql), we just don't >> want to use it unless we have to. I wouldn't feel too bad about saying >> "upgrading tsearch2 directly from 9.0 to 9.4 requires that you have >> plpgsql installed when you iss

Re: [HACKERS] pika failing since the per-column collation patch

2011-02-16 Thread Rémi Zara
Le 14 févr. 2011 à 19:27, Rémi Zara a écrit : > > Le 12 févr. 2011 à 18:51, Peter Eisentraut a écrit : > >> >> It's only failing on this one machine, but there isn't anything >> platform-specific in this code, so I'd look for memory management faults >> on the code or a compiler problem. Try

Re: [HACKERS] contrib loose ends: 9.0 to 9.1 incompatibilities

2011-02-16 Thread David E. Wheeler
On Feb 16, 2011, at 1:20 PM, Dimitri Fontaine wrote: > We will then need "build"-time requires (build-depends would say debian) > so that the system knows what's needed to run the install or upgrade > scripts. I've been thinking that's for 9.2, but maybe that would be a > simpler fix for you here

Re: [HACKERS] tsearch Parser Hacking

2011-02-16 Thread David E. Wheeler
On Feb 14, 2011, at 11:44 PM, Oleg Bartunov wrote: >> IMO, sooner or later we need to trash that code and replace it with >> something a bit more modification-friendly. > > We thought about configurable parser, but AFAIR, we didn't get any support > for this at that time. What would it take to

Re: [HACKERS] arrays as pl/perl input arguments [PATCH]

2011-02-16 Thread Alvaro Herrera
I cleaned up the patch a bit -- result is v11, attached. I'll give it another look tomorrow and hopefully commit it. -- Álvaro Herrera The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Development, 24x7 support pg_to_perl_arrays_v11.patch.gz Description

Re: [HACKERS] Add support for logging the current role

2011-02-16 Thread Andrew Dunstan
On 02/16/2011 04:24 PM, Robert Haas wrote: On Tue, Feb 15, 2011 at 1:02 PM, Stephen Frost wrote: * Andrew Dunstan (and...@dunslane.net) wrote: On 02/15/2011 11:13 AM, Stephen Frost wrote: Think I suggested that at one point. I'm all for doing that on a major version change like this one, b

Re: [HACKERS] arrays as pl/perl input arguments [PATCH]

2011-02-16 Thread Andrew Dunstan
On 02/16/2011 05:54 PM, Alvaro Herrera wrote: I cleaned up the patch a bit -- result is v11, attached. I'll give it another look tomorrow and hopefully commit it. Thanks for picking this up. cheers andrew -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make chan

Re: [HACKERS] Usability tweaks for extension commands

2011-02-16 Thread Tom Lane
Dimitri Fontaine writes: > Tom Lane writes: >> Another thought is that it'd probably be useful for there to be a >> "CREATE OR REPLACE EXTENSION" syntax, with the behavior of "install the >> extension if it's not present, else make sure it's of the specified or >> default version"; this behavior

Re: [HACKERS] Fix for Index Advisor related hooks

2011-02-16 Thread Gurjeet Singh
On Wed, Feb 16, 2011 at 10:26 AM, Tom Lane wrote: > Gurjeet Singh writes: > > BTW, you use the term 'fictitious' in the comments, would it be > better > > to standardize the term used for such an index? So either the comment > would > > be changed to call it hypothetical, or the structure me

Re: [HACKERS] Extensions vs PGXS' MODULE_PATHNAME handling

2011-02-16 Thread Tom Lane
Dimitri Fontaine writes: > Tom Lane writes: >> [ scratches head ... ] Why is your version generating so many >> unnecessary @extschema@ uses? > I just ran create table tomlist as select your query and create table > dimlist as select my query, then: > ... > No difference on @extschema@ use here

Re: [HACKERS] Fix corner case for binary upgrade: extension functions in pg_catalog.

2011-02-16 Thread Tom Lane
Dimitri Fontaine writes: > Tom Lane writes: >> Fix corner case for binary upgrade: extension functions in pg_catalog. > Do we only want to care about functions here? Yes. Functions/aggregates are the only object type where pg_dump tries to suppress fetching any information at all about system-

Re: [HACKERS] SSI bug?

2011-02-16 Thread Kevin Grittner
YAMAMOTO Takashi wrote: > might be unrelated to the loop problem, but... > > i got the following SEGV when runnning vacuum on a table. > vacuum on the table succeeded with the attached patch. Thanks! I appreciate the heavy testing and excellent diagnostics. On the face of it, this doesn't

Re: [HACKERS] Usability tweaks for extension commands

2011-02-16 Thread David E. Wheeler
On Feb 16, 2011, at 3:00 PM, Tom Lane wrote: > According to our prior discussions of C.O.R. commands, the general > principle that such a command ought to follow is that upon success, > the object exists with exactly the properties implied by the command's > arguments. So (1) if the extension isn

Re: [HACKERS] Determining period between 2 dates

2011-02-16 Thread Steve Crawford
On 02/16/2011 09:07 AM, Marti Raudsepp wrote: On Wed, Feb 16, 2011 at 18:03, Thom Brown wrote: For the number of fortnights, that becomes: select extract(epoch from now() - '2010-01-01 11:45:13'::timestamp)/60/60/24/14; You'd think with PostgreSQL having such a rich type system, it wouldn't n

Re: [HACKERS] Debian readline/libedit breakage

2011-02-16 Thread Tom Lane
Andrew Dunstan writes: > On 02/16/2011 12:29 PM, Bruce Momjian wrote: >> Can someone take ownership of this, get involved with the libedit folks, >> get Debian to use their fixes, and solve this problem for us? > You're assuming a fact not in evidence, namely the existence of an > identifiable g

Re: [HACKERS] Fix for Index Advisor related hooks

2011-02-16 Thread Tom Lane
Gurjeet Singh writes: > On Wed, Feb 16, 2011 at 10:25 AM, Tom Lane wrote: >> The only reason you'd need that code is if you were trying to construct >> a fake Relation structure, which seems unnecessary and undesirable. > The planner requires IndexOptInfo, and for the planner to choose the > hyp

Re: [HACKERS] Debian readline/libedit breakage

2011-02-16 Thread Greg Smith
Andrew Dunstan wrote: You're assuming a fact not in evidence, namely the existence of an identifiable group of "libedit folks". Last time I looked there was no such group. There appear to be two people working periodically on the upstream NetBSD libedit: http://cvsweb.netbsd.org/bsdweb.cgi/

Re: [HACKERS] Add support for logging the current role

2011-02-16 Thread Robert Haas
On Wed, Feb 16, 2011 at 5:55 PM, Andrew Dunstan wrote: > On 02/16/2011 04:24 PM, Robert Haas wrote: >> >> On Tue, Feb 15, 2011 at 1:02 PM, Stephen Frost  wrote: >>> >>> * Andrew Dunstan (and...@dunslane.net) wrote: On 02/15/2011 11:13 AM, Stephen Frost wrote: > > Think I suggeste

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-16 Thread Oliver Jowett
On 17/02/11 04:23, Tom Lane wrote: > Florian Pflug writes: >> Hm, I've browsed through the code and it seems that the current behaviour >> was implemented on purpose. > > Yes, it's 100% intentional. The idea is to allow function authors to > use OUT-parameter notation (in particular, the conven

Re: [HACKERS] Fix for Index Advisor related hooks

2011-02-16 Thread Tom Lane
Gurjeet Singh writes: > On Wed, Feb 16, 2011 at 10:26 AM, Tom Lane wrote: >> Yeah, hypothetical is the more-established term I think. > Please find the patch attached. Applied with minor adjustments to HEAD and 9.0. regards, tom lane -- Sent via pgsql-hackers mailing

Re: [HACKERS] Debian readline/libedit breakage

2011-02-16 Thread Greg Stark
On Thu, Feb 17, 2011 at 12:07 AM, Greg Smith wrote: > There appear to be two people working periodically on the upstream NetBSD > libedit: http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libedit/?sortby=date > > And a third who periodically packages that at http://www.thrysoee.dk/editline/ I'm rea

Re: [HACKERS] Debian readline/libedit breakage

2011-02-16 Thread Joshua D. Drake
On Thu, 2011-02-17 at 00:28 +, Greg Stark wrote: > On Thu, Feb 17, 2011 at 12:07 AM, Greg Smith wrote: > > > There appear to be two people working periodically on the upstream NetBSD > > libedit: http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libedit/?sortby=date > > > > And a third who period

Re: [HACKERS] Debian readline/libedit breakage

2011-02-16 Thread Tom Lane
Greg Smith writes: > I find it hard to get excited about working to replace the software that > has a reasonable license here (readline) rather than trying to eliminate > dependence on the one with an unreasonable license (OpenSSL). Hm? The trouble with readline is that it's GPL, not LGPL, and

Re: [HACKERS] Add support for logging the current role

2011-02-16 Thread Tom Lane
Robert Haas writes: >>> On Tue, Feb 15, 2011 at 1:02 PM, Stephen Frost  wrote: I believe the suggestion that Robert and I were talking about above was to just unilatterally change the CSV log file output format to include current_role.  No header lines, no variable output format, et

Re: [HACKERS] Fix for Index Advisor related hooks

2011-02-16 Thread Thom Brown
On 16 February 2011 23:02, Gurjeet Singh wrote: > On Wed, Feb 16, 2011 at 10:26 AM, Tom Lane wrote: >> >> Gurjeet Singh writes: >> >     BTW, you use the term 'fictitious' in the comments, would it be >> > better >> > to standardize the term used for such an index? So either the comment >> > wou

Re: [HACKERS] Fix for Index Advisor related hooks

2011-02-16 Thread Tom Lane
Thom Brown writes: > For my benefit, could you explain how ishypothetical gets set to true? In the core, it never does. An index advisor plugin would set it in IndexOptInfo structs that it makes. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@p

Re: [HACKERS] Fix for Index Advisor related hooks

2011-02-16 Thread Thom Brown
On 17 February 2011 00:48, Tom Lane wrote: > Thom Brown writes: >> For my benefit, could you explain how ishypothetical gets set to true? > > In the core, it never does.  An index advisor plugin would set it in > IndexOptInfo structs that it makes. I get the idea. Thanks Tom. -- Thom Brown Tw

Re: [HACKERS] Debian readline/libedit breakage

2011-02-16 Thread Tom Lane
Greg Stark writes: > On Thu, Feb 17, 2011 at 12:07 AM, Greg Smith wrote: >> There appear to be two people working periodically on the upstream NetBSD >> libedit: http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libedit/?sortby=date >> >> And a third who periodically packages that at >> http://www.

Re: [HACKERS] Debian readline/libedit breakage

2011-02-16 Thread Marko Kreen
On Thu, Feb 17, 2011 at 2:39 AM, Tom Lane wrote: > Greg Smith writes: >> I find it hard to get excited about working to replace the software that >> has a reasonable license here (readline) rather than trying to eliminate >> dependence on the one with an unreasonable license (OpenSSL). > > Hm? >

Re: [HACKERS] Fix for Index Advisor related hooks

2011-02-16 Thread Gurjeet Singh
On Wed, Feb 16, 2011 at 7:25 PM, Tom Lane wrote: > Gurjeet Singh writes: > > On Wed, Feb 16, 2011 at 10:26 AM, Tom Lane wrote: > >> Yeah, hypothetical is the more-established term I think. > > > Please find the patch attached. > > Applied with minor adjustments to HEAD and 9.0. > Thanks Tom. -

Re: [HACKERS] Debian readline/libedit breakage

2011-02-16 Thread Greg Stark
On Thu, Feb 17, 2011 at 12:39 AM, Tom Lane wrote: > In particular, getting rid of use of OpenSSL would not be sufficient > to satisfy the most rabid GPL partisans that we were in compliance. Huh? In what way would we not be in compliance? Or rather, what part of the GPL would we be unable to com

Re: [HACKERS] Add support for logging the current role

2011-02-16 Thread Robert Haas
On Wed, Feb 16, 2011 at 7:42 PM, Tom Lane wrote: > Robert Haas writes: On Tue, Feb 15, 2011 at 1:02 PM, Stephen Frost  wrote: > I believe the suggestion that Robert and I were talking about above was > to just unilatterally change the CSV log file output format to include > curre

Re: [HACKERS] Add support for logging the current role

2011-02-16 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > I can't remember at the moment: have we changed the CSV format in any > releases since it was first created? And if so, did anyone complain? It was changed between 8.4 and 9.0 (application_name was added). I've looked around a bit in the archives w/ googl

Re: [HACKERS] Add support for logging the current role

2011-02-16 Thread Andrew Dunstan
On 02/16/2011 08:38 PM, Stephen Frost wrote: * Tom Lane (t...@sss.pgh.pa.us) wrote: I can't remember at the moment: have we changed the CSV format in any releases since it was first created? And if so, did anyone complain? It was changed between 8.4 and 9.0 (application_name was added). I'v

Re: [HACKERS] Debian readline/libedit breakage

2011-02-16 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > In particular, getting rid of use of OpenSSL would not be sufficient > to satisfy the most rabid GPL partisans that we were in compliance. I've never heard anyone argue that position, don't believe anyone would, and certainly don't agree with it. > Whereas

Re: [HACKERS] Add support for logging the current role

2011-02-16 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: > CSV log files were introduced in 8.3.0 by commit > fd801f4faa8e0f00bc314b16549e3d8e8aa1b653. There are several follow-on > commits making adjustments, but they all appear to be 8.3-vintage: > > 230e8962f3a47cae4729ad7c017410d28caf1370 > 3bf66d6f1c3a8

Re: [HACKERS] log_hostname and pg_stat_activity

2011-02-16 Thread Robert Haas
On Thu, Feb 10, 2011 at 10:40 AM, Steve Singer wrote: > On 11-02-10 10:32 AM, Robert Haas wrote: >> I was assuming those changes were sufficiently trivial that they could >> be made at commit-time, especially if Peter is committing it himself. >> Of course if he'd like a re-review, he can always p

Re: [HACKERS] Debian readline/libedit breakage

2011-02-16 Thread Joshua D. Drake
On Wed, 2011-02-16 at 20:53 -0500, Stephen Frost wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: > > In particular, getting rid of use of OpenSSL would not be sufficient > > to satisfy the most rabid GPL partisans that we were in compliance. > > I've never heard anyone argue that position, don't b

  1   2   >