Re: [HACKERS] Notes on implementing URI syntax for libpq

2011-12-09 Thread Alexander Shulgin
Excerpts from Daniel Farina's message of Mon Dec 05 11:56:19 +0200 2011: > > I think the current direction is fine, although as Robert Haas has > said, I am not really at all inclined to view JDBC compatibility as > any kind of a plus. JDBC URLs are weird, and do the drivers actually > link libp

Re: [HACKERS] review: CHECK FUNCTION statement

2011-12-09 Thread Albe Laurenz
Pavel Stehule wrote: > updated version > > changes: > > * CHECK FUNCTION ALL; is enabled - in this case functions from > pg_catalog schema are ignored > > I looked on parser, and I didn't other changes there - IN SCHEMA, FOR > ROLE are used more time there, so our usage will be consistent > a smal

Re: [HACKERS] WIP: Collecting statistics on CSV file data

2011-12-09 Thread Etsuro Fujita
Hi Hanada-san, I updated the patch. Please find attached a patch. Best regards, Etsuro Fujita > (2011/11/18 21:00), Shigeru Hanada wrote: >> (2011/11/18 16:25), Etsuro Fujita wrote: >>> Thank you for your testing. I updated the patch according to your >>> comments. Attached is the updated ver

Re: [HACKERS] Bug in walsender when calling out to do_pg_stop_backup (and others?)

2011-12-09 Thread Heikki Linnakangas
On 03.12.2011 18:37, Heikki Linnakangas wrote: One small change I'd like to make is to treat the loss of connection more as a new "top-level" event, rather than as a new reason for query cancellation. A lost connection is more like receiving SIGTERM, really. Please take a look at the attached pat

Re: [HACKERS] [v9.2] Fix Leaky View Problem

2011-12-09 Thread Robert Haas
On Thu, Dec 8, 2011 at 5:17 PM, Kohei KaiGai wrote: > My first impression remind me an idea that I proposed before, even > though it got negative response due to user visible changes. > It requires superuser privilege to create new operators, since we > assume superuser does not set up harmful con

Re: [HACKERS] Notes on implementing URI syntax for libpq

2011-12-09 Thread Robert Haas
On Fri, Dec 9, 2011 at 6:03 AM, Alexander Shulgin wrote: > See above.  The hope is that URIs will be compatible sans the driver-specific > extra query parameters which might be not recognized by either party. Yeah. I am not that concerned with being stupidity-compatible with anyone else ... bu

Re: [HACKERS] review: CHECK FUNCTION statement

2011-12-09 Thread Albe Laurenz
Pavel Stehule wrote: > there is fixed version Here is my attempt at a doc patch. Could you add it to your patch so that all is in a single patch? Yours, Laurenz Albe check_function_docs.patch Description: check_function_docs.patch -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgre

Re: [HACKERS] WIP: SP-GiST, Space-Partitioned GiST

2011-12-09 Thread Tom Lane
Teodor Sigaev writes: > [ spgist patch ] I've been working through this patch and fixing assorted things. There are a couple of issues that require some discussion: 1. It took me awhile to realize it, but there are actually three different datatypes that can be stored in an SPGist index: the pre

[HACKERS] static or dynamic libpgport

2011-12-09 Thread Andrew Dunstan
Recently I attempted to build an external package (pg_bulkload) against the latest Fedora packages. Unfortunately this fails, as pgxs adds "-lpgport" to any link line for an executable, and the corresponding libpgport.a isn't there. And in fact, pg_bulkload does use some of the functionality th

Re: [HACKERS] static or dynamic libpgport

2011-12-09 Thread Peter Geoghegan
On 9 December 2011 16:13, Andrew Dunstan wrote: > Is there any good reason why we shouldn't build and install a dynamic > libpgport.so? +1 in favour of building and installing a dynamic libpgport.so. I generally agree with your analysis. I've seen this issue crop up a good few times now. I'm a F

Re: [HACKERS] review: CHECK FUNCTION statement

2011-12-09 Thread Pavel Stehule
Hello 2011/12/9 Albe Laurenz : > Pavel Stehule wrote: >> there is fixed version > > Here is my attempt at a doc patch. > > Could you add it to your patch so that all is in a single patch? > there is merged patch Thank you Regards Pavel > Yours, > Laurenz Albe check_function-2011-12-09-3.dif

Re: [HACKERS] static or dynamic libpgport

2011-12-09 Thread Steve Singer
On 11-12-09 11:13 AM, Andrew Dunstan wrote: Recently I attempted to build an external package (pg_bulkload) against the latest Fedora packages. Unfortunately this fails, as pgxs adds "-lpgport" to any link line for an executable, and the corresponding libpgport.a isn't there. And in fact, pg_bu

Re: [HACKERS] static or dynamic libpgport

2011-12-09 Thread Andrew Dunstan
On 12/09/2011 01:01 PM, Steve Singer wrote: On 11-12-09 11:13 AM, Andrew Dunstan wrote: Recently I attempted to build an external package (pg_bulkload) against the latest Fedora packages. Unfortunately this fails, as pgxs adds "-lpgport" to any link line for an executable, and the correspond

Re: [HACKERS] psql line number reporting from stdin

2011-12-09 Thread Peter Eisentraut
On lör, 2011-11-26 at 22:36 +0200, Peter Eisentraut wrote: > There is a long-standing oddity in psql that running > > psql -f foo.sql > > returns error messages with file name and line number, like > > psql:foo.sql:1: ERROR: syntax error at or near "foo" > > but running > > psql < foo.sql doe

Re: [HACKERS] Core Extensions relocation

2011-12-09 Thread Josh Berkus
All, This is currently awaiting a check by gsmith that the 7 named extensions do not add any new dependancies. -- Josh Berkus PostgreSQL Experts Inc. http://pgexperts.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.post

Re: [HACKERS] psql line number reporting from stdin

2011-12-09 Thread Tom Lane
Peter Eisentraut writes: > The problem is, this breaks the regression tests, because first the > actual output changes, and second the line numbers get included, which > will create a mess every time you edit a test. Not sure whether we can > work around that. Ideas? Ugh, that's pretty nearly a

Re: [HACKERS] [PATCH] pg_test_fsync: Delete temporary file when aborted by a signal

2011-12-09 Thread Robert Haas
On Wed, Dec 7, 2011 at 1:40 PM, Marti Raudsepp wrote: > Hi list, > > I found a 'pg_test_fsync.out' file in my $PGDATA, which was probably > left around because I aborted pg_test_fsync with ^C back when setting > up the server. > > Here's a patch to delete that file via a signal handler for > SIGIN

Re: [HACKERS] [PATCH] PostgreSQL fails to build with 32bit MinGW-w64

2011-12-09 Thread Robert Haas
On Thu, Dec 8, 2011 at 12:46 PM, Andrew Dunstan wrote: > This is apparently an optimization bug in the compiler. If I turn > optimization off (CFLAGS=-O0) it goes away. Ick. > > So at the moment I'm a bit blocked. I can't really file a bug because the > compiler can't currently be used to build po

Re: [HACKERS] [PATCH] PostgreSQL fails to build with 32bit MinGW-w64

2011-12-09 Thread Andrew Dunstan
On 12/09/2011 03:11 PM, Robert Haas wrote: On Thu, Dec 8, 2011 at 12:46 PM, Andrew Dunstan wrote: This is apparently an optimization bug in the compiler. If I turn optimization off (CFLAGS=-O0) it goes away. Ick. So at the moment I'm a bit blocked. I can't really file a bug because the compi

Re: [HACKERS] RangeVarGetRelid()

2011-12-09 Thread Robert Haas
On Wed, Dec 7, 2011 at 8:42 AM, Noah Misch wrote: > It narrows the window for race conditions of that genesis, but isn't doing so > an anti-feature?  Even if not, doing that _only_ in RemoveRelations() is odd. I dunno. I was just reluctant to change things without a clear reason for doing so, an

Re: [HACKERS] Review of VS 2010 support patches

2011-12-09 Thread Andrew Dunstan
On 12/04/2011 12:44 PM, Andrew Dunstan wrote: On 11/29/2011 04:32 PM, Brar Piening wrote: Andrew Dunstan wrote: Some minor nitpicks: Do we really need to create all those VSProject.pm and VSSolution.pm files? They are all always included anyway. Why not just stash all the packag

Re: [HACKERS] Notes on implementing URI syntax for libpq

2011-12-09 Thread Daniel Farina
On Fri, Dec 9, 2011 at 3:03 AM, Alexander Shulgin wrote: > The JDBC driver is special in that it intentionally does not use libpq.   > Given every other binding (think Ruby, Python, Perl, Tcl, etc.) does use > libpq, it makes perfect sense to me to make the syntax compatible with JDBC. I am wit

Re: [HACKERS] Notes on implementing URI syntax for libpq

2011-12-09 Thread Alexander Shulgin
Excerpts from Daniel Farina's message of Fri Dec 09 23:04:26 +0200 2011: > > I guess if I move the parenthetical grouping of logic around, what you > are probably intending to say is "everyone except this one ecosystem > does the normal thing, so we have an opportunity to Unite The Clans, > by ab

Re: [HACKERS] RangeVarGetRelid()

2011-12-09 Thread Noah Misch
On Fri, Dec 09, 2011 at 03:43:19PM -0500, Robert Haas wrote: > On Wed, Dec 7, 2011 at 8:42 AM, Noah Misch wrote: > > It narrows the window for race conditions of that genesis, but isn't doing > > so > > an anti-feature? ?Even if not, doing that _only_ in RemoveRelations() is > > odd. > > I dunn

Re: [HACKERS] static or dynamic libpgport

2011-12-09 Thread Bruce Momjian
Andrew Dunstan wrote: > >> Is there any good reason why we shouldn't build and install a dynamic > >> libpgport.so? > > > > +1 > > > > We've struggled with slony and pgport because so many users have had > > problems with pgport not being included in some distributions. It has > > some useful f

Re: [HACKERS] Timing overhead and Linux clock sources

2011-12-09 Thread Ants Aasma
On Wed, Dec 7, 2011 at 9:40 AM, Greg Smith wrote: >  He estimated 22ns per gettimeofday on the system with fast timing > calls--presumably using TSC, and possibly faster than I saw because his > system had less cores than mine to worry about.  He got 990 ns on his slower > system, and a worst case

Re: [HACKERS] Timing overhead and Linux clock sources

2011-12-09 Thread Greg Smith
On 12/09/2011 06:48 PM, Ants Aasma wrote: The attached test program (test_gettimeofday_monotonic) shows that one test loop iteration takes 34ns with tsc and 1270ns with hpet. This test program is great, I've wanted this exact sort of visibility into this problem for years. I've toyed with

[HACKERS] Why do regression tests now leave "regress_test_role_super" around?

2011-12-09 Thread Tom Lane
As of commit fc6d1006bda783cc002c61a5f072905849dbde4b, the regression tests leave an unused role sitting around, because that commit removed DROP ROLE regress_test_role_super; from foreign_data.sql. Was that intentional? If so, why? regards, tom lane -- Sent via

Re: [HACKERS] pgsql_fdw, FDW for PostgreSQL server

2011-12-09 Thread Greg Smith
On 12/07/2011 02:34 AM, Shigeru Hanada wrote: I think that only the owner of foreign table can keep collation consistent between foreign and local, like data type of column. We need to support per-column-collation on foreign tables too, or should deny pushing down condition which is collation-se