Re: [HACKERS] Bugs in planner's equivalence-class processing

2012-10-18 Thread Simon Riggs
On 16 October 2012 16:56, Tom Lane t...@sss.pgh.pa.us wrote: Is anybody concerned about the compatibility implications of fixing this bug in the back branches? I'm worried about people complaining that we broke their application in a minor release. Maybe they were depending on incorrect

Re: [HACKERS] Global Sequences

2012-10-18 Thread Simon Riggs
On 17 October 2012 11:21, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Simon Riggs si...@2ndquadrant.com writes: On 16 October 2012 15:15, Tom Lane t...@sss.pgh.pa.us wrote: What you really want is something vaguely like nextval but applied to a distinct type of object. That is, I think we

Re: [HACKERS] Global Sequences

2012-10-18 Thread Simon Riggs
On 17 October 2012 10:19, Markus Wanner mar...@bluegap.ch wrote: On 10/17/2012 10:34 AM, Simon Riggs wrote: IMHO an API is required for give me the next allocation of numbers, essentially a bulk equivalent of nextval(). Agreed. That pretty exactly matches what I described (and what's

Re: [HACKERS] Global Sequences

2012-10-18 Thread Simon Riggs
On 16 October 2012 18:29, Tom Lane t...@sss.pgh.pa.us wrote: Or maybe better, invent a level of indirection like a sequence access method (comparable to index access methods) that provides a compatible set of substitute functions for sequence operations. If you want to override nextval() for

Re: [HACKERS] [RFC] CREATE QUEUE (log-only table) for londiste/pgQ ccompatibility

2012-10-18 Thread Simon Riggs
On 17 October 2012 21:25, Josh Berkus j...@agliodbs.com wrote: It is not meant to be a full implementation of application level queuing system though but just the capture, persisting and distribution parts Using this as an application level queue needs a set of interface functions to extract

[HACKERS] Database object names and libpq in UTF-8 locale on Windows

2012-10-18 Thread Sebastien FLAESCH
Hello, Using PostgreSQL 9.2.1 on Windows, I am facing a strange character set issue with a UTF-8 database. Maybe this is expected, but want to be sure that I am not missing something. On Windows, I have created a database with: ENCODING = 'UTF-8' LC_COLLATE = 'English_United States.1252'

Re: [HACKERS] [RFC] CREATE QUEUE (log-only table) for londiste/pgQ ccompatibility

2012-10-18 Thread Simon Riggs
On 17 October 2012 11:26, Hannu Krosing ha...@2ndquadrant.com wrote: LOGGED ONLY TABLE is very technical description of realisation - I'd prefer it to work as mush like a table as possible, similar to how VIEW currently works - for all usages that make sense, you can simply substitute it for

[HACKERS] Database object names and libpq in UTF-8 locale on Windows

2012-10-18 Thread Sebastien FLAESCH
Hello, Using PostgreSQL 9.2.1 on Windows, I am facing a strange character set issue with a UTF-8 database. Maybe this is expected, but want to be sure that I am not missing something. On Windows, I have created a database with: ENCODING = 'UTF-8' LC_COLLATE = 'English_United States.1252'

[HACKERS] [BUG] False indication in pg_stat_replication.sync_state

2012-10-18 Thread Kyotaro HORIGUCHI
Hello. My colleague found that pg_stat_replication.sync_state shows false state for some condition. This prevents Pacemaker from completing fail-over that could safely be done. The point is in walsender.c, pg_stat_get_wal_senders() below, (as of REL9_2_1) 1555:if (walsnd-pid != 0) 1556:

Re: [HACKERS] Bugs in CREATE/DROP INDEX CONCURRENTLY

2012-10-18 Thread Andres Freund
On Thursday, October 18, 2012 06:12:02 AM Kevin Grittner wrote: Kevin Grittner wrote: Hmm. The comment is probably better now, but I've been re-checking the code, and I think my actual code change is completely wrong. Give me a bit to sort this out. I'm having trouble seeing a way to

Re: [HACKERS] [PATCH] pg_dump: Sort overloaded functions in deterministic order

2012-10-18 Thread Joel Jacobson
On Wed, Oct 17, 2012 at 11:43 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Uh, the patch you posted keeps the pg_get_function_identity_arguments call in dumpFunc, but there is now also a new one in getFuncs. Do we need to remove the second one? It could be done, but unfortunately we

Re: [HACKERS] Global Sequences

2012-10-18 Thread Dimitri Fontaine
Simon Riggs si...@2ndquadrant.com writes: Not sure how it is cleaner when we have to have trigger stuff hanging around to make one object pretend to be another. That also creates a chain of dependency which puts this into the future, rather than now. Yes, that part isn't cleaner at all. The

[HACKERS] Deprecations in authentication

2012-10-18 Thread Magnus Hagander
Since Simon stirred up a hornets nest suggesting deprecation of a number of features, I figured I'd take it one step further and suggest removal of some previously deprecated features :) In particular, we made a couple of changes over sveral releases back in the authentication config, that we

Re: [HACKERS] Deprecations in authentication

2012-10-18 Thread Simon Riggs
On 18 October 2012 12:20, Magnus Hagander mag...@hagander.net wrote: 2. ident-over-unix-sockets was renamed to peer in 9.1, with the old syntax deprecated but still mapping to the new one. Has it been there long enough that we should start throwing an error for ident on unix? Any reason to

Re: [HACKERS] Deprecations in authentication

2012-10-18 Thread Magnus Hagander
On Thu, Oct 18, 2012 at 1:32 PM, Simon Riggs si...@2ndquadrant.com wrote: On 18 October 2012 12:20, Magnus Hagander mag...@hagander.net wrote: 2. ident-over-unix-sockets was renamed to peer in 9.1, with the old syntax deprecated but still mapping to the new one. Has it been there long enough

Re: [HACKERS] Deprecations in authentication

2012-10-18 Thread Simon Riggs
On 18 October 2012 12:37, Magnus Hagander mag...@hagander.net wrote: On Thu, Oct 18, 2012 at 1:32 PM, Simon Riggs si...@2ndquadrant.com wrote: On 18 October 2012 12:20, Magnus Hagander mag...@hagander.net wrote: 2. ident-over-unix-sockets was renamed to peer in 9.1, with the old syntax

Re: [HACKERS] Deprecations in authentication

2012-10-18 Thread Simon Riggs
On 18 October 2012 12:20, Magnus Hagander mag...@hagander.net wrote: Since Simon stirred up a hornets nest suggesting deprecation of a number of features, I figured I'd take it one step further and suggest removal of some previously deprecated features :) I'm laughing at the analogy that

[HACKERS] Re: DROP INDEX CONCURRENTLY is not really concurrency safe leaves around undroppable indexes

2012-10-18 Thread Abhijit Menon-Sen
At 2012-09-25 01:46:18 +0200, and...@2ndquadrant.com wrote: The attached patch fixes this issue. Haven't looked at the other one in detail yet. Here are tests for both bugs. They currently fail with HEAD. Note that the first test now uses PREPARE instead of the SELECTs in the original

Re: [HACKERS] Re: DROP INDEX CONCURRENTLY is not really concurrency safe leaves around undroppable indexes

2012-10-18 Thread Simon Riggs
On 18 October 2012 12:56, Abhijit Menon-Sen a...@2ndquadrant.com wrote: At 2012-09-25 01:46:18 +0200, and...@2ndquadrant.com wrote: The attached patch fixes this issue. Haven't looked at the other one in detail yet. Here are tests for both bugs. They currently fail with HEAD. Note that the

Re: [HACKERS] Bugs in CREATE/DROP INDEX CONCURRENTLY

2012-10-18 Thread Kevin Grittner
Andres Freund wrote: On Thursday, October 18, 2012 06:12:02 AM Kevin Grittner wrote: I'm having trouble seeing a way to make this work without rearranging the code for concurrent drop to get to a state where it has set indisvalid = false, made that visible to all processes, and ensured that

Re: [HACKERS] Deprecations in authentication

2012-10-18 Thread Alvaro Herrera
Simon Riggs wrote: On 18 October 2012 12:20, Magnus Hagander mag...@hagander.net wrote: Since Simon stirred up a hornets nest suggesting deprecation of a number of features, I figured I'd take it one step further and suggest removal of some previously deprecated features :) I'm

Re: [HACKERS] Deprecating RULES

2012-10-18 Thread Andrew Dunstan
On 10/17/2012 07:25 PM, Tom Lane wrote: I'm fairly annoyed by the entire tenor of this conversation, because the people who are hollering the loudest seem to be people who have never actually touched any of the rules code, but nonetheless seem prepared to tell those of us who have what to

Re: [HACKERS] [RFC][PATCH] wal decoding, attempt #2 - Design Documents (really attached)

2012-10-18 Thread Peter Geoghegan
On 16 October 2012 15:26, Jan Wieck janwi...@yahoo.com wrote: This means that the transition time from the existing, trigger based approach to the new WAL based mechanism will see both technologies in parallel, which is no small thing to support. So, you're talking about a shim between the two

Re: [HACKERS] hash_search and out of memory

2012-10-18 Thread Tom Lane
Hitoshi Harada umi.tan...@gmail.com writes: If OOM happens during expand_table() in hash_search_with_hash_value() for RelationCacheInsert, What OOM? expand_table is supposed to return without doing anything if it can't expand the table. If that's not happening, that's a bug in the hash code.

Re: [HACKERS] September 2012 commitfest

2012-10-18 Thread Alvaro Herrera
Amit Kapila wrote: For the Patch, Trim trailing NULL columns, I have provided the performance data required and completed the review. There are only few review comments which can be addressed. So is it possible that I complete them and mark it as Ready For Committer or what else can be the

Re: [HACKERS] [BUG] False indication in pg_stat_replication.sync_state

2012-10-18 Thread Fujii Masao
On Thu, Oct 18, 2012 at 5:42 PM, Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp wrote: Hello. My colleague found that pg_stat_replication.sync_state shows false state for some condition. This prevents Pacemaker from completing fail-over that could safely be done. The point is in

Re: [HACKERS] First draft of snapshot snapshot building design document

2012-10-18 Thread Robert Haas
On Tue, Oct 16, 2012 at 7:30 AM, Andres Freund and...@2ndquadrant.com wrote: On Thursday, October 11, 2012 01:02:26 AM Peter Geoghegan wrote: The design document [2] really just explains the problem (which is the need for catalog metadata at a point in time to make sense of heap tuples),

Re: [HACKERS] Deprecations in authentication

2012-10-18 Thread Simon Riggs
On 18 October 2012 12:43, Simon Riggs si...@2ndquadrant.com wrote: On 18 October 2012 12:20, Magnus Hagander mag...@hagander.net wrote: Since Simon stirred up a hornets nest suggesting deprecation of a number of features, I figured I'd take it one step further and suggest removal of some

Re: [HACKERS] Global Sequences

2012-10-18 Thread Robert Haas
On Tue, Oct 16, 2012 at 1:29 PM, Tom Lane t...@sss.pgh.pa.us wrote: In particular, the reason proposing a hook first seems backwards is that if we have a catalog-level representation that some sequences are local and others not, we should be using that to drive the determination of whether to

Re: [HACKERS] Global Sequences

2012-10-18 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Tue, Oct 16, 2012 at 1:29 PM, Tom Lane t...@sss.pgh.pa.us wrote: Or maybe better, invent a level of indirection like a sequence access method (comparable to index access methods) that provides a compatible set of substitute functions for sequence

Re: [HACKERS] [RFC][PATCH] wal decoding, attempt #2 - Design Documents (really attached)

2012-10-18 Thread Christopher Browne
On Thu, Oct 18, 2012 at 9:49 AM, Peter Geoghegan pe...@2ndquadrant.com wrote: On 16 October 2012 15:26, Jan Wieck janwi...@yahoo.com wrote: This means that the transition time from the existing, trigger based approach to the new WAL based mechanism will see both technologies in parallel, which

Re: [HACKERS] [BUGS] BUG #7534: walreceiver takes long time to detect n/w breakdown

2012-10-18 Thread Fujii Masao
On Wed, Oct 17, 2012 at 8:46 PM, Amit Kapila amit.kap...@huawei.com wrote: On Monday, October 15, 2012 3:43 PM Heikki Linnakangas wrote: On 13.10.2012 19:35, Fujii Masao wrote: On Thu, Oct 11, 2012 at 11:52 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: Ok, thanks. Committed. I

Re: [HACKERS] [RFC][PATCH] wal decoding, attempt #2 - Design Documents (really attached)

2012-10-18 Thread Peter Geoghegan
On 18 October 2012 16:18, Christopher Browne cbbro...@gmail.com wrote: A shim adds complexity, but retains the upgrade across versions use case, and reduces the need to keep supporting elder versions of Slony. Right. Upgrading across major versions is likely to continue to remain a very

Re: [HACKERS] [PATCH] pg_dump: Sort overloaded functions in deterministic order

2012-10-18 Thread Alvaro Herrera
Joel Jacobson wrote: On Wed, Oct 17, 2012 at 11:43 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Uh, the patch you posted keeps the pg_get_function_identity_arguments call in dumpFunc, but there is now also a new one in getFuncs. Do we need to remove the second one? It could be

Re: [HACKERS] Review for pg_dump: Sort overloaded functions in deterministic order

2012-10-18 Thread Alvaro Herrera
Joel Jacobson wrote: Hi Joachim, Attached, please find new patch. Test unchanged. This was committed, as discussed in the original patch's thread. It would be great if reviewers could reply to the email that submits the patch, instead of creating a thread of their own. It helps keep things

Re: [HACKERS] hash_search and out of memory

2012-10-18 Thread Tom Lane
I wrote: Hitoshi Harada umi.tan...@gmail.com writes: If OOM happens during expand_table() in hash_search_with_hash_value() for RelationCacheInsert, What OOM? expand_table is supposed to return without doing anything if it can't expand the table. If that's not happening, that's a bug in

Re: [HACKERS] First draft of snapshot snapshot building design document

2012-10-18 Thread Andres Freund
On Thursday, October 18, 2012 04:47:12 PM Robert Haas wrote: On Tue, Oct 16, 2012 at 7:30 AM, Andres Freund and...@2ndquadrant.com wrote: On Thursday, October 11, 2012 01:02:26 AM Peter Geoghegan wrote: The design document [2] really just explains the problem (which is the need for catalog

Re: [HACKERS] Bug in -c CLI option of pg_dump/pg_restore

2012-10-18 Thread Alvaro Herrera
Robert Haas escribió: On Tue, Oct 16, 2012 at 10:31 AM, Guillaume Lelarge guilla...@lelarge.info wrote: Any comments on this? I'm not sure I'd want to back-patch this, since it is a behavior change, but I do think it's probably a good idea to change it for 9.3. Hm, but the bug is said to

Re: [HACKERS] Global Sequences

2012-10-18 Thread Simon Riggs
On 18 October 2012 16:08, Robert Haas robertmh...@gmail.com wrote: To make it even better, add some generic options that can be passed through to the underlying handler. Agreed Or maybe better, invent a level of indirection like a sequence access method (comparable to index access methods)

Re: [HACKERS] Global Sequences

2012-10-18 Thread Simon Riggs
On 18 October 2012 16:15, Tom Lane t...@sss.pgh.pa.us wrote: But I'd want to see a pretty bulletproof argument why overriding *only* nextval is sufficient (and always will be) before accepting a hook for just nextval. If we build an equivalent amount of functionality piecemeal it's going to

Re: [HACKERS] tuplesort memory usage: grow_memtuples

2012-10-18 Thread Alvaro Herrera
Greg Stark escribió: On Tue, Oct 16, 2012 at 9:47 PM, Peter Geoghegan pe...@2ndquadrant.com wrote: The patch will now been marked ready for committer. Does this need doc changes, in light of what is arguably a behavioural difference? You only mentioned release notes. I'm happy to look

Re: [HACKERS] PATCH: optimized DROP of multiple tables within a transaction

2012-10-18 Thread Alvaro Herrera
Tomas Vondra wrote: Hi, thanks for the review. I'll look into that in ~2 weeks, once the pgconf.eu is over. Excellent. Please submit the updated version to the upcoming commitfest when you have it. I'm marking this patch Returned with Feedback. Many thanks to Shigeru Hanada for the review

Re: [HACKERS] PATCH: pgbench - aggregation of info written into log

2012-10-18 Thread Alvaro Herrera
Tomas Vondra wrote: Also, I've realized the last interval may not be logged at all - I'll take a look into this in the next version of the patch. I didn't see any later version of this patch posted anywhere. I guess it'll have to wait until the next commitfest. Please fix the remaining

Re: [HACKERS] Deprecations in authentication

2012-10-18 Thread Robert Haas
On Thu, Oct 18, 2012 at 7:20 AM, Magnus Hagander mag...@hagander.net wrote: Since Simon stirred up a hornets nest suggesting deprecation of a number of features, I figured I'd take it one step further and suggest removal of some previously deprecated features :) In particular, we made a

Re: [HACKERS] tuplesort memory usage: grow_memtuples

2012-10-18 Thread Peter Geoghegan
On 16 October 2012 21:47, Peter Geoghegan pe...@2ndquadrant.com wrote: The same basic strategy for sizing the tuplesort memtuples array in also exists in tuplestore. I wonder if we should repeat this there? I suppose that that could follow later. Incidentally, the basis of this remark is

[HACKERS] Re: [PATCH 3/8] Add support for a generic wal reading facility dubbed XLogReader

2012-10-18 Thread Alvaro Herrera
This patch doesn't seem to be going anywhere, sadly. Since we're a bit late in the commitfest and this patch hasn't seen any activity for a long time, I'll mark it as returned-with-feedback. I hope one or both versions are resubmitted (with additional fixes?) for the next commitfest, and that

Re: [HACKERS] xlog filename formatting functions in recovery

2012-10-18 Thread Alvaro Herrera
Daniel, I assume you are submitting an updated version based on the feedback that has been provided. I will mark this patch returned with feedback in the current CF; please submit the next version to CF3. Thanks to the (rather numerous!) reviewers. -- Álvaro Herrera

[HACKERS] Very minor feature suggestion

2012-10-18 Thread Murphy, Kevin
It might be nice for psql to have a 'htmlcaption' boolean pset option that would wrap the provided title/caption, if any, in a caption tag in the HTML report output, when using html format. Motivation: When I use: \pset title 'Some title' or \C 'Some title' psql emits the text:

Re: [HACKERS] Deprecations in authentication

2012-10-18 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Thu, Oct 18, 2012 at 7:20 AM, Magnus Hagander mag...@hagander.net wrote: 2. ident-over-unix-sockets was renamed to peer in 9.1, with the old syntax deprecated but still mapping to the new one. Has it been there long enough that we should start

Re: [HACKERS] xlog filename formatting functions in recovery

2012-10-18 Thread Daniel Farina
On Thu, Oct 18, 2012 at 9:22 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Daniel, I assume you are submitting an updated version based on the feedback that has been provided. I will mark this patch returned with feedback in the current CF; please submit the next version to CF3. Thank

Re: [HACKERS] Deprecating RULES

2012-10-18 Thread Steve Crawford
On 10/17/2012 04:25 PM, Tom Lane wrote: ...Now having said that, I would definitely like to see rules in their current form go away eventually. But not without a substitute. Triggers are not a complete replacement, and no amount of wishful thinking makes them so. ... Perhaps it would be more

Re: [HACKERS] Bug in -c CLI option of pg_dump/pg_restore

2012-10-18 Thread Guillaume Lelarge
On Thu, 2012-10-18 at 12:19 -0300, Alvaro Herrera wrote: Robert Haas escribió: On Tue, Oct 16, 2012 at 10:31 AM, Guillaume Lelarge guilla...@lelarge.info wrote: Any comments on this? I'm not sure I'd want to back-patch this, since it is a behavior change, but I do think it's

Re: [HACKERS] [BUGS] BUG #7534: walreceiver takes long time to detect n/w breakdown

2012-10-18 Thread Fujii Masao
On Tue, Oct 16, 2012 at 9:31 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 15.10.2012 19:31, Fujii Masao wrote: On Mon, Oct 15, 2012 at 11:27 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 15.10.2012 13:13, Heikki Linnakangas wrote: Oh, I didn't remember that we've

Re: [HACKERS] Deprecating RULES

2012-10-18 Thread Daniel Farina
On Thu, Oct 18, 2012 at 6:46 AM, Andrew Dunstan and...@dunslane.net wrote: On 10/17/2012 07:25 PM, Tom Lane wrote: I'm fairly annoyed by the entire tenor of this conversation, because the people who are hollering the loudest seem to be people who have never actually touched any of the rules

Re: [HACKERS] Deprecations in authentication

2012-10-18 Thread Joshua D. Drake
On 10/18/2012 04:43 AM, Simon Riggs wrote: On 18 October 2012 12:20, Magnus Hagander mag...@hagander.net wrote: Since Simon stirred up a hornets nest suggesting deprecation of a number of features, I figured I'd take it one step further and suggest removal of some previously deprecated

Re: [HACKERS] [RFC] CREATE QUEUE (log-only table) for londiste/pgQ ccompatibility

2012-10-18 Thread Josh Berkus
Simon, It's hard to work out how to reply to this because its just so off base. I don't agree with the restrictions you think you see at all, saying it politely rather than giving a one word answer. You have inside knowledge of Hannu's design. I am merely going from his description *on this

Re: [HACKERS] [PATCH] lock_timeout and common SIGALRM framework

2012-10-18 Thread Alvaro Herrera
Boszormenyi Zoltan escribió: Hi, this is the latest one, fixing a bug in the accounting of per-statement lock timeout handling and tweaking some comments. Tom, are you able to give this patch some more time on this commitfest? (If not, I think it would be fair to boot it to CF3; this is

Re: [HACKERS] [PATCH] lock_timeout and common SIGALRM framework

2012-10-18 Thread Tom Lane
Alvaro Herrera alvhe...@2ndquadrant.com writes: Boszormenyi Zoltan escribió: this is the latest one, fixing a bug in the accounting of per-statement lock timeout handling and tweaking some comments. Tom, are you able to give this patch some more time on this commitfest? I'm still hoping to

Re: [HACKERS] gistchoose vs. bloat

2012-10-18 Thread Alvaro Herrera
Alexander Korotkov escribió: 4. It looks like the randomization is happening while trying to compare the penalties. I think it may be more readable to separate those two steps; e.g. /* create a mapping whether randomization is on or not */ for (i = FirstOffsetNumber; i = maxoff; i

Re: [HACKERS] Statistics and selectivity estimation for ranges

2012-10-18 Thread Alvaro Herrera
Heikki, would you be able to give this patch a look and perhaps commit it? -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] SP-GiST for ranges based on 2d-mapping and quad-tree

2012-10-18 Thread Alvaro Herrera
Jeff Davis escribió: On Sat, 2012-08-18 at 18:10 +0400, Alexander Korotkov wrote: Thanks! There is a separate patch for adjacent. I've reworked adjacent check in order to make it more clear. I am taking a look at this patch now. A few quick comments: * I tried some larger tests and

Re: [HACKERS] [v9.3] Row-Level Security

2012-10-18 Thread Alvaro Herrera
Kohei KaiGai escribió: The revised patch fixes the problem that Daen pointed out. Robert, would you be able to give this latest version of the patch a look? (KaiGai, does it still apply cleanly? If not, please submit a rebased version.) -- Álvaro Herrera

Re: [HACKERS] [RFC] CREATE QUEUE (log-only table) for londiste/pgQ ccompatibility

2012-10-18 Thread Claudio Freire
On Thu, Oct 18, 2012 at 2:33 PM, Josh Berkus j...@agliodbs.com wrote: I should also add that this is an switchable sync/asynchronous transactional queue, whereas LISTEN/NOTIFY is a synchronous transactional queue. Thanks for explaining. New here, I missed half the conversation, but since

Re: [HACKERS] Bugs in CREATE/DROP INDEX CONCURRENTLY

2012-10-18 Thread Simon Riggs
On 18 October 2012 10:20, Andres Freund and...@2ndquadrant.com wrote: On Thursday, October 18, 2012 06:12:02 AM Kevin Grittner wrote: Kevin Grittner wrote: Hmm. The comment is probably better now, but I've been re-checking the code, and I think my actual code change is completely wrong.

Re: [HACKERS] [RFC] CREATE QUEUE (log-only table) for londiste/pgQ ccompatibility

2012-10-18 Thread Hannu Krosing
On 10/18/2012 07:33 PM, Josh Berkus wrote: Simon, It's hard to work out how to reply to this because its just so off base. I don't agree with the restrictions you think you see at all, saying it politely rather than giving a one word answer. You have inside knowledge of Hannu's design.

Re: [HACKERS] [RFC] CREATE QUEUE (log-only table) for londiste/pgQ ccompatibility

2012-10-18 Thread Hannu Krosing
On 10/18/2012 08:36 PM, Claudio Freire wrote: The CREATE QUEUE command, in fact, could be creating such a channel. The channel itself won't be WAL-only, just the messages going through it. This (I think) would solve locking issues. Hmm. Maybe we should think of implementing this as REMOTE

Re: [HACKERS] Truncate if exists

2012-10-18 Thread Robert Haas
On Tue, Oct 16, 2012 at 2:12 PM, Stafford, David x78061 david.staff...@broadridge.com wrote: On Mon, 15 Oct 2012 10:21:18 -0700, Robert Haas robertmh...@gmail.com wrote: Yeah, I think the functionality that we need is pretty much there already today. What we need to do is to get the syntax to

Re: [HACKERS] [RFC] CREATE QUEUE (log-only table) for londiste/pgQ ccompatibility

2012-10-18 Thread Christopher Browne
On Thu, Oct 18, 2012 at 2:56 PM, Hannu Krosing ha...@2ndquadrant.com wrote: * works as table on INSERTS up to inserting logical WAL record describing the insert but no data is inserted locally. with all things that follow from the local table having no data - unique constraints don't make

Re: [HACKERS] Incorrect behaviour when using a GiST index on points

2012-10-18 Thread Noah Misch
On Thu, Oct 11, 2012 at 07:17:28AM -0400, Noah Misch wrote: On Tue, Oct 02, 2012 at 01:58:40PM -0400, Noah Misch wrote: On Mon, Aug 27, 2012 at 7:43 PM, Tom Lane t...@sss.pgh.pa.us wrote: There's also the big-picture question of whether we should just get rid of fuzzy comparisons in

Re: [HACKERS] [BUGS] BUG #7521: Cannot disable WAL log while using pg_dump

2012-10-18 Thread Gezeala M . Bacuño II
You may disable full_page_writes, but as you can see from my previous post, disabling it did not do the trick. My zfs' USED property continues to increase. On Wed, Oct 17, 2012 at 3:55 PM, ichbinrene rene.romer...@gmail.com wrote: I'm experiencing the exact same issue: PostgreSQL 9.1.6 on

Re: [HACKERS] pg_stat_lwlocks view - lwlocks statistics, round 2

2012-10-18 Thread Robert Haas
On Tue, Oct 16, 2012 at 11:31 AM, Satoshi Nagayasu sn...@uptime.jp wrote: A flight-recorder must not be disabled. Collecting performance data must be top priority for DBA. This analogy is inapposite, though, because a flight recorder rarely crashes the aircraft. If it did, people might have

Re: [HACKERS] Deprecating RULES

2012-10-18 Thread Robert Haas
On Wed, Oct 17, 2012 at 7:25 PM, Tom Lane t...@sss.pgh.pa.us wrote: Josh Berkus j...@agliodbs.com writes: I would tend to say well, they're not hurting anyone, why not keep them? Except that we're gathering an increasing number of features (RETURNING, FDWs, CTEs, Command triggers) which don't

Re: [HACKERS] embedded list

2012-10-18 Thread Tom Lane
Alvaro Herrera alvhe...@2ndquadrant.com writes: Here's the final version. I think this is ready to go in. I got around to reviewing this today. I'm pretty seriously annoyed at the definition of dlist_delete: it should *not* require the list header. The present coding simply throws away one of

Re: [HACKERS] Skip checkpoint on promoting from streaming replication

2012-10-18 Thread Alvaro Herrera
This patch seems to have been neglected by both its submitter and the reviewer. Also, Simon said he was going to set it returned-with-feedback on his last reply, but I see it as needs-review still in the CF app. Is this something that is going to be reconsidered and resubmitted for the next

[HACKERS] Prefetch index pages for B-Tree index scans

2012-10-18 Thread Claudio Freire
I've noticed, doing some reporting queries once, that index scans fail to saturate server resources on compute-intensive queries. Problem is, just after fetching a page, postgres starts computing stuff before fetching the next. This results in I/O - compute - I/O - compute alternation that

Re: [HACKERS] [PATCH] lock_timeout and common SIGALRM framework

2012-10-18 Thread Boszormenyi Zoltan
2012-10-18 20:08 keltezéssel, Tom Lane írta: Alvaro Herrera alvhe...@2ndquadrant.com writes: Boszormenyi Zoltan escribió: this is the latest one, fixing a bug in the accounting of per-statement lock timeout handling and tweaking some comments. Tom, are you able to give this patch some more

Re: [HACKERS] Deprecating RULES

2012-10-18 Thread Andrew Dunstan
On 10/18/2012 01:11 PM, Daniel Farina wrote: Here's another use case that in my history with RULES that didn't seem to pan out so well: In my recollection, one way to use rules is to retarget operations that happen against a view and move them to a table, and as I recall to make this work as

Re: [HACKERS] embedded list

2012-10-18 Thread Tom Lane
Alvaro Herrera alvhe...@2ndquadrant.com writes: Oops. I mentioned this explicitely somewhere in the discussion. I assumed you had seen that, and that you would have complained had you found it objectionable. Sorry, I've been too busy to pay very much attention to this patch. I think we

Re: [HACKERS] Deprecating RULES

2012-10-18 Thread Любен Каравелов
Well, it'd be nice to be able to rewrite a query referring to a table to still refer to that same table, but you can't, because you get infinite recursion. If that was possible it would be quite easy to express any row/column level security policies with it. If you could do that, it'd

Re: [HACKERS] Skip checkpoint on promoting from streaming replication

2012-10-18 Thread Simon Riggs
On 18 October 2012 21:22, Alvaro Herrera alvhe...@2ndquadrant.com wrote: This patch seems to have been neglected by both its submitter and the reviewer. Also, Simon said he was going to set it returned-with-feedback on his last reply, but I see it as needs-review still in the CF app. Is

Re: [HACKERS] [PATCH] Prefetch index pages for B-Tree index scans

2012-10-18 Thread Claudio Freire
On Thu, Oct 18, 2012 at 5:30 PM, Claudio Freire klaussfre...@gmail.com wrote: Backward: QUERY PLAN

Re: [HACKERS] Deprecations in authentication

2012-10-18 Thread Peter Eisentraut
On Thu, 2012-10-18 at 13:20 +0200, Magnus Hagander wrote: In particular, we made a couple of changes over sveral releases back in the authentication config, that we should perhaps consider finishing by removing the old stuff now? 1. krb5 authentication. We've had gssapi since 8.3 (which

Re: [HACKERS] Deprecations in authentication

2012-10-18 Thread Peter Eisentraut
On Thu, 2012-10-18 at 12:38 -0400, Tom Lane wrote: I think the argument that it causes user confusion is a fairly strong one, though. What is confusing, IMO, is changing the hba syntax all the time. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to

Re: [HACKERS] pg_stat_lwlocks view - lwlocks statistics, round 2

2012-10-18 Thread Ants Aasma
On Thu, Oct 18, 2012 at 10:36 PM, Robert Haas robertmh...@gmail.com wrote: Sadly, the situation on Windows doesn't look so good. I don't remember the exact numbers but I think it was something like 40 or 60 or 80 times slower on the Windows box one of my colleagues tested than it is on Linux.

Re: [HACKERS] Deprecating RULES

2012-10-18 Thread Daniel Farina
On Thu, Oct 18, 2012 at 1:55 PM, Andrew Dunstan and...@dunslane.net wrote: On 10/18/2012 01:11 PM, Daniel Farina wrote: Here's another use case that in my history with RULES that didn't seem to pan out so well: In my recollection, one way to use rules is to retarget operations that happen

Re: [HACKERS] Deprecating RULES

2012-10-18 Thread Josh Berkus
Daniel, I'm not going to disagree with that, I only feel it's reasonable to ask why those who react so strongly against deprecation why they think what they do, and receive a clinical response, because not everyone has seen those use cases. My level of interest in deprecation is only as far

Re: [HACKERS] Deprecating RULES

2012-10-18 Thread Daniel Farina
On Thu, Oct 18, 2012 at 6:10 PM, Josh Berkus j...@agliodbs.com wrote: Daniel, I'm not going to disagree with that, I only feel it's reasonable to ask why those who react so strongly against deprecation why they think what they do, and receive a clinical response, because not everyone has

Re: [HACKERS] [PATCH] Support for Array ELEMENT Foreign Keys

2012-10-18 Thread Tom Lane
Marco Nenciarini marco.nenciar...@2ndquadrant.it writes: Please find the attached refreshed patch (v2) which fixes the loose ends you found. I've started looking at this patch, and the first thing I notice is that the syntax doesn't work. It's ambiguous, and this: %left JOIN CROSS

Re: [HACKERS] [RFC] CREATE QUEUE (log-only table) for londiste/pgQ ccompatibility

2012-10-18 Thread Ants Aasma
On Thu, Oct 18, 2012 at 10:03 PM, Hannu Krosing ha...@2ndquadrant.com wrote: Hmm. Maybe we should think of implementing this as REMOTE TABLE, that is a table which gets no real data stored locally but all insert got through WAL and are replayed as real inserts on slave side. FWIW, MySQL calls

Re: [HACKERS] [PATCH] Support for Array ELEMENT Foreign Keys

2012-10-18 Thread Tom Lane
I wrote: Or we could go back to using ARRAY here --- that should be safe since ARRAY is already fully reserved. Ugh ... no, that doesn't work, because ARRAY[...] is allowed in c_expr and hence b_expr. So the ambiguity would still be there. We'd need a different fully-reserved keyword to go

Re: [HACKERS] hash_search and out of memory

2012-10-18 Thread Hitoshi Harada
On Thu, Oct 18, 2012 at 8:35 AM, Tom Lane t...@sss.pgh.pa.us wrote: I wrote: Hitoshi Harada umi.tan...@gmail.com writes: If OOM happens during expand_table() in hash_search_with_hash_value() for RelationCacheInsert, the palloc-based allocator does throw errors. I think that when that was