Re: [HACKERS] Allow substitute allocators for PGresult.

2011-12-22 Thread Kyotaro HORIGUCHI
in backend is preferable for the usage and don't want to get data making detour via PGresult. regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-01-17 Thread Kyotaro HORIGUCHI
. libpq_altstore_doc_20120117.patch - Document for libpq_altstore. Shows in 31.19. Alternatie result storage regards, -- Kyotaro Horiguchi NTT Open Source Software Center diff --git a/src/interfaces/libpq/exports.txt b/src/interfaces/libpq/exports.txt index 1af8df6..83525e1 100644 --- a/src/interfaces/libpq/exports.txt

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-01-26 Thread Kyotaro HORIGUCHI
it realize. regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-01-27 Thread Kyotaro HORIGUCHI
the orignal. regargs, -- Kyotaro Horiguchi NTT Open Source Software Center diff --git a/src/interfaces/libpq/exports.txt b/src/interfaces/libpq/exports.txt index 1af8df6..c47af3a 100644 --- a/src/interfaces/libpq/exports.txt +++ b/src/interfaces/libpq/exports.txt @@ -160,3 +160,6 @@ PQconnectStartParams

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-01-30 Thread Kyotaro HORIGUCHI
|29 |29 |29 |29 (1 row) -- Kyotaro Horiguchi NTT Open Source Software Center diff --git a/src/interfaces/libpq/exports.txt b/src/interfaces/libpq/exports.txt index 1af8df6..5ed083c 100644 --- a/src/interfaces/libpq/exports.txt +++ b/src/interfaces/libpq/exports.txt @@ -160,3 +160,5

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-01-30 Thread Kyotaro HORIGUCHI
() or dblink_record_internal(). The behavior that this dblink displays this error as 'unkown error/could not execute query' on the user session is as it did before. regards, -- Kyotaro Horiguchi NTT Open Source Software Center diff --git a/contrib/dblink/dblink.c b/contrib/dblink/dblink.c index 36a8e3e

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-02-01 Thread Kyotaro HORIGUCHI
.. However, the inhibition of throwing exceptions in RowProcessor is not based on any certain fact, so palloc here may make sense if we can do that. -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-02-01 Thread Kyotaro HORIGUCHI
Hello, This is new version of dblink.c - Memory is properly freed when realloc returns NULL in storeHandler(). - The bug that free() in finishStoreInfo() will be fed with garbage pointer when malloc for sinfo-valbuflen fails is fixed. regards, -- Kyotaro Horiguchi NTT Open Source Software

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-02-02 Thread Kyotaro HORIGUCHI
aggressive optimizations on dblink side, but I'd like to get a nod from a committer for libpq changes first. I'm looking forward to the aggressiveness of that:-) regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-02-15 Thread Kyotaro HORIGUCHI
should I insert this function ? regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-02-20 Thread Kyotaro HORIGUCHI
Hello, I don't have any attachment to PQskipRemainingResults(), but I think that some formal method to skip until Command-Complete('C') without breaking session is necessary because current libpq does so. On Thu, Feb 16, 2012 at 02:24:19PM +0900, Kyotaro HORIGUCHI wrote: The choices

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-02-21 Thread Kyotaro HORIGUCHI
. regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-02-21 Thread Kyotaro HORIGUCHI
succeeding PQgetResult()'s to skip all the rows. ~~ -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-02-21 Thread Kyotaro HORIGUCHI
processor in PGconn when the second parameter is true, and in PGresult for false. No, let's keep row processor only under PGconn. Then, Should I add the stash for the row processor (and needless for param) to recall after in PGconn? regards, -- Kyotaro Horiguchi NTT Open Source Software Center

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-02-21 Thread Kyotaro HORIGUCHI
Thank you. Everything seems clear. Please wait for a while. PQskipResult: - store old callback and param in local vars - set do-nothing row callback - call PQgetresu On Tue, Feb 21, 2012 at 12:13 PM, Kyotaro HORIGUCHI horiguchi.kyot...@oss.ntt.co.jp wrote: - PQskipResult(conn, true

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-02-23 Thread Kyotaro HORIGUCHI
). # PQsetRowProcessorErrMsg outside of callback is not implemented. - Documentation and dblink are modified according to the changes above. By the way, I would like to ask you one question. What is the reason why void* should be head or tail of the parameter list? regards, -- Kyotaro Horiguchi NTT Open Source

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-02-24 Thread Kyotaro HORIGUCHI
now... all errors are displayed as `Error occurred on dblink connection...'. - TODO: No NLS messages for error messages. - Somehow make check yields error for base revision. So I have not done that. - I have no idea how to do test for protocol 2... regards, -- Kyotaro Horiguchi NTT Open

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-02-27 Thread Kyotaro HORIGUCHI
== PGRES_TUPLES_BREAK can be used to check if the transfer is breaked. Instead use (%s, errmsg) as argument there. libpq code is noisy enough, no need to add more. Ok. I will do so. regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-02-27 Thread Kyotaro HORIGUCHI
keeping NULL there. I agree with it. regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-02-28 Thread Kyotaro HORIGUCHI
connection..: could not execute query'.. Is it right to consider this as follows? - dblink is wrong in error handling. A client of libpq should see PGconn by PQerrorMessage() if (or regardless of whether?) PGresult says nothing about error. regards, -- Kyotaro Horiguchi NTT Open Source

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-03-05 Thread Kyotaro HORIGUCHI
simply drop it. Ok. My suggestion - check in getAnotherTuple whether resultStatus is already error and do nothing then. This allows internal pqAddRow to set regular out of memory error. Otherwise give generic row processor error. regards, -- Kyotaro Horiguchi NTT Open Source Software

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-03-06 Thread Kyotaro HORIGUCHI
for a while for the new patch. regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-03-06 Thread Kyotaro HORIGUCHI
that the whole row data is loaded at the point ^am that getAnotherTuple is called. I agree that getAnotherTuple should not return EOF to request for unloaded part of the message. Please wait for a while for the new patch. regards, -- Kyotaro Horiguchi NTT Open Source Software Center

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-03-06 Thread Kyotaro HORIGUCHI
this in parseInput3(). Could you give me further explanation? regards, -- Kyotaro Horiguchi NTT Open Source Software Center diff --git a/src/interfaces/libpq/exports.txt b/src/interfaces/libpq/exports.txt index 1af8df6..a6418ec 100644 --- a/src/interfaces/libpq/exports.txt +++ b/src/interfaces/libpq

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-03-07 Thread Kyotaro HORIGUCHI
://github.com/markokr/libpq-rowproc-demos with return value changes. I'm pretty happy with current state. So tagging it ReadyForCommitter. Thank you very much for all your help. regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] the number of pending entries in GIN index with FASTUPDATE=on

2012-11-19 Thread Kyotaro HORIGUCHI
show the other properties such as entry pages, data pages, entries, and total pages as pgstatindex does? regards, -- Kyotaro Horiguchi NTT Open Source Software Center (*1) Sample diff --git a/contrib/pgstattuple/pgstatindex.c b/contrib/pgstattuple/pgstatindex.c index 8a2ae85..71c2023

Re: [HACKERS] the number of pending entries in GIN index with FASTUPDATE=on

2012-11-27 Thread Kyotaro HORIGUCHI
. But if you think they are useful, I don't object to expose them. Ok, my point was the apparent consistency of the functions. I don't have any distinct wish about this. I'll mark this as Ready for Committer. regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers

[HACKERS] [BUG?] lag of minRecoveryPont in archive recovery

2012-12-05 Thread Kyotaro HORIGUCHI
, also works for 9.2, and seems no harm and maybe some grace for 9.1.. What do you think about this? The details follow. reagrds, -- Kyotaro Horiguchi NTT Open Source Software Center Operation sequence to cause the problem. === Mst$export PGDATA=$HOME/pgdatam Mst$rm -rf $PGDATA Mst$initdb

Re: [HACKERS] Performance Improvement by reducing WAL for Update Operation

2012-12-07 Thread Kyotaro HORIGUCHI
to be look similar. fastgetattr looks quite differ to corresponding macro. ... regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

Re: [HACKERS] [BUG?] lag of minRecoveryPont in archive recovery

2012-12-09 Thread Kyotaro HORIGUCHI
/msg00101.php Since I've not cleary understood the problem of missing it before redo, and it also seems to have no harm on performance, I have no objection to place it both before and after of redo. -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list

Re: [HACKERS] [BUG?] lag of minRecoveryPont in archive recovery

2012-12-09 Thread Kyotaro HORIGUCHI
xact_redo_commit_internal could shold be fixed in the same way. At Mon, 10 Dec 2012 00:41:34 +0900, Fujii Masao masao.fu...@gmail.com wrote in CAHGQGwEUpEvK=s0xrfinwnoasjhy3pod3hie4namowhk0a-...@mail.gmail.com On Thu, Dec 6, 2012 at 1:04 PM, Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp wrote

Re: [HACKERS] Performance Improvement by reducing WAL for Update Operation

2012-12-10 Thread Kyotaro HORIGUCHI
://archives.postgresql.org/message-id/6C0B27F7206C9E4CA54AE035729E9C38285495B0@szxeml509-mbx -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [BUG?] lag of minRecoveryPont in archive recovery

2012-12-10 Thread Kyotaro HORIGUCHI
into succeessfully startup, ignoring the another reason for it should be before, which is unknown to me. regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Performance Improvement by reducing WAL for Update Operation

2012-12-14 Thread Kyotaro HORIGUCHI
it. It's just a fancy. regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pl/perl and utf-8 in sql_ascii databases

2012-07-06 Thread Kyotaro HORIGUCHI
What should I do for this? badalex badalex Just let the commiter decide? :-) Agreed. -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail address has been changed since Apr. 1, 2012. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [SPAM] [MessageLimit][lowlimit] Re: [HACKERS] pl/perl and utf-8 in sql_ascii databases

2012-07-11 Thread Kyotaro HORIGUCHI
encodings. What do you think about that? regards, -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail address has been changed since Apr. 1, 2012. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] pl/perl and utf-8 in sql_ascii databases

2012-07-11 Thread Kyotaro HORIGUCHI
from other than sql_ascii, utf8 and latin1. This might be archieved by create empty plperl_lc.sql and plperl_lc.out files for those encodings. What do you think about that? regards, -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail address has been changed since Apr. 1, 2012

Re: [HACKERS] pl/perl and utf-8 in sql_ascii databases

2012-07-17 Thread Kyotaro HORIGUCHI
we should just remove the test. Ok I agree to do so. regards, -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail address has been changed since Apr. 1, 2012. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Skip checkpoint on promoting from streaming replication

2012-08-30 Thread Kyotaro HORIGUCHI
holyday. For now, I'm going to mark this as Returned With Feedback, but please don't be discouraged by that. I think we have enough time to think about that yet, and I believe this will be worth doing. Thank you. regards, -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail

[HACKERS] Identity projection

2012-09-13 Thread Kyotaro HORIGUCHI
, -- Kyotaro Horiguchi NTT Open Source Software Center diff --git a/src/backend/executor/execQual.c b/src/backend/executor/execQual.c index 56b106a..da1113f 100644 --- a/src/backend/executor/execQual.c +++ b/src/backend/executor/execQual.c @@ -5360,6 +5360,11 @@ ExecProject(ProjectionInfo

Re: [HACKERS] Identity projection

2012-09-14 Thread Kyotaro HORIGUCHI
onto disks. regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Identity projection

2012-09-14 Thread Kyotaro HORIGUCHI
is confusing that optimization somehow. The whole table is on memory and query is very simple and the number of columns is relatively larger in this case. This is because I intended to improve retrieving a large part of partitioned table with many columns. -- Kyotaro Horiguchi NTT Open Source

[HACKERS] Reduce palloc's in numeric operations.

2012-09-14 Thread Kyotaro HORIGUCHI
on_memory_table' needed 1570 ms. Similary 8% gain for about 30 - 50 digits numeric. Performance of avg(numeric) made no gain in contrast. Do you think this worth doing? regards, -- Kyotaro Horiguchi NTT Open Source Software Center diff --git a/src/backend/utils/adt/numeric.c b/src/backend/utils/adt

Re: [HACKERS] Identity projection

2012-10-05 Thread Kyotaro HORIGUCHI
0.00 101 0.00 0.00 ExecResult ! 0.00 0.13 0.00 100 0.00 0.00 ExecProject regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Identity projection

2012-10-17 Thread Kyotaro HORIGUCHI
Ah. It's too late. I'll re-submit updated versions of my patches left alone in the last CF. Hi, I've marked this patch as Returned with Feedback (thanks Tom). Please submit an updated version to the upcoming commitfest. Thanks. I'm sorry and thank you. -- Kyotaro Horiguchi NTT Open Source

[HACKERS] [BUG] False indication in pg_stat_replication.sync_state

2012-10-18 Thread Kyotaro HORIGUCHI
/E338 flush 3/0 apply 2/FE80 !| DEBUG: HOGE: flush = 3/0 sync_priority[0] = 1 I think this patch should be applied for 9.2.2 and 9.1.7. regards, -- Kyotaro Horiguchi NTT Open Source Software Center = The patch for this test

Re: [HACKERS] [BUG] False indication in pg_stat_replication.sync_state

2012-10-19 Thread Kyotaro HORIGUCHI
. In these files, LSN's fed to XLogRecPtrIsInvalid() looks to be *valid* start point of WAL records, but I'm not sure of that. regards, -- Kyotaro Horiguchi NTT Open Source Software Center diff --git a/src/backend/replication/syncrep.c b/src/backend/replication/syncrep.c index 088f7b6..148756d

Re: [HACKERS] [BUG] False indication in pg_stat_replication.sync_state

2012-10-19 Thread Kyotaro HORIGUCHI
not sure of that. regards, -- Kyotaro Horiguchi NTT Open Source Software Center diff --git a/src/backend/replication/syncrep.c b/src/backend/replication/syncrep.c index 088f7b6..6caf586 100644 --- a/src/backend/replication/syncrep.c +++ b/src/backend/replication/syncrep.c @@ -46,6 +46,7

Re: [HACKERS] Reduce palloc's in numeric operations.

2012-11-12 Thread Kyotaro HORIGUCHI
Thanks for comments, Have to be careful to really not modify the operands. numeric_out() and numeric_out_sci() are wrong; they call get_str_from_var(), which modifies the argument. Same with numeric_expr(): it passes the argument to numericvar_to_double_no_overflow(), which passes it to

Re: [HACKERS] Identity projection

2012-11-12 Thread Kyotaro HORIGUCHI
test posted before in order to show the source of the gain. regards, -- -- Kyotaro Horiguchi NTT Open Source Software Center At Fri, 05 Oct 2012 16:04:16 +0900, Kyotaro HORIGUCHI wrote in 20121005.160416.256387378.horiguchi.kyot...@lab.ntt.co.jp Although I said as following, the gain seems

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-03-23 Thread Kyotaro HORIGUCHI
these for this go-round, and to stick to providing the features that we can test via the dblink patch. Testing pqGetRow via dblink? Do you mean 'drop these' as pqGetRow? So, this part might be droppable apart from the rest. regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-03-26 Thread Kyotaro HORIGUCHI
dblink_use_rowproc_20120326.patch - dblink row processor patch. dblink_connname_20120326.patch- dblink connname fix patch. regards, -- Kyotaro Horiguchi NTT Open Source Software Center diff --git a/contrib/dblink/dblink.c b/contrib/dblink/dblink.c index 36a8e3e..dd73aa5 100644 --- a/contrib/dblink

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-03-26 Thread Kyotaro HORIGUCHI
I'm sorry to have coded a silly bug. The previous patch has a bug in realloc size calculation. And separation of the 'connname patch' was incomplete in regtest. It is fixed in this patch. regards, -- Kyotaro Horiguchi NTT Open Source Software Center diff --git a/contrib/dblink/dblink.c b

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-03-29 Thread Kyotaro HORIGUCHI
be dropped for this time and done another time. I'am sorry for bothering you by such a damn thing. regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-04-04 Thread Kyotaro HORIGUCHI
processor that couldn't know what to do until after the entire query result is received. I hope so. Thank you. regards, -- Kyotaro Horiguchi NTT Open Source Software Center dblink_rowproc_20120405.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-04-04 Thread Kyotaro HORIGUCHI
I'm afraid not re-initializing materialize_needed for the next query in the latest dblink patch. I will confirm that and send the another one if needed in a few hours. # I need to catch the train I usually get on.. Hello, This is the new version of dblink patch. regards, -- Kyotaro Horiguchi

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-04-04 Thread Kyotaro HORIGUCHI
not being used is interesting enough to justify contorting the logic, and I'm worried about introducing corner case bugs for that. I'm afraid of indefinite state by mixing sync and async queries or API call sequence for async query out of my expectations (which is rather narrow). regards, -- Kyotaro

Re: [HACKERS] pgsql_fdw, FDW for PostgreSQL server

2012-04-06 Thread Kyotaro HORIGUCHI
of FDW author, I think that row sampling (acquire_sample_rows) function seems handy place to hook. regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

[HACKERS] [BUG] Checkpointer on hot standby runs without looking checkpoint_segments

2012-04-16 Thread Kyotaro HORIGUCHI
be for GetWalRcvWriteRecPtr() on 9.1.3. However, it seems to work fine on a simple test. regards, -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail address has been changed since Apr. 1, 2012. diff --git a/src/backend/postmaster/checkpointer.c b/src/backend/postmaster/checkpointer.c

[HACKERS] A typo fix in a comment in xlog.c

2012-04-16 Thread Kyotaro HORIGUCHI
fill-paragraph for the fixed comment so the patch replaces a little bit more. regards, -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail address has been changed since Apr. 1, 2012. diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index 0c301b2

Re: [HACKERS] A typo fix in a comment in xlog.c

2012-04-16 Thread Kyotaro HORIGUCHI
code and comments. -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail address has been changed since Apr. 1, 2012. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [BUG] Checkpointer on hot standby runs without looking checkpoint_segments

2012-04-16 Thread Kyotaro HORIGUCHI
for this comment be too short... Typo: RedoRecptr should be RedoRecPtr? I think that's right. I've unconsciously brought that spelling from the orignal comment. regards, -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail address has been changed since Apr. 1, 2012. -- Sent

Re: [HACKERS] [BUG] Checkpointer on hot standby runs without looking checkpoint_segments

2012-04-17 Thread Kyotaro HORIGUCHI
= replayPtr = receivePtr But XLByteLT(recievePtr, replayPtr) this should not return true under the condition above.. Something wrong in my assumption? Anyway, I understand here that you say the location returned by GetXLogReplayRecPtr() is always flushed. -- Kyotaro Horiguchi NTT Open Source

Re: [HACKERS] [BUG] Checkpointer on hot standby runs without looking checkpoint_segments

2012-04-17 Thread Kyotaro HORIGUCHI
of the sync_state. regards, -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail address has been changed since Apr. 1, 2012. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [BUG] Checkpointer on hot standby runs without looking checkpoint_segments

2012-04-17 Thread Kyotaro HORIGUCHI
it is possible using StandbyMode in IsCheckpointOnSchedule(), I suppose. I will correct the patch later. regards, -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail address has been changed since Apr. 1, 2012. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] [BUG] Checkpointer on hot standby runs without looking checkpoint_segments

2012-04-17 Thread Kyotaro HORIGUCHI
Hello, this message is attached with the patch which did not tested. That is for show the way. On Tue, Apr 17, 2012 at 9:38 PM, Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp wrote: But I think referring checkpoint_segment on such case should be inhibited, and I suppose it is possible using

Re: [HACKERS] [BUG] Checkpointer on hot standby runs without looking checkpoint_segments

2012-04-17 Thread Kyotaro HORIGUCHI
the condition above.. Something wrong in my assumption? regards, -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail address has been changed since Apr. 1, 2012. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] [BUG] Checkpointer on hot standby runs without looking checkpoint_segments

2012-04-18 Thread Kyotaro HORIGUCHI
= receivePtr? - If correct, what the code in GetStandbyFlushRecPtr() showing below means? if (XLByteLT(receivePtr, replayPtr)) - Or if wrong, what situation would take place to break the expression restorePtr = replayPtr = receivePtr? regards, -- Kyotaro Horiguchi NTT Open Source Software

Re: [HACKERS] [BUG] Checkpointer on hot standby runs without looking checkpoint_segments

2012-04-18 Thread Kyotaro HORIGUCHI
Hello, this is new version of standby checkpoint_segments patch. - xlog.c: Make StandbyMode shared. - checkpointer.c: Use IsStandbyMode() to check if postmaster is under standby mode. regards, -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail address has been changed

Re: [HACKERS] [BUG] Checkpointer on hot standby runs without looking checkpoint_segments

2012-04-24 Thread Kyotaro HORIGUCHI
, + * XLogInsert that actually triggers a checkpoint when Currently a checkpoint is triggered by XLogWrite (not XLogInsert), the above needs to be corrected. I will be carefull for such outdated description. regards, -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail

Re: [HACKERS] [BUG] Checkpointer on hot standby runs without looking checkpoint_segments

2012-04-27 Thread Kyotaro HORIGUCHI
, -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail address has been changed since Apr. 1, 2012. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [BUG] Checkpointer on hot standby runs without looking checkpoint_segments

2012-04-27 Thread Kyotaro HORIGUCHI
currently, I'm not sure, but at least it needs to be discussed. Would be good to do some performance testing of recovery with various checkpoint_segments and _timeout settings, with and without this patch. regards, -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail address

Re: [HACKERS] [BUG] Checkpointer on hot standby runs without looking checkpoint_segments

2012-04-27 Thread Kyotaro HORIGUCHI
of maintenancibility (suspicious-proof expression?), it may be preferable that the manner to read shared memory be uniform whole source code if no particular reasons. regards, -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail address has been changed since Apr. 1, 2012. -- Sent via

Re: [HACKERS] [BUG] Checkpointer on hot standby runs without looking checkpoint_segments

2012-05-13 Thread Kyotaro HORIGUCHI
and retrogression to the code and behavior, nevertheless it won't solve the half of the problem. I don't yet understand about cascading replication enough, but I suppose erasing WALs as becoming out of use (by some logic I don't find yet) is hopeful. regards, -- Kyotaro Horiguchi NTT Open Source

Re: [HACKERS] [BUG] Checkpointer on hot standby runs without looking checkpoint_segments

2012-05-16 Thread Kyotaro HORIGUCHI
Hello, On Sun, May 13, 2012 at 10:38 PM, Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp wrote: I've overlooked that startup process of the standby reads archives first, and then WAL. But the current patch enables progress governing based on checkpoint_segments during archive recovery

[HACKERS] Checkpointer on hot standby runs without looking checkpoint_segments

2012-06-08 Thread Kyotaro HORIGUCHI
. - Determine whether to delay checkpoint by GetLogReplayRecPtr() instead of GetInsertRecPtr() when WalRcvStarted() says true. regards, -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail address has been changed since Apr. 1, 2012. diff --git a/src/backend/postmaster/checkpointer.c b

[HACKERS] Skip checkpoint on promoting from streaming replication

2012-06-08 Thread Kyotaro HORIGUCHI
() introduced by my another patch. http://archives.postgresql.org/pgsql-hackers/2012-06/msg00287.php regards, -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail address has been changed since Apr. 1, 2012. diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam

Re: [HACKERS] Skip checkpoint on promoting from streaming replication

2012-06-11 Thread Kyotaro HORIGUCHI
failed to find that discussion. Could you let me have a pointer to that? Of cource I'd be very happy if the checkpoints are completely avoided on the approach. regards, -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail address has been changed since Apr. 1, 2012. -- Sent via

Re: [HACKERS] Skip checkpoint on promoting from streaming replication

2012-06-12 Thread Kyotaro HORIGUCHI
that..) Discussion on a patch submitted to me to the Januray 2012 CommitFest to reduce failover time. Thank you and I'm sorry for missing it. I've found that discussions and read them from now. regards, -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail address has been changed since

Re: [HACKERS] Skip checkpoint on promoting from streaming replication

2012-06-18 Thread Kyotaro HORIGUCHI
think about this? regards, -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail address has been changed since Apr. 1, 2012. diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index 0d68760..70b4972 100644 --- a/src/backend/access/transam/xlog.c +++ b

Re: [HACKERS] Skip checkpoint on promoting from streaming replication

2012-06-19 Thread Kyotaro HORIGUCHI
. So the crash recovery sequence won't stop before reaching the WAL with new TLI disignated in the control file. regards, -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail address has been changed since Apr. 1, 2012. -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] pl/perl and utf-8 in sql_ascii databases

2012-06-21 Thread Kyotaro HORIGUCHI
regardless of the real encoding. But # plper_lc_*.(sql|out) increases if the bug is fixed. regards, -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail address has been changed since Apr. 1, 2012. diff --git a/src/pl/plperl/Util.xs b/src/pl/plperl/Util.xs index 7d0102b..4b4b680

Re: [HACKERS] pl/perl and utf-8 in sql_ascii databases

2012-06-21 Thread Kyotaro HORIGUCHI
as encoding UTF8 not encoding for output.. So the regtest patch covers all of possible patterns - UTF8 and SQL_ASCII.. regards, -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail address has been changed since Apr. 1, 2012. -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Skip checkpoint on promoting from streaming replication

2012-06-21 Thread Kyotaro HORIGUCHI
to the existing or induces the labor to weave new function into existing code. Furthurmore, this seems to take certain time on promotion (or end of recovery). The discussion about temporary wal files would be the same to 1. regards, -- Kyotaro Horiguchi NTT Open Source Software Center

Re: [HACKERS] pl/perl and utf-8 in sql_ascii databases

2012-06-22 Thread Kyotaro HORIGUCHI
managed by git. -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail address has been changed since Apr. 1, 2012. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pl/perl and utf-8 in sql_ascii databases

2012-06-22 Thread Kyotaro HORIGUCHI
a single test and two expected files. That seems simpler than messing around in the makefile. Yes, you're right. But it was easier to add pairs of .sql and .out to do that. Plus, as I wrote in another message, I'm unwilling to push it nevertheless I've wrote it:-( -- Kyotaro Horiguchi NTT Open

Re: [HACKERS] pl/perl and utf-8 in sql_ascii databases

2012-06-27 Thread Kyotaro HORIGUCHI
. It will be easily ported into 9.1 and 9.2 and there seems to be no problem technically, but a bit unsure from the other points of view... regards, -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail address has been changed since Apr. 1, 2012. -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Checkpointer on hot standby runs without looking checkpoint_segments

2012-07-02 Thread Kyotaro HORIGUCHI
be smarter to make better balance between disk usage and performance, I accept the judgement to drop this. Thank you. regards, -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail address has been changed since Apr. 1, 2012. -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] pl/perl and utf-8 in sql_ascii databases

2012-07-03 Thread Kyotaro HORIGUCHI
-D pgdata dir ... same as 4.1 here after... -- Kyotaro Horiguchi NTT Open Source Software Center == My e-mail address has been changed since Apr. 1, 2012. diff --git a/src/pl/plperl/Util.xs b/src/pl/plperl/Util.xs index 7d0102b..4b4b680 100644 --- a/src/pl/plperl/Util.xs +++ b/src/pl/plperl

Re: [HACKERS] make_greater_string() does not return a string in some cases

2011-07-08 Thread Kyotaro HORIGUCHI
for all BMP characters) remains, and none of them are not Japanese character :-) The attached patch is sample implement of this idea. What do you think about this patch? -- Kyotaro Horiguchi NTT Open Source Software Center diff --git a/src/backend/utils/adt/selfuncs.c b/src/backend/utils/adt

Re: [HACKERS] [BUGS] make_greater_string() does not return a string in some cases

2011-07-11 Thread Kyotaro HORIGUCHI
Thanks for your suggestion, I'll do so. At Fri, 8 Jul 2011 23:28:32 -0400, Robert Haas robertmh...@gmail.com wrote: Please add your patch to the next CommitFest. https://commitfest.postgresql.org/action/commitfest_view/open -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via

Re: [HACKERS] make_greater_string() does not return a string in some cases

2011-07-12 Thread Kyotaro HORIGUCHI
This is an update of a patch for NEXT CommitFest 2011/09. Please ignore this message. 1 Additional Feature - EUC-JP incrementer 2 Bug fixes - bytea incrementer, libpq compilation. -- Kyotaro Horiguchi NTT Open Source Software Center diff --git a/src/backend/utils/adt/selfuncs.c b/src/backend

Re: [HACKERS] Identity projection

2013-02-12 Thread Kyotaro HORIGUCHI
will check in more detail before sending patch. With best regards, -- Kyotaro Horiguchi -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] 9.2.3 crashes during archive recovery

2013-02-12 Thread Kyotaro HORIGUCHI
should slow the transactions.. Regards, -- Kyotaro Horiguchi NTT Open Source Software Center == Replay script. #! /bin/sh PGDATA=$HOME/pgdata PGARC=$HOME/pgarc rm -rf $PGDATA/* $PGARC/* initdb cat $PGDATA/postgresql.conf EOF wal_level = hot_standby checkpoint_segments = 300

Re: [HACKERS] Identity projection

2013-02-15 Thread Kyotaro HORIGUCHI
that? Regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] 9.2.3 crashes during archive recovery

2013-02-15 Thread Kyotaro HORIGUCHI
recovery from that, that's essentially the same thing as Kyotaro's test case. Regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

Re: [HACKERS] 9.2.3 crashes during archive recovery

2013-02-19 Thread Kyotaro HORIGUCHI
it 'checkpoint xmin'. - vacuum skips the modification by the transactions at the same time or after the checkpoint xmin. What do you think of this? -- Kyotaro Horiguchi NTT Open Source Software Center = diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c

Re: [HACKERS] Identity projection

2013-02-19 Thread Kyotaro HORIGUCHI
I have updated the patch as per comments from Tom and Heikki. If you can verify it, then IMO it can be marked as 'Ready For Committer' Would you please do that? Done. Thank you. regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing

Re: [HACKERS] 9.2.3 crashes during archive recovery

2013-02-20 Thread Kyotaro HORIGUCHI
time or after the checkpoint xmin. -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] 9.2.3 crashes during archive recovery

2013-02-25 Thread Kyotaro HORIGUCHI
Hello, Anyway, I've committed this to master and 9.2 now. This seems to fix the issue. We'll examine this further. Thank you. -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

  1   2   3   4   5   6   7   8   9   10   >