Re: [HACKERS] ALTER SYSTEM RESET?

2014-09-12 Thread Fujii Masao
On Wed, Sep 10, 2014 at 9:06 PM, Fujii Masao wrote: > On Wed, Sep 3, 2014 at 12:08 AM, Christoph Berg wrote: >> Re: Vik Fearing 2014-09-02 <5405d2d9.9050...@dalibo.com> >>> > Uhm, are we agreed on the decision on not to backpatch this? I would >>> > think this should have been part of the initia

Re: [HACKERS] ALTER SYSTEM RESET?

2014-09-10 Thread Fujii Masao
On Wed, Sep 3, 2014 at 12:08 AM, Christoph Berg wrote: > Re: Vik Fearing 2014-09-02 <5405d2d9.9050...@dalibo.com> >> > Uhm, are we agreed on the decision on not to backpatch this? I would >> > think this should have been part of the initial ALTER SYSTEM SET patch >> > and thus should be backpatch

Re: [HACKERS] ALTER SYSTEM RESET?

2014-09-02 Thread Christoph Berg
Re: Vik Fearing 2014-09-02 <5405d2d9.9050...@dalibo.com> > > Uhm, are we agreed on the decision on not to backpatch this? I would > > think this should have been part of the initial ALTER SYSTEM SET patch > > and thus should be backpatched to 9.4. > > I think it belongs in 9.4 as well, especially

Re: [HACKERS] ALTER SYSTEM RESET?

2014-09-02 Thread Vik Fearing
On 09/02/2014 04:12 PM, Alvaro Herrera wrote: > Fujii Masao wrote: >> On Mon, Sep 1, 2014 at 10:54 PM, Amit Kapila wrote: >>> On Mon, Sep 1, 2014 at 3:57 PM, Fujii Masao wrote: On Sat, Aug 30, 2014 at 12:27 PM, Amit Kapila wrote: > On Wed, Aug 27, 2014 at 7:16 PM, Fujii Masao

Re: [HACKERS] ALTER SYSTEM RESET?

2014-09-02 Thread Alvaro Herrera
Fujii Masao wrote: > On Mon, Sep 1, 2014 at 10:54 PM, Amit Kapila wrote: > > On Mon, Sep 1, 2014 at 3:57 PM, Fujii Masao wrote: > >> > >> On Sat, Aug 30, 2014 at 12:27 PM, Amit Kapila > >> wrote: > >> > On Wed, Aug 27, 2014 at 7:16 PM, Fujii Masao > >> > wrote: > >> >> The patch looks good to m

Re: [HACKERS] ALTER SYSTEM RESET?

2014-09-02 Thread Fujii Masao
On Mon, Sep 1, 2014 at 10:54 PM, Amit Kapila wrote: > On Mon, Sep 1, 2014 at 3:57 PM, Fujii Masao wrote: >> >> On Sat, Aug 30, 2014 at 12:27 PM, Amit Kapila >> wrote: >> > On Wed, Aug 27, 2014 at 7:16 PM, Fujii Masao >> > wrote: >> >> The patch looks good to me. One minor comment is; probably y

Re: [HACKERS] ALTER SYSTEM RESET?

2014-09-01 Thread Amit Kapila
On Mon, Sep 1, 2014 at 3:57 PM, Fujii Masao wrote: > > On Sat, Aug 30, 2014 at 12:27 PM, Amit Kapila wrote: > > On Wed, Aug 27, 2014 at 7:16 PM, Fujii Masao wrote: > >> The patch looks good to me. One minor comment is; probably you need to > >> update the tab-completion code. > > > > Thanks for

Re: [HACKERS] ALTER SYSTEM RESET?

2014-09-01 Thread Fujii Masao
On Sat, Aug 30, 2014 at 12:27 PM, Amit Kapila wrote: > On Wed, Aug 27, 2014 at 7:16 PM, Fujii Masao wrote: >> The patch looks good to me. One minor comment is; probably you need to >> update the tab-completion code. > > Thanks for the review. I have updated the patch to support > tab-completion.

Re: [HACKERS] ALTER SYSTEM RESET?

2014-08-29 Thread Amit Kapila
On Wed, Aug 27, 2014 at 7:16 PM, Fujii Masao wrote: > The patch looks good to me. One minor comment is; probably you need to > update the tab-completion code. Thanks for the review. I have updated the patch to support tab-completion. As this is a relatively minor change, I will mark it as "Ready

Re: [HACKERS] ALTER SYSTEM RESET?

2014-08-27 Thread Fujii Masao
On Mon, Aug 25, 2014 at 1:34 PM, Amit Kapila wrote: > On Wed, Jul 30, 2014 at 9:11 AM, Amit Kapila > wrote: >> I have verified the patch and found that it works well for >> all scenario's. Few minor suggestions: >> >> 1. >> !values to the postgresql.auto.conf file. >> !Setting the parame

Re: [HACKERS] ALTER SYSTEM RESET?

2014-08-24 Thread Amit Kapila
On Wed, Jul 30, 2014 at 9:11 AM, Amit Kapila wrote: > I have verified the patch and found that it works well for > all scenario's. Few minor suggestions: > > 1. > !values to the postgresql.auto.conf file. > !Setting the parameter to DEFAULT, or using the > !RESET variant, removes the

Re: [HACKERS] ALTER SYSTEM RESET?

2014-07-29 Thread Amit Kapila
On Thu, Jun 26, 2014 at 8:17 PM, Vik Fearing wrote: > I didn't quite follow your ALTER TABLE example because I don't think > it's necessary, I was asking to split the ALTER SYSTEM command like it's there for ALTER TABLE (AlterTableStmt: ALTER TABLE relation_expr alter_table_cmds). It would have ma

Re: [HACKERS] ALTER SYSTEM RESET?

2014-06-28 Thread Amit Kapila
On Sat, Jun 28, 2014 at 10:38 PM, Christoph Berg wrote: > Re: Vik Fearing 2014-06-27 <53ad15f7.2060...@dalibo.com> > > Amit, > > > > I added this to the next commitfest with your name as reviewer. > > > > https://commitfest.postgresql.org/action/patch_view?id=1495 > > > > Please update the status

Re: [HACKERS] ALTER SYSTEM RESET?

2014-06-28 Thread Christoph Berg
Re: Vik Fearing 2014-06-27 <53ad15f7.2060...@dalibo.com> > On 06/27/2014 08:49 AM, Vik Fearing wrote: > > This third patch reformats the documentation in the way I expected it to > > be committed. > > Amit, > > I added this to the next commitfest with your name as reviewer. > > https://commitfes

Re: [HACKERS] ALTER SYSTEM RESET?

2014-06-27 Thread Amit Kapila
On Fri, Jun 27, 2014 at 12:27 PM, Vik Fearing wrote: > On 06/27/2014 08:49 AM, Vik Fearing wrote: > > This third patch reformats the documentation in the way I expected it to > > be committed. > > Amit, > > I added this to the next commitfest with your name as reviewer. No issues, I will review i

Re: [HACKERS] ALTER SYSTEM RESET?

2014-06-26 Thread Vik Fearing
On 06/27/2014 08:49 AM, Vik Fearing wrote: > This third patch reformats the documentation in the way I expected it to > be committed. Amit, I added this to the next commitfest with your name as reviewer. https://commitfest.postgresql.org/action/patch_view?id=1495 Please update the status as you

Re: [HACKERS] ALTER SYSTEM RESET?

2014-06-26 Thread Vik Fearing
On 06/27/2014 06:22 AM, Amit Kapila wrote: > On Thu, Jun 26, 2014 at 8:17 PM, Vik Fearing > wrote: >> On 06/26/2014 05:07 AM, Amit Kapila wrote: >> > I think it will make sense if we support RESET ALL as well similar >> > to Alter Database .. RESET ALL syntax. Do yo

Re: [HACKERS] ALTER SYSTEM RESET?

2014-06-26 Thread Amit Kapila
On Thu, Jun 26, 2014 at 8:17 PM, Vik Fearing wrote: > On 06/26/2014 05:07 AM, Amit Kapila wrote: > > I think it will make sense if we support RESET ALL as well similar > > to Alter Database .. RESET ALL syntax. Do you see any reason > > why we shouldn't support RESET ALL syntax for Alter System?

Re: [HACKERS] ALTER SYSTEM RESET?

2014-06-26 Thread Vik Fearing
On 06/26/2014 05:07 AM, Amit Kapila wrote: > On Wed, Jun 25, 2014 at 9:56 PM, Vik Fearing > wrote: >> On 06/25/2014 03:04 PM, Amit Kapila wrote: >> > Currently you can achieve that by >> > "ALTER SYSTEM RESET guc = Default;". >> > However it will be good to have supp

Re: [HACKERS] ALTER SYSTEM RESET?

2014-06-26 Thread Christoph Berg
Re: Amit Kapila 2014-06-26 > On Wed, Jun 25, 2014 at 9:56 PM, Vik Fearing wrote: > > On 06/25/2014 03:04 PM, Amit Kapila wrote: > > > Currently you can achieve that by > > > "ALTER SYSTEM RESET guc = Default;". > > > However it will be good to have support for RESET as well. I think it > > > sh

Re: [HACKERS] ALTER SYSTEM RESET?

2014-06-25 Thread Amit Kapila
On Wed, Jun 25, 2014 at 9:56 PM, Vik Fearing wrote: > On 06/25/2014 03:04 PM, Amit Kapila wrote: > > Currently you can achieve that by > > "ALTER SYSTEM RESET guc = Default;". > > However it will be good to have support for RESET as well. I think it > > should not be too complicated to implement

Re: [HACKERS] ALTER SYSTEM RESET?

2014-06-25 Thread Fabrízio de Royes Mello
On Wed, Jun 25, 2014 at 1:26 PM, Vik Fearing wrote: > On 06/25/2014 03:04 PM, Amit Kapila wrote: > > On Wed, Jun 25, 2014 at 6:20 PM, Christoph Berg > > wrote: > >> > >> Hi, > >> > >> is there a reason there's no ALTER SYSTEM RESET? > >> > >> The natural idiom to reset SET

Re: [HACKERS] ALTER SYSTEM RESET?

2014-06-25 Thread Vik Fearing
On 06/25/2014 03:04 PM, Amit Kapila wrote: > On Wed, Jun 25, 2014 at 6:20 PM, Christoph Berg > wrote: >> >> Hi, >> >> is there a reason there's no ALTER SYSTEM RESET? >> >> The natural idiom to reset SET statements is "RESET guc;", I don't >> think "SET guc = default;" is in

Re: [HACKERS] ALTER SYSTEM RESET?

2014-06-25 Thread Fabrízio de Royes Mello
On Wed, Jun 25, 2014 at 10:04 AM, Amit Kapila wrote: > > On Wed, Jun 25, 2014 at 6:20 PM, Christoph Berg wrote: > > > > Hi, > > > > is there a reason there's no ALTER SYSTEM RESET? > > > > The natural idiom to reset SET statements is "RESET guc;", I don't > > think "SET guc = default;" is in use

Re: [HACKERS] ALTER SYSTEM RESET?

2014-06-25 Thread Amit Kapila
On Wed, Jun 25, 2014 at 6:20 PM, Christoph Berg wrote: > > Hi, > > is there a reason there's no ALTER SYSTEM RESET? > > The natural idiom to reset SET statements is "RESET guc;", I don't > think "SET guc = default;" is in use much, so "ALTER SYSTEM RESET guc;" > would be the natural way to try. C

[HACKERS] ALTER SYSTEM RESET?

2014-06-25 Thread Christoph Berg
Hi, is there a reason there's no ALTER SYSTEM RESET? The natural idiom to reset SET statements is "RESET guc;", I don't think "SET guc = default;" is in use much, so "ALTER SYSTEM RESET guc;" would be the natural way to try. Also, ALTER SYSTEM SET/RESET seems to be what oracle does: http://docs.