Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-12-05 Thread Craig Ringer 
On 5 December 2016 at 19:17, Dagfinn Ilmari Mannsåker  wrote:

> This is not the correct invocation of cpanm: it just takes a list of
> module names.  This will pull in the 'install' module, which is
> harmless, but unnecessary: https://metacpan.org/pod/install.

Ha. Good catch. Since, as you noted, it's harmless I didn't realise
it'd happened.

-- 
 Craig Ringer   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-12-05 Thread Dagfinn Ilmari Mannsåker 
Noah Misch  writes:

> On Mon, Nov 21, 2016 at 05:37:50PM +0900, Kyotaro HORIGUCHI wrote:
>> At Mon, 21 Nov 2016 16:45:10 +0900, Michael Paquier 
>>  wrote in 
>> 
>> > No objections to this version. It's a good idea to document that.
>> 
>> +1
>
> Committed after re-filling paragraphs.

I just noticed this bit in the committed patch:

+cpanm install IPC::Run

This is not the correct invocation of cpanm: it just takes a list of
module names.  This will pull in the 'install' module, which is
harmless, but unnecessary: https://metacpan.org/pod/install.

-- 
"I use RMS as a guide in the same way that a boat captain would use
 a lighthouse.  It's good to know where it is, but you generally
 don't want to find yourself in the same spot." - Tollef Fog Heen


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-12-04 Thread Michael Paquier 
On Sun, Dec 4, 2016 at 2:28 PM, Noah Misch  wrote:
> Committed after re-filling paragraphs.

Thanks, I have updated the CF entry as well.
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-12-03 Thread Noah Misch 
On Mon, Nov 21, 2016 at 11:58:34AM +0800, Craig Ringer wrote:
> Updated docs patch. Since configure checks for 5.8.0 that's what's
> specified. Anyone who wants to argue about the actual version we
> _should_ target can do so elsewhere, all I'm interested in is what we
> _do_ officially target so I can document this.

That's a proper separation of efforts; thanks.

On Mon, Nov 21, 2016 at 05:37:50PM +0900, Kyotaro HORIGUCHI wrote:
> At Mon, 21 Nov 2016 16:45:10 +0900, Michael Paquier 
>  wrote in 
> 
> > No objections to this version. It's a good idea to document that.
> 
> +1

Committed after re-filling paragraphs.


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-21 Thread Kyotaro HORIGUCHI 
At Mon, 21 Nov 2016 16:45:10 +0900, Michael Paquier  
wrote in 
> > Fixed in attached.
> 
> No objections to this version. It's a good idea to document that.

+1

regards,

-- 
Kyotaro Horiguchi
NTT Open Source Software Center




-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-20 Thread Michael Paquier 
On Mon, Nov 21, 2016 at 3:38 PM, Craig Ringer  wrote:
> On 21 November 2016 at 12:23, Kyotaro HORIGUCHI
>  wrote:
>> I understand you :p By the way, the new doc points to
>> http://install.perlbrew.pl and it just shows the install
>> script. It seems more puzzling..
>>
>> I suppose https://perlbrew.pl/ seems to me the primary site for
>> perbrew.
>
> Oops!
>
> Fixed in attached.

No objections to this version. It's a good idea to document that.
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-20 Thread Craig Ringer 
On 21 November 2016 at 12:23, Kyotaro HORIGUCHI
 wrote:
> Hello,
>
> At Mon, 21 Nov 2016 11:58:34 +0800, Craig Ringer  
> wrote in 
>> On 18 November 2016 at 08:15, Craig Ringer  wrote:
>> > On 18 November 2016 at 07:10, Michael Paquier  
>> > wrote:
>> >> On Thu, Nov 17, 2016 at 2:39 PM, Craig Ringer  
>> >> wrote:
>> >>> I wasted a bunch of time getting set up to test for such an ancient
>> >>> Perl and would love to save the next person along the hassle by
>> >>> documenting the easy way.
>> >>
>> >> It looks sensible to mention that in the README, so +1.
>
> I appreciate the labor. Anyway I don't object for adding that to
> the README. +1.

Thanks.

> I understand you :p By the way, the new doc points to
> http://install.perlbrew.pl and it just shows the install
> script. It seems more puzzling..
>
> I suppose https://perlbrew.pl/ seems to me the primary site for
> perbrew.

Oops!

Fixed in attached.

-- 
 Craig Ringer   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services
From e9a654aebd76abeadd5bc592191f8b01bce3716e Mon Sep 17 00:00:00 2001
From: Craig Ringer 
Date: Tue, 15 Nov 2016 15:45:41 +0800
Subject: [PATCH] Document that perl 5.8.0 is required

---
 src/test/perl/README | 18 ++
 1 file changed, 18 insertions(+)

diff --git a/src/test/perl/README b/src/test/perl/README
index cfb45a1..0732cac 100644
--- a/src/test/perl/README
+++ b/src/test/perl/README
@@ -64,3 +64,21 @@ For available PostgreSQL-specific test methods and some example tests read the
 perldoc for the test modules, e.g.:
 
 perldoc src/test/perl/PostgresNode.pm
+
+Required Perl
+-
+
+Tests must run on perl 5.8.0 and newer. perlbrew is a good way to obtain
+such a Perl; see http://perlbrew.pl .
+
+Just install and
+
+perlbrew --force install 5.8.0
+perlbrew use 5.8.0
+perlbrew install-cpanm
+cpanm install IPC::Run
+
+then re-run configure to ensure the correct Perl is used when running tests. To verify
+that the right Perl was found:
+
+grep ^PERL= config.log
-- 
2.5.5


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-20 Thread Kyotaro HORIGUCHI 
Hello,

At Mon, 21 Nov 2016 11:58:34 +0800, Craig Ringer  wrote 
in 
> On 18 November 2016 at 08:15, Craig Ringer  wrote:
> > On 18 November 2016 at 07:10, Michael Paquier  
> > wrote:
> >> On Thu, Nov 17, 2016 at 2:39 PM, Craig Ringer  
> >> wrote:
> >>> I wasted a bunch of time getting set up to test for such an ancient
> >>> Perl and would love to save the next person along the hassle by
> >>> documenting the easy way.
> >>
> >> It looks sensible to mention that in the README, so +1.

I appreciate the labor. Anyway I don't object for adding that to
the README. +1.

> >> By the way, would it matter to mention ways to install perlbrew? For
> >> example, I just bumped into http://install.perlbrew.pl by looking
> >> around, though I don't doubt that most people would just use cpan with
> >> "install App::perlbrew" for example. For OSX users with brew and
> >> without macports that would matter.
> >
> > The docs linked mention it, so I figured that'd probably do. Though I
> > notice it's only mentioned in the "configuration" section not under
> > "installation", so maybe it's worth adding yeah.
> 
> Updated docs patch. Since configure checks for 5.8.0 that's what's
> specified. Anyone who wants to argue about the actual version we
> _should_ target can do so elsewhere, all I'm interested in is what we
> _do_ officially target so I can document this.

I understand you :p By the way, the new doc points to
http://install.perlbrew.pl and it just shows the install
script. It seems more puzzling..

I suppose https://perlbrew.pl/ seems to me the primary site for
perbrew.


| Perlbrew
| 
| perlbrew is an admin-free perl installation management tool. The latest 
version is 0.78, read the release note: Release 0.78.
| 
| Install, quickly
| 
| Copy & Paste this line into your terminal:
| 
| \curl -L https://install.perlbrew.pl | bash

regards,

-- 
Kyotaro Horiguchi
NTT Open Source Software Center




-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-20 Thread Craig Ringer 
On 18 November 2016 at 08:15, Craig Ringer  wrote:
> On 18 November 2016 at 07:10, Michael Paquier  
> wrote:
>> On Thu, Nov 17, 2016 at 2:39 PM, Craig Ringer  wrote:
>>> I wasted a bunch of time getting set up to test for such an ancient
>>> Perl and would love to save the next person along the hassle by
>>> documenting the easy way.
>>
>> It looks sensible to mention that in the README, so +1.
>>
>> By the way, would it matter to mention ways to install perlbrew? For
>> example, I just bumped into http://install.perlbrew.pl by looking
>> around, though I don't doubt that most people would just use cpan with
>> "install App::perlbrew" for example. For OSX users with brew and
>> without macports that would matter.
>
> The docs linked mention it, so I figured that'd probably do. Though I
> notice it's only mentioned in the "configuration" section not under
> "installation", so maybe it's worth adding yeah.

Updated docs patch. Since configure checks for 5.8.0 that's what's
specified. Anyone who wants to argue about the actual version we
_should_ target can do so elsewhere, all I'm interested in is what we
_do_ officially target so I can document this.

-- 
 Craig Ringer   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services
From e659e76ed2a1049ce5f7428fb6a8ef9deaef3ca6 Mon Sep 17 00:00:00 2001
From: Craig Ringer 
Date: Tue, 15 Nov 2016 15:45:41 +0800
Subject: [PATCH] Document that perl 5.8.0 is required

---
 src/test/perl/README | 18 ++
 1 file changed, 18 insertions(+)

diff --git a/src/test/perl/README b/src/test/perl/README
index cfb45a1..d2550a9 100644
--- a/src/test/perl/README
+++ b/src/test/perl/README
@@ -64,3 +64,21 @@ For available PostgreSQL-specific test methods and some example tests read the
 perldoc for the test modules, e.g.:
 
 perldoc src/test/perl/PostgresNode.pm
+
+Required Perl
+-
+
+Tests must run on perl 5.8.0 and newer. perlbrew is a good way to obtain
+such a Perl; see http://install.perlbrew.pl .
+
+Just install and
+
+perlbrew --force install 5.8.0
+perlbrew use 5.8.0
+perlbrew install-cpanm
+cpanm install IPC::Run
+
+then re-run configure to ensure the correct Perl is used when running tests. To verify
+that the right Perl was found:
+
+grep ^PERL= config.log
-- 
2.5.5


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-17 Thread Craig Ringer 
On 18 November 2016 at 07:10, Michael Paquier  wrote:
> On Thu, Nov 17, 2016 at 2:39 PM, Craig Ringer  wrote:
>> I wasted a bunch of time getting set up to test for such an ancient
>> Perl and would love to save the next person along the hassle by
>> documenting the easy way.
>
> It looks sensible to mention that in the README, so +1.
>
> By the way, would it matter to mention ways to install perlbrew? For
> example, I just bumped into http://install.perlbrew.pl by looking
> around, though I don't doubt that most people would just use cpan with
> "install App::perlbrew" for example. For OSX users with brew and
> without macports that would matter.

The docs linked mention it, so I figured that'd probably do. Though I
notice it's only mentioned in the "configuration" section not under
"installation", so maybe it's worth adding yeah.


-- 
 Craig Ringer   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-17 Thread Michael Paquier 
On Thu, Nov 17, 2016 at 2:39 PM, Craig Ringer  wrote:
> I wasted a bunch of time getting set up to test for such an ancient
> Perl and would love to save the next person along the hassle by
> documenting the easy way.

It looks sensible to mention that in the README, so +1.

By the way, would it matter to mention ways to install perlbrew? For
example, I just bumped into http://install.perlbrew.pl by looking
around, though I don't doubt that most people would just use cpan with
"install App::perlbrew" for example. For OSX users with brew and
without macports that would matter.
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-17 Thread Craig Ringer 
On 18 November 2016 at 05:41, Robert Haas  wrote:
> On Wed, Nov 16, 2016 at 9:54 PM, Craig Ringer  wrote:
>> On 17 November 2016 at 10:42, Craig Ringer  wrote:
>>> But sure, if it's easier, we can have 5.8.0 in the README. What's five
>>> extra years matter anyway? Hey, while we're at it, lets change Pg to
>>> build on Borland C and require K style!
>>
>> Sorry. That was unnecessary. I should've had the sense to save that as
>> a draft and come back later.
>
> Well, *I* thought it was pretty funny...
>
> I remember K style rather fondly.  Of course it was inferior
> technically, but if you could get things to compile that way you could
> feel like a wizard for being able to make the old compiler work.

Rather. I remember getting modern software to compile on SCO
OpenServer 5.0.5 that way. *Twich* *twitch*.

Anyway, here's an updated patch with version changed to 5.8.4 since
that's the newest we test on the buildfarm (and it's from 2004).

I wasted a bunch of time getting set up to test for such an ancient
Perl and would love to save the next person along the hassle by
documenting the easy way.

-- 
 Craig Ringer   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services
From 2a911dda796e88c88703095ad2f34cb73ccf919b Mon Sep 17 00:00:00 2001
From: Craig Ringer 
Date: Tue, 15 Nov 2016 15:45:41 +0800
Subject: [PATCH] Document that perl 5.8.4 is required for TAP tests

We don't test with anything older than Perl 5.8.4 in the buildfarm
and it's from 2004, so document that the TAP tests are expected to
work with Perl 5.8.4 and explain how to get it easily.

This does not affect configure tests; we'll still compile against
an older Perl 5.8.x if there's one in the wild.
---
 src/test/perl/README | 17 +
 1 file changed, 17 insertions(+)

diff --git a/src/test/perl/README b/src/test/perl/README
index cfb45a1..9c8bd05 100644
--- a/src/test/perl/README
+++ b/src/test/perl/README
@@ -64,3 +64,20 @@ For available PostgreSQL-specific test methods and some example tests read the
 perldoc for the test modules, e.g.:
 
 perldoc src/test/perl/PostgresNode.pm
+
+Required Perl
+-
+
+Tests must run on perl 5.8.4 and newer. perlbrew is a good way to obtain
+such a Perl; see https://metacpan.org/pod/distribution/App-perlbrew/bin/perlbrew .
+Just install and
+
+perlbrew --force install 5.8.4
+perlbrew use 5.8.4
+perlbrew install-cpanm
+cpanm install IPC::Run
+
+then re-run configure to ensure the correct Perl is used when running tests. To verify
+that the right Perl was found:
+
+grep ^PERL= config.log
-- 
2.5.5


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-17 Thread Robert Haas 
On Wed, Nov 16, 2016 at 9:54 PM, Craig Ringer  wrote:
> On 17 November 2016 at 10:42, Craig Ringer  wrote:
>> But sure, if it's easier, we can have 5.8.0 in the README. What's five
>> extra years matter anyway? Hey, while we're at it, lets change Pg to
>> build on Borland C and require K style!
>
> Sorry. That was unnecessary. I should've had the sense to save that as
> a draft and come back later.

Well, *I* thought it was pretty funny...

I remember K style rather fondly.  Of course it was inferior
technically, but if you could get things to compile that way you could
feel like a wizard for being able to make the old compiler work.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-16 Thread Craig Ringer 
On 17 November 2016 at 12:23, Michael Paquier  wrote:
> On Wed, Nov 16, 2016 at 6:54 PM, Craig Ringer  wrote:
>> In all seriousness, though, lets query the buildfarm database for Perl
>> versions. Let it answer.
>
> castoroides, Solaris 10 and perl 5.8.4, no?
> https://www.postgresql.org/message-id/20150415053842.ga2948...@tornado.leadboat.com

Thanks for checking.

Can we just add the README text with Perl 5.8.4 then? Or 5.8.0 or
3.005 or whatever version is determined to be the oldest needed?

-- 
 Craig Ringer   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-16 Thread Michael Paquier 
On Wed, Nov 16, 2016 at 6:54 PM, Craig Ringer  wrote:
> In all seriousness, though, lets query the buildfarm database for Perl
> versions. Let it answer.

castoroides, Solaris 10 and perl 5.8.4, no?
https://www.postgresql.org/message-id/20150415053842.ga2948...@tornado.leadboat.com
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-16 Thread Kyotaro HORIGUCHI 
Hello,

At Thu, 17 Nov 2016 11:59:02 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI 
 wrote in 
<20161117.115902.224922490.horiguchi.kyot...@lab.ntt.co.jp>
> My only concern is the fact that 'make check-world' runs the TAP
> tests as a part if --enable-tap-tests (according to
> release-9.4.sgml, but I haven't done by myself.). I completely
> agree to you if it didn't run as a part of top-level 'make  kind of check>'.

Hmm. I notice that older perls may reject installation of TAP. If
that's true, no check needed but a description also might be
needed to --enable-tap-tests. Or, might not be needed since
anyway it fails for the older versions.


diff --git a/doc/src/sgml/installation.sgml b/doc/src/sgml/installation.sgml
index 296611d..58459e5 100644
--- a/doc/src/sgml/installation.sgml
+++ b/doc/src/sgml/installation.sgml
@@ -1285,9 +1285,11 @@ su - postgres


 
- Enable tests using the Perl TAP tools.  This requires a Perl
- installation and the Perl module IPC::Run.
-  for more 
information.]]>
+ Enable tests using the Perl TAP tools.  This requires a Perl (5.8.8
+ or later) installation and the Perl
+ module IPC::Run.
+  for more
+ information.]]>
 

   

regards,

-- 
Kyotaro Horiguchi
NTT Open Source Software Center




-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-16 Thread Kyotaro HORIGUCHI 
At Thu, 17 Nov 2016 10:42:54 +0800, Craig Ringer  wrote 
in 
> On 17 November 2016 at 10:31, Kyotaro HORIGUCHI
>  wrote:
> 
> >
> > I vote +1 to upgrading perl, but I'm not sure if all supporting
> > platforms other than linux support the version of perl.
> >
> > Anyway ./configure is saying as the following.
> >
> > | *** The installed version of Perl, $PERL, is too old to use with 
> > PostgreSQL.
> > | *** Perl version 5.8 or later is required, but this is 
> > $pgac_perl_version." >&5
> >
> > If TAP test requires 5.8.8, the whole build sequence should
> > follow that. Or at least ./configure --enable-tap-tests should
> > check that.
> 
> I wrote 5.8.8 because that's what we've always discussed before and I
> could honestly not imagine it mattering whether we require 10-year or
> 15-year old Perl. Especially for the TAP tests, which are new, and
> optional.
> 
> I really don't think it matters if the TAP tests use a slightly newer
> Perl. They're optional and not enabled by default. Can we just

If so, why explicitly require 5.8.8? I think it is because the
'slight' difference actually prevent the test from running.

> document this please? I didn't think a four-line docs patch to an
> optional, non-default, new test suite would require this kind of
> discussion.

My only concern is the fact that 'make check-world' runs the TAP
tests as a part if --enable-tap-tests (according to
release-9.4.sgml, but I haven't done by myself.). I completely
agree to you if it didn't run as a part of top-level 'make '.
 
> But sure, if it's easier, we can have 5.8.0 in the README. What's five
> extra years matter anyway? Hey, while we're at it, lets change Pg to
> build on Borland C and require K style!

It's seems an extreme story. And I *believe* anywhere written
that Pg requires some version of C standard.

regards,

-- 
Kyotaro Horiguchi
NTT Open Source Software Center




-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-16 Thread Craig Ringer 
On 17 November 2016 at 10:42, Craig Ringer  wrote:

> But sure, if it's easier, we can have 5.8.0 in the README. What's five
> extra years matter anyway? Hey, while we're at it, lets change Pg to
> build on Borland C and require K style!

Sorry. That was unnecessary. I should've had the sense to save that as
a draft and come back later.

In all seriousness, though, lets query the buildfarm database for Perl
versions. Let it answer.

-- 
 Craig Ringer   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-16 Thread Craig Ringer 
On 17 November 2016 at 10:31, Kyotaro HORIGUCHI
 wrote:

>
> I vote +1 to upgrading perl, but I'm not sure if all supporting
> platforms other than linux support the version of perl.
>
> Anyway ./configure is saying as the following.
>
> | *** The installed version of Perl, $PERL, is too old to use with PostgreSQL.
> | *** Perl version 5.8 or later is required, but this is $pgac_perl_version." 
> >&5
>
> If TAP test requires 5.8.8, the whole build sequence should
> follow that. Or at least ./configure --enable-tap-tests should
> check that.

I wrote 5.8.8 because that's what we've always discussed before and I
could honestly not imagine it mattering whether we require 10-year or
15-year old Perl. Especially for the TAP tests, which are new, and
optional.

I really don't think it matters if the TAP tests use a slightly newer
Perl. They're optional and not enabled by default. Can we just
document this please? I didn't think a four-line docs patch to an
optional, non-default, new test suite would require this kind of
discussion.

But sure, if it's easier, we can have 5.8.0 in the README. What's five
extra years matter anyway? Hey, while we're at it, lets change Pg to
build on Borland C and require K style!

-- 
 Craig Ringer   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-16 Thread Kyotaro HORIGUCHI 
Hello,

At Thu, 17 Nov 2016 10:00:53 +0800, Craig Ringer  wrote 
in 
> On 17 November 2016 at 00:01, Michael Paquier  
> wrote:
> > On Tue, Nov 15, 2016 at 11:32 PM, Noah Misch  wrote:
> >> On Wed, Nov 16, 2016 at 12:48:03PM +0800, Craig Ringer wrote:
> >>> --- a/src/test/perl/README
> >>> +++ b/src/test/perl/README
> >>> @@ -64,3 +64,20 @@ For available PostgreSQL-specific test methods and 
> >>> some example tests read the
> >>>  perldoc for the test modules, e.g.:
> >>>
> >>>  perldoc src/test/perl/PostgresNode.pm
> >>> +
> >>> +Required Perl
> >>> +-
> >>> +
> >>> +Tests must run on perl 5.8.8 and newer. perlbrew is a good way to obtain
> >>
> >> Tests must run on Perl 5.8.0 and newer.
> 
> Why? We've always discussed 5.8.8 before. That's already a full 10 years old.
> 
> 5.8.0 is from *2002*. Are you running any 15-year-old systems you
> can't update to a *patch release* of the same perl major?
> 
> 
> gendef.pl says it needs 5.8.0 or newer with "use 5.8.0" but that's the
> only relevant thing I can find, and it's not relevant to the TAP tests
> anyway.
> 
> BTW, here's my older approach, with a dockerfile, before I became
> aware of perlbrew:
> 
> https://www.postgresql.org/message-id/camsr+ygr6pu-guyp-ft98xwxasc9n6j-awzaqxvw_+p3rtc...@mail.gmail.com
> 
> 
> 5.8.8 is in CentOS 5.
> 
> Debian Lenny (6) has 5.14.2 Wheezy (5) has 5.10. Etch (4) has 5.8.8.
> Etch came out in early 2007. Even Sarge had 5.8.4.
> 
> Ubuntu 10.04 Lucid (old-lts) had 5.10.1-8ubuntu2 .
> 
> So unless we care about Debian 3 Sarge or source builds done more than
> 10 years ago, 5.8.8 is more than good enough.

I vote +1 to upgrading perl, but I'm not sure if all supporting
platforms other than linux support the version of perl.

Anyway ./configure is saying as the following.

| *** The installed version of Perl, $PERL, is too old to use with PostgreSQL.
| *** Perl version 5.8 or later is required, but this is $pgac_perl_version." 
>&5

If TAP test requires 5.8.8, the whole build sequence should
follow that. Or at least ./configure --enable-tap-tests should
check that.

regards,

-- 
Kyotaro Horiguchi
NTT Open Source Software Center




-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-16 Thread Craig Ringer 
On 17 November 2016 at 00:01, Michael Paquier  wrote:
> On Tue, Nov 15, 2016 at 11:32 PM, Noah Misch  wrote:
>> On Wed, Nov 16, 2016 at 12:48:03PM +0800, Craig Ringer wrote:
>>> --- a/src/test/perl/README
>>> +++ b/src/test/perl/README
>>> @@ -64,3 +64,20 @@ For available PostgreSQL-specific test methods and some 
>>> example tests read the
>>>  perldoc for the test modules, e.g.:
>>>
>>>  perldoc src/test/perl/PostgresNode.pm
>>> +
>>> +Required Perl
>>> +-
>>> +
>>> +Tests must run on perl 5.8.8 and newer. perlbrew is a good way to obtain
>>
>> Tests must run on Perl 5.8.0 and newer.

Why? We've always discussed 5.8.8 before. That's already a full 10 years old.

5.8.0 is from *2002*. Are you running any 15-year-old systems you
can't update to a *patch release* of the same perl major?


gendef.pl says it needs 5.8.0 or newer with "use 5.8.0" but that's the
only relevant thing I can find, and it's not relevant to the TAP tests
anyway.

BTW, here's my older approach, with a dockerfile, before I became
aware of perlbrew:

https://www.postgresql.org/message-id/camsr+ygr6pu-guyp-ft98xwxasc9n6j-awzaqxvw_+p3rtc...@mail.gmail.com


5.8.8 is in CentOS 5.

Debian Lenny (6) has 5.14.2 Wheezy (5) has 5.10. Etch (4) has 5.8.8.
Etch came out in early 2007. Even Sarge had 5.8.4.

Ubuntu 10.04 Lucid (old-lts) had 5.10.1-8ubuntu2 .

So unless we care about Debian 3 Sarge or source builds done more than
10 years ago, 5.8.8 is more than good enough.

-- 
 Craig Ringer   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-16 Thread Michael Paquier 
On Tue, Nov 15, 2016 at 11:32 PM, Noah Misch  wrote:
> On Wed, Nov 16, 2016 at 12:48:03PM +0800, Craig Ringer wrote:
>> --- a/src/test/perl/README
>> +++ b/src/test/perl/README
>> @@ -64,3 +64,20 @@ For available PostgreSQL-specific test methods and some 
>> example tests read the
>>  perldoc for the test modules, e.g.:
>>
>>  perldoc src/test/perl/PostgresNode.pm
>> +
>> +Required Perl
>> +-
>> +
>> +Tests must run on perl 5.8.8 and newer. perlbrew is a good way to obtain
>
> Tests must run on Perl 5.8.0 and newer.

Hm? I thought that 5.8.8 was the minimum supported by recalling the
precious discussions. That's as well the oldest version of perldoc,
which is kind of useful. Anyway it would be nice to mention the
minimum requirements directly in src/test/perl/README?
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-15 Thread Noah Misch 
On Wed, Nov 16, 2016 at 12:48:03PM +0800, Craig Ringer wrote:
> --- a/src/test/perl/README
> +++ b/src/test/perl/README
> @@ -64,3 +64,20 @@ For available PostgreSQL-specific test methods and some 
> example tests read the
>  perldoc for the test modules, e.g.:
>  
>  perldoc src/test/perl/PostgresNode.pm
> +
> +Required Perl
> +-
> +
> +Tests must run on perl 5.8.8 and newer. perlbrew is a good way to obtain

Tests must run on Perl 5.8.0 and newer.


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-15 Thread Craig Ringer 
I found it a real pain to set up Perl 5.8.8 to re-check recent TAP
changes against it. It turns out there's a much easier way than
messing with VMs or manually doing a source install, so I documented
it to save others the future pain.

It'd be nice to commit this at least to 9.6 and v10. Trivial one-file
docs patch. There's no README to patch in 9.4 or 9.5.

-- 
 Craig Ringer   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services
From 4ea6e7bff66ac2026bbca130bd036618b4012c35 Mon Sep 17 00:00:00 2001
From: Craig Ringer 
Date: Tue, 15 Nov 2016 15:45:41 +0800
Subject: [PATCH] Document that perl 5.8.8 is required

---
 src/test/perl/README | 17 +
 1 file changed, 17 insertions(+)

diff --git a/src/test/perl/README b/src/test/perl/README
index cfb45a1..f15e4f0 100644
--- a/src/test/perl/README
+++ b/src/test/perl/README
@@ -64,3 +64,20 @@ For available PostgreSQL-specific test methods and some example tests read the
 perldoc for the test modules, e.g.:
 
 perldoc src/test/perl/PostgresNode.pm
+
+Required Perl
+-
+
+Tests must run on perl 5.8.8 and newer. perlbrew is a good way to obtain
+such a Perl; see https://metacpan.org/pod/distribution/App-perlbrew/bin/perlbrew .
+Just install and
+
+perlbrew --force install 5.8.8
+perlbrew use 5.8.8
+perlbrew install-cpanm
+cpanm install IPC::Run
+
+then re-run configure to ensure the correct Perl is used when running tests. To verify
+that the right Perl was found:
+
+grep ^PERL= config.log
-- 
2.5.5


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers