Re: [HACKERS] New functions

2015-09-08 Thread Alvaro Herrera
Michael Paquier wrote: > On Tue, Sep 8, 2015 at 9:32 AM, Alvaro Herrera wrote: > > Michael Paquier wrote: > > I made a couple extra cleanups to the patch, namely: do not call > > CreateTemplateTupleDesc() just to discard the resulting tupdesc with a > > subsequent get_call_result_type(); and do not

Re: [HACKERS] New functions

2015-09-08 Thread Michael Paquier
On Tue, Sep 8, 2015 at 9:32 AM, Alvaro Herrera wrote: > Michael Paquier wrote: > I made a couple extra cleanups to the patch, namely: do not call > CreateTemplateTupleDesc() just to discard the resulting tupdesc with a > subsequent get_call_result_type(); and do not write a \0 to the > BIO_s_mem, a

Re: [HACKERS] New functions

2015-09-07 Thread Alvaro Herrera
Michael Paquier wrote: > Note for committers: attached is a small script that will generate a > client certificate with extensions enabled. This is helpful when > testing this patch. Once created, then simply connect with something > like this connection string: > "host=127.0.0.1 sslmode=verify-fu

Re: [HACKERS] New functions

2015-09-07 Thread Michael Paquier
On Tue, Sep 8, 2015 at 7:31 AM, Alvaro Herrera wrote: > Michael Paquier wrote: >> On Sun, Aug 23, 2015 at 10:21 PM, Michael Paquier wrote: >> > By the way, perhaps it would be worth doing similar things for the >> > other calls of BIO_free and BIO_new, no? I have attached a second >> > patch. >> >

Re: [HACKERS] New functions

2015-09-07 Thread Alvaro Herrera
Michael Paquier wrote: > On Sun, Aug 23, 2015 at 10:21 PM, Michael Paquier wrote: > > By the way, perhaps it would be worth doing similar things for the > > other calls of BIO_free and BIO_new, no? I have attached a second > > patch. > > And... This second patch had a stupid mistake making for exa

Re: [HACKERS] New functions

2015-08-23 Thread Michael Paquier
On Sun, Aug 23, 2015 at 10:21 PM, Michael Paquier wrote: > By the way, perhaps it would be worth doing similar things for the > other calls of BIO_free and BIO_new, no? I have attached a second > patch. And... This second patch had a stupid mistake making for example ssl_client_dn() fail, so here

Re: [HACKERS] New functions

2015-08-23 Thread Michael Paquier
On Sat, Aug 22, 2015 at 11:24 PM, Heikki Linnakangas wrote: > On 07/08/2015 01:15 PM, Дмитрий Воронин wrote: >> >> 07.07.2015, 18:34, "Michael Paquier" : >> >>> Speaking of which, I have rewritten the patch as attached. This looks >>> way cleaner than the previous version submitted. Dmitry, do

Re: [HACKERS] New functions

2015-08-22 Thread Heikki Linnakangas
On 07/08/2015 01:15 PM, Дмитрий Воронин wrote: 07.07.2015, 18:34, "Michael Paquier" : Speaking of which, I have rewritten the patch as attached. This looks way cleaner than the previous version submitted. Dmitry, does that look fine for you? I am switching this patch as "Waiting on Auth

Re: [HACKERS] New functions

2015-07-26 Thread Michael Paquier
On Wed, Jul 8, 2015 at 10:18 PM, Michael Paquier wrote: > > On Wed, Jul 8, 2015 at 9:15 PM, Дмитрий Воронин > wrote: > > > > > > 07.07.2015, 18:34, "Michael Paquier" : > > > >> Speaking of which, I have rewritten the patch as attached. This looks > >> way cleaner than the previous version submi

Re: [HACKERS] New functions

2015-07-08 Thread Michael Paquier
On Wed, Jul 8, 2015 at 9:15 PM, Дмитрий Воронин wrote: > > > 07.07.2015, 18:34, "Michael Paquier" : > >> Speaking of which, I have rewritten the patch as attached. This looks >> way cleaner than the previous version submitted. Dmitry, does that >> look fine for you? >> I am switching this patc

Re: [HACKERS] New functions

2015-07-08 Thread Дмитрий Воронин
07.07.2015, 18:34, "Michael Paquier" : >  Speaking of which, I have rewritten the patch as attached. This looks >  way cleaner than the previous version submitted. Dmitry, does that >  look fine for you? >  I am switching this patch as "Waiting on Author". >  Regards, >  -- >  Michael Michael,

Re: [HACKERS] New functions

2015-07-07 Thread Michael Paquier
On Mon, Mar 23, 2015 at 12:46 PM, Michael Paquier wrote: > On Mon, Mar 23, 2015 at 1:48 AM, Воронин Дмитрий > wrote: >> >>> Please, attach new version of my patch to commitfest page. >> >> Michael, I found a way to attach patch. sorry to trouble. > > Cool. Thanks. I am seeing your patch entry he

Re: [HACKERS] New functions

2015-07-07 Thread Michael Paquier
On Mon, Mar 23, 2015 at 12:46 PM, Michael Paquier wrote: > On Mon, Mar 23, 2015 at 1:48 AM, Воронин Дмитрий > wrote: >> >>> Please, attach new version of my patch to commitfest page. >> >> Michael, I found a way to attach patch. sorry to trouble. > > Cool. Thanks. I am seeing your patch entry he

Re: [HACKERS] New functions

2015-03-22 Thread Michael Paquier
On Mon, Mar 23, 2015 at 1:48 AM, Воронин Дмитрий wrote: > >> Please, attach new version of my patch to commitfest page. > > Michael, I found a way to attach patch. sorry to trouble. Cool. Thanks. I am seeing your patch entry here: https://commitfest.postgresql.org/5/192/ I'll try to take a look

Re: [HACKERS] New functions

2015-03-22 Thread Воронин Дмитрий
>  Please, attach new version of my patch to commitfest page. Micheal, I found a way to attach patch. sorry to trouble. --  Best regards, Dmitry Voronin -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpre

Re: [HACKERS] New functions

2015-03-22 Thread Dmitry Voronin
Hello, Michael. Please, attach new version of my patch to commitfest page. --  Best regards, Dmitry Voronin *** /dev/null --- b/contrib/sslinfo/sslinfo--1.0--1.1.sql *** *** 0 --- 1,21 + /* contrib/sslinfo/sslinfo--1.0--1.1.sql */ + + -- complain if script is sourced in psq

Re: [HACKERS] New functions

2015-03-09 Thread Michael Paquier
On Tue, Mar 10, 2015 at 7:24 AM, Andreas Karlsson wrote: > On 03/08/2015 08:14 PM, Dmitry Voronin wrote: >> >> What do you think about it? > > > Nice to see you back working on the patch. > > For reviewers: the previous discussion and review of the patch can be found > at http://www.postgresql.org

Re: [HACKERS] New functions

2015-03-09 Thread Andreas Karlsson
On 03/08/2015 08:14 PM, Dmitry Voronin wrote: What do you think about it? Nice to see you back working on the patch. For reviewers: the previous discussion and review of the patch can be found at http://www.postgresql.org/message-id/53a88911.6060...@proxel.se. -- Andreas Karlsson -- Sent

Re: [HACKERS] New functions

2015-03-09 Thread Воронин Дмитрий
You're right. I changed: - at sslinfo.contol return default module version to '1.0'; - function get_extension() returns now boolean (true, if we found extension, and false otherwise).09.03.2015, 16:43, "Alvaro Herrera" : Dmitry Voronin wrote:  Hello,  I make an a patch, wh

Re: [HACKERS] New functions

2015-03-09 Thread Alvaro Herrera
Dmitry Voronin wrote: > Hello, > I make an a patch, which adds 4 functions to sslinfo extension > module:1) ssl_extension_names() --- get short names of X509v3 > extensions from client certificate and it's values; > 2) ssl_extension_value(text) --- get value of extension from certificate > (argu

Re: [HACKERS] New functions

2015-03-08 Thread Воронин Дмитрий
Sorry, 3 functions. 08.03.2015, 22:16, "Dmitry Voronin" : > Hello, > > I make an a patch, which adds 4 functions to sslinfo extension module: > 1) ssl_extension_names() --- get short names of X509v3 extensions from client > certificate and it's values; 2) ssl_extension_value(text) --- get value o

Re: [HACKERS] New functions in sslinfo module

2014-07-18 Thread Michael Paquier
On Fri, Jul 18, 2014 at 3:12 PM, Воронин Дмитрий wrote: > I make a new version of patch. I corrected your notes for my previous > version of patch. Could you test it? Thank you. I just had a look at the new version of this patch, and this is lacking a couple of things. First, this patch has been

Re: [HACKERS] New functions in sslinfo module

2014-07-17 Thread Воронин Дмитрий
Hello, Andreas and others!I make a new version of patch. I corrected your notes for my previous version of patch. Could you test it? Thank you.03.07.2014, 01:54, "Andreas Karlsson" : On 07/02/2014 02:17 PM, Воронин Дмитрий wrote:  I apologize, that I am writing this message today

Re: [HACKERS] New functions in sslinfo module

2014-07-02 Thread Andreas Karlsson
On 07/02/2014 02:17 PM, Воронин Дмитрий wrote: I apologize, that I am writing this message today. Thank you for testing my patch! You are welcome! I will modify functions ssl_extensions(), that it returns a set (key, value). Could you get me an example of code those function? You can look a

Re: [HACKERS] New functions in sslinfo module

2014-07-02 Thread Michael Paquier
On Wed, Jul 2, 2014 at 9:19 PM, Воронин Дмитрий wrote: > > Oh, how can I write a documentation for my functions? You will need to edit the sgml documentation and to include the diffs in your patch. Hence in your case simply list the new functions and a description of what they do in doc/src/sgml/

Re: [HACKERS] New functions in sslinfo module

2014-07-02 Thread Воронин Дмитрий
Oh, how can I write a documentation for my functions? 02.07.2014, 16:17, "Воронин Дмитрий" : > 24.06.2014, 00:07, "Andreas Karlsson" : >>  On 04/21/2014 07:51 AM, Воронин Дмитрий wrote: >>>   I put patch generated on git diffs to this letter. I make an a thread in >>>   postgresql commit fest: >>>

Re: [HACKERS] New functions in sslinfo module

2014-07-02 Thread Воронин Дмитрий
24.06.2014, 00:07, "Andreas Karlsson" : On 04/21/2014 07:51 AM, Воронин Дмитрий wrote:  I put patch generated on git diffs to this letter. I make an a thread in  postgresql commit fest:  https://commitfest.postgresql.org/action/patch_view?id=1438 Thanks for the patch, it seems li

Re: [HACKERS] New functions in sslinfo module

2014-06-23 Thread Andreas Karlsson
On 04/21/2014 07:51 AM, Воронин Дмитрий wrote: I put patch generated on git diffs to this letter. I make an a thread in postgresql commit fest: https://commitfest.postgresql.org/action/patch_view?id=1438 Thanks for the patch, it seems like a useful feature. === General === - Applies cleanly t

Re: [HACKERS] New functions for sslinfo extension

2014-04-21 Thread Dmitry Voronin
Hello, I make an a patch, which adds 4 functions to sslinfo extension module.  You can view some information of certificate's extensions with those functions. The descriptions of functions I posted in my first letter and in source code. What do you think about it? -- Best regards, Dmitry Voronin --

Re: [HACKERS] New functions in sslinfo module

2014-04-20 Thread Michael Paquier
On Mon, Apr 21, 2014 at 2:51 PM, Воронин Дмитрий wrote: > I put patch generated on git diffs to this letter. I make an a thread in > postgresql commit fest: > https://commitfest.postgresql.org/action/patch_view?id=1438 > Thanks! -- Michael

Re: [HACKERS] New functions in sslinfo module

2014-04-20 Thread Воронин Дмитрий
I put patch generated on git diffs to this letter. I make an a thread in postgresql commit fest: https://commitfest.postgresql.org/action/patch_view?id=1438 21.04.2014, 09:12, "Michael Paquier" :On Mon, Apr 21, 2014 at 1:48 PM, Воронин Дмитрий wrote:> Hello,>  > I make an

Re: [HACKERS] New functions in sslinfo module

2014-04-20 Thread Michael Paquier
On Mon, Apr 21, 2014 at 1:48 PM, Воронин Дмитрий wrote: > Hello, > > I make an a patch, which adds 4 functions to sslinfo extension module: > 1) ssl_get_count_of_extensions() --- get count of X509v3 extensions from > client certificate; > 2) ssl_get_extension_names() --- get short names of X509v3

Re: [HACKERS] New functions for sslinfo extension

2014-04-16 Thread Michael Paquier
Hi, On Thu, Apr 17, 2014 at 3:30 AM, Воронин Дмитрий wrote: > I want to present some functions to sslinfo extension module: > 1) ssl_get_count_of_extensions() --- get count of X509v3 extensions from > client certificate; > 2) ssl_get_extension_names() --- get short names of X509v3 extensions from