Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2014-02-15 Thread Peter Eisentraut
On 2/9/14, 11:16 PM, Haribabu Kommi wrote: > I also felt a lot of work for little benefit but as of now I am not able > to find an easier solution to handle this problem. > can we handle the same later if it really requires? I think we leave everything as is. -- Sent via pgsql-hackers mailing

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2014-02-09 Thread Haribabu Kommi
On Sat, Feb 8, 2014 at 12:10 PM, Peter Eisentraut wrote: > On 1/29/14, 7:37 PM, Haribabu Kommi wrote: > > > > On Tue, Jan 28, 2014 at 1:17 PM, Peter Eisentraut wrote: > > > > On 11/30/13, 6:59 AM, Haribabu kommi wrote: > > > To detect provided data and xlog directories are same or not, I

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2014-02-07 Thread Peter Eisentraut
On 1/29/14, 7:37 PM, Haribabu Kommi wrote: > > On Tue, Jan 28, 2014 at 1:17 PM, Peter Eisentraut wrote: > > On 11/30/13, 6:59 AM, Haribabu kommi wrote: > > To detect provided data and xlog directories are same or not, I > reused the > > Existing make_absolute_path() code as follow

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2014-01-31 Thread Fujii Masao
On Thu, Jan 30, 2014 at 9:37 AM, Haribabu Kommi wrote: > > On Tue, Jan 28, 2014 at 1:17 PM, Peter Eisentraut wrote: >> >> On 11/30/13, 6:59 AM, Haribabu kommi wrote: >> > To detect provided data and xlog directories are same or not, I reused >> > the >> > Existing make_absolute_path() code as foll

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2014-01-29 Thread Haribabu Kommi
On Tue, Jan 28, 2014 at 1:17 PM, Peter Eisentraut wrote: > On 11/30/13, 6:59 AM, Haribabu kommi wrote: > > To detect provided data and xlog directories are same or not, I reused > the > > Existing make_absolute_path() code as follows. > > I note that initdb does not detect whether the data and xlo

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2014-01-27 Thread Peter Eisentraut
On 11/30/13, 6:59 AM, Haribabu kommi wrote: > To detect provided data and xlog directories are same or not, I reused the > Existing make_absolute_path() code as follows. I note that initdb does not detect whether the data and xlog directories are the same. I think there is no point in addressing

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-12-20 Thread Alvaro Herrera
Haribabu kommi escribió: > From the compilation I observed as libpgcommon is linking while building ecpg. > I tested the same by using psprintf directly in ecpg code. > > I modified the libecpg's Makefile as suggested by you which is attached in > the mail, > Still the errors are occurring. Plea

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-12-20 Thread Haribabu kommi
On 20 December 2013 02:02 Bruce Momjian wrote: > On Thu, Dec 19, 2013 at 05:14:50AM +, Haribabu kommi wrote: > > On 19 December 2013 05:31 Bruce Momjian wrote: > > > On Wed, Dec 11, 2013 at 10:22:32AM +, Haribabu kommi wrote: > > > > The make_absolute_path() function moving to port is chang

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-12-19 Thread Bruce Momjian
On Thu, Dec 19, 2013 at 05:14:50AM +, Haribabu kommi wrote: > On 19 December 2013 05:31 Bruce Momjian wrote: > > On Wed, Dec 11, 2013 at 10:22:32AM +, Haribabu kommi wrote: > > > The make_absolute_path() function moving to port is changed in > > similar > > > way as Bruce Momjian approach.

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-12-18 Thread Haribabu kommi
On 19 December 2013 05:31 Bruce Momjian wrote: > On Wed, Dec 11, 2013 at 10:22:32AM +, Haribabu kommi wrote: > > The make_absolute_path() function moving to port is changed in > similar > > way as Bruce Momjian approach. The psprintf is used to store the > error > > string which Occurred in the

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-12-18 Thread Bruce Momjian
On Wed, Dec 11, 2013 at 10:22:32AM +, Haribabu kommi wrote: > The make_absolute_path() function moving to port is changed in similar way as > Bruce Momjian approach. The psprintf is used to store the error string which > Occurred in the function. But psprintf is not used for storing the absolut

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-12-11 Thread Haribabu kommi
On 10 December 2013 19:55 Alvaro Herrera wrote: > Haribabu kommi escribió: > > > To detect provided data and xlog directories are same or not, I > reused > > the Existing make_absolute_path() code as follows. > > > > 1. Moved the make_absolute_path() function from miscinit.c to path.c > > and Chan

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-12-10 Thread Alvaro Herrera
Haribabu kommi escribió: > To detect provided data and xlog directories are same or not, I reused the > Existing make_absolute_path() code as follows. > > 1. Moved the make_absolute_path() function from miscinit.c to path.c and > Changed all error reporting functions. And also it returns NULL inc

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-30 Thread Haribabu kommi
On 27 November 2013 10:35 Fujii Masao wrote: > On Wed, Nov 27, 2013 at 1:27 PM, Haribabu kommi > wrote: > > On 26 November 2013 23:11 Fujii Masao wrote: > >> On Wed, Nov 20, 2013 at 7:43 PM, Haribabu kommi > >> wrote: > >> > I tried using of stat'ing in two directories, which is having a > >> pro

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-28 Thread Haribabu kommi
On 27 November 2013 10:35 Fujii Masao wrote: > On Wed, Nov 27, 2013 at 1:27 PM, Haribabu kommi > wrote: > > On 26 November 2013 23:11 Fujii Masao wrote: > >> On Wed, Nov 20, 2013 at 7:43 PM, Haribabu kommi > >> wrote: > >> > I tried using of stat'ing in two directories, which is having a > >> pro

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-26 Thread Fujii Masao
On Wed, Nov 27, 2013 at 1:27 PM, Haribabu kommi wrote: > On 26 November 2013 23:11 Fujii Masao wrote: >> On Wed, Nov 20, 2013 at 7:43 PM, Haribabu kommi >> wrote: >> > I tried using of stat'ing in two directories, which is having a >> problem in windows. >> > So modified old approach to detect li

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-26 Thread Haribabu kommi
On 26 November 2013 23:11 Fujii Masao wrote: > On Wed, Nov 20, 2013 at 7:43 PM, Haribabu kommi > wrote: > > I tried using of stat'ing in two directories, which is having a > problem in windows. > > So modified old approach to detect limited errors. Updated patch > attached. > > This will detect an

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-26 Thread Fujii Masao
On Wed, Nov 20, 2013 at 7:43 PM, Haribabu kommi wrote: > On 19 November 2013 19:12 Fujii Masao wrote: >> On Tue, Nov 19, 2013 at 9:14 PM, Haribabu kommi >> wrote: >> > On 18 November 2013 23:30 Fujii Masao wrote: >> >> On Tue, Nov 19, 2013 at 12:01 AM, Haribabu kommi >> >> wrote: >> >> >> >> Tha

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-20 Thread Haribabu kommi
on 20 November 2013 23:44 Gavin Flower wrote: >On 20/11/13 23:43, Haribabu kommi wrote: >>I tried using of stat'ing in two directories, which is having a problem in >>windows. >>So modified old approach to detect limited errors. Updated patch attached. >>This will detect and throw an error in t

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-20 Thread Gavin Flower
On 20/11/13 23:43, Haribabu kommi wrote: On 19 November 2013 19:12 Fujii Masao wrote: On Tue, Nov 19, 2013 at 9:14 PM, Haribabu kommi wrote: On 18 November 2013 23:30 Fujii Masao wrote: On Tue, Nov 19, 2013 at 12:01 AM, Haribabu kommi wrote: Thanks for newer version of the patch! I found t

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-20 Thread Haribabu kommi
On 19 November 2013 19:12 Fujii Masao wrote: > On Tue, Nov 19, 2013 at 9:14 PM, Haribabu kommi > wrote: > > On 18 November 2013 23:30 Fujii Masao wrote: > >> On Tue, Nov 19, 2013 at 12:01 AM, Haribabu kommi > >> wrote: > >> > >> Thanks for newer version of the patch! > >> > >> I found that the em

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-19 Thread Magnus Hagander
On Tue, Nov 19, 2013 at 2:41 PM, Fujii Masao wrote: > On Tue, Nov 19, 2013 at 9:14 PM, Haribabu kommi > wrote: > > On 18 November 2013 23:30 Fujii Masao wrote: > >> On Tue, Nov 19, 2013 at 12:01 AM, Haribabu kommi > >> wrote: > >> > On 18 November 2013 18:45 Fujii Masao wrote: > >> >> On Mon, N

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-19 Thread Tom Lane
Fujii Masao writes: > On the second thought, I'm thinking that it might be overkill to add > such not simple code for that small benefit. Yeah --- there's a limit to how much code we should expend on detecting this type of error. It's not like the case is all that plausible. One idea that I don

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-19 Thread Fujii Masao
On Tue, Nov 19, 2013 at 9:14 PM, Haribabu kommi wrote: > On 18 November 2013 23:30 Fujii Masao wrote: >> On Tue, Nov 19, 2013 at 12:01 AM, Haribabu kommi >> wrote: >> > On 18 November 2013 18:45 Fujii Masao wrote: >> >> On Mon, Nov 18, 2013 at 6:31 PM, Haribabu kommi >> >> wrote: >> >> > >> >> >

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-19 Thread Haribabu kommi
On 18 November 2013 23:30 Fujii Masao wrote: > On Tue, Nov 19, 2013 at 12:01 AM, Haribabu kommi > wrote: > > On 18 November 2013 18:45 Fujii Masao wrote: > >> On Mon, Nov 18, 2013 at 6:31 PM, Haribabu kommi > >> wrote: > >> > > >> > On 18 November 2013 11:19 Haribabu kommi wrote: > >> >> On 17 No

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-18 Thread Haribabu kommi
On 18 November 2013 23:25 Andres Freund wrote: > On 2013-11-18 15:01:42 +, Haribabu kommi wrote: > > > > /* > > + * Returns the malloced string of containing current working > directory. > > + * The caller has to take care of freeing the memory. > > + * On failure exits with error code. > > +

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-18 Thread Fujii Masao
On Tue, Nov 19, 2013 at 12:01 AM, Haribabu kommi wrote: > On 18 November 2013 18:45 Fujii Masao wrote: >> On Mon, Nov 18, 2013 at 6:31 PM, Haribabu kommi >> wrote: >> > >> > On 18 November 2013 11:19 Haribabu kommi wrote: >> >> On 17 November 2013 00:55 Fujii Masao wrote: >> >> > On Sat, Nov 16,

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-18 Thread Andres Freund
On 2013-11-18 15:01:42 +, Haribabu kommi wrote: > > /* > + * Returns the malloced string of containing current working directory. > + * The caller has to take care of freeing the memory. > + * On failure exits with error code. > + */ > +static char * > +get_current_working_dir() > +{ > +

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-18 Thread Haribabu kommi
On 18 November 2013 18:45 Fujii Masao wrote: > On Mon, Nov 18, 2013 at 6:31 PM, Haribabu kommi > wrote: > > > > On 18 November 2013 11:19 Haribabu kommi wrote: > >> On 17 November 2013 00:55 Fujii Masao wrote: > >> > On Sat, Nov 16, 2013 at 2:27 PM, Haribabu kommi > >> > wrote: > >> > > on 15 Nov

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-18 Thread Fujii Masao
On Mon, Nov 18, 2013 at 6:31 PM, Haribabu kommi wrote: > > On 18 November 2013 11:19 Haribabu kommi wrote: >> On 17 November 2013 00:55 Fujii Masao wrote: >> > On Sat, Nov 16, 2013 at 2:27 PM, Haribabu kommi >> > wrote: >> > > on 15 November 2013 17:26 Magnus Hagander wrote: >> > > >> > >>On Fri,

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-18 Thread Haribabu kommi
On 18 November 2013 11:19 Haribabu kommi wrote: > On 17 November 2013 00:55 Fujii Masao wrote: > > On Sat, Nov 16, 2013 at 2:27 PM, Haribabu kommi > > wrote: > > > on 15 November 2013 17:26 Magnus Hagander wrote: > > > > > >>On Fri, Nov 15, 2013 at 12:10 PM, Haribabu kommi > > >> wrote: > > > > >

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-17 Thread Haribabu kommi
On 17 November 2013 00:55 Fujii Masao wrote: > On Sat, Nov 16, 2013 at 2:27 PM, Haribabu kommi > wrote: > > on 15 November 2013 17:26 Magnus Hagander wrote: > > > >>On Fri, Nov 15, 2013 at 12:10 PM, Haribabu kommi > >> wrote: > > > >>On 14 November 2013 23:59 Fujii Masao wrote: > >>> On Thu, Nov 1

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-16 Thread Fujii Masao
On Sat, Nov 16, 2013 at 2:27 PM, Haribabu kommi wrote: > on 15 November 2013 17:26 Magnus Hagander wrote: > >>On Fri, Nov 15, 2013 at 12:10 PM, Haribabu kommi >> wrote: > >>On 14 November 2013 23:59 Fujii Masao wrote: >>> On Thu, Nov 14, 2013 at 9:08 PM, Haribabu kommi >>> wrote: >>> > Please fi

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-15 Thread Haribabu kommi
on 15 November 2013 17:26 Magnus Hagander wrote: >On Fri, Nov 15, 2013 at 12:10 PM, Haribabu kommi >mailto:haribabu.ko...@huawei.com>> wrote: >On 14 November 2013 23:59 Fujii Masao wrote: >> On Thu, Nov 14, 2013 at 9:08 PM, Haribabu kommi >> mailto:haribabu.ko...@huawei.com>> wrote: >> > Please fi

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-15 Thread Haribabu kommi
On 15 November 2013 17:26 Magnus Hagander wrote: On Fri, Nov 15, 2013 at 12:10 PM, Haribabu kommi mailto:haribabu.ko...@huawei.com>> wrote: On 14 November 2013 23:59 Fujii Masao wrote: > On Thu, Nov 14, 2013 at 9:08 PM, Haribabu kommi > mailto:haribabu.ko...@huawei.com>> wrote: > > Please find att

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-15 Thread Magnus Hagander
On Fri, Nov 15, 2013 at 12:10 PM, Haribabu kommi wrote: > On 14 November 2013 23:59 Fujii Masao wrote: > > On Thu, Nov 14, 2013 at 9:08 PM, Haribabu kommi > > wrote: > > > Please find attached the patch, for adding a new option for > > > pg_basebackup, to specify a different directory for pg_xlog

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-15 Thread Haribabu kommi
On 14 November 2013 23:59 Fujii Masao wrote: > On Thu, Nov 14, 2013 at 9:08 PM, Haribabu kommi > wrote: > > Please find attached the patch, for adding a new option for > > pg_basebackup, to specify a different directory for pg_xlog. > > Sounds good! Here are the review comments: > > +printf(

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-14 Thread Fujii Masao
On Thu, Nov 14, 2013 at 9:08 PM, Haribabu kommi wrote: > Please find attached the patch, for adding a new option for pg_basebackup, > to specify a different directory for pg_xlog. Sounds good! Here are the review comments: +printf(_("--xlogdir=XLOGDIR location for the transaction l