On Fri, 7 Sep 2001 17:25:19 -0400 (EDT), you wrote:
>OK, I have created pgjindent in src/tools/pgindent, and ran it over the
>current CVS. It compiles so it should be fine:
>
> ftp://candle.pha.pa.us/pub/postgresql/astyle_jdbc.tar.gz
This looks good.
Regards,
René Pijlman <[EMAIL PROTECTE
>
> On Tue, Sep 04, 2001 at 03:25:33PM -0400, Bruce Momjian wrote:
> > I must say it looks very good.
> >
> > Can people tak a look at that and see if they like it? I will work on
> > astyle to find a format that matches the main code indenting.
>
> I like it. The following results in a cl
On Thu, Sep 06, 2001 at 09:51:19AM -0700, Barry Lind wrote:
> Should the jdbc java code use the same formatting as the C code?
IMHO, yes: for consistency and because it is, at the moment, part of the
main "package".
Liam
--
Liam Stewart :: Red Hat Canada, Ltd. :: [EMAIL PROTECTED]
--
Dave,
I agree with you, and it seems that much of the existing jdbc code is
formated that way. But before starting a thread on what everybody
prefers as their java format, let me first ask the question:
Should the jdbc java code use the same formatting as the C code?
If the answer is yes, t
On Thu, 6 Sep 2001 07:06:29 -0400, you wrote:
>Public int foo(int x,int y){
> x=y;
>}
>
>Turns into
>
>Public int foo( int x, int y )
>{
> x = y;
>}
>
>
>I find this easier to read.
I agree. This is my preference as well in Java.
Regards,
René Pijlman <[EMAIL PROTECTED]>
--
-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED]] On Behalf Of Bruce Momjian
Sent: September 4, 2001 3:26 PM
To: Liam Stewart
Cc: [EMAIL PROTECTED]
Subject: Re: [JDBC] driver source code indentation
>
> I suggest that the JDBC driver adopt PostgreSQL's indentation
Well, my vote would be for a 2 space indent.
Dave
On Tue, 2001-09-04 at 16:59, Tom Lane wrote:
> Barry Lind <[EMAIL PROTECTED]> writes:
> > I am OK with the style used for the C code. However I would like the
> > following additional step done for the java code: replace all tabs with
> > spac
On Tue, Sep 04, 2001 at 04:59:20PM -0400, Tom Lane wrote:
> Barry Lind <[EMAIL PROTECTED]> writes:
> > I am OK with the style used for the C code. However I would like the
> > following additional step done for the java code: replace all tabs with
> > spaces.
>
> I disagree with this, because
On Tue, 4 Sep 2001, Bruce Momjian wrote:
> Can people tak a look at that and see if they like it? I will work on
> astyle to find a format that matches the main code indenting.
>
> If you like it, I will indent just after we go beta.
Looks great!
I only noticed two things that I sort of dislik
Barry Lind <[EMAIL PROTECTED]> writes:
> I am OK with the style used for the C code. However I would like the
> following additional step done for the java code: replace all tabs with
> spaces.
I disagree with this, because then we are *not* applying the same coding
standards in the backend a
On Tue, Sep 04, 2001 at 12:43:21PM -0700, Barry Lind wrote:
> I am OK with the style used for the C code. However I would like the
> following additional step done for the java code: replace all tabs with
> spaces.
Oh noo! Barry's stumbled over the tripwire of the Tab/Spaces flamewar
On Tue, Sep 04, 2001 at 03:25:33PM -0400, Bruce Momjian wrote:
> I must say it looks very good.
>
> Can people tak a look at that and see if they like it? I will work on
> astyle to find a format that matches the main code indenting.
I like it. The following results in a closer match to
I agree that this is needed. In fact I know Bruce wants to do something
in this area. In fact he sent out a few months ago a sample of the code
after it had been cleaned up by some tool. At the time no one seemed to
be very interested. Going forward for 7.2 I think now is the time that
som
>
> I suggest that the JDBC driver adopt PostgreSQL's indentation standards
> (see PostgreSQL developers FAQ, question 1). I see that some source
> files have used this standard, but the vast majority do not. We should
> have a standard for consistency and our own sanity if nothing else.
Glad s
I suggest that the JDBC driver adopt PostgreSQL's indentation standards
(see PostgreSQL developers FAQ, question 1). I see that some source
files have used this standard, but the vast majority do not. We should
have a standard for consistency and our own sanity if nothing else.
Liam
--
Liam S
15 matches
Mail list logo
