I attach the patch for the following TODO item.
SQL COMMAND
* Change LIMIT/OFFSET to use int8
It passes all the regression tests and supports int8.
I am waiting for your review.
Thanks
Dhanaraj
*** ./src/backend/executor/nodeLimit.c.orig Sun Jun 25 15:02:46 2006
---
I wrote:
IIRC, newer BSDen use a kernel call for this, so you should be able to
measure it on your own machine. Just tweak ps_status.c to force it to
select PS_USE_NONE instead of PS_USE_SETPROCTITLE to generate a
comparison case. I'll try it on my old HPUX box too.
On HPUX, I get a median
Umm, It is strange.. I think that you have another config.h.?
I look at much error by the reason for being realistic.
I will become on tomorrow night, since I am not in the machine
which can work now.
Regards,
Hiroshi Saito
From: Magnus Hagander
Hi Bruce-san.
It does not help me yet. He
Bruce Momjian [EMAIL PROTECTED] writes:
Tom Lane wrote:
Something that might also be interesting is an option to suppress
per-command ps_status reporting. On machines where updating ps status
takes a kernel call, there's now a pretty good argument why you might
want to turn that off and rely
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
Seeing stats_command_string with almost zero overhead is great news!
Should we remove that setting and just have it enabled all
the time?
If you don't need it, you shouldn't have to pay any overhead for it,
I think. One could make
Hi Bruce-san.
It does not help me yet. He uses VC2005.:-( It seems that
furthermore, it is still in the middle of work.
One problem is visible to the next.(win32.mak)
+ if not exist pg_config_os.h copy port\win32.h pg_config_os.h
If VC6+ is still supported, I will submit the patch
Hi!
Attached patch is required ot build with the CRT that comes with Visual
Studio 2005. Basically MS defined errcode in the headers with a typedef,
so we have to #define it out of the way.
While at it, fix a function declaration in plpython that didn't match
the implementation (volatile
Magnus Hagander [EMAIL PROTECTED] writes:
*** src/pl/plpython/plpython.c25 Jun 2006 00:18:24 - 1.83
--- src/pl/plpython/plpython.c26 Jun 2006 13:58:56 -
***
*** 10,16
--- 10,19
/* Python uses #pragma to bring in a non-default libpython on
*** src/pl/plpython/plpython.c 25 Jun 2006 00:18:24
- 1.83
--- src/pl/plpython/plpython.c 26 Jun 2006 13:58:56 -
***
*** 10,16
--- 10,19
/* Python uses #pragma to bring in a non-default
libpython on VC++ if
* _DEBUG is defined */
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
Yep, I see 8% here. I will add a patch to allow the ps display to be
turned off.
I think we'd still want a backend to set the PS display once with its
identification data (user/DB name and client address). It's just the
transient
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
Attached patch adds GUC 'update_process_title' to control ps display
updates per SQL command. Default to 'on'. GUC name OK?
This is an ugly patch. Why not *one* test of the GUC variable, inside
set_ps_display(), and no
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
If you put a contition test in set_ps_display(), the only clean way to
do this is for init_ps_display() to force update_process_title to true
before we call set_ps_display(), then reset it to its original value,
but that sounds
Christopher Kings-Lynne wrote:
TODO item done for 8.2:
* Add PQescapeIdentifier() to libpq
Someone probably needs to check this :)
Updated patch applied. Thanks.
--
Bruce Momjian [EMAIL PROTECTED]
EnterpriseDBhttp://www.enterprisedb.com
+ If your life is a hard drive,
I am confused why this patch requires libldap_r. Is there a need for
threading? Should this be contingent on whether the threading flag was
passed to configure?
---
Albe Laurenz wrote:
This patch for libpq allows you to
Modified patch attached and applied to HEAD and 8.1.X.
I restructured the loop exit, and used the symbols without the leading
underscores. I didn't see any Win32 underscore symbol usage in our
existing code.
Thanks.
-
Bruce Momjian [EMAIL PROTECTED] writes:
* Add PQescapeIdentifier() to libpq
Updated patch applied. Thanks.
Have either of you inquired into the encoding-safety of this code?
It certainly looks like no consideration was given for that.
regards, tom lane
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
* Add PQescapeIdentifier() to libpq
Updated patch applied. Thanks.
Have either of you inquired into the encoding-safety of this code?
It certainly looks like no consideration was given for that.
I thought of that but I assume we
Bruce Momjian [EMAIL PROTECTED] writes:
Tom Lane wrote:
Have either of you inquired into the encoding-safety of this code?
It certainly looks like no consideration was given for that.
I thought of that but I assume we were not accepting user-supplied
identifiers for this --- that this was
Hi Bruce-san.
Yesterday patch was inadequate
pg_backup_tar.c: In function `tarOpen':
pg_backup_tar.c:379: `S_IREAD' undeclared (first use in this function)
pg_backup_tar.c:379: (Each undeclared identifier is reported only once
pg_backup_tar.c:379: for each function it appears in.)
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
Tom Lane wrote:
Have either of you inquired into the encoding-safety of this code?
It certainly looks like no consideration was given for that.
I thought of that but I assume we were not accepting user-supplied
identifiers for
Hiroshi Saito wrote:
Hi Bruce-san.
Yesterday patch was inadequate
pg_backup_tar.c: In function `tarOpen':
pg_backup_tar.c:379: `S_IREAD' undeclared (first use in this function)
pg_backup_tar.c:379: (Each undeclared identifier is reported only once
pg_backup_tar.c:379: for each
Patch applied. Thanks.
---
Dhanaraj M wrote:
Hi
I send the appropriate patch for bug #2073. This fix disallows to change the
default sequence.
I ran the regression test and passed. The bug details are given below.
Christopher Kings-Lynne [EMAIL PROTECTED] writes:
Yes, phpPgAdmin sure would. I imagine this would be a nightmare to
address properly, so perhaps we should remove the function :(
Well, it's fixable, cf PQescapeStringConn, but we should fix it *before*
it gets into the field not after.
Patch applied. Thanks.
---
Greg Stark wrote:
Fixed previous patch by calling change_varattnos_of_a_node() to fix up
constraint expressions in case attribute positions don't line up.
change_varattnos_of_a_node is in
24 matches
Mail list logo
