Re: [PATCHES] Enums patch v2

2007-02-01 Thread Bruce Momjian
Where are we on this? --- Tom Dunstan wrote: > Hi all > > Here is an updated version of the enums patch. It has been brought up to > date and applies against current CVS HEAD. The original email is at [1], > and describes

Re: [PATCHES] [HACKERS] writing new regexp functions

2007-02-01 Thread Jeremy Drake
On Thu, 1 Feb 2007, Jeremy Drake wrote: > On Thu, 1 Feb 2007, Tom Lane wrote: > > > Jeremy Drake <[EMAIL PROTECTED]> writes: > > > Is there some specific reason that these functions are static, > > > > Yeah: not cluttering the global namespace. > > > Is there a reason for not putting your new code

[PATCHES] Error correction for n_dead_tuples

2007-02-01 Thread ITAGAKI Takahiro
Here is a patch discussed in http://archives.postgresql.org/pgsql-hackers/2007-02/msg00010.php Concurrent vacuum will save n_dead_tuples value at the beginning. Stats collector will be subtract the value from n_dead_tuples instead of setting it to zero. The statistics accuracy of n_dead_tuples wil

Re: [HACKERS] [PATCHES] Full page writes improvement

2007-02-01 Thread Koichi Suzuki
Tom Lane wrote: > Koichi Suzuki <[EMAIL PROTECTED]> writes: >> Tom Lane wrote: >>> Doesn't this break crash recovery on PITR slaves? > >> Compressed archive log contains the same data as full_page_writes off >> case. So the influence to PITR slaves is the same as full_page_writes off. > > Right

Re: [HACKERS] [PATCHES] Full page writes improvement

2007-02-01 Thread Tom Lane
Koichi Suzuki <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> Doesn't this break crash recovery on PITR slaves? > Compressed archive log contains the same data as full_page_writes off > case. So the influence to PITR slaves is the same as full_page_writes off. Right. So what is the use-case f

Re: [HACKERS] [PATCHES] Full page writes improvement

2007-02-01 Thread Koichi Suzuki
Tom Lane wrote: > Koichi Suzuki <[EMAIL PROTECTED]> writes: >> Here's an idea and a patch for full page writes improvement. > >> Idea: >> (1) keep full page writes for ordinary WAL, make them available during >> the crash recovery, -> recovery from inconsistent pages which can be >> made at the cr

Re: [PATCHES] [pgsql-patches] Fixed shared_preload_libraries on Win32

2007-02-01 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- [E

Re: [PATCHES] Full page writes improvement

2007-02-01 Thread Tom Lane
Koichi Suzuki <[EMAIL PROTECTED]> writes: > Here's an idea and a patch for full page writes improvement. > Idea: > (1) keep full page writes for ordinary WAL, make them available during > the crash recovery, -> recovery from inconsistent pages which can be > made at the crash, > (2) Remove them fr

Re: [PATCHES] pg_standby

2007-02-01 Thread Doug Knight
Hi Simon, Quick question on the -w option; setting it to zero "disables", do you mean it waits until the file appears or a trigger file appears, or it just doesn't wait at all? Doug Knight WSI Inc Andover, MA On Mon, 2007-01-22 at 13:06 +, Simon Riggs wrote: > On Wed, 2007-01-17 at 16:15 +000

Re: [PATCHES] [pgsql-patches] Recalculating OldestXmin in a long-running vacuum

2007-02-01 Thread Bruce Momjian
Tom Lane wrote: > Heikki Linnakangas <[EMAIL PROTECTED]> writes: > > I have two runs of DBT-2, one with the patch and one without. > > > Patched: > > > autovac "public.stock" scans:1 pages:1285990(-0) > > tuples:25303056(-2671265) CPU 95.22s/38.02u sec elapsed 10351.17 sec > > > Unpatched: > >

Re: [PATCHES] [pgsql-patches] Patch to avoid gprofprofilingoverwrites

2007-02-01 Thread Bruce Momjian
[EMAIL PROTECTED] wrote: > > >> What about a "--enable-gprof" (or "--enable-profiling"?) configure > > >> flag? This could add the appropriate compiler flags to CFLAGS, enable > > >> LINUX_PROFILE if on Linux, and enable the "gprof/pid" mkdir(). > > > > > That would really only work for GCC, would

Re: [PATCHES] [pgsql-patches] Recalculating OldestXmin in a long-running vacuum

2007-02-01 Thread Tom Lane
Heikki Linnakangas <[EMAIL PROTECTED]> writes: > I have two runs of DBT-2, one with the patch and one without. > Patched: > autovac "public.stock" scans:1 pages:1285990(-0) > tuples:25303056(-2671265) CPU 95.22s/38.02u sec elapsed 10351.17 sec > Unpatched: > autovac "public.stock" scans:1 page

Re: [PATCHES] [pgsql-patches] Recalculating OldestXmin in a long-running vacuum

2007-02-01 Thread Heikki Linnakangas
Bruce Momjian wrote: Have you gotten performance numbers on this yet? I have two runs of DBT-2, one with the patch and one without. Patched: autovac "public.stock" scans:1 pages:1285990(-0) tuples:25303056(-2671265) CPU 95.22s/38.02u sec elapsed 10351.17 sec Unpatched: autovac "public.sto

Re: [PATCHES] [pgsql-patches] Patch to avoid gprofprofilingoverwrites

2007-02-01 Thread korryd
> >> What about a "--enable-gprof" (or "--enable-profiling"?) configure > >> flag? This could add the appropriate compiler flags to CFLAGS, enable > >> LINUX_PROFILE if on Linux, and enable the "gprof/pid" mkdir(). > > > That would really only work for GCC, wouldn't it? > > Well, yeah, but that's

Re: [PATCHES] [pgsql-patches] Patch to avoid gprof profilingoverwrites

2007-02-01 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > Neil Conway wrote: >> What about a "--enable-gprof" (or "--enable-profiling"?) configure >> flag? This could add the appropriate compiler flags to CFLAGS, enable >> LINUX_PROFILE if on Linux, and enable the "gprof/pid" mkdir(). > That would really onl

Re: [PATCHES] [pgsql-patches] Patch to avoid gprofprofilingoverwrites

2007-02-01 Thread korryd
> > Right - but LINUX_PROFILE was added to correct Linux specific oddities > > with the time counter accumulation, whereas your patch is not Linux > > specific at all. So I think a more representative symbol is required. > > Yeah, that was my problem with the patch too. The issue that it's > ad

Re: [PATCHES] [pgsql-patches] Patch to avoid gprof profilingoverwrites

2007-02-01 Thread Peter Eisentraut
Neil Conway wrote: > What about a "--enable-gprof" (or "--enable-profiling"?) configure > flag? This could add the appropriate compiler flags to CFLAGS, enable > LINUX_PROFILE if on Linux, and enable the "gprof/pid" mkdir(). That would really only work for GCC, wouldn't it? -- Peter Eisentraut h