Re: [PATCHES] Improve shutdown during online backup

2008-04-02 Thread Albe Laurenz
Simon Riggs wrote: Few comments: * smart shutdown waits for sessions to complete, yet this just ignores smart shutdowns which is something a little different. I think we should wait for the backup to complete and then shutdown. That would be more consistent, I agree. I'll undo my changes

Re: [PATCHES] Show login privilege in psql \du command

2008-04-02 Thread Bruce Momjian
This feature is being added by another patch so this patch is no longer needed --- See the INHERIT \du thread. --- Bernd Helmle wrote: Please find attached a tiny patch which adds a Login field to the \du command,

Re: [PATCHES] Friendly help for psql

2008-04-02 Thread Greg Sabino Mullane
Index: mainloop.c === RCS file: /projects/cvsroot/pgsql/src/bin/psql/mainloop.c,v retrieving revision 1.87 diff -c -r1.87 mainloop.c *** mainloop.c 1 Jan 2008 19:45:56 - 1.87 --- mainloop.c 2 Apr 2008 12:51:36 -

Re: [PATCHES] Consistent \d commands in psql

2008-04-02 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 \df Lists all user functions \df [pattern] Lists both system and user functions matching [pattern] \df * Lists all system and user functions I don't like this for two reasons: the items returned changes based on the existence of args,

Re: [PATCHES] Consistent \d commands in psql

2008-04-02 Thread Tom Lane
Greg Sabino Mullane [EMAIL PROTECTED] writes: \df Lists all user functions \df [pattern] Lists both system and user functions matching [pattern] \df * Lists all system and user functions I don't like this for two reasons: the items returned changes based on the existence of args, rather than

Re: [PATCHES] Consistent \d commands in psql

2008-04-02 Thread Brendan Jurd
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/04/2008, Greg Sabino Mullane wrote: \df Lists all user functions \df [pattern] Lists both system and user functions matching [pattern] \df * Lists all system and user functions I don't like this for two reasons: the items returned

Re: [PATCHES] [HACKERS] POSIX shared memory support

2008-04-02 Thread Chris Marcellino
Yes, that is understandable. I'm not sure that there is a robust portable solution that doesn't involve a major rearchitecture. I'm not sure that would be worth the risk given the reward. Thanks, Chris On Apr 2, 2008, at 8:50 AM, Bruce Momjian wrote: The original patch author:

[PATCHES] Patch to add a feature to pg_standby

2008-04-02 Thread chris . johnson
When using pg_standby to remain in recovery mode on a warm standby system, if there is a need to perform other actions in coordination with recovery actions, the -x auxiliary command option implemented by this patch enables that coordination. I considered adding the ability to override the

[PATCHES] Changes to building dynamically loadable modules

2008-04-02 Thread Peter Eisentraut
The attached patch implements a few changes to how shared libraries and dynamically loadable modules are built. Foremost, it creates a solid distinction between these two types of targets based on what had already been implemented and duplicated in ad hoc ways before. Specifically, -

Re: [PATCHES] Changes to building dynamically loadable modules

2008-04-02 Thread Tom Lane
Peter Eisentraut [EMAIL PROTECTED] writes: The attached patch implements a few changes to how shared libraries and dynamically loadable modules are built. Looks like a good idea to me, though I've not read it in great detail (I hate unidiffs). regards, tom lane --

Re: [PATCHES] Patch to add a feature to pg_standby

2008-04-02 Thread Simon Riggs
On Wed, 2008-04-02 at 12:43 -0400, [EMAIL PROTECTED] wrote: Please consider incorporating this feature. Thanks, sounds very interesting. I'll have a look in more detail over next few days. -- Simon Riggs 2ndQuadrant http://www.2ndQuadrant.com -- Sent via pgsql-patches mailing list

Re: [PATCHES] Configurable Penalty Costs for Levenshtein

2008-04-02 Thread Bruce Momjian
Because of lack of reply from the author, this has been saved for the next commit-fest: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Tom Lane wrote: Volkan YAZICI [EMAIL PROTECTED] writes: I noticed

Re: [PATCHES] Consistent \d commands in psql

2008-04-02 Thread Bruce Momjian
The patch author has been given feedback, so this has been saved for the next commit-fest: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Greg Sabino Mullane wrote: [ There is text before PGP section. ]

Re: [PATCHES] actualized SQL/PSM patch

2008-04-02 Thread Bruce Momjian
The author has received feedback so this has been saved for the next commit-fest: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Pavel Stehule wrote: Hello On 01/04/2008, Tom Lane [EMAIL PROTECTED]

Re: [PATCHES] [8.4] Updated WITH clause patch (non-recursive)

2008-04-02 Thread Bruce Momjian
There is little support for adding this patch without the recursive part, so I added the URLs for this thread to the TODO list under recursive queries. --- Neil Conway wrote: Attached is an updated version of Greg Stark's

Re: [PATCHES] actualized SQL/PSM patch

2008-04-02 Thread Jonah H. Harris
On Tue, Apr 1, 2008 at 5:55 PM, Tom Lane [EMAIL PROTECTED] wrote: The fundamental problem I've got with this patch is that it adds 400K of new code (and that's just the code, not counting documentation or regression tests) that we'll have to maintain, to obtain a feature that so far as

Re: [PATCHES] psql command aliases support

2008-04-02 Thread Gregory Stark
Peter Eisentraut [EMAIL PROTECTED] writes: Am Dienstag, 1. April 2008 schrieb Tom Lane: Do we really want such a thing? Yes! The space of backslash command names is so densely populated already that it's hard to imagine creating aliases without conflicting with existing (or future)

Re: [PATCHES] Consistent \d commands in psql

2008-04-02 Thread Gregory Stark
Tom Lane [EMAIL PROTECTED] writes: Greg Sabino Mullane [EMAIL PROTECTED] writes: \df Lists all user functions \df [pattern] Lists both system and user functions matching [pattern] \df * Lists all system and user functions I don't like this for two reasons: the items returned changes based

Re: [PATCHES] actualized SQL/PSM patch

2008-04-02 Thread Joshua D. Drake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Tue, 01 Apr 2008 17:55:45 -0400 Tom Lane [EMAIL PROTECTED] wrote: Pavel Stehule [EMAIL PROTECTED] writes: I actualized sql/psm patch. This patch can be downloaded from http://www.pgsql.cz/patches/plpgpsm.diff.gz The fundamental problem

Re: [PATCHES] actualized SQL/PSM patch

2008-04-02 Thread Tom Lane
Joshua D. Drake [EMAIL PROTECTED] writes: Tom Lane [EMAIL PROTECTED] wrote: The fundamental problem I've got with this patch is that it adds 400K of new code (and that's just the code, not counting documentation or regression tests) that we'll have to maintain, to obtain a feature that so far

Re: [PATCHES] actualized SQL/PSM patch

2008-04-02 Thread Andrew Dunstan
Jonah H. Harris wrote: On Tue, Apr 1, 2008 at 5:55 PM, Tom Lane [EMAIL PROTECTED] wrote: The fundamental problem I've got with this patch is that it adds 400K of new code (and that's just the code, not counting documentation or regression tests) that we'll have to maintain, to obtain a

Re: [PATCHES] actualized SQL/PSM patch

2008-04-02 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: ... I suspect anyone wanting to migrate their existing SQL/PSM stuff to Postgres will be less than impressed by our function body as a string mechanism. Yeah, that's the other little problem with claiming standards-compliance as a reason for doing

Re: [PATCHES] actualized SQL/PSM patch

2008-04-02 Thread Joshua D. Drake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thu, 03 Apr 2008 00:57:11 -0400 Tom Lane [EMAIL PROTECTED] wrote: Joshua D. Drake [EMAIL PROTECTED] writes: Tom Lane [EMAIL PROTECTED] wrote: The fundamental problem I've got with this patch is that it adds 400K of new code (and that's just