Magnus Hagander wrote:
> > While I have applied your patch, I am now confused about
> > something. Your change was to pg_config.h.win32, which is
> > used only for WIN32_CLIENT_ONLY compiles, namely MSVC and Borland C.
> >
> > The addition was:
> >
> > /* use _snprintf and _vsnprintf */
> >
Magnus Hagander wrote:
> > > > libpq and psql also have message translation.
> > >
> > > AFAIK we don't support NLS builds with MSVC anyway. (Check
> > > pg_config.h.win32, it has no #define NLS). So I don't think
> > this is an
> > > issue.
> >
> > Um, I agree with you. Probably, Bruce san is
Hiroshi Saito wrote:
> > for messages, but libpq and psql also have message translation.
>
> The work of using port/snprintf is needed.
> and If gettext is used
> Is it desired now? It will be tonight if it becomes so.
Sorry, I only realized after I was in bed that we don't use libintl with
t
> -Original Message-
> From: Tom Lane [mailto:[EMAIL PROTECTED]
> Sent: 09 December 2005 14:33
> To: Dave Page
> Cc: Hiroshi Saito; Magnus Hagander; Bruce Momjian; PostgreSQL-patches
> Subject: Re: [PATCHES] CVS of 8.1.x MS-VC6 probrem.
>
> "Dave Pag
Dear tom san.
Thank you for suggestion.
> Yeah. I had hoped the client-only build would "just work" with the
> snprintf changes, but if not there is no time to make it work for 8.1.1.
> I would like to revisit this for 8.1.2 or 8.2, though. It would be
> good to have NLS support in the client-
"Dave Page" writes:
> As one of the people who has had the joy of maintaining this in the
> past, I wanted to drop it as you may remember but that was rejected on
> the basis that someone somewhere might want to use their own VC++ build
> over our precompiled versions for some reason.
> Now that
> -Original Message-
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED] On Behalf Of Tom Lane
> Sent: 09 December 2005 14:01
> To: Hiroshi Saito
> Cc: Magnus Hagander; Bruce Momjian; PostgreSQL-patches
> Subject: Re: [PATCHES] CVS of 8.1.x MS-VC6 probrem.
"Hiroshi Saito" <[EMAIL PROTECTED]> writes:
>> AFAIK we don't support NLS builds with MSVC anyway. (Check
>> pg_config.h.win32, it has no #define NLS). So I don't think this is an
>> issue.
> Um, I agree with you. Probably, Bruce san is also noticed.
> I thought that Bruce san suggested the evolut
> > > libpq and psql also have message translation.
> >
> > AFAIK we don't support NLS builds with MSVC anyway. (Check
> > pg_config.h.win32, it has no #define NLS). So I don't think
> this is an
> > issue.
>
> Um, I agree with you. Probably, Bruce san is also noticed.
> I thought that Bruce s
Hi Magnus.
> > libpq and psql also have message translation.
>
> AFAIK we don't support NLS builds with MSVC anyway. (Check
> pg_config.h.win32, it has no #define NLS). So I don't think this is an
> issue.
Um, I agree with you. Probably, Bruce san is also noticed.
I thought that Bruce san sugges
> While I have applied your patch, I am now confused about
> something. Your change was to pg_config.h.win32, which is
> used only for WIN32_CLIENT_ONLY compiles, namely MSVC and Borland C.
>
> The addition was:
>
> /* use _snprintf and _vsnprintf */
> #define HAVE_DECL_SNPRINTF 1
>
> for messages, but libpq and psql also have message translation.
The work of using port/snprintf is needed.
and If gettext is used
Is it desired now? It will be tonight if it becomes so.
Regards,
Hiroshi Saito
---(end of broadcast)---
TIP 1:
Dear Bruce-san.
> > #define HAVE_DECL_SNPRINTF 1
> > #define HAVE_DECL_VSNPRINTF 1
> > #define HAVE_SNPRINTF 1
> > #define HAVE_VSNPRINTF 1
> > #define USE_REPL_SNPRINTF 1
Ummm...
This causes injustice.
--
Also, if my suggested changes do not allow it to compile, please show us
the compile error message with my suggested changes. Thanks.
---
Bruce Momjian wrote:
>
> While I have applied your patch, I am now confused about so
While I have applied your patch, I am now confused about something. Your
change was to pg_config.h.win32, which is used only for
WIN32_CLIENT_ONLY compiles, namely MSVC and Borland C.
The addition was:
/* use _snprintf and _vsnprintf */
#define HAVE_DECL_SNPRINTF 1
#defin
That code was removed when *printf was fixed, and we thought it wasn't
needed anumore. Thanks for the quick report.
Patch applied to CVS HEAD and 8.1.X.
---
Hiroshi Saito wrote:
> Dear Bruce san.
>
> I reconfirmed MS-VC6
Dear Bruce san.
I reconfirmed MS-VC6. Thank you for wonderful correspondence.
However, Another problem newly occurred.
This solves the problem of snprintf and vsnprintf.
Please apply it.
Thank you.
Regards,
Hiroshi Saito--- src/include/pg_config.h.win32.orig Fri Dec 9 13:30:41 2005
+++ src/in
17 matches
Mail list logo
